From patchwork Thu Mar 7 20:12:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 159929 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7855172jad; Thu, 7 Mar 2019 12:13:09 -0800 (PST) X-Google-Smtp-Source: APXvYqwvUXK0dch1fuF0aZ3j8L+HDxZSZTF6CoaaQf/kmJLwxkP2azRCrsEOcu2ZJeMD/5FwKf1G X-Received: by 2002:a25:d0a:: with SMTP id 10mr8159093ybn.84.1551989589063; Thu, 07 Mar 2019 12:13:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551989589; cv=none; d=google.com; s=arc-20160816; b=zhsGCSbFiVnbxuM7lh8xqkkShfhqj99NQmfBikF6x0zEfoq+qM8pAsK6XV6NUmhZk6 HmSnv5oWewWnSOI6KOHKmcJ+cL9hjqr1cf4hB3l1/2gkG1jGxMoauVQJVzsu3yZuOc2J 7E2So4/NykLTxTTemPUw6dXVOIHBWMxJ3uSHChQw1xgwbdFRkASr5mdLu0WhPG/2fcRG fS93pMab/jmAQjJwytF7ZWjlaN3sAee5dHQN0HOWeZ3C/qBrPvBqNN+BCE9/DDogj+o8 AQBA24z2b+RR/oqMVZ7H2OUroDh/QWxjHx34FB7LM2YM75WpjeqNQdifYo2+VZMOSuRQ QgXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=hUIwo5oMb7uZbiT38UJGxEQTjQHyGRKs7fFvsrLbEyY=; b=vTf+AfAILsUjYRX4cts/y527uL88RzcMVz1ZAbvZRcke9JAQeEWmOG41zEcby8ECBx lNDe73yyFTvjh/HOgr+9jVCdtF1BsJBLbvEP/Ju2Ew3yLRG3fnHtpRG/3MXW9eJf8Zf6 U3C8yihFJKYDVl/2l1FMOZ7mUjhsYEL5TI3/iPyikeV59jMW3OXcqPClo7l+E/0mUFUG n9XzGQjrFvHBEf+XOL0HraLTCc9rSjm3jryLn8fISQs5ENDnTxVxa59rZlg7duo06Q9s vUSkxSgoR4pALTv8Nk3GZ6ObYYM0xZczEBXlvXPBIRIldLArRz/vd5RDH7AGyfcrjxc+ jiQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=e4jNmMIY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m7si3120245ybp.450.2019.03.07.12.13.08 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Mar 2019 12:13:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=e4jNmMIY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:59001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zO8-0006Il-J6 for patch@linaro.org; Thu, 07 Mar 2019 15:13:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zNr-0006Hw-0F for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1zNq-0001yH-Ak for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:50 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:39468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1zNq-0001xO-3B for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:50 -0500 Received: by mail-pf1-x442.google.com with SMTP id i20so12289261pfo.6 for ; Thu, 07 Mar 2019 12:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hUIwo5oMb7uZbiT38UJGxEQTjQHyGRKs7fFvsrLbEyY=; b=e4jNmMIYyd16D2oHclzMSZdXtLyg+JF92FdlO4x8tJWfdbwrg2qqzavwOjWvAyJT86 0O0a1fOkYnZazCsVTSyoZjO+B2tfSamJ/vGnKj8JjYZQnozRiWovdheILQxaLkdSqmm4 Fyxixq98yDwXQP1qOIwIcKwSd3Klpfc57I+rcbeN1qUkPtIIZTwzdKXefzy9bSAP36Hr bo2yci5GTIkgFVPX2Ws8IzuvoeARU0x/ypCFozXjO/lyhRdp/oJp9CLQLiZ3YNIhOTM9 ahHck+q08/LlaFjYEKYtGkvw/oEDe1II9Ddoy5DRVqPDKjceJjG7DW4n0ZxujK0obrL0 pH/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hUIwo5oMb7uZbiT38UJGxEQTjQHyGRKs7fFvsrLbEyY=; b=M5e04dugnbApt0uAlD/bpaFpLosH8cgxmrfwwBHMAPsenkmtWcEiuyoO1wxl3pqELO 2lTNLzAS4d7imEM0lKzwW2sH7UEsF+S7gAjv4SdCgFbCEgKQBxDH1Wkfr4ywXJzXlxdE TU2o4VyZU2V4oduZpR05XJYLJrOCpdSxfiKHXinzr5KzW8NDCgIRk0IajR8jqq495gTE TvJAheC4heTq7E9sN3E/6sSpQwjyrmTXKVY7wndYs7LUbvwQna2wtPK8oyzaKvEDROvj FCw9dKVbUU3xCaSQbP0hjcWt8H0gPy3vXuKezpI+h0zs8jww+XBSQZ3xxBsDA62iY64c Dydw== X-Gm-Message-State: APjAAAXpGMdTZeAbdcCKSM+WPJU9VW46e+XsQVxHwRHYBCVpy/lzatq0 bUG/0fRYJ+xpYjCpytOGIPQ6ABz7aUQ= X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr14211979plo.274.1551989568410; Thu, 07 Mar 2019 12:12:48 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id h126sm18567484pfc.135.2019.03.07.12.12.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 12:12:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 12:12:43 -0800 Message-Id: <20190307201244.8971-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307201244.8971-1-richard.henderson@linaro.org> References: <20190307201244.8971-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: [Qemu-devel] [PATCH 1/2] target/arm: Put system registers in "system" group X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The system group is predefined within gdb. While the spec seems to allow arbitrary group names, that seems to mess up the addition of all registers to any groups. Signed-off-by: Richard Henderson --- target/arm/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.2 diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index 0c64c0292e..67c8874b3b 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -113,7 +113,7 @@ static void arm_gen_one_xml_reg_tag(GString *s, DynamicGDBXMLInfo *dyn_xml, { g_string_append_printf(s, "name); g_string_append_printf(s, " bitsize=\"%d\"", bitsize); - g_string_append_printf(s, " group=\"cp_regs\"/>"); + g_string_append_printf(s, " group=\"system\"/>"); dyn_xml->num_cpregs++; dyn_xml->cpregs_keys[dyn_xml->num_cpregs - 1] = ri_key; } From patchwork Thu Mar 7 20:12:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 159930 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7857889jad; Thu, 7 Mar 2019 12:16:07 -0800 (PST) X-Google-Smtp-Source: APXvYqw3keYOO0ejLXkt+WsYy/MRr2jgd1anj/ash4pL9WdRiavU69fBKdrU+4RZGFFMwmIXIDRa X-Received: by 2002:a25:ba8d:: with SMTP id s13mr12794009ybg.332.1551989767685; Thu, 07 Mar 2019 12:16:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551989767; cv=none; d=google.com; s=arc-20160816; b=bKWwM62uf7g0i6aCk29+3+gl4lT4Ky1SZNnTM4Zf0/FwpTeo6gDbwfWS1fcoIiUv67 h9smOgmNt1igbpFBx7FqzLMBdxxzyveG/fBe6mQ+1XLn91/y3Juys6IolDxV+7tMwLRT H71bxvTz6+J7Jof78J4D2tf7iKSBU3GjDtsBMN//bHCnXKWslpdUVnWMMkiw2bjMEYwN 4E0XfWqLNUHt/Hhfdt57VYi48WaC48eZRt5Qx6uDFffnROK0cToI74AXsajpZ+uCemRr L7o9ESL9/UFGGy0TX8a8wqSwOSR+kVKlq+2PwL68RpHbTXHmAb9p9macDLr1BeE//XLe 5MYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=efdSzmGfbpW7WQYecr4f/sOH11ZNMvPyJ3hMSinoX5c=; b=R4XOQcUCGIlp8puL1sa1bglfc3gQdzSF1XLMDHItim9Pw38sZym53Qj5eNUT+Ttl76 Cc8Rg5XJ4DIA9UoYvzQJZqJSTG2/TA/s6JF7UEZ8dcS19tCIGXTiznSAb5g/1y1Kqv6m 49W+x2sJ280CbNJyE3iFmjcF92io5ra8c1bIykTmZb2TjHzh5ofzzRMbFYjFXRyRTfhV EExLTZqZTCfm094otvoURpn92lkqwJ+4PJuT8x8syb5oNLCo1FXTFaYMZixcaH5O+e/N OMlUokEEiRNnMw+oLepNQNBuMDxebiZjXkSNXKmmDoLjj9kqv+6mQAniSrbTCrYCYo4L vsVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=saBm9G9k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 202si3254174ywr.84.2019.03.07.12.16.07 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Mar 2019 12:16:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=saBm9G9k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:59050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zR1-0008Bg-8W for patch@linaro.org; Thu, 07 Mar 2019 15:16:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zNs-0006IA-5a for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1zNr-0001z9-J3 for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:52 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:35112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1zNr-0001yX-BX for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:51 -0500 Received: by mail-pf1-x443.google.com with SMTP id j5so12296868pfa.2 for ; Thu, 07 Mar 2019 12:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=efdSzmGfbpW7WQYecr4f/sOH11ZNMvPyJ3hMSinoX5c=; b=saBm9G9kQfPAjSDBx+xBQ4v7Um/5Iw+yU1Ys1jF4wmiLg3G3FJLRZUzxa2xwr3nvTw mWfWwwfyHXo7FY98utrxTgyJtjvlZko/xz/P8AC2yBURucokJX0XaL8VXJc851RAnRZv yPpuLA/FeTx1X3S5Xzip0HvweZTcRDBaoG1USBlKgjETUm8FSdvhNAa39odw2eacZPCm hBoMRs6NujZiaWzqtQ7zVvZ2PywuedrGrYC5uzHaOnTkikj4v8Bt1HJ4mqmohtJcirY/ /izfl/od452E36cktWqhKmzcYXss+jX++R7fWxhoeeM6hZ/vDosVbieHbrNsbLmQi8jQ wT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=efdSzmGfbpW7WQYecr4f/sOH11ZNMvPyJ3hMSinoX5c=; b=npa50rkFbIPEuK/J0+e0HNroRNlFE78nOrssoeFXRPEIY9piQbvQTdUCMKfPK1CDLZ qM2QHtWaSuS8oGeByHB8cH3AoPjdU0Z3E+Quo7xlVoidw+4g7K/xZcoA8QCwKNrDaZ/C 1xk8/0+v1vHCtdNkNxlYw5d5VTBN43cciGyCGeawf3D6A6iymu6CV1IhztJ8VH+ySiMH 5m9Cv+BwfAOUnh8fhxzTwhjC4M8p6fQqhEm9WOKa5SaMH4jVLmtp3xAelEcp3auMBILv Z6+QeCzP5rAcMb8Tvm2US7RoOV+ag1Bs4O/renUqX1Mgkfc9/J8sVbj9Lb909l/ded2A 2URw== X-Gm-Message-State: APjAAAVnoI79fH9BfsO2bcugZLozGh8/u1SVJ80YrhU/rNCbIAivvG0+ eHXwL0gJtaGS0a/aqClNmaQgU1Ffsrg= X-Received: by 2002:a65:5c01:: with SMTP id u1mr13046252pgr.197.1551989569876; Thu, 07 Mar 2019 12:12:49 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id h126sm18567484pfc.135.2019.03.07.12.12.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 12:12:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 12:12:44 -0800 Message-Id: <20190307201244.8971-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307201244.8971-1-richard.henderson@linaro.org> References: <20190307201244.8971-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH 2/2] target/arm: Don't add system-registers.xml for user-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The system registers aren't that interesting for debugging user binaries. Avoid adding them in this case. Signed-off-by: Richard Henderson --- target/arm/helper.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.17.2 diff --git a/target/arm/helper.c b/target/arm/helper.c index 2607d39ad1..ca5632d26f 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -221,6 +221,7 @@ static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri, } } +#ifndef CONFIG_USER_ONLY static int arm_gdb_get_sysreg(CPUARMState *env, uint8_t *buf, int reg) { ARMCPU *cpu = arm_env_get_cpu(env); @@ -243,6 +244,7 @@ static int arm_gdb_set_sysreg(CPUARMState *env, uint8_t *buf, int reg) { return 0; } +#endif static bool raw_accessors_invalid(const ARMCPRegInfo *ri) { @@ -6694,9 +6696,11 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) gdb_register_coprocessor(cs, vfp_gdb_get_reg, vfp_gdb_set_reg, 19, "arm-vfp.xml", 0); } +#ifndef CONFIG_USER_ONLY gdb_register_coprocessor(cs, arm_gdb_get_sysreg, arm_gdb_set_sysreg, arm_gen_dynamic_xml(cs), "system-registers.xml", 0); +#endif } /* Sort alphabetically by type name, except for "any". */