From patchwork Thu Mar 7 10:09:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159816 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7248288jad; Thu, 7 Mar 2019 02:09:55 -0800 (PST) X-Google-Smtp-Source: APXvYqx9RC355vHM6PlA6huys2PVbJc5Shp4LRmihPikS4xLidzIhtlTntx8UGr/G2MxcCR2xWrU X-Received: by 2002:a17:902:7d84:: with SMTP id a4mr12204531plm.76.1551953395778; Thu, 07 Mar 2019 02:09:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551953395; cv=none; d=google.com; s=arc-20160816; b=zvaXiazrINWPuqUtVTYip7m5KPgqGpsIVa48A4MkORkFMlzvXvfBvK3Fzbjr96ciSD asRFgr5UGh+bBsR28Zzakrzu3GLTHTGSXLV3Xa2P1+lXu+743CpqqrGjEVryS4tPsmEo 45YHzXHFDBXjNT2uA7eA3Ps/lWI6sRZQzECsw+6pxsREuqWetBiI7hF6gUevnnme/kRD a1b6X2O+Q17WPsPS5KnoOHV+OTQ6GhmUY2cUagn2kI6sinDQmQPoTMO3VmJRqHqooz1e rsxT0g/czV0dL/YOWa4zOH3Tdyt3zJMzSzofxrgYhLKaNjlBEbVugo9B+OELtGrn9fZy g5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xJZfOksZVUsqhSt7WQA4C8NwxuVSDBvcjhonCk84h6I=; b=ZwypG9goYPK3inDXKw+x+YUCY+pY+pBdUrHQFopKvMwAAMpLBJVSP4MF1N1QQSjBU6 U+TfYzkdeL2N9VWYtpW7xJL/PHAtSSn+4cPkmQJ1D04KFgFb4ncSYpkiJUnZzfrzjg0H EqoLCkWT9djqH8IqhIlQxjJDwL9IPeyIdqQXvFAPVl8MBVeW3o/DNA8g+wvWw4rjDO3x j3wuvFiHVWZwLIttZXHHLFvnhsRine0XkFbd3uy+ShoPYBb+e7N9hYOCNDACF7+Eh8TS GdWe//hSXztPtc5fJmwRFoK/ZUE8LdnV8OH80PMVqS84HiYPNI1a+NlsEGdtjEND2m9m PVPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si3927345ply.361.2019.03.07.02.09.55; Thu, 07 Mar 2019 02:09:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbfCGKJy (ORCPT + 5 others); Thu, 7 Mar 2019 05:09:54 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:47261 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfCGKJy (ORCPT ); Thu, 7 Mar 2019 05:09:54 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPA (Nemesis) id 1MDPuq-1hCFYZ1YRS-00AZ2j; Thu, 07 Mar 2019 11:09:49 +0100 From: Arnd Bergmann To: Ulf Hansson , Robert Jarzmik Cc: Nick Desaulniers , Arnd Bergmann , Daniel Mack , Linus Walleij , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: pxamci: fix enum type confusion Date: Thu, 7 Mar 2019 11:09:19 +0100 Message-Id: <20190307100948.570006-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:dLg/EnprOSV+AG5rIOUAbfhnAkCXqZLaPxorfGVq19dXI7tPAXw f9pQVKwPp07Aqn+Gzq5B17hfMRbkVeAxZYujcCjbvzdUAdKmVYmCljsn5ERFOUqnFn9n5Fy emGnbd3PGeBwnyM37xl+dwVP4R5xRi+35k+Ih2Fhoyt7O9sHMeIESmEBoE9II32Ughg0CqU pLc+DUZkyFqfboTpf74Kg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:HTPr5zcU7jQ=:fCx+jyDj+/sUC9vrD1YFUj fjbSkyTMAnJBQuEynYNoYRGHvIB831+vs08w8/s1rTa8IcXiIqCB9/hzaCzYEK6t7J5T+diPt sqmzsv+sBXTbVJrgycjM99j25BTe0K2msiQr10fVtfwSS1tVHVxKQpThR7mlf53HdRn4a9Nc6 bMWbmHbuVYG0poYnUxmJjKv7vd1f+EEjYoG6os8ljxzBCzsWen0B2EdtW3NTdmRInMnQUf3Ek bd+VSShOGdDGsIor5PItOcrfochsXXNNGui/2oM3zjZST6e7gxvOeAvbgjz2upQrBywE+46tS 0t5u6urmyLS5Lsr6kEW/Bf7Q8smNsuB2zyf1SDEtMqn+ldayOTqCT++guVaYKWrqexDoU2IDp gjSZ8HQXKF6K/YyjtysQzXBZ/mbajqtOBMSQ8joONf8HKQ0Fyhh5wlNjgrf4hXsVUHHGi6RIS zXdzOdeLSm1BEbF9hBtrNYaMOrdTqdF/mlJCE7y2FYmFLE0QaUlEatyiawd0sSKDKLfkAScb8 VUyZhPJMj0M1Ej3tw6+MIzBo/cvWdjCbabNqDYPszt2pFRkgCAAqmXlaXq0KSpI/+WmGrXbbz FdHjNIqmyKkA1OO59EWbPahEfOaSJ4kliu/J4yisjmgUBcZ3WQU0cWpJ+gZ7RzY/IpIc1UP24 moaBfvxN2ms0jTI5jHgkgDMH9hQly8l8GCmEmKWOzev3GGG5ptYB55bPWHPwV6/ZekoMV5OVW PBvOvKmn7qnr28PDXjkPFGQw038sM0fhPN1Ruw== Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org clang points out several instances of mismatched types in this drivers, all coming from a single declaration: drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] direction = DMA_DEV_TO_MEM; ~ ^~~~~~~~~~~~~~ drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion] tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction, The behavior is correct, so this must be a simply typo from dma_data_direction and dma_transfer_direction being similarly named types with a similar purpose. Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use") Signed-off-by: Arnd Bergmann --- drivers/mmc/host/pxamci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Reviewed-by: Nathan Chancellor Acked-by: Robert Jarzmik diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c907bf502a12..c1d3f0e38921 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param); static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data) { struct dma_async_tx_descriptor *tx; - enum dma_data_direction direction; + enum dma_transfer_direction direction; struct dma_slave_config config; struct dma_chan *chan; unsigned int nob = data->blocks;