From patchwork Fri Oct 28 01:35:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 619771 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1132EFA3741 for ; Fri, 28 Oct 2022 01:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235577AbiJ1Bfu (ORCPT ); Thu, 27 Oct 2022 21:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235475AbiJ1Bfu (ORCPT ); Thu, 27 Oct 2022 21:35:50 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D04098260A; Thu, 27 Oct 2022 18:35:47 -0700 (PDT) Received: from loongson.cn (unknown [10.180.13.64]) by gateway (Coremail) with SMTP id _____8AxjrfyMVtj3P0CAA--.6533S3; Fri, 28 Oct 2022 09:35:46 +0800 (CST) Received: from localhost.localdomain (unknown [10.180.13.64]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxV1fsMVtjGRcGAA--.3419S2; Fri, 28 Oct 2022 09:35:45 +0800 (CST) From: Yinbo Zhu To: "Rafael J . Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: zhanghongchen , Liu Peibao , Yinbo Zhu Subject: [PATCH v8 1/2] thermal: loongson-2: add thermal management support Date: Fri, 28 Oct 2022 09:35:31 +0800 Message-Id: <20221028013532.10361-1-zhuyinbo@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CM-TRANSID: AQAAf8BxV1fsMVtjGRcGAA--.3419S2 X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvJXoW3uw4DJw1xKr45GrWfWFykZrb_yoWDWF1rpF W3C3y5GrsrGFsrZw1DCr1UCFs0vwnIyFy3ZFZ7CwnY9rZ3J343Wry8JF18ZrWSkFyDGF15 ZrZ8KFWUCFWDX3DanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bzAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUXVWUAwA2ocxC64 kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28E F7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Cr0_Gr1UM2 8EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l 57IF6xkI12xvs2x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41l42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxFaVAv8VWrMxC20s026x CaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_ JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r 1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_ Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8Jb IYCTnIWIevJa73UjIFyTuYvjxUzgAwDUUUU Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This patch adds the support for Loongson-2 thermal sensor controller, which can support maximum 4 sensors. It's based on thermal of framework: - Trip points defined in device tree. - Cpufreq as cooling device registered in Loongson-2 cpufreq driver. - Pwm fan as cooling device registered in hwmon pwm-fan driver. Signed-off-by: zhanghongchen Signed-off-by: Yinbo Zhu --- Change in v8: 1. Replace string loongson2/Loongson2/LOONGSON2 with loongson-2/ Loongson-2/LOONGSON-2 in Kconfig and commit log and MAINTAINERS files. MAINTAINERS | 7 + drivers/thermal/Kconfig | 10 ++ drivers/thermal/Makefile | 1 + drivers/thermal/loongson2_thermal.c | 264 ++++++++++++++++++++++++++++ 4 files changed, 282 insertions(+) create mode 100644 drivers/thermal/loongson2_thermal.c diff --git a/MAINTAINERS b/MAINTAINERS index 589517372408..cb6a59213006 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11899,6 +11899,13 @@ F: drivers/*/*loongarch* F: Documentation/loongarch/ F: Documentation/translations/zh_CN/loongarch/ +LOONGSON-2 SOC SERIES THERMAL DRIVER +M: zhanghongchen +M: Yinbo Zhu +L: linux-pm@vger.kernel.org +S: Maintained +F: drivers/thermal/loongson2_thermal.c + LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) M: Sathya Prakash M: Sreekanth Reddy diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index e052dae614eb..734ba7238d96 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL If you say yes here you get support for the FAN controlled by the Microcontroller found on the Khadas VIM boards. +config LOONGSON2_THERMAL + tristate "Loongson-2 SoC series thermal driver" + depends on OF + default y + help + Support for Thermal driver found on Loongson-2 SoC series platforms. + It supports one critical trip point and one passive trip point. The + cpufreq and the pwm fan is used as the cooling device to throttle + CPUs when the passive trip is crossed. + endif diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index def8e1a0399c..e99f839126fa 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -61,3 +61,4 @@ obj-$(CONFIG_UNIPHIER_THERMAL) += uniphier_thermal.o obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o +obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o diff --git a/drivers/thermal/loongson2_thermal.c b/drivers/thermal/loongson2_thermal.c new file mode 100644 index 000000000000..082f9dd0b2a2 --- /dev/null +++ b/drivers/thermal/loongson2_thermal.c @@ -0,0 +1,264 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Author: zhanghongchen + * Yinbo Zhu + * Copyright (C) 2022-2023 Loongson Technology Corporation Limited + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include "thermal_hwmon.h" + +#define LOONGSON2_SOC_MAX_SENSOR_NUM 4 + +#define LOONGSON2_TSENSOR_CTRL_HI 0x0 +#define LOONGSON2_TSENSOR_CTRL_LO 0x8 +#define LOONGSON2_TSENSOR_STATUS 0x10 +#define LOONGSON2_TSENSOR_OUT 0x14 + +struct loongson2_thermal_data { + struct thermal_zone_device *tzd; + int irq; + int id; + void __iomem *regs; + struct platform_device *pdev; + u16 ctrl_low_val; + u16 ctrl_hi_val; +}; + +static int loongson2_thermal_set(struct loongson2_thermal_data *data, + int low, int high, bool enable) +{ + u64 reg_ctrl = 0; + int reg_off = data->id * 2; + + if (low > high) + return -EINVAL; + + low = low < -100 ? -100 : low; + high = high > 155 ? 155 : high; + + low += 100; + high += 100; + + reg_ctrl |= low; + reg_ctrl |= enable ? 0x100 : 0; + writew(reg_ctrl, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off); + + reg_ctrl = 0; + reg_ctrl |= high; + reg_ctrl |= enable ? 0x100 : 0; + writew(reg_ctrl, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off); + + return 0; +} + +static int loongson2_thermal_get_temp(void *__data, int *temp) +{ + struct loongson2_thermal_data *data = __data; + u32 reg_val; + + reg_val = readl(data->regs + LOONGSON2_TSENSOR_OUT); + *temp = ((reg_val & 0xff) - 100) * 1000; + + return 0; +} + +static int loongson2_thermal_get_sensor_id(void) +{ + int ret, id; + struct of_phandle_args sensor_specs; + struct device_node *np, *sensor_np; + + np = of_find_node_by_name(NULL, "thermal-zones"); + if (!np) + return -ENODEV; + + sensor_np = of_get_next_child(np, NULL); + ret = of_parse_phandle_with_args(sensor_np, "thermal-sensors", + "#thermal-sensor-cells", + 0, &sensor_specs); + if (ret) { + of_node_put(np); + of_node_put(sensor_np); + return ret; + } + + if (sensor_specs.args_count >= 1) { + id = sensor_specs.args[0]; + WARN(sensor_specs.args_count > 1, + "%s: too many cells in sensor specifier %d\n", + sensor_specs.np->name, sensor_specs.args_count); + } else { + id = 0; + } + + of_node_put(np); + of_node_put(sensor_np); + + return id; +} + +static irqreturn_t loongson2_thermal_alarm_irq(int irq, void *dev) +{ + struct loongson2_thermal_data *data = dev; + + /* clear interrupt */ + writeb(0x3, data->regs + LOONGSON2_TSENSOR_STATUS); + + disable_irq_nosync(irq); + + return IRQ_WAKE_THREAD; +} + +static irqreturn_t loongson2_thermal_irq_thread(int irq, void *dev) +{ + struct loongson2_thermal_data *data = dev; + + thermal_zone_device_update(data->tzd, + THERMAL_EVENT_UNSPECIFIED); + enable_irq(data->irq); + + return IRQ_HANDLED; +} + +static int loongson2_thermal_set_trips(void *data, int low, int high) +{ + return loongson2_thermal_set(data, low/1000, high/1000, true); +} + +static const struct thermal_zone_of_device_ops loongson2_of_thermal_ops = { + .get_temp = loongson2_thermal_get_temp, + .set_trips = loongson2_thermal_set_trips, +}; + +static int loongson2_thermal_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct resource *res; + struct loongson2_thermal_data *data; + int ret; + + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->pdev = pdev; + platform_set_drvdata(pdev, data); + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + data->regs = devm_ioremap(dev, res->start, resource_size(res)); + if (IS_ERR(data->regs)) + return PTR_ERR(data->regs); + + /* get irq */ + data->irq = platform_get_irq(pdev, 0); + if (data->irq < 0) + return data->irq; + + /* get id */ + data->id = loongson2_thermal_get_sensor_id(); + if (data->id > LOONGSON2_SOC_MAX_SENSOR_NUM - 1 || data->id < 0) { + dev_err(dev, "sensor id error,must be in <0 ~ %d>\n", + LOONGSON2_SOC_MAX_SENSOR_NUM - 1); + return -EINVAL; + } + + writeb(0xff, data->regs + LOONGSON2_TSENSOR_STATUS); + + loongson2_thermal_set(data, 0, 0, false); + + data->tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, + data->id, data, + &loongson2_of_thermal_ops); + if (IS_ERR(data->tzd)) { + ret = PTR_ERR(data->tzd); + data->tzd = NULL; + dev_err(&pdev->dev, "failed to register %d\n", ret); + return ret; + } + + ret = devm_request_threaded_irq(dev, data->irq, + loongson2_thermal_alarm_irq, loongson2_thermal_irq_thread, + IRQF_ONESHOT, "loongson2_thermal", data); + if (ret < 0) { + dev_err(dev, "failed to request alarm irq: %d\n", ret); + return ret; + } + + /* + * Thermal_zone doesn't enable hwmon as default, + * enable it here + */ + data->tzd->tzp->no_hwmon = false; + ret = thermal_add_hwmon_sysfs(data->tzd); + if (ret) { + dev_err(dev, "failed to add hwmon sysfs interface %d\n", ret); + return ret; + } + + return 0; +} + +static int loongson2_thermal_remove(struct platform_device *pdev) +{ + struct loongson2_thermal_data *data = platform_get_drvdata(pdev); + int reg_off = data->id * 2; + + /* disable interrupt */ + writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off); + writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off); + + return 0; +} + +static const struct of_device_id of_loongson2_thermal_match[] = { + { .compatible = "loongson,ls2k-thermal",}, + { /* end */ } +}; +MODULE_DEVICE_TABLE(of, of_loongson2_thermal_match); + +static int __maybe_unused loongson2_thermal_suspend(struct device *dev) +{ + struct loongson2_thermal_data *data = dev_get_drvdata(dev); + int reg_off = data->id * 2; + + data->ctrl_low_val = readw(data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off); + data->ctrl_hi_val = readw(data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off); + + writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off); + writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off); + + return 0; +} + +static int __maybe_unused loongson2_thermal_resume(struct device *dev) +{ + struct loongson2_thermal_data *data = dev_get_drvdata(dev); + int reg_off = data->id * 2; + + writew(data->ctrl_low_val, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off); + writew(data->ctrl_hi_val, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(loongson2_thermal_pm_ops, + loongson2_thermal_suspend, loongson2_thermal_resume); + +static struct platform_driver loongson2_thermal_driver = { + .driver = { + .name = "loongson2_thermal", + .pm = &loongson2_thermal_pm_ops, + .of_match_table = of_loongson2_thermal_match, + }, + .probe = loongson2_thermal_probe, + .remove = loongson2_thermal_remove, +}; +module_platform_driver(loongson2_thermal_driver); From patchwork Fri Oct 28 01:35:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 619963 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9163EFA3744 for ; Fri, 28 Oct 2022 01:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235695AbiJ1Bfv (ORCPT ); Thu, 27 Oct 2022 21:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233622AbiJ1Bfu (ORCPT ); Thu, 27 Oct 2022 21:35:50 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC1E489AFD; Thu, 27 Oct 2022 18:35:48 -0700 (PDT) Received: from loongson.cn (unknown [10.180.13.64]) by gateway (Coremail) with SMTP id _____8DxfbfzMVtj4P0CAA--.6415S3; Fri, 28 Oct 2022 09:35:47 +0800 (CST) Received: from localhost.localdomain (unknown [10.180.13.64]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxV1fsMVtjGRcGAA--.3419S3; Fri, 28 Oct 2022 09:35:46 +0800 (CST) From: Yinbo Zhu To: "Rafael J . Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: zhanghongchen , Liu Peibao , Yinbo Zhu , Krzysztof Kozlowski Subject: [PATCH v8 2/2] dt-bindings: thermal: add loongson-2 thermal Date: Fri, 28 Oct 2022 09:35:32 +0800 Message-Id: <20221028013532.10361-2-zhuyinbo@loongson.cn> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221028013532.10361-1-zhuyinbo@loongson.cn> References: <20221028013532.10361-1-zhuyinbo@loongson.cn> MIME-Version: 1.0 X-CM-TRANSID: AQAAf8BxV1fsMVtjGRcGAA--.3419S3 X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvJXoW7uF15Xw17Wryfuw48WFWUXFb_yoW8Kr18pF 43Cw1DCr4vkF17Zws8KFy0krs0vr9YyF9rZrs2kw15Kr98Ja4aq3y3KF1DZ3yfuF1jgFW7 uFyI9r4UCF1DJ3DanT9S1TB71UUUUUJqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bfxFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUXVWUAwA2ocxC64 kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28E F7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Cr0_Gr1UM2 8EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE 52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I 80ewAv7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCj c4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7V AKI48JMxAIw28IcVCjz48v1sIEY20_WwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8 JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBI daVFxhVjvjDU0xZFpf9x07jn73kUUUUU= Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add the Loongson-2 thermal binding with DT schema format using json-schema. Signed-off-by: Yinbo Zhu Reviewed-by: Krzysztof Kozlowski --- Change in v8: 1. Replace string Loongson2/loongson2 with Loongson-2/loongson-2. .../thermal/loongson,ls2k-thermal.yaml | 43 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml new file mode 100644 index 000000000000..c0637e2d6d57 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Thermal sensors on Loongson-2 SoCs + +maintainers: + - zhanghongchen + - Yinbo Zhu + +properties: + compatible: + const: loongson,ls2k-thermal + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + '#thermal-sensor-cells': + const: 1 + +required: + - compatible + - reg + - interrupts + - '#thermal-sensor-cells' + +additionalProperties: false + +examples: + - | + #include + thermal: thermal-sensor@1fe01500 { + compatible = "loongson,ls2k-thermal"; + reg = <0x1fe01500 0x30>; + interrupt-parent = <&liointc0>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + #thermal-sensor-cells = <1>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index cb6a59213006..6ae50b1257e9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11904,6 +11904,7 @@ M: zhanghongchen M: Yinbo Zhu L: linux-pm@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml F: drivers/thermal/loongson2_thermal.c LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)