From patchwork Mon Mar 4 19:56:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159582 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4151774jad; Mon, 4 Mar 2019 11:57:38 -0800 (PST) X-Google-Smtp-Source: AHgI3IYoTEXDP0reHOI0AfMFIpq4ucvJLIhAxkHw+90gzny85wneVp4O2ifjTxrelb+3Fn5ytmUy X-Received: by 2002:a62:b502:: with SMTP id y2mr21481238pfe.212.1551729458149; Mon, 04 Mar 2019 11:57:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551729458; cv=none; d=google.com; s=arc-20160816; b=u/m1tKGlef18H06ojBc9B/jgL/wE2u2YVfbSg1tACgEHTevwbHg67W5Gv6Ccmf4EKU nIvUkWx/+aV6zW8eqyWx+ccikSOIAqfRIzjuveMfzXioJ11d3YcoZqfle6BtaMmefUEu 0uIgg9Y4qLxUS55jHjar2pW4iwHDhX+Qx8/YCg3Yj56DL3LHzIKYkq60lS9QeaQ3tJxz t033RThKJNJ5B0OVW3sBwxR0U0DjZVENhal07mXvkqiFwCjiGPaMabGzjauF99DRP7G6 y5jz8lPO6e0bbGYhLXbHaZYurZUDaizKMtfE1GGXxdkTlhuL1jQ3ROuVVhc6u7R7ojj/ FEkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=9L1yS0mFX463KFT/2cEEwEGWoh3PviHUznFcE2SC0J0=; b=fdLXj5yeu96J6aypVarMVMPM1y+0Bz4KiCLNuFiUwKmgnRaq+wkjLWRF4q0yno46ZC qqH15pE1qFj+Ko4c3KOqvopKT0iex4vWQReA6Wlre1+exSLsAA+QN4EaoHH2lmieMpzN 2UTZ1KLidZY6H4A/Oq2cvdfkInUPPcimqdewN+ZfMRkzgEzuyoz+ouhYVOKCtSNhtok0 bwj8iStW/QkDCTvc2SlfUnuDBcSMj0ituy81JKNm7BmGGOFWSPuwWFHvEQTU/yj4Dh2S rxXN9NeOBeavxsp/tOxy2xhg5fpwymsE3zCvTorSDy2JjCwsE1dwmhxCSCuo62Ptd/3y NgOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z72si5667723pgd.296.2019.03.04.11.57.38 for ; Mon, 04 Mar 2019 11:57:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726054AbfCDT5h (ORCPT ); Mon, 4 Mar 2019 14:57:37 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:54375 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfCDT5h (ORCPT ); Mon, 4 Mar 2019 14:57:37 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1Mgvan-1hS0ri03hd-00hLZ9; Mon, 04 Mar 2019 20:57:35 +0100 From: Arnd Bergmann To: Dmitry Torokhov Cc: Arnd Bergmann , Brian Masney , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Input: msm-vibrator: use correct gpio header Date: Mon, 4 Mar 2019 20:56:59 +0100 Message-Id: <20190304195734.1070109-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:/8+crg0rtE8F/KHpVaFS5EkmK0g90AuK4P88cv1P7RU8bbKBaQ9 y5teQZA0/mjvKjFDhlyuhCdBAIvk9trLWev7F2QkBvtuGP709ujItMCFIZuem343y0Js0DW DHGOifme8zeTq63KqLs4mrbqYNcLo2GmLx4lG1k7EwslSBIrCeV3VoY4jtVdcwzesBuYzpj lcGScS36Qnaf3xqy2rOnA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:O/pUvkxvbgQ=:ebr51muBYH3Z4vWd8/Xzp5 T50cfHcamWkBBSN2TgPrFq8sEgBEK+BTu1KkiyeS1EwuFCaWqElib0Hi0EQtXBYtJkTYvaF90 6uvI9Q6Z8l0hePKPK0MGyV12zEM+ILpsog+RDgu7DcnZHvF58mXwm0+JCF+FrpAEr53ze0Fd7 /zgepJ+t5jm+MdNNTUpdFXTovYWCSQJCwN4fMrp4tbJAidG5jutYTGTCq70f31RVnA6OHzjRW 9mEi1vIVnQHwn7hwEtu1suHnHrkWxR4IEhF/8FIuIIHbqRU3fJ9Cl8A0WgvQcRNC8KaYNI8Z0 X2KcOTctCUrwOuF8CoZWhT5knRKtTvNo4qjlop072nbDtOG2JAPcSdxLDz5eU4WZRBQptzn87 NnQAuxM0sJKSZWXanYsL14BhUIMFx+vKm3a0nk9YhBa3UpoFex2pJRwv60LGS0ZXLYKT0Ucw1 2U6xkIP8H8PoCXZZzs468AN7cl4XzXl5ivcnedIHDdZDrCeXRCOON0kyab1oAfLv9N6nEmNgQ 5ZLH84JHRpc5Rh9EDsU3R2W8S4jlTTKlOPGKCYjJwxozh/UL1VC+KXYJxecOCCj3A/fdRVMHM uQ938p/dei70Ux7ZSTk5GXFyEkGvoZ/3Dju59KW+molHbbfi2WNBT8+4HIrxdruJ3rMSdrs7y Mm49f7HQjBpwusuM5BRgBz1hG1BGFHRkVjZb9IoVtQFpvpJIkZqqEWWGD8kI5JkX19Gd7UQ7Z uKPQ//7mf1V8znGK3N5W6mb/jiNKBqDBOSj8mQ== Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org When CONFIG_GPIOLIB is not set, we get a couple of build errors during test building: drivers/input/misc/msm-vibrator.c: In function 'msm_vibrator_start': drivers/input/misc/msm-vibrator.c:79:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(vibrator->enable_gpio, 1); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep drivers/input/misc/msm-vibrator.c: In function 'msm_vibrator_probe': drivers/input/misc/msm-vibrator.c:176:26: error: implicit declaration of function 'devm_gpiod_get'; did you mean 'devm_gpio_free'? [-Werror=implicit-function-declaration] vibrator->enable_gpio = devm_gpiod_get(&pdev->dev, "enable", ^~~~~~~~~~~~~~ devm_gpio_free drivers/input/misc/msm-vibrator.c:177:13: error: 'GPIOD_OUT_LOW' undeclared (first use in this function); did you mean 'GPIOF_INIT_LOW'? GPIOD_OUT_LOW); ^~~~~~~~~~~~~ GPIOF_INIT_LOW drivers/input/misc/msm-vibrator.c:177:13: note: each undeclared identifier is reported only once for each function it appears in This is easy to avoid when we use gpio/consumer.h as the documented interface. Fixes: 0f681d09e66e ("Input: add new vibrator driver for various MSM SOCs") Signed-off-by: Arnd Bergmann --- drivers/input/misc/msm-vibrator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/input/misc/msm-vibrator.c b/drivers/input/misc/msm-vibrator.c index 69f2579c4ec2..b60f1aaee705 100644 --- a/drivers/input/misc/msm-vibrator.c +++ b/drivers/input/misc/msm-vibrator.c @@ -13,7 +13,7 @@ #include #include -#include +#include #include #include #include