From patchwork Fri Sep 23 02:46:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 608816 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F84CECAAD8 for ; Fri, 23 Sep 2022 02:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbiIWCqK (ORCPT ); Thu, 22 Sep 2022 22:46:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbiIWCqH (ORCPT ); Thu, 22 Sep 2022 22:46:07 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E98101176ED for ; Thu, 22 Sep 2022 19:46:00 -0700 (PDT) X-UUID: 218828dc5bc148f4a9459cf36284e246-20220923 X-CPASD-INFO: 57e6f7169adb4a0f9e1dff0b42ddd227@foefVpNpX2Zlgaaug6R7oFmWYZSWklC xdmyElJJiXleVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3hHmfVpZlYQ== X-CLOUD-ID: 57e6f7169adb4a0f9e1dff0b42ddd227 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:208. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:154.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:0.0, SPC:0, SIG:- 5, AUF:40, DUF:5467, ACD:88, DCD:88, SL:0, EISP:0, AG:0, CFC:0.312, CFSR:0.103, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 218828dc5bc148f4a9459cf36284e246-20220923 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 218828dc5bc148f4a9459cf36284e246-20220923 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 256080858; Fri, 23 Sep 2022 10:46:35 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATCH v8 v8 1/3] uas: add no-uas quirk for Hiksemi usb_disk Date: Fri, 23 Sep 2022 10:46:13 +0800 Message-Id: <1663901173-21020-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Acked-by: Alan Stern Signed-off-by: Hongling Zeng --- Change for v8 -Add acked for patch 3/3 (thinkplus(0x17ef, 0x3899)) --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index cdff7dc..a6bf87a 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -62,6 +62,13 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_IGNORE_UAS), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x090c, 0x2000, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI * commands in UAS mode. Observed with the 1.28 firmware; are there others? From patchwork Fri Sep 23 02:46:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 608815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A66C54EE9 for ; Fri, 23 Sep 2022 03:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbiIWDEO (ORCPT ); Thu, 22 Sep 2022 23:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232142AbiIWDDh (ORCPT ); Thu, 22 Sep 2022 23:03:37 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DEA8E11CA for ; Thu, 22 Sep 2022 20:03:30 -0700 (PDT) X-UUID: 7fafa513122148f3bf8609e04f54a17d-20220923 Message-ID: <1663902249837086.19.seg@mailgw> X-GW-Reason: 11109 X-Content-Feature: ica/max.line-size 82 audit/email.address 3 dict/contack 1 dict/transaction 1 meta/cnt.alert 1 X-CPASD-INFO: a73363c32bcf4a7596fe5bbb62ba65cb@qodtU2NlkWNegqWyg6SCb1lnmJFVsaS cVmKQkWJVuLSMbFJkYl1ZgYFqUWJnX2FZVXp4blJgYGJcWHh4lHKPVGBeYIJUdJOAo3FTY2Rj X-CLOUD-ID: a73363c32bcf4a7596fe5bbb62ba65cb X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:12.0, FD:0.0, CUTS:168.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:- 5.0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:0.0, SPC:0, SIG: -5, AUF:42, DUF:5470, ACD:88, DCD:88, SL:0, EISP:0, AG:0, CFC:0.476, CFSR:0.067, UAT:0, RAF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0 ,EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 7fafa513122148f3bf8609e04f54a17d-20220923 X-CPASD-BLOCK: 12 X-CPASD-STAGE: 1 X-UUID: 7fafa513122148f3bf8609e04f54a17d-20220923 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 837780238; Fri, 23 Sep 2022 10:46:58 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATCH v8 v8 3/3] uas: ignore UAS for Thinkplus chips Date: Fri, 23 Sep 2022 10:46:35 +0800 X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Thinkplus(0x17ef, 0x3899) is reported to influence performance and trigger kernel panic on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 [ 720.545894][13] Workqueue: usb_hub_wq hub_event [ 720.550971][13] ffff88026c143c38 0000000000016300 ffff8802755bb900 ffff880 26cb80000 [ 720.559673][13] ffff88026c144000 ffff88026ca88100 0000000000000000 ffff880 26cb80000 [ 720.568374][13] ffff88026cb80000 ffff88026c143c50 ffffffff8186ae25 ffff880 26ca880f8 [ 720.577076][13] Call Trace: [ 720.580201][13] [] schedule+0x35/0x80 [ 720.586137][13] [] schedule_preempt_disabled+0xe/0x10 [ 720.593623][13] [] __mutex_lock_slowpath+0x164/0x1e0 [ 720.601012][13] [] mutex_lock+0x2f/0x40 [ 720.607141][13] [] usb_disconnect+0x59/0x290 Falling back to USB mass storage can solve this problem, so ignore UAS function of this chip. Acked-by: Alan Stern Signed-off-by: Hongling Zeng --- Change for v8 -Add acked for patch 3/3 (thinkplus(0x17ef, 0x3899)) --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index 8a18d58..156e89c 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",