From patchwork Thu Sep 15 06:28:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 606717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB698C6FA8A for ; Thu, 15 Sep 2022 06:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbiIOG3y (ORCPT ); Thu, 15 Sep 2022 02:29:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiIOG3i (ORCPT ); Thu, 15 Sep 2022 02:29:38 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EE5B8C03C; Wed, 14 Sep 2022 23:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1663223352; x=1694759352; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nz3K58GYkjN1DFzET2mFu+DZKTsC6zB71nsZVaPjp1s=; b=BBe6vg0d06L0FV0jztUMN5a5PwNXWpOHDr/PdyP1lDm5+Ag+yG7mf2oe pkjoOdvIwkvySdN+Yjcx4E3e8S4xLaGmKEB7ysznDaVjHMmWv8xRPmdX7 AG/JR5amqIUVK6rb8Wb1Gq6ex3/ohGM7n8k6yEyY5cmulCgTOgfJODU9n dHuI2XRY5T+PZ6e2KgLuota8YSa5kbHF0xU3ETayAwILL/14N6gRVqfgZ mOz2pKtu3WGmqds67ZfAQOOOUlDH5ULPJnq927oCfp5edUi2AgONCFvhg s1MjDG4PVpE160VUhWVzFzeyhVho8oDza4/hIwy4oS8I3YfGBXqgUI67z g==; X-IronPort-AV: E=Sophos;i="5.93,317,1654552800"; d="scan'208";a="26189608" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 15 Sep 2022 08:29:04 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 15 Sep 2022 08:29:04 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 15 Sep 2022 08:29:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1663223344; x=1694759344; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nz3K58GYkjN1DFzET2mFu+DZKTsC6zB71nsZVaPjp1s=; b=TUQktTGJ3dwed0wxJRHNP8i64kG5vS1Ug9bJ8bd4qsz3JGfUUj8dCpq0 VED91OGE8GJysLw+ce0HVzFTkZeCwNdwOmPzOR929StTTL+WqM1xhCMcv 8kHvAZdOBno3NIEwk8RJyY8JyNyhz8wgSA6eSGwBNPI4paShAFtcvmj6d xoh224x9YfKLie7WC8Mkvxre/p2YD0Zs/CHFk7WKhj7uq8Rf81R8U/vkm Jba++GjNcYrQWICSRs5zDK+8Q5wVrQEIO7qDiMe9eR6j7u2qt57URsu/z TMtdvCptVWsqF1K3FSmUQzncOHBcW00lhZXPuk+PlTv2I0WoxMUThj4iA w==; X-IronPort-AV: E=Sophos;i="5.93,317,1654552800"; d="scan'208";a="26189607" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 15 Sep 2022 08:29:04 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 21E5D280072; Thu, 15 Sep 2022 08:29:04 +0200 (CEST) From: Alexander Stein To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Li Jun Cc: Alexander Stein , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski Subject: [PATCH v2 1/4] dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk Date: Thu, 15 Sep 2022 08:28:52 +0200 Message-Id: <20220915062855.751881-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915062855.751881-1-alexander.stein@ew.tq-group.com> References: <20220915062855.751881-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This selects SOF/ITP to be running on ref_clk. Signed-off-by: Alexander Stein Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 1779d08ba1c0..2a54d0bb0b15 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -234,6 +234,11 @@ properties: avoid -EPROTO errors with usbhid on some devices (Hikey 970). type: boolean + snps,gfladj-refclk-lpm-sel-quirk: + description: + When set, run the SOF/ITP counter based on ref_clk. + type: boolean + snps,is-utmi-l1-suspend: description: True when DWC3 asserts output signal utmi_l1_suspend_n, false when From patchwork Thu Sep 15 06:28:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 606718 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1EA8ECAAD3 for ; Thu, 15 Sep 2022 06:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbiIOG3x (ORCPT ); Thu, 15 Sep 2022 02:29:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbiIOG3i (ORCPT ); Thu, 15 Sep 2022 02:29:38 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C91C95ADD; Wed, 14 Sep 2022 23:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1663223354; x=1694759354; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q9w2m8jL0FbAwvRsvj253ZDURjjBXQk6jNqDtRl4VB4=; b=Mwc8kVHBLglpozty9hs+utTJ/kGPoyep+ISWMifTqpWqtwElV0f7wBTI YsVI5r78knHPU1P4YxyUlEJMz6T4RQfu6dcNyeWhlXeSl4BYP4dpBWjvR dvqsLdCZ3Mj8GrcRWGtYzeOfDfxVc4EQ23QRetGuIhAX5BQyxHgiWu0F0 WjDnmVPUoswVfOcfe05xOEXaVreLdKfhpKRMO2UruCyS9zO7kDFMayTAG ISfrgg/kBBrha4DGD2rwcKeYLYgxS0gU56ZffkP2Ge5k6Im4q3DBxjcJZ 6e4SDDmE9JClZ+574a9slDi67booW+eQzHYig3S49kViKCulNpJymPkXK w==; X-IronPort-AV: E=Sophos;i="5.93,317,1654552800"; d="scan'208";a="26189611" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 15 Sep 2022 08:29:04 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 15 Sep 2022 08:29:04 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 15 Sep 2022 08:29:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1663223345; x=1694759345; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q9w2m8jL0FbAwvRsvj253ZDURjjBXQk6jNqDtRl4VB4=; b=IKvlNNOmLGipacu8WxnLnkGPLbfKj29FyNiro/tWGeP5+6yR5dZB88KC zh1Csc5/FZck1pQ2S4rpOQLoHOvZ3VHGuiVVHxXdelVZa271C4zCq21g5 VFQAW20QJztnai7iRzpjrWLU1SRKHz8qeQaS0qQgYEHzsJ/h0956IWsp7 vjzAE4OY0WKSHq8nXwRjFGl4R0DehcjIPHaLQ2TFQrG3q/MrLJZfQM+nJ OTVmF3wYZ91iMkiIUroZco++Jcz9DxsKHRKZh//bhS5m298DCSWjUTwM4 inJiQP/eLRLLRl4OztJGii902fYp9t2Y51BMYgbQkCB3wWeWG3HU2No3B Q==; X-IronPort-AV: E=Sophos;i="5.93,317,1654552800"; d="scan'208";a="26189609" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 15 Sep 2022 08:29:04 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 6456B280056; Thu, 15 Sep 2022 08:29:04 +0200 (CEST) From: Alexander Stein To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Li Jun Cc: Alexander Stein , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/4] usb: dwc3: core: add gfladj_refclk_lpm_sel quirk Date: Thu, 15 Sep 2022 08:28:53 +0200 Message-Id: <20220915062855.751881-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915062855.751881-1-alexander.stein@ew.tq-group.com> References: <20220915062855.751881-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This selects the SOF/ITP counter be running on ref_clk. As documented U2_FREECLK_EXISTS has to be set to 0 as well. Signed-off-by: Alexander Stein Reviewed-by: Li Jun --- drivers/usb/dwc3/core.c | 8 +++++++- drivers/usb/dwc3/core.h | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 656bbf9285a5..885acc63f032 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -408,6 +408,10 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc) reg |= FIELD_PREP(DWC3_GFLADJ_REFCLK_FLADJ_MASK, fladj) | FIELD_PREP(DWC3_GFLADJ_240MHZDECR, decr >> 1) | FIELD_PREP(DWC3_GFLADJ_240MHZDECR_PLS1, decr & 1); + + if (dwc->gfladj_refclk_lpm_sel) + reg |= DWC3_GFLADJ_REFCLK_LPM_SEL; + dwc3_writel(dwc->regs, DWC3_GFLADJ, reg); } @@ -789,7 +793,7 @@ static int dwc3_phy_setup(struct dwc3 *dwc) else reg |= DWC3_GUSB2PHYCFG_ENBLSLPM; - if (dwc->dis_u2_freeclk_exists_quirk) + if (dwc->dis_u2_freeclk_exists_quirk || dwc->gfladj_refclk_lpm_sel) reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS; dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); @@ -1525,6 +1529,8 @@ static void dwc3_get_properties(struct dwc3 *dwc) "snps,dis-tx-ipgap-linecheck-quirk"); dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev, "snps,parkmode-disable-ss-quirk"); + dwc->gfladj_refclk_lpm_sel = device_property_read_bool(dev, + "snps,gfladj-refclk-lpm-sel-quirk"); dwc->tx_de_emphasis_quirk = device_property_read_bool(dev, "snps,tx_de_emphasis_quirk"); diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 7c9368145f37..d28c942e63dd 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -391,6 +391,7 @@ #define DWC3_GFLADJ_30MHZ_SDBND_SEL BIT(7) #define DWC3_GFLADJ_30MHZ_MASK 0x3f #define DWC3_GFLADJ_REFCLK_FLADJ_MASK GENMASK(21, 8) +#define DWC3_GFLADJ_REFCLK_LPM_SEL BIT(23) #define DWC3_GFLADJ_240MHZDECR GENMASK(30, 24) #define DWC3_GFLADJ_240MHZDECR_PLS1 BIT(31) @@ -1312,6 +1313,7 @@ struct dwc3 { unsigned dis_del_phy_power_chg_quirk:1; unsigned dis_tx_ipgap_linecheck_quirk:1; unsigned parkmode_disable_ss_quirk:1; + unsigned gfladj_refclk_lpm_sel:1; unsigned tx_de_emphasis_quirk:1; unsigned tx_de_emphasis:2;