From patchwork Thu Sep 15 12:07:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kumar Mahapatra X-Patchwork-Id: 606667 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CAFFECAAA1 for ; Thu, 15 Sep 2022 12:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230235AbiIOMI1 (ORCPT ); Thu, 15 Sep 2022 08:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbiIOMIV (ORCPT ); Thu, 15 Sep 2022 08:08:21 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2043.outbound.protection.outlook.com [40.107.101.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 966607D1C3; Thu, 15 Sep 2022 05:08:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WECBcTeDVkr7xjx8lHzbWlOZr7WM4YqpJq6xDO00juUptxu4Ykjmj6ArdUc7WU11VJ2wRb4JR6NBXDcIpVyKD1LjBMxOxjSsZeeAbUeEmxYyLYx+66aBTmCTS730LIqm6SK4lemBFwdkzXbPG2ne6xmRp12k1JvRwYM6xBnbdjXsXaXQqW+f7+jMYdv2bwLHMryZFMGsTelXOpKWaDJbxpVU3vO3if5WmcqaGWMjR9rCqu4fTI5/ndh13ZFJWYeu0Y48SF8QEMn9Fidr9aNT8n9AleZXvuyQ7sqFuIqaXReDeiZ/qZrw5B443DKKzlXRZoTu3UAPSiBPuV3UTqNKdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3WlEA8FSZiP3dwCrA4X9QhFCQoEmG3MAcuV1rXN1Dwg=; b=gVy1ibbqwltJ4MxiD+1ABzDrFLjzGbfCxzRF9XzuZyLCzM26fJFA3bK3+0IElElnGVmHnDwZcRKdA2l3NrTpkoOh5dQDONPLEo3R+KgAGO4dUvz6wNlDzeWki8/baZrHyW7iO1CKkndCWn8w1JR7qkelqxKJOYFawFEw3ZlEczOeu77jwGsAikIXfC36OEs6rigTpZRVv475obrBpy3NyBmmXvXHGPV8xl4zuExV0v+NT8ov+urz9a8J4rVs/KrMLHem8fuwSW9u3srpXYPWqIKKhGt3y2sZLK75mJLd8OIr00IX/t4F/TgtBtWjseAG4RXIf9IDmwYdcLmmq5WB3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WlEA8FSZiP3dwCrA4X9QhFCQoEmG3MAcuV1rXN1Dwg=; b=YeVAhRxqoMUz/GLuCAPZKGUafDsS0huI0WeWdhc7nOZ30Jox567PfFp2ClP3EbWAtEkOcvWxnQd110zCg8JTDktjv6YBfPX9R5jxmUCWPj+2ilAW6loLJubzzlOJcsFm8y7v2NxD920ay1Cdo5x7k8Hv9CCmx2f63GU1K3VqodY= Received: from DS7PR03CA0240.namprd03.prod.outlook.com (2603:10b6:5:3ba::35) by DM8PR02MB8296.namprd02.prod.outlook.com (2603:10b6:8:7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Thu, 15 Sep 2022 12:08:11 +0000 Received: from DM3NAM02FT015.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3ba:cafe::a1) by DS7PR03CA0240.outlook.office365.com (2603:10b6:5:3ba::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Thu, 15 Sep 2022 12:08:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT015.mail.protection.outlook.com (10.13.5.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Thu, 15 Sep 2022 12:08:11 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Thu, 15 Sep 2022 05:08:02 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Thu, 15 Sep 2022 05:08:02 -0700 Envelope-to: broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, git@amd.com, michal.simek@amd.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, akumarma@amd.com Received: from [10.140.6.39] (port=33420 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oYnf0-000Fci-9I; Thu, 15 Sep 2022 05:08:02 -0700 From: Amit Kumar Mahapatra To: , , CC: , , , , , , , Amit Kumar Mahapatra Subject: [PATCH v2 2/7] spi: spi-zynqmp-gqspi: Set CPOL and CPHA during hardware init Date: Thu, 15 Sep 2022 17:37:45 +0530 Message-ID: <20220915120750.1424984-3-amit.kumar-mahapatra@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915120750.1424984-1-amit.kumar-mahapatra@xilinx.com> References: <20220915120750.1424984-1-amit.kumar-mahapatra@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3NAM02FT015:EE_|DM8PR02MB8296:EE_ X-MS-Office365-Filtering-Correlation-Id: b18b2f9e-f037-4928-2de8-08da9712f5fc X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qk2q35UbNLSN18D+psJ9qc2qw27DyFVqjQKYaBzvSs/bz4c3fj9efQ0uWdfQrgFKiw9J0vHAlXe56C0Vx62psfPv5VBaueDuKzUcuLZs2T3uFepKM2vavCAp1y7EC63smElwn9l8uNhjBZm2zClnVIXUCggbFaFfuG6j2w0ikmvj4SR/CDvmE5SOzBvjzG8RLrefX8sBwfG0gb07eQ83GXZkfkPOtFqqPP5LnLupK8jp73OuanDa9X3oKMcKk11VgSi7Ka+fsk7wXC8Fq1AenW9KqUK9zGLT3LGYyF9emBKA+y9DwjxnXT5pJ+p0kkq6m8j2NglhQy3puH6DQOKtk4Y/lPQJKa6j1O7BUKqSK2zPLouQUm+o6i5RFD9VwfzPwbjnBW7upXmUjwApedzUfgBmyHCTIgy0CyQ10VKbQGX8uIVegVcr7N2zhPuixyvYIKqR3+mzkk0/oyIsNeW1lOqNF2kjqP5coqgRcx0AX34LTC6bhw5cfC1NDbjyER7kh9HEBc+jyF9nwS3enV9Qrc4qwsef8dr+1xQrSlxdmaBqF/jBvsi02Mtjv3+T0M1JIlpckcZQ1o3QDkQJvZ5OSQuasqvgLPNQTVHbOz0EE7yzKts+wgmEuTiU1jt4YL2lRADmxzcOFMyopp9wK/6pMJKS8arNm1QRCD2nRn1QxVgcUuc831NuLRMu+H4AqkU3Y/OqOERSeI92EZ8RlHQSFg6I3gl+zrcWPry3fboQW6sm1awPGwqXLe74j4g0l5l/EHh5S3UI/IFtsmhC5T6ghOlUkk48kDMfLPnF1tjKewk= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(8676002)(36860700001)(40460700003)(336012)(5660300002)(186003)(110136005)(8936002)(7416002)(7696005)(26005)(54906003)(6666004)(107886003)(316002)(82310400005)(83380400001)(478600001)(2616005)(41300700001)(7636003)(36756003)(82740400003)(9786002)(47076005)(1076003)(356005)(426003)(2906002)(70586007)(40480700001)(4326008)(70206006)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 12:08:11.7403 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b18b2f9e-f037-4928-2de8-08da9712f5fc X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT015.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8296 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org During every transfer GQSPI driver writes the CPOL & CPHA values to the configuration register. But the CPOL & CPHA values do not change in between multiple transfers, so moved the CPOL & CPHA initialization to hardware init so that the values are written only once. Signed-off-by: Amit Kumar Mahapatra --- drivers/spi/spi-zynqmp-gqspi.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index b07bb97cf874..6771496c1f86 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -264,7 +264,9 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr, * - Enable manual slave select * - Enable manual start * - Deselect all the chip select lines - * - Set the little endian mode of TX FIFO and + * - Set the little endian mode of TX FIFO + * - Set clock phase + * - Set clock polarity and * - Enable the QSPI controller */ static void zynqmp_qspi_init_hw(struct zynqmp_qspi *xqspi) @@ -303,10 +305,17 @@ static void zynqmp_qspi_init_hw(struct zynqmp_qspi *xqspi) config_reg |= GQSPI_CFG_WP_HOLD_MASK; /* Clear pre-scalar by default */ config_reg &= ~GQSPI_CFG_BAUD_RATE_DIV_MASK; - /* CPHA 0 */ - config_reg &= ~GQSPI_CFG_CLK_PHA_MASK; - /* CPOL 0 */ - config_reg &= ~GQSPI_CFG_CLK_POL_MASK; + /* Set CPHA */ + if (xqspi->ctlr->mode_bits & SPI_CPHA) + config_reg |= GQSPI_CFG_CLK_PHA_MASK; + else + config_reg &= ~GQSPI_CFG_CLK_PHA_MASK; + /* Set CPOL */ + if (xqspi->ctlr->mode_bits & SPI_CPOL) + config_reg |= GQSPI_CFG_CLK_POL_MASK; + else + config_reg &= ~GQSPI_CFG_CLK_POL_MASK; + zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, config_reg); /* Clear the TX and RX FIFO */ @@ -463,14 +472,6 @@ static int zynqmp_qspi_config_op(struct zynqmp_qspi *xqspi, config_reg = zynqmp_gqspi_read(xqspi, GQSPI_CONFIG_OFST); - /* Set the QSPI clock phase and clock polarity */ - config_reg &= (~GQSPI_CFG_CLK_PHA_MASK) & (~GQSPI_CFG_CLK_POL_MASK); - - if (qspi->mode & SPI_CPHA) - config_reg |= GQSPI_CFG_CLK_PHA_MASK; - if (qspi->mode & SPI_CPOL) - config_reg |= GQSPI_CFG_CLK_POL_MASK; - config_reg &= ~GQSPI_CFG_BAUD_RATE_DIV_MASK; config_reg |= (baud_rate_val << GQSPI_CFG_BAUD_RATE_DIV_SHIFT); zynqmp_gqspi_write(xqspi, GQSPI_CONFIG_OFST, config_reg); @@ -1162,6 +1163,9 @@ static int zynqmp_qspi_probe(struct platform_device *pdev) goto clk_dis_all; } + ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | SPI_RX_QUAD | + SPI_TX_DUAL | SPI_TX_QUAD; + /* QSPI controller initializations */ zynqmp_qspi_init_hw(xqspi); @@ -1188,8 +1192,6 @@ static int zynqmp_qspi_probe(struct platform_device *pdev) ctlr->setup = zynqmp_qspi_setup_op; ctlr->max_speed_hz = clk_get_rate(xqspi->refclk) / 2; ctlr->bits_per_word_mask = SPI_BPW_MASK(8); - ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | SPI_RX_QUAD | - SPI_TX_DUAL | SPI_TX_QUAD; ctlr->dev.of_node = np; ctlr->auto_runtime_pm = true; From patchwork Thu Sep 15 12:07:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kumar Mahapatra X-Patchwork-Id: 606666 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0B8ECAAD3 for ; Thu, 15 Sep 2022 12:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbiIOMIl (ORCPT ); Thu, 15 Sep 2022 08:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230414AbiIOMIc (ORCPT ); Thu, 15 Sep 2022 08:08:32 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7E4F7D7B8; Thu, 15 Sep 2022 05:08:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjUEvC7tiGJ1YlFeXriayNVwGJ/BhFm0V0iP/GiBBIfm4uFEd2t/OEQW+quCa1yn/lKK21ErAmY8+JGBcWs53Z3U4Aty4f2KtnvTXVvgB0D71GFU/bFJKWlbarFRZ/G/3GhBOIqG9GCmjRfg9nk04lo3P7jGwJKMnq3R9m5p3+CsUWr2eZ+P8+1vKTodMQ6l+3xH1EIhPY3bmRYTkO6tjXEzX4IEzCyzhX2hktkAx+JML+fnhGg+iNKI3PzOY5FBjVaA4RiRXZq1txpy4nL7wJVHaXrXuNU2m9iN+g3R5nLLS/KAREQ6Ne5IrOuxZMInFY39IzceDf+CEQiXhFcySA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MwNAbj05ECbWou82JkSRfkXCkZqQBgDF65tx8+StLfg=; b=YCR9usKYXf/LDXCzkyjm93Yo1bgeovAkjP/T7pLFfADojwD/tufmhLAVSKXGTlAVDbagMO5kUkWaq9LkowV+2PzEikFlLAXlOAWCzaDxoEsfxiNetz6d4yyR1Qtq74zKq6F4+0sC5P9g4q/gJCaqji7UropHv7C4lyETu63K4/5CCcjyNbhJ+9n4rd/LsRzcR6eHxaY1uRsfIfQZ72CgaNDxtln8eN4g02dRfI9F5nItMnqcrCkjH7gw+AaTZeEUK8k9vkdEIAGq30RDK5+ju5lbSIgef9ro/9D7nSWko+M31BahjWpHr0/rA2fSgr86XZSK5BPsSPZzU/rtIdxqQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MwNAbj05ECbWou82JkSRfkXCkZqQBgDF65tx8+StLfg=; b=DRgFfc4wVjzD6otQA88fH1w5poEX1ORlKN4RK0u/DbDxCjXJ2IGH9OEh1fov69IMi7Ll0v4gs4WqV/TKKVru4MhRRAcIUQ1qHc5jWb7dZuyTE1atajyOVE68fEOhn5dOKTBY6rvEmLPz4lUdYfuWzDGGT9Tmi5igEsQrfET8w+A= Received: from DM6PR01CA0025.prod.exchangelabs.com (2603:10b6:5:296::30) by SJ0PR02MB7261.namprd02.prod.outlook.com (2603:10b6:a03:2a3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 12:08:21 +0000 Received: from DM3NAM02FT032.eop-nam02.prod.protection.outlook.com (2603:10b6:5:296:cafe::3d) by DM6PR01CA0025.outlook.office365.com (2603:10b6:5:296::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Thu, 15 Sep 2022 12:08:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT032.mail.protection.outlook.com (10.13.5.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Thu, 15 Sep 2022 12:08:21 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Thu, 15 Sep 2022 05:08:09 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Thu, 15 Sep 2022 05:08:09 -0700 Envelope-to: broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, git@amd.com, michal.simek@amd.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, akumarma@amd.com Received: from [10.140.6.39] (port=33420 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oYnf6-000Fci-Px; Thu, 15 Sep 2022 05:08:09 -0700 From: Amit Kumar Mahapatra To: , , CC: , , , , , , , Rajan Vaja , Amit Kumar Mahapatra Subject: [PATCH v2 4/7] firmware: xilinx: Add qspi firmware interface Date: Thu, 15 Sep 2022 17:37:47 +0530 Message-ID: <20220915120750.1424984-5-amit.kumar-mahapatra@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915120750.1424984-1-amit.kumar-mahapatra@xilinx.com> References: <20220915120750.1424984-1-amit.kumar-mahapatra@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3NAM02FT032:EE_|SJ0PR02MB7261:EE_ X-MS-Office365-Filtering-Correlation-Id: fa5c7bad-23e8-400d-05f2-08da9712fbd7 X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nKJNmyhVOby4oMpOk2LgS+9rN196xbEl/F6tsCWGE5BMcPTRIdG/9NxVOb0byZDYfqAmfn/TdLpV1WSA4pVOsN3kwgy6LoRJwjfANn5Nm8OtnjejkuFcAeMH2aVtLBuONgm3judbFlOmBeC3y0A0ON8nfIJftTKIGm0kgctWsVr8/vc92DWvgy0XaoXxqg0lAHZTW/T37sy3CknhQkJb0XxE2h/hFPHYtsJLgZRweOgG4GBmfyMnhhv1kziT2Gh+qw9lKa3rlPqsfzBEJj10O6R6iGZHzAPW+320nTVpXTyjt8EbSWKXWmYBhr95yHUIdwwdcjfjYqBQTzklMxy5xZVCzYtnjYLM8UHKjU5wmGVf18dAXMMmQnAoQ6qeExOngWrRCcc665vsuLt7IMBsvaQpQ9CRjxhqLaXEmN0DLoHDLhVt8tGIDCvfmm+XwicZWVoi49HmQ+d3dS7K7+yt0ESZxHl+XV+JlNXs6KXeTe/Ji1AVn6lU96yixintHQ/8WuQxN8HXUyqa/KKa4+yBk/gAWmQuF4JXSwlb5zRe3Y1oHtwKO/4/OGA2qVVJxKk+lZbmPt5qBZp4EwjkCAaOpzTwvVN44ninGDvzQtQLWgqyBJjx69MWYJRkqaDarCypHElHX7SKgokKgK8zopQ1NEorJjhSRRaDZ4s9pwCCSC6AZNtoUM9INdyjU3/tVpNTx6Co3OoZkkV8uRJPIKOh83lMDV7YVHDjEPEjdzmwbW8W1CtA6opoqc0FmCEbL5YkfAb9hbE9C14gOPygpDBSVh9grv+BVDFVkVPfnNz39Pg= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(47076005)(83380400001)(36860700001)(336012)(426003)(356005)(1076003)(7636003)(82310400005)(41300700001)(40460700003)(478600001)(8936002)(9786002)(36756003)(2906002)(2616005)(186003)(82740400003)(110136005)(54906003)(5660300002)(7416002)(40480700001)(8676002)(70206006)(7696005)(70586007)(4326008)(6666004)(26005)(107886003)(316002)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 12:08:21.5787 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa5c7bad-23e8-400d-05f2-08da9712fbd7 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT032.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7261 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Rajan Vaja Add support for QSPI ioctl functions and enums. Signed-off-by: Rajan Vaja Signed-off-by: Michal Simek Signed-off-by: Amit Kumar Mahapatra --- drivers/firmware/xilinx/zynqmp.c | 7 +++++++ include/linux/firmware/xlnx-zynqmp.h | 19 +++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index 7977a494a651..b119f170437a 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -829,6 +829,13 @@ int zynqmp_pm_read_pggs(u32 index, u32 *value) } EXPORT_SYMBOL_GPL(zynqmp_pm_read_pggs); +int zynqmp_pm_set_tapdelay_bypass(u32 index, u32 value) +{ + return zynqmp_pm_invoke_fn(PM_IOCTL, 0, IOCTL_SET_TAPDELAY_BYPASS, + index, value, NULL); +} +EXPORT_SYMBOL_GPL(zynqmp_pm_set_tapdelay_bypass); + /** * zynqmp_pm_set_boot_health_status() - PM API for setting healthy boot status * @value: Status value to be written diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 1ec73d5352c3..b38d12b6040f 100644 --- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h @@ -134,6 +134,7 @@ enum pm_ret_status { }; enum pm_ioctl_id { + IOCTL_SET_TAPDELAY_BYPASS = 4, IOCTL_SD_DLL_RESET = 6, IOCTL_SET_SD_TAPDELAY = 7, IOCTL_SET_PLL_FRAC_MODE = 8, @@ -380,6 +381,18 @@ enum zynqmp_pm_shutdown_subtype { ZYNQMP_PM_SHUTDOWN_SUBTYPE_SYSTEM = 2, }; +enum tap_delay_signal_type { + PM_TAPDELAY_NAND_DQS_IN = 0, + PM_TAPDELAY_NAND_DQS_OUT = 1, + PM_TAPDELAY_QSPI = 2, + PM_TAPDELAY_MAX = 3, +}; + +enum tap_delay_bypass_ctrl { + PM_TAPDELAY_BYPASS_DISABLE = 0, + PM_TAPDELAY_BYPASS_ENABLE = 1, +}; + enum ospi_mux_select_type { PM_OSPI_MUX_SEL_DMA = 0, PM_OSPI_MUX_SEL_LINEAR = 1, @@ -451,6 +464,7 @@ int zynqmp_pm_write_ggs(u32 index, u32 value); int zynqmp_pm_read_ggs(u32 index, u32 *value); int zynqmp_pm_write_pggs(u32 index, u32 value); int zynqmp_pm_read_pggs(u32 index, u32 *value); +int zynqmp_pm_set_tapdelay_bypass(u32 index, u32 value); int zynqmp_pm_system_shutdown(const u32 type, const u32 subtype); int zynqmp_pm_set_boot_health_status(u32 value); int zynqmp_pm_pinctrl_request(const u32 pin); @@ -659,6 +673,11 @@ static inline int zynqmp_pm_read_pggs(u32 index, u32 *value) return -ENODEV; } +static inline int zynqmp_pm_set_tapdelay_bypass(u32 index, u32 value) +{ + return -ENODEV; +} + static inline int zynqmp_pm_system_shutdown(const u32 type, const u32 subtype) { return -ENODEV; From patchwork Thu Sep 15 12:07:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kumar Mahapatra X-Patchwork-Id: 606665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDEACC6FA8A for ; Thu, 15 Sep 2022 12:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230435AbiIOMJA (ORCPT ); Thu, 15 Sep 2022 08:09:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbiIOMIg (ORCPT ); Thu, 15 Sep 2022 08:08:36 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 511787F100; Thu, 15 Sep 2022 05:08:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IAOWkmNA22cJjsbpS2Iez2/yBiUswzXO5/aBcMZeTccvD5NuuFyQGrZi3A2YdUmMFL9jw4z80wNUqkbYB+sFkcIBGCXxI6rl9CBsVw+5CiBx0P83IuVTRTtd3XmDkoGMks1U/wIzlR/q/c6oQxwGSzOAt6AYOyds894No468rD+d7bWF/RN5+UWZa8NU77mWn+F7x9/KQmSXpuLMjPu1kw1I/aS5ow0SiQ7N4TP3v+idkxU9wvQj05pr5VqnrT9t4tZHlKiy3GbNaT02ktJdly1cKtl+NR6WrP0YruLTLSWGL4pmXzJYQZtsC8jis41NANQ9nVrJD2JvTfex0HlD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cIXtmoreUwJdEoRPBDZTZoiftr8lP7JPs55YuXXKbMc=; b=bE5imhxveHYC9IeWFR4IlG/iWAwTE3mnDVJt0oMMN2Gw556g7l+6+XkkFOcxI05jG7bVL3U4f52yTihn0JYJDR8HIUEufSVCgCtP0jXHIdLhDNz2ivnFz5wdWRd5HFvnABqY2SmcAvcJ3RYhBjTiEjjHgSRag5m/XKciYHaoGCoBKejLvS+tYZVsptRfIgCuzpbI+Nr85VMmq7SCQ9AiV76hQw7PrXgyIJJDQDyrYWr2LiFe4fu6j4rtApBr6UTgpCYfffR89Pj8pRdWzYLNLKLJdj7HqeHaUoGsLzzLz2YxLtg4iRvOeBBTyU6dlnPc/djOHfKfmrzNM5pF41FplA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIXtmoreUwJdEoRPBDZTZoiftr8lP7JPs55YuXXKbMc=; b=eD/cxCsH93y+jvNeDoM6e6UVbexWOw5+SIRnV8sLbhbAiO5jJmzpm5J/qft9yRFD/q810kp6NjWYipTpoLACDi09kUVuO2oe2Fg5RvjSJxUNzq70NtfvLgQ0WMjk/UlclA24voRT4zR6iH4FIzS2+VQr55fnz83NfhDNjtxocM0= Received: from DM6PR01CA0025.prod.exchangelabs.com (2603:10b6:5:296::30) by DM6PR02MB6843.namprd02.prod.outlook.com (2603:10b6:5:21e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Thu, 15 Sep 2022 12:08:27 +0000 Received: from DM3NAM02FT032.eop-nam02.prod.protection.outlook.com (2603:10b6:5:296:cafe::9f) by DM6PR01CA0025.outlook.office365.com (2603:10b6:5:296::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Thu, 15 Sep 2022 12:08:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT032.mail.protection.outlook.com (10.13.5.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Thu, 15 Sep 2022 12:08:27 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Thu, 15 Sep 2022 05:08:15 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Thu, 15 Sep 2022 05:08:15 -0700 Envelope-to: broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, git@amd.com, michal.simek@amd.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, akumarma@amd.com Received: from [10.140.6.39] (port=33420 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oYnfD-000Fci-A0; Thu, 15 Sep 2022 05:08:15 -0700 From: Amit Kumar Mahapatra To: , , CC: , , , , , , , Amit Kumar Mahapatra Subject: [PATCH v2 6/7] dt-bindings: spi: spi-zynqmp-qspi: Add support for Xilinx Versal QSPI Date: Thu, 15 Sep 2022 17:37:49 +0530 Message-ID: <20220915120750.1424984-7-amit.kumar-mahapatra@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915120750.1424984-1-amit.kumar-mahapatra@xilinx.com> References: <20220915120750.1424984-1-amit.kumar-mahapatra@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3NAM02FT032:EE_|DM6PR02MB6843:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fe0b0ff-b1f8-46b9-a3ef-08da9712ff33 X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A80+SxMIPm9Kfr+WB2FS0uxXVOh9EYehm8Tzs/++Oe8QBUmCvOMqWLA4CMuS1qEd0Z35utNK9zQ0wf+c0AwQ2i6USdTh7SuuTErbtbJnqYwuseWuW8vC42Gf5g9LQC1/3PDAVU8d5LeP07+P0g1jdchsqHjeeXXdNtNFpcLtvH78iZYBg1plPAkng4U2UTf1e3hqvs6UPAbpSv9g7olNSt9BpAlsU1IEKvhawo1R57gyoFPyBJM7uwizItxEd3I379rIrl191Ta/crK0+tx2wUEDotvlDkT6JAvLPo6o3aahA8w7tNDNscVArj4dHZTWuxudkN1GVK0R99Whbl5423aKcPPkaQLf3Ri0GgJ34TUhtQzv+RZAMR44MGFovsbkXiA5Uy2pDm66fP4mJHP1K0DyQb2gbP9AjjanBfdq3MZjuDT5ViC1OaSqJFkTTG6w5HUm+d/RHqwFxvMBR5QXKO0AYecAmu7aVUbEv4Y/YMHS+gISgnXhScOwwEkbOAOxbXd1N/VBzsKM7flSSmLzUaC3rZdvZyw34RH8jbsTmCFNbE6b7wqwuOoeE6HBqp+Vul21XdSAyt5risZuqIz9an1beMLC+fqanUh+tSj/decaW8su3xi3wB/5Uvb/GC3zWlgtOaMwQMqQEbmd+2wXl8MPjluOis+nHOuZAoXM5hn3iN2aINtmqrvtspbnOUBmYp7t8zLBZ+Irx4tf1CaZnvE9Syp+ebuvtfOhniMNS+ZnOoPL40pYsdN0Jdo6c13i4hGCY0eGS8XYA8Gz+Q/br5ps0T0rtaaIlqeYDEmXIaU= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(356005)(316002)(426003)(40480700001)(186003)(4326008)(9786002)(47076005)(36860700001)(2616005)(70586007)(82310400005)(107886003)(70206006)(41300700001)(7696005)(82740400003)(110136005)(336012)(54906003)(7636003)(8676002)(2906002)(1076003)(8936002)(36756003)(6666004)(40460700003)(4744005)(7416002)(5660300002)(83380400001)(478600001)(26005)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 12:08:27.2188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe0b0ff-b1f8-46b9-a3ef-08da9712ff33 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT032.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6843 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add new compatible to support QSPI controller on Xilinx Versal SoCs. Signed-off-by: Amit Kumar Mahapatra --- Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml index ea72c8001256..37108bfdcd81 100644 --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml @@ -14,7 +14,9 @@ allOf: properties: compatible: - const: xlnx,zynqmp-qspi-1.0 + enum: + - xlnx,zynqmp-qspi-1.0 + - xlnx,versal-qspi-1.0 reg: maxItems: 2