From patchwork Wed Sep 14 16:11:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorota Czaplejewicz X-Patchwork-Id: 606029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D8AC6FA89 for ; Wed, 14 Sep 2022 16:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbiINQME (ORCPT ); Wed, 14 Sep 2022 12:12:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbiINQMC (ORCPT ); Wed, 14 Sep 2022 12:12:02 -0400 Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FDB582F86; Wed, 14 Sep 2022 09:12:00 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 69325E0DE4; Wed, 14 Sep 2022 09:11:59 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vobkclx-FXAG; Wed, 14 Sep 2022 09:11:58 -0700 (PDT) Date: Wed, 14 Sep 2022 18:11:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1663171918; bh=elFceSoq1Zd6llwZFMqA1XY98dpuih6uD8z1glKnQpA=; h=Date:From:To:Subject:From; b=qhbhsklArPEDmf0efT6EpeuH8Ev8nd5pK9+FSLHA81FZ0lTmq85z9/J6evfTPJ06T ZHex60osQ6L8Yvw4KSbRdiiwgKhqXLej2G7jO3UpzVyoQJ2+Sdczq+eILaT12q0M7e xzf9Lnw+Z8QmMjT2oRvo7HUJAOK35zGF+PprtDLucx3GE6JdTkAQm6L4Ug+UAKsLQh r+Xc8AGEwKp0nY8vdjDmU2lWgze8bw8f14nzo5gG91gTjQF1jd+lt8e2XV21XTlI9U J5YZc92JFTD3qWDpicm1bAXyba0jNe5cAY/HI7AFpxf7194nV42UUPC8BGzmBkd3DQ Bgo4lr/OefzCw== From: Dorota Czaplejewicz To: Laurent Pinchart , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Subject: [PATCHv3 1/1] media: imx: Round line size to 4 bytes Message-ID: <20220914173236.3040f3a1.dorota.czaplejewicz@puri.sm> Organization: Purism MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Message-ID: <20220914161151.v7e-NT5VzIYSGTCkh8oZC45pnuS88QTe3umbumphK64@z> Section 13.7.6.13 "CSI Image Parameter Register" of the i.MX 8M Quad Applications Processors Reference Manual states that the line size should be divisible by 8 bytes. However, the hardware also accepts sizes divisible by 4 bytes, which are needed to fully utilize the S5K3L6XX sensors. This patch accepts line sizes divisible by 4 bytes. Signed-off-by: Dorota Czaplejewicz --- Hello, the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it. This revision improves the commit message. Cheers, Dorota Czaplejewicz drivers/staging/media/imx/imx7-media-csi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index a0553c24cce4..af821b410c3f 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, } /* Round up width for minimum burst size */ - width = round_up(mbus->width, 8); + width = round_up(mbus->width, 4); /* Round up stride for IDMAC line start address alignment */ - stride = round_up((width * cc->bpp) >> 3, 8); + stride = round_up((width * cc->bpp) >> 3, 4); pix->width = width; pix->height = mbus->height;