From patchwork Mon Sep 12 06:17:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605619 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEE4C6FA89 for ; Mon, 12 Sep 2022 06:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbiILGR6 (ORCPT ); Mon, 12 Sep 2022 02:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiILGR5 (ORCPT ); Mon, 12 Sep 2022 02:17:57 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C5CA2613A for ; Sun, 11 Sep 2022 23:17:55 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id p5so9307720ljc.13 for ; Sun, 11 Sep 2022 23:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=FI26vxDVvyB2ohU/Q2Xw8ikZ3CFzmn6rrr4FY2O/Oys=; b=M0/8cQ6sJ4K05sra8GufO8vQBqNlJPjWcLf14zPEPSFzixoHFP7lUzgkk1ARR51TeD zVL0FCRQL/lxz2tJC+yLAB0KHo7W6oI8AtKn8ui2NOoI+GT//J9OvBGzheOh7vZyDG/G PZuDZGh99myHf4APLISsDxePYWxV87UaEXASXFhDhyb4U0VAdhbFtp5ttGi/OL5PrTlw Ln+W2VBT1q/6QGJuCNIyWeemzQU9yShfSEt4KFJ99U8HeSwEZp23CPRta6kSl0KmwKhh T18kT+5/mn6MJ2ZZJc5CM18b7l0OXzPXwPaXo3+Bf8SDgUdqWpxZ38spoTu45GVB8tSu r7WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=FI26vxDVvyB2ohU/Q2Xw8ikZ3CFzmn6rrr4FY2O/Oys=; b=DyljPIRt2nnjFhgUGK7cAJTGiG1JeT/jgMgeszLSlmQzvaTYEfjYPWxbAAQyyKIh7M QG//9XhUfHBfBkk5ALvJlf5y5ewY1PtXFYUIqsMrnIEGw84X+2uEqF5R7Ukv8MHHWo9K 3r9dTJuJ8OnclwdNPoB9mX/jP3ZobhS38E+L34kHIIR0sWTR+Kr1+FLmwI7tReYw+uVx cpikWQFT8H2HwgobjdJu+tpxKic2BHJPacqAAQOBZupiBJxB37d0OKtiuDoiA9q7WBjC vrW+qWw9xPe2z8lALmq091PSc0HYQsR1pekzjZF5p/DkvpBUyyG1M8/o9PGzBzpFuD11 R+Hg== X-Gm-Message-State: ACgBeo24Tdwpi+jVNr3nUnsh8035lx9/OGJ0gV7VlXJDQdmkJO4IAam4 7pZbox7RPcB7BoVlInAJDOhnBA== X-Google-Smtp-Source: AA6agR44iRqUM/EedU02ObBZe5dzrKszQKQeOKL35am5SOOWpwqC6LYWeNVNuIx/lpXvoVe9ByPhqw== X-Received: by 2002:a05:651c:88b:b0:261:ba8e:717a with SMTP id d11-20020a05651c088b00b00261ba8e717amr7167538ljq.401.1662963473811; Sun, 11 Sep 2022 23:17:53 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 01/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:07 +0200 Message-Id: <20220912061746.6311-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index d8443811767d..8a2b4767c7b6 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -59,8 +59,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6115-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6115-tlmm-state" + additionalProperties: false '$defs': qcom-sm6115-tlmm-state: @@ -155,25 +156,25 @@ examples: gpio-ranges = <&tlmm 0 0 114>; sdc2_on_state: sdc2-on-state { - clk { + clk-pins { pins = "sdc2_clk"; bias-disable; drive-strength = <16>; }; - cmd { + cmd-pins { pins = "sdc2_cmd"; bias-pull-up; drive-strength = <10>; }; - data { + data-pins { pins = "sdc2_data"; bias-pull-up; drive-strength = <10>; }; - sd-cd { + sd-cd-pins { pins = "gpio88"; function = "gpio"; bias-pull-up; From patchwork Mon Sep 12 06:17:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50492ECAAA1 for ; Mon, 12 Sep 2022 06:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbiILGSE (ORCPT ); Mon, 12 Sep 2022 02:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbiILGSB (ORCPT ); Mon, 12 Sep 2022 02:18:01 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3EA2715C for ; Sun, 11 Sep 2022 23:17:58 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id y18so9310972ljh.12 for ; Sun, 11 Sep 2022 23:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=vyYamw1Du4HV9eH+g+rE4fAB7iezBD0VnqsswMEZh9Q=; b=OMp8EudE35YyzNGuCOAeWC5WjdioYM252RuRUFtRRdYynw6J1BBqWiYPEsWt0+FPUj M49nt1W2kDIRmNE30QLul3sMweSnC1Pryl8QRXnMDx9CRYVEbdO25JbtbhMt6n75bpPv TKpKrO/2m5eBEn3fYF+TyMEBXCSLYpkfCrYFGWld0R7oXpWV4qbShAC5FNrpKZYlmOcQ u+MzhKiSMFMXj4xGLmhO4xXND1soJIx01JMcBXMOrgk+PQ1ANQUN8tVb9p87/Tel+WME XEjDA5DSuc2WH0NIcOFpMGOjXmO+5H0CiMCgcDxQrWAO1tvg2/n0zuwPfk1xytg2M2Zk MEDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=vyYamw1Du4HV9eH+g+rE4fAB7iezBD0VnqsswMEZh9Q=; b=4huvHC5hw9Y5VSgL2sY9A7aobDIzmNz4arGzX0Vptr9L5IF+dXjD6Tz3FOYbP8BwGo +GRTc9M4ViP7p9CIXHkDPdaCHokO0TuT3Xu5VZth5ITBeRa63+E1V38hgAHJNCtAjjOo hFpjjmKn9lqC81RC4dBmh06WuXNAco208QcFACgAGZywwfSUlhZsBtqjMBeeNqq1nGlF wGwsX6CHbgwUx8xESUtBT3MgaI9rtqDjXDfSIdCkTJRfQgVJRrLylTShG7HcpIxoQQOB bhBQ9BXCY5wNI+TxqU+qfYjs6Ue3YzhOMe1meuL3ssU2Zp6YebWQox5SSpPR8ZpwOYOf /xlA== X-Gm-Message-State: ACgBeo1U2vFDUeNY4TnvR+P8OxPx1TQp2cTBOH50FgpcXXtsywB7c0pf 8KO+dsXCf+hrhjhX1Tr1Y7MP/A== X-Google-Smtp-Source: AA6agR6zRnH0MEqYlMZz4QKOqoGTt9It9V5BpYycR4WeATh2oNCyf5EySkBoW8N2AOkwOV8LKEpDcQ== X-Received: by 2002:a05:651c:2205:b0:25f:dda5:1e65 with SMTP id y5-20020a05651c220500b0025fdda51e65mr7827812ljq.240.1662963477269; Sun, 11 Sep 2022 23:17:57 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:56 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 02/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: require function on GPIOs Date: Mon, 12 Sep 2022 08:17:08 +0200 Message-Id: <20220912061746.6311-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Require function on GPIOs (so not on SD card pins). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 8a2b4767c7b6..28b29bf714b4 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -69,7 +69,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -121,6 +120,16 @@ patternProperties: required: - pins + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" + then: + required: + - function + additionalProperties: false allOf: From patchwork Mon Sep 12 06:17:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605618 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A3CC6FA8A for ; Mon, 12 Sep 2022 06:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbiILGSJ (ORCPT ); Mon, 12 Sep 2022 02:18:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiILGSC (ORCPT ); Mon, 12 Sep 2022 02:18:02 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43D31275FD for ; Sun, 11 Sep 2022 23:18:00 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id by6so9298094ljb.11 for ; Sun, 11 Sep 2022 23:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=9Ga8X9++qfiAWh6BldRFQQXZ+w/+Bj3hqeXHqr2J+Og=; b=MkBeGITuxFq8B3+KVWBocBoRpwWOeyxi8nZNPC8gDPapMrUfABNQNHYoT6po/jKQ5+ e1VTrtMkTuqcE905n9OiwleCv6rFy/3aaV0PFkzgCEQ8+37T8AskyCus6SVBPGArFshL qUPVYA6/44Rkfh+VVsK3cGvG+wTnn0QvvWutx1Ss2+PP+DvMsDtoU00GkgtTLIJQMJSp GMTHvYzGdrNLQeGge7FahsKMZgUKKQNTevza9SC/Swenraqm18KtZXRCzac7s0mn4kJe L0RR1CdvuIPBQj+wZ4HMWMDG/3WazUFHZg6xJ7f3S4EdCI2P42jvoLqaYtBhFkge5z6N WhxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=9Ga8X9++qfiAWh6BldRFQQXZ+w/+Bj3hqeXHqr2J+Og=; b=4ut0YxxW+wE/eBZg3Vdt0hwWgUPzh8qc+leCWVtz24kHlXZtyQjzm+3tLdlSOBYQF0 mUeE+PZfed3Z16M7UHh0suL6kMDifA1OyrP+4n7JSsgzgP8X+Qz8EfZH+XMNnSJ6njOr CcdS2pCLgM76g9/zTOhBZ/HF5GIqrq8hGjp1qsdXRPCjON3fx9xVEXDdn09lIoKh1iZM gisF3Lif5xYq1d5a8RFz4dfxQbjriXPjWToN4wnSSqAoy6Lc6Wdbqt6vl+CN2+DogwI6 t3j+lUJo6PjRsw2MpRNWihBylKQZAftpoE6kodnA9Cc74DqRiTjMKtiTizZ2oAewV544 1Law== X-Gm-Message-State: ACgBeo0l1vz1/9ZCe/FI5kiwZxcBLbiVG2mQRfC7q4UxL9Po787QYrGn mshlankSAXX4EmPQUh41C3hCVA== X-Google-Smtp-Source: AA6agR7QhocX1THln9X3pKtbHqBNFAiz5uUKM16iZZhYB3tXzCoHbb7kshkUQUZ50OlscMKuzjhY/g== X-Received: by 2002:a2e:a801:0:b0:261:91a3:bc44 with SMTP id l1-20020a2ea801000000b0026191a3bc44mr7194605ljq.497.1662963478460; Sun, 11 Sep 2022 23:17:58 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:58 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 03/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:09 +0200 Message-Id: <20220912061746.6311-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Iskren Chernev --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 80 +++++++++---------- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 28b29bf714b4..e39fbb36d8c1 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -150,44 +150,44 @@ additionalProperties: false examples: - | - #include - tlmm: pinctrl@500000 { - compatible = "qcom,sm6115-tlmm"; - reg = <0x500000 0x400000>, - <0x900000 0x400000>, - <0xd00000 0x400000>; - reg-names = "west", "south", "east"; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 114>; - - sdc2_on_state: sdc2-on-state { - clk-pins { - pins = "sdc2_clk"; - bias-disable; - drive-strength = <16>; - }; - - cmd-pins { - pins = "sdc2_cmd"; - bias-pull-up; - drive-strength = <10>; - }; - - data-pins { - pins = "sdc2_data"; - bias-pull-up; - drive-strength = <10>; - }; - - sd-cd-pins { - pins = "gpio88"; - function = "gpio"; - bias-pull-up; - drive-strength = <2>; - }; - }; + #include + tlmm: pinctrl@500000 { + compatible = "qcom,sm6115-tlmm"; + reg = <0x500000 0x400000>, + <0x900000 0x400000>, + <0xd00000 0x400000>; + reg-names = "west", "south", "east"; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 114>; + + sdc2_on_state: sdc2-on-state { + clk-pins { + pins = "sdc2_clk"; + bias-disable; + drive-strength = <16>; + }; + + cmd-pins { + pins = "sdc2_cmd"; + bias-pull-up; + drive-strength = <10>; + }; + + data-pins { + pins = "sdc2_data"; + bias-pull-up; + drive-strength = <10>; + }; + + sd-cd-pins { + pins = "gpio88"; + function = "gpio"; + bias-pull-up; + drive-strength = <2>; + }; }; + }; From patchwork Mon Sep 12 06:17:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DAEC6FA82 for ; Mon, 12 Sep 2022 06:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbiILGSR (ORCPT ); Mon, 12 Sep 2022 02:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbiILGSH (ORCPT ); Mon, 12 Sep 2022 02:18:07 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340452654A for ; Sun, 11 Sep 2022 23:18:01 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z25so13181797lfr.2 for ; Sun, 11 Sep 2022 23:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=XDfWSSZYnHMYa3I+jtVKxklgIjaIvR8V4Z96XPKAank=; b=JJKAJOgELOlwmCL+BnBq3mbcAiPTeSYOKDMEIK2H/haWGfWpmu5/LPNSSOZnV63G0k 95Jr1uJEPAqaSaQXQbMRndo54Vxe+8a3prJ4xoHZmET55DephfF8RQoUH/fUyXNZkNQ0 T+9xh9L8WQu3OeN0C4kERarcfgvWPnLEitgZGiQpD70oA0ocS0zNrWn+mJXsF46FmELY CicZzhYFu00I2xV42gltvePL1dvwP7GoVOcGOLWvWSO2DPOnNitLjo0b5CH1drHzoaki fXqAZzTyj1vOAlB1YTlsMDuQI8xFyJxT1kwQ0Xo2/wBhLcLRUlvIEZeOeERcUMR/XDI9 74wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=XDfWSSZYnHMYa3I+jtVKxklgIjaIvR8V4Z96XPKAank=; b=b7HcTCYZEhKzJC9Vv3AFNmuREuSk/jR0DftgKrJi76EON2uNa7GfpiT8KeVFSzMWW9 eY/hWj26IzxSi+vNhDMnQrOAmEIWLrooGgmUbTua42wTYdlJuqvdORD4pevYfss5Z16l wuK+3ZRe9Xh40u+mzeecv2V8jxAp8Ne60bzrifP/5O+7K0S+TRVdv79AgCVWAch3jSAr PpbHa3a5ayX20L1tDjGrGx7WUb81nB/ToF5HFKSLAgoSsvuPzbkBidyuM8xwjg+phMoH 1UY1JHQLb8oqFuEjTOs41986ajOqDwbKbufskkTDoNpA+Vsq9b0BvbLKd3YodhLz4s8I 8Oeg== X-Gm-Message-State: ACgBeo2dOAThlzkVBNhnnzlnQ+GCR/NCY9MJlyHrIQwV21T8j7SQXxaJ v50NitIlPF5HuKswaQ4RUh4JwA== X-Google-Smtp-Source: AA6agR6517MOdeUu/5+gzOzJj9LdfjK+/YCE3DzsF+tfaNofqE16a2BHRWuHpPnAx08dbTwm0qPPwA== X-Received: by 2002:ac2:5a46:0:b0:498:f53b:d19a with SMTP id r6-20020ac25a46000000b00498f53bd19amr5921684lfn.674.1662963479739; Sun, 11 Sep 2022 23:17:59 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:17:59 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 04/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:10 +0200 Message-Id: <20220912061746.6311-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index c8eec845ade9..84ed16f9915d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -51,8 +51,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6125-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6125-tlmm-state" + additionalProperties: false $defs: qcom-sm6125-tlmm-state: From patchwork Mon Sep 12 06:17:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605617 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 719FCC6FA82 for ; Mon, 12 Sep 2022 06:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbiILGSV (ORCPT ); Mon, 12 Sep 2022 02:18:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbiILGSQ (ORCPT ); Mon, 12 Sep 2022 02:18:16 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D56626138 for ; Sun, 11 Sep 2022 23:18:02 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id y29so9324614ljq.7 for ; Sun, 11 Sep 2022 23:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=fEX3mEf1YS0VEGkwrFu/5ECJ6Ev0hCKVagP2clm1WMU=; b=fVTuBzBUkJ22VyHG6FNWHCYgoRTNWjgDMyVIXuk5sPhnDy9eMiAtlWYY0PFzdJhw/U 9+5yWBbsHubw+nvqkA1HLrAS/8/1lKSI5915T74J9v3RSmSdCTTb2ln2Mzu/JiXtj3FS 1MvRPCL0Fgc68BNi4TdRhQmgamnDzYCS2SyWM62/DGd0wh9wSpjiSqyyPqLoPWD0bFc4 NZig99eryWwBIx55fgIpZSlt1dV7SbwapfQ+IWbWLtWq4Twl0Sxb/mXCLlWbuvHGahnO wnSj3BnhqAjSGvLRc8QAuakyz8X1izLxPP0juDBdmNoLgP0IfekWnN7fOnFYPg4moGi6 4xrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=fEX3mEf1YS0VEGkwrFu/5ECJ6Ev0hCKVagP2clm1WMU=; b=MDg6S/wNWL/igsu9D76vR3EOwjd1HT5D10W5zAYvdEHjmMQD2+l00k2r0Fn1W3I89B ZckwQeCp8K6ikpgpgLWNiDt/u7NS1gPCU9t3Z/0d4oNi0/NllSo4hRPHe5Xsg1Am2A9G AbyHHBgKG5lY8RD3y7NPofjGDchzzcmISf3y07wSpD8th0pIJVJn0AAvnb8wJUpc8Bzn HI3zlVgc2Xcctv1ZLyCRYdzV198aXZRX8BGU0Dlan7I6on0bUzp7JpHqTV3+R9KUqRNp RiF1WkJ8+zaSfy1uOfVzWPyyZTcjQHoY5Wy/BgIGBaZrGUC3Xb2CCgnyHoSRgZM7tbaF zcmA== X-Gm-Message-State: ACgBeo1+Wnht8ynWTgLyaGPaaV1EN7gl8yB/YDNmZp44VeKvXgyKoLQN wkDFj+yLhzAUyVyLkhhJfNxuqg== X-Google-Smtp-Source: AA6agR4M8TAMHhPFbvbyPN9nvAjoUxf1GnokNm6GLAPiY8e/5IWPCyGMpO033fwrrhvc4VXrB2/CtQ== X-Received: by 2002:a2e:5cb:0:b0:26a:b1bc:bba5 with SMTP id 194-20020a2e05cb000000b0026ab1bcbba5mr6959655ljf.93.1662963480813; Sun, 11 Sep 2022 23:18:00 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:00 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 05/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:11 +0200 Message-Id: <20220912061746.6311-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index 84ed16f9915d..735eb5d6834d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -61,7 +61,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -112,7 +111,16 @@ $defs: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio[0-9]|[1-9][0-9]|1[0-2][0-9]|13[0-2]$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605150 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F293C6FA8A for ; Mon, 12 Sep 2022 06:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbiILGSV (ORCPT ); Mon, 12 Sep 2022 02:18:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiILGSQ (ORCPT ); Mon, 12 Sep 2022 02:18:16 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CC9E2870D for ; Sun, 11 Sep 2022 23:18:03 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id y29so9324653ljq.7 for ; Sun, 11 Sep 2022 23:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=F43nv8/M+cL0CQPWEGRQlPTNWaqRQm3bONcFJuSIY7A=; b=A7XnkFV8JygYpzI+K7FIUb7NSbKPQhJ86e+gadfJ11SGAzkTHjVP0B8wKi1WlLAjDT FxcV6fLHq2EaU1ynM4X1z0909bqA1Rt2dWAXubIwo5+YLV9qELixFeCC9xo8/2NQSi/t wo0HHxNzmJRyIBQ00wsdrn4xJyTx1SrUm7/nfb61Cr2CAAAdOF1cocWDfK0oCvhTevjT C1jJlK12W68d4kY6OxSPKSqYI75TsVAfq6h3HFRZxfN7eE1Ri6RIW6NyARAVo9S9+7Pj v+58UdCE9hIUhsl+pom7C9P7uCJAXfk/rLEQ+RvbGaw5dQxr5UODLFUfPBCkDw7B2yjz ELUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=F43nv8/M+cL0CQPWEGRQlPTNWaqRQm3bONcFJuSIY7A=; b=kBrJ6JmSBcga2ZRnmj+UKFgdZZYBY6JxOixGtp8HNMWtUnebHhrQMgvbQ8PpwCvW/1 +DGgVk8iPmj6TYESOIPcr6wV+5qLtJyehI+fV9IH0Sg3ppwwQjQk4H6tJ773sqA3BmhB XDySUulc5W2QBldQD/u0M/gYAotKiKPUtRlh6+sy6wbXEoAX9/rzBYV+Wdbuud2/0YNn oGTmwJeUM5vEtbHDImnHOMj16JPd7JtsJI/+Xaf2IiuI72UTevkY0iUupm6UbQhE/K7d x3fYpddacaLiBZwxhDZWySKxykyd8Peh6cw3V6MMFY3OwlnTPbiiU6+G+iGvnNQTXYYd V6Fw== X-Gm-Message-State: ACgBeo2knd0IwUFY2JEbxl/OuXydTkECupQSCQTSoq3olUzvKAoyOP6V i1vx1ZXrHdnQab9DrCtebxRORQ== X-Google-Smtp-Source: AA6agR7X1hSRlJCWjl1EPIyxzpnPf13OnmsIlWlF9PER1H8bs5y2ZqqsChORkdl64SClLdzgNvYEKw== X-Received: by 2002:a2e:a587:0:b0:25f:e6ac:c287 with SMTP id m7-20020a2ea587000000b0025fe6acc287mr7087104ljp.416.1662963482077; Sun, 11 Sep 2022 23:18:02 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:01 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 06/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: extend example Date: Mon, 12 Sep 2022 08:17:12 +0200 Message-Id: <20220912061746.6311-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Extend example with children for pin configuration and indent it with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 46 +++++++++++++------ 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml index 735eb5d6834d..5cb8b272cb7d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml @@ -126,17 +126,37 @@ $defs: examples: - | - #include - pinctrl@500000 { - compatible = "qcom,sm6125-tlmm"; - reg = <0x00500000 0x400000>, - <0x00900000 0x400000>, - <0x00d00000 0x400000>; - reg-names = "west", "south", "east"; - interrupts = ; - gpio-controller; - gpio-ranges = <&tlmm 0 0 134>; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; + #include + pinctrl@500000 { + compatible = "qcom,sm6125-tlmm"; + reg = <0x00500000 0x400000>, + <0x00900000 0x400000>, + <0x00d00000 0x400000>; + reg-names = "west", "south", "east"; + interrupts = ; + gpio-controller; + gpio-ranges = <&tlmm 0 0 134>; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + + sdc2-off-state { + clk-pins { + pins = "sdc2_clk"; + drive-strength = <2>; + bias-disable; + }; + + cmd-pins { + pins = "sdc2_cmd"; + drive-strength = <2>; + bias-pull-up; + }; + + data-pins { + pins = "sdc2_data"; + drive-strength = <2>; + bias-pull-up; + }; }; + }; From patchwork Mon Sep 12 06:17:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605616 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2616C6FA82 for ; Mon, 12 Sep 2022 06:18:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbiILGSX (ORCPT ); Mon, 12 Sep 2022 02:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbiILGSR (ORCPT ); Mon, 12 Sep 2022 02:18:17 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A16CE29803 for ; Sun, 11 Sep 2022 23:18:05 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id f14so12192600lfg.5 for ; Sun, 11 Sep 2022 23:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=u03qsv1ayfTU6Jx4uWdo7qxMiGgjgckKImKOyJnLF5w=; b=a5qFYMQoEm1+4yxovQ3Ef2O3ttvBtdH7U35anDVIDhwwF3yBcFOQRM5LKQrrNPePsF 8PxmivF0jtVa9KJghmdDhWsQ8cvJJvP7ILP+eJGQU1U4bWzCQW5so4ZJP2Z1Ndv3uGM3 0nZT2DY3G0VxfQeLEInmx1sN35jA8rLWDgnyng58y92crc0H1hdwWUjRNO4TmenMReAN pizRxzbEwBkf0/B3twPCX8Y+SAZlhc+wEgbb2Ev00YEx7cswtb2JJKaMDqWA/5EShrZw f/8FV5aASHlNPV9gT+ywkmfiPZ+TzLxygAZFRmDCT2HmFo+9KPfLzP/QCtM/g9Csj/J4 AQ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=u03qsv1ayfTU6Jx4uWdo7qxMiGgjgckKImKOyJnLF5w=; b=DwPIOp0+xJtK2xg3Q6PCDzgdzFB3yp66g46QZZeTIVCxVVavonmz5ekEBDaJ6jzKdm O9zici3ftKzLfR4w4zIsd/DxpdG8B65YlFjHzTRknYELIWiySAoQNJW86tdnaImUsKIp Gix3T+qAcFXB9yzDl8oriT6fm2dBRNhKVodsqO0724p+T40Z17m1jNHJDOWyMHS4oJy0 2ZPlwBxMEhYDgLkppgaDyZ6R8eGdh2ZJneN7c9qToz/Ofu3Tk8S7md+ayBD7gchZmCYO k6iFyik51n3kM5erfEX2+zQ5jd5hTlrRC5bI9ODqQqSdH6ss6cVezCKiDuznj6Qibg5L GZHA== X-Gm-Message-State: ACgBeo0d0suOZsUH+kkUCUGYhqYvGOakiOOPG0C4ZRdtg3pRNfFhs/hn mqDqVEolqe/Nu82Yc67OBeWlMg== X-Google-Smtp-Source: AA6agR7nDfo2PcytVMo1uVWx8E8ef+HVm/VXHhh3lbmOPty2aOgtyO7Da6aBn+MTpiTn9sJssYEe2Q== X-Received: by 2002:a05:6512:3ca2:b0:497:9db7:ec10 with SMTP id h34-20020a0565123ca200b004979db7ec10mr9150052lfv.350.1662963483323; Sun, 11 Sep 2022 23:18:03 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:02 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 07/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:13 +0200 Message-Id: <20220912061746.6311-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 898608671c4b..85a4ff5a5625 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6350-tlmm-state" + additionalProperties: false $defs: qcom-sm6350-tlmm-state: @@ -133,13 +134,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio25"; function = "qup13_f2"; bias-disable; }; - tx { + tx-pins { pins = "gpio26"; function = "qup13_f2"; bias-disable; From patchwork Mon Sep 12 06:17:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605614 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CFBC6FA89 for ; Mon, 12 Sep 2022 06:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbiILGSd (ORCPT ); Mon, 12 Sep 2022 02:18:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiILGST (ORCPT ); Mon, 12 Sep 2022 02:18:19 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F28ED28E14 for ; Sun, 11 Sep 2022 23:18:04 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id a14so7212751ljj.8 for ; Sun, 11 Sep 2022 23:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=QW6MO1hMHGswxNmgzSJJEoxkkpvgP7Us3KREmZxCiHY=; b=Yu9BrTqQcEnJxEPrrVuFTQnTOJd6wG3FOfZq1tyHXe7MODQglhQ2YwW76KKgFxHMtc eaBS3IIh7jA1ahDEkBkygX8QqnmH9rBo9aOmDD3Mfs9/TcUZxYucYXClO5a3o+Yh52/C Icgoa7DM9ftsY0BycYjoANiKt9ZF7Nlz6lAMvTg6KCDb5AJLEyvx6j7embQb+xf4vuyi MI2w39tuOb10Rig5XHBJC4tWxhqCZr1HY9n+mgOSA+26ZVCrt+tMZwtrbloqbDXY+rmb 0XKTEvffzZwuYjPPiGqWiAS7buUNtsO3eZkWWUaH2YjlrEWmQRNP4Fb9LynxIJYu23/i 3vpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=QW6MO1hMHGswxNmgzSJJEoxkkpvgP7Us3KREmZxCiHY=; b=unAnVsqp5jH+u8ZbRvg83GoZU52fWB3fIPBoxNQw8qHLb0CBq67gCwlWgAZf6W0LUa Hkdocdji4u2g1P3q552rzgyIcbYWL6ob3+by5jJDgxA3oNIBtr1Ohr1u9vcl2H3gJFh6 JxJZtIcW/l4BNwKI/ScMIv5qH1S1eslVL75VLNkMV7I9C/GPu3ZC5cpcnyKCvU8XkEwc kyUthekeAfmrtOFOYfTaDZzil1nZgC3V/qnf9EBczmDyQHmRuwqkierizCvFtF2eHRSw iVj6kELX9/wIpEGd+BExlq/mvPZqR29qyc4E0HZ/ptc/ik8r4OffQ2FM6kNT1q2TSW+m ZABQ== X-Gm-Message-State: ACgBeo2TQ/IcXSrSU6jN+UaVJ1IQEt7NslxuiV8EqDYY5Z5evlZZMAyr veqmQBICVs56z/mvqcS7Lh+85g== X-Google-Smtp-Source: AA6agR5e30kVHJtnGRAqmDS1vesInkLLMyggYUjIYvaBWvXOR2+0CczdiEDd5g3ruvNG032Y0ncEQQ== X-Received: by 2002:a2e:a4b1:0:b0:26c:521:76b5 with SMTP id g17-20020a2ea4b1000000b0026c052176b5mr1205004ljm.258.1662963484412; Sun, 11 Sep 2022 23:18:04 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:03 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 08/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:14 +0200 Message-Id: <20220912061746.6311-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 85a4ff5a5625..0c4bf6e90ba0 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -111,7 +110,16 @@ $defs: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-7])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605615 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CB8ECAAD5 for ; Mon, 12 Sep 2022 06:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229690AbiILGS2 (ORCPT ); Mon, 12 Sep 2022 02:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbiILGSS (ORCPT ); Mon, 12 Sep 2022 02:18:18 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5A1629809 for ; Sun, 11 Sep 2022 23:18:06 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id by6so9298314ljb.11 for ; Sun, 11 Sep 2022 23:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=dSJXKFEZI4T1kbFyh1aKF3VNgs72FXruybc3OKrfZRY=; b=OYnKB00l/lh4t3hosBq7sPudQrWN98jkklZEAM7wrHZi4WRJJajlSYWbsOBWEy3Wt9 U1iez3g/sOAZKFkfCcBbuWBUWQDoKoRT0myMJDLjDxCe9KpU4SF1Az8dgLJehCrHr4N7 8z/qDb+zcwkmGUzk5D3bLU27DBEr679mqRbq7icqKrDI4md4sdevTtMakMBAeCtQd4E/ PEvsnB/cETQ2SuffQMPKzJodb+P/n4qSehEtma4eBOFgNpAHrblENdQV0qKFr9og88p1 KkpIwz3fF/yfcYvD/tmyGxk0wjHSeuXVpKJUgcWZNrB4Dda91TN4JxwcvRngNuBuW5jO BbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=dSJXKFEZI4T1kbFyh1aKF3VNgs72FXruybc3OKrfZRY=; b=HSkEVQYLKlCY525qF/tMNH/NuOoGBqse3+gH8cIk50vMxtaOFWIJ3TZxbgUHqYdytE iRMBkcmfLM9pevEwj4opw3W5OI5eWL5xQYp3X3bILTuZqe4dydjyLwApSYzdFKgzY8F+ nAqzp6mkc0+xesJwtKd5gCsUN1GHkmZ6d6iSF4CeeqsLjEuLTb+tfOtucq3JXnBvQlpl 7+0bwpjHwG+GAtXarPrjtniCTFudKQ5SiazQct/GaDeIxa+VwmkwFMyEOM8lHjkdJI2r iJcFp9aMjwZ6+Osxqr3AGNXWS3KGdh/u4Sv/LBccA4CkxzI+oD3BOiycyvwRoWS4VJyM vStw== X-Gm-Message-State: ACgBeo27haw+hbY71bzFwN01U4mLFAg+sVAVfBAVe5AQhZxQYT0uQyem +QPHLlVd5hkuav7MzRVZD8oxBg== X-Google-Smtp-Source: AA6agR4WQR1eg6E6HyOOHovMK/iMZcVJ/7te7mGe79HMH/duPhKgGkTmuwVbvSO0omzw1OLxa0OTbA== X-Received: by 2002:a2e:5356:0:b0:26b:dce1:419d with SMTP id t22-20020a2e5356000000b0026bdce1419dmr5323661ljd.52.1662963485739; Sun, 11 Sep 2022 23:18:05 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:05 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 09/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:15 +0200 Message-Id: <20220912061746.6311-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml index 0c4bf6e90ba0..856b9c567ecb 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml @@ -125,34 +125,34 @@ $defs: examples: - | - #include - pinctrl@f100000 { - compatible = "qcom,sm6350-tlmm"; - reg = <0x0f100000 0x300000>; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 157>; - - gpio-wo-subnode-state { - pins = "gpio1"; - function = "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins = "gpio25"; - function = "qup13_f2"; - bias-disable; - }; - - tx-pins { - pins = "gpio26"; - function = "qup13_f2"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible = "qcom,sm6350-tlmm"; + reg = <0x0f100000 0x300000>; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 157>; + + gpio-wo-subnode-state { + pins = "gpio1"; + function = "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins = "gpio25"; + function = "qup13_f2"; + bias-disable; + }; + + tx-pins { + pins = "gpio26"; + function = "qup13_f2"; + bias-disable; + }; + }; + }; ... From patchwork Mon Sep 12 06:17:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605148 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C1CECAAD5 for ; Mon, 12 Sep 2022 06:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbiILGS3 (ORCPT ); Mon, 12 Sep 2022 02:18:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbiILGSS (ORCPT ); Mon, 12 Sep 2022 02:18:18 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8011F29C83 for ; Sun, 11 Sep 2022 23:18:07 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id p5so9308158ljc.13 for ; Sun, 11 Sep 2022 23:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=32LY4IbEPjFm8JO/WRWi4obqGJa0d6BNeLwZ83eH6po=; b=WCnkuogqu7kQCyySlMwsIlulnXgYiVr5RxZd68Qj3KB00YqxTjGtAKuc5MwsQUHYoo kmK7+WEA7Fth5kid6mrA6rake6R8gFokF85xN1GI6iScDaLEzR0h1TDpljBwlbgW/p7X ffW19PP6q8Q5dpemuB3THQcZlHqbFkaPyrjCDSEU9Fl92TDLrAvUHkziNM5vJLRB2iAl Go7KqodPT3JDgg2zeUgsw8JeSH6t2509Ofvlyv1rdH9ORY6NjQnFjOgnf1Ibnqo8lOfg gze82PO3WkTsIAeKtfsPenMyjUk+Ai+ivJBYCzFU87NWz+rnKgMb2sAdT/rl55qP/ank FPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=32LY4IbEPjFm8JO/WRWi4obqGJa0d6BNeLwZ83eH6po=; b=tBFcV60PjnwZhE2CfztCyDRRy+oBJ3BQKr8PaWY7LIsKh2ud1hbMbfe5DXNEEc3rbo faNsEbBy2YoMvBxx6govFJbvjetSUEBXJZxa78vHrGpk24gkQT+aao1aTYMS4+CEjkon wNGc/mMLyBWNgcP8rw39MsB2G220KosisjXHfsL1ZRn+WwCIPov0FKurtMLK2VXmb3+k m0thwKtOjE7XIBNgFBVev7g1hXrgwr0rS0PheoFAWB/hR9c/VPilZPerbGiklz7Qn8Rx dtsd9wOxxBRzptbkz69NZCACpaJs0XYpDtOZhRDBSPed78f65zKn471zkNc8Knc1kYCc p8lQ== X-Gm-Message-State: ACgBeo1nucrV0m+8p2Kmza5IVVWywVGgZYBGoLwjdKMwf/l504hKpbZz 2LZj6l1LFDK7ug0sBKV/ck19Ug== X-Google-Smtp-Source: AA6agR7+hZOh3OMyOgpPiLFCoMoouG6n4+mB59qgB2hYJA/6/Y1BW+Jo7prrvciHrP4MVH/mpR/vUw== X-Received: by 2002:a2e:8190:0:b0:26b:d94b:75e9 with SMTP id e16-20020a2e8190000000b0026bd94b75e9mr5994084ljg.379.1662963486842; Sun, 11 Sep 2022 23:18:06 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:06 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 10/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:16 +0200 Message-Id: <20220912061746.6311-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index 3908807a8339..50f0ca5ab7e7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm6375-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm6375-tlmm-state" + additionalProperties: false $defs: qcom-sm6375-tlmm-state: @@ -142,13 +143,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio18"; function = "qup13_f2"; bias-pull-up; }; - tx { + tx-pins { pins = "gpio19"; function = "qup13_f2"; bias-disable; From patchwork Mon Sep 12 06:17:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169D0ECAAA1 for ; Mon, 12 Sep 2022 06:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbiILGS2 (ORCPT ); Mon, 12 Sep 2022 02:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbiILGSS (ORCPT ); Mon, 12 Sep 2022 02:18:18 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4772275FD for ; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f9so12421708lfr.3 for ; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ozqjcsR32neOzHv2L/2DOKBG63rqHKYUg3f24PJLOOc=; b=HRXfYKOKYFo928QWTJ3XEeNmTLfXNxtR/ON4IvkVbjcN2wLb8jBCHmxgVK2bIH+8U4 JLBAdj5mQHCnpyskwRIu/VmQAcGkVCJjQNYYxMO9kPn73S8X9Ieeav7pmBRHGOMvM7Bs COPnYkj5ggVLHo5DVdGM0fyxdRlD61E5cKhIxmtoQAJRAURxh8kHGpujtgiwZFmzsqNj u/PIRrv7ne0/H8f6rM+Az/m5beHkqfCi1/m5mrcNCP5idGwfj5GqS1DE9SHlDU74zPoz lNDwjZFnf1veGs4hNVh2azL7A7+pB9IBnxl2fyZo/tEoKWPDiXRNkzvoY9U33H0Fh26U ViFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ozqjcsR32neOzHv2L/2DOKBG63rqHKYUg3f24PJLOOc=; b=PwBSlRLMh4gQuSw6E/Ptxx9OI7ATNgCbR7qyXSrA7DuANjRqbgKpaGmKUrgIi3gMOA zYRs6D809moMvr+oDsdGWNkfrKnAi/la18vyjx0Ddz+4lJ3UcvEzxy5FlGJfg1eD6K6g MO1aqEZNnJ+w5/glfsp7b0pfnuyISPtPtZBObs/TItpAUO+C1tbsYzeR9r3BEDWq3lfC 3Czm7cCPL59jTiSEJHzdCYrzSP+VJmp7Wf+dXE2omCKsRn3gZmb7xepkUxgRDxsmVlI7 2v3ceAqErSmAzlqroXLHUGLOVO3/0fkJLAiMiXSfVg1b/qIwXUYec8IzSwjn6Y5kbNlY O3TA== X-Gm-Message-State: ACgBeo1OT+Lf/LGEqJKfbWI8pcbNu2nkoJ/TooHnLzz3TM/uFWOFGfhz kpCJTf/9QQbipXfTFO9UzALXUg== X-Google-Smtp-Source: AA6agR5vkTc5bkDXc5Fm76W7X9SzYXQM9MwiJVKojNzC/A4IpZJDSLBmWCYARjlCcfu3cz7vOxslGA== X-Received: by 2002:a05:6512:3f18:b0:492:ed03:1aa8 with SMTP id y24-20020a0565123f1800b00492ed031aa8mr9230762lfa.515.1662963488072; Sun, 11 Sep 2022 23:18:08 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:07 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 11/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:17 +0200 Message-Id: <20220912061746.6311-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index 50f0ca5ab7e7..dbd91d6b63b3 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -120,7 +119,16 @@ $defs: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-6])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1F2ECAAA1 for ; Mon, 12 Sep 2022 06:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbiILGSu (ORCPT ); Mon, 12 Sep 2022 02:18:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbiILGS0 (ORCPT ); Mon, 12 Sep 2022 02:18:26 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947432A269 for ; Sun, 11 Sep 2022 23:18:11 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id f11so13137309lfa.6 for ; Sun, 11 Sep 2022 23:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BzxKI895lpDHkY+H8tKxOiDzUL4EnCHd/mNz95fFCeE=; b=Xlg2dIPv8xQTI2AgZqSOy0a3Aoq6/qTwvZp96vZCURU6ZFq6elhBgbi+MDZ+FWhwl7 rHCaWo2Dg7AdG/tHit2VZWr5/Mwq7CAI4JXV91OO88J9cb61e4OTOiONNSU3QCw85qi1 HsXwbWSs84Zn5XJ/YMcrDGhtEBXk7DD80Hfh72uoSZBRhnp3u0NLHCxcT3X+NSMSufXA bOA/spka51nXO7cPIyvCzg9A9DMeYSuWkVQaNVn+6CBxYd1BF9/MOBeK80Z7XrClV1t9 paOd+HnY92BLRntDxYOFYqHXmudEkD+IvsJs1rJ4XEAfy2ZaMH6GRnmFNjdd1tolLBUF YehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BzxKI895lpDHkY+H8tKxOiDzUL4EnCHd/mNz95fFCeE=; b=yLBKS940KftqJrPmz2DZKbJEyUHSZvD/EUbMlTQiiJH1LcOsLdVjZSCmsGfjfy8IJO 8mLgDo6du6rdOjQQaukjoj/RZqBRjJtwf9uvFvRbTNsTjvzPImJFI0xp5JPcdHOCZLpy qWaVIGJX/5B8uKNx3ofUehMwxW9VH6qFZ8rFOJUmjI4sL4YbI93CC1X9RweNC6jxZZkj xdq/y9Pk6PXPHm9bQi4iOIvQt2PuNB5YV6XyS5MjD7wJY0aDJhKHZQT+Tx3iDDkFGKL+ wT866tkQLbA5BxfXrLl2P7uQ4pFvgqnDtysoCGL64qigXZIFnSxvoIPrrZcV0ZpeXnS9 Gudg== X-Gm-Message-State: ACgBeo21OOXCcPP45XfM2CcdfQgG60waN0NmUun+EecwW5QRcRtgj48Y 6i3qFEr0QFN4hxtOUrvd2jD5zw== X-Google-Smtp-Source: AA6agR6sXXzrqW04NblckGlbqXqV1UYsxNrNzA/iOY8ECYU7WjBS/pjnOgtbds7HAADn4Lg7FRDjwA== X-Received: by 2002:a05:6512:1687:b0:492:db5e:7768 with SMTP id bu7-20020a056512168700b00492db5e7768mr8804019lfb.118.1662963489273; Sun, 11 Sep 2022 23:18:09 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:08 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 12/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:18 +0200 Message-Id: <20220912061746.6311-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml index dbd91d6b63b3..025faf87d147 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml @@ -134,34 +134,34 @@ $defs: examples: - | - #include - pinctrl@500000 { - compatible = "qcom,sm6375-tlmm"; - reg = <0x00500000 0x800000>; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 157>; - - gpio-wo-subnode-state { - pins = "gpio1"; - function = "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins = "gpio18"; - function = "qup13_f2"; - bias-pull-up; - }; - - tx-pins { - pins = "gpio19"; - function = "qup13_f2"; - bias-disable; - }; - }; + #include + pinctrl@500000 { + compatible = "qcom,sm6375-tlmm"; + reg = <0x00500000 0x800000>; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 157>; + + gpio-wo-subnode-state { + pins = "gpio1"; + function = "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins = "gpio18"; + function = "qup13_f2"; + bias-pull-up; + }; + + tx-pins { + pins = "gpio19"; + function = "qup13_f2"; + bias-disable; + }; + }; + }; ... From patchwork Mon Sep 12 06:17:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35550ECAAA1 for ; Mon, 12 Sep 2022 06:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiILGSq (ORCPT ); Mon, 12 Sep 2022 02:18:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbiILGSW (ORCPT ); Mon, 12 Sep 2022 02:18:22 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 308A528707 for ; Sun, 11 Sep 2022 23:18:11 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id u18so13146262lfo.8 for ; Sun, 11 Sep 2022 23:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=huMBt2cOX5WYiW0m7Bpoars+zfOhAPbHFngq8gou9wo=; b=T8PDwPdVBimQHwxsfBUyfb4uH8nlYDvxv5g/QTxqnWH2LPwNzVda2v1jBaZzGREdVb EeAsURrwAHNtJ635NC2elIa4KJZOf2q08BukMxzmhU8DW8fxkPeDMAhrJUmFJ7jHMHQ1 k5rF/NhwGT2UicyG33Tm5TDHrXdiPTaPB84r38jG+srb5isFjWn1++4Q19e6RWhgjL2f zngl0U+K546t+Ex1Bgkpq+a5fPdxsLjBokKDpiEAUHKNmk6R+bJ6RPGpnR8NoEcjFSgX HG3oXxavYasohtl+8HxkTZbz2Ri5emIttgo+5T/c74/wBwp53gKOSekXze6q/jdla6NN LEZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=huMBt2cOX5WYiW0m7Bpoars+zfOhAPbHFngq8gou9wo=; b=Z3yWm7zqEtLYzr/lhCmVE2PqJXld4TW0xtfA+KawfuvK8O9KcvxpLGFvO/vAdMjoHC YexzMt0Pdzji2OhSzU3TP99fcpFHITWXL1jj3Whj/EFBjEHTZrUR3BHvjF3m4P+Kstza 7wcZ6vQ05CEbRiQBskdP0TwvJbNbrpltcgtpTSgBQInygzKLxunmP2e2RaOMq42CEmLM 60PeGGcAWpa4is+t7eyd7hHcK3LtbEaD62aJ/6ZL+cNMEM7SEqO9OXNu3STTZ3fK8qD7 e5S/BMqhtoTUaln6Yucqssorn34/xuibD372AEdUflT7nHN6zstlpg+guwZibM3YarJt cRUw== X-Gm-Message-State: ACgBeo0hKNHNxcRptqNYLzZFta8sejNVN9KI44z79euwWKCZc7RuQmPp zro2fih5Pe2sKMDuSPY16OncKw== X-Google-Smtp-Source: AA6agR6fRJ9q4A31YGpIAzK9KA/cdCWDaEg2eAV3NGrqf+BNeg59ngLbUvMSv4CZ00GGrrC03Inumg== X-Received: by 2002:ac2:4e0f:0:b0:48b:7a5f:91c8 with SMTP id e15-20020ac24e0f000000b0048b7a5f91c8mr9052330lfr.430.1662963490535; Sun, 11 Sep 2022 23:18:10 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:09 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 13/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:19 +0200 Message-Id: <20220912061746.6311-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index 15bb1018cf21..12bdc2e67c4d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -110,7 +110,15 @@ patternProperties: required: - pins - - function + + allOf: + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605146 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9A9C6FA82 for ; Mon, 12 Sep 2022 06:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbiILGS7 (ORCPT ); Mon, 12 Sep 2022 02:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbiILGS1 (ORCPT ); Mon, 12 Sep 2022 02:18:27 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4266F2A407 for ; Sun, 11 Sep 2022 23:18:12 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id p5so9308341ljc.13 for ; Sun, 11 Sep 2022 23:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ShPxgoMmuatqdGQWqNcZcpEJgDBD4NgqwMQX8EaKFn0=; b=Fc6pcgSEjUllry/Al9MHF/KiX476+f53LdQEuOfMlDgUBS0Y2Lysc5JDWCUJWQf/YR mRFsv6PSjAGrtHwJx0Xih2EBD9/NlJc2y4Pb00QpZlzGGHusAbnUn3OSEOy7U+ho1nQw Bxtw/FZYD0UVc8WE5M04VI0pWEfH88l2vEQZKCg7UTF5Mr2zRan172kVk/yiTBXWXjJD E5K7/zTPSikIe+QF+UtZBnoHqhCJMYeYIvbJPWpkM6cdUd4X/8WURI3c2oRGVgvS4kE3 o5lvrBXuf2AqSQ3CfdWB1eC7CC154Dh/VZ88zoxSOwBsvX/nWfwWfnVIhzPW+EyKxs9y MfXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ShPxgoMmuatqdGQWqNcZcpEJgDBD4NgqwMQX8EaKFn0=; b=l3i17PSDFxYFo+3vIJAFRrQnPD+eWHQxs8eSmfy59hT49fN8X1TkjR9w7uTJ3n1Y4K IDiT8X0QKfmzwOVbC2o6So4upPKbrXjzm8nMJb2S9Pl9ZY7CEm5e3L2qipGMkCuHG4iZ Z1DnmtBmjEO5f89quAfBTagfqeUulNtMY6K62YqbYg/yQpdQorA7zg+qswYNjotdurUB BrClS2u57iCEWtX/ItxRMfQ41Olt44zl2r78uagbFgFIZkF72kxYAcVn37w4HtzZp7zj QD5inrrC210adVTLeQuRDqYpHGNLckp0KvknWZtVZnXThZw5yZ7RtsMEWYxhehlWF+Ks FF0w== X-Gm-Message-State: ACgBeo1jZXh7m1wMe8qu55nVEXulgtMxDL+M/ZGKnFHpJi7WABX/KZAD JBJDdeSNS+O9D+rCAnVyVpYVEA== X-Google-Smtp-Source: AA6agR75yTn57lU+jCF17X4UVDBlpwHYMObteomolVN1OiWv6zhw6uhH6I3NQc12mYKAd+lqers/MA== X-Received: by 2002:a05:651c:160a:b0:25a:62a4:9085 with SMTP id f10-20020a05651c160a00b0025a62a49085mr7579297ljq.214.1662963491657; Sun, 11 Sep 2022 23:18:11 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:11 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 14/40] dt-bindings: pinctrl: qcom, sm8250-pinctrl: reference tlmm common pins Date: Mon, 12 Sep 2022 08:17:20 +0200 Message-Id: <20220912061746.6311-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Each subnode configuring pins (so the final -pins or pinconf) should reference common TLMM pin definition. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index 12bdc2e67c4d..bccc83f22aae 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -112,6 +112,7 @@ patternProperties: - pins allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" - if: properties: pins: From patchwork Mon Sep 12 06:17:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605144 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C275AECAAA1 for ; Mon, 12 Sep 2022 06:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbiILGTk (ORCPT ); Mon, 12 Sep 2022 02:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229951AbiILGTC (ORCPT ); Mon, 12 Sep 2022 02:19:02 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F9B129831 for ; Sun, 11 Sep 2022 23:18:29 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id i26so13132390lfp.11 for ; Sun, 11 Sep 2022 23:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=qxAFFeV9Jghea1krVGY5BQK+UR1GkKeREC8WB6H5B2c=; b=gTdROqGrrSl+2/wJzwvxlczeW+rqBSo9O5tBZh5AMCfufYpHRu1eptMa2gvOexkH8G HUqG4NBpOoNAEYe+GXhJp035hZEjfPiFHZBKJlHDvqoAuxTtk5M+4K1JUUtQjoGlmaTb VHUfRvTnlzyw/n+Mmev6p/pPh0VGS5XDn9xDY1nDzk0gRpZebTGG9Q1Fpm3Z/cbsXNZV YQ8GEMs+OE5ccWatvCHnJefz6e06Gia1ZHzhzQQUsJtVsgF0aKjPKRpoxhnRlZU3bho9 V8hvIHpY1Bi8MItUeuzWhbfFdd5R6LFF4C5fX0Nb0ytbWreOhkrnovbBchnwFGwkhGUF QWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=qxAFFeV9Jghea1krVGY5BQK+UR1GkKeREC8WB6H5B2c=; b=XSXaErwmjB96+7RB0abH3tRvAbPsS5pL0fU8xK2HNewE6IpBxSGcb4llchztLo2fP3 119aiIE2xz9sCxtr2sj5Nk+ESrSlpVbvIIB798bQ/6JmdOVSEtP7R2G4p8g4vL6oQGj2 fPccx4xuXhGfu8ZU19YCExhnqz0zS/ytBoR6qckIX1pnPfCcJrUIyrUaX1FzF8yPzYQ3 qt7xl4s72fA7YszHNs7DuqzD0BqxsYYtDRsyn516AHgbWv67OOc4cyOip0wnItPmKYHu vC39iFmd4aLNpucYXBNblHOS2PhCAc03/QScfGEFTgutUAgucuuvdCYXkm6Ln766RM1y h4ww== X-Gm-Message-State: ACgBeo2dCOQ1lJHdPSaRUhY6IfyxVnyDCLTFx5G/RYO5Cy6r7dErzYhL Z+zFQDK1ZF3Sge2RLa2THa4wCyCRVzhC+w== X-Google-Smtp-Source: AA6agR4yo2Oq6q/w+fQcJQJ371CJ+xnE/8UWXETJpk5WRuihsK1HiT2e9lawhz8pPDGJ/Xi8mdW6LA== X-Received: by 2002:a05:6512:6cc:b0:48d:acaa:8a66 with SMTP id u12-20020a05651206cc00b0048dacaa8a66mr9041345lff.272.1662963492830; Sun, 11 Sep 2022 23:18:12 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:12 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 15/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:21 +0200 Message-Id: <20220912061746.6311-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml index bccc83f22aae..c44d02d28bc9 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml @@ -141,18 +141,18 @@ additionalProperties: false examples: - | - #include - pinctrl@1f00000 { - compatible = "qcom,sm8250-pinctrl"; - reg = <0x0f100000 0x300000>, - <0x0f500000 0x300000>, - <0x0f900000 0x300000>; - reg-names = "west", "south", "north"; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 180>; - wakeup-parent = <&pdc>; - }; + #include + pinctrl@1f00000 { + compatible = "qcom,sm8250-pinctrl"; + reg = <0x0f100000 0x300000>, + <0x0f500000 0x300000>, + <0x0f900000 0x300000>; + reg-names = "west", "south", "north"; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 180>; + wakeup-parent = <&pdc>; + }; From patchwork Mon Sep 12 06:17:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605142 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E457C6FA8A for ; Mon, 12 Sep 2022 06:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230107AbiILGUD (ORCPT ); Mon, 12 Sep 2022 02:20:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbiILGTL (ORCPT ); Mon, 12 Sep 2022 02:19:11 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CB5829C80 for ; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id f11so13137528lfa.6 for ; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Ix0v/JGnTNkLvR8lnkw4PxO4vTS1Ezmp9TWJ/ylE0lI=; b=RNq2Ay6bofF8EtTn8Aa6fJHXRwtjlaMMQP08M8V+KUrrsyuwbPrNA3XJoxh11yduDU XhOblk3H0YAT/Zaz5e79wMpWLiu64N/MAu1+ByC8ua/LVZgEJzpmQIBVPOMSfff4ZdqF 6NK0B9QpibR84J4dKgbVO07aSpU6jiDS5nPK0BcGUWx/13GHjdssakEgGl008YY8px49 gSUzr0CT98FvcWtoo+NxcOeELtPGmWJtmNsdxlbC684gzYiKKnMMx4mqVL7TTkqpggnN Gsty06IMrt9PG2HOPz2JL5dBVFxW0XKidF/t+Zo1dw9PlC5SkTMTsXni9cCMSOpHua8A 76aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Ix0v/JGnTNkLvR8lnkw4PxO4vTS1Ezmp9TWJ/ylE0lI=; b=StTIeXBRnmzuSOxVydQDuDmLNLi4P0DH4yf6UOr/F2HdvgMcEa6yIYRGI5PpMBUqCW FjNibPG+TGQeTBywHWLbkMM7smjuTmoUXYrCthrYABszqOVK2UpB+YeC/+xFrOp4X8EL m2MqI9lVnLN7XaU2C6BOoJp85CTccKkyaJH+AgOs8y740fOejMB8q7KOTwVdR0RhlI0o /tBhqVT4fNmJOvddcW5ekmb9VxC3ezNfzv9wCD0geAnOqAcy9Q+HY1UVUmmCSVbEpkxE 3NBvX4wM1TD6BLfZu3+T3vcSOjXYFjIFHDlvqZQdeh1Oqez6cz7xWezg1d2UDZL/gBSa 9iqQ== X-Gm-Message-State: ACgBeo258WJBRL+v6s1tLYJ6zZvo8haIFRCgMgByrH9aqN4ktavchlg9 NE/fqOp94BaeBWzuXpSwRL70eQ== X-Google-Smtp-Source: AA6agR7oxSPmPzWcJYkvHhpvvohJVKs8ewnvLe9zcbvmo5ONG+O/0LmLLaQElLINXty+TqmeG/Q1bw== X-Received: by 2002:a05:6512:118b:b0:492:e3c4:a164 with SMTP id g11-20020a056512118b00b00492e3c4a164mr9200538lfr.598.1662963494177; Sun, 11 Sep 2022 23:18:14 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:13 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 16/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:22 +0200 Message-Id: <20220912061746.6311-17-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: sm8350-hdk.dtb: pinctrl@f100000: qup-uart3-default-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 6b7789db2f75..211cca11f94f 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8350-tlmm-state" + additionalProperties: false $defs: qcom-sm8350-tlmm-state: @@ -130,13 +131,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio18"; function = "qup3"; bias-pull-up; }; - tx { + tx-pins { pins = "gpio19"; function = "qup3"; bias-disable; From patchwork Mon Sep 12 06:17:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D316ECAAD5 for ; Mon, 12 Sep 2022 06:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiILGTM (ORCPT ); Mon, 12 Sep 2022 02:19:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbiILGS2 (ORCPT ); Mon, 12 Sep 2022 02:18:28 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A922A959 for ; Sun, 11 Sep 2022 23:18:15 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id a3so1166922lfk.9 for ; Sun, 11 Sep 2022 23:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ZQ3YhRzsCIvzwIGS4j9FwdZrsy4eOBBU0P2zsVYlRwE=; b=YFavRgvL8Jvgg5KSU7zov2VEdf7/zxH1U32/swYPYp5f2qVJbinY5B6l54ABAseTH3 1Fjg9xNatNquSqn5PMqNzm9jp5Qj2LA5RsQuDb9Y10qcTLHaSQJBvXuVrUV8qeDit1AC WBsBwTWptg5bhihq+/lF6h7AYnRRqctNJmof7jLiIMkGbpI21HBCRM6uathMx9S9Qz9/ bgOJ5mNE7KOkBXEyv4jHTodPdYY9tZBZqhxNLlA8kogprxZ0ISEIgzHvu/kgaw5OP5Yq K0BS/X/+yHI+dntmO2WvxDLI3XbYyyDDzu0zTAssVURmNjKweg6HpDE8GDIitcM8chKo UXvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ZQ3YhRzsCIvzwIGS4j9FwdZrsy4eOBBU0P2zsVYlRwE=; b=BlrsBftUIGreRvO6snlKIh5nsRQUN1Q4rN9OUoH2ryq8vNZ9yIf9kHLV4eG4w7G4ka KF3LKYEaXxs1YoPkFQnF2oyFQi1+Sn71p6xZG1Y971N+TsUExckirwxbtlKgJBDRtrYc mUHXSlrFQZpVHg6Rqe5ZKASD+9SsyN3Kczcx6odisucvjow80GfDAzUGiX8V4YO0DKJo e+/6kKPKPfeXBmBVWIl6yFxB/i6mHJn1YMdbwJglXsML8i/FOiQ1FbTJC9UgaHsOGgnh tpvYWPgOZnFq+YkcQ1dq3pDOId/o/bQWF057YAoxIyFDWEv/6tM/XrlR56hYthjUyt5m e/iA== X-Gm-Message-State: ACgBeo36RjzQUPkD5mqC0DM8UU8eBqmUOiv6SrExVSnU3O5b9xk9kCCK DniJnsqNjPWBjzNyvSVDCt+cIQ== X-Google-Smtp-Source: AA6agR7kBHj+9dOwtJjEUEh1uLmt4hg7BQQArafWb63SmcnqlHqYdmLuiBg9Z7u/AqTNVBUt0yMFuA== X-Received: by 2002:ac2:4bc1:0:b0:48b:2ab9:8745 with SMTP id o1-20020ac24bc1000000b0048b2ab98745mr8996563lfq.75.1662963495403; Sun, 11 Sep 2022 23:18:15 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:15 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 17/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:23 +0200 Message-Id: <20220912061746.6311-18-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 211cca11f94f..f3106d25adcf 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -114,34 +114,34 @@ $defs: examples: - | - #include - pinctrl@f100000 { - compatible = "qcom,sm8350-tlmm"; - reg = <0x0f100000 0x300000>; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 203>; - - gpio-wo-subnode-state { - pins = "gpio1"; - function = "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins = "gpio18"; - function = "qup3"; - bias-pull-up; - }; - - tx-pins { - pins = "gpio19"; - function = "qup3"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible = "qcom,sm8350-tlmm"; + reg = <0x0f100000 0x300000>; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 203>; + + gpio-wo-subnode-state { + pins = "gpio1"; + function = "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins = "gpio18"; + function = "qup3"; + bias-pull-up; + }; + + tx-pins { + pins = "gpio19"; + function = "qup3"; + bias-disable; + }; + }; + }; ... From patchwork Mon Sep 12 06:17:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7383ECAAD5 for ; Mon, 12 Sep 2022 06:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbiILGUC (ORCPT ); Mon, 12 Sep 2022 02:20:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbiILGTL (ORCPT ); Mon, 12 Sep 2022 02:19:11 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B53E02AC6B for ; Sun, 11 Sep 2022 23:18:32 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id l12so9328201ljg.9 for ; Sun, 11 Sep 2022 23:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=BZ9D0FRQE2grk03g+mdXjEXzyihdHpyqrjbkROOcsv4=; b=TTp7DZxGJuSnK3qrqpKDd7lgsAeYbQrUqzjZLtnmGzksft9og6MTCGIPnpRvGH8l78 935LZxGnhSIwJgrDjLwFI03pkV46Nda36x7mJ6BolP2K4222alRCRCwiudqELPhKYC8n C3KEqhN3YLEk1wYeYH8c2irj1tdvCJG7KkmRCrXsy3PciuWRmb+iSMJ02qoEXVY7WDV6 YYjZhGp62s8k9bOkjEsYX9BODC7SQc/E99rJgVI1J5dONR4Lqsc56YtkrEKlWrHPo2mH f4Bk5F2PC9PgnOaEomfA0T4V3l+nNdw7qOMbkofMSGyZkU7WlmbnroeH7KZ8aAw0FxF9 k62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=BZ9D0FRQE2grk03g+mdXjEXzyihdHpyqrjbkROOcsv4=; b=NtvruR7cNHz/gHD4fQa0xvAKs+7UaXA0rNrArQ9g8MZ4jPYCjYSRVIRy6Bf2PnpX0e 4AnhgC5RWlG9NgwPbtLcvawbsjh4stRiNaMolMatSIJY89eSo7SfE21LfIaT+LO1x2AS yc3JYJtsH2s7zkoJPz3J9AgOnkl12XKiLElWcuhwkG7i8UKqFb3z77gGaFj1J3Gb1Jjl xFHyloC9suS5g/CmtjUaNvIG/LjQ0ApW7NVdtytoBiefMvR/2Bi+dI0u3SaJyr/upKu4 BIkcHNApILda2VVHvK2+8BGKrcLO4f30suKkLzf7WQKzel8tJi33TGTThU+6g/gEa/VE 0ajg== X-Gm-Message-State: ACgBeo1QhwcVAHRdAZTmdo1rHfwfyHVB8q5JxVL8vJATTai3IPTDtrJ3 N/35QyalZ3t8QsvSSsrnwhHSPg== X-Google-Smtp-Source: AA6agR4ojUBJbR98VBNGjH6wUq6Nv9KGgK1AKUNvZJBoFiv1DMMK6QwYkduNkakZUyZXwJv9yrH0Dw== X-Received: by 2002:a05:651c:91:b0:25e:4418:4c20 with SMTP id 17-20020a05651c009100b0025e44184c20mr7478771ljq.131.1662963496904; Sun, 11 Sep 2022 23:18:16 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 18/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:24 +0200 Message-Id: <20220912061746.6311-19-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index f3106d25adcf..6ae5571f60da 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -54,7 +54,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -108,7 +107,16 @@ $defs: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-3])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605608 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308A3C6FA82 for ; Mon, 12 Sep 2022 06:20:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbiILGUQ (ORCPT ); Mon, 12 Sep 2022 02:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbiILGTP (ORCPT ); Mon, 12 Sep 2022 02:19:15 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31DE42AE04 for ; Sun, 11 Sep 2022 23:18:33 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id f11so13137739lfa.6 for ; Sun, 11 Sep 2022 23:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GbjA8/0sNJoSMWK/LnXW+oLOon29f7DAZdcODYnsdAI=; b=erMAGCUjMGkF2Ivsnvzv3t/iPNvuuafZFkalisK7GLrYYBCdZmWuhau5ID5WuhZqTb kr4ysEzdnOmLoI24PE54VWcp/Yj9IP64UgnG2NySQxmwoDwgNq3uhLxCcsHRyeZNXzze qcngVl8HMJjvV8gMbNqVY3QFrTxqyfVoWKJYS1z6f6qdmSuj1jSra1r4awyaEaEfxDOx JXfUWvOrDk/G//9LuBhR4tPYlZQqDPAA1zsuuNWMOTfJJmjX0FpQkmdYXaKFsr1Kx4pZ M2qlCtgzNqhW4g0lkuYQDdqCPOeNDS25ybaO7WoZC+lyGTmj/32vTZv0oA2eGEqmofoK +nGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GbjA8/0sNJoSMWK/LnXW+oLOon29f7DAZdcODYnsdAI=; b=tGp50D4yamwQMWxk4QaCuhiYuU6r+hwsFjRyY7pkn8iFAhboHoPvUBuynJtDsbnoV9 Rf23+KgEpuekfhXJ8jCKHYRxc5w2fX2jqjNWAF6MclI4yvhZ78TbArFk7SluZvORCF1S OLuE0gx0gEyyhOb4SfzFWUa3buWO9SUpxKHnCLDslBA9rhyRCi7Rj4v2lbWdGn/CUVNm e8vF4ZaQZ8NjUOpgiFLqhlIC212DY7WrcV509onfUoX5/JKr0admo99HeV6JEAA1WDFB VeJlgAvI7HUVlRuGa0FDW5Xka6j5dpNeJA2Od3Ni0QodqLw2fvsgj6zQ9wNuCIFG1/aE WJ7w== X-Gm-Message-State: ACgBeo15vzdDtM4L2rV3y+uGN4W7hX91Dpv6Z1RLBvk6D0wSB9VGc4an d5Ilx8GBMCY3tRGh+heGuBFqig== X-Google-Smtp-Source: AA6agR78dE94Pkj7MTVfrXdLrHj56fM2dZpt6YU0K68zVSX1Wj34JmSVk7ltGHP/cfzGrGJn83ASkA== X-Received: by 2002:a05:6512:310:b0:496:a0ca:1613 with SMTP id t16-20020a056512031000b00496a0ca1613mr9200190lfp.394.1662963498186; Sun, 11 Sep 2022 23:18:18 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:17 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 19/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:25 +0200 Message-Id: <20220912061746.6311-20-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: qcom/sm4250-oneplus-billie2.dtb: pinctrl@500000: sdc1-on-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'clk', 'cmd', 'data', 'rclk' do not match any of the regexes: 'pinctrl-[0-9]+' [[26]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 9c891246245b..d1d1c1455b3c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -43,8 +43,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8450-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8450-tlmm-state" + additionalProperties: false $defs: qcom-sm8450-tlmm-state: @@ -127,13 +128,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio26"; function = "qup7"; bias-pull-up; }; - tx { + tx-pins { pins = "gpio27"; function = "qup7"; bias-disable; From patchwork Mon Sep 12 06:17:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9F8ECAAA1 for ; Mon, 12 Sep 2022 06:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbiILGTQ (ORCPT ); Mon, 12 Sep 2022 02:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbiILGSh (ORCPT ); Mon, 12 Sep 2022 02:18:37 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CC0C286F7 for ; Sun, 11 Sep 2022 23:18:20 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id p5so9308686ljc.13 for ; Sun, 11 Sep 2022 23:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=jLZlsEJ5VG4J2SIrJhH+JChzqh+Qp8BnGJ+3NtUQBWY=; b=iy+1E6NNM2NV6qejn/O7aNh2X6cahhiySX7JGDDPWM8fi7pbSxNy1Vy/08sMI9/SwD /Pg38MrUhxzzTL3YQFuIdnpJViM2Wb88kJaZAkfCk4rNCn6WsVjsWyMBjCXVNgYPrjhn +vglAER66aopmjjkNzalteCtuSiCC6nHQ8U5f5Zy7O8eVuZfTUuxeg0jkDPFWRP8BCXl +um5K7Ih0ATyvtrZQTK+fs+Ch18yyL4y0L5HNzCCBvZZm2KeKu13/czNFegoZpZcEYcr wNApHRGtZ4m58YV8YUplpkyh+xf5AIsYWtGaUUWoc6arPYnog5qGi5AuHJLveLSWK+lP GaLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=jLZlsEJ5VG4J2SIrJhH+JChzqh+Qp8BnGJ+3NtUQBWY=; b=axYSu68iewg/AF6lO5PmXIIzU4pxdghQOQWoubuPXdRKgNu+8IKB1Q/0oXpJrIV4S0 2y16q7+BSkRqKi7srS/NZy1Jt6JiVYy1bMvndayQuM712IDV6+MtPNbenDaXb1+KwQ/t WpkWYki9WaJ/nbnuFnhtumRcYZuk23xA7lDZwNDnzefvGSm5nptI8mPf1jrG9ngGmCPo fD8AUXRv1Hwu8Kugc+qyEpecq0K+Ez9JKoXPUKeoqsO4zzScPUSJRP90hJPX7xtEF5+C /EHspPYZHcv4+eiCLjr5Dcqod8BHoF8L1AW2hb77OUvhMCj1cHGzD+3Ua2ZNF3fe5jVu 8vgA== X-Gm-Message-State: ACgBeo2wAoIalRlAnVewVSCxe1+yKd5UTGsO0R8R1Kl4MGtohyf8bo4K 3izjtS3TCdj+kmNUzwyDi5fOvg== X-Google-Smtp-Source: AA6agR6SCFQ8A3mDkdUAbA6vJv5w7JkeX3CkwNy4Ko3l8MlMVLJ2U4z8kPRzN1YdMQHNTkqVbseQxQ== X-Received: by 2002:a2e:9b0e:0:b0:26b:e2dc:c0e4 with SMTP id u14-20020a2e9b0e000000b0026be2dcc0e4mr4610047lji.459.1662963499851; Sun, 11 Sep 2022 23:18:19 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:19 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 20/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:26 +0200 Message-Id: <20220912061746.6311-21-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index d1d1c1455b3c..87347e9c5f1c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -111,34 +111,34 @@ $defs: examples: - | - #include - pinctrl@f100000 { - compatible = "qcom,sm8450-tlmm"; - reg = <0x0f100000 0x300000>; - gpio-controller; - #gpio-cells = <2>; - gpio-ranges = <&tlmm 0 0 211>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = ; - - gpio-wo-subnode-state { - pins = "gpio1"; - function = "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins = "gpio26"; - function = "qup7"; - bias-pull-up; - }; - - tx-pins { - pins = "gpio27"; - function = "qup7"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible = "qcom,sm8450-tlmm"; + reg = <0x0f100000 0x300000>; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&tlmm 0 0 211>; + interrupt-controller; + #interrupt-cells = <2>; + interrupts = ; + + gpio-wo-state { + pins = "gpio1"; + function = "gpio"; }; + + uart-w-state { + rx-pins { + pins = "gpio26"; + function = "qup7"; + bias-pull-up; + }; + + tx-pins { + pins = "gpio27"; + function = "qup7"; + bias-disable; + }; + }; + }; ... From patchwork Mon Sep 12 06:17:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6715DC6FA8B for ; Mon, 12 Sep 2022 06:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbiILGUQ (ORCPT ); Mon, 12 Sep 2022 02:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbiILGTQ (ORCPT ); Mon, 12 Sep 2022 02:19:16 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD612654A for ; Sun, 11 Sep 2022 23:18:36 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a3so1167207lfk.9 for ; Sun, 11 Sep 2022 23:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Ahz8RWfiLMT3ul4AnyZJntS/GGhk6GDdZTcm/1GzutM=; b=XQx4OVoUTJ8zLRAOaa2DLHo6FsqUUIRXo+DobwRnK46uXPNdF1oz4sHjHfhn7VBeDT mahjMNA/0pSp4sFed3g6hRqC4TNGf98zxdJP4fJ0bAMO+jXDBVlCcm/22OJUtITFD4O/ wur/E97wbVnWoiHsX7BhwSEEUw0vEIXN4wsq+gsi8dyzZ6V4mW+R/wPZ+g3jpOJk945n PzOkt9Gq9JKCsg8yTiSqodf20oBnJZUyFFnkP+L8X03h8qML8onuvOzimpqXQ25Zn7Aa BML63mdsfED5Jh7SwV5al2fDm7IAdAg+bdsyLk+uEk3Q6NfPT/BkJMX/utA0Xh5tFfLW BiQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Ahz8RWfiLMT3ul4AnyZJntS/GGhk6GDdZTcm/1GzutM=; b=BSkgelFsVwDOpzcYXSWUPuTzCqG/pkBwUG5sKOSFL/tgy36pwIJM9frpS7iLuI4d+T dY7DiAZg6gGCS8VWnIymaSOEjaZ/7G3Iq8AqAoy9B12xurTRMWIXXaaPr+VNuNLM6Pd7 X0uk2NuE3C2VgonQ6MbBsTpQKFWyEuo4DWjTgHmQlWl8RJVMVLXGqF9Ztl3SS1lWsX9f t+oVLo61wEos25tGX2O45TtbK42XIrO2lRg5F6dB0ae2JKDHGM9YpOKqE952mACSR6d/ kACVsEqSmxchy6ieMahe+QBmzenXpFe8p2S7U8z7dbIE4CSHUczOTzwhiSp7JnJwGS2f X1EA== X-Gm-Message-State: ACgBeo0OMLYQTs+Iv+2a2blAGNGWmFXRfKFwumqbeOYVyOKZG4rmv6+o HZMYbC/hIQWkadtbhOe0xrjERA== X-Google-Smtp-Source: AA6agR6CgY6b4wbJXemoxfp6L/GXP1ptnkEcrWxGnEEWlQ57O7w2lOc9yEmiwDdK056mFItPqrKlwQ== X-Received: by 2002:ac2:4e10:0:b0:49a:d44b:426 with SMTP id e16-20020ac24e10000000b0049ad44b0426mr860979lfr.234.1662963500925; Sun, 11 Sep 2022 23:18:20 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:20 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 21/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:27 +0200 Message-Id: <20220912061746.6311-22-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 87347e9c5f1c..296f503c1d97 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -53,7 +53,6 @@ $defs: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -105,7 +104,16 @@ $defs: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-9])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DFCC6FA82 for ; Mon, 12 Sep 2022 06:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbiILGUg (ORCPT ); Mon, 12 Sep 2022 02:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230054AbiILGTk (ORCPT ); Mon, 12 Sep 2022 02:19:40 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E11A2A257 for ; Sun, 11 Sep 2022 23:18:45 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id a8so13100283lff.13 for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=zWIyjK4dxfH9A9tyS53A/sJlwsqf8yeDaeYqVdTxLgc=; b=hpCVVDO6lm/ERZUqGXJ74SnKDvWrhTMHmEv5Fam/9wconDWlH0JRvADTQgdAPsUJJ9 IGTP8/gqha1csTIxGRflb8WaBi8mi+jJpu53V8O2LKO4tA6kcjh0a2Z3TKW2ZfywNaIS xh483O0miukpvmb+SSWep5RbHM8GSqzAuizfdCbMfT25qX6iLaahoI0qvC6Xi9vg5LAf o3IT4r2b8Y74FTGwOWSSJNKjIj2z4g6XAP05NbWYzO5tI9/VFqz0eIVYc/SKzwbEKWUQ Uvveo6ZruqyRw7m3J3Zb2IplLch2HrTmjNuXRKF5MGtWSzjTbFjaT7ldeH2QQDyEWlBG KZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=zWIyjK4dxfH9A9tyS53A/sJlwsqf8yeDaeYqVdTxLgc=; b=eCVzPQf5mJnp1cKK/iCwSTWHjA7KqYdwh+s+P7C54NIoOsfoZawDaYQR0m3e9HiJuw 9jPDFoL4ouvTJ2VCCB7u7YtO7MiE9Hv7NIElBfzmHE3DYo6u49aISgUIg5+CGe1c+qIZ EapQHpU1X+MFKxFpfvJ+50KSa+WeXTRwcudNJPdv5dgDJQF/4V10UhK5Wfukz0rJRHpD dKu48IuVRCDtULShn89Yp6bF0+Bbec7N7T9oStRZV9AVzRqvzloA851i1UmZ10ZgzFgO FSA0sVFAxhcRrb04mXhgAajhEIKnNnPtmiypa/x7An6s9jiZlO/ynw2/hzevai39K6et KMfA== X-Gm-Message-State: ACgBeo0oEVnbxKVz/+KiOXg3mMlI+sE63HrdxHGWPd3wgU3JBopTcc5Q YN7ejlkSdqT21iAGg/3CgoyIF/yE28nWbg== X-Google-Smtp-Source: AA6agR5r3zi0vLyk+9FSxThtVD8PFl2WWjBbHuTJ/T97nO1HfcFmdyhBehkF/qXfvwHnllEZGutEMw== X-Received: by 2002:a19:5e5e:0:b0:497:a26d:89ef with SMTP id z30-20020a195e5e000000b00497a26d89efmr9255418lfi.555.1662963502031; Sun, 11 Sep 2022 23:18:22 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:21 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 22/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: add gpio-line-names Date: Mon, 12 Sep 2022 08:17:28 +0200 Message-Id: <20220912061746.6311-23-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add common gpio-line-names property and restrict gpio-reserved-ranges to fixed size. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml index 296f503c1d97..9cd97a467648 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml @@ -27,7 +27,14 @@ properties: interrupt-controller: true '#interrupt-cells': true gpio-controller: true - gpio-reserved-ranges: true + + gpio-reserved-ranges: + minItems: 1 + maxItems: 105 + + gpio-line-names: + maxItems: 209 + '#gpio-cells': true gpio-ranges: true wakeup-parent: true From patchwork Mon Sep 12 06:17:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DD4C6FA82 for ; Mon, 12 Sep 2022 06:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbiILGT0 (ORCPT ); Mon, 12 Sep 2022 02:19:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbiILGSp (ORCPT ); Mon, 12 Sep 2022 02:18:45 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA5CE2AC41 for ; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id f11so13137966lfa.6 for ; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=zwTA5qS1hc7D78vIogufG1A3n3m88CDEiwTkMCUDUSY=; b=NDZd5eNQd/ivs/nVIC9+jVJ08nKEpAoyAwhRw1juzvmkT0Hwzf3F5/luL6s/GjkvyQ jKw5zrEGPEvwojwtP+s8ozkk2r7U98apViw+oVHKxu432P/r+Ti9dJpOodQwjxca1vMT +0NMs80i1YSJcBZ0hFOIdhFO+4nGMIP6dFt7jO6KUUXCWvrftuxXFDU39GvyBE0kI8ON dTDO5k72cnTWQqzq2z7Rx0sQfveRhH4g6JADB0BowhRHbo1OBPdN7emxV0rLTm8cxeim G3oJEkRj0HD3yGPLyh5teVSRyNBnpVXVElYHl0dZSIiqODL4f+G3d2Zf2/sEOkSe7ro4 T/gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=zwTA5qS1hc7D78vIogufG1A3n3m88CDEiwTkMCUDUSY=; b=zDYrM1SQ1A4tkcOe0nTE0lHLIMOi3GPA96JHRMgpi8vMXA3UW7+XQ4/lXmsc3E/+6E oBe93/hWbIu7tK9Plm8Ln+C6GzXalmzKfZtqRkana/CIGH8B9zP+0pwt55DgXnrDEOYO tbgutQRCEU+jaV1HfbXj4wKbbwE3zin8QPddmBeI4Rdd2eKW5uWHwMeDFNSFu6qPFuOc rJtOBaswSNSu9Udbo1xuH7e3xM7Rc86KM+SgBP8gLWP48TGUzJS2kDybsEdOJwkdS68V kqz54nQ4KCAr9XoBCNlIn1DiPJyt5swnNtXiSXpSOg+FWZ8HRwi5PIihoJURAFLRaLYL fcHQ== X-Gm-Message-State: ACgBeo0UDScfniiLAfzMTGGr3EmEdZr9tJ3FxJvSG2HD9k/HFj2g2jGl KIgGUR2ZaCiEOec0h71WwXbCxnq19Fx3eQ== X-Google-Smtp-Source: AA6agR6ed2DHXO6r4Y3xKZSWqZRAbcp2otrsHX/5b3717I2u2EJGrPHBG6Qqasap9hgOmK6nKgPu+w== X-Received: by 2002:a05:6512:15a5:b0:49a:84f4:9284 with SMTP id bp37-20020a05651215a500b0049a84f49284mr1758805lfb.477.1662963503474; Sun, 11 Sep 2022 23:18:23 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 23/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: correct number of GPIOs Date: Mon, 12 Sep 2022 08:17:29 +0200 Message-Id: <20220912061746.6311-24-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There are 182 GPIOs on SC7280. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 2bd60c49a442..76de3b1eb8c7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -60,7 +60,7 @@ patternProperties: subnode. items: oneOf: - - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-4])$" + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|18[0-2])$" - enum: [ sdc1_rclk, sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data, ufs_reset ] minItems: 1 From patchwork Mon Sep 12 06:17:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605604 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3597ECAAD5 for ; Mon, 12 Sep 2022 06:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbiILGVF (ORCPT ); Mon, 12 Sep 2022 02:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229979AbiILGUN (ORCPT ); Mon, 12 Sep 2022 02:20:13 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCB592B1AB for ; Sun, 11 Sep 2022 23:18:47 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id r12so7771015ljg.10 for ; Sun, 11 Sep 2022 23:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=7otNZydIIUOO98pahjg4CEuB5+Fq5/uSk8VTmLsIpzU=; b=y1PkTbkfQaEwzE8pqTvXXEqqyqgNCrhlTm+WskqwrVRcHgZIYMYePo2scrKwo8Ecva LvDAC8NGymufgPa4qEORDD/Wrq5CrWBWa9E+oyAnQPx7MmmwGinLriWtg6V8WCOQQ3fl I2sKhg+kVac8Y5/tnJBTChOa8UrscNYu1O3nVa2hM6+iJ/Pt9EhIEtWL+T2MtBJaBaTX AQQA9ud55nUBZurgUa3xNwm/CLLgLej9tnvGgeKGG0MxkPPzXZD7RvD4vLXhVK6QSKlJ JbrvbYONCzrPcZD4dQroI+Jyg/ZyUW247d06MWkK+JpW5GecpmHirw37alQZmRSfS4YI fhUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=7otNZydIIUOO98pahjg4CEuB5+Fq5/uSk8VTmLsIpzU=; b=OIZqMsZtTlmF75VVNyhxb4IHvZ8uMiVQe7n/3L9iHFcqTv6bXbbrb5kvc4IBHg9byk Uu0FYK/ev/U5wH5KgTA0Bt9f2v4DhDN4bfRD0V7aBmrC74gsDS0nMZj6mwfdcvU4E2P4 fTvBi9JCdCSLyj/VFxFXDWmyGOI806XKSkYxFbgMCwd8azs6tvLHMyDp5KF6rYfwO7Wl zUk4Jq/GhcnphwbiqwOALWSlmsRRlsii1WIixRmxfjZ++S/4OfjvSc5225+r6h9lzr8h kbhs5M8BuB2kEsYtT6xfLqyfTDnhDth/IIYupJXMJGFzTzRlTlWO6a8TCp3sTygRHKzy LROw== X-Gm-Message-State: ACgBeo2y2hzgAO/SOwoGP37ZWr9CaslMjXxBMFpKu/p5oU0l3BqEzmW0 O9TmTw/FZ4noGVgRMU93CGtMDQ== X-Google-Smtp-Source: AA6agR5L+ws1m3zLWS/oH5Zrss/Tfueo4yhHwoEwx2izoi+tIo4sz1GHBrQ+L4BNJhVVth2dfNz0ow== X-Received: by 2002:a2e:3817:0:b0:26a:d369:ca71 with SMTP id f23-20020a2e3817000000b0026ad369ca71mr6775219lja.191.1662963504669; Sun, 11 Sep 2022 23:18:24 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:24 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 24/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:30 +0200 Message-Id: <20220912061746.6311-25-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 76de3b1eb8c7..b12e738cabfa 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -51,7 +51,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "/schemas/pinctrl/pincfg-node.yaml" properties: pins: @@ -118,7 +117,16 @@ patternProperties: required: - pins - - function + + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|18[0-2])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E15EC6FA82 for ; Mon, 12 Sep 2022 06:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbiILGVH (ORCPT ); Mon, 12 Sep 2022 02:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbiILGUN (ORCPT ); Mon, 12 Sep 2022 02:20:13 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49FB2A25D for ; Sun, 11 Sep 2022 23:18:48 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id r12so7771073ljg.10 for ; Sun, 11 Sep 2022 23:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ecN/gYWUwSiweisrF7KuYwKYJSjUztD/7vYHklQvBvk=; b=IlYDGyr7po16zCLurzL0boVCWpIe2vQrGdxG+n1Dkwb59cE5qATQprDA9UG/pjEjbw ic/0lzmV+44/3QvRGjNPtiPoxjzMFCKBJXYnfjj02xAn4CXb+jyAcLDOUZDwEjVoIBec 34oR1ovQ34/8UMdrKNYgTwpy1BDwEzdd3xfZpiVcDZ8Q/0r0KBPBPHjAxT3KyZVRi65k kDRJ5pDZwqeUnOl4q7dhX+PjXR21GDTorw34XLj46rehoGnqUP8EY2yuT3BmhM54I71b /QkJeO1yf0RTr8JTBbjMkxCuXeW32D8gBkhHgSYCfQxFLYk06Qa2LGVuHt4X/9CaeDB3 KmuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ecN/gYWUwSiweisrF7KuYwKYJSjUztD/7vYHklQvBvk=; b=gY8GGI3u3XYA58hcSK/Ght19ZUd4mX9T3SnWWOk2cR+7BXPgyQBu7dh29Y1o3RluJN ARQQxJnQRLw98/P5aA7vLtjcF/Xmqb3sUGIWjeGxnMI6xmyZELs07Hqd+cGaTQ7j3UlY KHyFiL8Se2lzGYS5wGUlyHnUZmSs2zaKbC+FH0Q9y5HSGqEdfTZVXaLNCYV5yp9GScUq KYddMxaHCso/3D5ZdMWQaPCZJGq/mcvLRTXlh68u0JYh3/r1rrVu7hIPYJPmtvI4naLs T20Dcb8KXmiXt6zrzQWGdFnEm/N9hXmPwhY4HMNxDGhaHogEXEL4Zzdnd+lW211Wwhhz 0m3g== X-Gm-Message-State: ACgBeo3muE9RR1Bc+0a00HVE0Vcl8r8Q7wby2A7OzAhS/IfObuY9GjPu vmiuoFkbWwHv5+Z411yTUqV0Og== X-Google-Smtp-Source: AA6agR5WeLK4jOC+RH7LR6VxQ2wxUntjRu8GCITTJXfjC05e3A87axkbjrtO+q4v9lFP6N/4UE+QUA== X-Received: by 2002:a05:651c:551:b0:261:dc64:8027 with SMTP id q17-20020a05651c055100b00261dc648027mr7888259ljp.272.1662963506450; Sun, 11 Sep 2022 23:18:26 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 25/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: add gpio-line-names Date: Mon, 12 Sep 2022 08:17:31 +0200 Message-Id: <20220912061746.6311-26-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add common gpio-line-names property (used on SC7280 Herobrine boards). Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index b12e738cabfa..463f2e95e237 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -42,6 +42,9 @@ properties: gpio-ranges: maxItems: 1 + gpio-line-names: + maxItems: 174 + wakeup-parent: true #PIN CONFIGURATION NODES From patchwork Mon Sep 12 06:17:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0107AC6FA82 for ; Mon, 12 Sep 2022 06:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiILGTm (ORCPT ); Mon, 12 Sep 2022 02:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbiILGTF (ORCPT ); Mon, 12 Sep 2022 02:19:05 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 602B228E14 for ; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id u18so13147152lfo.8 for ; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Kly+7x9ihf9PeM0EfSaLRyWHlTHThn1xyufL9SH1Mkk=; b=xeBmlterGWh/U+JS0vtsstUra2lrkbxnYk5rWcBKrHL4zZHPzQwCo9nYmNZQAxIkjK 6VFwPt8WK+FDmuCPmaDTrSi1ZLDeY39eECCX7bA4uBCDju99EpmH9GHZJuUdVfQTOY9g sT7zpyYE/CEYlb7UaJpwNjWDztGJlj9V+9rOT4vd9Rzl8+YAt6iK/pMPYyvK2rm5O86E Fxp/Ilz3JM22N3n0rLe0+BwrnjqYZokpG6GDz8GqCNuBoItMuT2LEIPmKToRWTmYTJLw XghwlTnfKpgZ2bTtFXVg7wr7KExiMichaC3ZFk2KBN7DjD0vQ8othz01kg8g2mH68dB7 1muA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Kly+7x9ihf9PeM0EfSaLRyWHlTHThn1xyufL9SH1Mkk=; b=5w9QJAnD3wSUYkmMsPEnGE4JBQsCjdMsOqlJ3nwMIZGPp7PDb/NSPooBncA1IZ0POx KGbqGcB0TzbVBo/6QDqeO+E+iUuoKL4DheO8osEvUAxcXp2WFF3sWRHIDaFDAMqlWoPC aoqGRjPWhuUD2STHxxh/KiwPq/dY4qRrfEh6criYI7r4q/xuhRF5isVca37ffRhMAihg u2UGNDIdUPoZYeWqdtdw/Uc919If/8rOUVh538nNMa9sOP6pNa2mvN5dHDy7JeY3URWs t6/txaCNKyuHrhlb8KScIoKMM1JycHM7oQtOorNSDWH6TuVA9NOv7IAcLvlrCo0YKCgr NwwQ== X-Gm-Message-State: ACgBeo1k8R3neBv9OAKv4/0CGihkoVCg3YYWRcFTwMTH2I+t6b8A8ON9 +lodfx2pS+PZ6Om/CqruNVLUIQ== X-Google-Smtp-Source: AA6agR7dtmvrVPKLZRJ5GpakNOHSirzshDenRP6aJbciJLYjckp97je3Um3P2uaRiKUxymcGijX+Vw== X-Received: by 2002:a05:6512:a8c:b0:491:d4b8:47c9 with SMTP id m12-20020a0565120a8c00b00491d4b847c9mr8018352lfu.258.1662963509810; Sun, 11 Sep 2022 23:18:29 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 26/40] dt-bindings: pinctrl: qcom, sc7280-pinctrl: reference tlmm schema Date: Mon, 12 Sep 2022 08:17:32 +0200 Message-Id: <20220912061746.6311-27-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Qualcomm TLMM pin controller bindings should reference generic TLMM schema (which also pulls generic pinctrl schema). Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 463f2e95e237..2ad79029d9b0 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -134,7 +134,7 @@ patternProperties: additionalProperties: false allOf: - - $ref: "pinctrl.yaml#" + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# required: - compatible From patchwork Mon Sep 12 06:17:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E24C6FA89 for ; Mon, 12 Sep 2022 06:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiILGUF (ORCPT ); Mon, 12 Sep 2022 02:20:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbiILGTM (ORCPT ); Mon, 12 Sep 2022 02:19:12 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE592AC63 for ; Sun, 11 Sep 2022 23:18:31 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f9so12422833lfr.3 for ; Sun, 11 Sep 2022 23:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GuYszGqRUvgj4iSIWHANYUWvhVnhTB9OnVeXvHTw1Z8=; b=WokROcTL8/yBzzsDBvVCTM0Y0+RbY9AuLJwSynt63bAxNV6SvoUh+UOejSoGS4XaUr UqtkazUKgIxgiJ1hLKzRxGAxRSA3XzX5F3OxOxquL7l0FtLl04n11EZ+X0/oNrh0oVf5 6znwMuihyE5TPIwsRYxILuJ2QRGEGajIlIosD/D40qYx1u8/zt2foQoai3cqtOmDRqgy k2ftL43JBKwem6UQW/ZbjR6VHX6rmVRUQq/zu1P/hHxIjwVlEW8sPzRBTw6/mjhpClua IfIa19CMGcTnyWZOpl9zf8UA+dWcitf4EMah9tO6Vmkn/dvNMlgAk+7qMKsjo8IycgH9 3MMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GuYszGqRUvgj4iSIWHANYUWvhVnhTB9OnVeXvHTw1Z8=; b=nWoQExBBdrLgBr8IvBcZnsuVVuH8/N5v7Fp2Zjf7SebjZhrK6KFHlngifUCU5fzBwr EKSB/sJ4ZeLyJI9FWdLcl6yMLIgZmZPk1m1V7LpPcjJHLc9Jok8Rk5ImeSElc1/UpLKT OQDaubBzGglsaBMDCo1IeqS8dvT/eMhk0vKF0aOvkAKOydWMrhqonpnG2a5wKD4qac93 zINTp4bjzU1T+1ek1Kai/sbFQNd+C73hJMRqhygBYTTdqzJTptW3slGs2VSwgtTQBcvC 3Zpq6IzYwywLu5fkYiLYicUYp+Dq4zl+oVw7koYxA/mtp/H8d8xk9CKWTgyY7DJrwNZX /99A== X-Gm-Message-State: ACgBeo3hUQCeFu3YNwdMTLM/EblxO7JG6MMVzrVRPmrQp/k6hL2jnQQF lUlse/tA6e2qEQ9D64gZ1Y3j2Q== X-Google-Smtp-Source: AA6agR5oJOWbVa1PdbQ1XCZJ3VJHS6tgg1+MBOSg3drRcILNTZFp/4A7Ah3vRwovv77AcFd92qjd9w== X-Received: by 2002:a05:6512:3407:b0:49a:4862:965b with SMTP id i7-20020a056512340700b0049a4862965bmr1895628lfr.576.1662963510939; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 27/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:33 +0200 Message-Id: <20220912061746.6311-28-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml index 2ad79029d9b0..ad3496784678 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml @@ -150,22 +150,22 @@ additionalProperties: false examples: - | - #include - tlmm: pinctrl@f000000 { - compatible = "qcom,sc7280-pinctrl"; - reg = <0xf000000 0x1000000>; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 175>; - wakeup-parent = <&pdc>; - - qup_uart5_default: qup-uart5-pins { - pins = "gpio46", "gpio47"; - function = "qup13"; - drive-strength = <2>; - bias-disable; - }; + #include + tlmm: pinctrl@f000000 { + compatible = "qcom,sc7280-pinctrl"; + reg = <0xf000000 0x1000000>; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 175>; + wakeup-parent = <&pdc>; + + qup_uart5_default: qup-uart5-pins { + pins = "gpio46", "gpio47"; + function = "qup13"; + drive-strength = <2>; + bias-disable; }; + }; From patchwork Mon Sep 12 06:17:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8F9C6FA89 for ; Mon, 12 Sep 2022 06:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbiILGVe (ORCPT ); Mon, 12 Sep 2022 02:21:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230208AbiILGVE (ORCPT ); Mon, 12 Sep 2022 02:21:04 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 171642BB24 for ; Sun, 11 Sep 2022 23:18:56 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id z20so9338325ljq.3 for ; Sun, 11 Sep 2022 23:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=isoYJKBwL9O1ZTWOtoJy6YqcTPPUMcFYuBQOWK2a8G0=; b=Sn5uYWupsTjYshBneVtvzhVm3tf9tCxdh4UlYVFBt+IUS0/qO8AZG6l1xAt8OTwdcw LqSgZqKAY72eXW7HIgMULuiRS3xGprajeZGJiGeCelFx7FciQ6ekWDZRaV8/z10dk4gS 127eQTscFSplDtvT8htQc83JifHjo++wfC1ErJCMomo10pyjyMeliT0Iu/Pc69Cq7JTf kkzYKb2Zh66/CVOvi25eYko/MCV67RJbLzmpxKnHCPokSsNSre0NdELFow6p5CRQ+CDu d8hREZz8A0EG//L7Kr5EffVi2u2ONDT3bjh4v7h1YagyiR6TD43pdXyGcUg74p0EUZs6 /ZBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=isoYJKBwL9O1ZTWOtoJy6YqcTPPUMcFYuBQOWK2a8G0=; b=MiZIYi593Y3dw8okFxyxP8MWQzWbPjngqbhX0fcvf4NsPVwQONESCcZNcz19Ezt/Kn dpuAPDEBe7b+RFX6h5yXYXCK72VtJiAUBpLWTrF9TQ9+lgk7FWvX7sdEHD7+eHZPjzMY cBBZxrdt0CyNTTFtbobK4lOV46rWc8XYriIPzC2D37rq8a9Qt27/9A1BXZ7aDZaSj1+R d1dOlxjjuQAhEfSYry0VPQJ1xZp8kxQ11iuijOircvMSbqLv4qWMxuTn3QVZPwyHVVGR 87CNzuInAXiSbSb+O+V6FSW3Wc6Bh5Z2OUwy8Jn/MiA0dIQAECIZgub9m8ODTZLeFJ2k MC1Q== X-Gm-Message-State: ACgBeo0FcTxysfQpMEzgjURgyv514AK2IIK+LEEKx7He5mIU0655WRyM 7nd0MweN7YromhYAOmkQyDJOTQ== X-Google-Smtp-Source: AA6agR4xwxfcUqidIq62wQLoSkaPFn1oBOsoXm32yp4o95+WVvQIOqMOm3t2WCydvzEkLmkKr0zW7Q== X-Received: by 2002:a2e:978f:0:b0:26a:a62e:8f2c with SMTP id y15-20020a2e978f000000b0026aa62e8f2cmr7369259lji.153.1662963513116; Sun, 11 Sep 2022 23:18:33 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 28/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:34 +0200 Message-Id: <20220912061746.6311-29-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 86509172603d..646fabdf81f7 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -51,8 +51,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sc8180x-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sc8180x-tlmm-state" + additionalProperties: false '$defs': qcom-sc8180x-tlmm-state: @@ -137,13 +138,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio4"; function = "qup6"; bias-pull-up; }; - tx { + tx-pins { pins = "gpio5"; function = "qup6"; bias-disable; From patchwork Mon Sep 12 06:17:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605602 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA2CECAAD5 for ; Mon, 12 Sep 2022 06:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbiILGVc (ORCPT ); Mon, 12 Sep 2022 02:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiILGUz (ORCPT ); Mon, 12 Sep 2022 02:20:55 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B0E2B624 for ; Sun, 11 Sep 2022 23:19:00 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id bt10so13202309lfb.1 for ; Sun, 11 Sep 2022 23:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Z/95Brm84Hs/a3P501KqW9gtmX0Qfi6hmXE/MDLL0vI=; b=PLoAGfgYNr7od2O4N2jBATlyy9GsidtsOIMLThrsH+SM3UaH/dbI0LB74rLQz7mTld BXMJAwXOEC+24QzIPIaMlrAcZTTiWY4OgQDhPMxzxdtgEULAWYZvemx2eE3TBxKA1OSg F0plECT478eM9Y7YmoosYIi+S49h+4fb7ZJqaCF1pH2q4T9gA36lsULF9RWpN7oLFSCW VRTDRuhFLxE7eZ71cXkrLSyH8nCfNfJoFgB/CbGB5FEmaQDNzYDSli9PqfiRUzSC6nq4 0cJFwnb4PJmd98hCiAKVjbdR90vSU6SpukpLUGdvA0rMCJcMrsk+txXTzVVTSN4wmqYe JYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Z/95Brm84Hs/a3P501KqW9gtmX0Qfi6hmXE/MDLL0vI=; b=Vjn9vdQFQqQvb8iHQqtX4mseBaDVfOAjDicUIfnFHzLaQuVin1ZKAJS1g8ZRO3tEfA fvq21XsYarLY2dFwkKWgvT71Sa3mGUT08pgApDq3bS8RkvIfw33UC9yt7S/OLwj2BVRQ 9S/lG7Oqp3Q7XFLPN5Mh9a9g21+eTs/GhJfAsGUgFkTwHkCyV7UbQCLAF//tUUYK+k11 Ukg56Ddi/flnosMTbCZUbZb/zI/DSGiOQHaben4B2abvO/kIRRZQrLDxcVnpOXD9GdMy baY01JC1wwaN6FXR48KswJD9vgCyjHTEwmNe2me9O0Tczcl9wV6w8idn8qtzgcJuaPI3 DYZg== X-Gm-Message-State: ACgBeo2IZQUZMglXvLkZTjdt+7/Rtpu6QTDgh9i8/8rWHxl5nkuQOkuR a0Dlz/xJiBd7qH/dUwqwLiJSVA== X-Google-Smtp-Source: AA6agR5oG2zgeaH/mojNn55ZSx64wxS+B+6Ny6B04LZFluXVKFQhqrN6oR2dY8galG82Ymg64bJlzQ== X-Received: by 2002:a05:6512:24b:b0:497:a7a7:2ddf with SMTP id b11-20020a056512024b00b00497a7a72ddfmr8890896lfo.379.1662963514996; Sun, 11 Sep 2022 23:18:34 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:34 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 29/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:35 +0200 Message-Id: <20220912061746.6311-30-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 646fabdf81f7..4afe20bac87c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -61,7 +61,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -112,7 +111,16 @@ patternProperties: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-8][0-9])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F6EC6FA82 for ; Mon, 12 Sep 2022 06:21:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230273AbiILGVh (ORCPT ); Mon, 12 Sep 2022 02:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbiILGVJ (ORCPT ); Mon, 12 Sep 2022 02:21:09 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 213602C123 for ; Sun, 11 Sep 2022 23:19:03 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id s6so1946267lfo.7 for ; Sun, 11 Sep 2022 23:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=nXdmZRWySMH2y4BHslWMyDvfmlDcWpCDzcQgKmezSiA=; b=aS+agOqhWINw9MuAJ0n32qJeHyY3pODek/iNq3Rojv3DYFvibsVMgg5Ku/4AwlqjKS yUX1g0w9BfjFNhByRz4ypR3sjOe976/vzTOP3MHbTCI9TkaPlrZKI9mHSaJ+9nz96KQR Dqx96gtCyqAdr5ltVbudxyFj3SeDsL0nWPL8eb5Fwb2BDPzlg4t0dyn8BNV/bY5jz7Br SCMQch7z2wWWzy5vaCDpDFeaKvU93G/K2PVJr07EEH07WVaLnD4zxaVuz4aOgfE/9iw9 9WVpDL82VrfX5xN+bDgXCG9mxqNOm4ZUnNY6/PBM8IECQrEnrDYA62L37EUmk+DbVNQg fKZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=nXdmZRWySMH2y4BHslWMyDvfmlDcWpCDzcQgKmezSiA=; b=Di2WsJTTBvGBeONoau01F80PnFKqMd8vZsKitKkqtQcMo3lxYCBu5PjNh+9/DfhHW+ 1z13Lreh1FcOjvQggiA1cW1BWB5VMfbVH1e52PKpAsCbizjeIJQBUu8GWk/NlaS61Ht7 q8jlEHjYAdZKvkKkYdyQh4hqrcCzWQrYnbkpZnl5en0jdnje5qE67hr9OY+KffX2yEbt wu20jxoveYcz4Pbg9WR/KGyNqYfynB8rS+OhQ+PAszlU3TluUAN6pvQam7Q+qPbSq5EL QVQg7gqWwc3pZblwzfecZ9nYu+nK98LfXl+ZCrIgC37PIdvsin9o/LMvNrnH2Wdx7t5F FodA== X-Gm-Message-State: ACgBeo31znq/mYdWNmrLP/xpuypFvu0se9UyYNRxWp+P2OqA9UCI/Dit E3uXgtjeNYE43fxZJIwMOFITTTlKfeB41w== X-Google-Smtp-Source: AA6agR45OVFDsP7/GSM/ZCIfw7CKomhVPysvR/TQNc6CDDrydTsLOCiRTXPAkluJzMM6x8e58vrekg== X-Received: by 2002:a05:6512:682:b0:49a:9db4:5a3f with SMTP id t2-20020a056512068200b0049a9db45a3fmr1641603lfe.214.1662963516774; Sun, 11 Sep 2022 23:18:36 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:36 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 30/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:36 +0200 Message-Id: <20220912061746.6311-31-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../pinctrl/qcom,sc8180x-pinctrl.yaml | 64 +++++++++---------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml index 4afe20bac87c..b98eeba2c530 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml @@ -126,37 +126,37 @@ patternProperties: examples: - | - #include - pinctrl@3100000 { - compatible = "qcom,sc8180x-tlmm"; - reg = <0x03100000 0x300000>, - <0x03500000 0x700000>, - <0x03d00000 0x300000>; - reg-names = "west", "east", "south"; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 190>; - - gpio-wo-subnode-state { - pins = "gpio1"; - function = "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins = "gpio4"; - function = "qup6"; - bias-pull-up; - }; - - tx-pins { - pins = "gpio5"; - function = "qup6"; - bias-disable; - }; - }; + #include + pinctrl@3100000 { + compatible = "qcom,sc8180x-tlmm"; + reg = <0x03100000 0x300000>, + <0x03500000 0x700000>, + <0x03d00000 0x300000>; + reg-names = "west", "east", "south"; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 190>; + + gpio-wo-subnode-state { + pins = "gpio1"; + function = "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins = "gpio4"; + function = "qup6"; + bias-pull-up; + }; + + tx-pins { + pins = "gpio5"; + function = "qup6"; + bias-disable; + }; + }; + }; ... From patchwork Mon Sep 12 06:17:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B26CC6FA8B for ; Mon, 12 Sep 2022 06:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbiILGVi (ORCPT ); Mon, 12 Sep 2022 02:21:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbiILGVI (ORCPT ); Mon, 12 Sep 2022 02:21:08 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC892C128 for ; Sun, 11 Sep 2022 23:19:04 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id a3so1167979lfk.9 for ; Sun, 11 Sep 2022 23:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=bcVZH+vM6VlPj46aHm51wHDmSEBgcg+OmD5GfgTxNm4=; b=IOYLQduKDVqUl2FVMPccdSSq4RPfytAj5bsgcI/Uaj/+kjB/Rlsv+dnvKW0O+wmtlO nsk2UpQKYauZTfMFSGRcTCzzeN74n+6fyXIO+Gx230ej4/RYnBItA2zoyh6JiADlCWlp 4JzDVoYRjQEEbZLY1AX8sxtcJRztvl8fG3ip1M2MwQs+XK9kjCnDQtM+THV/H7aRjkOM gzuyuSzE5xGOSsShos85ncbYSxdoGAFw4T0i64nkWPLYv7MfzlhD/TiCFqug+nheHgIT g9k9DFBRgl/NLcLoEtSugSQBDjYIha+FMBwO9/JClQ7sNe65zfZnPSvClwnGUAg1Trfb jeHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=bcVZH+vM6VlPj46aHm51wHDmSEBgcg+OmD5GfgTxNm4=; b=F8x7f+Jxn4UNEEfraX43zGl1jmLRFAIBY5Bt+Fviv+g27SGjsxn6lZPquihsLDmyTj Q+YKhBQ1RFjHHnms1ET1ogWZVUyXa9lBhk3+Qrx8Fdfzn5smVzmwyEtnvo6OEsAVtvdE nWCf8Ecad/2uW7GEyQVC/iS8wXvY3x9t3mSXVOWMlhJxCEih8yN4IFqvVlLq4YHmi37J P4hx6mZEEqLySPLXSsLCMhuKklYtMAPWgSHi4quk3g/KLGH5CdJ+Qy/fNgzSFZ0sVzxe fUpO8K+eff31bzjGxyCwhwvKbgOC9dsytw2wIsfjNOgVyRPslcGhMJi4R/GbaculZVIp 5GUg== X-Gm-Message-State: ACgBeo3JK1VyLYx3Y9lg1IJocslSqznLdRfP9cuyPrFbK4imlRpARsfQ z5R/RGiaeLPK8cTLtnpBj5o48Q== X-Google-Smtp-Source: AA6agR7TCoX/JggyD8QfNFbQxY7SgJBZR67pv6AvYZGTLMbK2RzG8EEmdtkEnjQDS1+gpUS8RPmq7A== X-Received: by 2002:a05:6512:3b06:b0:498:fa72:c24d with SMTP id f6-20020a0565123b0600b00498fa72c24dmr4978910lfv.538.1662963517852; Sun, 11 Sep 2022 23:18:37 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:37 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 31/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:37 +0200 Message-Id: <20220912061746.6311-32-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml index 87a381c9a19d..5147afc28721 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -43,8 +43,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sc8280xp-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sc8280xp-tlmm-state" + additionalProperties: false '$defs': qcom-sc8280xp-tlmm-state: @@ -135,13 +136,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio4"; function = "qup14"; bias-pull-up; }; - tx { + tx-pins { pins = "gpio5"; function = "qup14"; bias-disable; From patchwork Mon Sep 12 06:17:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C1FECAAD5 for ; Mon, 12 Sep 2022 06:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbiILGUT (ORCPT ); Mon, 12 Sep 2022 02:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbiILGTS (ORCPT ); Mon, 12 Sep 2022 02:19:18 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDBD72AE29 for ; Sun, 11 Sep 2022 23:18:39 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id y29so9325958ljq.7 for ; Sun, 11 Sep 2022 23:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=XCpzuH6l9uwERwbmApSAocGpO1WUQ+kJaH+BaZZ4Pgk=; b=jtakP6ORWyIKPUpkfqal/BV/8/ncUpbuF/5f34Fj9guQlNdQkZWt3NW9uM5z/4dA+Q bk/EgTX/eS9uwqh9E0VzpeV3+t5LfhSDSBe3pFFHuM6IZh7ZzimhHGoKLFNrGY+VOxIM 5Q4Dq2dzny2t6jYuBcPQrjV+DS6WIEONEYjqdsLb+VZdZLHHMiUDqaZtdMgRURp2W33i mzeyml15vQ+BKAhYTYqnPqtjqlY5VouichDNzKL4BWZpjkBkitJaufC7NdSN9LfMOytL mBfR6ETq0FI2E9URYaX81M1b20WZCat4TS9yfNSGdcTjVmiyE5OGQIpZzgMlrLM/Jtzx NO1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=XCpzuH6l9uwERwbmApSAocGpO1WUQ+kJaH+BaZZ4Pgk=; b=kPcC3CxvyMhBXF0jTTfhhA1P+dlEm1OklBCY/CFCHAz9Fs2qD77dNGIseCXIuoJp2v MZr7SgbijOduFTwA3RK66fBLQ3z55rR1Mp1T8DuKW05VaH85oX1ApKkecJFls3XJl4n0 lmG/FXhSPyn8Nf4NyIPIUyYJvZx13ToHF3uEJ+OsxzxSGp7luFRnZQzrkYegHmE6cNzK Y4o0AGopG+wEqHvDJ4q2NQoVGyzz874T4Zva/TMNXxt70ROZockuZB8o/bNUIJHyEYam zxRU4vZHHIg3rqIsTOZw3p9xBviIfzW2oHPk21Ca1M0p6BpLdruR7kjeIA5PEBghJb8A 1TqQ== X-Gm-Message-State: ACgBeo0w7G1hvWeV6hHHX/dxQaZvo1HCi+ePlkD5sF1hQg4jcuPsbPjm V/ESIJJw+dbxO/ILdWjJH7ANkQ== X-Google-Smtp-Source: AA6agR6gVvk+wjJcy+GsVuOyXfIuM6E7NgxSoHfkKTcN9oVF2DXgcCNIutIim0ZgRFH40l3SGXWrdg== X-Received: by 2002:a05:651c:44f:b0:26b:e48e:5b4e with SMTP id g15-20020a05651c044f00b0026be48e5b4emr4377596ljg.314.1662963518967; Sun, 11 Sep 2022 23:18:38 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:38 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 32/40] dt-bindings: pinctrl: qcom, sc8280xp-pinctrl: do not require function on non-GPIOs Date: Mon, 12 Sep 2022 08:17:38 +0200 Message-Id: <20220912061746.6311-33-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Certain pins, like SDcard related, do not have functions and such should not be required: sdc1-clk-pins: 'function' is a required property Signed-off-by: Krzysztof Kozlowski --- Another question is whether 'function' should be disallowed for such pins? --- .../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml index 5147afc28721..8610f2701388 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -53,7 +53,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -113,7 +112,16 @@ patternProperties: required: - pins - - function + + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-1][0-9]|22[0-7])$" + then: + required: + - function additionalProperties: false From patchwork Mon Sep 12 06:17:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605606 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B459EECAAD5 for ; Mon, 12 Sep 2022 06:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbiILGUV (ORCPT ); Mon, 12 Sep 2022 02:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbiILGT0 (ORCPT ); Mon, 12 Sep 2022 02:19:26 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D21A62B192 for ; Sun, 11 Sep 2022 23:18:40 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id x10so9326534ljq.4 for ; Sun, 11 Sep 2022 23:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=691KvJvip9wejzXr7qpWGsmceASveD6n9KP/WuDonD8=; b=d1DHQPk8TiATnt/m6mMQt61SUjKvZhpDvPIkhUG2xBhT2q7YegT1qS0K2WLyXviV7p MBPpZfjbJprK7gQU4RQU3ULzM+eRPx6UwyTgDDq35YgH/1oV3YmB3C+0f+h4LcvWS+yl kGCmB4XV1ADWqH//Z2TdMauEX01fJNC50nqadf+mOZL75OPAj1UrvrXM7jYPWJ6Q+xhK vqvQOg0iOoCRIsamcHzrXhT7qTVd1bvLT8fK7Mk5jPgqqfGvvyn76SgT3jBs7kGFBOVz tElvW2mJBXv0H98qeRcgkgvgKJWOwjRFFJSQxA1eRfOZoaqKJNYxoB0fTS1R/DmMzGoA ESpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=691KvJvip9wejzXr7qpWGsmceASveD6n9KP/WuDonD8=; b=ExHCS3NTT0AW/bTBvFjQp20i4fIoN00De+W2xM3+/P+SDITXFoFEmXT9mQ2BzlGFwM BRBzxdEvHSRRIafzj9033/GxQR6y0hhntCAWlUa8b5xn3xWmku/EgMY05xq8RxamDA9W FkN+C1Zg4eoDV3VVFGADzgmRoULpS9FKy1aBOvFjk/y4sHRmYSoZ2vKzkXMdWlqGb9EI Ql9qK3gMUpEfzIdabm3Anwdha81PUPi+bIBMc90cUnZjBDdc5J0HTqu8q6EzIPSn8GGC 0qW4MA1W0XT8NYSObCt6gd5XGB7gncJ+nfhLnEAzXTS/m7oCCRroL0nyn90hjqrJV4I+ 2K8g== X-Gm-Message-State: ACgBeo0MnbNYHzW5SX9pVnBa1b6nHrW1FWhdSsEcrhwdsVeKDSzxd3Uj MNtcwAV7GKd/RhP3XzxNmW8xCA== X-Google-Smtp-Source: AA6agR74Ig3J9SSX0nqCYqvR7QrLh5RKvXE1wOuQ5kJ/yx4ASKopm0Acvfok/VWCHRj9SPWW23EXhw== X-Received: by 2002:a2e:9cf:0:b0:26b:e127:df1 with SMTP id 198-20020a2e09cf000000b0026be1270df1mr4921166ljj.325.1662963520191; Sun, 11 Sep 2022 23:18:40 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:39 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 33/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix indentation in example Date: Mon, 12 Sep 2022 08:17:39 +0200 Message-Id: <20220912061746.6311-34-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Bindings example should be indented with 4-spaces. Signed-off-by: Krzysztof Kozlowski --- .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml index 8610f2701388..b9ab130cd558 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml @@ -127,34 +127,34 @@ patternProperties: examples: - | - #include - pinctrl@f100000 { - compatible = "qcom,sc8280xp-tlmm"; - reg = <0x0f100000 0x300000>; - interrupts = ; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-ranges = <&tlmm 0 0 230>; - - gpio-wo-subnode-state { - pins = "gpio1"; - function = "gpio"; - }; - - uart-w-subnodes-state { - rx-pins { - pins = "gpio4"; - function = "qup14"; - bias-pull-up; - }; - - tx-pins { - pins = "gpio5"; - function = "qup14"; - bias-disable; - }; - }; + #include + pinctrl@f100000 { + compatible = "qcom,sc8280xp-tlmm"; + reg = <0x0f100000 0x300000>; + interrupts = ; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-ranges = <&tlmm 0 0 230>; + + gpio-wo-subnode-state { + pins = "gpio1"; + function = "gpio"; }; + + uart-w-subnodes-state { + rx-pins { + pins = "gpio4"; + function = "qup14"; + bias-pull-up; + }; + + tx-pins { + pins = "gpio5"; + function = "qup14"; + bias-disable; + }; + }; + }; ... From patchwork Mon Sep 12 06:17:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605140 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40E6ECAAA1 for ; Mon, 12 Sep 2022 06:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbiILGUU (ORCPT ); Mon, 12 Sep 2022 02:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbiILGTW (ORCPT ); Mon, 12 Sep 2022 02:19:22 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECE0B2B1A6 for ; Sun, 11 Sep 2022 23:18:41 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id x10so9326591ljq.4 for ; Sun, 11 Sep 2022 23:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=e91Jrvw0byDqU3CWt6E5mPoWrF7xdNn1DqHo4tKVYDs=; b=r13KarNKK5ee3JgywvFlXLxKsjaraY1VicrvUPbB9VD8UJfG2zoVaqOKpy3NpmT7jz yFDUpkEtnYRb0TCmtyWSAuUws3fq/Xjg1PGO9Q1L+fV+AF1mMfKmRSjxDAs61iwkv6ha +xs28HP+fPMNtZo/8km1RpdfUjbSTjkctGLmw0+C8CAJ+asTfrIqI9n9erJivduaMs2K n8YOHhZbK+JdWFSAdeD7YpH3veW+IMkFfky+9bOjtKQf9D1hISMWYd9a2sAQQBtvdXig nbyv+E8LEkGnNHmfGH/1GiWlUNUXBoeJrVGkXxluyHKOnmjwqa2mMEZsw7vVP6ebzpm7 eRCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=e91Jrvw0byDqU3CWt6E5mPoWrF7xdNn1DqHo4tKVYDs=; b=h5SvqT000QMKa0wVcVmti2RmhUjGGDI1q3yc4bZwio9kIwvsKY9HZil2oyf5Q6L5tg MLeLdtPI4wFFHeJIGJCVYx7z323UDyJO3fDTWVUREi9KttlkjhJW2CE+fBfXWaC+mSUZ gkQxVxzbtlpvwdvcNcDmpU5D2b4GE07H09xiSpbvRysNuKYmESby+07rum6JC584IuFg +eerSRefjUS6w0o0iUDayH1w+JSPZCuEEKcT4EJWcQubIVCGoKmkXn6NovzZoaAAGj8x 4T5QYJPHnBypD3spfRzqjRLGGoUGtCXLiTVpN5FFcdc2OACWiO8n/vGgeG32Cu8pnPHt +ThA== X-Gm-Message-State: ACgBeo2xQNYGvKleYL7CK1EbPmkuA5EwHZE2ISLK3kAeMYbTgpIfLVQw 4bD5z3x3jcZBTIU7TRJZxQCxXQ== X-Google-Smtp-Source: AA6agR5c/r/NiSr82VLsI6pynDVo1A+HrcRDt4+K2JA3uy3KqvQ5lMGUKNHcAxjzW8UzH1/i0M2ccg== X-Received: by 2002:a05:651c:88b:b0:261:ba8e:717a with SMTP id d11-20020a05651c088b00b00261ba8e717amr7168298ljq.401.1662963521401; Sun, 11 Sep 2022 23:18:41 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:41 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:40 +0200 Message-Id: <20220912061746.6311-35-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 4 ++-- arch/arm64/boot/dts/qcom/sm6125.dtsi | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts index 0aad2e94e757..6a8b88cc4385 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts @@ -87,7 +87,7 @@ &hsusb_phy1 { }; &sdc2_off_state { - sd-cd { + sd-cd-pins { pins = "gpio98"; drive-strength = <2>; bias-disable; @@ -95,7 +95,7 @@ sd-cd { }; &sdc2_on_state { - sd-cd { + sd-cd-pins { pins = "gpio98"; drive-strength = <2>; bias-pull-up; diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi index 8c582a9e4ada..1fe3fa3ad877 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 { #interrupt-cells = <2>; sdc2_off_state: sdc2-off-state { - clk { + clk-pins { pins = "sdc2_clk"; drive-strength = <2>; bias-disable; }; - cmd { + cmd-pins { pins = "sdc2_cmd"; drive-strength = <2>; bias-pull-up; }; - data { + data-pins { pins = "sdc2_data"; drive-strength = <2>; bias-pull-up; @@ -413,13 +413,13 @@ clk { bias-disable; }; - cmd { + cmd-pins-pins { pins = "sdc2_cmd"; drive-strength = <10>; bias-pull-up; }; - data { + data-pins { pins = "sdc2_data"; drive-strength = <10>; bias-pull-up; From patchwork Mon Sep 12 06:17:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E07F7ECAAA1 for ; Mon, 12 Sep 2022 06:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbiILGVo (ORCPT ); Mon, 12 Sep 2022 02:21:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbiILGVQ (ORCPT ); Mon, 12 Sep 2022 02:21:16 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2865F2C65B for ; Sun, 11 Sep 2022 23:19:08 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id r12so7771631ljg.10 for ; Sun, 11 Sep 2022 23:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=GgI6sNuIiEld/+iiG14XAnJiIn6TNY0eqR/C3vJoJeY=; b=AZ2/CXMfG94NpKqvmvATbBdh/wh7IGSp/kCNkPmjDqn80oOyEquISBToVUWiKXE/Ak +XdNQSxmSGqe6CZOC+DNfOpgy0wNgLWKmMpluF0ZYQDV+RWoUIgbeVco9uY7YSKamjUY jSUa3W+AmX+vcLr8ElbE7gribHE+ixq4SrK6wJQOigGt3WAS9daXUSINGVolZgT3JWgv nAjkx5nmWIvYBRRKTCiyZjljBm+gso5dKp38A4EWLxkjuFnpErRliqs4BjuzSFEp84T9 LUTBGDbyPcIvv1mCZhS04lAHeUI3ODv9nNe/JA6gOqiTvS7VAlV8RRbgNqIhIS1u2WtT fN9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=GgI6sNuIiEld/+iiG14XAnJiIn6TNY0eqR/C3vJoJeY=; b=wzKcSnwkqk9WgglKUYJTAIrmXHTREAW0uACKzyjfmivXMsffRWlBILt6moZO+5CMsx JQVTRCLy5bcM9D/VytoGDYkOzqhPcDZhI5AexoeJPNe2ARcXY65rWCnbjCyNV14VyRp4 G6SybUfjaPj76dGgX/TkcCZ7xELmlY6CRewVvEEEaf80IaEdY0xWKVZrPi4u5Y15XDes Eo0B2BZWcM20M+oQfvlfgylegZpIOuzf99Nqqcd1WICfwrt3xRpHinkyyLOGH0OPajiY uEC8jpUCm1VfgIYZjsj0gLTOZodf2bxoQuN27fT20I/sigbPqFSZukDls3Nbagi5MItp nSAA== X-Gm-Message-State: ACgBeo1Aht50fFy/aNNIRa3nqGSgxbk0FMLKTG8+owCffnDjHCBHf37r ke5bgz+1fAR7ekocDYHZV8MH7w== X-Google-Smtp-Source: AA6agR4YgAvA7zMoENGzSneI75XAZYBTj1RKbWWcfo+LgroyLfiscFA2+fHOpW9UFcMiRO5yEGzBRg== X-Received: by 2002:a2e:a587:0:b0:25f:e6ac:c287 with SMTP id m7-20020a2ea587000000b0025fe6acc287mr7087767ljp.416.1662963522651; Sun, 11 Sep 2022 23:18:42 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:42 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 35/40] arm64: dts: qcom: sm6350: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:41 +0200 Message-Id: <20220912061746.6311-36-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index d882c29d53aa..c39de7d3ace0 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1314,49 +1314,49 @@ tlmm: pinctrl@f100000 { #interrupt-cells = <2>; gpio-ranges = <&tlmm 0 0 157>; - qup_uart9_default: qup-uart9-default { + qup_uart9_default: qup-uart9-default-state { pins = "gpio25", "gpio26"; function = "qup13_f2"; drive-strength = <2>; bias-disable; }; - qup_i2c0_default: qup-i2c0-default { + qup_i2c0_default: qup-i2c0-default-state { pins = "gpio0", "gpio1"; function = "qup00"; drive-strength = <2>; bias-pull-up; }; - qup_i2c2_default: qup-i2c2-default { + qup_i2c2_default: qup-i2c2-default-state { pins = "gpio45", "gpio46"; function = "qup02"; drive-strength = <2>; bias-pull-up; }; - qup_i2c6_default: qup-i2c6-default { + qup_i2c6_default: qup-i2c6-default-state { pins = "gpio13", "gpio14"; function = "qup10"; drive-strength = <2>; bias-pull-up; }; - qup_i2c7_default: qup-i2c7-default { + qup_i2c7_default: qup-i2c7-default-state { pins = "gpio27", "gpio28"; function = "qup11"; drive-strength = <2>; bias-pull-up; }; - qup_i2c8_default: qup-i2c8-default { + qup_i2c8_default: qup-i2c8-default-state { pins = "gpio19", "gpio20"; function = "qup12"; drive-strength = <2>; bias-pull-up; }; - qup_i2c10_default: qup-i2c10-default { + qup_i2c10_default: qup-i2c10-default-state { pins = "gpio4", "gpio5"; function = "qup14"; drive-strength = <2>; From patchwork Mon Sep 12 06:17:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605605 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C2FC6FA89 for ; Mon, 12 Sep 2022 06:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbiILGUi (ORCPT ); Mon, 12 Sep 2022 02:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbiILGTk (ORCPT ); Mon, 12 Sep 2022 02:19:40 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76BB62A24D for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id q21so13240135lfo.0 for ; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Hce0/X2M7TfP4RUEOJj4lD2o6WMQMhsp3Z9J0vMVmr8=; b=ZXKYRnQbMrzbBBMEj5ewTSQLkcTtsF4QhqUnK4rUxBkiQD50Ieq0wUWyfhwd9KToOJ mFeHU7I317N5fNIMGMNiSqiUNKfYg2wkERv0+lWfcLQp0IVkb6dK+wIi3vmaKUoQR7lB 3TfYUbwk+0i6Mn9AC8xYOZ1bypcR8mKVJFlZ3eMo6XuPvkVTbkAEApY5+hyI9s+8ZwbO ygtufrghs+QhH9cJTXUbWEFDgSFcXeaYzkRVarXF3GODspqDRs4unjTVMcR5WpWdA81J Ky5BsIyxt/O7HbYyiMLoiXw3aQfF+dAwwv7Di5DdEW7G4gD3Er3e7qaNfmhgjb8iq++U /9AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Hce0/X2M7TfP4RUEOJj4lD2o6WMQMhsp3Z9J0vMVmr8=; b=NK+QkqAleXAxsRoKgJX3OnBYqLeeORInLZkkR+SvwcF7Vgy4pZx5SbvXvcDia3RP8B RjTxb8QCnbw3xcwxWwOkLawYlD2nudaRSF6L5oID/BwHkJkRCnI5s/CxeHLHtaTH9bBn rK92qOwPrdTmnwJRYw3iuPcAvYC+8BkGffc1zGMwPzGJt7alB0olWb7z8HYFNUwN7ul0 5YwjkH78HCWSGffJtEMyosbHc6fJk/7USmloVxIqb9NQaboe7ndIMA2szaVH1yokaBs5 93v1KK/Iuz9MI35iMXUaOQwzkUo6qPdOFoTJmQc0MCz0BzIeHMAOQTdMHITo0Teb30Wl ThNQ== X-Gm-Message-State: ACgBeo1U5KFKHo/bgr/UBBq9yRfHyXvRUfJlHHOiZcDlzhLZ2mpQT8LU wOq10EvflL1pO3mtlFCj6UUPoQ== X-Google-Smtp-Source: AA6agR7wxJGiPeuK4elaQ/Zq9PldsHu63xZJaoVKvIJwb5wrJqe/x6l3D/S89Et+8uD4aRFo5guISw== X-Received: by 2002:a05:6512:3409:b0:499:f8f1:8322 with SMTP id i9-20020a056512340900b00499f8f18322mr2448812lfr.459.1662963523773; Sun, 11 Sep 2022 23:18:43 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:43 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 36/40] arm64: dts: qcom: sm8350-sagami: correct TS pin property Date: Mon, 12 Sep 2022 08:17:42 +0200 Message-Id: <20220912061746.6311-37-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The pin configuration is selected with "pins", not "pin" property. Fixes: 1209e9246632 ("arm64: dts: qcom: sm8350-sagami: Enable and populate I2C/SPI nodes") Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi index cb9bbd234b7b..b702ab1605bb 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi @@ -223,7 +223,7 @@ &tlmm { gpio-reserved-ranges = <44 4>; ts_int_default: ts-int-default { - pin = "gpio23"; + pins = "gpio23"; function = "gpio"; drive-strength = <2>; bias-disable; From patchwork Mon Sep 12 06:17:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605138 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B4FC6FA82 for ; Mon, 12 Sep 2022 06:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230199AbiILGU4 (ORCPT ); Mon, 12 Sep 2022 02:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbiILGUD (ORCPT ); Mon, 12 Sep 2022 02:20:03 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C60C2A255 for ; Sun, 11 Sep 2022 23:18:45 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id a14so7214229ljj.8 for ; Sun, 11 Sep 2022 23:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=CL2/j/JItz+3oLrNQS5aOSC401S6zfG+DX5xNbB/udc=; b=rG2VlijA2pc60u0PlEafJ/vMPNVOs3b06FeQdM/PZIIpBk4dgmGeVcICYSUNbXpRDA g/2+1MTu0c1MMvkNsuJtXi2IyLDNESo1U28yAyNwoVG6w5iB0wAJKZJThQ98KWwFbRn9 rqTdIfMwdtmUKi82UqO/Vx2a0tmrGXnHlNoSE1GuddtvgFiFEtDUXfx7JLcaTRXaUlqc Q+fb/Y650xgzz7fQEqsqnAGMC8LNUubfpF04ego2FC8zBHhrZvMBrIpNAZiHIoLVmM1F 79GWmOKVz7htYegd8k4FIvekdQRXWzor0LQoeWRPvRsSfiq6hCRPYPbcnx20EttdskVs PI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=CL2/j/JItz+3oLrNQS5aOSC401S6zfG+DX5xNbB/udc=; b=03gfwhxheolRj8OpkVYyP1qG7rLMvf/Iqz6ReWM0GYc2v6HxcIczn3EDIzFm87AKBx JrTzlRn8uKF9nTnvkFTsSM8h2maalg6jlRvk98L42UX3jlQJtVQf4i5Hrhpfg9FfcL4V m9iFJexN18pCxGqW0PI03bVJ27h5z7M+gKJ2Z+/yDu5ZJ79TS/rzU3KtMhPb2TR6oexg 83pnMhfw3rhSizNXD79iZ2A0xo53q6nJYMHrPZWrWNHbT9dZQsV5nUzC+pEJqB8NoSpP 7/4VSbcit57BCzzkFJxb3kyAY6zm9to875n26QpZUSq1wRz9syPJstg6LJuA1uCPWSnO lkyA== X-Gm-Message-State: ACgBeo2oIu1W125aMNyr+5WC2pDQp2IPx8VmU6PklysNskK66l8/N1YV 4lM2Bk8OjRUZxJ5T03HY76cAzw== X-Google-Smtp-Source: AA6agR6J734c31m8cKsxH6hs0z5otjzVQUXq/8A1k7uEm/AT3EhLg0T6iy2PHqjAiMgvNb36mNyYvQ== X-Received: by 2002:a2e:5356:0:b0:26b:dce1:419d with SMTP id t22-20020a2e5356000000b0026bdce1419dmr5324319ljd.52.1662963524861; Sun, 11 Sep 2022 23:18:44 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:44 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 37/40] arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:43 +0200 Message-Id: <20220912061746.6311-38-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../dts/qcom/sm8350-sony-xperia-sagami.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8350.dtsi | 44 +++++++++---------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi index b702ab1605bb..b3c9952ac173 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi @@ -222,7 +222,7 @@ &spi14 { &tlmm { gpio-reserved-ranges = <44 4>; - ts_int_default: ts-int-default { + ts_int_default: ts-int-default-state { pins = "gpio23"; function = "gpio"; drive-strength = <2>; diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index e72a04411888..cd5503642a23 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1762,150 +1762,150 @@ tlmm: pinctrl@f100000 { wakeup-parent = <&pdc>; qup_uart3_default_state: qup-uart3-default-state { - rx { + rx-pins { pins = "gpio18"; function = "qup3"; }; - tx { + tx-pins { pins = "gpio19"; function = "qup3"; }; }; - qup_uart6_default: qup-uart6-default { + qup_uart6_default: qup-uart6-default-state { pins = "gpio30", "gpio31"; function = "qup6"; drive-strength = <2>; bias-disable; }; - qup_uart18_default: qup-uart18-default { + qup_uart18_default: qup-uart18-default-state { pins = "gpio58", "gpio59"; function = "qup18"; drive-strength = <2>; bias-disable; }; - qup_i2c0_default: qup-i2c0-default { + qup_i2c0_default: qup-i2c0-default-state { pins = "gpio4", "gpio5"; function = "qup0"; drive-strength = <2>; bias-pull-up; }; - qup_i2c1_default: qup-i2c1-default { + qup_i2c1_default: qup-i2c1-default-state { pins = "gpio8", "gpio9"; function = "qup1"; drive-strength = <2>; bias-pull-up; }; - qup_i2c2_default: qup-i2c2-default { + qup_i2c2_default: qup-i2c2-default-state { pins = "gpio12", "gpio13"; function = "qup2"; drive-strength = <2>; bias-pull-up; }; - qup_i2c4_default: qup-i2c4-default { + qup_i2c4_default: qup-i2c4-default-state { pins = "gpio20", "gpio21"; function = "qup4"; drive-strength = <2>; bias-pull-up; }; - qup_i2c5_default: qup-i2c5-default { + qup_i2c5_default: qup-i2c5-default-state { pins = "gpio24", "gpio25"; function = "qup5"; drive-strength = <2>; bias-pull-up; }; - qup_i2c6_default: qup-i2c6-default { + qup_i2c6_default: qup-i2c6-default-state { pins = "gpio28", "gpio29"; function = "qup6"; drive-strength = <2>; bias-pull-up; }; - qup_i2c7_default: qup-i2c7-default { + qup_i2c7_default: qup-i2c7-default-state { pins = "gpio32", "gpio33"; function = "qup7"; drive-strength = <2>; bias-disable; }; - qup_i2c8_default: qup-i2c8-default { + qup_i2c8_default: qup-i2c8-default-state { pins = "gpio36", "gpio37"; function = "qup8"; drive-strength = <2>; bias-pull-up; }; - qup_i2c9_default: qup-i2c9-default { + qup_i2c9_default: qup-i2c9-default-state { pins = "gpio40", "gpio41"; function = "qup9"; drive-strength = <2>; bias-pull-up; }; - qup_i2c10_default: qup-i2c10-default { + qup_i2c10_default: qup-i2c10-default-state { pins = "gpio44", "gpio45"; function = "qup10"; drive-strength = <2>; bias-pull-up; }; - qup_i2c11_default: qup-i2c11-default { + qup_i2c11_default: qup-i2c11-default-state { pins = "gpio48", "gpio49"; function = "qup11"; drive-strength = <2>; bias-pull-up; }; - qup_i2c12_default: qup-i2c12-default { + qup_i2c12_default: qup-i2c12-default-state { pins = "gpio52", "gpio53"; function = "qup12"; drive-strength = <2>; bias-pull-up; }; - qup_i2c13_default: qup-i2c13-default { + qup_i2c13_default: qup-i2c13-default-state { pins = "gpio0", "gpio1"; function = "qup13"; drive-strength = <2>; bias-pull-up; }; - qup_i2c14_default: qup-i2c14-default { + qup_i2c14_default: qup-i2c14-default-state { pins = "gpio56", "gpio57"; function = "qup14"; drive-strength = <2>; bias-disable; }; - qup_i2c15_default: qup-i2c15-default { + qup_i2c15_default: qup-i2c15-default-state { pins = "gpio60", "gpio61"; function = "qup15"; drive-strength = <2>; bias-disable; }; - qup_i2c16_default: qup-i2c16-default { + qup_i2c16_default: qup-i2c16-default-state { pins = "gpio64", "gpio65"; function = "qup16"; drive-strength = <2>; bias-disable; }; - qup_i2c17_default: qup-i2c17-default { + qup_i2c17_default: qup-i2c17-default-state { pins = "gpio72", "gpio73"; function = "qup17"; drive-strength = <2>; bias-disable; }; - qup_i2c19_default: qup-i2c19-default { + qup_i2c19_default: qup-i2c19-default-state { pins = "gpio76", "gpio77"; function = "qup19"; drive-strength = <2>; From patchwork Mon Sep 12 06:17:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E713C6FA8A for ; Mon, 12 Sep 2022 06:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230115AbiILGVI (ORCPT ); Mon, 12 Sep 2022 02:21:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229982AbiILGUN (ORCPT ); Mon, 12 Sep 2022 02:20:13 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C98F2B26C for ; Sun, 11 Sep 2022 23:18:47 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id f9so12423515lfr.3 for ; Sun, 11 Sep 2022 23:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Agf1+UyJe+fVcEGMvuo1mvU0w0VboU6bQsb5wGtqwzo=; b=mt6//2wN69Yj3nOhwlwIpUAf/toiHld+utFjB1UmLCN2F7u3bS+g9Q7MMtqQlZ6Mp4 XXQcTIh6WAoEPkpfXg136mm6SZbTtCQrKwWBObSjwHzmSkcsrlqVfCr3X2tS1g9qmcEk 2Gx4RM5KfVTsc6bMtq3OcjMCsyQBDw1R4fyfuJp4rf6iLKJOmsRSVFCeL5eaifBzn7fS I2lK7Yof/O7gixiqjQTEPHicl+ilas/pprhAAYXOn7pPvCEUizS65eMpyvwb7FmlLcX9 8xXsKH32SUy7iq4Tll0//yWi4dqne6rKcsuF8sHejCwVmIKhK2u3QSdO3mSUrqEKz9c2 3pJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Agf1+UyJe+fVcEGMvuo1mvU0w0VboU6bQsb5wGtqwzo=; b=E7FH6qRwJZHUsv9cBlpxvhjGvTkDecxlHriFFS9SFx9xBcX82H1sahFaYSAYHub0Q/ hmZ/uWQuyojonwxWg/9gbBV6BFRavQ5FRMF+0SYoMFQHKupU3vVgaZWI1CJaV1trgwQN 5S+YLVQcWV6FyyR4f3exnlwwu1A9T2ZrPLpHQRbaihGcUl99FOtxDD+lm1iRvmC/YKFr hSGCbhSOceplY7mSRJW7NyECP+W16moL3xqXlbTe5kfnSOtnl5eflf7hA+xcXQ7Vmjx5 +ThVjjJo68lguWLNXxag0b28rB/IcO7FTjoDs88S4gCEGi+umR5XDcwpzY4F4tlfXBlg sIwQ== X-Gm-Message-State: ACgBeo1UuDxz2XifZGRc+67nXes17D1rTqoXDm90HJgdEhtMfp0DXU/j uPse6teMuZolvPbAG6XaWgsfGg== X-Google-Smtp-Source: AA6agR61r5W+TqcVo17JrpiKR9RSsLrs8VwNGDA/e499flUqoiGLzql9xlDLfMzGxx6WFGvzei6Qog== X-Received: by 2002:a05:6512:10cd:b0:498:fe5b:8ab3 with SMTP id k13-20020a05651210cd00b00498fe5b8ab3mr4971305lfg.613.1662963526686; Sun, 11 Sep 2022 23:18:46 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:46 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 38/40] arm64: dts: qcom: sm8450: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:44 +0200 Message-Id: <20220912061746.6311-39-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../qcom/sm8450-sony-xperia-nagara-pdx223.dts | 12 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 152 +++++++++--------- 2 files changed, 82 insertions(+), 82 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts index 7fe582b92a61..d68765eb6d4f 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts @@ -572,27 +572,27 @@ &spi10 { &tlmm { gpio-reserved-ranges = <28 4>; - sdc2_default_state: sdc2-default { - clk { + sdc2_default_state: sdc2-default-state { + clk-pins { pins = "sdc2_clk"; drive-strength = <16>; bias-disable; }; - cmd { + cmd-pins { pins = "sdc2_cmd"; drive-strength = <16>; bias-pull-up; }; - data { + data-pins { pins = "sdc2_data"; drive-strength = <16>; bias-pull-up; }; }; - ts_int_default: ts-int-default { + ts_int_default: ts-int-default-state { pins = "gpio23"; function = "gpio"; drive-strength = <2>; @@ -600,7 +600,7 @@ ts_int_default: ts-int-default { input-enable; }; - sdc2_card_det_n: sd-card-det-n { + sdc2_card_det_n: sd-card-det-n-state { pins = "gpio92"; function = "gpio"; drive-strength = <2>; diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index d0ebf61a0074..1d878256028f 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2384,20 +2384,20 @@ tlmm: pinctrl@f100000 { gpio-ranges = <&tlmm 0 0 211>; wakeup-parent = <&pdc>; - sdc2_sleep_state: sdc2-sleep { - clk { + sdc2_sleep_state: sdc2-sleep-state { + clk-pins { pins = "sdc2_clk"; drive-strength = <2>; bias-disable; }; - cmd { + cmd-pins { pins = "sdc2_cmd"; drive-strength = <2>; bias-pull-up; }; - data { + data-pins { pins = "sdc2_data"; drive-strength = <2>; bias-pull-up; @@ -2405,21 +2405,21 @@ data { }; pcie0_default_state: pcie0-default-state { - perst { + perst-pins { pins = "gpio94"; function = "gpio"; drive-strength = <2>; bias-pull-down; }; - clkreq { + clkreq-pins { pins = "gpio95"; function = "pcie0_clkreqn"; drive-strength = <2>; bias-pull-up; }; - wake { + wake-pins { pins = "gpio96"; function = "gpio"; drive-strength = <2>; @@ -2428,21 +2428,21 @@ wake { }; pcie1_default_state: pcie1-default-state { - perst { + perst-pins { pins = "gpio97"; function = "gpio"; drive-strength = <2>; bias-pull-down; }; - clkreq { + clkreq-pins { pins = "gpio98"; function = "pcie1_clkreqn"; drive-strength = <2>; bias-pull-up; }; - wake { + wake-pins { pins = "gpio99"; function = "gpio"; drive-strength = <2>; @@ -2450,350 +2450,350 @@ wake { }; }; - qup_i2c0_data_clk: qup-i2c0-data-clk { + qup_i2c0_data_clk: qup-i2c0-data-clk-state { pins = "gpio0", "gpio1"; function = "qup0"; }; - qup_i2c1_data_clk: qup-i2c1-data-clk { + qup_i2c1_data_clk: qup-i2c1-data-clk-state { pins = "gpio4", "gpio5"; function = "qup1"; }; - qup_i2c2_data_clk: qup-i2c2-data-clk { + qup_i2c2_data_clk: qup-i2c2-data-clk-state { pins = "gpio8", "gpio9"; function = "qup2"; }; - qup_i2c3_data_clk: qup-i2c3-data-clk { + qup_i2c3_data_clk: qup-i2c3-data-clk-state { pins = "gpio12", "gpio13"; function = "qup3"; }; - qup_i2c4_data_clk: qup-i2c4-data-clk { + qup_i2c4_data_clk: qup-i2c4-data-clk-state { pins = "gpio16", "gpio17"; function = "qup4"; }; - qup_i2c5_data_clk: qup-i2c5-data-clk { + qup_i2c5_data_clk: qup-i2c5-data-clk-state { pins = "gpio206", "gpio207"; function = "qup5"; }; - qup_i2c6_data_clk: qup-i2c6-data-clk { + qup_i2c6_data_clk: qup-i2c6-data-clk-state { pins = "gpio20", "gpio21"; function = "qup6"; }; - qup_i2c8_data_clk: qup-i2c8-data-clk { + qup_i2c8_data_clk: qup-i2c8-data-clk-state { pins = "gpio28", "gpio29"; function = "qup8"; }; - qup_i2c9_data_clk: qup-i2c9-data-clk { + qup_i2c9_data_clk: qup-i2c9-data-clk-state { pins = "gpio32", "gpio33"; function = "qup9"; }; - qup_i2c10_data_clk: qup-i2c10-data-clk { + qup_i2c10_data_clk: qup-i2c10-data-clk-state { pins = "gpio36", "gpio37"; function = "qup10"; }; - qup_i2c11_data_clk: qup-i2c11-data-clk { + qup_i2c11_data_clk: qup-i2c11-data-clk-state { pins = "gpio40", "gpio41"; function = "qup11"; }; - qup_i2c12_data_clk: qup-i2c12-data-clk { + qup_i2c12_data_clk: qup-i2c12-data-clk-state { pins = "gpio44", "gpio45"; function = "qup12"; }; - qup_i2c13_data_clk: qup-i2c13-data-clk { + qup_i2c13_data_clk: qup-i2c13-data-clk-state { pins = "gpio48", "gpio49"; function = "qup13"; drive-strength = <2>; bias-pull-up; }; - qup_i2c14_data_clk: qup-i2c14-data-clk { + qup_i2c14_data_clk: qup-i2c14-data-clk-state { pins = "gpio52", "gpio53"; function = "qup14"; drive-strength = <2>; bias-pull-up; }; - qup_i2c15_data_clk: qup-i2c15-data-clk { + qup_i2c15_data_clk: qup-i2c15-data-clk-state { pins = "gpio56", "gpio57"; function = "qup15"; }; - qup_i2c16_data_clk: qup-i2c16-data-clk { + qup_i2c16_data_clk: qup-i2c16-data-clk-state { pins = "gpio60", "gpio61"; function = "qup16"; }; - qup_i2c17_data_clk: qup-i2c17-data-clk { + qup_i2c17_data_clk: qup-i2c17-data-clk-state { pins = "gpio64", "gpio65"; function = "qup17"; }; - qup_i2c18_data_clk: qup-i2c18-data-clk { + qup_i2c18_data_clk: qup-i2c18-data-clk-state { pins = "gpio68", "gpio69"; function = "qup18"; }; - qup_i2c19_data_clk: qup-i2c19-data-clk { + qup_i2c19_data_clk: qup-i2c19-data-clk-state { pins = "gpio72", "gpio73"; function = "qup19"; }; - qup_i2c20_data_clk: qup-i2c20-data-clk { + qup_i2c20_data_clk: qup-i2c20-data-clk-state { pins = "gpio76", "gpio77"; function = "qup20"; }; - qup_i2c21_data_clk: qup-i2c21-data-clk { + qup_i2c21_data_clk: qup-i2c21-data-clk-state { pins = "gpio80", "gpio81"; function = "qup21"; }; - qup_spi0_cs: qup-spi0-cs { + qup_spi0_cs: qup-spi0-cs-state { pins = "gpio3"; function = "qup0"; }; - qup_spi0_data_clk: qup-spi0-data-clk { + qup_spi0_data_clk: qup-spi0-data-clk-state { pins = "gpio0", "gpio1", "gpio2"; function = "qup0"; }; - qup_spi1_cs: qup-spi1-cs { + qup_spi1_cs: qup-spi1-cs-state { pins = "gpio7"; function = "qup1"; }; - qup_spi1_data_clk: qup-spi1-data-clk { + qup_spi1_data_clk: qup-spi1-data-clk-state { pins = "gpio4", "gpio5", "gpio6"; function = "qup1"; }; - qup_spi2_cs: qup-spi2-cs { + qup_spi2_cs: qup-spi2-cs-state { pins = "gpio11"; function = "qup2"; }; - qup_spi2_data_clk: qup-spi2-data-clk { + qup_spi2_data_clk: qup-spi2-data-clk-state { pins = "gpio8", "gpio9", "gpio10"; function = "qup2"; }; - qup_spi3_cs: qup-spi3-cs { + qup_spi3_cs: qup-spi3-cs-state { pins = "gpio15"; function = "qup3"; }; - qup_spi3_data_clk: qup-spi3-data-clk { + qup_spi3_data_clk: qup-spi3-data-clk-state { pins = "gpio12", "gpio13", "gpio14"; function = "qup3"; }; - qup_spi4_cs: qup-spi4-cs { + qup_spi4_cs: qup-spi4-cs-state { pins = "gpio19"; function = "qup4"; drive-strength = <6>; bias-disable; }; - qup_spi4_data_clk: qup-spi4-data-clk { + qup_spi4_data_clk: qup-spi4-data-clk-state { pins = "gpio16", "gpio17", "gpio18"; function = "qup4"; }; - qup_spi5_cs: qup-spi5-cs { + qup_spi5_cs: qup-spi5-cs-state { pins = "gpio85"; function = "qup5"; }; - qup_spi5_data_clk: qup-spi5-data-clk { + qup_spi5_data_clk: qup-spi5-data-clk-state { pins = "gpio206", "gpio207", "gpio84"; function = "qup5"; }; - qup_spi6_cs: qup-spi6-cs { + qup_spi6_cs: qup-spi6-cs-state { pins = "gpio23"; function = "qup6"; }; - qup_spi6_data_clk: qup-spi6-data-clk { + qup_spi6_data_clk: qup-spi6-data-clk-state { pins = "gpio20", "gpio21", "gpio22"; function = "qup6"; }; - qup_spi8_cs: qup-spi8-cs { + qup_spi8_cs: qup-spi8-cs-state { pins = "gpio31"; function = "qup8"; }; - qup_spi8_data_clk: qup-spi8-data-clk { + qup_spi8_data_clk: qup-spi8-data-clk-state { pins = "gpio28", "gpio29", "gpio30"; function = "qup8"; }; - qup_spi9_cs: qup-spi9-cs { + qup_spi9_cs: qup-spi9-cs-state { pins = "gpio35"; function = "qup9"; }; - qup_spi9_data_clk: qup-spi9-data-clk { + qup_spi9_data_clk: qup-spi9-data-clk-state { pins = "gpio32", "gpio33", "gpio34"; function = "qup9"; }; - qup_spi10_cs: qup-spi10-cs { + qup_spi10_cs: qup-spi10-cs-state { pins = "gpio39"; function = "qup10"; }; - qup_spi10_data_clk: qup-spi10-data-clk { + qup_spi10_data_clk: qup-spi10-data-clk-state { pins = "gpio36", "gpio37", "gpio38"; function = "qup10"; }; - qup_spi11_cs: qup-spi11-cs { + qup_spi11_cs: qup-spi11-cs-state { pins = "gpio43"; function = "qup11"; }; - qup_spi11_data_clk: qup-spi11-data-clk { + qup_spi11_data_clk: qup-spi11-data-clk-state { pins = "gpio40", "gpio41", "gpio42"; function = "qup11"; }; - qup_spi12_cs: qup-spi12-cs { + qup_spi12_cs: qup-spi12-cs-state { pins = "gpio47"; function = "qup12"; }; - qup_spi12_data_clk: qup-spi12-data-clk { + qup_spi12_data_clk: qup-spi12-data-clk-state { pins = "gpio44", "gpio45", "gpio46"; function = "qup12"; }; - qup_spi13_cs: qup-spi13-cs { + qup_spi13_cs: qup-spi13-cs-state { pins = "gpio51"; function = "qup13"; }; - qup_spi13_data_clk: qup-spi13-data-clk { + qup_spi13_data_clk: qup-spi13-data-clk-state { pins = "gpio48", "gpio49", "gpio50"; function = "qup13"; }; - qup_spi14_cs: qup-spi14-cs { + qup_spi14_cs: qup-spi14-cs-state { pins = "gpio55"; function = "qup14"; }; - qup_spi14_data_clk: qup-spi14-data-clk { + qup_spi14_data_clk: qup-spi14-data-clk-state { pins = "gpio52", "gpio53", "gpio54"; function = "qup14"; }; - qup_spi15_cs: qup-spi15-cs { + qup_spi15_cs: qup-spi15-cs-state { pins = "gpio59"; function = "qup15"; }; - qup_spi15_data_clk: qup-spi15-data-clk { + qup_spi15_data_clk: qup-spi15-data-clk-state { pins = "gpio56", "gpio57", "gpio58"; function = "qup15"; }; - qup_spi16_cs: qup-spi16-cs { + qup_spi16_cs: qup-spi16-cs-state { pins = "gpio63"; function = "qup16"; }; - qup_spi16_data_clk: qup-spi16-data-clk { + qup_spi16_data_clk: qup-spi16-data-clk-state { pins = "gpio60", "gpio61", "gpio62"; function = "qup16"; }; - qup_spi17_cs: qup-spi17-cs { + qup_spi17_cs: qup-spi17-cs-state { pins = "gpio67"; function = "qup17"; }; - qup_spi17_data_clk: qup-spi17-data-clk { + qup_spi17_data_clk: qup-spi17-data-clk-state { pins = "gpio64", "gpio65", "gpio66"; function = "qup17"; }; - qup_spi18_cs: qup-spi18-cs { + qup_spi18_cs: qup-spi18-cs-state { pins = "gpio71"; function = "qup18"; drive-strength = <6>; bias-disable; }; - qup_spi18_data_clk: qup-spi18-data-clk { + qup_spi18_data_clk: qup-spi18-data-clk-state { pins = "gpio68", "gpio69", "gpio70"; function = "qup18"; drive-strength = <6>; bias-disable; }; - qup_spi19_cs: qup-spi19-cs { + qup_spi19_cs: qup-spi19-cs-state { pins = "gpio75"; function = "qup19"; drive-strength = <6>; bias-disable; }; - qup_spi19_data_clk: qup-spi19-data-clk { + qup_spi19_data_clk: qup-spi19-data-clk-state { pins = "gpio72", "gpio73", "gpio74"; function = "qup19"; drive-strength = <6>; bias-disable; }; - qup_spi20_cs: qup-spi20-cs { + qup_spi20_cs: qup-spi20-cs-state { pins = "gpio79"; function = "qup20"; }; - qup_spi20_data_clk: qup-spi20-data-clk { + qup_spi20_data_clk: qup-spi20-data-clk-state { pins = "gpio76", "gpio77", "gpio78"; function = "qup20"; }; - qup_spi21_cs: qup-spi21-cs { + qup_spi21_cs: qup-spi21-cs-state { pins = "gpio83"; function = "qup21"; }; - qup_spi21_data_clk: qup-spi21-data-clk { + qup_spi21_data_clk: qup-spi21-data-clk-state { pins = "gpio80", "gpio81", "gpio82"; function = "qup21"; }; - qup_uart7_rx: qup-uart7-rx { + qup_uart7_rx: qup-uart7-rx-state { pins = "gpio26"; function = "qup7"; drive-strength = <2>; bias-disable; }; - qup_uart7_tx: qup-uart7-tx { + qup_uart7_tx: qup-uart7-tx-state { pins = "gpio27"; function = "qup7"; drive-strength = <2>; bias-disable; }; - qup_uart20_default: qup-uart20-default { + qup_uart20_default: qup-uart20-default-state { pins = "gpio76", "gpio77", "gpio78", "gpio79"; function = "qup20"; }; From patchwork Mon Sep 12 06:17:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FEA7ECAAD5 for ; Mon, 12 Sep 2022 06:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbiILGWC (ORCPT ); Mon, 12 Sep 2022 02:22:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiILGVc (ORCPT ); Mon, 12 Sep 2022 02:21:32 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D76A2A959 for ; Sun, 11 Sep 2022 23:19:12 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f9so12423578lfr.3 for ; Sun, 11 Sep 2022 23:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=kCmef+I4ubqqGDCcAcc+6D54ls+qXxrTz9AD5rjIgz8=; b=xTRopjT8RULABlCJHqxtuxh/0qxNvnYELgRRhlf/yV20satUbzwzOvennLl0Qd4m9N Qvjj19khSdT/mfewd5E+BA8QWXkYFp6AdFi0+/epYrwaTZdSUnH4yRMLlZAABiisa/p3 /ekgfLNYibWpqe4R7G4RK5aJ0y/qKdSVuoaF6nPPQQ8Ik/In7ed2mZ9KU5kUoVQY72+7 6Cg9V7+xSGFgfS0AAxWM+iZvSk0FoeQrGiq4rFiK2R+AhvnpeOLfOUMQoHexLWeY/PQm mzgigqoLplRq5U7DqGmW7wanEZt4gAeAGSmA+jCHyF9/GnVufOZy6duWj7m+3M/tjAv7 yaCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=kCmef+I4ubqqGDCcAcc+6D54ls+qXxrTz9AD5rjIgz8=; b=60QrTdMqcEeUN0p12b8//5z6EVonvsoDq7t+1Y1F0R4r5V7LIjNa0tqweNCOmg6THG B2qR+KGDq1p40RwUN71e3HOczFuCGxNNZyQLG3J6PRoL+dZq2K5UVYyOUWomlHGf+/mo gEmgS8texvH6sHSKcdlqFt07DPb5XrYn52E6/DpTGEy2MoKhxodYxMkyMl1PVnCAl2mo d4nbfrtfL5YTOqHZhCnSFVqrFxvIr+kk1+3cFmCmevqOSHLiWQ1Sxw69R37PACr5s/z4 IxJypz1OhbXY3KcK4aSy7xTReHL4e8VwbsszysnA8lsIzVesU4B24Oo1Ypq8pSFKG3zx OFCw== X-Gm-Message-State: ACgBeo03cVtskfTkvpkofiSHdTanIAix0DyC4eAcYKRtaRQdfAxvjZCS RLqJj0yk7SdrAExAsKqIz9B67w== X-Google-Smtp-Source: AA6agR6lUpkimdHOgaaptYrNlgGPNjggTiAYrXWDC3WCH4/ehXWMlFBARLmq0/i+k0tWHlAUvSIdHg== X-Received: by 2002:a05:6512:3a87:b0:499:2069:17af with SMTP id q7-20020a0565123a8700b00499206917afmr4524286lfu.38.1662963528144; Sun, 11 Sep 2022 23:18:48 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:47 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 39/40] arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema Date: Mon, 12 Sep 2022 08:17:45 +0200 Message-Id: <20220912061746.6311-40-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 44 +-- .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 8 +- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 20 +- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 14 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 316 +++++++++--------- 5 files changed, 201 insertions(+), 201 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index 45f6a1e1002e..82307722222a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -717,27 +717,27 @@ &tlmm { pinctrl-names = "default"; pinctrl-0 = <&bios_flash_wp_od>; - amp_en: amp-en { + amp_en: amp-en-pins { pins = "gpio63"; function = "gpio"; bias-disable; drive-strength = <2>; }; - ap_ec_int_l: ap-ec-int-l { + ap_ec_int_l: ap-ec-int-l-pins { pins = "gpio18"; function = "gpio"; bias-pull-up; }; - bios_flash_wp_od: bios-flash-wp-od { + bios_flash_wp_od: bios-flash-wp-od-pins { pins = "gpio16"; function = "gpio"; /* Has external pull */ bias-disable; }; - en_fp_rails: en-fp-rails { + en_fp_rails: en-fp-rails-pins { pins = "gpio77"; function = "gpio"; bias-disable; @@ -745,60 +745,60 @@ en_fp_rails: en-fp-rails { output-high; }; - en_pp3300_codec: en-pp3300-codec { + en_pp3300_codec: en-pp3300-codec-pins { pins = "gpio105"; function = "gpio"; bias-disable; drive-strength = <2>; }; - en_pp3300_dx_edp: en-pp3300-dx-edp { + en_pp3300_dx_edp: en-pp3300-dx-edp-pins { pins = "gpio80"; function = "gpio"; bias-disable; drive-strength = <2>; }; - fp_rst_l: fp-rst-l { + fp_rst_l: fp-rst-l-pins { pins = "gpio78"; function = "gpio"; bias-disable; drive-strength = <2>; }; - fp_to_ap_irq_l: fp-to-ap-irq-l { + fp_to_ap_irq_l: fp-to-ap-irq-l-pins { pins = "gpio61"; function = "gpio"; /* Has external pullup */ bias-disable; }; - fpmcu_boot0: fpmcu-boot0 { + fpmcu_boot0: fpmcu-boot0-pins { pins = "gpio68"; function = "gpio"; bias-disable; }; - gsc_ap_int_odl: gsc-ap-int-odl { + gsc_ap_int_odl: gsc-ap-int-odl-pins { pins = "gpio104"; function = "gpio"; bias-pull-up; }; - hp_irq: hp-irq { + hp_irq: hp-irq-pins { pins = "gpio101"; function = "gpio"; bias-pull-up; }; - hub_en: hub-en { + hub_en: hub-en-pins { pins = "gpio157"; function = "gpio"; bias-disable; drive-strength = <2>; }; - pe_wake_odl: pe-wake-odl { + pe_wake_odl: pe-wake-odl-pins { pins = "gpio3"; function = "gpio"; /* Has external pull */ @@ -807,45 +807,45 @@ pe_wake_odl: pe-wake-odl { }; /* For ap_spi_fp */ - qup_spi9_cs_gpio_init_high: qup-spi9-cs-gpio-init-high { + qup_spi9_cs_gpio_init_high: qup-spi9-cs-gpio-init-high-pins { pins = "gpio39"; function = "gpio"; output-high; }; /* For ap_ec_spi */ - qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high { + qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high-pins { pins = "gpio43"; function = "gpio"; output-high; }; - sar0_irq_odl: sar0-irq-odl { + sar0_irq_odl: sar0-irq-odl-pins { pins = "gpio141"; function = "gpio"; bias-pull-up; }; - sar1_irq_odl: sar1-irq-odl { + sar1_irq_odl: sar1-irq-odl-pins { pins = "gpio140"; function = "gpio"; bias-pull-up; }; - sd_cd_odl: sd-cd-odl { + sd_cd_odl: sd-cd-odl-pins { pins = "gpio91"; function = "gpio"; bias-pull-up; }; - ssd_en: ssd-en { + ssd_en: ssd-en-pins { pins = "gpio51"; function = "gpio"; bias-disable; drive-strength = <2>; }; - ssd_rst_l: ssd-rst-l { + ssd_rst_l: ssd-rst-l-pins { pins = "gpio2"; function = "gpio"; bias-disable; @@ -853,14 +853,14 @@ ssd_rst_l: ssd-rst-l { output-low; }; - tp_int_odl: tp-int-odl { + tp_int_odl: tp-int-odl-pins { pins = "gpio7"; function = "gpio"; /* Has external pullup */ bias-disable; }; - wf_cam_en: wf-cam-en { + wf_cam_en: wf-cam-en-pins { pins = "gpio119"; function = "gpio"; /* Has external pulldown */ diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi index a7c346aa3b02..7f5143e9bb80 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi @@ -79,26 +79,26 @@ cr50: tpm@0 { }; &tlmm { - ap_ec_int_l: ap-ec-int-l { + ap_ec_int_l: ap-ec-int-l-pins { pins = "gpio18"; function = "gpio"; input-enable; bias-pull-up; }; - h1_ap_int_odl: h1-ap-int-odl { + h1_ap_int_odl: h1-ap-int-odl-pins { pins = "gpio104"; function = "gpio"; input-enable; bias-pull-up; }; - qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high { + qup_spi10_cs_gpio_init_high: qup-spi10-cs-gpio-init-high-pins { pins = "gpio43"; output-high; }; - qup_spi14_cs_gpio_init_high: qup-spi14-cs-gpio-init-high { + qup_spi14_cs_gpio_init_high: qup-spi14-cs-gpio-init-high-pins { pins = "gpio59"; output-high; }; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 0c48db69e1ef..89ecf0d25a12 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -550,18 +550,18 @@ &sdc2_data { }; &tlmm { - bt_en: bt-en { + bt_en: bt-en-pins { pins = "gpio85"; function = "gpio"; output-low; bias-disable; }; - nvme_pwren: nvme-pwren { + nvme_pwren: nvme-pwren-pins { function = "gpio"; }; - pcie1_reset_n: pcie1-reset-n { + pcie1_reset_n: pcie1-reset-n-pins { pins = "gpio2"; function = "gpio"; @@ -570,7 +570,7 @@ pcie1_reset_n: pcie1-reset-n { bias-disable; }; - pcie1_wake_n: pcie1-wake-n { + pcie1_wake_n: pcie1-wake-n-pins { pins = "gpio3"; function = "gpio"; @@ -578,7 +578,7 @@ pcie1_wake_n: pcie1-wake-n { bias-pull-up; }; - qup_uart7_sleep_cts: qup-uart7-sleep-cts { + qup_uart7_sleep_cts: qup-uart7-sleep-cts-pins { pins = "gpio28"; function = "gpio"; /* @@ -591,7 +591,7 @@ qup_uart7_sleep_cts: qup-uart7-sleep-cts { bias-bus-hold; }; - qup_uart7_sleep_rts: qup-uart7-sleep-rts { + qup_uart7_sleep_rts: qup-uart7-sleep-rts-pins { pins = "gpio29"; function = "gpio"; /* @@ -603,7 +603,7 @@ qup_uart7_sleep_rts: qup-uart7-sleep-rts { bias-pull-down; }; - qup_uart7_sleep_tx: qup-uart7-sleep-tx { + qup_uart7_sleep_tx: qup-uart7-sleep-tx-pins { pins = "gpio30"; function = "gpio"; /* @@ -613,7 +613,7 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx { bias-pull-up; }; - qup_uart7_sleep_rx: qup-uart7-sleep-rx { + qup_uart7_sleep_rx: qup-uart7-sleep-rx-pins { pins = "gpio31"; function = "gpio"; /* @@ -624,13 +624,13 @@ qup_uart7_sleep_rx: qup-uart7-sleep-rx { bias-pull-up; }; - sd_cd: sd-cd { + sd_cd: sd-cd-pins { pins = "gpio91"; function = "gpio"; bias-pull-up; }; - sw_ctrl: sw-ctrl { + sw_ctrl: sw-ctrl-pins { pins = "gpio86"; function = "gpio"; bias-pull-down; diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index 7cd91df7a118..0b56aecf857b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -542,7 +542,7 @@ pmic_edp_bl_pwm: pmic-edp-bl-pwm-state { }; &tlmm { - mos_bt_en: mos-bt-en { + mos_bt_en: mos-bt-en-pins { pins = "gpio85"; function = "gpio"; drive-strength = <2>; @@ -550,7 +550,7 @@ mos_bt_en: mos-bt-en { }; /* For mos_bt_uart */ - qup_uart7_sleep_cts: qup-uart7-sleep-cts { + qup_uart7_sleep_cts: qup-uart7-sleep-cts-pins { pins = "gpio28"; function = "gpio"; /* @@ -564,7 +564,7 @@ qup_uart7_sleep_cts: qup-uart7-sleep-cts { }; /* For mos_bt_uart */ - qup_uart7_sleep_rts: qup-uart7-sleep-rts { + qup_uart7_sleep_rts: qup-uart7-sleep-rts-pins { pins = "gpio29"; function = "gpio"; /* @@ -577,7 +577,7 @@ qup_uart7_sleep_rts: qup-uart7-sleep-rts { }; /* For mos_bt_uart */ - qup_uart7_sleep_rx: qup-uart7-sleep-rx { + qup_uart7_sleep_rx: qup-uart7-sleep-rx-pins { pins = "gpio31"; function = "gpio"; /* @@ -589,7 +589,7 @@ qup_uart7_sleep_rx: qup-uart7-sleep-rx { }; /* For mos_bt_uart */ - qup_uart7_sleep_tx: qup-uart7-sleep-tx { + qup_uart7_sleep_tx: qup-uart7-sleep-tx-pins { pins = "gpio30"; function = "gpio"; /* @@ -599,13 +599,13 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx { bias-pull-up; }; - ts_int_conn: ts-int-conn { + ts_int_conn: ts-int-conn-pins { pins = "gpio55"; function = "gpio"; bias-pull-up; }; - ts_rst_conn: ts-rst-conn { + ts_rst_conn: ts-rst-conn-pins { pins = "gpio54"; function = "gpio"; drive-strength = <2>; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index ad04025a8a1a..07fa3e417a96 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4061,791 +4061,791 @@ tlmm: pinctrl@f100000 { gpio-ranges = <&tlmm 0 0 175>; wakeup-parent = <&pdc>; - dp_hot_plug_det: dp-hot-plug-det { + dp_hot_plug_det: dp-hot-plug-det-pins { pins = "gpio47"; function = "dp_hot"; }; - edp_hot_plug_det: edp-hot-plug-det { + edp_hot_plug_det: edp-hot-plug-det-pins { pins = "gpio60"; function = "edp_hot"; }; - mi2s0_data0: mi2s0-data0 { + mi2s0_data0: mi2s0-data0-pins { pins = "gpio98"; function = "mi2s0_data0"; }; - mi2s0_data1: mi2s0-data1 { + mi2s0_data1: mi2s0-data1-pins { pins = "gpio99"; function = "mi2s0_data1"; }; - mi2s0_mclk: mi2s0-mclk { + mi2s0_mclk: mi2s0-mclk-pins { pins = "gpio96"; function = "pri_mi2s"; }; - mi2s0_sclk: mi2s0-sclk { + mi2s0_sclk: mi2s0-sclk-pins { pins = "gpio97"; function = "mi2s0_sck"; }; - mi2s0_ws: mi2s0-ws { + mi2s0_ws: mi2s0-ws-pins { pins = "gpio100"; function = "mi2s0_ws"; }; - mi2s1_data0: mi2s1-data0 { + mi2s1_data0: mi2s1-data0-pins { pins = "gpio107"; function = "mi2s1_data0"; }; - mi2s1_sclk: mi2s1-sclk { + mi2s1_sclk: mi2s1-sclk-pins { pins = "gpio106"; function = "mi2s1_sck"; }; - mi2s1_ws: mi2s1-ws { + mi2s1_ws: mi2s1-ws-pins { pins = "gpio108"; function = "mi2s1_ws"; }; - pcie1_clkreq_n: pcie1-clkreq-n { + pcie1_clkreq_n: pcie1-clkreq-n-pins { pins = "gpio79"; function = "pcie1_clkreqn"; }; - qspi_clk: qspi-clk { + qspi_clk: qspi-clk-pins { pins = "gpio14"; function = "qspi_clk"; }; - qspi_cs0: qspi-cs0 { + qspi_cs0: qspi-cs0-pins { pins = "gpio15"; function = "qspi_cs"; }; - qspi_cs1: qspi-cs1 { + qspi_cs1: qspi-cs1-pins { pins = "gpio19"; function = "qspi_cs"; }; - qspi_data01: qspi-data01 { + qspi_data01: qspi-data01-pins { pins = "gpio12", "gpio13"; function = "qspi_data"; }; - qspi_data12: qspi-data12 { + qspi_data12: qspi-data12-pins { pins = "gpio16", "gpio17"; function = "qspi_data"; }; - qup_i2c0_data_clk: qup-i2c0-data-clk { + qup_i2c0_data_clk: qup-i2c0-data-clk-pins { pins = "gpio0", "gpio1"; function = "qup00"; }; - qup_i2c1_data_clk: qup-i2c1-data-clk { + qup_i2c1_data_clk: qup-i2c1-data-clk-pins { pins = "gpio4", "gpio5"; function = "qup01"; }; - qup_i2c2_data_clk: qup-i2c2-data-clk { + qup_i2c2_data_clk: qup-i2c2-data-clk-pins { pins = "gpio8", "gpio9"; function = "qup02"; }; - qup_i2c3_data_clk: qup-i2c3-data-clk { + qup_i2c3_data_clk: qup-i2c3-data-clk-pins { pins = "gpio12", "gpio13"; function = "qup03"; }; - qup_i2c4_data_clk: qup-i2c4-data-clk { + qup_i2c4_data_clk: qup-i2c4-data-clk-pins { pins = "gpio16", "gpio17"; function = "qup04"; }; - qup_i2c5_data_clk: qup-i2c5-data-clk { + qup_i2c5_data_clk: qup-i2c5-data-clk-pins { pins = "gpio20", "gpio21"; function = "qup05"; }; - qup_i2c6_data_clk: qup-i2c6-data-clk { + qup_i2c6_data_clk: qup-i2c6-data-clk-pins { pins = "gpio24", "gpio25"; function = "qup06"; }; - qup_i2c7_data_clk: qup-i2c7-data-clk { + qup_i2c7_data_clk: qup-i2c7-data-clk-pins { pins = "gpio28", "gpio29"; function = "qup07"; }; - qup_i2c8_data_clk: qup-i2c8-data-clk { + qup_i2c8_data_clk: qup-i2c8-data-clk-pins { pins = "gpio32", "gpio33"; function = "qup10"; }; - qup_i2c9_data_clk: qup-i2c9-data-clk { + qup_i2c9_data_clk: qup-i2c9-data-clk-pins { pins = "gpio36", "gpio37"; function = "qup11"; }; - qup_i2c10_data_clk: qup-i2c10-data-clk { + qup_i2c10_data_clk: qup-i2c10-data-clk-pins { pins = "gpio40", "gpio41"; function = "qup12"; }; - qup_i2c11_data_clk: qup-i2c11-data-clk { + qup_i2c11_data_clk: qup-i2c11-data-clk-pins { pins = "gpio44", "gpio45"; function = "qup13"; }; - qup_i2c12_data_clk: qup-i2c12-data-clk { + qup_i2c12_data_clk: qup-i2c12-data-clk-pins { pins = "gpio48", "gpio49"; function = "qup14"; }; - qup_i2c13_data_clk: qup-i2c13-data-clk { + qup_i2c13_data_clk: qup-i2c13-data-clk-pins { pins = "gpio52", "gpio53"; function = "qup15"; }; - qup_i2c14_data_clk: qup-i2c14-data-clk { + qup_i2c14_data_clk: qup-i2c14-data-clk-pins { pins = "gpio56", "gpio57"; function = "qup16"; }; - qup_i2c15_data_clk: qup-i2c15-data-clk { + qup_i2c15_data_clk: qup-i2c15-data-clk-pins { pins = "gpio60", "gpio61"; function = "qup17"; }; - qup_spi0_data_clk: qup-spi0-data-clk { + qup_spi0_data_clk: qup-spi0-data-clk-pins { pins = "gpio0", "gpio1", "gpio2"; function = "qup00"; }; - qup_spi0_cs: qup-spi0-cs { + qup_spi0_cs: qup-spi0-cs-pins { pins = "gpio3"; function = "qup00"; }; - qup_spi0_cs_gpio: qup-spi0-cs-gpio { + qup_spi0_cs_gpio: qup-spi0-cs-gpio-pins { pins = "gpio3"; function = "gpio"; }; - qup_spi1_data_clk: qup-spi1-data-clk { + qup_spi1_data_clk: qup-spi1-data-clk-pins { pins = "gpio4", "gpio5", "gpio6"; function = "qup01"; }; - qup_spi1_cs: qup-spi1-cs { + qup_spi1_cs: qup-spi1-cs-pins { pins = "gpio7"; function = "qup01"; }; - qup_spi1_cs_gpio: qup-spi1-cs-gpio { + qup_spi1_cs_gpio: qup-spi1-cs-gpio-pins { pins = "gpio7"; function = "gpio"; }; - qup_spi2_data_clk: qup-spi2-data-clk { + qup_spi2_data_clk: qup-spi2-data-clk-pins { pins = "gpio8", "gpio9", "gpio10"; function = "qup02"; }; - qup_spi2_cs: qup-spi2-cs { + qup_spi2_cs: qup-spi2-cs-pins { pins = "gpio11"; function = "qup02"; }; - qup_spi2_cs_gpio: qup-spi2-cs-gpio { + qup_spi2_cs_gpio: qup-spi2-cs-gpio-pins { pins = "gpio11"; function = "gpio"; }; - qup_spi3_data_clk: qup-spi3-data-clk { + qup_spi3_data_clk: qup-spi3-data-clk-pins { pins = "gpio12", "gpio13", "gpio14"; function = "qup03"; }; - qup_spi3_cs: qup-spi3-cs { + qup_spi3_cs: qup-spi3-cs-pins { pins = "gpio15"; function = "qup03"; }; - qup_spi3_cs_gpio: qup-spi3-cs-gpio { + qup_spi3_cs_gpio: qup-spi3-cs-gpio-pins { pins = "gpio15"; function = "gpio"; }; - qup_spi4_data_clk: qup-spi4-data-clk { + qup_spi4_data_clk: qup-spi4-data-clk-pins { pins = "gpio16", "gpio17", "gpio18"; function = "qup04"; }; - qup_spi4_cs: qup-spi4-cs { + qup_spi4_cs: qup-spi4-cs-pins { pins = "gpio19"; function = "qup04"; }; - qup_spi4_cs_gpio: qup-spi4-cs-gpio { + qup_spi4_cs_gpio: qup-spi4-cs-gpio-pins { pins = "gpio19"; function = "gpio"; }; - qup_spi5_data_clk: qup-spi5-data-clk { + qup_spi5_data_clk: qup-spi5-data-clk-pins { pins = "gpio20", "gpio21", "gpio22"; function = "qup05"; }; - qup_spi5_cs: qup-spi5-cs { + qup_spi5_cs: qup-spi5-cs-pins { pins = "gpio23"; function = "qup05"; }; - qup_spi5_cs_gpio: qup-spi5-cs-gpio { + qup_spi5_cs_gpio: qup-spi5-cs-gpio-pins { pins = "gpio23"; function = "gpio"; }; - qup_spi6_data_clk: qup-spi6-data-clk { + qup_spi6_data_clk: qup-spi6-data-clk-pins { pins = "gpio24", "gpio25", "gpio26"; function = "qup06"; }; - qup_spi6_cs: qup-spi6-cs { + qup_spi6_cs: qup-spi6-cs-pins { pins = "gpio27"; function = "qup06"; }; - qup_spi6_cs_gpio: qup-spi6-cs-gpio { + qup_spi6_cs_gpio: qup-spi6-cs-gpio-pins { pins = "gpio27"; function = "gpio"; }; - qup_spi7_data_clk: qup-spi7-data-clk { + qup_spi7_data_clk: qup-spi7-data-clk-pins { pins = "gpio28", "gpio29", "gpio30"; function = "qup07"; }; - qup_spi7_cs: qup-spi7-cs { + qup_spi7_cs: qup-spi7-cs-pins { pins = "gpio31"; function = "qup07"; }; - qup_spi7_cs_gpio: qup-spi7-cs-gpio { + qup_spi7_cs_gpio: qup-spi7-cs-gpio-pins { pins = "gpio31"; function = "gpio"; }; - qup_spi8_data_clk: qup-spi8-data-clk { + qup_spi8_data_clk: qup-spi8-data-clk-pins { pins = "gpio32", "gpio33", "gpio34"; function = "qup10"; }; - qup_spi8_cs: qup-spi8-cs { + qup_spi8_cs: qup-spi8-cs-pins { pins = "gpio35"; function = "qup10"; }; - qup_spi8_cs_gpio: qup-spi8-cs-gpio { + qup_spi8_cs_gpio: qup-spi8-cs-gpio-pins { pins = "gpio35"; function = "gpio"; }; - qup_spi9_data_clk: qup-spi9-data-clk { + qup_spi9_data_clk: qup-spi9-data-clk-pins { pins = "gpio36", "gpio37", "gpio38"; function = "qup11"; }; - qup_spi9_cs: qup-spi9-cs { + qup_spi9_cs: qup-spi9-cs-pins { pins = "gpio39"; function = "qup11"; }; - qup_spi9_cs_gpio: qup-spi9-cs-gpio { + qup_spi9_cs_gpio: qup-spi9-cs-gpio-pins { pins = "gpio39"; function = "gpio"; }; - qup_spi10_data_clk: qup-spi10-data-clk { + qup_spi10_data_clk: qup-spi10-data-clk-pins { pins = "gpio40", "gpio41", "gpio42"; function = "qup12"; }; - qup_spi10_cs: qup-spi10-cs { + qup_spi10_cs: qup-spi10-cs-pins { pins = "gpio43"; function = "qup12"; }; - qup_spi10_cs_gpio: qup-spi10-cs-gpio { + qup_spi10_cs_gpio: qup-spi10-cs-gpio-pins { pins = "gpio43"; function = "gpio"; }; - qup_spi11_data_clk: qup-spi11-data-clk { + qup_spi11_data_clk: qup-spi11-data-clk-pins { pins = "gpio44", "gpio45", "gpio46"; function = "qup13"; }; - qup_spi11_cs: qup-spi11-cs { + qup_spi11_cs: qup-spi11-cs-pins { pins = "gpio47"; function = "qup13"; }; - qup_spi11_cs_gpio: qup-spi11-cs-gpio { + qup_spi11_cs_gpio: qup-spi11-cs-gpio-pins { pins = "gpio47"; function = "gpio"; }; - qup_spi12_data_clk: qup-spi12-data-clk { + qup_spi12_data_clk: qup-spi12-data-clk-pins { pins = "gpio48", "gpio49", "gpio50"; function = "qup14"; }; - qup_spi12_cs: qup-spi12-cs { + qup_spi12_cs: qup-spi12-cs-pins { pins = "gpio51"; function = "qup14"; }; - qup_spi12_cs_gpio: qup-spi12-cs-gpio { + qup_spi12_cs_gpio: qup-spi12-cs-gpio-pins { pins = "gpio51"; function = "gpio"; }; - qup_spi13_data_clk: qup-spi13-data-clk { + qup_spi13_data_clk: qup-spi13-data-clk-pins { pins = "gpio52", "gpio53", "gpio54"; function = "qup15"; }; - qup_spi13_cs: qup-spi13-cs { + qup_spi13_cs: qup-spi13-cs-pins { pins = "gpio55"; function = "qup15"; }; - qup_spi13_cs_gpio: qup-spi13-cs-gpio { + qup_spi13_cs_gpio: qup-spi13-cs-gpio-pins { pins = "gpio55"; function = "gpio"; }; - qup_spi14_data_clk: qup-spi14-data-clk { + qup_spi14_data_clk: qup-spi14-data-clk-pins { pins = "gpio56", "gpio57", "gpio58"; function = "qup16"; }; - qup_spi14_cs: qup-spi14-cs { + qup_spi14_cs: qup-spi14-cs-pins { pins = "gpio59"; function = "qup16"; }; - qup_spi14_cs_gpio: qup-spi14-cs-gpio { + qup_spi14_cs_gpio: qup-spi14-cs-gpio-pins { pins = "gpio59"; function = "gpio"; }; - qup_spi15_data_clk: qup-spi15-data-clk { + qup_spi15_data_clk: qup-spi15-data-clk-pins { pins = "gpio60", "gpio61", "gpio62"; function = "qup17"; }; - qup_spi15_cs: qup-spi15-cs { + qup_spi15_cs: qup-spi15-cs-pins { pins = "gpio63"; function = "qup17"; }; - qup_spi15_cs_gpio: qup-spi15-cs-gpio { + qup_spi15_cs_gpio: qup-spi15-cs-gpio-pins { pins = "gpio63"; function = "gpio"; }; - qup_uart0_cts: qup-uart0-cts { + qup_uart0_cts: qup-uart0-cts-pins { pins = "gpio0"; function = "qup00"; }; - qup_uart0_rts: qup-uart0-rts { + qup_uart0_rts: qup-uart0-rts-pins { pins = "gpio1"; function = "qup00"; }; - qup_uart0_tx: qup-uart0-tx { + qup_uart0_tx: qup-uart0-tx-pins { pins = "gpio2"; function = "qup00"; }; - qup_uart0_rx: qup-uart0-rx { + qup_uart0_rx: qup-uart0-rx-pins { pins = "gpio3"; function = "qup00"; }; - qup_uart1_cts: qup-uart1-cts { + qup_uart1_cts: qup-uart1-cts-pins { pins = "gpio4"; function = "qup01"; }; - qup_uart1_rts: qup-uart1-rts { + qup_uart1_rts: qup-uart1-rts-pins { pins = "gpio5"; function = "qup01"; }; - qup_uart1_tx: qup-uart1-tx { + qup_uart1_tx: qup-uart1-tx-pins { pins = "gpio6"; function = "qup01"; }; - qup_uart1_rx: qup-uart1-rx { + qup_uart1_rx: qup-uart1-rx-pins { pins = "gpio7"; function = "qup01"; }; - qup_uart2_cts: qup-uart2-cts { + qup_uart2_cts: qup-uart2-cts-pins { pins = "gpio8"; function = "qup02"; }; - qup_uart2_rts: qup-uart2-rts { + qup_uart2_rts: qup-uart2-rts-pins { pins = "gpio9"; function = "qup02"; }; - qup_uart2_tx: qup-uart2-tx { + qup_uart2_tx: qup-uart2-tx-pins { pins = "gpio10"; function = "qup02"; }; - qup_uart2_rx: qup-uart2-rx { + qup_uart2_rx: qup-uart2-rx-pins { pins = "gpio11"; function = "qup02"; }; - qup_uart3_cts: qup-uart3-cts { + qup_uart3_cts: qup-uart3-cts-pins { pins = "gpio12"; function = "qup03"; }; - qup_uart3_rts: qup-uart3-rts { + qup_uart3_rts: qup-uart3-rts-pins { pins = "gpio13"; function = "qup03"; }; - qup_uart3_tx: qup-uart3-tx { + qup_uart3_tx: qup-uart3-tx-pins { pins = "gpio14"; function = "qup03"; }; - qup_uart3_rx: qup-uart3-rx { + qup_uart3_rx: qup-uart3-rx-pins { pins = "gpio15"; function = "qup03"; }; - qup_uart4_cts: qup-uart4-cts { + qup_uart4_cts: qup-uart4-cts-pins { pins = "gpio16"; function = "qup04"; }; - qup_uart4_rts: qup-uart4-rts { + qup_uart4_rts: qup-uart4-rts-pins { pins = "gpio17"; function = "qup04"; }; - qup_uart4_tx: qup-uart4-tx { + qup_uart4_tx: qup-uart4-tx-pins { pins = "gpio18"; function = "qup04"; }; - qup_uart4_rx: qup-uart4-rx { + qup_uart4_rx: qup-uart4-rx-pins { pins = "gpio19"; function = "qup04"; }; - qup_uart5_cts: qup-uart5-cts { + qup_uart5_cts: qup-uart5-cts-pins { pins = "gpio20"; function = "qup05"; }; - qup_uart5_rts: qup-uart5-rts { + qup_uart5_rts: qup-uart5-rts-pins { pins = "gpio21"; function = "qup05"; }; - qup_uart5_tx: qup-uart5-tx { + qup_uart5_tx: qup-uart5-tx-pins { pins = "gpio22"; function = "qup05"; }; - qup_uart5_rx: qup-uart5-rx { + qup_uart5_rx: qup-uart5-rx-pins { pins = "gpio23"; function = "qup05"; }; - qup_uart6_cts: qup-uart6-cts { + qup_uart6_cts: qup-uart6-cts-pins { pins = "gpio24"; function = "qup06"; }; - qup_uart6_rts: qup-uart6-rts { + qup_uart6_rts: qup-uart6-rts-pins { pins = "gpio25"; function = "qup06"; }; - qup_uart6_tx: qup-uart6-tx { + qup_uart6_tx: qup-uart6-tx-pins { pins = "gpio26"; function = "qup06"; }; - qup_uart6_rx: qup-uart6-rx { + qup_uart6_rx: qup-uart6-rx-pins { pins = "gpio27"; function = "qup06"; }; - qup_uart7_cts: qup-uart7-cts { + qup_uart7_cts: qup-uart7-cts-pins { pins = "gpio28"; function = "qup07"; }; - qup_uart7_rts: qup-uart7-rts { + qup_uart7_rts: qup-uart7-rts-pins { pins = "gpio29"; function = "qup07"; }; - qup_uart7_tx: qup-uart7-tx { + qup_uart7_tx: qup-uart7-tx-pins { pins = "gpio30"; function = "qup07"; }; - qup_uart7_rx: qup-uart7-rx { + qup_uart7_rx: qup-uart7-rx-pins { pins = "gpio31"; function = "qup07"; }; - qup_uart8_cts: qup-uart8-cts { + qup_uart8_cts: qup-uart8-cts-pins { pins = "gpio32"; function = "qup10"; }; - qup_uart8_rts: qup-uart8-rts { + qup_uart8_rts: qup-uart8-rts-pins { pins = "gpio33"; function = "qup10"; }; - qup_uart8_tx: qup-uart8-tx { + qup_uart8_tx: qup-uart8-tx-pins { pins = "gpio34"; function = "qup10"; }; - qup_uart8_rx: qup-uart8-rx { + qup_uart8_rx: qup-uart8-rx-pins { pins = "gpio35"; function = "qup10"; }; - qup_uart9_cts: qup-uart9-cts { + qup_uart9_cts: qup-uart9-cts-pins { pins = "gpio36"; function = "qup11"; }; - qup_uart9_rts: qup-uart9-rts { + qup_uart9_rts: qup-uart9-rts-pins { pins = "gpio37"; function = "qup11"; }; - qup_uart9_tx: qup-uart9-tx { + qup_uart9_tx: qup-uart9-tx-pins { pins = "gpio38"; function = "qup11"; }; - qup_uart9_rx: qup-uart9-rx { + qup_uart9_rx: qup-uart9-rx-pins { pins = "gpio39"; function = "qup11"; }; - qup_uart10_cts: qup-uart10-cts { + qup_uart10_cts: qup-uart10-cts-pins { pins = "gpio40"; function = "qup12"; }; - qup_uart10_rts: qup-uart10-rts { + qup_uart10_rts: qup-uart10-rts-pins { pins = "gpio41"; function = "qup12"; }; - qup_uart10_tx: qup-uart10-tx { + qup_uart10_tx: qup-uart10-tx-pins { pins = "gpio42"; function = "qup12"; }; - qup_uart10_rx: qup-uart10-rx { + qup_uart10_rx: qup-uart10-rx-pins { pins = "gpio43"; function = "qup12"; }; - qup_uart11_cts: qup-uart11-cts { + qup_uart11_cts: qup-uart11-cts-pins { pins = "gpio44"; function = "qup13"; }; - qup_uart11_rts: qup-uart11-rts { + qup_uart11_rts: qup-uart11-rts-pins { pins = "gpio45"; function = "qup13"; }; - qup_uart11_tx: qup-uart11-tx { + qup_uart11_tx: qup-uart11-tx-pins { pins = "gpio46"; function = "qup13"; }; - qup_uart11_rx: qup-uart11-rx { + qup_uart11_rx: qup-uart11-rx-pins { pins = "gpio47"; function = "qup13"; }; - qup_uart12_cts: qup-uart12-cts { + qup_uart12_cts: qup-uart12-cts-pins { pins = "gpio48"; function = "qup14"; }; - qup_uart12_rts: qup-uart12-rts { + qup_uart12_rts: qup-uart12-rts-pins { pins = "gpio49"; function = "qup14"; }; - qup_uart12_tx: qup-uart12-tx { + qup_uart12_tx: qup-uart12-tx-pins { pins = "gpio50"; function = "qup14"; }; - qup_uart12_rx: qup-uart12-rx { + qup_uart12_rx: qup-uart12-rx-pins { pins = "gpio51"; function = "qup14"; }; - qup_uart13_cts: qup-uart13-cts { + qup_uart13_cts: qup-uart13-cts-pins { pins = "gpio52"; function = "qup15"; }; - qup_uart13_rts: qup-uart13-rts { + qup_uart13_rts: qup-uart13-rts-pins { pins = "gpio53"; function = "qup15"; }; - qup_uart13_tx: qup-uart13-tx { + qup_uart13_tx: qup-uart13-tx-pins { pins = "gpio54"; function = "qup15"; }; - qup_uart13_rx: qup-uart13-rx { + qup_uart13_rx: qup-uart13-rx-pins { pins = "gpio55"; function = "qup15"; }; - qup_uart14_cts: qup-uart14-cts { + qup_uart14_cts: qup-uart14-cts-pins { pins = "gpio56"; function = "qup16"; }; - qup_uart14_rts: qup-uart14-rts { + qup_uart14_rts: qup-uart14-rts-pins { pins = "gpio57"; function = "qup16"; }; - qup_uart14_tx: qup-uart14-tx { + qup_uart14_tx: qup-uart14-tx-pins { pins = "gpio58"; function = "qup16"; }; - qup_uart14_rx: qup-uart14-rx { + qup_uart14_rx: qup-uart14-rx-pins { pins = "gpio59"; function = "qup16"; }; - qup_uart15_cts: qup-uart15-cts { + qup_uart15_cts: qup-uart15-cts-pins { pins = "gpio60"; function = "qup17"; }; - qup_uart15_rts: qup-uart15-rts { + qup_uart15_rts: qup-uart15-rts-pins { pins = "gpio61"; function = "qup17"; }; - qup_uart15_tx: qup-uart15-tx { + qup_uart15_tx: qup-uart15-tx-pins { pins = "gpio62"; function = "qup17"; }; - qup_uart15_rx: qup-uart15-rx { + qup_uart15_rx: qup-uart15-rx-pins { pins = "gpio63"; function = "qup17"; }; - sdc1_clk: sdc1-clk { + sdc1_clk: sdc1-clk-pins { pins = "sdc1_clk"; }; - sdc1_cmd: sdc1-cmd { + sdc1_cmd: sdc1-cmd-pins { pins = "sdc1_cmd"; }; - sdc1_data: sdc1-data { + sdc1_data: sdc1-data-pins { pins = "sdc1_data"; }; - sdc1_rclk: sdc1-rclk { + sdc1_rclk: sdc1-rclk-pins { pins = "sdc1_rclk"; }; - sdc1_clk_sleep: sdc1-clk-sleep { + sdc1_clk_sleep: sdc1-clk-sleep-pins { pins = "sdc1_clk"; drive-strength = <2>; bias-bus-hold; }; - sdc1_cmd_sleep: sdc1-cmd-sleep { + sdc1_cmd_sleep: sdc1-cmd-sleep-pins { pins = "sdc1_cmd"; drive-strength = <2>; bias-bus-hold; }; - sdc1_data_sleep: sdc1-data-sleep { + sdc1_data_sleep: sdc1-data-sleep-pins { pins = "sdc1_data"; drive-strength = <2>; bias-bus-hold; }; - sdc1_rclk_sleep: sdc1-rclk-sleep { + sdc1_rclk_sleep: sdc1-rclk-sleep-pins { pins = "sdc1_rclk"; drive-strength = <2>; bias-bus-hold; }; - sdc2_clk: sdc2-clk { + sdc2_clk: sdc2-clk-pins { pins = "sdc2_clk"; }; - sdc2_cmd: sdc2-cmd { + sdc2_cmd: sdc2-cmd-pins { pins = "sdc2_cmd"; }; - sdc2_data: sdc2-data { + sdc2_data: sdc2-data-pins { pins = "sdc2_data"; }; - sdc2_clk_sleep: sdc2-clk-sleep { + sdc2_clk_sleep: sdc2-clk-sleep-pins { pins = "sdc2_clk"; drive-strength = <2>; bias-bus-hold; }; - sdc2_cmd_sleep: sdc2-cmd-sleep { + sdc2_cmd_sleep: sdc2-cmd-sleep-pins { pins = "sdc2_cmd"; drive-strength = <2>; bias-bus-hold; }; - sdc2_data_sleep: sdc2-data-sleep { + sdc2_data_sleep: sdc2-data-sleep-pins { pins = "sdc2_data"; drive-strength = <2>; bias-bus-hold; From patchwork Mon Sep 12 06:17:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605136 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7539C6FA8B for ; Mon, 12 Sep 2022 06:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbiILGVJ (ORCPT ); Mon, 12 Sep 2022 02:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbiILGUP (ORCPT ); Mon, 12 Sep 2022 02:20:15 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44EDC2A245 for ; Sun, 11 Sep 2022 23:18:50 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id q21so13240392lfo.0 for ; Sun, 11 Sep 2022 23:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=VVRMe5K9zQktuETEV7D34ZSBEU0mHzUqiBeP7TQimRg=; b=E9zZ3Djr07TS3fJj6umSRVrlBqZsmRosVs7UWiwoZ84qNN/a0cVp/MbBsxbDvNCRK4 C5PzUhuDTHzNoejdenm32fJ2OweRU0Ba1IodWlj6HzopWoL+AJtWDhtPW8BCMPIiBu+c l2YkgWv05vztqViwf+jj/DW/l0cVvqcEV3OEmjMYARPhi/aX+/uTK3bTtrxBJngTXC4z HlFxq0wupVH7fGCSL3l+sS8gAkYtfIEbVZpzdORYN/obVqWkMqM44XUykiTw1/g9wYw7 VuVfp5t4SncEfaeUCbiZ0KkYaI/Kn/dEDiajc7EHNyX0bGlUKKNH/42dhQApHtcct4jL sSXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=VVRMe5K9zQktuETEV7D34ZSBEU0mHzUqiBeP7TQimRg=; b=zdVZ0zsogj1dRVEZxY/l9I2l5jXYWvznPhLHLmmT3F+DOTVEdDndhxFc8eL+PTxbMJ hrJ5iNBH9m3zgUh6Czll7c9S7rE8pj2Mn+aI/PVT50ZH4DmcVa+JKYG3DpFX0BHJDd3w 2jNtc+5cwfsyl0DLYpRJT7uja1NTeI4PiusKZcEmHWfnBEL8YrPUxn5hf7mi7dq2+lzo x7xcM/kxFEyIcl8tYJ+fukjfgwuTz8st1inFMH/FqhwlagPYACKrID4yP2OvUT21zsi1 foNuxUl+iKryvs7f10UHZBM53Gvkm6SqeO5wuSXn9nyB8QXr6E2XCIeTo8z+p1R7vmmi X0wQ== X-Gm-Message-State: ACgBeo3sB087dP81zlUQOpCKaHl7tnBrQcFxhbgntBTJKLHjrBkA8Rim CyfaaDSD9UMgyGaupuI7a0l4PA== X-Google-Smtp-Source: AA6agR5Ef8VuKaloSkqcwAVTmW4EDULh+UlSiGV/k2vvbAxBjr8D2hI70ANVmlLY8cttjljJtvwDYw== X-Received: by 2002:ac2:5a46:0:b0:498:f53b:d19a with SMTP id r6-20020ac25a46000000b00498f53bd19amr5922678lfn.674.1662963529575; Sun, 11 Sep 2022 23:18:49 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:49 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 40/40] arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names Date: Mon, 12 Sep 2022 08:17:46 +0200 Message-Id: <20220912061746.6311-41-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There are 174 GPIOs in SC7280. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts index bc795c480352..3448e9ed8b03 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts @@ -371,7 +371,5 @@ &tlmm { "", /* 170 */ "MOS_BLE_UART_TX", "MOS_BLE_UART_RX", - "", - "", ""; };