From patchwork Thu Sep 8 08:10:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 604017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E88ECAAD5 for ; Thu, 8 Sep 2022 08:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231432AbiIHILu (ORCPT ); Thu, 8 Sep 2022 04:11:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231390AbiIHIL3 (ORCPT ); Thu, 8 Sep 2022 04:11:29 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADE2689918 for ; Thu, 8 Sep 2022 01:10:56 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id u18so14139624lfo.8 for ; Thu, 08 Sep 2022 01:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=2nFGr7k9DwUv67DCXwyHIh7iOrFysefykil+1Bjeu4Q=; b=QI00Ut4LNoGRP2si81Gt7ZrmZ0y3PMzWlkBGW8eLfinFPRGYcqg93wIXUuHqAyHcYF WgHxr4f3ynQQgbwnUhJ0L881yWxacwW/maGqhtsrDzwjt+uWyIPUVbAT+4tmMjnL7s4u zrk1gNoxF/MgA76ey8VbqWp9cIpd/i43/9Jsuf0TFzzCIX7ip8mTResbLDghCBciG1+s sI+2CoiI9vw66Cz52Ip49R3X/3MffkonjSx1lYBXVAHlsD+wrrXT1KiNuwpLH0Kw8k2V 3GX1+swaIt8wPfhEMiF6HJxVAzSciqLAWDSg247gLjvGWGduLYOVHKg09BQoS4+rws4n uM/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=2nFGr7k9DwUv67DCXwyHIh7iOrFysefykil+1Bjeu4Q=; b=rhvm4tpP44sEqP+G7lNwpD0l2VwaVHp3ynGrkQLmmNEe5TrhX8J7gibcS/Q1Eh0GMK GrY/iPJU9FpArkf8r+UU4jIm7MUIhf6Ygg9hc4dnZjRC4idYJCyLg7sP01tAXmMnDSlJ /AjzzG1adFrDDkjXCvMSMJJXAPdMs24vufLvseFlbJ6LCyqqSKYlyTMdcTgiA8OXnN60 y8em4i3/ylF1Dm4b9WwmR5ugz0tx1f+LxwN0/qHDPF32xxxspzOBuwkSzkxyJKbpmYyU +obmGg061zHTjsJjo6Df1K7F7PtefjAWj8dDpFhbbjhUQep2aygXnWE5SoJ7P92vxU3B nz9Q== X-Gm-Message-State: ACgBeo1DGtuJRoWRvWulhVKQVa+bfL7AArNH+/1dziRnFHhBTvBGQzGf x7RuDqY3oIjeobbj8Qewdlt/vQ== X-Google-Smtp-Source: AA6agR68K7dmUGNxIEWv3RFYEt5/3kxurlRNx9y2sEnt8wkQMSUuZy+PKbQsP/XYLWMKO/P8N24nnQ== X-Received: by 2002:a05:6512:b1c:b0:492:8835:1e4c with SMTP id w28-20020a0565120b1c00b0049288351e4cmr2169794lfu.442.1662624654049; Thu, 08 Sep 2022 01:10:54 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u18-20020a05651c131200b00261e7e7b698sm3075777lja.123.2022.09.08.01.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:10:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/5] arm64: dts: qcom: pmi8994: add missing MPP compatible fallback Date: Thu, 8 Sep 2022 10:10:46 +0200 Message-Id: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Bindings require usage of generic MPP fallback in compatible: qcom/apq8094-sony-xperia-kitakami-karin_windy.dtb: pmic@2: mpps@a000:compatible: ['qcom,pmi8994-mpp'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi index 92a139ca4482..a0af91698d49 100644 --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi @@ -21,7 +21,7 @@ pmi8994_gpios: gpio@c000 { }; pmi8994_mpps: mpps@a000 { - compatible = "qcom,pmi8994-mpp"; + compatible = "qcom,pmi8994-mpp", "qcom,spmi-mpp"; reg = <0xa000>; gpio-controller; gpio-ranges = <&pmi8994_mpps 0 0 4>; From patchwork Thu Sep 8 08:10:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 604016 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BDBECAAD5 for ; Thu, 8 Sep 2022 08:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231477AbiIHIL4 (ORCPT ); Thu, 8 Sep 2022 04:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231480AbiIHILd (ORCPT ); Thu, 8 Sep 2022 04:11:33 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 272E382FAF for ; Thu, 8 Sep 2022 01:10:58 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id bt10so26455148lfb.1 for ; Thu, 08 Sep 2022 01:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=iPVQmciwDU5l9xQEUoTRli5ZxjsltpZ7/BU9vnSvS1U=; b=PCEA+EbJxcxLWvroaJMvPvIoys/PDUNxLIe7Bbcy9HWEVKarFIx8eMGgHMyf5x8Tk4 OEySCgUmZhwkPSq6aH2vjn4E+uTnN2wBh4MVfsUBklO0KanykgOtNlu1SaWV5vVpephs w6SSs7mDeR38LgJ4ZsrHVYzLENinYM93QJVGfy+UfAoZracyrOx6GxsCcNGBfY+qABFc pTyPi4+8eK3b0r6ZiLQduod/p2YwSYokCQBMNCZW7f9LueLZb3IYqmciVHmbFeE2xsni VOTviTerOREhyF6nXC2SyCMrqObDsTIaqDOovrebuLjPGu7s8x8D8UdM4bs6ll4xIKMK d17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=iPVQmciwDU5l9xQEUoTRli5ZxjsltpZ7/BU9vnSvS1U=; b=63wnu4L1II6P52YfaNsGilCky0lAoNkTv7al0WR28GQoeIAi6Jd8z2soDD5P+aLWCB zhmcMep+1W5u4DrqZltapucgeelzUBKgX9Zn4tXiNC1Cca3pKvTmqAy2S1s0WYCKTchl uqQwNQMvqOm+4cz6LFtQ7a9CKYpa5OdzM+zUU9vL8kLkruNTXr4aCvGof55YI0inZdt2 VyHWAOAjlo9DOGLjOJPnwkdPnwiNxK0GNHQmzUM/ouj94I3hNwcJ7DrQEImwo517CJrV SzD440nSm0F2YN0m1NP5t33tukI47J9YNuy8VirDUzk6xI8TROb2gYAo1oF86Sif2zdA TDFQ== X-Gm-Message-State: ACgBeo0XDlXTVL9RXt1PT/+YHgBIpnQhR2YI4Iy7mKRAMT5tCkgiCsZ2 uRJxDm9uulap4ezSMDev4VKAjw== X-Google-Smtp-Source: AA6agR5jiMpcpc9CfMHmCEuL44Mr/DiSeIbg/2pT3W+l/xVVA+SqJYueNhHr0/zl9WxGlgN00iOzQA== X-Received: by 2002:a05:6512:e98:b0:492:cf3c:8860 with SMTP id bi24-20020a0565120e9800b00492cf3c8860mr2280479lfb.603.1662624656211; Thu, 08 Sep 2022 01:10:56 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u18-20020a05651c131200b00261e7e7b698sm3075777lja.123.2022.09.08.01.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:10:55 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/5] arm64: dts: qcom: msm8996-xiaomi: align PMIC GPIO pin configuration with DT schema Date: Thu, 8 Sep 2022 10:10:48 +0200 Message-Id: <20220908081050.29751-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> References: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Bindings expect PMIC GPIO pin configuration nodes to be named with '-state' suffix: qcom/msm8996-xiaomi-scorpio.dtb: pmic@0: gpio@c000: 'irled-default', 'keypad-default' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+' Drop also additional indentation via "pinconf" to make the code a bit smaller. Signed-off-by: Krzysztof Kozlowski --- .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 16 +++++++--------- .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts | 16 +++++++--------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi index 6d6e0fb4d270..78a1977d0593 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi @@ -651,15 +651,13 @@ vdd_gfx: s2 { }; &pm8994_gpios { - irled_default: irled-default { - pinconf { - pins = "gpio5"; - function = PMIC_GPIO_FUNC_FUNC1; - output-low; - qcom,drive-strength = ; - power-source = ; - bias-disable; - }; + irled_default: irled-default-state { + pins = "gpio5"; + function = PMIC_GPIO_FUNC_FUNC1; + output-low; + qcom,drive-strength = ; + power-source = ; + bias-disable; }; wlan_en_default: wlan-en-state { diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts index d287fa77e45a..895050831267 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts @@ -278,15 +278,13 @@ &pm8994_gpios { "UIM_BATT_ALARM", /* GPIO_21 */ "NC"; /* GPIO_22 */ - keypad_default: keypad-default { - pinconf { - pins = "gpio7", "gpio10"; - function = PMIC_GPIO_FUNC_FUNC1; - output-low; - qcom,drive-strength = ; - power-source = ; - bias-disable; - }; + keypad_default: keypad-default-state { + pins = "gpio7", "gpio10"; + function = PMIC_GPIO_FUNC_FUNC1; + output-low; + qcom,drive-strength = ; + power-source = ; + bias-disable; }; }; From patchwork Thu Sep 8 08:10:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 604015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD94ECAAD5 for ; Thu, 8 Sep 2022 08:12:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231409AbiIHIMO (ORCPT ); Thu, 8 Sep 2022 04:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231486AbiIHILg (ORCPT ); Thu, 8 Sep 2022 04:11:36 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62BF290C49 for ; Thu, 8 Sep 2022 01:10:59 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id l12so10510276ljg.9 for ; Thu, 08 Sep 2022 01:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=YZLACUPz0dSdErasL/kyxzUvd85vQCbH1Jqb2nBEYMw=; b=RPEZmW8fjs5QH9W9/Im5vpfIX69sElWEIZ8UcoT4JJ9ciA6OXjt4P+rejpW6v/tvkI JyglMAOD/o4vQO0qNs5hjFKZ8ECL15kZ9fX45doquozLNPv9zUGkazWxYQAlIvTGTAew bICET3/j5hO3ie3LrXWry7Ux4T2jxTwcs8QZemBT14xVyOq/wE4IkE6W4jZYAemuzlY/ VcBhXo6tvvq0nJBgVShKG0qk+9OEU38cL4kepUnCEvlUC3+i/X8MdiuL0y278z4+TcQN unNrgvoDffQx+IK/qtxLLNUe0c9sT+a3Tdk+lWy++j7Iq1/GNGi6GjOAgu1YZXX5PyM2 f0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=YZLACUPz0dSdErasL/kyxzUvd85vQCbH1Jqb2nBEYMw=; b=qE1463z1JeEzRcID7yxUQhh4e48gg/FciSN6yjmm3EZaiijfMYXul/mhAM3IA5Q27G 3D/kt2Tx4bTexV3bzZ2YB+JQ9ofwL7pXdUCgR9JRsi2nBGugakyMpjTKy3jqT1+svXr8 oMv5AnvSr4HWEM4tUQZ+G9qQjoxFXNEZoSABQpwRTLGc/d+5HxpK9Q1CZNlJIt5julO+ Fzy6fbzsg/YNz/AkZyeqrNJ0Gr4xi0wNJD99ceL5b4pu2X5wCsQqt5J/ESYCBAcgs+Yq lEKSDUSo+9GbuHcRQPg64sxni+znZ44DtI0KFMdv6odKxvvkMO9V5H6/uwh6rok9m47a oTow== X-Gm-Message-State: ACgBeo2Wi0FCrsx1k3fBu8T/1w64qysbMuOaWtDK9meOUAS7lgoSlkXT slOHaQxGIPOsIgGKNDgVrrY4Ig== X-Google-Smtp-Source: AA6agR6502NqVm0e5msexurrPH9GuLxDnMMfTqJyqU3vmCg/75xiDzqlJsh/Gma7W5WZZaa+zuDgwA== X-Received: by 2002:a05:651c:1783:b0:261:83f5:4b4c with SMTP id bn3-20020a05651c178300b0026183f54b4cmr2069278ljb.422.1662624657287; Thu, 08 Sep 2022 01:10:57 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u18-20020a05651c131200b00261e7e7b698sm3075777lja.123.2022.09.08.01.10.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:10:56 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 4/5] arm64: dts: qcom: sa8295p-adp: add fallback compatible to PMIC GPIOs Date: Thu, 8 Sep 2022 10:10:49 +0200 Message-Id: <20220908081050.29751-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> References: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Bindings require all PMIC GPIO nodes to have two compatibles - specific followed by SPMI or SSBI fallback: qcom/sa8295p-adp.dtb: pmic@8: gpio@c000:compatible: ['qcom,pm8150-gpio'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts index ca5f5ad32ce5..98f8420488b6 100644 --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts @@ -183,7 +183,7 @@ pm8450a: pmic@0 { #size-cells = <0>; pm8450a_gpios: gpio@c000 { - compatible = "qcom,pm8150-gpio"; + compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; #gpio-cells = <2>; @@ -199,7 +199,7 @@ pm8450c: pmic@4 { #size-cells = <0>; pm8450c_gpios: gpio@c000 { - compatible = "qcom,pm8150-gpio"; + compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; #gpio-cells = <2>; @@ -215,7 +215,7 @@ pm8450e: pmic@8 { #size-cells = <0>; pm8450e_gpios: gpio@c000 { - compatible = "qcom,pm8150-gpio"; + compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; #gpio-cells = <2>; @@ -231,7 +231,7 @@ pm8450g: pmic@c { #size-cells = <0>; pm8450g_gpios: gpio@c000 { - compatible = "qcom,pm8150-gpio"; + compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; #gpio-cells = <2>;