From patchwork Thu Sep 8 08:10:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 603921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB56C38145 for ; Thu, 8 Sep 2022 08:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231519AbiIHILv (ORCPT ); Thu, 8 Sep 2022 04:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231459AbiIHILa (ORCPT ); Thu, 8 Sep 2022 04:11:30 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25683D99DF for ; Thu, 8 Sep 2022 01:10:56 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id bt10so26455009lfb.1 for ; Thu, 08 Sep 2022 01:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=2nFGr7k9DwUv67DCXwyHIh7iOrFysefykil+1Bjeu4Q=; b=QI00Ut4LNoGRP2si81Gt7ZrmZ0y3PMzWlkBGW8eLfinFPRGYcqg93wIXUuHqAyHcYF WgHxr4f3ynQQgbwnUhJ0L881yWxacwW/maGqhtsrDzwjt+uWyIPUVbAT+4tmMjnL7s4u zrk1gNoxF/MgA76ey8VbqWp9cIpd/i43/9Jsuf0TFzzCIX7ip8mTResbLDghCBciG1+s sI+2CoiI9vw66Cz52Ip49R3X/3MffkonjSx1lYBXVAHlsD+wrrXT1KiNuwpLH0Kw8k2V 3GX1+swaIt8wPfhEMiF6HJxVAzSciqLAWDSg247gLjvGWGduLYOVHKg09BQoS4+rws4n uM/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=2nFGr7k9DwUv67DCXwyHIh7iOrFysefykil+1Bjeu4Q=; b=y6G3Uro9BdOo0pqHgKkbA6tz7kURyx7wTrLEI9dmmbq5L75hpo8Pk0wh1xKwOZbBtU b4jOH+fsDlRSq0JLgSZ59LzQgxl++9j/mV+x54f1s7JYM3u1aNgsZVcCFMCsxfxk2yaF IddFWxNQ5kE9w66goQBqtIZv0Htq6yBsKHDINQGHjcdcSa/am+rI86I6SXhGsrvQJemr 59w+ft6z+49sf87j4DmeBZhIxlZ1KYyIjg+oYfX4lLTb38zGYmYemuMli3ZUo4hz1kOK lGFmtAHKMsDFG75y5IZCsT9aX7LzsiqN75j02an+g/voj4EvSl++vD7/kv94AGT9H7G6 TtvQ== X-Gm-Message-State: ACgBeo2m12VrmfeqKy2V+EM6uTRl0YF0faMB+qs/AWSLOLhx80QTCMYA ukLFNrk52fmPYMgZQh7MW63XRg== X-Google-Smtp-Source: AA6agR68K7dmUGNxIEWv3RFYEt5/3kxurlRNx9y2sEnt8wkQMSUuZy+PKbQsP/XYLWMKO/P8N24nnQ== X-Received: by 2002:a05:6512:b1c:b0:492:8835:1e4c with SMTP id w28-20020a0565120b1c00b0049288351e4cmr2169794lfu.442.1662624654049; Thu, 08 Sep 2022 01:10:54 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u18-20020a05651c131200b00261e7e7b698sm3075777lja.123.2022.09.08.01.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:10:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/5] arm64: dts: qcom: pmi8994: add missing MPP compatible fallback Date: Thu, 8 Sep 2022 10:10:46 +0200 Message-Id: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Bindings require usage of generic MPP fallback in compatible: qcom/apq8094-sony-xperia-kitakami-karin_windy.dtb: pmic@2: mpps@a000:compatible: ['qcom,pmi8994-mpp'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi index 92a139ca4482..a0af91698d49 100644 --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi @@ -21,7 +21,7 @@ pmi8994_gpios: gpio@c000 { }; pmi8994_mpps: mpps@a000 { - compatible = "qcom,pmi8994-mpp"; + compatible = "qcom,pmi8994-mpp", "qcom,spmi-mpp"; reg = <0xa000>; gpio-controller; gpio-ranges = <&pmi8994_mpps 0 0 4>; From patchwork Thu Sep 8 08:10:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 603920 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EEAC38145 for ; Thu, 8 Sep 2022 08:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbiIHILx (ORCPT ); Thu, 8 Sep 2022 04:11:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbiIHILb (ORCPT ); Thu, 8 Sep 2022 04:11:31 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370445245B for ; Thu, 8 Sep 2022 01:10:58 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id bt10so26455147lfb.1 for ; Thu, 08 Sep 2022 01:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=iPVQmciwDU5l9xQEUoTRli5ZxjsltpZ7/BU9vnSvS1U=; b=PCEA+EbJxcxLWvroaJMvPvIoys/PDUNxLIe7Bbcy9HWEVKarFIx8eMGgHMyf5x8Tk4 OEySCgUmZhwkPSq6aH2vjn4E+uTnN2wBh4MVfsUBklO0KanykgOtNlu1SaWV5vVpephs w6SSs7mDeR38LgJ4ZsrHVYzLENinYM93QJVGfy+UfAoZracyrOx6GxsCcNGBfY+qABFc pTyPi4+8eK3b0r6ZiLQduod/p2YwSYokCQBMNCZW7f9LueLZb3IYqmciVHmbFeE2xsni VOTviTerOREhyF6nXC2SyCMrqObDsTIaqDOovrebuLjPGu7s8x8D8UdM4bs6ll4xIKMK d17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=iPVQmciwDU5l9xQEUoTRli5ZxjsltpZ7/BU9vnSvS1U=; b=wwt8FKUZHwrIWmOvcr/JInOH55FbjbEyk8UCb2Kz8/A9ZETySW8oEfMHQQCN0v8YRi hLJ4wL6zulZw29+XvvPLKxoDidSm4Uobk6HUwFISkP/Agq9tZaFYXiEqaxQyYmlXFed0 btST8JGpDFfI7MWq8VBQ78BQohstmEr4CTnDgOsSQLTmt8/9k/SuuvxnpT5CV+UHAVzR 6wzCdgY1JIG3TSetIViZmk8HLNVXS8v1H+v0a+4YOO+yJxgFcCgYUAoi3Q+IJb40C6wh jDG6xlfnNneUXgAuDCm/atgWtiZSrDs/fswETTfL6xP8+IJ8AZnycnqOufQliYOmmqpH KFmA== X-Gm-Message-State: ACgBeo03YafSjaANxMvtdp/IL6qE7mhTMcTpC+OgQjhJ8g2IDqWZmpZI Dfz+j1bpjCfdQzwfpFjsFD1YQQ== X-Google-Smtp-Source: AA6agR5jiMpcpc9CfMHmCEuL44Mr/DiSeIbg/2pT3W+l/xVVA+SqJYueNhHr0/zl9WxGlgN00iOzQA== X-Received: by 2002:a05:6512:e98:b0:492:cf3c:8860 with SMTP id bi24-20020a0565120e9800b00492cf3c8860mr2280479lfb.603.1662624656211; Thu, 08 Sep 2022 01:10:56 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u18-20020a05651c131200b00261e7e7b698sm3075777lja.123.2022.09.08.01.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:10:55 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/5] arm64: dts: qcom: msm8996-xiaomi: align PMIC GPIO pin configuration with DT schema Date: Thu, 8 Sep 2022 10:10:48 +0200 Message-Id: <20220908081050.29751-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> References: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Bindings expect PMIC GPIO pin configuration nodes to be named with '-state' suffix: qcom/msm8996-xiaomi-scorpio.dtb: pmic@0: gpio@c000: 'irled-default', 'keypad-default' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+' Drop also additional indentation via "pinconf" to make the code a bit smaller. Signed-off-by: Krzysztof Kozlowski --- .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 16 +++++++--------- .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts | 16 +++++++--------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi index 6d6e0fb4d270..78a1977d0593 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi @@ -651,15 +651,13 @@ vdd_gfx: s2 { }; &pm8994_gpios { - irled_default: irled-default { - pinconf { - pins = "gpio5"; - function = PMIC_GPIO_FUNC_FUNC1; - output-low; - qcom,drive-strength = ; - power-source = ; - bias-disable; - }; + irled_default: irled-default-state { + pins = "gpio5"; + function = PMIC_GPIO_FUNC_FUNC1; + output-low; + qcom,drive-strength = ; + power-source = ; + bias-disable; }; wlan_en_default: wlan-en-state { diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts index d287fa77e45a..895050831267 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts @@ -278,15 +278,13 @@ &pm8994_gpios { "UIM_BATT_ALARM", /* GPIO_21 */ "NC"; /* GPIO_22 */ - keypad_default: keypad-default { - pinconf { - pins = "gpio7", "gpio10"; - function = PMIC_GPIO_FUNC_FUNC1; - output-low; - qcom,drive-strength = ; - power-source = ; - bias-disable; - }; + keypad_default: keypad-default-state { + pins = "gpio7", "gpio10"; + function = PMIC_GPIO_FUNC_FUNC1; + output-low; + qcom,drive-strength = ; + power-source = ; + bias-disable; }; }; From patchwork Thu Sep 8 08:10:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 603919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE92DECAAD5 for ; Thu, 8 Sep 2022 08:12:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231544AbiIHIMN (ORCPT ); Thu, 8 Sep 2022 04:12:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231510AbiIHILf (ORCPT ); Thu, 8 Sep 2022 04:11:35 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C1A1923D4 for ; Thu, 8 Sep 2022 01:11:00 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id p7so26441820lfu.3 for ; Thu, 08 Sep 2022 01:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=WbrJFxDN9M+roX+wTBZIP2zZRkjGZwlxDva2DwfHcBI=; b=hstIHa10wYZKdgbw+bwt6JUfeyCTmPPR9hwh1lj7fJs4QOwKFX460qW1FomRilmzci bXy+QToiGA6WTLaGBDzzdVe+MRM+lF9NtM/fee65hKXEa6/5ZoLYLfWgBwzrkr147tBy W7CZe8MoZZx7ADo4ITLXY+CglVlrkPobX/k2re21D8DxwdZW/T9yVnt0zHy4XHurQ7aI KopgJy/c9I0SGxL5lhglFIFi8vhQem5048iLPvz9GUhSYj7uInFPPm44LiEEbYoN8Dkm ZBOPdCpWR5vl1+fZWHMtE5+tvY1rQslPWVhd6KpONcE2PrSU9Sm05kitVekxpCasBYYd uAbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=WbrJFxDN9M+roX+wTBZIP2zZRkjGZwlxDva2DwfHcBI=; b=rEvyIQ2OXSO0H29LM7QU+Yk9WcdMTg0tV1w1opOj3J6HwF41R6N5IWVmobqZqyvpt+ gs45XFpezctG+JPCz6wFk0McoG4sJgaLSOJKOVQv/qpGL2jhnNfIj6e3J+vMHj3yFHi4 14iuifQSSEcPmLYcYmcRWHVltvnkrC7W5OhDbmebM0dzSO+h+VLcrgdG/6jpDaymZy7E NK0WN8PJRAlEwdFhgMboBbmcuL09UnRjxObvKwoOhF4p5IDJY2gWQUSZ8jaoR6im2U1L 4QQYuw5XraWOtRIrxiiqMIxEcRIzaGxuYToT6KSkT+ciWU8Szdw5kXvW42d02fQ6gt48 zb+A== X-Gm-Message-State: ACgBeo0I30JuZ2wuxlTLbKoY2kucnB+PS5L9wvXV/OcBaXTh+jm9EtIy IP0tPf28ROyYb3pkfN8b1ALTVw== X-Google-Smtp-Source: AA6agR65kCJXgGOmiLBCOsmHznD6sp8G9/H9QT459/kOlCrrMh5qBYGusq3dde2OIsxeWsgvigZYww== X-Received: by 2002:a05:6512:1393:b0:48d:6f0:64c7 with SMTP id p19-20020a056512139300b0048d06f064c7mr2221626lfa.20.1662624658338; Thu, 08 Sep 2022 01:10:58 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u18-20020a05651c131200b00261e7e7b698sm3075777lja.123.2022.09.08.01.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:10:57 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/5] arm64: dts: qcom: sa8295p-adp: add missing gpio-ranges in PMIC GPIOs Date: Thu, 8 Sep 2022 10:10:50 +0200 Message-Id: <20220908081050.29751-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> References: <20220908081050.29751-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The Qualcomm PMIC GPIO bindings require gpio-ranges property: qcom/sa8295p-adp.dtb: pmic@8: gpio@c000: 'gpio-ranges' is a required property Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts index 98f8420488b6..b608b82dff03 100644 --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts @@ -186,6 +186,7 @@ pm8450a_gpios: gpio@c000 { compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; + gpio-ranges = <&pm8450a_gpios 0 0 10>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -202,6 +203,7 @@ pm8450c_gpios: gpio@c000 { compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; + gpio-ranges = <&pm8450c_gpios 0 0 10>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -218,6 +220,7 @@ pm8450e_gpios: gpio@c000 { compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; + gpio-ranges = <&pm8450e_gpios 0 0 10>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -234,6 +237,7 @@ pm8450g_gpios: gpio@c000 { compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; + gpio-ranges = <&pm8450g_gpios 0 0 10>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>;