From patchwork Wed Sep 7 02:33:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 604190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2812ECAAD5 for ; Wed, 7 Sep 2022 02:33:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbiIGCdf (ORCPT ); Tue, 6 Sep 2022 22:33:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbiIGCde (ORCPT ); Tue, 6 Sep 2022 22:33:34 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43F6393203 for ; Tue, 6 Sep 2022 19:33:33 -0700 (PDT) X-UUID: 8502a2e9897a48c1abecfa665379da46-20220907 X-CPASD-INFO: 458630f5711143d0b8de6b53f41ba9e0@fYVyVmBilGVjUXN9g3avaoJplJVmjlW CqG5Rko9pkVCVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3g3dyVmNelg== X-CLOUD-ID: 458630f5711143d0b8de6b53f41ba9e0 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:146.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:0.0, SPC:0, SIG:- 5, AUF:14, DUF:4211, ACD:72, DCD:72, SL:0, EISP:0, AG:0, CFC:0.208, CFSR:0.156, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 8502a2e9897a48c1abecfa665379da46-20220907 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 8502a2e9897a48c1abecfa665379da46-20220907 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1261898946; Wed, 07 Sep 2022 10:33:55 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATH v1 1/3] uas: add no-uas quirk for Hiksemi usb_disk Date: Wed, 7 Sep 2022 10:33:53 +0800 Message-Id: <1662518033-17777-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Signed-off-by: Hongling Zeng --- change for v1 -Change the email real name --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index cdff7dc..a6bf87a 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -62,6 +62,13 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_IGNORE_UAS), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x090c, 0x2000, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI * commands in UAS mode. Observed with the 1.28 firmware; are there others? From patchwork Wed Sep 7 02:34:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 603764 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754AFECAAD5 for ; Wed, 7 Sep 2022 02:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbiIGCdv (ORCPT ); Tue, 6 Sep 2022 22:33:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbiIGCdu (ORCPT ); Tue, 6 Sep 2022 22:33:50 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A6A9322C for ; Tue, 6 Sep 2022 19:33:48 -0700 (PDT) X-UUID: 57a867216f7b49b8bc9cb45b0af0cfdc-20220907 X-CPASD-INFO: 995a7211b962484880365c94578bde9b@golvgWRkX2GOWXh-g3t_clhhY2Zlj1m Dd3FYkpKVZYKVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3iHtvgWlgYQ== X-CLOUD-ID: 995a7211b962484880365c94578bde9b X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:208. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:150.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:2.0, SPC:0, SIG:- 5, AUF:15, DUF:4212, ACD:72, DCD:72, SL:0, EISP:0, AG:0, CFC:0.176, CFSR:0.168, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 57a867216f7b49b8bc9cb45b0af0cfdc-20220907 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 57a867216f7b49b8bc9cb45b0af0cfdc-20220907 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1559616718; Wed, 07 Sep 2022 10:34:12 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATH v1 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS Date: Wed, 7 Sep 2022 10:34:11 +0800 Message-Id: <1662518051-17831-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi USB_HDD is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Signed-off-by: Hongling Zeng --- Change for v1 - Change the email real name and the code worng place. --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index a6bf87a..8a18d58 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -149,6 +149,13 @@ UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Benjamin Tissoires */ UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, "Initio Corporation", From patchwork Wed Sep 7 02:34:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 604189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCCBECAAD5 for ; Wed, 7 Sep 2022 02:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbiIGCeA (ORCPT ); Tue, 6 Sep 2022 22:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbiIGCd6 (ORCPT ); Tue, 6 Sep 2022 22:33:58 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69D8994118 for ; Tue, 6 Sep 2022 19:33:57 -0700 (PDT) X-UUID: 021d893284f34916964152b9cf7392df-20220907 X-CPASD-INFO: 8a1482a0888043f89e2d50c5877497f9@gbFrVGVkj2BkWHp8g3axclmWYpRlXIO EenFXZGdnklmVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3h6NrVGhgkQ== X-CLOUD-ID: 8a1482a0888043f89e2d50c5877497f9 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:119.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:0.0, SPC:0, SIG:- 5, AUF:16, DUF:4213, ACD:72, DCD:72, SL:0, EISP:0, AG:0, CFC:0.325, CFSR:0.105, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 021d893284f34916964152b9cf7392df-20220907 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 021d893284f34916964152b9cf7392df-20220907 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 298534234; Wed, 07 Sep 2022 10:34:21 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATH v1 3/3] uas: ignore UAS for Thinkplus chips Date: Wed, 7 Sep 2022 10:34:22 +0800 Message-Id: <1662518062-17875-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Thinkplus is reported to fail to work on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 Falling back to USB mass storage can solve this problem, so ignore UAS function of this chip. Signed-off-by: Hongling Zeng --- Change for v1 - Change the email real name and the code worng place. --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index 8a18d58..156e89c 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",