From patchwork Tue Sep 6 03:27:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 603330 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D69ECAAD3 for ; Tue, 6 Sep 2022 03:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238308AbiIFD22 (ORCPT ); Mon, 5 Sep 2022 23:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238371AbiIFD2G (ORCPT ); Mon, 5 Sep 2022 23:28:06 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 760BC6CD3E for ; Mon, 5 Sep 2022 20:27:36 -0700 (PDT) X-UUID: 9ca6b3b5ee494520a2c44c9b04f4a8aa-20220906 X-CPASD-INFO: 743a436644ff47e7946ab9795cb4f12f@gIRtgWFlZGZgVKiyg3qwcVllZpGSZVe Id52CZZRhXoaVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBhXoZgUZB3hnZtgWVhZg== X-CLOUD-ID: 743a436644ff47e7946ab9795cb4f12f X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:1.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:141.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:1.0, CFOB:1.0, SPC:0, SIG:- 5, AUF:12, DUF:4112, ACD:71, DCD:71, SL:0, EISP:0, AG:0, CFC:0.2, CFSR:0.155, UAT:0, RAF :0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EA F:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 9ca6b3b5ee494520a2c44c9b04f4a8aa-20220906 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 9ca6b3b5ee494520a2c44c9b04f4a8aa-20220906 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1249559960; Tue, 06 Sep 2022 11:27:57 +0800 From: zenghongling To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, zenghongling Subject: [PATCH 1/3] uas: add no-uas quirk for Hiksemi usb_disk Date: Tue, 6 Sep 2022 11:27:54 +0800 Message-Id: <1662434874-5116-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Signed-off-by: zenghongling --- linux-4.9.327/drivers/usb/storage/unusual_uas.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/linux-4.9.327/drivers/usb/storage/unusual_uas.h b/linux-4.9.327/drivers/usb/storage/unusual_uas.h index cdff7dc..2fc6787 100644 --- a/linux-4.9.327/drivers/usb/storage/unusual_uas.h +++ b/linux-4.9.327/drivers/usb/storage/unusual_uas.h @@ -62,6 +62,12 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_IGNORE_UAS), +UNUSUAL_DEV(0x090c, 0x2000, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI * commands in UAS mode. Observed with the 1.28 firmware; are there others? From patchwork Tue Sep 6 03:28:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 603770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76ACECAAA1 for ; Tue, 6 Sep 2022 03:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238214AbiIFD2z (ORCPT ); Mon, 5 Sep 2022 23:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238415AbiIFD2Q (ORCPT ); Mon, 5 Sep 2022 23:28:16 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3061E6C107 for ; Mon, 5 Sep 2022 20:27:48 -0700 (PDT) X-UUID: 8f741a944b3f40968e60ae5334a07ee6-20220906 X-CPASD-INFO: 13a9b898c1e24abdab9142087e07c898@eoObWY9qZ2iPUad-g6StnoGTaWFkXlC HeZ9QZ5FoZViVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3gHWbWZRmaQ== X-CLOUD-ID: 13a9b898c1e24abdab9142087e07c898 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:141.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:2.0, SPC:0, SIG:- 5, AUF:13, DUF:4113, ACD:71, DCD:71, SL:0, EISP:0, AG:0, CFC:0.167, CFSR:0.2, UAT:0, RAF :0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EA F:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 8f741a944b3f40968e60ae5334a07ee6-20220906 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 8f741a944b3f40968e60ae5334a07ee6-20220906 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 442656841; Tue, 06 Sep 2022 11:28:09 +0800 From: zenghongling To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, zenghongling Subject: [PATCH 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS Date: Tue, 6 Sep 2022 11:28:11 +0800 Message-Id: <1662434891-5160-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi USB_HDD is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Signed-off-by: zenghongling --- linux-4.9.327/drivers/usb/storage/unusual_uas.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/linux-4.9.327/drivers/usb/storage/unusual_uas.h b/linux-4.9.327/drivers/usb/storage/unusual_uas.h index 2fc6787..bf0bb79 100644 --- a/linux-4.9.327/drivers/usb/storage/unusual_uas.h +++ b/linux-4.9.327/drivers/usb/storage/unusual_uas.h @@ -141,6 +141,12 @@ UNUSUAL_DEV(0x0bc2, 0xab21, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: G. Richard Bellamy */ UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x9999, "Seagate", From patchwork Tue Sep 6 03:28:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 603329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FB9ECAAD3 for ; Tue, 6 Sep 2022 03:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238371AbiIFD35 (ORCPT ); Mon, 5 Sep 2022 23:29:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231874AbiIFD3G (ORCPT ); Mon, 5 Sep 2022 23:29:06 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6844F6CD0C for ; Mon, 5 Sep 2022 20:28:07 -0700 (PDT) X-UUID: 33c3d717d0db41d79eee4dec42b27327-20220906 X-CPASD-INFO: 257c066856f34e5fbdea0932a0ca9d41@e4Vxg11oZGhhVqh_g6iAoIKVlZFgZVO Bo2qDkWeUYFGVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3gXdxg2BkZg== X-CLOUD-ID: 257c066856f34e5fbdea0932a0ca9d41 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:112.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:0.0, SPC:0, SIG:- 5, AUF:13, DUF:4113, ACD:71, DCD:71, SL:0, EISP:0, AG:0, CFC:0.407, CFSR:0.084, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 33c3d717d0db41d79eee4dec42b27327-20220906 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 33c3d717d0db41d79eee4dec42b27327-20220906 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 16328132; Tue, 06 Sep 2022 11:28:29 +0800 From: zenghongling To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, zenghongling Subject: [PATCH 3/3] uas: ignore UAS for Thinkplus chips Date: Tue, 6 Sep 2022 11:28:28 +0800 Message-Id: <1662434908-5204-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Thinkplus is reported to fail to work on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 Falling back to USB mass storage can solve this problem, so ignore UAS function of this chip. Signed-off-by: zenghongling --- linux-4.9.327/drivers/usb/storage/unusual_uas.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/linux-4.9.327/drivers/usb/storage/unusual_uas.h b/linux-4.9.327/drivers/usb/storage/unusual_uas.h index bf0bb79..4206385 100644 --- a/linux-4.9.327/drivers/usb/storage/unusual_uas.h +++ b/linux-4.9.327/drivers/usb/storage/unusual_uas.h @@ -182,6 +182,12 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA), +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Thinh Nguyen */ UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, "PNY",