From patchwork Tue Feb 12 14:19:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 158154 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3901455jaa; Tue, 12 Feb 2019 06:19:57 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia2jABfv1doKk60P6BtbPmM9vrBgwphJsPmh4rNDgY0myPWRzOFSQqU59ZYm0kui02xU1Cl X-Received: by 2002:a17:902:a415:: with SMTP id p21mr1329056plq.7.1549981197259; Tue, 12 Feb 2019 06:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549981197; cv=none; d=google.com; s=arc-20160816; b=d74KMxeKpc6nYh+HcxzhucsmscHYqIF0AA9icVcA6+qJV+mhLA0Av1UDPrHVVpNT7d CSNYsfIDRg0xg3+034X3Z1NW7tU5R6IsC6d01FzW1kRolSOYl/GXkjqFLbkIIw4j4cl/ 4FyvxHWIlzuasojFEtAhYefOIUkN6ztUa6RzcK2NRwAAp8DsOw1YwzcMv4XyD8S5ajmC pRasVkeNcuRlGMQ4D3lzh4EpGjCAvMfYs4xtNKYnQGVH5qOTFFiD0GQ9a1eS06km/hoB dvoCNLuzAOQL2PYMg8tQhb3v74K/EKpUZJ0ojJlGGbPtl6OuBkplYjmdk4bjOyO+8FEp xpNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Utm90G5IPjBRXtazwujVj4uAUzCke3Q6vjvDJL4l9mQ=; b=Le/g1ehsMYa1pHqChOwCdyvIJSU1M+hMug7zDRDE535xwQTjhRoKvcZH1gsn4w/Y0l kdTZgq8mp1b620/xfp4CxqiI0DwA4Qz2MQiz8MqVDh/Saz3xTL8DLpJFX4T/4ONIxBMS 6H0yNUsoiRW0ASvQ4627axESrLfzUE0Vg8IDwzwCT9RSqypT/Occrduot4O/JgF5sVE/ +/rErnzZMZ6DdF8Ci9Puhy8jGMc/Bd34jnCoGUyTHXKDZThJa7sN3F/gLtFDExDwlK76 Opzd3n69z5DGt+KqdyyzJsE7Wco6kECuvaeQ8Rx93gb0rXOEhvMEq1yv2o7XHlBpct4y B1nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zVSx00El; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p189si786550pga.95.2019.02.12.06.19.57; Tue, 12 Feb 2019 06:19:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zVSx00El; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730241AbfBLOT4 (ORCPT + 15 others); Tue, 12 Feb 2019 09:19:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:33366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730157AbfBLOT4 (ORCPT ); Tue, 12 Feb 2019 09:19:56 -0500 Received: from localhost.localdomain (unknown [122.167.101.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 982A020838; Tue, 12 Feb 2019 14:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549981195; bh=YT+SzQ7pwUKX1+qJael7Su1xIVUC35sLJf/+k+amDg4=; h=From:To:Cc:Subject:Date:From; b=zVSx00ElyoKs7RTpnU27wQQbPlVOq9tCZPhqLNI8OYbdLbdIdIeBIk6BeThoxOJuB xtAvpTzAtAmb++SzdsEQeGkVjamtx1AA4GWdS1kJiLwADXDWWCgrHhupvyyRm6CuS0 kVlOio82EnX15L3adJvh09uJw0cnCJH1lp7Wv4Qg= From: Vinod Koul To: David S Miller Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , netdev@vger.kernel.org, Niklas Cassel , Andrew Lunn , Florian Fainelli , "Nori, Sekhar" , Peter Ujfalusi , Marc Gonzalez Subject: [PATCH] net: phy: at803x: disable delay only for RGMII mode Date: Tue, 12 Feb 2019 19:49:22 +0530 Message-Id: <20190212141922.12849-1-vkoul@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID can have delay in phy. So disable the delay only for RGMII mode and disable for other modes Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") Reported-by: Peter Ujfalusi Signed-off-by: Vinod Koul --- drivers/net/phy/at803x.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) -- 2.20.1 Tested-by: Peter Ujfalusi diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 8ff12938ab47..7b54b54e3316 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, return phy_write(phydev, AT803X_DEBUG_DATA, val); } +static inline int at803x_enable_rx_delay(struct phy_device *phydev) +{ + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0, + AT803X_DEBUG_RX_CLK_DLY_EN); +} + +static inline int at803x_enable_tx_delay(struct phy_device *phydev) +{ + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0, + AT803X_DEBUG_TX_CLK_DLY_EN); +} + static inline int at803x_disable_rx_delay(struct phy_device *phydev) { return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, @@ -255,18 +267,25 @@ static int at803x_config_init(struct phy_device *phydev) if (ret < 0) return ret; - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID || - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || - phydev->interface == PHY_INTERFACE_MODE_RGMII) { + if (phydev->interface == PHY_INTERFACE_MODE_RGMII) { ret = at803x_disable_rx_delay(phydev); if (ret < 0) return ret; + ret = at803x_disable_tx_delay(phydev); + if (ret < 0) + return ret; + }; + + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || + phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) { + ret = at803x_enable_rx_delay(phydev); + if (ret < 0) + return ret; } - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID || - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || - phydev->interface == PHY_INTERFACE_MODE_RGMII) { - ret = at803x_disable_tx_delay(phydev); + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || + phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) { + ret = at803x_enable_tx_delay(phydev); if (ret < 0) return ret; }