From patchwork Fri Aug 26 08:39:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badhri Jagan Sridharan X-Patchwork-Id: 600567 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6996ECAAA3 for ; Fri, 26 Aug 2022 08:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245404AbiHZIlY (ORCPT ); Fri, 26 Aug 2022 04:41:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343698AbiHZIki (ORCPT ); Fri, 26 Aug 2022 04:40:38 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB79628E08 for ; Fri, 26 Aug 2022 01:40:07 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-3363b1dffa0so14841197b3.23 for ; Fri, 26 Aug 2022 01:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc; bh=5Nio9wW+lrrk0jgd+Y112TI5asoBTwAgUJzWnWe5Nhw=; b=lc/DEvA28YWRszUXEzeZiZBVU33lgrVMfzjNRLDZdc2lRvjAZToaPDsCieBTLyyGQa mIUmjfEOYpO9/mMQoZ79PsRbPjy1ugF6JXOpcEuFXrFulmpYBwn/FqAZXZUrfh+duRae hL/Wmrw1HNOfwcYmlIJpvDyqNAaMQrx0t9zsr1HfhQLVlU4FVFFLtP3C2ENDiABYjH/l GRHPTZjMj2399RnPkmhjxwvqv0nAwkX3VpfFfUCYl5soSOD3Sqc95t+1tBhve/6OG9sJ 3eapzduIfdIMZsDiMWWF9lVrASgwhRR9UNKj4mVd1y5aYLFAPOhnnimMTcMASf3KYtr/ AgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc; bh=5Nio9wW+lrrk0jgd+Y112TI5asoBTwAgUJzWnWe5Nhw=; b=caBqdXw4gsCL/NA/m2ub+d1czjHI4roSQMtVp3ykJ/ibNLyPntXmKAf8L4UYY55wTi v77xU7V1VlPutz9JSfd5iq3Sgwc71Dms2MPYYJrf4Yrr8PLuMribBxQdO/A/a2/xj9XC gGlctv5At8U1B8rha4GgX+UeMi65F6Qf1ePEZid9UwWHlOlYXNchuM902RzocIPYbu5Z udzfRLfcReU+CvWp/dzOpXD+WVsK3Ws0Xu16wRO/H49n6Lnkgq5kkiYu94hv+RLjA//D 0vd45XU2heTY+MUJwCoLq+y4QCEN1SWJvdHvC+Qwl4XcPRiNNtbOE4GSa9LAtBTvE9DD jNyg== X-Gm-Message-State: ACgBeo1y4STySecqdbedbnI7JFGJYBT2CQNk/eaRMVpI8c/YzacXYRQi Y1pLpajXBOKx+2tt3ECqzczV5H3TCYM= X-Google-Smtp-Source: AA6agR4Uav3ReYTOQOwjr3GgXzhPHy3miFnlZKIUaO7TrO0USxQIECRWCkEtZY8fF0mFzaNA3fs9N3qEZlM= X-Received: from badhri.mtv.corp.google.com ([2620:15c:211:201:9c82:622c:af33:39f2]) (user=badhri job=sendgmr) by 2002:a81:594:0:b0:33d:a498:167c with SMTP id 142-20020a810594000000b0033da498167cmr7809363ywf.59.1661503206669; Fri, 26 Aug 2022 01:40:06 -0700 (PDT) Date: Fri, 26 Aug 2022 01:39:58 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220826084001.3341215-1-badhri@google.com> Subject: [PATCH v1 1/4] usb: typec: tcpm: Add callbacks to mitigate wakeups due to contaminant From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , Badhri Jagan Sridharan Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On some of the TCPC implementations, when the Type-C port is exposed to contaminants, such as water, TCPC stops toggling while reporting OPEN either by the time TCPM reads CC pin status or during CC debounce window. This causes TCPM to be stuck in TOGGLING state. If TCPM is made to restart toggling, the behavior recurs causing redundant CPU wakeups till the USB-C port is free of contaminant. [206199.287817] CC1: 0 -> 0, CC2: 0 -> 0 [state TOGGLING, polarity 0, disconnected] [206199.640337] CC1: 0 -> 0, CC2: 0 -> 0 [state TOGGLING, polarity 0, disconnected] [206199.985789] CC1: 0 -> 0, CC2: 0 -> 0 [state TOGGLING, polarity 0, disconnected] ... To mitigate redundant TCPM wakeups, TCPCs which do have the needed hardware can implement the check_contaminant callback which is invoked by TCPM to evaluate for presence of contaminant. Lower level TCPC driver can restart toggling through TCPM_PORT_CLEAN event when the driver detects that USB-C port is free of contaminant. check_contaminant callback also passes the disconnect_while_debounce flag which when true denotes that the CC pins transitioned to OPEN state during the CC debounce window. Signed-off-by: Badhri Jagan Sridharan --- drivers/usb/typec/tcpm/tcpm.c | 59 +++++++++++++++++++++++++++++++++-- include/linux/usb/tcpm.h | 7 +++++ 2 files changed, 64 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index ea5a917c51b1..072c5a2817d0 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -36,6 +36,7 @@ #define FOREACH_STATE(S) \ S(INVALID_STATE), \ S(TOGGLING), \ + S(CHECK_CONTAMINANT), \ S(SRC_UNATTACHED), \ S(SRC_ATTACH_WAIT), \ S(SRC_ATTACHED), \ @@ -249,6 +250,7 @@ enum frs_typec_current { #define TCPM_RESET_EVENT BIT(2) #define TCPM_FRS_EVENT BIT(3) #define TCPM_SOURCING_VBUS BIT(4) +#define TCPM_PORT_CLEAN BIT(5) #define LOG_BUFFER_ENTRIES 1024 #define LOG_BUFFER_ENTRY_SIZE 128 @@ -483,6 +485,13 @@ struct tcpm_port { * SNK_READY for non-pd link. */ bool slow_charger_loop; + + /* + * When true indicates CC pins transitioned to OPEN state while + * debouncing(tCCDebounce). + */ + bool disconnect_while_debouncing; + #ifdef CONFIG_DEBUG_FS struct dentry *dentry; struct mutex logbuffer_lock; /* log buffer access lock */ @@ -3663,6 +3672,7 @@ static int tcpm_src_attach(struct tcpm_port *port) port->partner = NULL; port->attached = true; + port->disconnect_while_debouncing = false; port->send_discover = true; return 0; @@ -3797,6 +3807,7 @@ static int tcpm_snk_attach(struct tcpm_port *port) port->partner = NULL; port->attached = true; + port->disconnect_while_debouncing = false; port->send_discover = true; return 0; @@ -3824,6 +3835,7 @@ static int tcpm_acc_attach(struct tcpm_port *port) tcpm_typec_connect(port); port->attached = true; + port->disconnect_while_debouncing = false; return 0; } @@ -3908,11 +3920,22 @@ static void run_state_machine(struct tcpm_port *port) switch (port->state) { case TOGGLING: break; + case CHECK_CONTAMINANT: + port->tcpc->check_contaminant(port->tcpc, port->disconnect_while_debouncing); + port->disconnect_while_debouncing = false; + break; /* SRC states */ case SRC_UNATTACHED: if (!port->non_pd_role_swap) tcpm_swap_complete(port, -ENOTCONN); tcpm_src_detach(port); + if (port->disconnect_while_debouncing) { + /* Check for contaminant when port reports disconnected while debouncing */ + if (port->tcpc->check_contaminant) { + tcpm_set_state(port, CHECK_CONTAMINANT, 0); + break; + } + } if (tcpm_start_toggling(port, tcpm_rp_cc(port))) { tcpm_set_state(port, TOGGLING, 0); break; @@ -3922,6 +3945,7 @@ static void run_state_machine(struct tcpm_port *port) tcpm_set_state(port, SNK_UNATTACHED, PD_T_DRP_SNK); break; case SRC_ATTACH_WAIT: + port->disconnect_while_debouncing = true; if (tcpm_port_is_debug(port)) tcpm_set_state(port, DEBUG_ACC_ATTACHED, PD_T_CC_DEBOUNCE); @@ -3936,6 +3960,7 @@ static void run_state_machine(struct tcpm_port *port) break; case SNK_TRY: + port->disconnect_while_debouncing = false; port->try_snk_count++; /* * Requirements: @@ -4150,6 +4175,13 @@ static void run_state_machine(struct tcpm_port *port) tcpm_swap_complete(port, -ENOTCONN); tcpm_pps_complete(port, -ENOTCONN); tcpm_snk_detach(port); + if (port->disconnect_while_debouncing) { + port->disconnect_while_debouncing = false; + if (port->tcpc->check_contaminant) { + tcpm_set_state(port, CHECK_CONTAMINANT, 0); + break; + } + } if (tcpm_start_toggling(port, TYPEC_CC_RD)) { tcpm_set_state(port, TOGGLING, 0); break; @@ -4159,6 +4191,7 @@ static void run_state_machine(struct tcpm_port *port) tcpm_set_state(port, SRC_UNATTACHED, PD_T_DRP_SRC); break; case SNK_ATTACH_WAIT: + port->disconnect_while_debouncing = true; if ((port->cc1 == TYPEC_CC_OPEN && port->cc2 != TYPEC_CC_OPEN) || (port->cc1 != TYPEC_CC_OPEN && @@ -4170,14 +4203,16 @@ static void run_state_machine(struct tcpm_port *port) PD_T_PD_DEBOUNCE); break; case SNK_DEBOUNCED: - if (tcpm_port_is_disconnected(port)) + if (tcpm_port_is_disconnected(port)) { tcpm_set_state(port, SNK_UNATTACHED, PD_T_PD_DEBOUNCE); - else if (port->vbus_present) + } else if (port->vbus_present) { tcpm_set_state(port, tcpm_try_src(port) ? SRC_TRY : SNK_ATTACHED, 0); + port->disconnect_while_debouncing = false; + } break; case SRC_TRY: port->try_src_count++; @@ -4925,6 +4960,12 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1, tcpm_set_state(port, SRC_ATTACH_WAIT, 0); else if (tcpm_port_is_sink(port)) tcpm_set_state(port, SNK_ATTACH_WAIT, 0); + /* Check for contaminant when port reports disconnected while toggling */ + else if (tcpm_port_is_disconnected(port) && port->tcpc->check_contaminant) + tcpm_set_state(port, CHECK_CONTAMINANT, 0); + break; + case CHECK_CONTAMINANT: + /* Wait for Toggling to be resumed */ break; case SRC_UNATTACHED: case ACC_UNATTACHED: @@ -5225,6 +5266,7 @@ static void _tcpm_pd_vbus_off(struct tcpm_port *port) case SNK_ATTACH_WAIT: case SNK_DEBOUNCED: /* Do nothing, as TCPM is still waiting for vbus to reaach VSAFE5V to connect */ + port->disconnect_while_debouncing = false; break; case SNK_NEGOTIATE_CAPABILITIES: @@ -5425,6 +5467,10 @@ static void tcpm_pd_event_handler(struct kthread_work *work) port->vbus_source = true; _tcpm_pd_vbus_on(port); } + if (events & TCPM_PORT_CLEAN) { + tcpm_log(port, "port clean"); + tcpm_set_state(port, TOGGLING, 0); + } spin_lock(&port->pd_event_lock); } @@ -5477,6 +5523,15 @@ void tcpm_sourcing_vbus(struct tcpm_port *port) } EXPORT_SYMBOL_GPL(tcpm_sourcing_vbus); +void tcpm_port_clean(struct tcpm_port *port) +{ + spin_lock(&port->pd_event_lock); + port->pd_events |= TCPM_PORT_CLEAN; + spin_unlock(&port->pd_event_lock); + kthread_queue_work(port->wq, &port->event_work); +} +EXPORT_SYMBOL_GPL(tcpm_port_clean); + static void tcpm_enable_frs_work(struct kthread_work *work) { struct tcpm_port *port = container_of(work, struct tcpm_port, enable_frs); diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h index bffc8d3e14ad..436563d91a49 100644 --- a/include/linux/usb/tcpm.h +++ b/include/linux/usb/tcpm.h @@ -114,6 +114,11 @@ enum tcpm_transmit_type { * Optional; The USB Communications Capable bit indicates if port * partner is capable of communication over the USB data lines * (e.g. D+/- or SS Tx/Rx). Called to notify the status of the bit. + * @check_contaminant: + * Optional; The callback is called when CC pins report open status + * at the end of the deboumce period or when the port is still + * toggling. Chip level drivers are expected to check for contaminant + * and call tcpm_clean_port when the port is clean. */ struct tcpc_dev { struct fwnode_handle *fwnode; @@ -148,6 +153,7 @@ struct tcpc_dev { bool pps_active, u32 requested_vbus_voltage); bool (*is_vbus_vsafe0v)(struct tcpc_dev *dev); void (*set_partner_usb_comm_capable)(struct tcpc_dev *dev, bool enable); + void (*check_contaminant)(struct tcpc_dev *dev, bool disconnect_while_debouncing); }; struct tcpm_port; @@ -165,5 +171,6 @@ void tcpm_pd_transmit_complete(struct tcpm_port *port, enum tcpm_transmit_status status); void tcpm_pd_hard_reset(struct tcpm_port *port); void tcpm_tcpc_reset(struct tcpm_port *port); +void tcpm_port_clean(struct tcpm_port *port); #endif /* __LINUX_USB_TCPM_H */ From patchwork Fri Aug 26 08:40:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badhri Jagan Sridharan X-Patchwork-Id: 600566 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BD2ECAAD6 for ; Fri, 26 Aug 2022 08:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234424AbiHZIl3 (ORCPT ); Fri, 26 Aug 2022 04:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343713AbiHZIkj (ORCPT ); Fri, 26 Aug 2022 04:40:39 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 875473ECDC for ; Fri, 26 Aug 2022 01:40:13 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-33dd097f993so15676477b3.10 for ; Fri, 26 Aug 2022 01:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc; bh=1BCRKzVhOtBrKG/VR6oCKwA2rCN8yts14gxEEpWzTCs=; b=LpDUdywQAhULaMYLRcfvjEFdyqICCSbvUhMa1DwrNNBTXZ98htp1qCZwkXePp0+qCP fjWkp3GQpIlRivOEyhsVHLsN6eU/KWRz9XFPvbwOinyj0d3mfcx9j2h9IvBFz3Cax1dx D+6trm1GmP3wzvlvqtVNSb/Zh1UtxY9xcfwoJ5/Z5nUEZNPNZHtV2V/7VzGIvP8BVwSv wLi74SKWq17U0iEorxRpjRSmMMIAGSy47nHgvX2KCsjCfjZjhu9pFdF1ancQdj4wBoLR vKVy7pYQN320eHO3HAsMf1AEOpRSt++WrxHCnZDOsPV1hBoLjM5R1WBoNIHhyi+ndYRj nn7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc; bh=1BCRKzVhOtBrKG/VR6oCKwA2rCN8yts14gxEEpWzTCs=; b=aOnZtO+q3qqhu5XGiCuXopwFcK+vIo5OCKVwRgq/k4jjYFOs3MWPh7AgidYda2/AIa Y/b7dlrUMscvlgdofd3lmefRXwTrVZpHLSZzX7qK22PzLO/qVUG0lkO+PizoMo6QgzI5 gWyTkGgU+2g5nEjTVOK3Nt0IZK4xNZvNutxJZKhAX6JyF6vcZAkgxgr84ecK1jMz4EON IAMTfzZtlkKIB10xjjsHpa3KDfSSD8ki3AXQvnhXb8ofHAGHT8iUhXfp5P8LZ3N3DhDi pcVTAeRdk4xItXjt1iTD6QV+4XjLGDAd1Ej0CKaVwtNI08psOsC7mmnc7SN2rEg6CUSh RNdQ== X-Gm-Message-State: ACgBeo3ENeA1dm/ocT5PSTDLmrjCyzWOsBa+AngQm4f1aByZsy+MXlzA poI/9NDJB0uHeeDflPArs3UyoplUlLU= X-Google-Smtp-Source: AA6agR6wjESRw5TzQK2Y6xr9dLNT27OzE76bMAt4poVX5d//5QWPL/VdEtum0Cvn2yNc0Zzee+GEEfFEqGs= X-Received: from badhri.mtv.corp.google.com ([2620:15c:211:201:9c82:622c:af33:39f2]) (user=badhri job=sendgmr) by 2002:a0d:da83:0:b0:329:9c04:fe6d with SMTP id c125-20020a0dda83000000b003299c04fe6dmr7700379ywe.196.1661503212667; Fri, 26 Aug 2022 01:40:12 -0700 (PDT) Date: Fri, 26 Aug 2022 01:40:00 -0700 In-Reply-To: <20220826084001.3341215-1-badhri@google.com> Mime-Version: 1.0 References: <20220826084001.3341215-1-badhri@google.com> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220826084001.3341215-3-badhri@google.com> Subject: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function for register reads From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , Badhri Jagan Sridharan Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Signed-off-by: Badhri Jagan Sridharan --- drivers/usb/typec/tcpm/tcpci_maxim.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c index 4b6705f3d7b7..af3a7ecab23b 100644 --- a/drivers/usb/typec/tcpm/tcpci_maxim.c +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c @@ -68,25 +68,29 @@ static struct max_tcpci_chip *tdata_to_max_tcpci(struct tcpci_data *tdata) return container_of(tdata, struct max_tcpci_chip, data); } -static int max_tcpci_read16(struct max_tcpci_chip *chip, unsigned int reg, u16 *val) +inline int max_tcpci_read16(struct max_tcpci_chip *chip, unsigned int reg, u16 *val) { return regmap_raw_read(chip->data.regmap, reg, val, sizeof(u16)); } +EXPORT_SYMBOL_GPL(max_tcpci_read16); -static int max_tcpci_write16(struct max_tcpci_chip *chip, unsigned int reg, u16 val) +inline int max_tcpci_write16(struct max_tcpci_chip *chip, unsigned int reg, u16 val) { return regmap_raw_write(chip->data.regmap, reg, &val, sizeof(u16)); } +EXPORT_SYMBOL_GPL(max_tcpci_write16); -static int max_tcpci_read8(struct max_tcpci_chip *chip, unsigned int reg, u8 *val) +inline int max_tcpci_read8(struct max_tcpci_chip *chip, unsigned int reg, u8 *val) { return regmap_raw_read(chip->data.regmap, reg, val, sizeof(u8)); } +EXPORT_SYMBOL_GPL(max_tcpci_read8); -static int max_tcpci_write8(struct max_tcpci_chip *chip, unsigned int reg, u8 val) +inline int max_tcpci_write8(struct max_tcpci_chip *chip, unsigned int reg, u8 val) { return regmap_raw_write(chip->data.regmap, reg, &val, sizeof(u8)); } +EXPORT_SYMBOL_GPL(max_tcpci_write8); static void max_tcpci_init_regs(struct max_tcpci_chip *chip) {