From patchwork Thu Aug 25 15:06:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599967 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp354455mae; Thu, 25 Aug 2022 08:09:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR5HdTpvjj1fV8cvsHux11Jx82KymTA82izP8asMJIpP+tcFuYsPAtIPlXpzjnyfDlcyFvwr X-Received: by 2002:a05:620a:1537:b0:6ba:be3d:d70f with SMTP id n23-20020a05620a153700b006babe3dd70fmr3347202qkk.578.1661440144030; Thu, 25 Aug 2022 08:09:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440144; cv=none; d=google.com; s=arc-20160816; b=scrBQZne9IH5GJeb7TNoFDHpSf0HKewTyMsItMLdoBvsuAH/mc51uCs4mo0Ioz+W9S DSUFU64TDTf9Nb8lVb9xW9Z/WElKzEOm6GBHWqMCOEvoU8gLBlfPIPbMoJYUHSOFXtzn W5tgnm8bbz/QPnnhR/wNO3rM03hXjFB5E7eIYgZFTiC9fndQaUZPE9pg0jQnpObmA1eI KUwO3CxzTlOgdyr/PBKTtX1RXlMWZXFOJqegxmQBxRcw7n77DkT6uhNe5YTV6BrBUu8Z R6LGTGtcUf9JqQNVfoakcE2KLShqS7u9BNOjX2oon59YmBDB75PMuV4/ec945/PPDV5e /7rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=+xZTakyk5u2TBFgliT7wIbbLXV3Gbp3ddv6mrgYQohs=; b=jN1XuAQJhE4FObWWcB6WTg0o6pjpbAb9hoqsbN+eiL/SBhc7hFHcd26M+k65ICY4nD LkgauHT9y+II+9JUS8GK4/QaYTELLiNW6MY7zVWmpqQfx+9j0p7Cfjgh6g5Q2om9LMTA g/CuGgaMQL7O41TW+LTUlIQBwqwHO86Uvr+DbCCICu/QVMICSRqvdHiDvouyr7+6ZqnW c2LA3KYkT1tpp9Vvn5P8Nhrkf43yE1vVxlezt4QaQV8HZZhKer+MASKha5Xq73idNf2n vORekGIKmsxLfpGrEuT+TVWzb0jyjPeEdCZBPCtOr7n4OUylBJ1nMV2Mus5Xjfy6cFck 2DTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZYSk01Cx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bz26-20020a05622a1e9a00b0031f1933f10fsi9944511qtb.221.2022.08.25.08.09.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:09:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZYSk01Cx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRETf-0003ul-Ke for patch@linaro.org; Thu, 25 Aug 2022 11:09:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERq-0003uL-1k for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:10 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:40600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERo-0002Ln-Bs for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:09 -0400 Received: by mail-wr1-x42c.google.com with SMTP id h5so24198134wru.7 for ; Thu, 25 Aug 2022 08:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=+xZTakyk5u2TBFgliT7wIbbLXV3Gbp3ddv6mrgYQohs=; b=ZYSk01CxiLczD40wouVLJecG1AXCSnlnXRuxq56S2aqpt0Z9D2Vai4fbTZAQjfkc4m Ikeog7nuHmb2V+ffoZZlcsFMHgEBfRqZmW9QsAoyH0WE8ANy+I4EYWKQrVgB7vr+MiZU W5VRgrMUEWxzAfZAXLmzlax0FNpM/lqoVjdvWNuNHTUbedp3EgAMCs9IKnh87Zi16/Ba x0LTjHJJlZbYD286cct//l3eYRKGUQiIqhYGdXImFGqNl3O79sOCIrM/ceCLL2gpt5+/ +nqHlMp+K4reBvPsd11KAoAX3zLVONYSwo9JkhMN4bnnI/v8LCbWHD8oSEhXg0kt7IWo fNLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=+xZTakyk5u2TBFgliT7wIbbLXV3Gbp3ddv6mrgYQohs=; b=e2ZE1/JsAnp6uwsGr//788NZnPWW1aMyzifiosM463RD2qAn2V0C1niLiJkiak3ucV dR7xKzaqFhXj1mlG9i5ojNmZOJ5LP75s7UY6DVL2cyY9uzOufaolRY7qQP8Xi9wGa1o+ wZBhf+xDRCnFyE+t4mjuUKFVyuCejwMsvtne53eVOFunYuWIoZ+EWKxASC3v34KnXnK3 bxyGcLEgdcPLyopFgvUd93mZCyyuQ7N0f2jDXPsV7aVh5E+2nImCvGq/ClRiOApqX9HU 5Xstp3ecMHOTEUb0Kqmxpu+WWZYnjTxX7QVvfikwFGr9EFakCQ0Pg3L2m50l0PeY63GG zAzA== X-Gm-Message-State: ACgBeo1HD0V6PkyYicHtBsnlek02WRZRxpKOOZPUGc2zCNOpJvNrxqcG 2xsDufFCJAByCwUcOIjsqopDIiiBXiN3cw== X-Received: by 2002:a5d:6881:0:b0:225:28cb:332f with SMTP id h1-20020a5d6881000000b0022528cb332fmr2582713wru.405.1661440026902; Thu, 25 Aug 2022 08:07:06 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:06 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 1/7] configure: Remove unused python_version variable Date: Thu, 25 Aug 2022 16:06:57 +0100 Message-Id: <20220825150703.4074125-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Shellcheck correctly reports that we set python_version and never use it. This is a leftover from commit f9332757898a7: we used to use python_version purely to as part of the summary information printed at the end of a configure run, and that commit changed to printing the information from meson (which looks up the python version itself). Remove the unused variable. Signed-off-by: Peter Maydell --- configure | 3 --- 1 file changed, 3 deletions(-) diff --git a/configure b/configure index 72ab03f11aa..efe28050234 100755 --- a/configure +++ b/configure @@ -1112,9 +1112,6 @@ if ! $python -c 'import sys; sys.exit(sys.version_info < (3,6))'; then "Use --python=/path/to/python to specify a supported Python." fi -# Preserve python version since some functionality is dependent on it -python_version=$($python -c 'import sys; print("%d.%d.%d" % (sys.version_info[0], sys.version_info[1], sys.version_info[2]))' 2>/dev/null) - # Suppress writing compiled files python="$python -B" From patchwork Thu Aug 25 15:06:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599971 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp356695mae; Thu, 25 Aug 2022 08:12:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Ty9gYqee7hiPv7MRjAvZBEZNefqTWFLHds5MAbEU7SgjStT3qvtcWtYDW+vIOoAzCiSBX X-Received: by 2002:a05:6214:e6c:b0:476:a4bd:2b95 with SMTP id jz12-20020a0562140e6c00b00476a4bd2b95mr3946945qvb.25.1661440327365; Thu, 25 Aug 2022 08:12:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440327; cv=none; d=google.com; s=arc-20160816; b=T5uIAC8Ss5KC/oXwpED+VkuWu9s73XHx2RqTlM9vu+8OAl0WbTbpS8mPQ/M1wIScrI 9s1ZxFUcPAZrQMhsMSwvnXfCbb0YQ7iHEQMxMIB9py7PdnNr9o2eMKtrNmg64uY4G3Xd j5RGG8ltMs5vqcXLI8exJ1j9wUHMIDfKF5oAB8US+SN0s+PS52JrVXMW9GYC/jee9PId n0Jwd6EYg1wMzinqgPsUCuuwv/6rCCK133Gx6h1CKMhmIoYRjqhK/aHEVy9PC4CjWMgJ t1yaXS2CHXsR6D2wuCtAs5tfMxlo7R1qABURKhXYIuYMWVmt/tPD1xuxaRQplz/Z2C2i n7pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=2OVPYJQv5NBuPCjLGLGoSfyQ6B6HYDsVYY1WswEVFEg=; b=pKNdNH9ouUr8VtLMnyfO5vxSQStKtAPCfQb1O+4plpAOQhfFN+Nt7a8ankJfwQXawZ 2zTc7GXL/sRARKEt9r/3q5kRx6AGWJvFhEy5/r82ks8GWAW90eb65GQyNCnGwyR5VODy 661mVwQFZlHevtxPPnspR0OHJQfns+jm53qoFS/yhj4v3Go7hBGD08hvXO/Lzm45+aly r8ti5J35hukJECmdRHAqxyQIb1CCIkvxElNZuyU4ZvgDG3HQ3suphgaNMcueDcMwLw3z f4PNxoDibFUhiViFM8Qv6oEGogLv3sNqiUZQoJSQk83QxYk49CFq8rVK9kM1DpTbjdM6 a1fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HlW3WjZf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m9-20020a05620a24c900b006b8dee896a2si419413qkn.209.2022.08.25.08.12.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:12:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HlW3WjZf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREWc-0001LX-VO for patch@linaro.org; Thu, 25 Aug 2022 11:12:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERr-0003ua-2c for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:11 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:46074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERp-0002Ly-GO for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:10 -0400 Received: by mail-wr1-x436.google.com with SMTP id bq11so18427069wrb.12 for ; Thu, 25 Aug 2022 08:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=2OVPYJQv5NBuPCjLGLGoSfyQ6B6HYDsVYY1WswEVFEg=; b=HlW3WjZfUrij5ZrefSQmkNWjpuUn/wy8J/6Od+GtGWrh9SkHt8f8snsFVBYr61MQ9K ddgT/4rZeoDQjeTSCA/iWWMxiJdi9rafGIqYlKtGPR7qfx3RLwmVc6STjXj+01UC0NsX ymk5IqqE8lw16lKQMQ7x/EJvjSGUCuB1TvEyvpHqEsjzazFyASpJr9k4Lgm+XBVspBuk Y/Sj5U6maWJ3cakbahYnqMLMHzpGI1u9GmplQG3FXlSducTWD1bbGddnpnJKtBSU4Sgt BqKMjsA9JCo8KVl7MIp9sAJgMGJ+G01vqS0hcfeAtAcEej4hbtLpz7UWNfGJ6L9Mrt8D 4hAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=2OVPYJQv5NBuPCjLGLGoSfyQ6B6HYDsVYY1WswEVFEg=; b=OFLAaTHFg4VvRF1ErbX3X1obpFJx3fIlo6ubQFhvMQRJx5g+ra1+saFZST5qWCPYnX LNx4uTFPKhL5qKnpgnqtsG+Gz1/BOBMjhxhZGHZ7pLHh1NJEWWxSOXedrYJx5aU6AeK2 blSgbNmblHc/zgk4vQVoQEcTLFCdngsvSHcchpd/CM6v+nyOCNf/DyqkySIfAxdg/LUd 2UbuI85Wq993C0s8z5sVSJHCvn7YYefVCsfzq9rj29Eq44OWk3ExPesX0+FzLdCjB6v+ gAPRtS/qDKKVtIGFUXreWFiRR7IXLZbNb065Q8KdY4b4ARk4pXlgQjWIyapVrJqoJ0Oc HsOQ== X-Gm-Message-State: ACgBeo38aXMjs+yaNrMkfurwKawe4gLoIIe08GX+u2jycFUTyx1+x/5S aEPq8mwWu0FMHNnaGdc6I4+iqPE6mHI0/g== X-Received: by 2002:a5d:6e8e:0:b0:21d:ea5:710f with SMTP id k14-20020a5d6e8e000000b0021d0ea5710fmr2622835wrz.48.1661440027724; Thu, 25 Aug 2022 08:07:07 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:07 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 2/7] configure: Remove unused meson_args variable Date: Thu, 25 Aug 2022 16:06:58 +0100 Message-Id: <20220825150703.4074125-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The meson_args variable was added in commit 3b4da13293482134b, but was not used in that commit and isn't used today. Delete the unnecessary assignment. Signed-off-by: Peter Maydell --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index efe28050234..b1acaca6dd2 100755 --- a/configure +++ b/configure @@ -311,7 +311,6 @@ pie="" coroutine="" plugins="$default_feature" meson="" -meson_args="" ninja="" bindir="bin" skip_meson=no From patchwork Thu Aug 25 15:06:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599972 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp356744mae; Thu, 25 Aug 2022 08:12:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR4MxkeiSg+Cjb09sz7a0Qi79skQEGxIp2N87jzw6TPFzEMylG9MSCuYCSPKkHe4sPuCWkMR X-Received: by 2002:a0c:a950:0:b0:496:d8b1:b0c7 with SMTP id z16-20020a0ca950000000b00496d8b1b0c7mr3986502qva.9.1661440330363; Thu, 25 Aug 2022 08:12:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440330; cv=none; d=google.com; s=arc-20160816; b=t3yCY0FJmggr9QXaRT2UKm3UfQSpG6FO++JATNQAcCy3lyiZa5F9+sY/mSDlBQ9syU xkBysGRzdpff6mUvdDdXu4wVb9HgD3bvbTY6sevOCH5MU4oWap4DrvuRKC5ktK8aU1p6 +X/bZh1UDfbnoXFqord1VJq1i1SYt3A1f/nBa9Bhyrvp2uD/y8lv+jlBLyedq0xZKAp7 i5e+t2XwXBLy0exsRVhydto0ViqMu161x9oZbR7ZFvzWXSfTWc8BTvV8GqJhJ96eDVnm PegxWcsc/w1YZkrNpLldmYcZsOL8CstRjW5432V65VKHvG1vXbXv3Awzkrh3l+x+JdlK skIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DWNuvqbFBvUjcGdjxo+MqgXtO5vi7v0ejT71g3xQKIg=; b=nboaViCWO8VKSyoeNEAcwzhnLkx5/3/JvaB50BCyif1demNOnj4L9uGT29cJgshLTS jrtGiC3FfqAt1gTY8yTKm1QdnDYj9ifSrd1FBd1Dk9ByPvzNbZpCj/ePh8VYcq1FLyIe IV3mTVnQgLHqK6I2iW5Trd5ReZCcCxIp7nQ2w56huAFpVQZPecNZ50OyyJHRVX8REB8C b9wX6wzQ+CF+L0FpU+/ndcpUK2QN7oLR4p/vNzEEHoLQAp83QnuYKk+Wt6O4rFNtX2Cy z/BswIyNij68RW/ZKHrAFtr1mbL193EpG2h4YRDb9Z6D2yJPmO6WsM/VAFkAaC89CIIR 7etA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qi9mXkoH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id gh11-20020a05621429cb00b0047356ab5ce6si9254239qvb.544.2022.08.25.08.12.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qi9mXkoH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREWf-0001RF-Tx for patch@linaro.org; Thu, 25 Aug 2022 11:12:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERs-0003yB-LP for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:13 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERq-0002M4-IO for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:12 -0400 Received: by mail-wr1-x42f.google.com with SMTP id n17so392038wrm.4 for ; Thu, 25 Aug 2022 08:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=DWNuvqbFBvUjcGdjxo+MqgXtO5vi7v0ejT71g3xQKIg=; b=qi9mXkoH3wrwJjibelE3Xeo9GegiFCuONmK4CnVZzcBg7iM9+rq6hKJYoRMB9Soy30 fzrp4a2401scBjSFf8qfcbIxy3LYJv9E86a4rLoyqHNm0q2XrVBpm4Ychc/Jy/xN3k+F CyapDHLwsVOXSAop+1K2Bi/QRbsagk0hCdiQ1MIo10GU8zV4Tdx6CeOhcwBCpzLkYXD5 389tRNAeAJiKyJZPHrxEeAux4NxwMuCnG18/JoxVHfyTYYtm8CLb0yXLvLZ6y8JQWgvn 39rEpDzi58zSRyw5FTNoMen7cwF4nS8tRCy5Oqhvp591N4cDuGPP9fO83zqwNL/cImSf jqMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=DWNuvqbFBvUjcGdjxo+MqgXtO5vi7v0ejT71g3xQKIg=; b=FRSkl3Xw88B3rq9wzYHjTsJw/gGTKe8zrbV80f9duhJSISulX+YvbhkCEmWt67fzwY axLcbE1bOGrS4EH194OVdKS4cHb8vtIH9+gm6BpzzNSlnvuU+6JmTbQ9CGvdjzP32kPq TzZHMDHQIN767TLnKbHLl7rI1l/EF718f7KHLlFzDO6r3OhqE7tcFTkp6x6xWWFWZaL2 LnZLDUlR41NVms6NZ+PxAGCPbwHZcIpU+0PWZGzr7qoS+lkWUvXZHKNkWkbVFy1iJaHG puBgueDpa+Npi7oAspGmG4/f1BKK0F+pZiY/fvdWAvLiGr6irT3W9v2KB0ZV9DGSxI3+ 1apQ== X-Gm-Message-State: ACgBeo2SE4yptFDLsFeRvxGAKDRv4hxYe1WHJkWbFLubgJly2efCYYUV eF14FnloB3JzJsd1j83DE4NzAx/OwssBRg== X-Received: by 2002:a5d:6485:0:b0:225:5caf:2e44 with SMTP id o5-20020a5d6485000000b002255caf2e44mr2556391wri.365.1661440028722; Thu, 25 Aug 2022 08:07:08 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:08 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 3/7] configure: Add missing quoting for some easy cases Date: Thu, 25 Aug 2022 16:06:59 +0100 Message-Id: <20220825150703.4074125-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This commit adds quotes in some places which: * are spotted by shellcheck * are obviously incorrect * are easy to fix just by adding the quotes It doesn't attempt fix all of the places shellcheck finds errors, or even all the ones which are easy to fix. It's just a random sampling which is hopefully easy to review and which cuts down the size of the problem for next time somebody wants to try to look at shellcheck errors. Signed-off-by: Peter Maydell --- configure | 64 +++++++++++++++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/configure b/configure index b1acaca6dd2..894642554c3 100755 --- a/configure +++ b/configure @@ -57,7 +57,7 @@ GNUmakefile: ; EOF cd build - exec $source_path/configure "$@" + exec "$source_path/configure" "$@" fi # Temporary directory used for files created while @@ -691,7 +691,7 @@ meson_option_build_array() { printf ']\n' } -. $source_path/scripts/meson-buildoptions.sh +. "$source_path/scripts/meson-buildoptions.sh" meson_options= meson_option_add() { @@ -711,7 +711,7 @@ for opt do case "$opt" in --help|-h) show_help=yes ;; - --version|-V) exec cat $source_path/VERSION + --version|-V) exec cat "$source_path/VERSION" ;; --prefix=*) prefix="$optarg" ;; @@ -985,7 +985,7 @@ default_target_list="" mak_wilds="" if [ "$linux_user" != no ]; then - if [ "$targetos" = linux ] && [ -d $source_path/linux-user/include/host/$cpu ]; then + if [ "$targetos" = linux ] && [ -d "$source_path/linux-user/include/host/$cpu" ]; then linux_user=yes elif [ "$linux_user" = yes ]; then error_exit "linux-user not supported on this architecture" @@ -995,7 +995,7 @@ if [ "$bsd_user" != no ]; then if [ "$bsd_user" = "" ]; then test $targetos = freebsd && bsd_user=yes fi - if [ "$bsd_user" = yes ] && ! [ -d $source_path/bsd-user/$targetos ]; then + if [ "$bsd_user" = yes ] && ! [ -d "$source_path/bsd-user/$targetos" ]; then error_exit "bsd-user not supported on this host OS" fi fi @@ -1117,7 +1117,7 @@ python="$python -B" if test -z "$meson"; then if test "$explicit_python" = no && has meson && version_ge "$(meson --version)" 0.59.3; then meson=meson - elif test $git_submodules_action != 'ignore' ; then + elif test "$git_submodules_action" != 'ignore' ; then meson=git elif test -e "${source_path}/meson/meson.py" ; then meson=internal @@ -1840,7 +1840,7 @@ esac container="no" if test $use_containers = "yes"; then if has "docker" || has "podman"; then - container=$($python $source_path/tests/docker/docker.py probe) + container=$($python "$source_path"/tests/docker/docker.py probe) fi fi @@ -2290,7 +2290,7 @@ if test "$QEMU_GA_DISTRO" = ""; then QEMU_GA_DISTRO=Linux fi if test "$QEMU_GA_VERSION" = ""; then - QEMU_GA_VERSION=$(cat $source_path/VERSION) + QEMU_GA_VERSION=$(cat "$source_path"/VERSION) fi @@ -2539,7 +2539,7 @@ fi for target in $target_list; do target_dir="$target" target_name=$(echo $target | cut -d '-' -f 1)$EXESUF - mkdir -p $target_dir + mkdir -p "$target_dir" case $target in *-user) symlink "../qemu-$target_name" "$target_dir/qemu-$target_name" ;; *) symlink "../qemu-system-$target_name" "$target_dir/qemu-system-$target_name" ;; @@ -2574,14 +2574,14 @@ for target in $target_list; do config_target_mak=tests/tcg/config-$target.mak echo "# Automatically generated by configure - do not modify" > $config_target_mak - echo "TARGET_NAME=$arch" >> $config_target_mak + echo "TARGET_NAME=$arch" >> "$config_target_mak" case $target in xtensa*-linux-user) # the toolchain is not complete with headers, only build softmmu tests continue ;; *-softmmu) - test -f $source_path/tests/tcg/$arch/Makefile.softmmu-target || continue + test -f "$source_path/tests/tcg/$arch/Makefile.softmmu-target" || continue qemu="qemu-system-$arch" ;; *-linux-user|*-bsd-user) @@ -2596,73 +2596,73 @@ for target in $target_list; do # compilers is a requirememt for adding a new test that needs a # compiler feature. - echo "BUILD_STATIC=$build_static" >> $config_target_mak - write_target_makefile >> $config_target_mak + echo "BUILD_STATIC=$build_static" >> "$config_target_mak" + write_target_makefile >> "$config_target_mak" case $target in aarch64-*) if do_compiler "$target_cc" $target_cflags \ -march=armv8.1-a+sve -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_SVE=y" >> $config_target_mak + echo "CROSS_CC_HAS_SVE=y" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -march=armv8.1-a+sve2 -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_SVE2=y" >> $config_target_mak + echo "CROSS_CC_HAS_SVE2=y" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -march=armv8.3-a -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_ARMV8_3=y" >> $config_target_mak + echo "CROSS_CC_HAS_ARMV8_3=y" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -mbranch-protection=standard -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_ARMV8_BTI=y" >> $config_target_mak + echo "CROSS_CC_HAS_ARMV8_BTI=y" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -march=armv8.5-a+memtag -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_ARMV8_MTE=y" >> $config_target_mak + echo "CROSS_CC_HAS_ARMV8_MTE=y" >> "$config_target_mak" fi ;; ppc*) if do_compiler "$target_cc" $target_cflags \ -mpower8-vector -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_POWER8_VECTOR=y" >> $config_target_mak + echo "CROSS_CC_HAS_POWER8_VECTOR=y" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -mpower10 -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_POWER10=y" >> $config_target_mak + echo "CROSS_CC_HAS_POWER10=y" >> "$config_target_mak" fi ;; i386-linux-user) if do_compiler "$target_cc" $target_cflags \ -Werror -fno-pie -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_I386_NOPIE=y" >> $config_target_mak + echo "CROSS_CC_HAS_I386_NOPIE=y" >> "$config_target_mak" fi ;; esac elif test -n "$container_image"; then echo "build-tcg-tests-$target: docker-image-$container_image" >> $makefile - echo "BUILD_STATIC=y" >> $config_target_mak - write_container_target_makefile >> $config_target_mak + echo "BUILD_STATIC=y" >> "$config_target_mak" + write_container_target_makefile >> "$config_target_mak" case $target in aarch64-*) - echo "CROSS_CC_HAS_SVE=y" >> $config_target_mak - echo "CROSS_CC_HAS_SVE2=y" >> $config_target_mak - echo "CROSS_CC_HAS_ARMV8_3=y" >> $config_target_mak - echo "CROSS_CC_HAS_ARMV8_BTI=y" >> $config_target_mak - echo "CROSS_CC_HAS_ARMV8_MTE=y" >> $config_target_mak + echo "CROSS_CC_HAS_SVE=y" >> "$config_target_mak" + echo "CROSS_CC_HAS_SVE2=y" >> "$config_target_mak" + echo "CROSS_CC_HAS_ARMV8_3=y" >> "$config_target_mak" + echo "CROSS_CC_HAS_ARMV8_BTI=y" >> "$config_target_mak" + echo "CROSS_CC_HAS_ARMV8_MTE=y" >> "$config_target_mak" ;; ppc*) - echo "CROSS_CC_HAS_POWER8_VECTOR=y" >> $config_target_mak - echo "CROSS_CC_HAS_POWER10=y" >> $config_target_mak + echo "CROSS_CC_HAS_POWER8_VECTOR=y" >> "$config_target_mak" + echo "CROSS_CC_HAS_POWER10=y" >> "$config_target_mak" ;; i386-linux-user) - echo "CROSS_CC_HAS_I386_NOPIE=y" >> $config_target_mak + echo "CROSS_CC_HAS_I386_NOPIE=y" >> "$config_target_mak" ;; esac got_cross_cc=yes fi if test $got_cross_cc = yes; then mkdir -p tests/tcg/$target - echo "QEMU=$PWD/$qemu" >> $config_target_mak + echo "QEMU=$PWD/$qemu" >> "$config_target_mak" echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >> $makefile tcg_tests_targets="$tcg_tests_targets $target" fi From patchwork Thu Aug 25 15:07:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599969 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp354488mae; Thu, 25 Aug 2022 08:09:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+sF8nihimjVZ03FXwKjE7bASZtlL6+UY8J5Fs8ALFFJOQY8tslK7atlzC0MFyN6pPXaGf X-Received: by 2002:a05:622a:1452:b0:344:51de:cc10 with SMTP id v18-20020a05622a145200b0034451decc10mr3923103qtx.432.1661440147518; Thu, 25 Aug 2022 08:09:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440147; cv=none; d=google.com; s=arc-20160816; b=RDqGXnEuEcxsJ7FkW12KmqKXW7XAU4aUKzAqKnZo4RrIOwtRi/fxAXBkoYOntZ6eAm jjeBUT7nb3u1KcAnI/ihhxb9Zw5f5elc05dYrVsCtN7Qgvw0zjk+3Oli1lbqypXQADTS tXdYSBi7Fm5wUCTZTA+rCa2B2H6Tq3ALiX40ORf7eS+OB85buMdqIRVmdgMa6r8/vLzy S5HAGWC4rqtcVgD7CB4Ht153cl2eY6ICOTh2cX8pD7BJ5fbAadJQxri3gao3sIMCBEwK 5TACtyASiw0N6kU5qr2L/UMBrm7ouRe3/ezUPjp3QAtQW3A5UeGCdeuRXFXwzO7RU7F4 RBGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=JiN1luN3YeavHyuwP6WbtnNpnk7z37GeHVcVmF5DqF0=; b=bh0PMRXUwBfbNEqZp3ye19bDbVcS9FmcpatEWCjpJ3+M5nsQPipywtIh+RWtSnZ3BH EoZkdELZvP7FKvUOQmpQXVr2grVy46BVrgCjNjERI2dX2NI7ARP/dZMUqG4TzLS+mJT4 VNJyEqZqhC20nSc9l+cdBbQ253/x1FshhOHZEF9Aolnhua9bAuLdixrgHq3LpxuccKhy Wi9ek2Zv+pcSg+tSmyqiMxPh/xtCns39T/sJfV/9x4emyeHwrSb+OqXACbDZ5LF0C4bf leC+6qS7TeVSiXRwlfQirfIsygB9Y9FimrAsB85wKZgGCXCthtCISqGZWiRE0s/GAEm8 mhuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nkdmCpbA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id fo12-20020ad45f0c000000b004922ac9db6csi10063841qvb.60.2022.08.25.08.09.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:09:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nkdmCpbA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRETj-0003zS-1T for patch@linaro.org; Thu, 25 Aug 2022 11:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERs-0003yJ-No for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:12 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:41801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERr-0002MM-3E for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:12 -0400 Received: by mail-wr1-x434.google.com with SMTP id h24so25006954wrb.8 for ; Thu, 25 Aug 2022 08:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=JiN1luN3YeavHyuwP6WbtnNpnk7z37GeHVcVmF5DqF0=; b=nkdmCpbAI9VsDyH8tJdTk6/xarCBpEBIKW1AwuzoGz5u74jUXFoszHyG1Jy2UooExu ua+ozd2TGtEqSKWun7xNEn101t7Xe9h7rx6xzN/zhJmdRhTtF0CKlx10Sbh3tBv5DLdK DCODhfg4U+2Ro4CJ348XvJBa7PaKcMTC0lDl42I1mGFkti3a5E0u9w85+aRX5SQC0OUx uVsRzjpJVhejwCMgcYTT6kbiPTGXEuIrCICnzsV9o8WObqVKpU/PTBL0NyCvnz90Z2vm M7vY+S5iGp10XKwg+ldboM3e3jnoJaw5GXvekdVb4/Qh97iwVVipZur8Vf3O8Vk5yz4/ B77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=JiN1luN3YeavHyuwP6WbtnNpnk7z37GeHVcVmF5DqF0=; b=hDJGJYZ6lLczOM1LYBHNYH9LVFus7ive46U09/FnUWSs3P9E0Jo/bC1uP/W+yEQwoD NVCZFvRT0AlaC+n4FiC1limOq7MAXxEo74GNKnfYZKdrppOlSK+S1LsU2ZUFALOiCzFd 6oLAAUhFWoIgGe6O2gLm6USwsHBwY5tAnwL+xESs/u0tfgYyKxrT6qvh939SXfEahXIP 9Ent/ttTli1asKR21Ns8JU4WRkW2WDVizDvH4RIKzxS3MtFCjSwrZTQWImqS3CRupfjh 0kdFNY6GciSuaSd6NNgop9Qlw/BmavusBslcjoTafnLbnKG3rk/ETR3CZG+VB3+YCstj RfeA== X-Gm-Message-State: ACgBeo0NwuohlKcINYeGoTrbplyr0BVMkxvDVZNZUU3ubnld50TIA9hW 7xiUo3B3yyiU4NUHlZIGZwkajBonqDb0HA== X-Received: by 2002:a05:6000:1448:b0:225:63f2:2421 with SMTP id v8-20020a056000144800b0022563f22421mr2438638wrx.527.1661440029623; Thu, 25 Aug 2022 08:07:09 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:09 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 4/7] configure: Add './' on front of glob of */config-devices.mak.d Date: Thu, 25 Aug 2022 16:07:00 +0100 Message-Id: <20220825150703.4074125-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Shellcheck warns that in rm -f */config-devices.mak.d the glob might expand to something with a '-' in it, which would then be misinterpreted as an option to rm. Fix this by adding './'. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 894642554c3..d5b6546ae81 100755 --- a/configure +++ b/configure @@ -1093,7 +1093,7 @@ exit 0 fi # Remove old dependency files to make sure that they get properly regenerated -rm -f */config-devices.mak.d +rm -f ./*/config-devices.mak.d if test -z "$python" then From patchwork Thu Aug 25 15:07:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599973 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp359852mae; Thu, 25 Aug 2022 08:16:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR4zPUnnc8aaXoMWL0wDcnlKz7A54QEFkdQiXrSc2VWgAZxFcuOxYJGzDmv4LkNDMlt54teF X-Received: by 2002:ac8:5a8e:0:b0:344:69b2:1307 with SMTP id c14-20020ac85a8e000000b0034469b21307mr3888278qtc.57.1661440563605; Thu, 25 Aug 2022 08:16:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440563; cv=none; d=google.com; s=arc-20160816; b=fFp6j8y8bNI/e2wv4yi6E+oPnXajA/0TNcoxi/EzgqZUYg6Odde2RfOQ3LkSdia4Ia j7zbjQNhb/wSGNSpsz8Jvv+ltsC3ez1aV9JqtyZD6zA93X3v5WBPOhoU7L8cp7LfPP7n EX+fBNooplxIE7v7a6O0ZQu8yUVvxj8frChmTfMc+HPIrivRPpXXymtyepFiuJGzhYL7 f7CnJW0IXWtHIyHF66ktbawjL8r/03RSC8dAqSg4vpmoX2ep33jlh4eO7iK8n6r3Jj8S S6EsLu6oamu2HO5UvPYbE/1wdMUKkE0IUmEG+MDcwczgcTPNM/mckz1eW0kbM5uzOgrI sGvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=xf12vm2J9pTBvB1Rs+/alRNUQSzG8ZNSmZQQA8BoXwU=; b=tu+EaAMEMYS0S64SM6iVI+Sc0B/36wkxfrRE6mR7lOYmyGRzjm43eSmgbjJIHWLvRW uzc5CbHwfTKFbwIs8bLMWr92J1a/PX1yNSovF+V/87/GdXeW2OnurUMazNqvKrbpEE50 9uDtv+uq0AqzMzPGjL4kE86IKxWIGMa74z5/R35eMeSQezkkMm0tq/vwO46RT7blQWTx maT3SZsIsawCpv1U3SkedjWcT6+VX1mCgM2Wynu8Ty6mHwCtgNfXoEB7IbChEDRaiT3u x2xPmukyJGtke9sKCGPIwVcadmOs6YwFE72HPrKRIJ9gh7LnGJJ9pv9DMm8V5Tp+vzaz zYNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G9IBdo6I; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i6-20020ac85c06000000b0031d3ea50dddsi11651093qti.422.2022.08.25.08.16.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:16:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G9IBdo6I; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREaO-0006W9-Fi for patch@linaro.org; Thu, 25 Aug 2022 11:16:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERx-00049V-1u for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:17 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:37841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERr-0002MX-Qp for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:16 -0400 Received: by mail-wr1-x436.google.com with SMTP id n17so392160wrm.4 for ; Thu, 25 Aug 2022 08:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=xf12vm2J9pTBvB1Rs+/alRNUQSzG8ZNSmZQQA8BoXwU=; b=G9IBdo6IQjSpmZ0OrgRGeMhKzlVAFsnRvNSqx0o6ZyIvAJWq/viaykAF+GpABVTRTm CkbLTV0REb8uAVFxJCmRo2XloXCuDF+FmKaDH1UZCZK5J4LBg/zsx/+c7YOqp2ynWcjg 7fJDUEeLqs9mL34c1WlGKAxz/x+KMHxz63DW/08h52+YXhi08sUAY8IkUYsKLdfwC8Zq 2ec4+mtT613507llsPBTzlK7HUi3BwPTWSPa3SPrj4TVZiNmbMPQt+pa5+B3NRTqaaKw xSvq1cqbkavYTP+l3sUp69LGoD5kyEdMFA3oLRrQUkGfQpiy7W4+59e1ENZ8TIcv6F7B NBCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=xf12vm2J9pTBvB1Rs+/alRNUQSzG8ZNSmZQQA8BoXwU=; b=tdOdQvyKIfLbVXwMx88fFMaS94SqyxXlSm/TrT3TsEY+rPie+TJmN7V9QhpEhEOekX esDzrMYHGvHjnMf7A78hlfFiftEubkl/oXunDq+dUFBRQCqI+Fq5YZ4pncZyf1RPdvIO cRJzrk/V4j/d/x/hfJYfXwXpjmPrVgCGTcTn0pt0iN/yAMR3zAW1P4QiEdSymwuRxNUL FQY7cZTf3gDCJNJ9DSgtz9CkvjpbZem/OBkKo03PUiYloR6TLSc4W61zotGfE4Q7RcBi nYZgr7q8fMvAdox6lvAhchaN6YFkeag0rMzXXux7Jdm7f/CKIqtS9w8slzICS3PlRsQq plOA== X-Gm-Message-State: ACgBeo010mZjE03F3puNpr0SbBEXWgRJyhkq073uM/dpsutVtBqcUXwc 4qBkIK4LA0RS6PmLsvOMtC9nowRjDx3d+g== X-Received: by 2002:a05:6000:250:b0:225:624b:13 with SMTP id m16-20020a056000025000b00225624b0013mr2460816wrz.127.1661440030511; Thu, 25 Aug 2022 08:07:10 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:10 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 5/7] configure: Remove use of backtick `...` syntax Date: Thu, 25 Aug 2022 16:07:01 +0100 Message-Id: <20220825150703.4074125-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There's only one place in configure where we use `...` to execute a command and capture the result. Switch to $() to match the rest of the script. This silences a shellcheck warning. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d5b6546ae81..5c1992d5bce 100755 --- a/configure +++ b/configure @@ -2317,7 +2317,7 @@ LINKS="$LINKS python" LINKS="$LINKS contrib/plugins/Makefile " for f in $LINKS ; do if [ -e "$source_path/$f" ]; then - mkdir -p `dirname ./$f` + mkdir -p "$(dirname ./"$f")" symlink "$source_path/$f" "$f" fi done From patchwork Thu Aug 25 15:07:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599968 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp354474mae; Thu, 25 Aug 2022 08:09:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5j4frDhw2JVKPkJ+A6J50COCTT7Bg3JQXEdjR7vNr2mzHLDuttlVwqdKhe8q/CIepNbSUL X-Received: by 2002:ac8:5885:0:b0:343:74df:9b26 with SMTP id t5-20020ac85885000000b0034374df9b26mr4003904qta.406.1661440146258; Thu, 25 Aug 2022 08:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440146; cv=none; d=google.com; s=arc-20160816; b=APZ+CxZbVk8fq6fP+psyX0V3QBDxCR0ubzL1JCc8kL2OOSvywjQMZs9nnmGgCU5UG0 83xMdql1hXwAu9Xtbyb182fyPyDJM3KXKwo9ePGresukDbJccVUxCxi1fMnYHU1dn0R7 1MUcfunN4/Y+JWnYOVdV1AB1RQk+G6BERjfQw/C1sm3YHaYuG5V/F1CYYstaguTaROBo DLhj+OoOcpTrTSI0FhwPhZz2ep4TVE/Hv0fl1EGx1CtcSXX3nNW6a+OyptoOUq/MRPYj E2HrXt59mInaFM4VN18EVaNk/MUoUoRi8yxwgvY2PbhGQLstBSAJCHDanvjgR3tbQ4g6 +POg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=4boT9ZMp8UNLQGnPh1ZGB1JNd8shwOC+FWZasArxRX0=; b=IxkTvt54U1Y/TdRN6+bpXPpj6b9z3euwvPyKOqzuuiAz4FgcVuKahTQQLzJlc86Jqv mvUJdcoDxUDbhUHcF/CiTO/SsunFZuhyJpJu1Vtgr3qRY1UmD5h1QqK2CaYYG4XMD79c j+8W8g3Sc4AUz1IvxutE0Nrqn79oou+LLgqUd1xobYiUCL3oNdQbK6f6MyqA035WssHH O3fxeM/VQwzYIc3+/+YAfuWNdAMXbf3idM+niMm6Nc0wXp63JXDQ1X/DCMWhcuu5mCdi /gpuumaHL6XuhqnfoT24fphcczFzYsbziFtkY30EhPWAx7eXapzHqCFu//o30eSoKHla HvNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wk5KsKhJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ff10-20020a05622a4d8a00b00344a67fbb8asi7748110qtb.637.2022.08.25.08.09.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:09:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wk5KsKhJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRETh-00043w-Qz for patch@linaro.org; Thu, 25 Aug 2022 11:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERu-00040V-Ey for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:44975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERs-0002Mn-Sb for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: by mail-wm1-x336.google.com with SMTP id k18-20020a05600c0b5200b003a5dab49d0bso2683744wmr.3 for ; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=4boT9ZMp8UNLQGnPh1ZGB1JNd8shwOC+FWZasArxRX0=; b=wk5KsKhJ4H6O4nuab22EGZzNJgjJHaF5skcbPGGbpT13em+JPLha8Uj9hXj3/rcHx9 NPINAOlwIPSAzGlSB0Qi7ZxoaWOj+lxopxSTiQwsvTMZQ+gXzDJVf/UIpOcmsE0C1mMS EdtcpPwk/9Ym0Zs/OkjCG88uEGGML3MAllyNKad2noglVvj0NuRPJjlHg6+iZ6yTiYH8 pMJmpnc/5ve3LPwwKG4HMWOP3HDeG8+Mbp7RhJud6LO7LgkzivWoJmg88tqSWOdoU5RF GufZOTo1Ot6PIKjepUqxJtCAv/lNm8qIUkbVV8F9ijq/fBRUZAhqnayhMr4whRh3DESh O9oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=4boT9ZMp8UNLQGnPh1ZGB1JNd8shwOC+FWZasArxRX0=; b=SYzZusGqva/zo4thDp63haYUl4CZTfVyPcHk44mnko3Cpd7cvE2epx0FmSFncbEf+e ODTCz2oVcmh7ZLDyJjoO+fozCV0lCnQyFp7suoUKM24UGRk9HFgd8mXLWcdM9swVrvMd uHR/Sg1XL6/30aJQ+zPl3z3yFs7HhagJoNUq5VHBgugxE7z0/Ny/3t/scieDL7vPfGJW g/+a9LC+mu/pbDtmE5pTsqhE7jsQEtAdvx7XupcYD4OtQnoj76FYPxHYVHOWfLHwcAaX 0LAJZ37+0YnheVwOclFtNpZTaLiC0UXSYbIgXqg96lj1EfhAekTuUC8m2GEBnhFhqnid qb0Q== X-Gm-Message-State: ACgBeo1r0UBHnhbRRjwBzG+AfGNwZM73oMJRrk13oVmnmWm5sAJ49PbL X/a6KWK1QUrsoLSdBqVyjrSUABd58t6mEw== X-Received: by 2002:a1c:7703:0:b0:3a5:aefa:68e3 with SMTP id t3-20020a1c7703000000b003a5aefa68e3mr2755344wmi.158.1661440031363; Thu, 25 Aug 2022 08:07:11 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:10 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 6/7] configure: Check mkdir result directly, not via $? Date: Thu, 25 Aug 2022 16:07:02 +0100 Message-Id: <20220825150703.4074125-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Shellcheck warns that we have one place where we run a command and then check if it failed using $?; this is better written to simply check the command in the 'if' statement directly. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 5c1992d5bce..f8d7270a60e 100755 --- a/configure +++ b/configure @@ -67,8 +67,7 @@ fi # it when configure exits.) TMPDIR1="config-temp" rm -rf "${TMPDIR1}" -mkdir -p "${TMPDIR1}" -if [ $? -ne 0 ]; then +if ! mkdir -p "${TMPDIR1}"; then echo "ERROR: failed to create temporary directory" exit 1 fi From patchwork Thu Aug 25 15:07:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 599970 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp356690mae; Thu, 25 Aug 2022 08:12:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ZV32JlwAraehueDQ64ZKxnzVmep3syn8CtZNpnwUqfSXmAGfeFPVSQ620xrNBv0NXa8ey X-Received: by 2002:ac8:4e87:0:b0:343:6249:1810 with SMTP id 7-20020ac84e87000000b0034362491810mr4029749qtp.117.1661440326787; Thu, 25 Aug 2022 08:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661440326; cv=none; d=google.com; s=arc-20160816; b=sb262retjIIisMcoM5jIrgH7G4H8ybYW1HB7yBaVd4Q+fPBeQR1gvYjwo5dlwuuP2W Hnl0llKTYo99cYsqCUvIAbr+2YZH+CzYBynIfbQkCAepgdtcDglAbVqqNf4e0OiG3y1B 41uCmtnGaxQWOCj2R141vKvY1ReWxUVlbTSvVy5HJOBQNBWacuzeaJTsgstsecB7LNqr /5Iq4jclf2iK/s/ZC5PkCB18Xw22KozAhYE+9P2j9/jZJSzc6YCHiEKNiacY8bzX5Grr uA7o0HMHzIWKXKRRP4BIx2Q4CUtbo7SwQ2IzDW43oKeKxG1zYnJbphAxd4X9G/S4FUv3 tK8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=gfzBkvKduEMFGr20IRUSeBlVG1QRzWpQAykxC9X/YJ4WEshU4ZQb0x5BWhkWA3FdlL DaFH++ZQ7rNCflh89HqcXmZuETEEn/MPyJT9JPjskp11ECWlfNblaUddwp5kPrFyJCje j3+fGWRcAR5yOmWT9Tb89ukHXHL9ZFo/KljxroP1t1yT9C45t7edSS9MwGepo8BvnrA/ lJpQAGVwMoTJnnj3qOPdMSv428Igp87aDYb+Gp6NiK445/gTehOrhtLcOODPuXF4tVQd vzRavSLj6NUI1MTAqT+Im/aUNMk9sThtj7mULfhwn+UJwIegVE2YcvHu5J0cxsphiEEt 3gzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mlFGuZ5O; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p17-20020a05622a13d100b003435f7b3ceasi11386819qtk.197.2022.08.25.08.12.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Aug 2022 08:12:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mlFGuZ5O; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREWc-0001Hm-CO for patch@linaro.org; Thu, 25 Aug 2022 11:12:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERu-000410-JF for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERs-0002M4-W7 for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: by mail-wr1-x42f.google.com with SMTP id n17so392278wrm.4 for ; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=mlFGuZ5OjV2RVek6i01ZKdY8nX6XEU1A/hnnZkSNI/PLwUzz7F6jbGKU4VzilrjCXD ySGTTC5vnst6KrXbO6ZNsZLKQC7r7adpswLbV5JzyVZESOnX5MB/GJexe9Dk7g4BDNxy m226L6htJLAoCHCO7VTMT1kiBaZsWMMUK/T8Yp98EC6q7MqKQ2Lq/9YT842EsNGhYdVQ /DENxN7VKrKxf+e6/u4XCZ6cFW0TObBMHoBXWnmHC3V8wLwuJxSAkvyxfHDaQV7YvQ6z z13eyGueNq3TNuW0GmRuV58yXI6ksRkifGNvr+MRz9nAywtlhWYu4ExmjLbeFM13He/m e11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=BdVVjW/u7nsDote/ypRJ9pYhlj6Bpev2nTnGxZ8xmjVEhrp+ZlYYPDrfhEMZ15f/aS N7N/YnBR/c8Vko5D/cCTXRsp6lo+u1OtWnIaLVMBdrGy7ZjHhlbWj9MEYMGgoa4cx8jP Ey7R6O/AqVuaciLRoYt340uqYZf/434HGI3EIHr/QLjvj8OQL6IbvXvloSLkAgpJpCYT 9c/GqMBR/gPEkVDiJNN3l7KSXq6XI5toQ/t7c5/XDS7lZJ5K9G/o0BKfomwt3ev4lcxD gImpkkCXfKBWmfww3UevAt6VGvkz+0QPUdvkZseqy6FYgkxHW2q0Vpoh7djs1KQpZpuL PSQA== X-Gm-Message-State: ACgBeo24dL0H0Pklpuv3KSx3M692IEgOoMq3mWDxruEKlc2wmAzCZ/x5 oI/R/D1TdqCgouHltmh1YUE6nkWN0eyIAg== X-Received: by 2002:a5d:49c6:0:b0:225:61c9:dd4e with SMTP id t6-20020a5d49c6000000b0022561c9dd4emr2480862wrs.445.1661440032138; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:11 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 7/7] configure: Avoid use of 'local' as it is non-POSIX Date: Thu, 25 Aug 2022 16:07:03 +0100 Message-Id: <20220825150703.4074125-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We use the non-POSIX 'local' keyword in just two places in configure; rewrite to avoid it. In do_compiler(), just drop the 'local' keyword. The variable 'compiler' is only used elsewhere in the do_compiler_werror() function, which already uses the variable as a normal non-local one. In probe_target_compiler(), $try and $t are both local; make them normal variables and use a more obviously distinct variable name for $t. Signed-off-by: Peter Maydell --- configure | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure b/configure index f8d7270a60e..f2f793e3653 100755 --- a/configure +++ b/configure @@ -110,7 +110,7 @@ error_exit() { do_compiler() { # Run the compiler, capturing its output to the log. First argument # is compiler binary to execute. - local compiler="$1" + compiler="$1" shift if test -n "$BASH_VERSION"; then eval ' echo >>config.log " @@ -2071,7 +2071,6 @@ probe_target_compiler() { : ${container_cross_strip:=${container_cross_prefix}strip} done - local t try try=cross case "$target_arch:$cpu" in aarch64_be:aarch64 | \ @@ -2084,8 +2083,8 @@ probe_target_compiler() { try='native cross' ;; esac eval "target_cflags=\${cross_cc_cflags_$target_arch}" - for t in $try; do - case $t in + for thistry in $try; do + case $thistry in native) target_cc=$cc target_ccas=$ccas