From patchwork Mon Aug 22 17:44:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 599555 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5329CC28D13 for ; Mon, 22 Aug 2022 17:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234936AbiHVRoW (ORCPT ); Mon, 22 Aug 2022 13:44:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232071AbiHVRoV (ORCPT ); Mon, 22 Aug 2022 13:44:21 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95177422D3 for ; Mon, 22 Aug 2022 10:44:20 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id s6so5071300lfo.11 for ; Mon, 22 Aug 2022 10:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=pPgFBD7q3E3eicH1Pv3awZm8nZwSgddbX6vYO9NgS5s=; b=tKiS5nRGw+aixKb+4e2oD8qwOCfiuLqBi6o0G0b5aXjKruh3Wk+aVld6woWNtrkcoA FVXQbgyR/r+arZ5Qro+NmeaAeUm1J/BXKtkgtxX5Fkn3vnSrKw/Dtfr3a+jrZj1O9G2i mODLBzcL9eyDtvnVphp05DjRwPFFkBjkAaAHUN7rgybymq8O9egjysKQifVSqt7oMfGD lkFyQvrrZV0sdydZLd00P+qqRxKblnvLYtoPXn4F89CdSPis7tdHz2RlkFSZRYYyJqbR WLHb7Usvg6UDZuF2aDrVL3T1leXrFNMbtz36x1WXYPzc718DT8/bE6wue7GgEBn304ek ncFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=pPgFBD7q3E3eicH1Pv3awZm8nZwSgddbX6vYO9NgS5s=; b=EV8ndIuUHswONQaoQxgJikeL0TMAJLrNcQ05Kdls8sf5d59hOn7zeLKAq+v+6iV30h 1RoeFa8ewLgesdELvHLse8Udmxhc7gaOgv0pJVB2uqrMZ7k5GR+S/5uEzq93S1yf4wmq oXmRxK+S6EzvZGLp8AhwywhI/TDLNAEO2yT2YWAWOeHlTVIWmMnUJH/9mjBEXy9NJguP 2AhjR3doSYBA4xHsk5yYtjVL3xojTAynNEb5XaMjJGykamMMGJFegnuhk25zFNubBRpf vsht7AsxCfWGll+SUldhU9qNiaaBxSyi7hhuf1UzA/cTh1ejyvw4fmzfKLv9hfPYL244 cRWw== X-Gm-Message-State: ACgBeo087EyXnsuU5eRN5vOTPm7IP4nQo8yx89Ksww++hMDTF5I0R4Hv kgNDHJqHdQubrPpNN9BU0x4I8w== X-Google-Smtp-Source: AA6agR7TmR9HnV5ntDFtZKkSVFvPlc09+DbRAW4QsmCohy13NJfdZ/NlptxVK9QM16q7uQVJB8vl2g== X-Received: by 2002:a05:6512:3a94:b0:492:b321:8f75 with SMTP id q20-20020a0565123a9400b00492b3218f75mr7393314lfu.366.1661190258966; Mon, 22 Aug 2022 10:44:18 -0700 (PDT) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id n8-20020a05651203e800b0048b13d0b896sm327180lfq.141.2022.08.22.10.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 10:44:18 -0700 (PDT) From: Dmitry Baryshkov To: Rob Clark , Sean Paul , Abhinav Kumar Cc: Stephen Boyd , David Airlie , Daniel Vetter , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH] drm/msm/dsi: drop the hpd worker Date: Mon, 22 Aug 2022 20:44:17 +0300 Message-Id: <20220822174417.292926-1-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org It makes no sense to have the HPD worker in the MSM DSI driver anymore. It is only queued from the dsi_host_attach/detach() callbacks, where it plays no useful role. Either way the panel or next bridge will be present and will report it's status directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index a34078497af1..43bf84e92a7c 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -144,7 +144,6 @@ struct msm_dsi_host { u32 err_work_state; struct work_struct err_work; - struct work_struct hpd_work; struct workqueue_struct *workqueue; /* DSI 6G TX buffer*/ @@ -1500,14 +1499,6 @@ static int dsi_cmds2buf_tx(struct msm_dsi_host *msm_host, return len; } -static void dsi_hpd_worker(struct work_struct *work) -{ - struct msm_dsi_host *msm_host = - container_of(work, struct msm_dsi_host, hpd_work); - - drm_helper_hpd_irq_event(msm_host->dev); -} - static void dsi_err_worker(struct work_struct *work) { struct msm_dsi_host *msm_host = @@ -1697,8 +1688,6 @@ static int dsi_host_attach(struct mipi_dsi_host *host, return ret; DBG("id=%d", msm_host->id); - if (msm_host->dev) - queue_work(msm_host->workqueue, &msm_host->hpd_work); return 0; } @@ -1713,8 +1702,6 @@ static int dsi_host_detach(struct mipi_dsi_host *host, msm_host->device_node = NULL; DBG("id=%d", msm_host->id); - if (msm_host->dev) - queue_work(msm_host->workqueue, &msm_host->hpd_work); return 0; } @@ -2126,7 +2113,6 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi) /* setup workqueue */ msm_host->workqueue = alloc_ordered_workqueue("dsi_drm_work", 0); INIT_WORK(&msm_host->err_work, dsi_err_worker); - INIT_WORK(&msm_host->hpd_work, dsi_hpd_worker); msm_dsi->id = msm_host->id;