From patchwork Wed Aug 17 13:14:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9422CC32771 for ; Wed, 17 Aug 2022 13:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239680AbiHQNOg (ORCPT ); Wed, 17 Aug 2022 09:14:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239605AbiHQNO1 (ORCPT ); Wed, 17 Aug 2022 09:14:27 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201354BD03 for ; Wed, 17 Aug 2022 06:14:24 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id w5so18961703lfq.5 for ; Wed, 17 Aug 2022 06:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ylRikkO/bjiVr6cfpMQukwsajH9gmB7MCgQxpA3FZjg=; b=PlW7Mtcl47MpdE/4X+zlMXjbRlUXpGWW9lYJlFzAkyhQ6HaAUQuNhxHKHBZATug0fV qWWX0jOXCVp+nAnrGjjF7KUBOemnJGrR02np5S78KK79cjImAtHquy9edBoPFqJ1zp5T sxPsNlena2Y/2n9nF2P6+V51h8teL+21UMhJNmrqGofHl8pDvNYByk7pnsQSIaPyKLr4 2LzUPkeLxCO/3TpJnod9YLGzhENtwtomzyI4wdvNDWiqh7rDVci2w1728KL/JHXN9d0k OOV1Hd63+mI08bZZDt1S+FdV6Dtz68N3ZL/czhDm4NXBFmrPYnbwWb0K5GgrPluFd5hl JFpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ylRikkO/bjiVr6cfpMQukwsajH9gmB7MCgQxpA3FZjg=; b=ikp3kI4QXIeQ4VSRULIQDWp6hzef+LVwq8jT9jvcM75v5g8zm3N0yOR88c1qZ/BevL n4GcCvMLxCpFolgeiWQMIDK1CIox/X6MIserALUsBeHhAlZ58J51yR7HUvKr1hLPBqWw 0Mv2TEPUjNHU6bdGL3nnhepuwmw9VY2uwSJXEyGVvBRNM2k5zFL+zoYgmc4l2Jgtnb1w L9isYjKtV5gFLAWPUJPKhwNsYt1d0P8GRl9MY8eSBdb8b3WtQMONrA7zDMAWLHFr/W4M eGEroQEHTKWN061npKQHqJ+0OL1sRl1aWoBD4/36r0z8Ik3SbJsRb/Rh+CEJAGt7+Apn PnWw== X-Gm-Message-State: ACgBeo3iUF9jtRpWBssHO0H51Y8bDLdU66Bjj1h39GgDkqW+gRa06SuO DTJXIWNRGNU5fo/3AlUA01xV5w== X-Google-Smtp-Source: AA6agR7hK/LtVDTNcW/FOB3ZBLh9ErM5S9vA8oOiKLvSKbz5Ptv+gx5OFqdfNPZpxNBEgxnzgv8Lag== X-Received: by 2002:a05:6512:4c7:b0:48b:29bb:8195 with SMTP id w7-20020a05651204c700b0048b29bb8195mr8347371lfq.386.1660742062364; Wed, 17 Aug 2022 06:14:22 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:21 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 01/12] dt-bindings: hwlock: qcom-hwspinlock: add support for MMIO on older SoCs Date: Wed, 17 Aug 2022 16:14:04 +0300 Message-Id: <20220817131415.714340-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Older Qualcomm SoCs have TCSR mutex registers with 0x80 stride, instead of 0x1000. Add dedicated compatibles for such case. Unfortunately the binding started using a generic "qcom,tcsr-mutex" compatible without specifying the SoC part, thus it looks now quite inconsistent. Signed-off-by: Krzysztof Kozlowski --- If anyone ever says "I want a generic compatible because I am sure all devices are compatible", that's one more argument they are wrong. :) --- .../bindings/hwlock/qcom-hwspinlock.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml index 1c7149f7d171..de98b961fb38 100644 --- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml @@ -15,9 +15,18 @@ description: properties: compatible: - enum: - - qcom,sfpb-mutex - - qcom,tcsr-mutex + oneOf: + - enum: + - qcom,sfpb-mutex + - qcom,tcsr-mutex + - items: + - enum: + - qcom,apq8084-tcsr-mutex + - qcom,ipq6018-tcsr-mutex + - qcom,msm8226-tcsr-mutex + - qcom,msm8974-tcsr-mutex + - qcom,msm8994-tcsr-mutex + - const: qcom,tcsr-mutex reg: maxItems: 1 From patchwork Wed Aug 17 13:14:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB1FC32771 for ; Wed, 17 Aug 2022 13:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239783AbiHQNOk (ORCPT ); Wed, 17 Aug 2022 09:14:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239695AbiHQNOa (ORCPT ); Wed, 17 Aug 2022 09:14:30 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F2B14BD0F for ; Wed, 17 Aug 2022 06:14:25 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id v10so13506132ljh.9 for ; Wed, 17 Aug 2022 06:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=CEQ6kD7E3x3cGbQZ0xWqW+Ktcext0aENc2Q7rleIIpo=; b=ZLW1S4NiQU/zIX4dyxR1JbzzCb9w3pYh1ElEDkry2G49gQQwdoV4ZbBEqfMgLxvwk3 qn+U7LlGYMMHtOuupRnX8wo5BaXQZ/2ZwVjnVyzLnIEYucldFUClvsxpWRN+iETeLROc 3cDiMgCF/bt9aMWhEKVS/XdpDnVf3PlchWidgj0aheh6UxqdZNGDEthcLtIMhjOy+kIR e7b7pEC56l7+71GHun2fdcULFqQ1kKpR6UTQP+eE1SPSEp+UjB0ZTuCl8BMBLmHkGfIB B3kS5jZR+NQJvCcCVOQ1NLmZagOGE+A7fVI2sHna6YocLY8uTFyo+GSzeX70G6nxCuNx 2ZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=CEQ6kD7E3x3cGbQZ0xWqW+Ktcext0aENc2Q7rleIIpo=; b=DG1fZ5DJpRAN4/Borma89E/42aLc9lK4urr0+C029RSDC9Wbx6j9TVzdCUa6J/8Zeb F/jyvGZe7jzwCn4Q9pbVbqifGGTMvU61hUm1KGn/xCpUfuK78kcVvFCcKyY0iJ9WhZyR WeouCOdXNSUMEEjOJtT55H1ahlQtDceRq+Snia0oWhcVkY7rcJranpVBRs1lAvU+E4V0 INQbD/wQzhOMb1huFBCZqmceBNOd5PG1xMIYdGGR4GhHRtZ02lB+C+BVA1O8wxtngLHT Z7qYd0BFz18kLctJbK0L9JuuYkrDyOSbW/5OIIyr6wcPtNFmz/kbBjvI9U4vdOBDSUYz /gCQ== X-Gm-Message-State: ACgBeo02wwZGgrWOZpi8SZCHTgEncAr9GVWhqmOWBiJbC54H/6yKJeN2 G0CEpYVOXYVdFzYXBC29ZDLITg== X-Google-Smtp-Source: AA6agR7KrrzN7b/lcEy++KQc/DJ9TjbfJCRkrrA6FmPSFUqMwZ0dAq5BtJWI5XRcsnwJW3AfxaUL6g== X-Received: by 2002:a05:651c:14e:b0:25f:dbf7:8636 with SMTP id c14-20020a05651c014e00b0025fdbf78636mr8007233ljd.51.1660742063840; Wed, 17 Aug 2022 06:14:23 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 02/12] dt-bindings: hwlock: qcom-hwspinlock: correct example indentation Date: Wed, 17 Aug 2022 16:14:05 +0300 Message-Id: <20220817131415.714340-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Use some consistent indentation (4-space) for DTS example. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/hwlock/qcom-hwspinlock.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml index de98b961fb38..1a3adf75934b 100644 --- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml @@ -43,9 +43,9 @@ additionalProperties: false examples: - | - tcsr_mutex: hwlock@1f40000 { - compatible = "qcom,tcsr-mutex"; - reg = <0x01f40000 0x40000>; - #hwlock-cells = <1>; - }; + hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; + reg = <0x01f40000 0x40000>; + #hwlock-cells = <1>; + }; ... From patchwork Wed Aug 17 13:14:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598192 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36ABCC32793 for ; Wed, 17 Aug 2022 13:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239749AbiHQNOm (ORCPT ); Wed, 17 Aug 2022 09:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239160AbiHQNOe (ORCPT ); Wed, 17 Aug 2022 09:14:34 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 521A34C605 for ; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id x9so13509476ljj.13 for ; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Yg02g9RCBzELEXyS88kfi01jTvYemBxzwaKsyEKanCE=; b=wrxaq7kIOpkPNFTiLpjulwCD7pviXkUQGvHL9K/EVHN5XsO7SN2JLubqS+u9PCcp5v q0vOZVwTtxD1x5mYS+/y7aa68SIKuzE8DZuOm4+sRD0zzLTLLwk488pBr5EicLQAly/1 jQWEu7D26Z+pT4ShEDmBxsziUSiTd288fmynPp/5uP9gitFdW75iasYactInEaasMu40 Nta7yv0NpCMRYB/Mn7lcN2dyUvFyfiPl3H6JMjDbs1ffzgvgDB3K0WXit+xgqIowB3vc QWrwxpvvsgXv9CiWC1iIiMdTEq0DnmfAI4Lee40+6ZyUzN/V8OJ92T9vc5cpgGVP/H+i kYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Yg02g9RCBzELEXyS88kfi01jTvYemBxzwaKsyEKanCE=; b=ezdUvQzaUzTfbb3hkcNxIoBhzB4J1fqRKb0qRurUskdccWZKRZNegbaES7845Hj3fX 2JCMYqaNPmLwGaw1yfQCh84+5xmJ44CkBbWmpj2oZK5yojSosj0TiEK0r2S0h33jAcl0 FyTOeq6JSAzG/IE3K1FEc1UnjH/N5DlGu88I1mFSVGIuh5rr1oRlEz7Yu+b83hh5PmEs hLhsB74Vx9ZCrv6PqQWFmCAJWTdpb1H/LV2iG/2Gm13nb7eAtS/mGF2N0881N2hJe3nY phbi0z7KIeLK3dI38ZnlDA2cTqE5YTjUNYVZLpkbCjCt8JAbkTtZYDMMVPipYfPgJrzq oFiw== X-Gm-Message-State: ACgBeo2HzO2JhykftYJu597usR0CeINfmRH5FvmPdgvy+Hx5i/Z/KJqS vWTLBk8SKdTGxaPqktel+7a6eQ== X-Google-Smtp-Source: AA6agR5uzwpyakQr42iVyz1uBf4J8T2NX3T081uUgaSAx0+liX43Wz9QFyk9NN8TtSGeujw5eecP3A== X-Received: by 2002:a05:651c:555:b0:25f:f134:de3a with SMTP id q21-20020a05651c055500b0025ff134de3amr8354626ljp.376.1660742065551; Wed, 17 Aug 2022 06:14:25 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:25 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 03/12] dt-bindings: mfd: qcom,tcsr: add MSM8974 Date: Wed, 17 Aug 2022 16:14:06 +0300 Message-Id: <20220817131415.714340-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Document new MSM8974 TCSR compatible. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml index e1c4936a0352..e7383dcad83b 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,7 @@ properties: oneOf: - items: - enum: + - qcom,msm8974-tcsr - qcom,msm8998-tcsr - qcom,sc7180-tcsr - qcom,sc7280-tcsr From patchwork Wed Aug 17 13:14:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2590DC32789 for ; Wed, 17 Aug 2022 13:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239797AbiHQNOm (ORCPT ); Wed, 17 Aug 2022 09:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239754AbiHQNOg (ORCPT ); Wed, 17 Aug 2022 09:14:36 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92904C628 for ; Wed, 17 Aug 2022 06:14:28 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id v2so18957605lfi.6 for ; Wed, 17 Aug 2022 06:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=G7nHz7460NiblDwkfaLZP3QC942cYsdIM8XAFA/ajO4=; b=Ux60q81hVODEZ/9jXK6w497/gC2vI3P1tZbdFxdC7xZz26+r69kF7Ay82VhNZborZk L/TqTpH907LPYU7oDzCO2WHPks/3Nt5X5SXUJt65mFu8kNFDwxa2RgNQENDyIenqsVji KO4CkIbSeSKX6cthFiFYToS+bSBV0y1bDXlXjNNZhsJRiAG35W3hnRUoprjD3PZyujeA /w0blmU9lUw5MSxHa/bbaVsvGmEwGq6tl6LuFQgr6OkeFyryD2WmIW+V5OaMkW0rnjGE vWHe0c/ZBQit5GGf5CKS04xciRk1+vWigIp5+kxAiPRRZJNyegN/DGfWEj23co0DWa7J igLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=G7nHz7460NiblDwkfaLZP3QC942cYsdIM8XAFA/ajO4=; b=kkB/pvJA+3tH7y4OyTMQIfRNIvWgTdxOuR4aEfq8gWbvlUIxWnnalcCA6GsQbXvSbA gN59UX8/ecc20BqOjY4t/zyaevgg6L2q4iLubdN1SKCUOzEPetHVW6sUUV9365AcFbYM MZwpEk2pqxi99Mqjd9/nlqoQLLBvuxKt8UHdt3T/VYiOPzUyl3HTvW/jRbCgLP0l+XLZ WWV/ZORov5lIOIKrYuK3weNEeYIvjpvhYBp7q9Kr0oZMhmWuJCPk8gl4QM2J+qg2fpE+ uf9APEthvfN2hEGvZfF2LtSx+VKM5O62ppFQd62JfV9daJQbOBF7NXyeNKH/6KbPPzkj BL8Q== X-Gm-Message-State: ACgBeo16YKZV/WJYykPWOTEyMpsGCvUl4XzoZswmx1vh1kL4IyBJLU00 jEA0KNMby71qRz4KZeWfbyv6Kg== X-Google-Smtp-Source: AA6agR7VvZ0QXXkcR5lT43JZl+4AdD8B89Fw1v6q71SdS7UPGz75Z3tQMAGOjjFa6BZ9G5qRomKT6w== X-Received: by 2002:a05:6512:3e0f:b0:491:313d:5b6a with SMTP id i15-20020a0565123e0f00b00491313d5b6amr6822082lfv.223.1660742067199; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 04/12] hwspinlock: qcom: correct MMIO max register for newer SoCs Date: Wed, 17 Aug 2022 16:14:07 +0300 Message-Id: <20220817131415.714340-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Newer ARMv8 Qualcomm SoCs using 0x1000 register stride have maximum register 0x20000 (32 mutexes * 0x1000). Fixes: 7a1e6fb1c606 ("hwspinlock: qcom: Allow mmio usage in addition to syscon") Signed-off-by: Krzysztof Kozlowski --- drivers/hwspinlock/qcom_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index 80ea45b3a815..9734e149d981 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -121,7 +121,7 @@ static const struct regmap_config tcsr_mutex_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, - .max_register = 0x40000, + .max_register = 0x20000, .fast_io = true, }; From patchwork Wed Aug 17 13:14:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598191 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D3DFC32771 for ; Wed, 17 Aug 2022 13:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239802AbiHQNOs (ORCPT ); Wed, 17 Aug 2022 09:14:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239770AbiHQNOi (ORCPT ); Wed, 17 Aug 2022 09:14:38 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 501564CA1B for ; Wed, 17 Aug 2022 06:14:29 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id v4so253453ljg.0 for ; Wed, 17 Aug 2022 06:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=NUd8YryzxRUKn1lcURqTFfrnvxH9vHeWn1VsvKW9iig=; b=j8crz0TGC0TwfsN5OrJTRjy9ExfL2boMNIiIoZ1GY8DY2Wi8+8b5X5/lv2gqmY7V6o aG0tfYcAOL6OX55fn2TtvZjNbo4cbB98QqLI6hmhHXa0sJFp+4Pd3hGETSYGKooGCm69 i+J0aZOHrU0Gm+Avl9S6OpiDSVZGKzhpbo2W8t4jSJjmP6wfesLIgEK84+vqfZ6B559+ X0gwLCno8PNjo0efY5DtGg0dRn0mtlx988H4zpYMPU3XV3OB7Z1rpjE0ToYiWrO8C3EF 6h4nSwl1PdoWkcuKcYIzDm8rBZdZhVBCMF1EautAoqjbAWO147MRzL1Mp8x0z6ZxSZik H8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=NUd8YryzxRUKn1lcURqTFfrnvxH9vHeWn1VsvKW9iig=; b=eu8yq0/YXRUERRDqQerMbRG1dVmwt23bAHHSE9hTi7A9H/UYeNMoOoVATeDfVPiUF3 uJwsjw/PgJ6a2P8+BZytGspgXjCQckRPIpUPU6abND0YEzBGrZnXdwabnN+sVWM8Ch82 hK13d5ozu1I/lvBPGRTbgeD65UJ3C+/IU7znvxPeugj2qsyUO6DZhPQOheh04uvKpRXV +iks6XVQFRX8npbmKbqRUS+muvp3Y+JrZmVRayRpS7QVuXTLZ6NMZBQWRrn+NYMx9C+0 BPnIpzJ7jQLAKaKPnTVJYSzhR1jjwFTDiWfjOd9LsVTAMZT/N2YdmVFe8QMasneCBQw1 MMVw== X-Gm-Message-State: ACgBeo1MmAiy8U7CL42muqovq/ZwP8F/Xf4LcqBsXKQ8UTbwiGM2GPCW SHCBmM2ND/uFeCGSl3e92alCjQ== X-Google-Smtp-Source: AA6agR4ODr7SKicA1GAKwnAKK/adpoZpki8+XPbXTk8r1Ll36pXGE75J4H1rXOx4tDjMzSsB4QzPbA== X-Received: by 2002:a05:651c:154a:b0:25e:7b43:133f with SMTP id y10-20020a05651c154a00b0025e7b43133fmr8631623ljp.137.1660742068771; Wed, 17 Aug 2022 06:14:28 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:28 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 05/12] hwspinlock: qcom: add support for MMIO on older SoCs Date: Wed, 17 Aug 2022 16:14:08 +0300 Message-Id: <20220817131415.714340-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Older Qualcomm SoCs have TCSR mutex registers with 0x80 stride, instead of 0x1000. Add dedicated compatibles and regmap for such case. Signed-off-by: Krzysztof Kozlowski --- drivers/hwspinlock/qcom_hwspinlock.c | 42 +++++++++++++++++++++------- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index 9734e149d981..9cf186362ae2 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -22,6 +22,7 @@ struct qcom_hwspinlock_of_data { u32 offset; u32 stride; + const struct regmap_config *regmap_config; }; static int qcom_hwspinlock_trylock(struct hwspinlock *lock) @@ -73,15 +74,42 @@ static const struct qcom_hwspinlock_of_data of_sfpb_mutex = { .stride = 0x4, }; -/* All modern platform has offset 0 and stride of 4k */ +static const struct regmap_config tcsr_msm8226_mutex_config = { + .reg_bits = 32, + .reg_stride = 4, + .val_bits = 32, + .max_register = 0x1000, + .fast_io = true, +}; + +static const struct qcom_hwspinlock_of_data of_msm8226_tcsr_mutex = { + .offset = 0, + .stride = 0x80, + .regmap_config = &tcsr_msm8226_mutex_config, +}; + +static const struct regmap_config tcsr_mutex_config = { + .reg_bits = 32, + .reg_stride = 4, + .val_bits = 32, + .max_register = 0x20000, + .fast_io = true, +}; + static const struct qcom_hwspinlock_of_data of_tcsr_mutex = { .offset = 0, .stride = 0x1000, + .regmap_config = &tcsr_mutex_config, }; static const struct of_device_id qcom_hwspinlock_of_match[] = { { .compatible = "qcom,sfpb-mutex", .data = &of_sfpb_mutex }, { .compatible = "qcom,tcsr-mutex", .data = &of_tcsr_mutex }, + { .compatible = "qcom,apq8084-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, + { .compatible = "qcom,ipq6018-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, + { .compatible = "qcom,msm8226-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, + { .compatible = "qcom,msm8974-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, + { .compatible = "qcom,msm8994-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, { } }; MODULE_DEVICE_TABLE(of, qcom_hwspinlock_of_match); @@ -117,14 +145,6 @@ static struct regmap *qcom_hwspinlock_probe_syscon(struct platform_device *pdev, return regmap; } -static const struct regmap_config tcsr_mutex_config = { - .reg_bits = 32, - .reg_stride = 4, - .val_bits = 32, - .max_register = 0x20000, - .fast_io = true, -}; - static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev, u32 *offset, u32 *stride) { @@ -133,6 +153,8 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev, void __iomem *base; data = of_device_get_match_data(dev); + if (!data->regmap_config) + return ERR_PTR(-EINVAL); *offset = data->offset; *stride = data->stride; @@ -141,7 +163,7 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev, if (IS_ERR(base)) return ERR_CAST(base); - return devm_regmap_init_mmio(dev, base, &tcsr_mutex_config); + return devm_regmap_init_mmio(dev, base, data->regmap_config); } static int qcom_hwspinlock_probe(struct platform_device *pdev) From patchwork Wed Aug 17 13:14:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597898 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E46C25B08 for ; Wed, 17 Aug 2022 13:14:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239817AbiHQNOt (ORCPT ); Wed, 17 Aug 2022 09:14:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239781AbiHQNOj (ORCPT ); Wed, 17 Aug 2022 09:14:39 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01A5E4D830 for ; Wed, 17 Aug 2022 06:14:32 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id x19so18962832lfq.7 for ; Wed, 17 Aug 2022 06:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Ye4bqmRVQU/UtyZrgiLeA6KXU6bvQ0m892CxJrKhdQ4=; b=ed6cpMDb8WI+kpHuNPDw3tEHtLzGoeIM7/DhxZ8qY1spbgm2GgkLKM2vYL41UwjWTW Jr9TR0jKQQ5WmNC/Ebsaac+0rh0uwoGkYKo3oiCmJN6xlqoF2bO2Ltl+ci+4TMMgchCU FjSnDVVPFsVUXiiCcbt9tO1SmhcoEjt1SW0ez7B++yxaAZw7dskA50tLPmv+EVyh2vg7 MltuQedxRcmvs4pBtnEZ8xEHWm/RYJHmvWfyR+i2TopkLd8TfOeeCbZGXGYJh7wu+1Hs /1WVWpH11/l7UHlZ+uMA4g/d/7NfcdEaXD97rSId0OpsKfyf+3LM6T3bHvGt1t3I+lzk Whvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Ye4bqmRVQU/UtyZrgiLeA6KXU6bvQ0m892CxJrKhdQ4=; b=vrhPTkwW/WQ87cnSgHwhoKRsu4u74udbXLUqier3/2/LU74pXv9IEMSumCHfBS/sjM PpsuOwCj0FrHFmU7YfgIq5YE6pev4lsFXdjugB3XccklZ5v5i2+h7UkMNQWqOF+50trl 1uQ6xApdOvzf4V6aATG/XnxPnLoBYoynjcjLs3RVNkPmjqnYZiHophYCGuTXtrMW4Pmy oZaNMM6MbpNrO87EomjK6Mabl9wqgjik6ig1K5VATq2fUKI9jj98ZehoR/8V00Oxx6lh 8wnzjVGEplaqH5MJ0pJ41m3z1m/ySKx6/bP4FFm/QNlS0YArtb4LSaMH3tzR1ri1SLV5 gnqA== X-Gm-Message-State: ACgBeo2NpkIdMvAghmyWiRYpLO9TO1IAUaC59lZl2bZktK4ZbmMuC0qi HXyCCj2UKrhVDS4B31d1Zo4Bdw== X-Google-Smtp-Source: AA6agR40LiTC3alpKQxZw8Z8Ahc4i1D+Q9jCLV9rHVJrjn5TH84JSJC2mmd4LlwEX2Gei2nrCKh5+Q== X-Received: by 2002:a05:6512:3047:b0:491:4104:cf93 with SMTP id b7-20020a056512304700b004914104cf93mr6591392lfb.546.1660742070296; Wed, 17 Aug 2022 06:14:30 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 06/12] arm64: dts: qcom: ipq6018: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:09 +0300 Message-Id: <20220817131415.714340-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/ipq6018-cp01-c1.dtb: hwlock: 'reg' is a required property qcom/ipq6018-cp01-c1.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index aaad7d9059f6..ae56fccebe21 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -129,12 +129,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x80>; - #hwlock-cells = <1>; - }; - pmuv8: pmu { compatible = "arm,cortex-a53-pmu"; interrupts = ; }; - tcsr_mutex_regs: syscon@1905000 { - compatible = "syscon"; - reg = <0x0 0x01905000 0x0 0x8000>; + tcsr_mutex: hwlock@1905000 { + compatible = "qcom,ipq6018-tcsr-mutex", "qcom,tcsr-mutex"; + reg = <0x0 0x01905000 0x0 0x1000>; + #hwlock-cells = <1>; }; tcsr: syscon@1937000 { From patchwork Wed Aug 17 13:14:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7AD7C32793 for ; Wed, 17 Aug 2022 13:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239774AbiHQNOx (ORCPT ); Wed, 17 Aug 2022 09:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239789AbiHQNOk (ORCPT ); Wed, 17 Aug 2022 09:14:40 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83C8A4DF0F for ; Wed, 17 Aug 2022 06:14:33 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id z20so13535507ljq.3 for ; Wed, 17 Aug 2022 06:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=pqtLuKgHuRzFaU11WfzhWYMqklF7F2EiVQK9EioMBZA=; b=b1fRqbAJMcp7MUX2FEM9tYc3wbUwUDEQG6V91K9FJXB6NCYbi8D9eNXaJrQ6acEsTz 4FYHfDxLG1IWsEYf27Ra+q3ewylMGr6Xlt5s6AwP0ZZARxJx1qenfuOhtsEvPZIBfhLN JXf9eBsveGFDNDonbR6vec/7MYpWHTOl1UKTNt2VhfOYkmYa0INSFHB9UDbcjsbHepRQ 2Kh4eja2X9Ifz34Yf1mUydYTe5ohxUbtDHiLypPq6+uYugreCR2vA1Exbhin+QsWpAKc 9ddmxkO0Dga2GL8S+R/Zh2FGXM1M+K/W4GEi1n3f5ysqo4If32H3SIPosvL7T+nDU8TX YyTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=pqtLuKgHuRzFaU11WfzhWYMqklF7F2EiVQK9EioMBZA=; b=b99uHbQ/AYprJi4Hx6yUlIQF05aeHVp0ePSm0bN4M27otnX7W0KzJ3AbEiizYKb5Ye oskGnhIqm7den/RzToghsncvnBCZB75BqnOd6O3OJkmPrcZiwTVsJsSJR4P7IG9Q5e6R 3LMVisXTmWSKvL8Cbvn2JFF2XNVqMl75lwt6p+MTfjC/4dKF2mnFhChvjrA+yQmYxa9i oKFoZVt2MbYyOb7+56jS819i9IVaeqVUOm4ETOOQr6q62TKeAItJ0t1/CFIpDTFFUe7A Ex+yXdcjiXCdZI4OkpbsOzcr405QF9mIowS/vqD3oIW3qRx4vUcGCxEAk8TdwRYfHZzb m89w== X-Gm-Message-State: ACgBeo36H4F4DDj7i5uSEtByKPK6wHknSGYmg1rQGBlE8kHQ4fEPWZlE DoaGQwxs/huUDrUAjMaQ2CLJhg== X-Google-Smtp-Source: AA6agR48PdRddyjQg7Y2vLx7jqebiR+4tCUBl5bItx/oMtFmrBED6xdwL9PgJoF15SElq6AQmcJWLw== X-Received: by 2002:a2e:9e56:0:b0:261:7544:d79d with SMTP id g22-20020a2e9e56000000b002617544d79dmr1742755ljk.296.1660742071792; Wed, 17 Aug 2022 06:14:31 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:31 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 07/12] arm64: dts: qcom: msm8994: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:10 +0300 Message-Id: <20220817131415.714340-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8994-sony-xperia-kitakami-suzuran.dtb: hwlock: 'reg' is a required property qcom/msm8994-sony-xperia-kitakami-suzuran.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi index 8bc6c070e306..6a9bca6c2c5f 100644 --- a/arch/arm64/boot/dts/qcom/msm8994.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi @@ -164,12 +164,6 @@ memory@80000000 { reg = <0 0x80000000 0 0>; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x80>; - #hwlock-cells = <1>; - }; - pmu { compatible = "arm,cortex-a53-pmu"; interrupts = ; @@ -762,9 +756,10 @@ spmi_bus: spmi@fc4c0000 { #interrupt-cells = <4>; }; - tcsr_mutex_regs: syscon@fd484000 { - compatible = "syscon"; - reg = <0xfd484000 0x2000>; + tcsr_mutex: hwlock@fd484000 { + compatible = "qcom,msm8994-tcsr-mutex", "qcom,tcsr-mutex"; + reg = <0xfd484000 0x1000>; + #hwlock-cells = <1>; }; tlmm: pinctrl@fd510000 { From patchwork Wed Aug 17 13:14:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93169C3F6B0 for ; Wed, 17 Aug 2022 13:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239825AbiHQNOw (ORCPT ); Wed, 17 Aug 2022 09:14:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239787AbiHQNOk (ORCPT ); Wed, 17 Aug 2022 09:14:40 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF9254E630 for ; Wed, 17 Aug 2022 06:14:33 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id e15so19013966lfs.0 for ; Wed, 17 Aug 2022 06:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=6hkmj/RZGZV2ubSm7Y6EYAIQdJcarVin5p0NjjE8aKM=; b=LuJ/DuHx4XaFQtsZbUlL5O+XQwKTuYuMk1wiqb2amgN7AammjIOHIC0tBnk4Wys2Ea PIFR30NaUfWwcbUKlW0Cn7JUiQILZXgSb7N4S0M5y3CYgFbmVj4IekoVv4rMmnPUp8++ VFOvVJV8pSa+Kf+lKGjc03HE62HpnYzTeAtq4Ukp4tfcgpqYBsV18zQSHSJ9vBbCov0z uxEM/UwcXaIYlLxJLzFXFZTC08y5t45MuJkCHEHxHzu/W07vV0jqz5S4Zo748TYDibyz HhjwhTQxCCw8Jry2oJUV3JALsJMo2em/tfd7Wf+qy+4kWqQe7czpjwF3Y3W2bbD8SgKM 3DTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=6hkmj/RZGZV2ubSm7Y6EYAIQdJcarVin5p0NjjE8aKM=; b=6oOkSlyVWx3Sz7DAVaqvkrsaVWFjVYphfm5n//5MNy1q7i27aZSuyvcSTz3tK8X82O EeHt4qSAF6QyHWdqD57f80S9fm8csStlMk6BKm2UCO1Gim/9j3hNGRhYl9NB4g73e6Uw JUSlPdUVB6Y1EWqYHEXxCHJMnyHjpL7Rk0o5XmTKQyTAEdq0k5GKSwni+PARNDE/fO1F Xv4iKzQMWvwGBnPYZ+tOphPaeb2yO9FixPjioIi1JWDEhW5RJyN6XQJ7bGs94oX+9RID LzIm7XdnLciZsJjiaBAzv5iI98GcHnC9qRf09AklhnngunxfKVwb06SnxlltWGvxc+He aumg== X-Gm-Message-State: ACgBeo3YfcHVPkFbftAAWiXdAq5SauTu/1EBs5GOG89U1gRh1SPxWs0s wkldbHVHz1RYHpCb02sowk7nJw== X-Google-Smtp-Source: AA6agR6uz6PgHJJgHSkUYGIHiHszn0Dz+54GDEd24Jx76kQfPHB9W+lxiMZ+hmy/E2YYJ90MXmVbyg== X-Received: by 2002:a05:6512:3e1b:b0:48b:6ae:ce4d with SMTP id i27-20020a0565123e1b00b0048b06aece4dmr8496799lfv.142.1660742073304; Wed, 17 Aug 2022 06:14:33 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 08/12] ARM: dts: qcom: msm8974: add missing TCSR syscon compatible Date: Wed, 17 Aug 2022 16:14:11 +0300 Message-Id: <20220817131415.714340-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index 8baca2a77717..0a9f252c88a7 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1234,7 +1234,7 @@ tcsr_mutex_block: syscon@fd484000 { }; tcsr: syscon@fd4a0000 { - compatible = "syscon"; + compatible = "qcom,msm8974-tcsr", "syscon"; reg = <0xfd4a0000 0x10000>; }; From patchwork Wed Aug 17 13:14:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A852EC32796 for ; Wed, 17 Aug 2022 13:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239195AbiHQNOz (ORCPT ); Wed, 17 Aug 2022 09:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236789AbiHQNOn (ORCPT ); Wed, 17 Aug 2022 09:14:43 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B923F4F679 for ; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id x19so18963118lfq.7 for ; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=xXYhGBIEDADNPaF7FntsO5+CaYiCK5EMt2dAgswIP/E=; b=rfesmkR/Z2XkW9U5Ai2BIS8LVP73UN+425tKrx0cDTW1zqLqT2gXDM078/lW9QV2yI sQG6qAJgYSZUG457LxgdNYYIuMkNQq2Za3JQy/YETZEYWpLvm37fPk9RtQlnG4X0V0dK TW066pA7XnpEPtQ1VV1538t+W8+9k4l5WpTNDQpglqG1FRuGBVvBFp43qjaB5IH8sBf7 /JQ9csPnIN4J6v5N5ljLmSk3hCycOvauDqM6gBbkoyOqFswbH9BgtcKwiiWVJ1VwyGT3 KUGbmquXwocSJD4TjlGNAOvzw4v7tG5i7B5vjjJoCY+NAtYpaFy0pSVR5FvRuRxWlByI tFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=xXYhGBIEDADNPaF7FntsO5+CaYiCK5EMt2dAgswIP/E=; b=QwMuGinXHumt3MXUtzUAqIm2cwekuxnHMQrQd1sQYy80QGqbz0wywAifdZgE4SkxOd WEx5whg43zhgtpshVqdwqKAGpmWDdcGxwfYkE5pjPDecCxn9b1EZXM472OEFS6skZUh6 AKrKE2cTn+dV+4nviocOR0bgPxzO1UepA3UkRX5al/q1iPdnqPwcy6foS1entoT/BdVR u+MmM2Q/D6aybQ/yWUfMYmRZIs9Y7b0I+uEi+ILjxujVKg9BTWcie7E/T8nSHNnf+vEj lYzaXKBEpd90n6P9ZN0UcszcYFpYfoXonmaEBv5EJp1bB8y/CCJwBp4lgdAbrwbBKk6H 0T7w== X-Gm-Message-State: ACgBeo1K9tnFb/U5d1ra7Lt6SG6REJUDzpoWfwQNSG6GCXHyiswniPRN Efh6YXw94+7iC99V3naDVFe21A== X-Google-Smtp-Source: AA6agR6PDcGKSl5yiOIktlWZ0jUH6eEYd3ChNN0RAz7S7jfXE61WPqYwgJ808qhJjFJUkBaxmtwcow== X-Received: by 2002:a05:6512:2611:b0:478:da8f:e2d8 with SMTP id bt17-20020a056512261100b00478da8fe2d8mr8444745lfb.460.1660742074843; Wed, 17 Aug 2022 06:14:34 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:34 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 09/12] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:14:12 +0300 Message-Id: <20220817131415.714340-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 2 +- .../boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 2 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 11 ++++++++--- arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts | 2 +- arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 2 +- .../qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +- 7 files changed, 14 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts index 3051a861ff0c..2709a99e5c4c 100644 --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts @@ -38,7 +38,7 @@ &otg { status = "okay"; phys = <&usb_hs2_phy>; - phy-select = <&tcsr 0xb000 1>; + phy-select = <&tcsr_2 0xb000 1>; extcon = <&smbb>, <&usb_id>; vbus-supply = <&chg_otg>; hnp-disable; diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts index ec5d340562b6..5fd94dd6a427 100644 --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts @@ -251,7 +251,7 @@ &otg { status = "okay"; phys = <&usb_hs1_phy>; - phy-select = <&tcsr 0xb000 0>; + phy-select = <&tcsr_2 0xb000 0>; extcon = <&charger>, <&usb_id>; vbus-supply = <&usb_otg_vbus>; diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi index 5a70683d9103..118b231f3137 100644 --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi @@ -136,7 +136,7 @@ &otg { status = "okay"; phys = <&usb_hs1_phy>; - phy-select = <&tcsr 0xb000 0>; + phy-select = <&tcsr_2 0xb000 0>; extcon = <&smbb>, <&usb_id>; vbus-supply = <&chg_otg>; diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index 0a9f252c88a7..4b602410d72a 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1189,7 +1189,7 @@ remoteproc_mss: remoteproc@fc880000 { resets = <&gcc GCC_MSS_RESTART>; reset-names = "mss_restart"; - qcom,halt-regs = <&tcsr_mutex_block 0x1180 0x1200 0x1280>; + qcom,halt-regs = <&tcsr_1 0x180 0x200 0x280>; qcom,smem-states = <&modem_smp2p_out 0>; qcom,smem-state-names = "stop"; @@ -1230,10 +1230,15 @@ smd-edge { tcsr_mutex_block: syscon@fd484000 { compatible = "syscon"; - reg = <0xfd484000 0x2000>; + reg = <0xfd484000 0x1000>; }; - tcsr: syscon@fd4a0000 { + tcsr_1: syscon@fd485000 { + compatible = "qcom,msm8974-tcsr", "syscon"; + reg = <0xfd485000 0x1000>; + }; + + tcsr_2: syscon@fd4a0000 { compatible = "qcom,msm8974-tcsr", "syscon"; reg = <0xfd4a0000 0x10000>; }; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts index ff6e0066768b..c264d17e0953 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts @@ -89,7 +89,7 @@ &otg { status = "okay"; phys = <&usb_hs1_phy>; - phy-select = <&tcsr 0xb000 0>; + phy-select = <&tcsr_2 0xb000 0>; extcon = <&smbb>, <&usb_id>; vbus-supply = <&chg_otg>; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts index 983e10c3d863..2691a6dbbb8b 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts @@ -379,7 +379,7 @@ &otg { status = "okay"; phys = <&usb_hs1_phy>; - phy-select = <&tcsr 0xb000 0>; + phy-select = <&tcsr_2 0xb000 0>; hnp-disable; srp-disable; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts index 3f45f5c5d37b..d2bef3896c82 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts @@ -216,7 +216,7 @@ &otg { status = "okay"; phys = <&usb_hs1_phy>; - phy-select = <&tcsr 0xb000 0>; + phy-select = <&tcsr_2 0xb000 0>; extcon = <&smbb>, <&usb_id>; vbus-supply = <&chg_otg>; From patchwork Wed Aug 17 13:14:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C63DC28B2B for ; Wed, 17 Aug 2022 13:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239683AbiHQNOz (ORCPT ); Wed, 17 Aug 2022 09:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239804AbiHQNOs (ORCPT ); Wed, 17 Aug 2022 09:14:48 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBC4350700 for ; Wed, 17 Aug 2022 06:14:37 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id u1so18965579lfq.4 for ; Wed, 17 Aug 2022 06:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=zKHY3dCKJ9MBQUb1nFG5BJ8dnmo7NmfzmU7KoX4k/sc=; b=I7ZGQFpT7TyHMGcPOTq3gyDtAPS8zEGPd42TBrWTkjoqhrt3akPHiIf+w4B76q3aiU 3XI+IhkIVY2r3Iln2cKulCNu3xUaNftz1cSQrvJOifhtA316/9klkiyve6BFAPV1d6VY 7IU70Xb7QNLpKjEkw0Nwv2vr5dKAB23qe8xhrOtM2iIFHG8JPHF0X382o+ioejbk7DZe VPknovP886k8IVr78GTWmL/eyPg7VtoMZjCn9JTn9iGnbCgPfwiGaZlMQqHoTFGdyKMM 9sE2tpSW5DcEJvjaVVBPzOadXu6W0EVGWoaIjpd26RlNBHHvh1EM8vjudDsaBcJ7XFrF YHWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=zKHY3dCKJ9MBQUb1nFG5BJ8dnmo7NmfzmU7KoX4k/sc=; b=eYtKsNSyzgAOxXo91HPhFlJlacIkv9sz5tBk7eNHWsOIwhsGWbo+4/ySMUi4XvYa+o zbomSGA+7UyB12S2dzS/agoF0UoifTboJqwMyQqmjH7fGL9nPxvEk4spQHmuOcoA7MS0 6ZBUzbtpMQPcZPKmdfyGUL6z5BU9itqQgECMwTZLJxeKUfZTFli6h/vFPaN4jUUX6OxJ X0xt6rNzpbSvPqwMuxuNAN2X2nBwuVWcC6qqSTvlkMDYjeYqTCGH6oj06DWQRk0oxzlN V80veqcw6OnfTi6UMvtqfWlwgr9beA4oDlpST4au4L/9BD33D6j93lAL36ofjCqEpQLk y0ZQ== X-Gm-Message-State: ACgBeo3fwMzseXVuD01QXy0ecD6wwOaJpXLxXE9k+2LWVr073fwbm9PW cwKUYWB2XZwXgYOdntNybmYYQA== X-Google-Smtp-Source: AA6agR5XGF47v4qdgMgUliUXwW/xR14w/+9RDtpKsUFcdZ7p+r7vapl4D4EGIFCR+LZwwiSCgS0Epg== X-Received: by 2002:a05:6512:32c5:b0:48b:969a:9c24 with SMTP id f5-20020a05651232c500b0048b969a9c24mr8389425lfg.300.1660742076344; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:35 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 10/12] ARM: dts: qcom: msm8974: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:13 +0300 Message-Id: <20220817131415.714340-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom-msm8974-sony-xperia-rhine-amami.dtb: tcsr-mutex: 'reg' is a required property qcom-msm8974-sony-xperia-rhine-amami.dtb: tcsr-mutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index 4b602410d72a..5f674aa819ae 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1228,9 +1228,10 @@ smd-edge { }; }; - tcsr_mutex_block: syscon@fd484000 { - compatible = "syscon"; + tcsr_mutex: hwlock@fd484000 { + compatible = "qcom,msm8974-tcsr-mutex", "qcom,tcsr-mutex"; reg = <0xfd484000 0x1000>; + #hwlock-cells = <1>; }; tcsr_1: syscon@fd485000 { @@ -1719,13 +1720,6 @@ reboot-mode { }; }; - tcsr_mutex: tcsr-mutex { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_block 0 0x80>; - - #hwlock-cells = <1>; - }; - thermal-zones { cpu0-thermal { polling-delay-passive = <250>; From patchwork Wed Aug 17 13:14:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B57C25B08 for ; Wed, 17 Aug 2022 13:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239792AbiHQNO7 (ORCPT ); Wed, 17 Aug 2022 09:14:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239805AbiHQNOs (ORCPT ); Wed, 17 Aug 2022 09:14:48 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98B1851A00 for ; Wed, 17 Aug 2022 06:14:38 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id z20so13535766ljq.3 for ; Wed, 17 Aug 2022 06:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=uXLJl3ZPkfkVvmcRHOHOBnFdkGCya/Ew5ljctJGYsvo=; b=LThxqa07rs/MPV48N0w8kXoiodIcyMBUsQNqxCs/gH3PFDrVGh4PWvL+NXQ+nCb57O wAz+p0MPwvBqAaSenCoapEcgKSxAK4WxYxuOY8y7fN5OQ/on66T8Pn0htKijnE8VlOGk t92RgTzAKkzFe9Mf7ynXFlzG8NlkoNhFLWb3mtkbw3jK4KQiqRiC2bbnWGiHNXGgZ1UV hy3cRXR3fILbUgxgXio6ZFXJz/lf3m6FYOqW9wHLkTA5PON0V19ZEyj1HIomI5hx0vpT 7af9bPe3+VsZ6kxSFqSUmdDjv9Ive3oZ1ezAvw9PSQkJNqngxlD3PEvXXkMTgq5WGR7y Sd6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uXLJl3ZPkfkVvmcRHOHOBnFdkGCya/Ew5ljctJGYsvo=; b=7lX2zcmm2hGmEaBkz1YJ4Z0UtRULIKkq8rIVAkJ8VUjAyZDprt3qQAABDkNzUajYRQ 87XJpaYPR/LONS6zlnVXJsX8+WziLsFuwX6pb/w/cIwkvVeGlOR6Hp5luobNza7N5Clw Fa+3ElELRarmuzAJo+8aPbflPE6MtQvVYu/sb7sYq/Ag8zJq5wmxQN+Rpww9cQSrKfCR hrurS3vr6LLYC4DRYLrjQYLRllN9QP94OfkxtNxg76RdpigG1bidwHNLr9xBaJsQM/9u AJqHTU+PSFZ2yvTIxjJaEfcCzu0P2hTP7hlA6ID57YO/vOXQpuy3BeTH0SIBTZ7E/kDK pQKA== X-Gm-Message-State: ACgBeo3QcRPEIHcRpbL8Pn0UT1FLTRyv1OXiD5KANz1atc61fU7/hDrw mQ+NCKDr5e0gw2AcYTkftyUoCA== X-Google-Smtp-Source: AA6agR4jh/QK3ONB9rVZSBJuYOsHWZBBWf+scOCDnCRRh0UN+NM4NdTkZ2qEXGMavvmupaishF7GOw== X-Received: by 2002:a05:651c:2212:b0:25e:cc38:a1dc with SMTP id y18-20020a05651c221200b0025ecc38a1dcmr8545043ljq.359.1660742077891; Wed, 17 Aug 2022 06:14:37 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:37 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 11/12] ARM: dts: qcom: apq8084: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:14 +0300 Message-Id: <20220817131415.714340-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom-apq8084-mtp.dtb: hwlock: 'reg' is a required property qcom-apq8084-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-apq8084.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi index 72f9255855a1..5e07255fe5ea 100644 --- a/arch/arm/boot/dts/qcom-apq8084.dtsi +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi @@ -383,14 +383,9 @@ gcc: clock-controller@fc400000 { reg = <0xfc400000 0x4000>; }; - tcsr_mutex_regs: syscon@fd484000 { - compatible = "syscon"; - reg = <0xfd484000 0x2000>; - }; - - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x80>; + tcsr_mutex: hwlock@fd484000 { + compatible = "qcom,apq8084-tcsr-mutex", "qcom,tcsr-mutex"; + reg = <0xfd484000 0x1000>; #hwlock-cells = <1>; }; From patchwork Wed Aug 17 13:14:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598188 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89155C32772 for ; Wed, 17 Aug 2022 13:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239126AbiHQNO5 (ORCPT ); Wed, 17 Aug 2022 09:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239770AbiHQNOs (ORCPT ); Wed, 17 Aug 2022 09:14:48 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C823051A19 for ; Wed, 17 Aug 2022 06:14:39 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id l21so13536400ljj.2 for ; Wed, 17 Aug 2022 06:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Yb2tg6NLcz0SjyT+zhbpZCCAWG7Bnyw4PloKDdxoVAU=; b=StgnaHhGCg7OOpqTG13+gQqRFOCLdTRA/VCywEDqg9kMIxRkqhIjEL6/unZNraETkB OY78slefTO6VmDzp97WDvD8kTArUqhb1NLsuK7dpIINzEiwMK1YWNK9g8TqUfbVweYMm FIgJ0b+KVQtMsadPvgTAwA26rnWXysiwVIdai5xvQ4DdVGOA3ClgjDb5I0IEcgQ+Gv1U pyhxFEJkeL2O6+cfBaxxXSVEhe4+VnOd7U8+etGNUDTddXn7jHg1/sKyJW5B3MseCKzD NP8IjoOxxroQY3Y1ne8qNUgojmtamVj7SkkIGcdYG36ye/FMasRKQE/ytP2+enkQueNs RdtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Yb2tg6NLcz0SjyT+zhbpZCCAWG7Bnyw4PloKDdxoVAU=; b=xGnFAtkst3r1nvyL0CsPBsuJbnrtHn1hhJrUbwCoudAP1XN/0McyTkxUKI6H7pK/Br 5IPHD4WsWu2ZDpZ5tGeYgdEVPNpKRxMFVogRMeXeMfzaDoLtaWa1d9sKZYNO9wWZA7fX 5YUsnAue2Jf6bomlywIEpQonLVdLY+JndInVWUT/5FaGFSTOvpqVGihZsEkR6yjdBoyV vlxAXznnqnFNiGutKvLdcGDhdJm5GumI2LTDyG575nWlAja94EGIKWd68GzX3aYcaz9x K9HdWbTmwVD747hKCCTIu6disgvtGSYg63pOBnmWUnPSN+Z4baDPhUzxgkXCWC/hqmS2 GmWQ== X-Gm-Message-State: ACgBeo0v3Lor0E3PDFKg0dp/oWIBSCnOaG+wjCvmt8/9N8wfCFt1QHZO adA3RF2hCltpdD/lnMRmxqY8ZQ== X-Google-Smtp-Source: AA6agR4Jr9dVJN0cBFc7EFaxXfsdQSVgqEaGe2HDLtNEJ6H2epeCLVj35rKOvxNYeo5RnnOoO2U2wg== X-Received: by 2002:a05:651c:10d2:b0:25e:5a65:9026 with SMTP id l18-20020a05651c10d200b0025e5a659026mr8217403ljn.193.1660742079394; Wed, 17 Aug 2022 06:14:39 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:38 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 12/12] ARM: dts: qcom: msm8226: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:15 +0300 Message-Id: <20220817131415.714340-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom-msm8226-samsung-s3ve3g.dtb: hwlock: 'reg' is a required property qcom-msm8226-samsung-s3ve3g.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-msm8226.dtsi | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi index 0b5effdb269a..efb5d1edc3a8 100644 --- a/arch/arm/boot/dts/qcom-msm8226.dtsi +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi @@ -44,13 +44,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_block 0 0x80>; - - #hwlock-cells = <1>; - }; - reserved-memory { #address-cells = <1>; #size-cells = <1>; @@ -508,9 +501,10 @@ rpm_msg_ram: memory@fc428000 { reg = <0xfc428000 0x4000>; }; - tcsr_mutex_block: syscon@fd484000 { - compatible = "syscon"; - reg = <0xfd484000 0x2000>; + tcsr_mutex: hwlock@fd484000 { + compatible = "qcom,msm8226-tcsr-mutex", "qcom,tcsr-mutex"; + reg = <0xfd484000 0x1000>; + #hwlock-cells = <1>; }; };