From patchwork Wed Aug 3 08:51:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "niek.nooijens@omron.com" X-Patchwork-Id: 595492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6E5C19F28 for ; Wed, 3 Aug 2022 08:51:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234682AbiHCIvY (ORCPT ); Wed, 3 Aug 2022 04:51:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234300AbiHCIvW (ORCPT ); Wed, 3 Aug 2022 04:51:22 -0400 Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on2101.outbound.protection.outlook.com [40.107.114.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE8612608 for ; Wed, 3 Aug 2022 01:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z/QuwnH/cM+SCJMWeNTuXPodEcf1ft7cDb+1h11k0R8yybXCqJpEEmMfxFX9vFEkCVfUIxFWSf8B/r2xc7PkrGGgLKzeG144KJHT3lnE9pLFraha6e0FMU5AGibxAYwY7mLk195sp+vhWoTMLkbaqhjyVbvFXnHKjskfQEU0l5LY6+XhPA924VfVYKEZiPYZfgv07g6aui2flYS5vuJHcZuLsJ5d1e9LeqtC6/q4OEVkCpEtFXvBEk93CI+TMqd8NLvoR7tQfz3aYCWYZBTjNhpplCio7eVMd7eTDf3PFhlzF2QXaO4YQAg+GCFOn92g7/vL/vrHwFBMbN3M4zB13w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IvgVpHWbf9z84RYrkcunQ0oMdYlpQYx/20dX/Q+6ET8=; b=FUbY7iV/kQcEo6JOrMsZCM2Vk/rFiB/D4f4x5p1oY6X8zK31yR0pnjoiu8ZZr6SHUJVwCR64zV24Ztx4bzxlxfu9583b3Ccwyzff5argCSXohk4kKehNyf4pvAJFhXXshuhACquybVCRbTOqDdQM54jrxtDneGF+KI2nIYVJD/jyHgFrT7vnIAu2eWxg9zF5LSBR17NUh+NCwvJBHTRS7frKgERmWV9J3kdKfPQjjAopWEYkuLVLCR7XGfGIUbuOyRsRUgX0zwi29Xf95w5weDXoxYzIJRPadh8S5zrIGKTQnxw5/G+1uwQrC8RjVmo4EN6VkKQoUY+tjHKyZjKrzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=omron.com; dmarc=pass action=none header.from=omron.com; dkim=pass header.d=omron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omrongroup.onmicrosoft.com; s=selector2-omrongroup-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IvgVpHWbf9z84RYrkcunQ0oMdYlpQYx/20dX/Q+6ET8=; b=PGHKcIdRV1tRk4e+e7y/QA9rhqNSq6qlR66JDIuawNPDdVdgLno0Vrgp/WBU36iRtUPj/jwMfuLgfuhMi1YubajaDNZGvlhvhm9pZGvdgPK02wyWNyYv3h9pEcbWEkJFbNzxwnNdBoAPSBR8G4Kns93zaJ2dNxUure4B00RN2TY= Received: from OS3P286MB1495.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:17a::14) by TYAP286MB0267.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8041::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Wed, 3 Aug 2022 08:51:19 +0000 Received: from OS3P286MB1495.JPNP286.PROD.OUTLOOK.COM ([fe80::7db4:7d6a:44a9:3c0a]) by OS3P286MB1495.JPNP286.PROD.OUTLOOK.COM ([fe80::7db4:7d6a:44a9:3c0a%7]) with mapi id 15.20.5482.011; Wed, 3 Aug 2022 08:51:18 +0000 From: "niek.nooijens@omron.com" To: "linux-usb@vger.kernel.org" Subject: Fw: Linux kernel patch for Omron CS1W-CIF31 Thread-Topic: Linux kernel patch for Omron CS1W-CIF31 Thread-Index: AQHYpYQpeHo/T0XtKkaEwRn86yCTuK2c084AgAAGRaWAAAco+w== Date: Wed, 3 Aug 2022 08:51:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=omron.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3091f807-bf1f-4a2d-1314-08da752d552e x-ms-traffictypediagnostic: TYAP286MB0267:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0QVbUP0GPEPxmJCFKnHUm6wRtrcrnTqOVF032DqJA/M/RBDTIImJIgoHntAW2XSwwVvLiF2b/5vss5OQ/+c0l7x+ft3zfJO3FaRX5zRyBsJvd/nh6qIE5xowXh2/pRHsyvIXQ2lh0Q6Mlq2RV52/XyLjWhS0WZdq7TbImddi3FUXioxSr0D1vnDEFcHAscUq1NS6zPKCyMjG/Idk8/2wHq3ZIwp0Cy0yQYeqqWCRTaPDXNDwBHXaLPUpcsx7dSyNlg4wsHdELcpPbgxNG+g7MlO+O5lvllkQ8VoEryVbtlD/Bc6m81k5DR1tyLMwqMfvDWf8h346qbAxbIAj4SRavYnytz/ajvMjqzqozXq+ptNeIcDjpLUpkqSnJ8+mLw/v4BS5+QJR8Hu3PPVeMirXshvAKs164c3BISEdYZYkNi/W2bbakFcW229y6UwLUyAbaOlEBnCcttkuGfm0geev02wpQxLUvYXT7LVdgaRSr3oQdqsepBftDL/qIBlBRtA1IrOIQ5aSoiu1nvTRMBaqkRaZng8RTuZOHAph4I/DT9x9Q2PJb20x4fIl0+f/XKrBn0tEwaOoX08l0NDc2eSqNkEZ4udT9eJqGKmkK/K9GhBQSn/ELlKzR2BTo1fOU89sVxof5P/jwxwqfRT+FPZnTXVa2eywWsfrqjHU8gNwMmYLcnM9ybLPW1Tsur9a6pAs933d/nqTNFWBvX8YJHz+W7qKHw1zNk2kDcJIS/jDZjFnkcKKgm1LoVs7Fjo99sNomxGpFbmlVQAJ3Pkr+CCBHj57QS4EABRq56BlwDaJAAiMw4Sok1ivtT1670hCj/v6n/jwDVl00pXQzCsp5dkou8YwVFglIMMuoTLmt25Vy+25T481x4op6vtfkAX3WAciE6NbSbLqUo8+B8zV8lbAXQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3P286MB1495.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230016)(136003)(366004)(39860400002)(396003)(346002)(376002)(316002)(5660300002)(91956017)(83380400001)(186003)(52536014)(8936002)(8676002)(66946007)(64756008)(33656002)(66556008)(66446008)(76116006)(2906002)(66476007)(966005)(71200400001)(478600001)(45080400002)(2940100002)(53546011)(7696005)(26005)(6916009)(6506007)(55016003)(41300700001)(86362001)(9686003)(38100700002)(122000001)(38070700005)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?y2pKz4CQPqwCD0c84CTOG6agFPum?= =?utf-8?q?hdPyYC9/6WxH2IWtRdWvoHUsG0HRkXEX+hRZgs/WJqi4qB+OrmM6tAqjItH7P9v+i?= =?utf-8?q?bdxzthb/yzI2cdyAzKzl8Cbn1E9Y6MSsTor/jbZtYXIwcNKTbBUgoKLgM4RfZ4YpA?= =?utf-8?q?LJUGQq/OkrVcx9YjSNtAAsN7CZJhTp1Vrst5j6zG6+LJhZ0xP1iZliV/kGMdK8H7K?= =?utf-8?q?uwSre9PyOUAX26BH9Tar57Nb0W3l/a5n188qlMCJBqxVI2tXS7/9u7KXk8U3R1NvZ?= =?utf-8?q?uxJL/WBHqlvDJZ6E+q5d8Vl0h1fHaAvmH+g+jV1GXGuGbUr+RhtoB6xAM2LupURQp?= =?utf-8?q?U+7nbpcpLfggKJhOVYbR0X+Pu8ZjywU1xMCk9z1HLf+1elUPaAko2sUyYaDtLtQxh?= =?utf-8?q?Tzpc3qEm29NEkB68cPGXuqoEdQzVOb7tlNakpA5EOatCznYn1/TAcJR7haQrObLdX?= =?utf-8?q?hB6rme7XyrcFNEowtR1B+GQGmqTssgd4MXqmZmbJN0TlE1KngpGH44dcE8HvVpc50?= =?utf-8?q?h3qr+Wd8B4c3qQu/GCkw6JCvcGLsME8nPvjdKU01W0YMOwL2zK1PcYJFYsm4byQax?= =?utf-8?q?Lb6pAqXo33rqPF/CoSw0nJXjhrJNCcvj8IXwdhLIMZE/8oSjp3HiU6WBlUkmO6xxE?= =?utf-8?q?rpR7yPXVIbbHLDcnlRBAxTw7T67gLNsUD+7xqd8GFA2hTKNjphyRnLo73uFQTsBJX?= =?utf-8?q?yOKpYKKQjrnHcMzS/kzHgXqsdWdCxpJllkSWJD2ZQ8xCuLvuY2QfDJ5hXczqWxqHQ?= =?utf-8?q?WwPJPWTaZ7k3HLi5+LO330inrtiVGTVRmwBFW5KQL49EVwYGCayak/hO2pOH1nr62?= =?utf-8?q?HIYT7SAKETE+yNjO4ph/mOtKNtOaYafGfw9KkMgVExzc4LmxBaZWs1Oop3OGLfpDr?= =?utf-8?q?dDQEwvl/ESsJI22r5/8lDkIuxOVEP3UTt8k1E5DB2lXdxWPNgLNVChmnoek46a9XK?= =?utf-8?q?U2snMtLNluUv2rZDDtSJabSHUS8L/Rp+gl2J1mwDYOn2z/XbDsg2dsxSWsmC1Nxlz?= =?utf-8?q?0fBKA+I1yn1+gVnyDswH0paqeYKzFhfSmgS694P10YHr840KTvlcQgQ7qmBjfept5?= =?utf-8?q?P8rJO2AP78bNb/7wpTtrqbJ61uMgSpQIx6llmlDK9PrAX3kP1Q2QX+nKv0lazlM7B?= =?utf-8?q?REz8drmwSLv5t3HkCGF3ON8d38HNcMNOQKjadSWGQTCXtOSF8qOEjF/JCaJN9V+al?= =?utf-8?q?SZgF4q9MOlZCLgC2ke69B53W6ZMYM6ELW++CO+WUKMskv+13GiTyh4pkvSl5wlEto?= =?utf-8?q?rZIx24Y0TZBoA1qxbhLAoIFIjUyajUo2jJ4XFuighR6Qz+1/8NDhdPv+3qPXm6mwy?= =?utf-8?q?w/TNxu1hiXCnKFginPegSGvkbFsquFs4A27yklvTR9893ubEDdDFGZsbuFVxDawZO?= =?utf-8?q?2vD++G9ukVF/83aTg6E1vGCtyjlhqTnLtw0taq1OkWL1vVA5RLaAtfRnhShThKLwZ?= =?utf-8?q?h4Uh6D72MzBh8maMNes5owfaxUtFUUEso8nQrjNVKddFFkaRO1qzTFagU/WpmrX/6?= =?utf-8?q?+jhNeLAgeu78?= MIME-Version: 1.0 X-OriginatorOrg: omron.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB1495.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 3091f807-bf1f-4a2d-1314-08da752d552e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2022 08:51:18.9251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0ecff5a9-4bef-4a7b-96ec-a96579b4ac37 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xaBwaflqLA+XcHaIw7qOxO+MhPA0Mi/mozmMIOZfaHQIAeTY9ZS7eS7s+LYn3zxFFLm8dqUS9XbXDyHyzlGK4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAP286MB0267 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Niek Nooijens / IAB Sent: Wednesday, August 3, 2022 10:49 AM To: Johan Hovold Cc: linux-usb@vger.kernel.org Subject: Re: Linux kernel patch for Omron CS1W-CIF31   Hi Johan Thanks for the feedback. I updated the patch and pasted the result below and in https://github.com/torvalds/linux/commit/03c572442d10dc88f7c50b9ea957894ebf702c84 scripts/checkpatch.pl states "0001-USB-serial-ftdi_sio-add-Omron-CS1W-CIF31-device-id.patch has no obvious style problems and is ready for submission." git-send-email doesn't seem to work unfortunately. So I'll send it in plain text this way. (I had outlook web clear all formatting). If I can do anything more for you please let me know. Niek Nooijens Software Engineer Omron Manufacturing of the Netherlands. ================begin patch================ >From 03c572442d10dc88f7c50b9ea957894ebf702c84 Mon Sep 17 00:00:00 2001 From: Niek Nooijens Date: Mon, 1 Aug 2022 10:39:25 +0200 Subject: [PATCH] USB: serial: ftdi_sio: add Omron CS1W-CIF31 device id works perfectly with: modprobe ftdi_sio echo "0590 00b2" | tee /sys/module/ftdi_sio/drivers/usb-serial\:ftdi_sio/new_id > /dev/null but doing this every reboot is a pain in the ass. Signed-off-by: Niek Nooijens ---  drivers/usb/serial/ftdi_sio.c     | 2 ++  drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++  2 files changed, 8 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index d5a3986dfee7..52d59be92034 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1045,6 +1045,8 @@ static const struct usb_device_id id_table_combined[] = {       /* IDS GmbH devices */       { USB_DEVICE(IDS_VID, IDS_SI31A_PID) },       { USB_DEVICE(IDS_VID, IDS_CM31A_PID) }, +     /* Omron devices */ +     { USB_DEVICE(OMRON_VID, OMRON_CS1W_CIF31_PID) },       /* U-Blox devices */       { USB_DEVICE(UBLOX_VID, UBLOX_C099F9P_ZED_PID) },       { USB_DEVICE(UBLOX_VID, UBLOX_C099F9P_ODIN_PID) }, diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h index 4e92c165c86b..b99714c2f8cd 100644 --- a/drivers/usb/serial/ftdi_sio_ids.h +++ b/drivers/usb/serial/ftdi_sio_ids.h @@ -1587,6 +1587,12 @@  #define IDS_SI31A_PID              0x13A2  #define IDS_CM31A_PID              0x13A3   +/* + * Omron corporation (https://www.omron.com/). + */ + #define OMRON_VID                 0x0590 + #define OMRON_CS1W_CIF31_PID            0x00b2 +  /*   * U-Blox products (http://www.u-blox.com).   */