From patchwork Thu Jul 28 15:41:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: thermal-bot for Julien Panis X-Patchwork-Id: 594257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F489C04A68 for ; Thu, 28 Jul 2022 15:42:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232097AbiG1PmF (ORCPT ); Thu, 28 Jul 2022 11:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbiG1PmE (ORCPT ); Thu, 28 Jul 2022 11:42:04 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA09968DD8 for ; Thu, 28 Jul 2022 08:42:01 -0700 (PDT) Date: Thu, 28 Jul 2022 15:41:59 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1659022920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zQ11RQURvQ+Agip/Q8/1jNVfJFietfyYULJKV+Ffa/4=; b=0Z8D7TzN4i4gnsUiQ8NswiLtfroyXEczIDcW6KeGvHPWafM9vBRY5gLZT9DuGQrrwavH1z 4GOTSm9qliqd5C7hU+cXMVOXS/hPGdBBIZStOy5I7Xig0AY+RQc2HhQoi3nF78sBRQ4Qv9 x10SjWS1ef2qjiPDV5DLa6RLp0WydsUD4qaS/SWLnKy3ck//rt1vBkQ8fjre87w2wayDbv gLBeNHAFBHFQdwC3irkgFWFby/e3iYMYCz06wokD2hgOoVI9xUQ1MYQ6qbBGWoBM7B+RiS Tjut8xy+KloWQUKt2I+E9sOvwOOOU3u2iIX0kGSt9nxx82IA3sOiqPiYRV2sCw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1659022920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zQ11RQURvQ+Agip/Q8/1jNVfJFietfyYULJKV+Ffa/4=; b=e+l/hUkHRAwmCVygCMyu7tNiMCvBLx6QsyiOidM8lRxWuYeeFhDolhPA7XOqvgolYwbmaf fz/8NTT5G2GCv6Ag== From: "thermal-bot for Wolfram Sang" Sender: tip-bot2@linutronix.de Reply-to: linux-pm@vger.kernel.org To: linux-pm@vger.kernel.org Subject: [thermal: thermal/next] drivers/thermal/rcar_gen3_thermal: Improve logging during probe Cc: Wolfram Sang , Geert Uytterhoeven , niklas.soderlund+renesas@ragnatech.se, Daniel Lezcano , rui.zhang@intel.com, amitk@kernel.org In-Reply-To: <20220610200500.6727-1-wsa+renesas@sang-engineering.com> References: <20220610200500.6727-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Message-ID: <165902291926.15455.9349901822229270872.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The following commit has been merged into the thermal/next branch of thermal: Commit-ID: 404dd7dfb13028d315514f63ed3cf9da46307a39 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//404dd7dfb13028d315514f63ed3cf9da46307a39 Author: Wolfram Sang AuthorDate: Fri, 10 Jun 2022 22:04:59 +02:00 Committer: Daniel Lezcano CommitterDate: Thu, 28 Jul 2022 17:29:44 +02:00 drivers/thermal/rcar_gen3_thermal: Improve logging during probe When setting up a new board, a plain "Can't register thermal zone" didn't help me much because the thermal zones in DT were all fine. I just had a sensor entry too much in the parent TSC node. Reword the failure/success messages to contain the sensor number to make it easier to understand which sensor is affected. Example output now: rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund Link: https://lore.kernel.org/r/20220610200500.6727-1-wsa+renesas@sang-engineering.com Signed-off-by: Daniel Lezcano --- drivers/thermal/rcar_gen3_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 43eb25b..e2020c6 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -507,7 +507,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) zone = devm_thermal_zone_of_sensor_register(dev, i, tsc, &rcar_gen3_tz_of_ops); if (IS_ERR(zone)) { - dev_err(dev, "Can't register thermal zone\n"); + dev_err(dev, "Sensor %u: Can't register thermal zone\n", i); ret = PTR_ERR(zone); goto error_unregister; } @@ -529,7 +529,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) if (ret < 0) goto error_unregister; - dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret); + dev_info(dev, "Sensor %u: Loaded %d trip points\n", i, ret); } if (!priv->num_tscs) {