From patchwork Thu Jul 21 09:34:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 592637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C00C43334 for ; Thu, 21 Jul 2022 09:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbiGUJa6 (ORCPT ); Thu, 21 Jul 2022 05:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiGUJa5 (ORCPT ); Thu, 21 Jul 2022 05:30:57 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 396087E82C; Thu, 21 Jul 2022 02:30:56 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id y11so1849625lfs.6; Thu, 21 Jul 2022 02:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=s151ffk1JIauk2lEB3TrZV+yG7gGvKpVixQvHLr+F1w=; b=nZvJDPK0EO6QY9MLTYOQ0LWUPTJZ5JUKK0SEj61HOjGzS4p4dNaOmtMk+ASvtvO0kx VvN0Jg0ed2dCQehW/9iVtgCAPxitukB6VZ29jQ9k4NV7Mz0gSPh5InWM/gTnb4DNn8Y4 sQbFjRcLH33bYFC2t3Jyl+EyNzOFuNb4LGjth3GYI82qFrwTb0liiz+Uf1c6YQU7cdVY 9DJi18H5P55gdWgJQcsPXkoo7YhU96Xwwu55mg7D0Qww43xwVMWuaboePe5HjAvPLwKy C5As6//osND0ELDE9TdlKYFu0Bthos9Il+0w9j/EuwSho/hJBVG3eO+AGN7DqG8Ob4NG wsSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=s151ffk1JIauk2lEB3TrZV+yG7gGvKpVixQvHLr+F1w=; b=oZDXFfPiHXcWB8/ICgUK8uNdifdyxXOv1OZt4x1OgjOZ2qvXFjgWZEEaowznwulf9Z djuxnpCo33LyIAG7NfQRXQHuoQolQB99cxsHPtojqrt9ACXV1aKVE6gTTQ1eL0Z05An2 xI0YZupV4V9yCXv/Cdjyp4N3Ee+cR53q9wEzaBq9KDgnXtLmLkXw3+qTm8tQyrYbdCHN RadfbN8vzIu9M3XEJp9/xbjwFv4u6NpIr1dBdflK9ApalwuYdjobrqdC2IA3KnXviz59 veYHcUVyYxU16ialqbXbUNRN1uMnUSfISGkuaMkUzakPAIpycCbJh3lkVIbZRaWY6Nx+ dUrA== X-Gm-Message-State: AJIora8vXL3VMQJXTSfXbruUy73D7/e/I84/JgvgP258ECX2OgOf+sm6 4fI2mxfDss9AFf5c/CXf/ycxk3fJ6fk= X-Google-Smtp-Source: AGRyM1uLU45d6nitV/svzhHqvt6/3qKj2nNBMf/FZIrIQ/ktIuvkN7xNwI/GV3FyTP60CY71VLOBnA== X-Received: by 2002:a05:6512:33c5:b0:48a:1c38:e43 with SMTP id d5-20020a05651233c500b0048a1c380e43mr18876341lfg.671.1658395854412; Thu, 21 Jul 2022 02:30:54 -0700 (PDT) Received: from localhost.localdomain (82-209-154-112.cust.bredband2.com. [82.209.154.112]) by smtp.gmail.com with ESMTPSA id y30-20020a19915e000000b0047f6b4f82d1sm323055lfj.250.2022.07.21.02.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 02:30:53 -0700 (PDT) From: Marcus Folkesson To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Maxime Ripard Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marcus Folkesson Subject: [PATCH 1/2] gpio: gpio-74x164: add support for CDx4HC4094 Date: Thu, 21 Jul 2022 11:34:21 +0200 Message-Id: <20220721093422.2173982-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org 74hc4094 and 75hc4094 works similar to 74x164 but has an additional storage latch associated with each stage for strobing data from the serial input to parallell buffer tri-state output. Add support for an optional strobe pin. Signed-off-by: Marcus Folkesson --- drivers/gpio/gpio-74x164.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c index e00c33310517..4a1c4de358e4 100644 --- a/drivers/gpio/gpio-74x164.c +++ b/drivers/gpio/gpio-74x164.c @@ -21,6 +21,7 @@ struct gen_74x164_chip { struct gpio_chip gpio_chip; struct mutex lock; struct gpio_desc *gpiod_oe; + struct gpio_desc *gpiod_strobe; u32 registers; /* * Since the registers are chained, every byte sent will make @@ -66,6 +67,10 @@ static void gen_74x164_set_value(struct gpio_chip *gc, chip->buffer[bank] &= ~(1 << pin); __gen_74x164_write_config(chip); + + /* Latch data to output pins*/ + gpiod_set_value_cansleep(chip->gpiod_strobe, 1); + gpiod_set_value_cansleep(chip->gpiod_strobe, 0); mutex_unlock(&chip->lock); } @@ -87,6 +92,10 @@ static void gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask, chip->buffer[bank] |= bitmask; } __gen_74x164_write_config(chip); + + /* Latch data to output pins*/ + gpiod_set_value_cansleep(chip->gpiod_strobe, 1); + gpiod_set_value_cansleep(chip->gpiod_strobe, 0); mutex_unlock(&chip->lock); } @@ -129,6 +138,12 @@ static int gen_74x164_probe(struct spi_device *spi) gpiod_set_value_cansleep(chip->gpiod_oe, 1); + chip->gpiod_strobe = devm_gpiod_get_optional(&spi->dev, "strobe", + GPIOD_OUT_LOW); + if (IS_ERR(chip->gpiod_strobe)) + return PTR_ERR(chip->gpiod_strobe); + + spi_set_drvdata(spi, chip); chip->gpio_chip.label = spi->modalias; @@ -153,6 +168,10 @@ static int gen_74x164_probe(struct spi_device *spi) goto exit_destroy; } + /* Latch data to output pins*/ + gpiod_set_value_cansleep(chip->gpiod_strobe, 1); + gpiod_set_value_cansleep(chip->gpiod_strobe, 0); + ret = gpiochip_add_data(&chip->gpio_chip, chip); if (!ret) return 0; @@ -182,6 +201,8 @@ MODULE_DEVICE_TABLE(spi, gen_74x164_spi_ids); static const struct of_device_id gen_74x164_dt_ids[] = { { .compatible = "fairchild,74hc595" }, { .compatible = "nxp,74lvc594" }, + { .compatible = "ti,cd54hc4094" }, + { .compatible = "ti,cd74hc4094" }, {}, }; MODULE_DEVICE_TABLE(of, gen_74x164_dt_ids); From patchwork Thu Jul 21 09:34:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 592232 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A1BCCA488 for ; Thu, 21 Jul 2022 09:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbiGUJa7 (ORCPT ); Thu, 21 Jul 2022 05:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230170AbiGUJa6 (ORCPT ); Thu, 21 Jul 2022 05:30:58 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16DDC7FE49; Thu, 21 Jul 2022 02:30:57 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id bp17so1861786lfb.3; Thu, 21 Jul 2022 02:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pbn4iYbqNCz7GfMmDju4Bq3tvwy5gDLpHOUqwybJ02U=; b=ndFuWigCiHE1sU0id4oFFGSUalZDq8lWiv7FygDSM6oIKf35zr0tu1sI30oOXo8WMF 0QMN8KsDN3Xqo1bvRGmMWBcCDSOR2Q9+fgTLFaKOjQqfBSeTGSryr4A1KaYWgBoYaT10 nHNLdcnA2gKHb8Uw5YnTC7Jxmi5vxHzSGY2OvNVWjuI4j1GIldaXvrXBMQFurozFa9Mc +Diq7+XZk0U9FlmNpzDtt62zALqggBFs2t4DsZdJvnvjp5VAYo7KEtpD8wJiT2fZtmHX ehOK44cJiOEFMHMU1F1K1SEZfrnyVExsO0EQRUT0GkZFFCGCobv84cawMn4/5mziqJyE 3mVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pbn4iYbqNCz7GfMmDju4Bq3tvwy5gDLpHOUqwybJ02U=; b=BJgR5UK2NZ6fy8o0dlLkj88TkZw3n5nhSwCFzrCMm9PaNllswF5PzjzL4iPnrhGhuf 028mDa+kIPn8tZFe2MPGTQG2fRqPUnY4I7HOT/vGO8h03CGVBSkZ4bCUT39sJV5TEpoY rGZcszILo+j6dwPs1fEPmjxVOYfEKYhwDLQQxerRRYgAKqFH+hYJfbPPT+tO/lkT3c5Y nED1QH9WnytD7BPQsK9gyIcl2ldc/vVNmEfKeFH1JrjA5/Jbd0x4GpJ9B1Xx579P/dUo w3EsPZ2Tp19NN+liVpmTplv9x3b5tboKhWS/dyFDj5hoS8YWZDA5/lup9iRE8gVc8NI+ xlrw== X-Gm-Message-State: AJIora8o4Ir+Cro8COUfkmeAqh/Y5tYFnIWfJbGdARdvz2VTZJqO1TBi m8Uo3wVMwFay5wROkTegaxY= X-Google-Smtp-Source: AGRyM1v5P9aY/99EWp7aNwiPSVRLeD4eH/MK9NGEYXVs8AlQFC+VPMrbm0tSISTvKOpf5ttJmpWm0w== X-Received: by 2002:ac2:4e07:0:b0:48a:18f3:e5fe with SMTP id e7-20020ac24e07000000b0048a18f3e5femr19875756lfr.357.1658395855369; Thu, 21 Jul 2022 02:30:55 -0700 (PDT) Received: from localhost.localdomain (82-209-154-112.cust.bredband2.com. [82.209.154.112]) by smtp.gmail.com with ESMTPSA id y30-20020a19915e000000b0047f6b4f82d1sm323055lfj.250.2022.07.21.02.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 02:30:54 -0700 (PDT) From: Marcus Folkesson To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Maxime Ripard Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marcus Folkesson Subject: [PATCH 2/2] dt-bindings: gpio: fairchild,74hc595: add strobe-gpios property Date: Thu, 21 Jul 2022 11:34:22 +0200 Message-Id: <20220721093422.2173982-2-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220721093422.2173982-1-marcus.folkesson@gmail.com> References: <20220721093422.2173982-1-marcus.folkesson@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Some shift registers (74hc4094 for example) has a strobe signal to latch data from the serial input to the parallel output. Add an optional strobe-gpios property to support those chips. Signed-off-by: Marcus Folkesson --- .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml index a99e7842ca17..9893df9ae22c 100644 --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml @@ -14,6 +14,8 @@ properties: enum: - fairchild,74hc595 - nxp,74lvc594 + - ti,cd54hc4094 + - ti,cd74hc4094 reg: maxItems: 1 @@ -33,6 +35,10 @@ properties: description: GPIO connected to the OE (Output Enable) pin. maxItems: 1 + strobe-gpios: + description: GPIO connected to the STROBE pin + maxItems: 1 + spi-max-frequency: true patternProperties: