From patchwork Sun Jul 17 12:42:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 591426 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5355C43334 for ; Sun, 17 Jul 2022 12:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232803AbiGQMnF (ORCPT ); Sun, 17 Jul 2022 08:43:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiGQMnF (ORCPT ); Sun, 17 Jul 2022 08:43:05 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D09C1572F; Sun, 17 Jul 2022 05:43:04 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id j22so16782615ejs.2; Sun, 17 Jul 2022 05:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=heItu7qNWLJ2iI4fhTzcVgfEgKTOgTZD5O+P4na3DrY=; b=iA17OtDvOPV9zwYv53yjkHqCiHIbJMZQconVanqI63FrS+kXrjsxnjJVBUQTKAjFdQ MuLaV0UHmzjbvcptjecnJwR/hlNPvb32pi2iwAudkrnyAaTLsw74Z3BhoNW+3WcWofUa kYnBNUCPEwTG2UO1nvoKtSuFfR8UJQhiay+ZzuO34+lbIWY1kEkjP1Ao5IvV4Y7yjaDf yUbsJphraV3sCTl8F5bZvoSRiBWbEt0MYd3FhlNcO4OiZaU4wP7e6askx364e8OEdf3Q hLHD9tNoc9OXqIddB1MSTUaHeLAJHCC6bM37TiynonUEuoMB7D0EEH7kkUqwGfC26/a+ PaHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=heItu7qNWLJ2iI4fhTzcVgfEgKTOgTZD5O+P4na3DrY=; b=kmHHoAuynjCtdqC+TAbISMo+Iv100VnK4g2lbGCy9olYganNCUyexD3Ggf/oqp6YeJ M156m0iyyCIKmf/sZX1HnasNXht9yoUz3yYoGhYtIhMZUydtzF6sCOwm3O3etlL/I4za wIG0qRd+VPvHvYVlj2CmtCfIvU4G/Lv6imz7WsH2NWD9BzWQ2HxQornmc+Pwlgh0pYfT EiB7IBDt8J9DRTWT9FLx7fCoRYmUxuYQjixiawpMYCtK1DCcqJS1o8Irt3rruiAMMG17 JuBIFtdf1orbbeJdwrqMd70wiYliNEUTTBqcaDgm97J1jO6FSmzjYLbMLd469hI1uiJt s5Jg== X-Gm-Message-State: AJIora+OSOGV7aMhgx7atcxUx6YhyYCGY7QbgxiJc/nvy9uUjH6eIAWL IpQjO6WRKQxTwWClt4NwE64= X-Google-Smtp-Source: AGRyM1swE+XIig5oXG3rbEORKdCkp52rvaCzTxLSD6iXjjaQ4BQ6qlo1Y0LYuZbJQ2rIaoZWjQEv3w== X-Received: by 2002:a17:906:8479:b0:72b:83cf:4cf3 with SMTP id hx25-20020a170906847900b0072b83cf4cf3mr21609830ejc.90.1658061782404; Sun, 17 Jul 2022 05:43:02 -0700 (PDT) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id i22-20020aa7c716000000b0043a64eee322sm4520588edq.28.2022.07.17.05.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 05:43:02 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Pavel Machek Cc: Rob Herring , Krzysztof Kozlowski , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , linux-leds@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 1/3] dt-bindings: leds: leds-bcm63138: unify full stops in descriptions Date: Sun, 17 Jul 2022 14:42:46 +0200 Message-Id: <20220717124248.13562-2-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220717124248.13562-1-zajec5@gmail.com> References: <20220717124248.13562-1-zajec5@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Rafał Miłecki Description of "reg" doesn't have full stop at the end. It makes sense as it's a one-sentence only. Use the same style for "active-low". Reported-by: Pavel Machek Signed-off-by: Rafał Miłecki --- Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml index 99cd4ba9b0ca..52252fb6bb32 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml +++ b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml @@ -54,7 +54,7 @@ patternProperties: active-low: type: boolean - description: Makes LED active low. + description: Makes LED active low required: - reg From patchwork Sun Jul 17 12:42:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 591559 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744B0C43334 for ; Sun, 17 Jul 2022 12:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiGQMnG (ORCPT ); Sun, 17 Jul 2022 08:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232868AbiGQMnF (ORCPT ); Sun, 17 Jul 2022 08:43:05 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31EE115A2E; Sun, 17 Jul 2022 05:43:05 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id mf4so16791259ejc.3; Sun, 17 Jul 2022 05:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KE97/SBmhO7aw3gFJCxcKM7p1dKmYViOU/YqYue35DU=; b=HHyPrTv20yWLSIzwggHfU0DjvMlfi6GYfxFKo1Z7U9HTkjp2D5Zb0cd2pZ9qJCOhSg fTJLoZ192E8Jpe9/T4LoCoEA0kCJtHSs83b28YYY7qY5olKAXBSLeRPgIv585mM90Ml5 DCHYJEx5cV/B+L88n4CGqbSgORmQi0QH/8kyqcJ82OC4Ar1DOolqRx1nTiknYBWmYqtY qeUjXzBIyJWfkVnzWtcQZZKmWpiu2YuyXRXA7ViYpkTHdw1FvI4VTXG2mEhuRRYkv4HC cNo3A8y7qcIJTEJ49qiBk3JZTkNokTtVLv/zHYQz4cpqFsnoIBgoKsfAr4nMllRUnuMY tSOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KE97/SBmhO7aw3gFJCxcKM7p1dKmYViOU/YqYue35DU=; b=RfnOCgZf+ysQCK7rDrQn211EVn+8aF12owNSWFuULSSmyY56dg5wqPDHPEKvvp9Bpe TYecjNOPQA4rbC6mhk9Nco5CddeCs7oUgmpA+4WgV1YivX/EecnLuRNcpWrpqH9FwoAH XTjLIVgvL0fOVPFjtKfCT9tqS/8lVMYLx5i3e0Y/2GavgQUAHp5ce8Mcya7LLqoWu4KQ PR6AtRkSWMZenOkfPoHrYMgPKEzp0xCfTs+Xp4/+hibO/V3ZkOzGTscmqn5FQjfKCu7W LeJ752CeP/hOmYaIrVH0RtPcq9w95TtnfkjFOmTHx3qbf7Ddc8OEAer6fOG2ahIqQknq D44w== X-Gm-Message-State: AJIora8gU+5koZqf3J3iRdXnGtHXpQSSAdmkfU0ssF81V7IBh99aW/iM fUVlKqJtNW51ppN07I8GVHw= X-Google-Smtp-Source: AGRyM1sK3E8RGOgV5nk5HqHonA0Fzt27080ufNkbbTtW55Cwh9UkAaff/TEgsGooDK46U/vWGvNZnA== X-Received: by 2002:a17:907:760f:b0:72b:7eb4:be52 with SMTP id jx15-20020a170907760f00b0072b7eb4be52mr21867628ejc.737.1658061783601; Sun, 17 Jul 2022 05:43:03 -0700 (PDT) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id i22-20020aa7c716000000b0043a64eee322sm4520588edq.28.2022.07.17.05.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 05:43:03 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Pavel Machek Cc: Rob Herring , Krzysztof Kozlowski , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , linux-leds@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 2/3] leds: add help info about BCM63138 module name Date: Sun, 17 Jul 2022 14:42:47 +0200 Message-Id: <20220717124248.13562-3-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220717124248.13562-1-zajec5@gmail.com> References: <20220717124248.13562-1-zajec5@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Rafał Miłecki It's what we do for all other LEDs drivers. Reported-by: Pavel Machek Signed-off-by: Rafał Miłecki --- drivers/leds/blink/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index c680af01b5a9..945c84286a4e 100644 --- a/drivers/leds/blink/Kconfig +++ b/drivers/leds/blink/Kconfig @@ -10,6 +10,8 @@ config LEDS_BCM63138 BCM63138 SoC. The same hardware block is known to be also used in BCM4908, BCM6848, BCM6858, BCM63148, BCM63381 and BCM68360. + If compiled as module it will be called leds-bcm63138. + config LEDS_LGM tristate "LED support for LGM SoC series" depends on X86 || COMPILE_TEST From patchwork Sun Jul 17 12:42:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 591425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851C6CCA47B for ; Sun, 17 Jul 2022 12:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232873AbiGQMnI (ORCPT ); Sun, 17 Jul 2022 08:43:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232868AbiGQMnH (ORCPT ); Sun, 17 Jul 2022 08:43:07 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 657AB1572F; Sun, 17 Jul 2022 05:43:06 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id ez10so16713367ejc.13; Sun, 17 Jul 2022 05:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YYzoacsZMoWFZstDTYaMwcaR8lS9+roWWLsiPfEpSnk=; b=e4uJUwKO+QuZiIwn6MC8rXU63K4IQnrySJmVyWBlaYif3fEz+/I8FexF02N7TDtzwA zHQmFzbKcC93LA0JZiHT89zqpF8q04j3rxXpaIvh8yselMOnEWl3fZSN7p87Top8KD+1 Ijkpgvmnde3BdhbD75TOHeFc2y+z6j7wvxTassSQY9kf7CdS/Ehe1bS7pjq5Y1B0+8VO LpEilgind89SzZKFYbSuPpOvdjAr3RejDAxvejRx6ZmfU5f+seWqjMbbArt9fgvLrH5u VIi6MJ8Eece+DJ0vZquVDkEU6XX131ME3J4wWi4FXqXoJYFmiYFUTl5MOYDL2bISl38o 8yDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YYzoacsZMoWFZstDTYaMwcaR8lS9+roWWLsiPfEpSnk=; b=zLlEJJk2toEa1vVvoJqBAv9LgI07NN3ubgoPFEzp/opMepW0nfmSxR5sYJswXoXz6w 9e4I7toydCDbNVm49xC44wueIoKq+n5sd4T4vdwq0DSqtHsAHYDvnjOIRxiolk+BSl7u H9yRLJEJJl+I3IheYukRWyJVkJncXUudI3JeLTxoxtDX84m/Pwd9Nh8w8cxpIH2N2Kra d66elJKSfgEtZStRaQ1awC5beCVauQQn4AgDEcz6whX6HbPjsJgM4IYgep9UqI9rYdXB mh2WYYY4Dc06CfSQWU4/f5h2eNrfIaOqeWmr5afkIFU3WGfw0JkG4sd4uNqHyyYrn936 qwZg== X-Gm-Message-State: AJIora+yZWmMq+K9zxFRp0qSeXdC8KUAm9KyaEfLs+YCgJHoTD2B6ZGM cX3yPJmhW7lokHftRbUz0vU= X-Google-Smtp-Source: AGRyM1sttkl1O/1N7usBItncy6DZS9ukz2ekFShxJ2xUrrGYNYHYHmSTZlR9vyWolD2P98D++QtOfA== X-Received: by 2002:a17:907:1def:b0:72b:33e6:46d6 with SMTP id og47-20020a1709071def00b0072b33e646d6mr21444035ejc.414.1658061784949; Sun, 17 Jul 2022 05:43:04 -0700 (PDT) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id i22-20020aa7c716000000b0043a64eee322sm4520588edq.28.2022.07.17.05.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 05:43:04 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Pavel Machek Cc: Rob Herring , Krzysztof Kozlowski , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , linux-leds@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 3/3] leds: leds-bcm63138: get rid of LED_OFF Date: Sun, 17 Jul 2022 14:42:48 +0200 Message-Id: <20220717124248.13562-4-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220717124248.13562-1-zajec5@gmail.com> References: <20220717124248.13562-1-zajec5@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Rafał Miłecki The whole "enum led_brightness" is marked as obsolete. Replace it with a (non-)zero check. Reported-by: Pavel Machek Signed-off-by: Rafał Miłecki --- drivers/leds/blink/leds-bcm63138.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c index c083cb1332cb..2cf2761e4914 100644 --- a/drivers/leds/blink/leds-bcm63138.c +++ b/drivers/leds/blink/leds-bcm63138.c @@ -113,8 +113,7 @@ static void bcm63138_leds_enable_led(struct bcm63138_leds *leds, { u32 bit = BIT(led->pin); - bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, - value == LED_OFF ? 0 : bit); + bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, value ? bit : 0); } /*