From patchwork Mon Jul 11 14:40:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yassine Oudjana X-Patchwork-Id: 589505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA499C43334 for ; Mon, 11 Jul 2022 14:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbiGKOl5 (ORCPT ); Mon, 11 Jul 2022 10:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231586AbiGKOlr (ORCPT ); Mon, 11 Jul 2022 10:41:47 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 528F010CB; Mon, 11 Jul 2022 07:41:45 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r18so6525733edb.9; Mon, 11 Jul 2022 07:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bXeQpXRbrH5X43wWagOkIwwhygGaQIFF6qtQ+Z9h8xo=; b=N7HeRO1Yvm19znwIzCh5ffaLuZnmb2PEkGhC+hxSVoeSJyjxYUn6MBAl6XKbBxyd9q EGyzOSFn986XUUZS+x6Y2NZjsR3TfIrMCZ3pxbUM/mRHxu9D1Qq+Pksh2z3XSxr7HzWY xHlUFOi/yDNIY6XlsuLe9oBXKkD0Uuz6mZ0yXGRKbV3uqN9vxkoXtw8BrG+sJ0md/Ivo fO++fcV0UqlXsKS0rDdJvfVN0fkT+l+YsHOW8ihaKiud1FvzbqBUoTSKyY1Y8aLt8UGj +a/wjLIXZdlJpZQE2i6/hS32jUIPvIoGwoZkv5iqve3rvRilOsYEHPpOmNpGaGZ24mYc Gxkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bXeQpXRbrH5X43wWagOkIwwhygGaQIFF6qtQ+Z9h8xo=; b=Qw7zt4rMXNQu66u2xIZL/r+hKY8Ovs9ZQI35aXAI0Z0cpEOecA8Tg+1dVj9nSNF1WJ rsPNBUrZqRXS0p1yI87yZXnZV2S/Adu50RinF9kQnUsypY3h/1JfizYGMqgtDNbWaAwF rQxL6n2Y0VNMVQodNY8do/3DrBXHxUuj6nBdhCDXZssvMssA7V+Ki8BaVL06aSqHx/Sk RsQpbYNCCf3jsbmImfinNnb2uxqkVlYInVvHpc1mOBBVjXYAFkdRtRNz9Ahoerivv9r8 QtTSYQUXVnJ4wEE7Xx3zzEV+7FiVu7gJRYB1fW0nobTGZ4mUxLT9dcAtqWRimQOBcdYs 3qvw== X-Gm-Message-State: AJIora9GhyY2zUNunqhMd8J0hdoLUCdIW/Un6sYgJcsBdMLuMOMS6lZV t4WoBGLVkbzBY6dJrOL7PBE= X-Google-Smtp-Source: AGRyM1tJUMuH7XabXaTMce5UeEqx7be1qKFN4GsEZqFEfJZPrdZYHtfCZW9rynveVK/SB55KSyMq8A== X-Received: by 2002:a05:6402:248c:b0:437:afe7:818b with SMTP id q12-20020a056402248c00b00437afe7818bmr25054824eda.239.1657550503859; Mon, 11 Jul 2022 07:41:43 -0700 (PDT) Received: from localhost.localdomain (89-39-107-113.hosted-by-worldstream.net. [89.39.107.113]) by smtp.gmail.com with ESMTPSA id cm10-20020a0564020c8a00b00436f3107bdasm4461390edb.38.2022.07.11.07.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 07:41:43 -0700 (PDT) From: Yassine Oudjana X-Google-Original-From: Yassine Oudjana To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Tianshu Qiu , Bingbu Cao Cc: Yassine Oudjana , Yassine Oudjana , Jacopo Mondi , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] media: dt-bindings: ak7375: Convert to DT schema Date: Mon, 11 Jul 2022 18:40:37 +0400 Message-Id: <20220711144039.232196-2-y.oudjana@protonmail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220711144039.232196-1-y.oudjana@protonmail.com> References: <20220711144039.232196-1-y.oudjana@protonmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Yassine Oudjana Convert DT bindings document for AKM AK7375 VCM to DT schema format and add an example. Signed-off-by: Yassine Oudjana --- Changes since v1: - Add vendor prefix to DT binding doc file name .../devicetree/bindings/media/i2c/ak7375.txt | 8 ---- .../media/i2c/asahi-kasei,ak7375.yaml | 41 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 42 insertions(+), 9 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/i2c/ak7375.txt create mode 100644 Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ak7375.txt b/Documentation/devicetree/bindings/media/i2c/ak7375.txt deleted file mode 100644 index aa3e24b41241..000000000000 --- a/Documentation/devicetree/bindings/media/i2c/ak7375.txt +++ /dev/null @@ -1,8 +0,0 @@ -Asahi Kasei Microdevices AK7375 voice coil lens driver - -AK7375 is a camera voice coil lens. - -Mandatory properties: - -- compatible: "asahi-kasei,ak7375" -- reg: I2C slave address diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml new file mode 100644 index 000000000000..22b1251b16ee --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/asahi-kasei,ak7375.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Asahi Kasei Microdevices AK7375 voice coil lens actuator + +maintainers: + - Tianshu Qiu + +description: + AK7375 is a voice coil motor (VCM) camera lens actuator that + is controlled over I2C. + +properties: + compatible: + const: asahi-kasei,ak7375 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ak7375: camera-lens@c { + compatible = "asahi-kasei,ak7375"; + reg = <0x0c>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index a97fef8c131d..e6accf8bc12b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3063,7 +3063,7 @@ M: Tianshu Qiu L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/i2c/ak7375.txt +F: Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml F: drivers/media/i2c/ak7375.c ASAHI KASEI AK8974 DRIVER From patchwork Mon Jul 11 14:40:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yassine Oudjana X-Patchwork-Id: 589504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112C4C433EF for ; Mon, 11 Jul 2022 14:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbiGKOmH (ORCPT ); Mon, 11 Jul 2022 10:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231609AbiGKOl6 (ORCPT ); Mon, 11 Jul 2022 10:41:58 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41E8C6D2FE; Mon, 11 Jul 2022 07:41:51 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id va17so9261528ejb.0; Mon, 11 Jul 2022 07:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OGhZTj5ZWGv/eTym6XOpCg2bZQb8uWXBpna96uNZQLA=; b=pLXX7QjLGzJMlrsyc7zv0canr2KOOS+gjDPGHDNPiUiqPlMRg3H4yA4NHLCg28lv6l Sw6VhScDmz5ipC5Em63Q1TJiKd8tU9x6HjwogT7UrlSS82yOEaFG3RZoKiD7LOaRvXj0 uCIV5w1cyStDGjwb6PdYzdvNIRZqej0owWzc2LuP3ZWcw8AppIwEi51Sq7xWtGjrRYrn 6Snp9U8EZVktyg/0/NRmgiwPdGkW5TcaA8pc/SUHjCE6e28pk99thQB1vBupYy42D5QG JZOyjnKRmZhsDo+ltCSjPGU9FOj+tHAWDMOnnhEbFRYsACmXKESkMStoPlw1nHu1qu9J FsmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OGhZTj5ZWGv/eTym6XOpCg2bZQb8uWXBpna96uNZQLA=; b=k55o1rMeUJfqEDuy/UqFs16XKHhAUoDq8K+x0ctS5uvg2vOR0gY5pdQB6OryUf6Hpi H7TW/K3SEwR/UdjXlRgBdsKbQ/Nf/yjeZNWubxfsr7QgnAwO9xGLnZztDjviZWB58hyM wA0HdORVOX13+zBCan3/9SgGZzqMMrd2Y0HkLZLNRHIbhxGfix54ofAU+uO2dUKUK3XZ f3vfVM8RS1Yns8wgaiIjTV9EnoQ/OC0Kw104FMKM1ZeBeVE+KPa7gDW47Gz9RActT2/6 IRe0iDe17OIU7xi9JHTtybAb7/4xwijyG68cjlw+ZFFv83LgDKuDsdfXtsvVLe6DJpK0 Vsfg== X-Gm-Message-State: AJIora9qulF5omWERkgj9alaHk7dTq9iHOBuLw0KW8JZPo/M2dBXdPQY 6KxMjm+qmyNvFXEfKPwLK3I/matCtigZL/+D X-Google-Smtp-Source: AGRyM1vl9kBGEmWp2DTA164KVmbJv1lySwAvttmKioVX7GsaVLslW4UHHcVKMosu7TifmP8HU6Rr+Q== X-Received: by 2002:a17:907:1361:b0:72b:3554:4f7 with SMTP id yo1-20020a170907136100b0072b355404f7mr13449704ejb.420.1657550509279; Mon, 11 Jul 2022 07:41:49 -0700 (PDT) Received: from localhost.localdomain (89-39-107-113.hosted-by-worldstream.net. [89.39.107.113]) by smtp.gmail.com with ESMTPSA id cm10-20020a0564020c8a00b00436f3107bdasm4461390edb.38.2022.07.11.07.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 07:41:48 -0700 (PDT) From: Yassine Oudjana X-Google-Original-From: Yassine Oudjana To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Tianshu Qiu , Bingbu Cao Cc: Yassine Oudjana , Yassine Oudjana , Jacopo Mondi , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] media: i2c: ak7375: Add regulator management Date: Mon, 11 Jul 2022 18:40:39 +0400 Message-Id: <20220711144039.232196-4-y.oudjana@protonmail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220711144039.232196-1-y.oudjana@protonmail.com> References: <20220711144039.232196-1-y.oudjana@protonmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Yassine Oudjana Make the driver get needed regulators on probe and enable/disable them on runtime PM callbacks. Signed-off-by: Yassine Oudjana --- Changes since v1: - Reorganize variable declaration - Change the power-on delay range to 3000-3500 microseconds. drivers/media/i2c/ak7375.c | 39 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/media/i2c/ak7375.c b/drivers/media/i2c/ak7375.c index 40b1a4aa846c..c2b2542a0056 100644 --- a/drivers/media/i2c/ak7375.c +++ b/drivers/media/i2c/ak7375.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include @@ -23,17 +24,32 @@ */ #define AK7375_CTRL_STEPS 64 #define AK7375_CTRL_DELAY_US 1000 +/* + * The vcm takes around 3 ms to power on and start taking + * I2C messages. This value was found experimentally due to + * lack of documentation. + */ +#define AK7375_POWER_DELAY_US 3000 #define AK7375_REG_POSITION 0x0 #define AK7375_REG_CONT 0x2 #define AK7375_MODE_ACTIVE 0x0 #define AK7375_MODE_STANDBY 0x40 +static const char * const ak7375_supply_names[] = { + "vdd", + "vio", +}; + +#define AK7375_NUM_SUPPLIES ARRAY_SIZE(ak7375_supply_names) + /* ak7375 device structure */ struct ak7375_device { struct v4l2_ctrl_handler ctrls_vcm; struct v4l2_subdev sd; struct v4l2_ctrl *focus; + struct regulator_bulk_data supplies[AK7375_NUM_SUPPLIES]; + /* active or standby mode */ bool active; }; @@ -133,12 +149,24 @@ static int ak7375_probe(struct i2c_client *client) { struct ak7375_device *ak7375_dev; int ret; + int i; ak7375_dev = devm_kzalloc(&client->dev, sizeof(*ak7375_dev), GFP_KERNEL); if (!ak7375_dev) return -ENOMEM; + for (i = 0; i < AK7375_NUM_SUPPLIES; i++) + ak7375_dev->supplies[i].supply = ak7375_supply_names[i]; + + ret = devm_regulator_bulk_get(&client->dev, AK7375_NUM_SUPPLIES, + ak7375_dev->supplies); + if (ret) { + dev_err(&client->dev, "Failed to get regulators: %pe", + ERR_PTR(ret)); + return ret; + } + v4l2_i2c_subdev_init(&ak7375_dev->sd, client, &ak7375_ops); ak7375_dev->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ak7375_dev->sd.internal_ops = &ak7375_int_ops; @@ -210,6 +238,10 @@ static int __maybe_unused ak7375_vcm_suspend(struct device *dev) if (ret) dev_err(dev, "%s I2C failure: %d\n", __func__, ret); + ret = regulator_bulk_disable(AK7375_NUM_SUPPLIES, ak7375_dev->supplies); + if (ret) + return ret; + ak7375_dev->active = false; return 0; @@ -230,6 +262,13 @@ static int __maybe_unused ak7375_vcm_resume(struct device *dev) if (ak7375_dev->active) return 0; + ret = regulator_bulk_enable(AK7375_NUM_SUPPLIES, ak7375_dev->supplies); + if (ret) + return ret; + + /* Wait for vcm to become ready */ + usleep_range(AK7375_POWER_DELAY_US, AK7375_POWER_DELAY_US + 500); + ret = ak7375_i2c_write(ak7375_dev, AK7375_REG_CONT, AK7375_MODE_ACTIVE, 1); if (ret) {