From patchwork Wed Jan 23 10:14:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 156347 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp551083jaa; Wed, 23 Jan 2019 02:20:28 -0800 (PST) X-Google-Smtp-Source: ALg8bN5wZMdZkUz5nJmLAcp6k8T74LQflA/5Dg+hGTSHne9a3ZT3sESKg/UIcQouN0EJhiGbSPNV X-Received: by 2002:adf:a357:: with SMTP id d23mr2102183wrb.195.1548238828320; Wed, 23 Jan 2019 02:20:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548238828; cv=none; d=google.com; s=arc-20160816; b=tmnf2t90GaVzzBWRMTlVrde32Aoj//t0vumgcUKOxu6pkQKuELrvGJfhhjsWvLtU48 0pW+6ImJXZxayakdhHzcGYphHNlLp9+mo/3yA9/vNCpGPAnUs+FkKNIGKjmBsRgKln+w QYsN7yXC0vbSxkn8sSanm6GYXJGRs/r060hkaFdN7pgHe7TupXGdq7MIJ1e5CUOLUY9l l6yD1dpC+Vu6F+WCxSrlMbc4+FjavywMbsK5UJZJZGb1UlVd8UJoaR2wXRJEw6JjQlhL DOVpUTFC9OidVYpkmbIlkMr4FHIFdjYC7O+iBpErqPUWfC6FgaJKWLIWTE+03JPrvX3r Jglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=fSqV2DL6BhrH3Uam/u95JZJVE0J1JsbTp4LpC2gybhY=; b=mX+3hM1jmv3NOE5FoULVPbdBMz0pSBCh/qBLBhAmKE8a1ZXBRFDdWQL0Imp41+fnee GyJY2vHcBDNqiHR5grTi7o8g2okSy2Zer6is8RxiOajpm1u7dLcm4hZBlYgy3FEbK9mh MrLaQ2LoNYkemkz/9ZkvXPrT1H35+9EuSlhPsXF33ner3nyJTmMlXZKRUwNwg19MgG/C V3MSJuwkbRuwXTsKkchGZ7Xuu2Pff0YzcbDxf2n/UnE4s+FH8/ovSnbmuyu4WqAbQPkn qDxBvYq+Xf7lLpiNpeVBnzoaRjGFkm3/BSUs/UI0N0Otv8qWznJh6vEBP1mS3dD87doE zWsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x7si69196724wrw.135.2019.01.23.02.20.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 23 Jan 2019 02:20:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:59699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmFdz-0003rz-6m for patch@linaro.org; Wed, 23 Jan 2019 05:20:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmFZY-0001WW-7d for qemu-devel@nongnu.org; Wed, 23 Jan 2019 05:15:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmFZT-0007Iz-TO for qemu-devel@nongnu.org; Wed, 23 Jan 2019 05:15:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34916) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmFZL-00075b-16; Wed, 23 Jan 2019 05:15:39 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1D4FC050061; Wed, 23 Jan 2019 10:15:28 +0000 (UTC) Received: from laptop.redhat.com (ovpn-117-91.ams2.redhat.com [10.36.117.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0AF96013C; Wed, 23 Jan 2019 10:15:20 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com, imammedo@redhat.com, david@redhat.com Date: Wed, 23 Jan 2019 11:14:43 +0100 Message-Id: <20190123101458.12478-4-eric.auger@redhat.com> In-Reply-To: <20190123101458.12478-1-eric.auger@redhat.com> References: <20190123101458.12478-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 23 Jan 2019 10:15:29 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 03/18] hw/arm/boot: introduce fdt_add_memory_node helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com, dgilbert@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Shameer Kolothum We introduce an helper to create a memory node. Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/arm/boot.c | 54 ++++++++++++++++++++++++++++++++------------------- 1 file changed, 34 insertions(+), 20 deletions(-) -- 2.20.1 diff --git a/hw/arm/boot.c b/hw/arm/boot.c index c7a67af7a9..16f5da02fb 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -423,6 +423,36 @@ static void set_kernel_args_old(const struct arm_boot_info *info, } } +static int fdt_add_memory_node(void *fdt, uint32_t acells, hwaddr mem_base, + uint32_t scells, hwaddr mem_len, + int numa_node_id) +{ + char *nodename = NULL; + int ret; + + nodename = g_strdup_printf("/memory@%" PRIx64, mem_base); + qemu_fdt_add_subnode(fdt, nodename); + qemu_fdt_setprop_string(fdt, nodename, "device_type", "memory"); + ret = qemu_fdt_setprop_sized_cells(fdt, nodename, "reg", acells, mem_base, + scells, mem_len); + if (ret < 0) { + fprintf(stderr, "couldn't set %s/reg\n", nodename); + goto out; + } + if (numa_node_id < 0) { + goto out; + } + + ret = qemu_fdt_setprop_cell(fdt, nodename, "numa-node-id", numa_node_id); + if (ret < 0) { + fprintf(stderr, "couldn't set %s/numa-node-id\n", nodename); + } + +out: + g_free(nodename); + return ret; +} + static void fdt_add_psci_node(void *fdt) { uint32_t cpu_suspend_fn; @@ -502,7 +532,6 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo, void *fdt = NULL; int size, rc, n = 0; uint32_t acells, scells; - char *nodename; unsigned int i; hwaddr mem_base, mem_len; char **node_path; @@ -576,35 +605,20 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo, mem_base = binfo->loader_start; for (i = 0; i < nb_numa_nodes; i++) { mem_len = numa_info[i].node_mem; - nodename = g_strdup_printf("/memory@%" PRIx64, mem_base); - qemu_fdt_add_subnode(fdt, nodename); - qemu_fdt_setprop_string(fdt, nodename, "device_type", "memory"); - rc = qemu_fdt_setprop_sized_cells(fdt, nodename, "reg", - acells, mem_base, - scells, mem_len); + rc = fdt_add_memory_node(fdt, acells, mem_base, + scells, mem_len, i); if (rc < 0) { - fprintf(stderr, "couldn't set %s/reg for node %d\n", nodename, - i); goto fail; } - qemu_fdt_setprop_cell(fdt, nodename, "numa-node-id", i); mem_base += mem_len; - g_free(nodename); } } else { - nodename = g_strdup_printf("/memory@%" PRIx64, binfo->loader_start); - qemu_fdt_add_subnode(fdt, nodename); - qemu_fdt_setprop_string(fdt, nodename, "device_type", "memory"); - - rc = qemu_fdt_setprop_sized_cells(fdt, nodename, "reg", - acells, binfo->loader_start, - scells, binfo->ram_size); + rc = fdt_add_memory_node(fdt, acells, binfo->loader_start, + scells, binfo->ram_size, -1); if (rc < 0) { - fprintf(stderr, "couldn't set %s reg\n", nodename); goto fail; } - g_free(nodename); } rc = fdt_path_offset(fdt, "/chosen"); From patchwork Wed Jan 23 10:14:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 156346 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp548507jaa; Wed, 23 Jan 2019 02:17:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN4f4jZ4ImlAT0tUqXwQYjuThsmmRl/h+TUfNMWQOgN7NrX2WvvfmK7gLWZ9qY5ALdtpRRBX X-Received: by 2002:a5d:56d2:: with SMTP id m18mr2079729wrw.113.1548238635684; Wed, 23 Jan 2019 02:17:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548238635; cv=none; d=google.com; s=arc-20160816; b=ChQ7RGem8bLQvPADKTF4MVEArRP84NXq6VG08hX8PfdGVBtvy1VoVIW/oCMz1FzY0U D1GwgjOaRxQNgmJfEl1QQjQN8NkMy9eIHCsEIJtAKxAEFMr4nFrqDam2FADsejUCARo+ EuLNH5Hkmj1vpr3UapB9sB0KlnEze+v+KU1lfsL7sS1FGKVQALz6TEO/vKomr7IN2pjU wuZB/UA6AzelyGw1fgMWZVTKIuDG1pxHbHEjGLoUDEb6mgsnnjextPBFSRVn7hfaKp2h +m+QFTvnuR3TYlckov/mM36KBr1w5VdGqdxnNxuxPNE0RKgCazQsYp9Q17duQ/Nq3zUg GhFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=qyPEKVCJwT6QxU1qhrRf/hFkDsaxVpc15Uu3aLzSPD4=; b=DqblamIdfceaHTVlmvDJjr3PbFuXm9bIZSnYLw9VLbA81iph7x8WtcYtZFfy50PQ7o bc207T8if94WbqQ79SgknSNDtsvjbf2yyeAreo9vk1LYF4RlVaVdEB2mY9l4e5VtSesl /Fe01ZeZGr5jkHwuXC5xwypbGUq1aLsfiAYobStcSH7aubItA7YjY0B0paZUn417bReg fkUjP/0Un7ZZX2EEwjVdYu+VR3XxPoe94ocf9KBxEjAqGBSmzU6xyFaKqn7CkL30W6TM IuQ77PXg8wBFpUVl8QHFY8gLG8jNqyUKyJlKu/z3tFXHAxZTQiP6Lu/uFmuViLu7YV5f ngOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w62si36074153wmb.102.2019.01.23.02.17.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 23 Jan 2019 02:17:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:59679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmFas-0002Ff-GZ for patch@linaro.org; Wed, 23 Jan 2019 05:17:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmFZn-0001lC-0I for qemu-devel@nongnu.org; Wed, 23 Jan 2019 05:16:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmFZm-0007Vw-2J for qemu-devel@nongnu.org; Wed, 23 Jan 2019 05:16:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52840) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmFZh-0007S1-UG; Wed, 23 Jan 2019 05:16:03 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D6AA2DA314; Wed, 23 Jan 2019 10:16:00 +0000 (UTC) Received: from laptop.redhat.com (ovpn-117-91.ams2.redhat.com [10.36.117.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45888601AE; Wed, 23 Jan 2019 10:15:58 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com, imammedo@redhat.com, david@redhat.com Date: Wed, 23 Jan 2019 11:14:52 +0100 Message-Id: <20190123101458.12478-13-eric.auger@redhat.com> In-Reply-To: <20190123101458.12478-1-eric.auger@redhat.com> References: <20190123101458.12478-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 23 Jan 2019 10:16:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 12/18] hw/arm/boot: Expose the PC-DIMM nodes in the DT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com, dgilbert@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Shameer Kolothum This patch add memory nodes corresponding to PC-DIMM regions. NV_DIMM and ACPI_NVDIMM configs are not yet set for ARM so we don't need to care about NV-DIMM at this stage. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger --- v3 -> v4: - git rid of @base and @len in fdt_add_hotpluggable_memory_nodes v1 -> v2: - added qapi_free_MemoryDeviceInfoList and simplify the loop --- hw/arm/boot.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) -- 2.20.1 diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 16f5da02fb..15432bb895 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -19,6 +19,7 @@ #include "sysemu/numa.h" #include "hw/boards.h" #include "hw/loader.h" +#include "hw/mem/memory-device.h" #include "elf.h" #include "sysemu/device_tree.h" #include "qemu/config-file.h" @@ -526,6 +527,34 @@ static void fdt_add_psci_node(void *fdt) qemu_fdt_setprop_cell(fdt, "/psci", "migrate", migrate_fn); } +static int fdt_add_hotpluggable_memory_nodes(void *fdt, + uint32_t acells, uint32_t scells) { + MemoryDeviceInfoList *info, *info_list = qmp_memory_device_list(); + MemoryDeviceInfo *mi; + PCDIMMDeviceInfo *di; + bool is_nvdimm; + int ret = 0; + + for (info = info_list; info != NULL; info = info->next) { + mi = info->value; + is_nvdimm = (mi->type == MEMORY_DEVICE_INFO_KIND_NVDIMM); + di = !is_nvdimm ? mi->u.dimm.data : mi->u.nvdimm.data; + + if (is_nvdimm) { + ret = -ENOENT; /* NV-DIMM not yet supported */ + } else { + ret = fdt_add_memory_node(fdt, acells, di->addr, + scells, di->size, di->node); + } + if (ret < 0) { + goto out; + } + } +out: + qapi_free_MemoryDeviceInfoList(info_list); + return ret; +} + int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo, hwaddr addr_limit, AddressSpace *as) { @@ -621,6 +650,12 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo, } } + rc = fdt_add_hotpluggable_memory_nodes(fdt, acells, scells); + if (rc < 0) { + fprintf(stderr, "couldn't add hotpluggable memory nodes\n"); + goto fail; + } + rc = fdt_path_offset(fdt, "/chosen"); if (rc < 0) { qemu_fdt_add_subnode(fdt, "/chosen"); From patchwork Wed Jan 23 10:14:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 156348 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp557163jaa; Wed, 23 Jan 2019 02:28:27 -0800 (PST) X-Google-Smtp-Source: ALg8bN780TwMtWBw6NXUj1ZKCkZjCl/YUOa2yTurdrfQWdp0YRLHCT+KhAnlU9u8Nnycaoayzosq X-Received: by 2002:a5d:6647:: with SMTP id f7mr1996929wrw.225.1548239307379; Wed, 23 Jan 2019 02:28:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548239307; cv=none; d=google.com; s=arc-20160816; b=kjZRbn2xd3HMNyu/bNog6+J3wVR29KiOvTd3Lyvrf4/QRbdQy53ZEqpLdED+XKwP7g cYtDdkQqyqiCIudS5zRzaXIkGtRbmWLZ2NKhD20byuh67Gt5prT6BT/h8Feg8Jc79lwv Dg4/IY0n6emxsdULl3c1x6E7xC+crvTcsoIv4yhgq9Het8dM92ikhCzAABUYGFyAnqgc hBSfpzX6DPdvhiFU5XOeJd6S9GrAO2gUOTp39xHn1TnZVlrsFjsoCLaRFwUE9IGLejcc bTT2r9VzQXR3pLKz+1E0eu8caBADqFSydtTa3HdcxkvzqA9Yahtxf2HdjdezSIQOOHjP IYOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=e57LzUlp9l0sSejkIz5IsWxGrX3HvfFUg/ZGPgRJkK4=; b=h+gnTejg3uNIakg8tbJebPcUiTcyAFZ/aBE/mf/aw/Ij8z6rDUW1BJzBclgzl7N5lX kf3yaswZwYl2wIb/cjfEvVQxno1cDbU+MKzR7VetAU084ApvAXSmQtgnkvbTKbZeeDAG IDkjZCipuqjK2zHksSeSPsJbQovqlN7WpOAGW/Ziss2j5hZVaWFlB140y7/3WPOrI3hh tQuZYZBF8pHuxoAG/GRKpJqfmeA+7GVdpihlz/cdtOniGF/Wdn7tsVtWdmlz+pumdgQM rIIfPcnWYe8iy0muChQlEdJBcVQlLmwDYf9S3NJPjW+HTKBIuPPy/6nTlLbXymG/jjJN oIYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q3si68744525wrx.388.2019.01.23.02.28.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 23 Jan 2019 02:28:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:59866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmFli-0003dH-Cg for patch@linaro.org; Wed, 23 Jan 2019 05:28:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmFaF-00026s-0q for qemu-devel@nongnu.org; Wed, 23 Jan 2019 05:16:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmFa7-0007fJ-1A for qemu-devel@nongnu.org; Wed, 23 Jan 2019 05:16:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52950) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmFZr-0007ZR-EM; Wed, 23 Jan 2019 05:16:13 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 505B580E7B; Wed, 23 Jan 2019 10:16:09 +0000 (UTC) Received: from laptop.redhat.com (ovpn-117-91.ams2.redhat.com [10.36.117.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3765560192; Wed, 23 Jan 2019 10:16:01 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com, imammedo@redhat.com, david@redhat.com Date: Wed, 23 Jan 2019 11:14:53 +0100 Message-Id: <20190123101458.12478-14-eric.auger@redhat.com> In-Reply-To: <20190123101458.12478-1-eric.auger@redhat.com> References: <20190123101458.12478-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 23 Jan 2019 10:16:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 13/18] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com, dgilbert@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Shameer Kolothum Generate Memory Affinity Structures for PC-DIMM ranges. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger --- v5 -> v5: - Align to x86 code and especially "pc: acpi: revert back to 1 SRAT entry for hotpluggable area" v3 -> v4: - do not use vms->bootinfo.device_memory_start/device_memory_size anymore v1 -> v2: - build_srat_hotpluggable_memory movedc to aml-build --- hw/arm/virt-acpi-build.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.20.1 diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 829d2f0035..a2feacf6ce 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -516,6 +516,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) int i, srat_start; uint64_t mem_base; MachineClass *mc = MACHINE_GET_CLASS(vms); + MachineState *ms = MACHINE(vms); const CPUArchIdList *cpu_list = mc->possible_cpu_arch_ids(MACHINE(vms)); srat_start = table_data->len; @@ -541,6 +542,13 @@ build_srat(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) } } + if (ms->device_memory) { + numamem = acpi_data_push(table_data, sizeof *numamem); + build_srat_memory(numamem, ms->device_memory->base, + ms->device_memory->mr.size, nb_numa_nodes - 1, + MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED); + } + build_header(linker, table_data, (void *)(table_data->data + srat_start), "SRAT", table_data->len - srat_start, 3, NULL, NULL); }