From patchwork Fri Jan 18 14:03:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155933 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3290659jaa; Fri, 18 Jan 2019 06:03:42 -0800 (PST) X-Google-Smtp-Source: ALg8bN7wXt+yGUo2lnHTH7ac8XRKgMhLqNJwQK7bLurlcy4sAMGpWPPGrdaDdHkHm9uvUILvnzDa X-Received: by 2002:a63:557:: with SMTP id 84mr17375806pgf.411.1547820222899; Fri, 18 Jan 2019 06:03:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820222; cv=none; d=google.com; s=arc-20160816; b=MgXI4GghxQF8bhKFNJI+LIuO8KbOBqY8hAaA4eHo8jIOg068QmwpG70JS/6tm7OiWi o5kpE0swWanznhjWPiCVQjM5EJpbU08fi/1bE0XMyO1KsN9j1WRKZDPnGGsnc2WLPllF dhSQ8GCtg7X++1F0vIqSNB0D2o9OUcb+yXkX6xUbPXESxo1KpZMqZy8rjUwidyWM+6Pm H56R3ex7H+kmi1yA4xhs78aDCX429o4QHJhFLBjvBC63n0JhblwH+04ro9yAHl9Wnigk jp5WZapODg7PihwvgTeDcccg9jgj+h+FbMCbYhRwHH35qL/jQhLURmJXNST0I6ZIqfD3 gEOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sEQntTSMSzloJbJKItQL/Y0eCsx+0HRyKgqFsac2X4A=; b=AhYR8cipGgDZua8FrQxzE1KbpEVA8ermy5aUoHkFkdWePgj3cYpScz3YaEwMlSSp4q fA2dKNhR5AHTw44ZBMv2Oicgghfwq0kCAWk4m8PZ0Dc16g/VyHNZ58sddfPIufmselXU HYUgYXsaCBLqDj/vCvMa8MhuHxV8fKJTFban9g/YPFrP5a2hNiAmF4VemmeNT/21zSct FDHwBL2WDH3yVs4SIijdWgL00Tuqr44UovoA9bixVGjNTTmVlm1E/nlOvcTuS8sYH2Lq LShn5sDkHvSkwhzdfgm8XHNZ9w40b9MQaLtYK0yV8LDjFBE3weYpFY4j/L6qbUFpGeqH wB9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cPe1W2uk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s11si4521097pgk.344.2019.01.18.06.03.42; Fri, 18 Jan 2019 06:03:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cPe1W2uk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727542AbfARODl (ORCPT + 12 others); Fri, 18 Jan 2019 09:03:41 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51449 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727285AbfARODj (ORCPT ); Fri, 18 Jan 2019 09:03:39 -0500 Received: by mail-wm1-f65.google.com with SMTP id b11so4618190wmj.1; Fri, 18 Jan 2019 06:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sEQntTSMSzloJbJKItQL/Y0eCsx+0HRyKgqFsac2X4A=; b=cPe1W2ukeE/BxfcSLkU4cf2uNzCL4X2WMZ6EcEj/Q8GTgGYMJf8XxHolt76sPRzxsN gkVeLuJi3fsmr3N0pcCcnUi1zl0xlVcQytXZJjcfkmB6BVUfytc3x+Df9jb4ikgcYsBZ rTW1zsNY5Faq9hvvQIWR8pFJu43sLi5zXu0wi1tb1xYtaS+GvPBsh0t8XxgVqOpJYukK dkiYAFWmSVTFeZ8MsLooULG2ogeLquVjU595O6zag6IXUItjouX9A3eOTpXulR62FRVi Xtnh4Hydt5lfgqMNwXUwJgm4b0fk9NE7k4aPYfSS8wB4bQAiZ6qz3fhyBg6OWkS4Us0L sCIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sEQntTSMSzloJbJKItQL/Y0eCsx+0HRyKgqFsac2X4A=; b=K+ZC1Yzq7vLO0w1wflGlw9xwfym9eOX/KyGB+frptYPTKVhcInvM0gKUoHivIiCj0t tJQ3Z1ZvPfm3eu8E7Zc+CBNtKmOOvAgGlsyiHhGhK2ifwe6xLLZuS3BzooPbW/dzMNqq 1D9TfLxECvbQt9DR/uFGdoPBiKmE2HToSdluN37YhkhQelmZaLUNhEBiReG8CrkrfQWl yEmFhqAURFlgU+W7bzcDK+3us+Jw6y258NnfB1O++kNNDV83wNbvpIwaBG/sx/xbDpGz WKa3WXDWjr9xIeRpN5zVFG/1N/4lzSrZ4pDPvTL1jeTmwxlZjqZETUZL9TdLSlbhDrGA v9HA== X-Gm-Message-State: AJcUukfowuAeHchoXkX4ONcfmdeZho5enUvNMXOEjBDF/Bw+yO2/6gYS pIWvin6UIBxdWQsFJ0wdOAM= X-Received: by 2002:a1c:4108:: with SMTP id o8mr15369849wma.91.1547820217059; Fri, 18 Jan 2019 06:03:37 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:36 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 1/7] hwmon: adm1029: Remove write to FFF paragraph Date: Fri, 18 Jan 2019 15:03:23 +0100 Message-Id: <20190118140329.18970-2-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As suggested by checkpatch, remove the "write to FFF" paragraph. Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index 8c5cdb560258..3dd4c84ec89e 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #include From patchwork Fri Jan 18 14:03:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155939 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3291338jaa; Fri, 18 Jan 2019 06:04:13 -0800 (PST) X-Google-Smtp-Source: ALg8bN6KjnZie5MHcYis8xxDFtnBmuYK0o+adf3xlbiuq0Rq2BlzOifgS646FE9m+EJtrpiM+C/R X-Received: by 2002:a17:902:4401:: with SMTP id k1mr19454094pld.307.1547820253646; Fri, 18 Jan 2019 06:04:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820253; cv=none; d=google.com; s=arc-20160816; b=A9T31nWhpsVxZdsDEBNBPxoL8p4jVCxar5K4rDM0nm+83uqwz/JADWCUhfp4GDEcX7 X5dhOml4yq2gBwWPLZGXO3D8OtlxZpTufB3NR5ZKQ67qGBAv+VUQTquwDNd2sV1ogPZX ph0uUoVwmYgJx3/5Gp02tUAZSXt6bzhEEbe+7sIztMbmTGVsHqBxT6df5kynBdv06A/o /FptYVUw7tE5wBGRRJPs3m89EMsVd/aVZwVPc+qgyw5WHrhJKVt0wJhEaK0It5lzbakv 5ax2ev2ivbBCRJuMWId/DfXBMNJcwIyQy2IsjUHxlSVYjiod7foi15ImCjmt9ogbvuWJ d6Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IrXf9aiRakHb+ciyKcO/4OLDAyZp5iDcsk5OFIZkBaA=; b=0r9kRngt1fToNgj4kb/f0WTIgtsenZYK+J1gzI0ebUXtol6iDE9BcYUqbBtBjXrpUX XbIQ1ZUribdlLFJtYLMGzOcOg1Lr5HP73xLDgUFA+8Y0nDoD8NS7v/hVNi9+imm3tVWI 6c2Or7wT+UBojzqetH7C9Fa49tir12il65oggeTb+zKV4nDP+NpO/2uPwKlYtwWKQ5ce 8J+3WHNN3rYHFqRlmfQ80yByikq+TnP+OE5pIZihrEviEQ3e/Bi+NM2vaRbUFmGp6E1h +QZpYO+SyqY05XV+HZrhF1ZfVGzSqLczuny6Iistqxya8qEUyFs0jN8tncP+qW1NCYhe txfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BME3C63u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e93si4919691plk.56.2019.01.18.06.04.13; Fri, 18 Jan 2019 06:04:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BME3C63u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727740AbfAROEL (ORCPT + 12 others); Fri, 18 Jan 2019 09:04:11 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40597 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727080AbfARODk (ORCPT ); Fri, 18 Jan 2019 09:03:40 -0500 Received: by mail-wr1-f65.google.com with SMTP id p4so15192884wrt.7; Fri, 18 Jan 2019 06:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IrXf9aiRakHb+ciyKcO/4OLDAyZp5iDcsk5OFIZkBaA=; b=BME3C63u5T7m0M4cxqVV4yvUDQDw8S1K8PHbxgke2dvfTWiaAkUKTHMIYaVi60qHZj SJps5ddXj2o/c2XDeaVGfQ+lNx4WFZmRJ2WPJAU6zrtFVCRReMwtGkYCNyusrnwa72Hn fZ9VXB+QvsClBSc+7KDn4O1O9lpwfJ+Ja5kZuJKbIuUf0FEyNDp7wUXUfPetEObSlWa7 TkTIcfzHDpl6Rdwylfkt9mnVIiuGH9YyVeR1KubQNFmBziNRGLTn34z0C7/2NzOAFgsP eiHw8NezVL6UebwUD0AS/hKrEVZ0G0VZUAm2rC0dst9Al0EibBBRb3BGfpXW1ux5tfz9 85lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IrXf9aiRakHb+ciyKcO/4OLDAyZp5iDcsk5OFIZkBaA=; b=dNUVqqCttxqSf+OSVFEZEiefLMOWMRRTghEo7hgOS9i/+X4bJkg4RIWA6jypNGiv0D uHQ1sQZXbb+ZIJ5mDuSTrW3amA6UDPuHSMqKOZPXpQZX4GsXwRvsaJWoR+WNMXv7GgE8 AE2j/eaPUpe/B9b1GaP17KbRAREuYrZRFNyJ2VZI7JncVhy/HKzC6I+94FyZMM4Htd+H 5ZOR/WFtwPua5MhTNj15AviliufxoXgINy8AWXOf9ocBHDXaVYsuNuQLi87Zdrdd7Ul9 rn3Iux4JXGD4PbsCIgqmjIP54F2vj34bnBVECrq/M/shTlDnBTRBePPkGu4JwjjoCadR yd6w== X-Gm-Message-State: AJcUukc1WdXhDe70S5VPa3/ztfRDjA9i0tdp7yTZRmMVqvWpC1JrK+BG k7QeiTe9ealpNlcaOmsBgwE= X-Received: by 2002:adf:ecc8:: with SMTP id s8mr16283513wro.208.1547820218147; Fri, 18 Jan 2019 06:03:38 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:37 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 2/7] hwmon: adm1029: Add SPDX header Date: Fri, 18 Jan 2019 15:03:24 +0100 Message-Id: <20190118140329.18970-3-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch addes SPDX header to adm1029 Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 1 + 1 file changed, 1 insertion(+) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index 3dd4c84ec89e..381bfae6b04b 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * adm1029.c - Part of lm_sensors, Linux kernel modules for hardware monitoring * From patchwork Fri Jan 18 14:03:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155938 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3291243jaa; Fri, 18 Jan 2019 06:04:09 -0800 (PST) X-Google-Smtp-Source: ALg8bN5tyv+/ZReyjXJ4gjp+05liGweUIe51qAjv3KeSdb8I5CLtLolq3dBIzRpk0//D4mYCuipv X-Received: by 2002:a17:902:50e:: with SMTP id 14mr19111761plf.141.1547820248956; Fri, 18 Jan 2019 06:04:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820248; cv=none; d=google.com; s=arc-20160816; b=BUeBisVP2wVzn7GC+fIWEJsafQ8JZa9vos/jI1oq81VSNlA8MxkmFWlwfyRMs/GjYa +nAe5sMhMA4siL5eBRrHOBFasYUPGZHFGdLahYWvtN6fPYErRG0wPUcthejMY1Vhmazy W8LGv0uVQDWtNpkXKUxSY4PZohuoSRwdUQYiTuPO1pokl4TIOWTDgif9tBfk9ecNxMOz LD6+yr2L78UeZiHme8whtTV1wiAHxwQhJOQpeO0uRpKpdrpHFPcFkIpYkFfjJx3M+ne8 b/2xV7M4wsrsy26V9ZD9vjBD3TqVrnVEYC5qyniUZWEVcaL2+iqaB+JNcj6FTeGYRUzo Ykxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NUYEzC/vmFZgItCQvOymRNmQxHG9/z8q+s/lyY68E14=; b=EILnt3wkkNitUYwBcBu/I7Tm/QbGbfH2b9Jks/7XNETaEhDbuiy/Uxni3724lAoRdC Y16zQLC7Y+qdE9vHS7LJb4w5ArjWBIo5rQNWovsNRmrSMKPZNtUUhSGmKONFb0jr1nHM 8ZQvWgZlwqLTe2gqkS3m1Glz9RGWOKO5ql1sJ/2clH1SfHUDthFJaboPaYPKxi320coM uCGuDgCH4Uy6+dN4pQtXQj0rUiQox2WGs2k8F9+uql6gEwlk+1D5LoZicPpJ5Jm6YU3+ N7wxow7DRKU7B8eH+L4Q/DdT782KNysCPspNUx+Wqi+df26L8NLHB0RqmGtIKlTxABiC 8ygw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Wt/puWrC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11si4874306pfk.210.2019.01.18.06.04.08; Fri, 18 Jan 2019 06:04:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Wt/puWrC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbfAROEG (ORCPT + 12 others); Fri, 18 Jan 2019 09:04:06 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33839 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727489AbfARODl (ORCPT ); Fri, 18 Jan 2019 09:03:41 -0500 Received: by mail-wr1-f67.google.com with SMTP id j2so15273423wrw.1; Fri, 18 Jan 2019 06:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NUYEzC/vmFZgItCQvOymRNmQxHG9/z8q+s/lyY68E14=; b=Wt/puWrCW+zAnEqKzUdMLeqWq0K7shRYilkopyRSSqaUG4WD0389NBCYrRjlDfcCo8 PunE6m8ZlvUeBnF6nYo8Y5cS7V0VHtsuYwi4o2vDXMfGUOMSePuM9Im5A2lcvELb8THQ x9W+9nDjRv8wyh1+o+4To17CF6RfbuY5F4LAh4j4Y39KzEh1YeqIZ9VO7a4tsrdKj4LK uRq04YKa2g4+PNv26eOsPVXlREjV++skVvTRKKEnZynNPQPVbRntE/vFgq9GcVTy8CSo 4GrIxdLRy+ZZn0Qhp0A2YHI0gBUDkUeUUBId5BkHlFfHTC7wz7B/qT3I5Uj+ttCdetNk k6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NUYEzC/vmFZgItCQvOymRNmQxHG9/z8q+s/lyY68E14=; b=d2y+qJ4NM71TDbHG0KGcFmAJgeddQpxsAfg86rhf4MUi/JSz3QZa8GmOHlS4OUZvz5 8sJs2Quvoj3IqfqUTdBC/Wffsb2Co3HmwEd27jiRlummW7eVrawr76vOibkCEVTpx7Ic oOOGbPISSI3uy9/w/uEqnCDtbxxGMsWBfHjZKNX6gPX7Xdp8o96nD6FJcS1MgvUv+i+N 7k5OSRS37nqmUQZoDgBgtwxw9IreNhF7AdQJXvc7Wg1B8Ru3VM/OM1WkKFrO/6kutQuc ogsJidUEd6+t4Oe/5nCIuW95ahlfQYmtmmNz3/DKHJzAnKcv5nnO3OEgGXutDcxMDZXT /o8Q== X-Gm-Message-State: AJcUukfZ0PP/BmPDLW6dXI8KMBZDASjwFh6T08n8tgdjG/bFYEk+kXoG pf3nNVr+EZYLLkfsJw2YM4c= X-Received: by 2002:adf:b201:: with SMTP id u1mr16428812wra.165.1547820219274; Fri, 18 Jan 2019 06:03:39 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:38 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 3/7] hwmon: adm1029: replace S_IXXX macros by their numeric values Date: Fri, 18 Jan 2019 15:03:25 +0100 Message-Id: <20190118140329.18970-4-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As requested by checkpatch, this patch replace S_IXXX macros by their numeric values. Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 37 ++++++++++++++++--------------------- 1 file changed, 16 insertions(+), 21 deletions(-) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index 381bfae6b04b..092f16ad774f 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -250,32 +250,27 @@ static ssize_t set_fan_div(struct device *dev, return count; } -/* - * Access rights on sysfs. S_IRUGO: Is Readable by User, Group and Others - * S_IWUSR: Is Writable by User. - */ -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0); -static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_temp, NULL, 1); -static SENSOR_DEVICE_ATTR(temp3_input, S_IRUGO, show_temp, NULL, 2); +/* Access rights on sysfs. */ +static SENSOR_DEVICE_ATTR(temp1_input, 0444, show_temp, NULL, 0); +static SENSOR_DEVICE_ATTR(temp2_input, 0444, show_temp, NULL, 1); +static SENSOR_DEVICE_ATTR(temp3_input, 0444, show_temp, NULL, 2); -static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO, show_temp, NULL, 3); -static SENSOR_DEVICE_ATTR(temp2_max, S_IRUGO, show_temp, NULL, 4); -static SENSOR_DEVICE_ATTR(temp3_max, S_IRUGO, show_temp, NULL, 5); +static SENSOR_DEVICE_ATTR(temp1_max, 0444, show_temp, NULL, 3); +static SENSOR_DEVICE_ATTR(temp2_max, 0444, show_temp, NULL, 4); +static SENSOR_DEVICE_ATTR(temp3_max, 0444, show_temp, NULL, 5); -static SENSOR_DEVICE_ATTR(temp1_min, S_IRUGO, show_temp, NULL, 6); -static SENSOR_DEVICE_ATTR(temp2_min, S_IRUGO, show_temp, NULL, 7); -static SENSOR_DEVICE_ATTR(temp3_min, S_IRUGO, show_temp, NULL, 8); +static SENSOR_DEVICE_ATTR(temp1_min, 0444, show_temp, NULL, 6); +static SENSOR_DEVICE_ATTR(temp2_min, 0444, show_temp, NULL, 7); +static SENSOR_DEVICE_ATTR(temp3_min, 0444, show_temp, NULL, 8); -static SENSOR_DEVICE_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 0); -static SENSOR_DEVICE_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 1); +static SENSOR_DEVICE_ATTR(fan1_input, 0444, show_fan, NULL, 0); +static SENSOR_DEVICE_ATTR(fan2_input, 0444, show_fan, NULL, 1); -static SENSOR_DEVICE_ATTR(fan1_min, S_IRUGO, show_fan, NULL, 2); -static SENSOR_DEVICE_ATTR(fan2_min, S_IRUGO, show_fan, NULL, 3); +static SENSOR_DEVICE_ATTR(fan1_min, 0444, show_fan, NULL, 2); +static SENSOR_DEVICE_ATTR(fan2_min, 0444, show_fan, NULL, 3); -static SENSOR_DEVICE_ATTR(fan1_div, S_IRUGO | S_IWUSR, - show_fan_div, set_fan_div, 0); -static SENSOR_DEVICE_ATTR(fan2_div, S_IRUGO | S_IWUSR, - show_fan_div, set_fan_div, 1); +static SENSOR_DEVICE_ATTR(fan1_div, 0644, show_fan_div, set_fan_div, 0); +static SENSOR_DEVICE_ATTR(fan2_div, 0644, show_fan_div, set_fan_div, 1); static struct attribute *adm1029_attrs[] = { &sensor_dev_attr_temp1_input.dev_attr.attr, From patchwork Fri Jan 18 14:03:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155937 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3291071jaa; Fri, 18 Jan 2019 06:04:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN7P24yKgc+VuQuwbn3fJIeKgKkRJhanpstJYOxLKz8fWh/1+oscijLlNRfIWYu9hhyJGzqq X-Received: by 2002:a17:902:6683:: with SMTP id e3mr18553907plk.93.1547820242130; Fri, 18 Jan 2019 06:04:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820242; cv=none; d=google.com; s=arc-20160816; b=xvz/7x5MXEwUa48kKQVGowkMBdfGStG1yW3x51fEuuKA1ArRGdwDI6QkcT8ivHjBae jhMxgv3vdWolIXHmKLykjtXtQsns17g92aGDER2qEo+5R9maLE/lfJWAzcydwP1La3BD 0+JchYZyTa9RIKrZDUADubREw4hT5FFyFfRhjziS2hz5gaqzHeF8q03CSaaLlWQZ1qHC sEKLHK6ecJ1emIqCmKXTq9jwRmHhfQnZejK455N7COlGNDBgoCf4lFmy9eU0JfSyg19a Oxi7WGLtnMAbDGhlDKs7rpsoBpFy9l2PyBoIehj4bxA4Ocm2q8q0SpMBD9jcHv2kkC+8 T/ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vCzxSPy+FzZRjZn8HTA+OyQdWgf2KeAGuCfMKZTF/eE=; b=sdYSZxYq9yfNzBKDDiMAgjQ4m0OKbVUdw3RlHtc5I0/YhUqZ3O0+VVxbMr8FhoAxUc itHsFHpxsvfElyxwg+UZJ5rHCX0uBtoYpClDa3O+kpCHWjCcKp5pRDYIK8IjfPw+rCxp rjzCBnepNPVMzbOtiY1/fph02q+JxgocUw3QHPmd95YtyoEq56BbfKx7cY1YquoeGm/k WXYaCx4ppuRGqjB4KBAAl+DBskujjvWD76PWMToDo5kbZLHrp/nejpLiOMG3uoGF2TfM KnqlSqCqQ+Iu0EEb1hfcQKdmEMMzyfqalIcQTRqhHMJbx99F54pJQ3ZJWq+7v7y8Xs23 2qFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Dn5D22rd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4si4770429pgj.61.2019.01.18.06.04.01; Fri, 18 Jan 2019 06:04:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Dn5D22rd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727588AbfARODp (ORCPT + 12 others); Fri, 18 Jan 2019 09:03:45 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41876 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727524AbfARODm (ORCPT ); Fri, 18 Jan 2019 09:03:42 -0500 Received: by mail-wr1-f65.google.com with SMTP id x10so15157635wrs.8; Fri, 18 Jan 2019 06:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vCzxSPy+FzZRjZn8HTA+OyQdWgf2KeAGuCfMKZTF/eE=; b=Dn5D22rdXlUC6LOdZ47CDE0REV4rkFHQYoewqEmLB5+xhG3c/URKIKSJeBu2IrTuhZ uWGsEmlBX/4jOxv/GYapduBe89+uM5VBcoGsr+icLa91eG9bxHq2Kt0WqazBmNkKZG3a NpeoGd4cycMby8azEw0+RWujKsZlXSo/YGyv4JOHV4SdyT32hJBRoc8Vk0wASWPWjyEv 0c8eyWfVuVgX+Twq5CltUZ3D3ztJ1aclyxYiKos7VTCbm/9+vQ2agPQHf22nwtCFxkg4 DZdSuJn9/W9OBEOKXbsGPlnDCqHM2+nUS1XTMOTE8zW5tOEHHSgl7zUy5GDXFlR8QivK PoVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vCzxSPy+FzZRjZn8HTA+OyQdWgf2KeAGuCfMKZTF/eE=; b=oi6ClTGrucA08grSGXY9Kq7nMklHcjKGkQPQcV/VxaIgkmJQPys8+9Z9946gPghBMr ld4T/3NFDABqBFmCs3zyFq88fyWt0sAfc6jsqWEgNpOnYk9heVGnlL77AwB6VokVK8K/ iDRv0FZDWL5M0ToTV5/UhoWlyxVl5etcxQQMXRwSPv3a0wMsNR1iRT90z1zYykAB20S2 xvtS1I2muxZ9Ay+KKDPHyMfrOj/h9Hob3jngP9ihEQHuIUAGbfTC+HaUghssjoOYID6/ 25tU1OLG53A51hIfNsnuYAUTsa8Cs8VxTK4RO1DnODlm3qQ64lVx2Xb2BBQLaN0ESFej DCCQ== X-Gm-Message-State: AJcUukfPfMtkgigThelCLRpKjhjYrhaVVSiJJ4cG8Nv14OwEaSkR6Gz0 20PA7S46SOuUea62nrEE900= X-Received: by 2002:a5d:6152:: with SMTP id y18mr17624308wrt.141.1547820220427; Fri, 18 Jan 2019 06:03:40 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:39 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 4/7] hwmon: adm1029: Add blank line after declarations Date: Fri, 18 Jan 2019 15:03:26 +0100 Message-Id: <20190118140329.18970-5-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As requested by checkpatch, this patch adds a blank line after declarations Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index 092f16ad774f..f9f4f1f4a4c7 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -171,6 +171,7 @@ show_temp(struct device *dev, struct device_attribute *devattr, char *buf) { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct adm1029_data *data = adm1029_update_device(dev); + return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[attr->index])); } @@ -180,6 +181,7 @@ show_fan(struct device *dev, struct device_attribute *devattr, char *buf) struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct adm1029_data *data = adm1029_update_device(dev); u16 val; + if (data->fan[attr->index] == 0 || (data->fan_div[attr->index] & 0xC0) == 0 || data->fan[attr->index] == 255) { @@ -196,6 +198,7 @@ show_fan_div(struct device *dev, struct device_attribute *devattr, char *buf) { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct adm1029_data *data = adm1029_update_device(dev); + if ((data->fan_div[attr->index] & 0xC0) == 0) return sprintf(buf, "0\n"); return sprintf(buf, "%d\n", DIV_FROM_REG(data->fan_div[attr->index])); @@ -210,6 +213,7 @@ static ssize_t set_fan_div(struct device *dev, u8 reg; long val; int ret = kstrtol(buf, 10, &val); + if (ret < 0) return ret; From patchwork Fri Jan 18 14:03:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155935 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3290871jaa; Fri, 18 Jan 2019 06:03:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN7bTGPQHs2gEK9f0M2npInwzfb2E4HM0oRiy3ZuWgLW69OgDc9KJNAk+TMr27/RZ4YSPioB X-Received: by 2002:a62:6799:: with SMTP id t25mr19444405pfj.139.1547820232117; Fri, 18 Jan 2019 06:03:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820232; cv=none; d=google.com; s=arc-20160816; b=CyEFY3R55jHNLqXIVmhA52gW10AVPIm3PL9M6+dP4CSidRphjbGBGfwp8ojFjCvCGy RUTxWIitm/NZOkaT0NvH7YHWbMJN4KERJtsopOsda9H2zkVImHwXt6CjVfBlbGRZaV90 5FEk7tG8r/7cNmMpMc1xw/rfzUwvteqLTtkNiHOAGeoAGMhmiK92MuwT0A1y/M3FLaS6 +78t9/p3I3zTTu6QmeLn0okMGs5sPyUFP4beipWeTJBmR59SCwIQCqJ3vYz3XeHCYvBo VDnv8Gsq3kg+VTm+9MbPPBLZz396Ir5Uu2nWRj4YVMBdO5OO+CQl2A5mKqT8ru4CHKxm YHuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=52hWXrVesE9hsYVcvtF6fWpIkVgqCxxIYdkUhzqrpz8=; b=bfkA33cuuaiE6M6DbK1hzt/dU0sfapxvx38zh7RJHIpt+zuwCNP4uOm/GYAigEt8rP 1NHZ6jE6mdTQ9gExADqUoYZVRycmGI07oJkkFj0qeE1q/ip+7c8g3NtXJMr33VDezDPt JXFFBVoa7YedayWJUlwj/HxoBPqtmtVvlbnBQvstUPqWP2sCw4eTHLvt1VOE+NA1dUC1 85sv4hti3Ii6OssjF60l4ufhAzfmb4gtaigP58ajIGUw8Nfav0w7ahivANrXEif+c0x2 svOMhu0gVt2qw2Hqz5nrQCO4734vPfNW3HNQ3q5z728303Hcexl7ZXc3lnXZmY7LTVlH pCOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EooudYQj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si3448811plb.209.2019.01.18.06.03.51; Fri, 18 Jan 2019 06:03:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EooudYQj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbfARODp (ORCPT + 12 others); Fri, 18 Jan 2019 09:03:45 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50281 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727285AbfARODn (ORCPT ); Fri, 18 Jan 2019 09:03:43 -0500 Received: by mail-wm1-f68.google.com with SMTP id n190so4631504wmd.0; Fri, 18 Jan 2019 06:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=52hWXrVesE9hsYVcvtF6fWpIkVgqCxxIYdkUhzqrpz8=; b=EooudYQjYAyQVnH01dtyFpFmvjNbyz5EvGFVvYLY2VvATnvqjEY01XCZ1/PHkmq60T QUJOoHTJt1i2OPCZY1HELOGT1zMHL8Rq7uJO04W60uPo8soxOXurj27qP/ft7/xOsCVK 2m33r5yQfb2cisVOxJeAdyQG01mF9iaollNmF2ZTNFpGMAzxv0DAacaUI1Hl3yjYYT9P 5teW7gk/TBZevv7h6mPHeukCTwj0aUTQYxIX3BK54iJ8ufSlmLpjVOjp9jPO5yEtsvYo KKnPEcRiwNllQygPHuJRja4IHRRqNcvYowloif1boMaajzcx7WW82vGu/g56RH1Ed4Ej JxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=52hWXrVesE9hsYVcvtF6fWpIkVgqCxxIYdkUhzqrpz8=; b=fq1frvln0LetXNV/1pqR/Gf71CTLy1+UAWBg/TXTmUoKVw9Nlx9xp85kwK/dMXxaFr cMxLYMMKv/K5sQvfdIw8+HgCaOJ7GUw1lF1yqcnotU+O2PRiWJSejHBQp9hJ6GfRiF+k 77CQ9ODvBTrSqMQsCpRv23xxXGzHmZ00PL5traKFewtYCsDXAWPPUaeKbSJr8/EfDGV5 cU3vtFyYuisQ67PA+mEsRyF27lZF+e1EfRR1w8PL3L+YLNFxSb2DhTp0q/kpTdI0a1tr xCW/IKjzSb9tjx1aD4EWRZAnprtIl3noOfBMugpUwibHUf69YZuvTSYsaCimwDAsNTG2 f/+Q== X-Gm-Message-State: AJcUukf8zTV9nvc60Q8ZuSh0alZr4tzrr1aVFdMvZlphEAcSWREAkzCa PUV9Ky1+RY1kAQggO4F0FwM= X-Received: by 2002:a1c:f319:: with SMTP id q25mr15832227wmq.151.1547820221550; Fri, 18 Jan 2019 06:03:41 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:41 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 5/7] hwmon: adm1029: Fix Logical continuations should be on the previous line checkpatch warning Date: Fri, 18 Jan 2019 15:03:27 +0100 Message-Id: <20190118140329.18970-6-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchs fix the "Logical continuations should be on the previous line" checkpatch warning. Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index f9f4f1f4a4c7..4339f6b864a1 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -131,8 +131,7 @@ static struct adm1029_data *adm1029_update_device(struct device *dev) * Use the "cache" Luke, don't recheck values * if there are already checked not a long time later */ - if (time_after(jiffies, data->last_updated + HZ * 2) - || !data->valid) { + if (time_after(jiffies, data->last_updated + HZ * 2) || !data->valid) { int nr; dev_dbg(&client->dev, "Updating adm1029 data\n"); @@ -182,9 +181,9 @@ show_fan(struct device *dev, struct device_attribute *devattr, char *buf) struct adm1029_data *data = adm1029_update_device(dev); u16 val; - if (data->fan[attr->index] == 0 - || (data->fan_div[attr->index] & 0xC0) == 0 - || data->fan[attr->index] == 255) { + if (data->fan[attr->index] == 0 || + (data->fan_div[attr->index] & 0xC0) == 0 || + data->fan[attr->index] == 255) { return sprintf(buf, "0\n"); } @@ -325,8 +324,8 @@ static int adm1029_detect(struct i2c_client *client, nb_fan_support = i2c_smbus_read_byte_data(client, ADM1029_REG_NB_FAN_SUPPORT); /* 0x41 is Analog Devices */ - if (man_id != 0x41 || (temp_devices_installed & 0xf9) != 0x01 - || nb_fan_support != 0x03) + if (man_id != 0x41 || (temp_devices_installed & 0xf9) != 0x01 || + nb_fan_support != 0x03) return -ENODEV; if ((chip_id & 0xF0) != 0x00) { From patchwork Fri Jan 18 14:03:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155934 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3290792jaa; Fri, 18 Jan 2019 06:03:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN4uCIUjwrqYqeP/GdYDEyu2gabVReT56VdFN1wOyDFI437TP53aoQ8EgpNd2p5rQ1d7gOWq X-Received: by 2002:a62:7dcb:: with SMTP id y194mr19606269pfc.113.1547820228503; Fri, 18 Jan 2019 06:03:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820228; cv=none; d=google.com; s=arc-20160816; b=Kb3cZiSTkmviwiAZSv3quLLth3/f+Y6CGvwXqATPszNBCPWGZyKgYS4JvcPtEM5EED vTUh0LzAFjD9YCjkLr+Uwv2wlqq6WxVYImgql/KuCo5yyu++6pObaEory6lLe2F0umjS m06uegQMbaqDt0um7L9wJuu9ds3z+JKw2VHpCPjHTXm8FaxgL//Sog6IqmUKXJKJxXXO C5PDecelhb9a9N6oPTAXkJJ7h3ehlF+nq3bEgh8SnQLaudskUueoiVqKgNxdHZxOiK/7 JebW/Omg7Q4hKsFKjOp9hxYCppZo5MZDH/1c6hSPyCx9UeE/O8GFFr9yUD3g0wdIXuvt gftg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w7Ai0hltg2jalPdM8DZ6LIbqR1s61sezTuxMf4F3h7I=; b=A61wX24UC2UFpR+kmMnUNPXC4/20ogSk7SJXc2GLDrAKRrPajxE4y6ZPHdYNnG0JR9 J8hyswQZug1GQmNdg1geViACevQ1zPSZuCuoI3ANmze7zBGj4eAfDY4fw/MrDAn+L359 j5X6uXf00EqexsxBALqalzJ9nV2UKtZgXCQ211HWdBuFa2w464L6x//ywkn8Rno7sK9r IcPEjV5Z2ZA+rnCgWKgcOcGcBL4OCRGh/hAJIBhkSy+GfJ5lJOX+wK2pf24z9uTiwh9M QGhAeXiOU3mNF8KtgD/zBKtupHKp3sUPFW15SXU54yd+P1/h+k3579SP+d71P40WfIQs 4o3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VFTqonkv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si4679474pgl.153.2019.01.18.06.03.48; Fri, 18 Jan 2019 06:03:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VFTqonkv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727655AbfARODq (ORCPT + 12 others); Fri, 18 Jan 2019 09:03:46 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51462 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfARODp (ORCPT ); Fri, 18 Jan 2019 09:03:45 -0500 Received: by mail-wm1-f68.google.com with SMTP id b11so4618462wmj.1; Fri, 18 Jan 2019 06:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w7Ai0hltg2jalPdM8DZ6LIbqR1s61sezTuxMf4F3h7I=; b=VFTqonkvdFADx/zms1yRuBIFRbi79hFhXVsaEYJbVAkJWYqlTgDLYefVjgziLNb0P8 w1Ngu+7kXmZOoh//mKJQjG16H7DsWZwj2kbsCP6o9U8l9dCzwFzNt1Po4QaShTYja1bg lKJjHw/93AjrUTgdLb3+plwvo1qv3l2RsaSSbzYhnS5KYs5SVlc23D8CSbzyiQPRMsZ9 kOHI5oT5kyIoZfGG56NMDuhJEhbdSswcm4ZTWtIPFrOcP1TBidNYhDANZJbG0YsfR0rn TrS2V5pnK3EFGIGQR/hydt4IyO6SaKQjT6aVV5IlHMXX/T/TMylS4rTB8pD8FHUfMy7g y/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w7Ai0hltg2jalPdM8DZ6LIbqR1s61sezTuxMf4F3h7I=; b=rJviwlOVK5SCunIMniwKZpQSaPiGhbOJcYKf78HpzkR4vKXYT1e8VYy4+I1msda/xk WXtV5buTlrdLYa32AhYs8gX6GDeSK/NoK7udK5Zv9apQxpl+kMXeV8jd9dX0K83hqk+e BosWVkclbio4fCjQniZHKR7a3N+hPG1KCckdcnjHB2Dw1CF7RqOdnRDj/qlL3juuxoWo pef8c/iq3F9xTk4Tvo34k9t9e4+kDMjiG3cpMfQuZoqrMVdeZkilw627X1dTXT1/xDwq uNgK4Kk5GF3D+DGHCCqjc7XRZ25Q7zP6oV7HdTQbWPLO95ErfDzBbYmi7cYtznCPAVN4 MY/Q== X-Gm-Message-State: AJcUukfcAJn/mJuOc3hKnxwhZI8e0j4RQ15gfJCi1eV7qv6VeOvOQ2Xu XH+j7mVNhkC15qxjDSPgMps= X-Received: by 2002:a1c:8548:: with SMTP id h69mr14987483wmd.11.1547820222613; Fri, 18 Jan 2019 06:03:42 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:42 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 6/7] hwmon: adm1029: Fix function alignment Date: Fri, 18 Jan 2019 15:03:28 +0100 Message-Id: <20190118140329.18970-7-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fix the "Alignment should match open parenthesis" checkpatch warning. Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index 4339f6b864a1..e9fe4fc3489e 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -203,8 +203,8 @@ show_fan_div(struct device *dev, struct device_attribute *devattr, char *buf) return sprintf(buf, "%d\n", DIV_FROM_REG(data->fan_div[attr->index])); } -static ssize_t set_fan_div(struct device *dev, - struct device_attribute *devattr, const char *buf, size_t count) +static ssize_t set_fan_div(struct device *dev, struct device_attribute *devattr, + const char *buf, size_t count) { struct adm1029_data *data = dev_get_drvdata(dev); struct i2c_client *client = data->client; @@ -322,7 +322,7 @@ static int adm1029_detect(struct i2c_client *client, temp_devices_installed = i2c_smbus_read_byte_data(client, ADM1029_REG_TEMP_DEVICES_INSTALLED); nb_fan_support = i2c_smbus_read_byte_data(client, - ADM1029_REG_NB_FAN_SUPPORT); + ADM1029_REG_NB_FAN_SUPPORT); /* 0x41 is Analog Devices */ if (man_id != 0x41 || (temp_devices_installed & 0xf9) != 0x01 || nb_fan_support != 0x03) From patchwork Fri Jan 18 14:03:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155936 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3290938jaa; Fri, 18 Jan 2019 06:03:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN4+utf4KARGV+4oGaoyCcB3XYz8wLprDp0yua8YSvJuMWqKMBy25sjmBvVT90OLfFt0xB0N X-Received: by 2002:a63:f141:: with SMTP id o1mr18113507pgk.134.1547820235872; Fri, 18 Jan 2019 06:03:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820235; cv=none; d=google.com; s=arc-20160816; b=XtpPMOGgURX1Hk2E3wp15GpFdYyXxTHNjvzRVFCyIqQCe0FDonw9GOO6yiKo+YpdLb t1B9iuOan3j8GatYT6/NPinFTX2Z5V91I+7MorqzBCm57Fj+M04UO5iu+UX8Ptev6L9l tlv2s8e6Yrf/xm8aK1xl8/fEdH2K3Fs4p/cjJp4DSEr90Nr8iA+ag6XAlzi8XgmNgU/N ufaerHJPnUxZati23sOszIzm7ubJBTnNigV0notJ7UYT3FULitSH3w24CizAYTp1AxhM eu7trnucfo7DiquBdjWX14IfNRUE3MtWH3Kzh4JOR/jk8wPZJFXW3CnlNPRBhsKQkHGJ 42jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k2UWdEyGVqVyvqUQDZYk9f7eNmmGxd41TJ57on6Onws=; b=0AxLvZdEyqUI5nosITbAtAQocrMm76pmp4f0ph+txD8nan0KmNYXSpOFDp0xShhlNg GqTjnLivfMrlAgwQQY6gG8cHSQluzBrTkMFlfjdXbxETV/76MtjfBxAoEE4J/4ECNK5L FdMvy01GcWpbozrE41lxDmRtCsDuQs3YJqTCA3KpRiBnX6AnYlW1PQ9r4Hqi8EBHw0tt 6SA5SzYKTP/bWyZ+eZ5PhgBNmV0gXSFmBthV+Pl9BcziMQ+2Fwtt30r8MXJB06yHrund 2DWcSAiqnHPxdoWYt++MDjDc/tBb3uiiapKiWvUPX+jA8dHP3j7tbRiYUlUNciCHaoLK Y0dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CdrdLCFs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si4889586pge.48.2019.01.18.06.03.55; Fri, 18 Jan 2019 06:03:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CdrdLCFs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727690AbfARODy (ORCPT + 12 others); Fri, 18 Jan 2019 09:03:54 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38132 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727556AbfARODp (ORCPT ); Fri, 18 Jan 2019 09:03:45 -0500 Received: by mail-wr1-f66.google.com with SMTP id v13so15211677wrw.5; Fri, 18 Jan 2019 06:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k2UWdEyGVqVyvqUQDZYk9f7eNmmGxd41TJ57on6Onws=; b=CdrdLCFs59tIk6shFskgU3fq/ZOkzyqz8UdY3d2jlho/svBXcx0oyfoja5LsYTisFs kdK3n7+mb9xhLjEWFyPGShjHJxS2fCw4ZJD+wGh7Lub5A2RunIXitqwp8hpcw8/3PSPN cYgb8WUS2HeOflTiG9uVYdRj66FBLVBBrEI+98MgEhNEJuQSSlqawH/FgrK4H4CbFcrz KM//nenqpZNAR3ObsPYTdmyFymD7+fupMZ5f0qYIOjhXNrL6yxJo2DBDnsiqxYhsczFj f1JIoTPATVIM7V87nw/tlhXvFNIWPOvpjP9LNjXKYuGtwsA07A9V4xHIsGnO5Wd5vJTl Fj1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k2UWdEyGVqVyvqUQDZYk9f7eNmmGxd41TJ57on6Onws=; b=eDbVKhCeHDoNN6lBMNGkRVJzLJuHxFR4FReFUVmh8gf0aL9Ydd8Z+/j9VY3VpKpRNN Pioex8eqzU2FGnwJnQE/QP0k8yqPrQHlNsKtjxl5EU08zefANxZ0t0JKYIiPsRTuGkzu z2WdynC4+7cZBWKC46FLPjSV4xC9lHUrC8akNLK4W71E9J1ofUyxUEDhLhB2q2yNurhT IJ6UrM6OYYjiUCsNRFIDDjEdWj6u+wBX3QlFdKF4OuidAoS1veVhe7WdjKAww0qlvqts QmfRxJknGzKCyvd4WVVor2GunbQP7m9V/TKd04rPR/XhJQ+Dihp2/Y6MSLznqJM3HsaO LhlA== X-Gm-Message-State: AJcUukc1LfgZHXJB21gqYUkrym8KuPPGZZezquVeSEJhzAy2ooIwpRnC ddH1H1qvyBqUFjyV8v28oZE= X-Received: by 2002:adf:b307:: with SMTP id j7mr17625353wrd.46.1547820223662; Fri, 18 Jan 2019 06:03:43 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:43 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 7/7] hwmon: adm1029: Add a comment for locking mutex Date: Fri, 18 Jan 2019 15:03:29 +0100 Message-Id: <20190118140329.18970-8-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Checkpatch complains that mutex does not have any comment. This patch fix that. Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index e9fe4fc3489e..e561279aea21 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -108,7 +108,7 @@ static const u8 ADM1029_REG_FAN_DIV[] = { struct adm1029_data { struct i2c_client *client; - struct mutex update_lock; + struct mutex update_lock; /* protect register access */ char valid; /* zero until following fields are valid */ unsigned long last_updated; /* in jiffies */