From patchwork Thu Jan 17 16:54:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loys Ollivier X-Patchwork-Id: 155855 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2193918jaa; Thu, 17 Jan 2019 08:55:01 -0800 (PST) X-Google-Smtp-Source: ALg8bN6cEC4bwLCX2l8HQYldiJI8NfErbRscuHoPh85PUqpOqX3wQMAZFTWAO3NDj+Vhu0CuTvxC X-Received: by 2002:a17:902:4827:: with SMTP id s36mr15263832pld.168.1547744101833; Thu, 17 Jan 2019 08:55:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547744101; cv=none; d=google.com; s=arc-20160816; b=kp7PPHiMfgEInwG0C5GnwydmvHKiEaaIJmv+tzy1jEChrEJ6GceDvB+n4QHq7YgqFL gkJ/dz538NBHpZIMbeXSppR/056uFhPwU2lS4Vq75h6oM1Jj98f9XiVeq6LiT0lEgEBf A8fASf10fY5DkaxyjLk2TtghbfxEB7MO/O5L6U56E/+yy2PiJD1TaEiuAGxwSd/SmUSU x6E35Dch1kpZa3EOor9gRaQe3Ey6lnnxdKyZt7VnUH4XygNrHkK7mBJSXwv8oEV7wtb+ xQJg5Gk1Kvl6fTa3swxNBeJu8httl/XLKDkoEv2AMTunBWKYRe3qzsb1Mc7N1FsbF5k5 djdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=b8QgOE/tP8Qxz0RDuzfPpPYFYowoEBOjoA8eqPauTxo=; b=I/WLHIWNa1lFTpqZuV5JiG56Man7WnUbqI2KE9rM65PSI4yYs5vmLdgIU8pAOI2gL1 E3VxSwVX+r1rA/OkeL3pg08CTwkkTCnHIbZ/bp7asbKo+mVUiLN4LRdIxd25evXx0VV1 eLXMhm1oYAK9yshp/SIUCIOdYdnjchl+x4k+AYpWnGaPX49Z/98h8uLglKVJorGuK8Us Kwa0VsEo/sZLp/1mpLi24WmO7YcFg8N7NoMivkAVGZwKZpvNQTRG8svFJi0FCWDVJthp arZTsav7LiT7RJgm4NVEo7XSD1UfOpwR7iDlLRnS7lW2W5Xz/1OpUDUu+sZZ4292UN2L VJWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=H0Of10pf; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si2154361plk.260.2019.01.17.08.55.01; Thu, 17 Jan 2019 08:55:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=H0Of10pf; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728810AbfAQQzB (ORCPT + 7 others); Thu, 17 Jan 2019 11:55:01 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52750 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728878AbfAQQyo (ORCPT ); Thu, 17 Jan 2019 11:54:44 -0500 Received: by mail-wm1-f68.google.com with SMTP id m1so1812108wml.2 for ; Thu, 17 Jan 2019 08:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=b8QgOE/tP8Qxz0RDuzfPpPYFYowoEBOjoA8eqPauTxo=; b=H0Of10pfwb0GAxVCtSdHEMcUdQGVnzowP83zcS2ctxKASi53pk7mJaigAIOY0eQhkg NmZX/E1bwDrCf/n6l1XP1LFfL8WNDNmm4LFWiWaulVt9/6IWcQvvQHe3CnXA9qhp3NCj 7/olVS/pMbpbUTzsNsEvwKwftD4W0IU3R9r+YBtT7jK5A9BQ5lCZUxNtpFNEBXQTm9G6 u6d1txDihVH8TLJ+ERFZhXOVUQ5PCn26s31KrC28xgpJfjtxvV8SsgFwgfdAv4NMNzXC aCiKOeTT2jmVSh8cMkzugkzzgWQ1fCSDS7J9fUWMel44gdh/f0UERKITvwRXCxbWly4V JrWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b8QgOE/tP8Qxz0RDuzfPpPYFYowoEBOjoA8eqPauTxo=; b=ciwx891qi+Hbc3TQUiRSeDv2wsC45jlCxWLcV5K09w3PxMUVtHP29W9Bo90T2XrbHr 42qfoaOPkJMaVjC0eGXtQ8XvLw+pJavuZjXeW61aMro0zE4pfeBoSOD6ULY7QO23X8q2 NyEUC382vP4T4bGYL6CYW+nmELPikXi4D7KUVlS2nwY6ewjJl86hXFUs+I4CmTbIOJvX /RwDwys6MUClPoUgswCv5adDMV9wA0BlFQvxA9rTodgz82dV/sU30WbQW2GeBZMu9EDj WEvC7jA+6jyslUFmc82aDj7PejhtaL4kN6Cu6FLaSOBS7Ba0pFrX4azhS0wd3/pgzSte BHWg== X-Gm-Message-State: AJcUukdgzI4dUndTzySw7dBK7y9zYulsKvV0c0K7f+VgA1K4FRc5S/Sw M4EFlaNt4aGaFy+p2MJJTal8ZVokTO+j2sJVQOc= X-Received: by 2002:a1c:96ce:: with SMTP id y197mr12976064wmd.36.1547744082833; Thu, 17 Jan 2019 08:54:42 -0800 (PST) Received: from loys-ubuntu-BY1835A49200471.thefacebook.com (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b12sm65309630wrt.17.2019.01.17.08.54.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Jan 2019 08:54:42 -0800 (PST) From: Loys Ollivier To: devicetree@vger.kernel.org, Johan Hovold Cc: Loys Ollivier , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, Kevin Hilman , linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Martin Blumenstingl Subject: [PATCH v2 2/4] dt-bindings: gnss: add mediatek binding Date: Thu, 17 Jan 2019 17:54:32 +0100 Message-Id: <1547744074-28308-3-git-send-email-lollivier@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1547744074-28308-1-git-send-email-lollivier@baylibre.com> References: <1547744074-28308-1-git-send-email-lollivier@baylibre.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add binding for Mediatek-based GNSS receivers. Signed-off-by: Loys Ollivier --- v2: Renamed bindings from Globaltop/gtop to Mediatek/mtk. Moved current-speed as an optional propertie. Removed the status line in the example. Added "mediatek,mt3339" compatible. .../devicetree/bindings/gnss/mediatek.txt | 39 ++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt -- 2.7.4 diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt new file mode 100644 index 000000000000..fd984b4a9a6d --- /dev/null +++ b/Documentation/devicetree/bindings/gnss/mediatek.txt @@ -0,0 +1,39 @@ +Mediatek-based GNSS Receiver DT binding + +Mediatek chipsets are used in GNSS-receiver modules produced by several +vendors and can use UART, SPI or I2C interfaces. + +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic +properties. + +Required properties: + +- compatible : Must be one of + + "globaltop,pa6h" + "mediatek,mt3339" + +- vcc-supply : Main voltage regulator (pin name: 3V3_IN, VCC, VDD) + +Required properties (I2C): +- reg : I2C slave address + +Required properties (SPI): +- reg : SPI chip select address + +Optional properties: + +- timepulse-gpios : Time pulse GPIO +- v-bckp-supply : Backup voltage regulator +- current-speed : Default UART baud rate + +Example: + +serial@1234 { + compatible = "ns16550a"; + + gnss { + compatible = "globaltop,pa6h"; + vcc-supply = <&vcc_3v3>; + }; +}; From patchwork Thu Jan 17 16:54:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loys Ollivier X-Patchwork-Id: 155853 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2193716jaa; Thu, 17 Jan 2019 08:54:49 -0800 (PST) X-Google-Smtp-Source: ALg8bN7a2PIb9d7EZ6+PrGwB1e/W5DBKN6XJD4Kplj3SILMZhtgCy12YDzv4bGgpw3+B6VQUalg5 X-Received: by 2002:a63:7e1a:: with SMTP id z26mr13822722pgc.216.1547744089569; Thu, 17 Jan 2019 08:54:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547744089; cv=none; d=google.com; s=arc-20160816; b=tsVPS/DxDHuc/H62SGQypDqSOIineWv584jsyh5IbrPZp+1MtHNdNYrjn/mtdjL947 u5uvr99nNy4rXmQ0M/FpsrnAWM+7Q8CyyYBT0wDnU0hJ9hkNVcAoHstu+VeMNepmDJ8E Kt6zNEKkT0kHlwAnq5BHk7kleZ5ZVme3eFYRT0iQgusvP6C1mrB7vcXHvK4Zwity0o0d X/N7/Z+NZqOIpKISP0W0aJy8oiHPG18rgKuQEf5xDQw+CZd/0xT+AzIYmtfEDa7wSiuz bqo/8vY2giDZyGaQ0QM3IRJEgKjnQDNp49GHednT4lsno2/YU/fA5Cr0nXZ7s7+JOXK4 Flpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=JdxC+TYoHyFvvG2M67CNwtrXKpmBLe0NX/snZJIlkJ4=; b=g4JY9ZJUckYoKhcpeA9AjpZBt3m3Mhm7wAgPzu9+PxA29DazsFiK+DYHp3gyZn9/kO 0OK3q9hT+eDQ6t5ITbGOV6b1NZUnf1Xt6AChMysEKDwbg+HG8uSdzzg8thtiMW/9/Kmm S/mPasy+Wgds+ncyXzDVDW+A0SmgCbVYmH+8C6J0usM7j5DmpIlpUlyuEMPi+pTzO5t/ UMLX0ctmmciyAAxtRJEGwB0UHCPJRFFLmDgaBOwk1uL8q5RlSuMUloZS6Bx8WzAmsadh SMeAP8UsvKEQSs8L1MPmcMhCMwQeQRVyq5NVct8QIflT5+I6Wgum8vW/h+oELNJW6Ogn 56tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=VIJSI+MC; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r81si2355428pfr.164.2019.01.17.08.54.49; Thu, 17 Jan 2019 08:54:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=VIJSI+MC; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728767AbfAQQys (ORCPT + 7 others); Thu, 17 Jan 2019 11:54:48 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37223 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729096AbfAQQyr (ORCPT ); Thu, 17 Jan 2019 11:54:47 -0500 Received: by mail-wr1-f68.google.com with SMTP id s12so11823644wrt.4 for ; Thu, 17 Jan 2019 08:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JdxC+TYoHyFvvG2M67CNwtrXKpmBLe0NX/snZJIlkJ4=; b=VIJSI+MCtGNJREA3jMHwYFVEg2tbXQUChJfvmWyIDkEHyT7GrUvwSo/C07Ty34fNx/ idPh8+Col7at41ybNFoMDAzDnG9ZqkWTFk1SFQvA9uoKy5mf+SMXsdhaPV2lULnnCwm9 L6JITLTdPOrvbyCO1LYh4IEj0Z4BSwNBpwNfcSQMQZVhv3qpuEOEaArWQRmj8spKXxYJ jpOtHerulPyj1U7pC7YjKx2NaCIboc4dRDlZNzAzrgPIeGpZx8P+VChQd5vbY/PEsjYy 4j+E0r7DODoOaempD0oBMFLVQzgZssqYY2v9EEBK+6ceqXMVS4yVCQ4r1Jw4nFDOUO06 NA5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JdxC+TYoHyFvvG2M67CNwtrXKpmBLe0NX/snZJIlkJ4=; b=mqEPmasUpsW165f3Y8304gtxRUuggfpv9yDlw0qkxfA6JAHoXypwKpQQszcuRVPYd6 V5fN+QR7bT8FTE+yi6qZX1XhSlJG3GN777jbhe7j04huYFphvuMBPzE5OCc5mKTaslUU FmNrtmHqDYpsXRkTxIqk+teJb6llHsgfeqBKGaybxFMepLBFFPrJ1dNbS2XxfiTF3Gpz K3CFUm+VQi88ja/xPg+BoEwl6atVrQ2WTfJXtGLv1Tb6C1xC/U1VuzUIu/69N+ZWew16 uPnaT3BTOUEmMsSAHR+OedeX4c+AJfPUcHuG+j702jH8Egw1a6jzFZtEeV6EN69fnpBh VNGA== X-Gm-Message-State: AJcUukcesU/bwdfP575KBUbTcMXIX9ltW8+z1jrUwbidy92eR7B6UAb2 x1ygipwdqzNtQ8qlZHXf4bpL/TfK1Args/Lz4Zc= X-Received: by 2002:adf:efd1:: with SMTP id i17mr12509696wrp.200.1547744084758; Thu, 17 Jan 2019 08:54:44 -0800 (PST) Received: from loys-ubuntu-BY1835A49200471.thefacebook.com (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b12sm65309630wrt.17.2019.01.17.08.54.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Jan 2019 08:54:44 -0800 (PST) From: Loys Ollivier To: devicetree@vger.kernel.org, Johan Hovold Cc: Loys Ollivier , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, Kevin Hilman , linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Martin Blumenstingl Subject: [PATCH v2 4/4] gnss: add driver for mediatek receivers Date: Thu, 17 Jan 2019 17:54:34 +0100 Message-Id: <1547744074-28308-5-git-send-email-lollivier@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1547744074-28308-1-git-send-email-lollivier@baylibre.com> References: <1547744074-28308-1-git-send-email-lollivier@baylibre.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add driver for serial-connected Mediatek-based GNSS receivers. These devices typically boot transmitting vendor specific NMEA output sequences. The serial port bit rate is read from the device tree "current-speed". Note that the driver uses the generic GNSS serial implementation and therefore essentially only manages power abstracted into three power states: ACTIVE, STANDBY, and OFF. For mediatek receivers with a main supply and no enable-gpios, this simply means that the main supply is disabled in STANDBY and OFF (the optional backup supply is kept enabled while the driver is bound). Note that the timepulse-support is left unimplemented. Signed-off-by: Loys Ollivier --- v2: Renamed from gtop/Globaltop to mtk/Mediatek. Added "mediatek,mt3339" compatible. drivers/gnss/Kconfig | 13 +++++ drivers/gnss/Makefile | 3 + drivers/gnss/core.c | 1 + drivers/gnss/mtk.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 170 insertions(+) create mode 100644 drivers/gnss/mtk.c -- 2.7.4 diff --git a/drivers/gnss/Kconfig b/drivers/gnss/Kconfig index 6abc88514512..51e6282d092a 100644 --- a/drivers/gnss/Kconfig +++ b/drivers/gnss/Kconfig @@ -40,4 +40,17 @@ config GNSS_UBX_SERIAL If unsure, say N. +config GNSS_MTK_SERIAL + tristate "Mediatek GNSS receiver support" + depends on SERIAL_DEV_BUS + select GNSS_SERIAL + help + Say Y here if you have a Mediatek-based GNSS receiver which uses a + serial interface. + + To compile this driver as a module, choose M here: the module will + be called gnss-mtk. + + If unsure, say N. + endif # GNSS diff --git a/drivers/gnss/Makefile b/drivers/gnss/Makefile index 5cf0ebe0330a..43318375aa51 100644 --- a/drivers/gnss/Makefile +++ b/drivers/gnss/Makefile @@ -14,3 +14,6 @@ gnss-sirf-y := sirf.o obj-$(CONFIG_GNSS_UBX_SERIAL) += gnss-ubx.o gnss-ubx-y := ubx.o + +obj-$(CONFIG_GNSS_MTK_SERIAL) += gnss-mtk.o +gnss-mtk-y := mtk.o diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index 4291a0dd22aa..320cfca80d5f 100644 --- a/drivers/gnss/core.c +++ b/drivers/gnss/core.c @@ -334,6 +334,7 @@ static const char * const gnss_type_names[GNSS_TYPE_COUNT] = { [GNSS_TYPE_NMEA] = "NMEA", [GNSS_TYPE_SIRF] = "SiRF", [GNSS_TYPE_UBX] = "UBX", + [GNSS_TYPE_MTK] = "MTK", }; static const char *gnss_type_name(struct gnss_device *gdev) diff --git a/drivers/gnss/mtk.c b/drivers/gnss/mtk.c new file mode 100644 index 000000000000..c91d4d251098 --- /dev/null +++ b/drivers/gnss/mtk.c @@ -0,0 +1,153 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Mediatek GNSS receiver driver + * + * Copyright (C) 2018 Loys Ollivier + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include "serial.h" + +struct mtk_data { + struct regulator *v_bckp; + struct regulator *vcc; +}; + +static int mtk_set_active(struct gnss_serial *gserial) +{ + struct mtk_data *data = gnss_serial_get_drvdata(gserial); + int ret; + + ret = regulator_enable(data->vcc); + if (ret) + return ret; + + return 0; +} + +static int mtk_set_standby(struct gnss_serial *gserial) +{ + struct mtk_data *data = gnss_serial_get_drvdata(gserial); + int ret; + + ret = regulator_disable(data->vcc); + if (ret) + return ret; + + return 0; +} + +static int mtk_set_power(struct gnss_serial *gserial, + enum gnss_serial_pm_state state) +{ + switch (state) { + case GNSS_SERIAL_ACTIVE: + return mtk_set_active(gserial); + case GNSS_SERIAL_OFF: + case GNSS_SERIAL_STANDBY: + return mtk_set_standby(gserial); + } + + return -EINVAL; +} + +static const struct gnss_serial_ops mtk_gserial_ops = { + .set_power = mtk_set_power, +}; + +static int mtk_probe(struct serdev_device *serdev) +{ + struct gnss_serial *gserial; + struct mtk_data *data; + int ret; + + gserial = gnss_serial_allocate(serdev, sizeof(*data)); + if (IS_ERR(gserial)) { + ret = PTR_ERR(gserial); + return ret; + } + + gserial->ops = &mtk_gserial_ops; + + gserial->gdev->type = GNSS_TYPE_MTK; + + data = gnss_serial_get_drvdata(gserial); + + data->vcc = devm_regulator_get(&serdev->dev, "vcc"); + if (IS_ERR(data->vcc)) { + ret = PTR_ERR(data->vcc); + goto err_free_gserial; + } + + data->v_bckp = devm_regulator_get_optional(&serdev->dev, "v-bckp"); + if (IS_ERR(data->v_bckp)) { + ret = PTR_ERR(data->v_bckp); + if (ret == -ENODEV) + data->v_bckp = NULL; + else + goto err_free_gserial; + } + + if (data->v_bckp) { + ret = regulator_enable(data->v_bckp); + if (ret) + goto err_free_gserial; + } + + ret = gnss_serial_register(gserial); + if (ret) + goto err_disable_v_bckp; + + return 0; + +err_disable_v_bckp: + if (data->v_bckp) + regulator_disable(data->v_bckp); +err_free_gserial: + gnss_serial_free(gserial); + + return ret; +} + +static void mtk_remove(struct serdev_device *serdev) +{ + struct gnss_serial *gserial = serdev_device_get_drvdata(serdev); + struct mtk_data *data = gnss_serial_get_drvdata(gserial); + + gnss_serial_deregister(gserial); + if (data->v_bckp) + regulator_disable(data->v_bckp); + gnss_serial_free(gserial); +}; + +#ifdef CONFIG_OF +static const struct of_device_id mtk_of_match[] = { + { .compatible = "globaltop,pa6h" }, + { .compatible = "mediatek,mt3339" }, + {}, +}; +MODULE_DEVICE_TABLE(of, mtk_of_match); +#endif + +static struct serdev_device_driver mtk_driver = { + .driver = { + .name = "gnss-mtk", + .of_match_table = of_match_ptr(mtk_of_match), + .pm = &gnss_serial_pm_ops, + }, + .probe = mtk_probe, + .remove = mtk_remove, +}; +module_serdev_device_driver(mtk_driver); + +MODULE_AUTHOR("Loys Ollivier "); +MODULE_DESCRIPTION("Mediatek GNSS receiver driver"); +MODULE_LICENSE("GPL v2");