From patchwork Mon Jan 14 13:44:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 155505 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3674737jaa; Mon, 14 Jan 2019 05:46:01 -0800 (PST) X-Google-Smtp-Source: ALg8bN7g3zzZsHNfblENGlA97+a47C08YpVzRj+1ZwHO0j/KwMVz6fD7fQs93KSzXVogqWmHe1TF X-Received: by 2002:a17:902:280b:: with SMTP id e11mr25566377plb.269.1547473561062; Mon, 14 Jan 2019 05:46:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547473561; cv=none; d=google.com; s=arc-20160816; b=dXVFCLTHX0UfhokoYB3qXEJu9V8vz/MPediz1JAx9IdgeepeFK5hT/KDKpCexVkTod JKeTTUjLaWF6EPQpZxvp0Ou/VT5Br08YPe3wQls65A1RXQy88y2qbZfJg2PjgSgg5eHS gjuxR8CawiF7kGXFJjGxzfg+aGEY4gYmKsHd2br22IZcUYeDWoPQEI7ioQ1qcqjUKn/P /wubzKBF3jzKMY+4C92j9EhPVjtgqE6auaWiGXVU5u+hxzAgB6BPMlayU68my2CG97Yq 59An3vTBtvIfkBkI/eEZyM6AL71/54mNOw06s/On6lRujSTtBdJ6oAdCHcmcfvFndASj kmlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=EmqA5rK78Y/C/Z352rsgJ+xwVJyqOQ8XLQYezJRY2MLASgGOusgPj/KCxhbj3RHWiu 9UgXx0wqgXJ1ecg4PdNN3RC6N/DlT6SRPk+zE2NnIdY4awmO8EuE3H8q5eaQQWNafnFO idg+Tqt06w6uywy68iUvZmqAqCViDDK0d7gwMDHyykInvP+Bu/a0Yvo/x5ZNcCWHppqa JFPPDWHiIHA1gVphxub7tOUoEFcdJk22kDMkuXrcIu0SOBszB/XaBgLLt3AaQNpeWycm KtNTvm/iLsUvemccwQnOYMUl+0BsuEtYGofq2jcePkv2VMFTYVVl1uUVC3YrPCaXHSlq jh8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CsrEo/uJ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j21si361875pll.150.2019.01.14.05.46.00; Mon, 14 Jan 2019 05:46:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CsrEo/uJ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfANNp6 (ORCPT + 31 others); Mon, 14 Jan 2019 08:45:58 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54327 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfANNp5 (ORCPT ); Mon, 14 Jan 2019 08:45:57 -0500 Received: by mail-wm1-f68.google.com with SMTP id a62so8962751wmh.4 for ; Mon, 14 Jan 2019 05:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=CsrEo/uJUfiY/yhKewL8SJyrD+mSyI9vQ5hR4ip+l8fH7imZ/n5u1l2mFgIgOJmIaT CLGzB1DFsfQ+LD0TWgG5KI9P+ixgpWiWaW8IldcliZ6LFPgAZayBd4QJpkewWd1XkU6B bCsrn+1AIUHxewPaSCiHqX+THm/66A3vjUQyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=Ak82VeaoKCmv+msqnZyWJqlCtmdb5o0UEJZ+K8Wc6izPdryhNHxmMCRAuZeIe9Ke0j MZJuoFE8DqZ7JSPDdTr+Guw9EYnOWSQcEvStaVFX0YvdkX8BUdch3ihKip5mBwwWdMYG Yh1zHqAYbdeDYm4XMrkXeu6bu7RCEyp/+/lMFrNgmJJTXvVjEIONOTSsN2msJaCRZ5XG S+0/CA0R7FZQSJav7e6sYjk+5D8M1y5A9pu1kpXVmTUA4rB8SU2El5k1mF0ZtNBRXF8j PRhEfqIDG8T3YFzTY2R0kSRdI7KM247RnZdML71VE3RCDdkUEOBxwN6jr/yaGQMLhQPa XIfg== X-Gm-Message-State: AJcUuke3QGpDEJ8G8k7f6zZIA5R43j6w2RT0QFcPaJAVVjNgUABEG/ff AXsOwPKZpKDn9MioNtye1lHpIg== X-Received: by 2002:a1c:4108:: with SMTP id o8mr11573993wma.91.1547473555389; Mon, 14 Jan 2019 05:45:55 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:54 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 1/4] slimbus: core: match full device id Date: Mon, 14 Jan 2019 13:44:46 +0000 Message-Id: <20190114134449.15367-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org match full slim device id instead of just product and manufacture code, this will allow drivers to be much more specific to that device. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 55eda5863a6b..9e4f3b21ba8c 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -21,7 +21,9 @@ static const struct slim_device_id *slim_match(const struct slim_device_id *id, { while (id->manf_id != 0 || id->prod_code != 0) { if (id->manf_id == sbdev->e_addr.manf_id && - id->prod_code == sbdev->e_addr.prod_code) + id->prod_code == sbdev->e_addr.prod_code && + id->dev_index == sbdev->e_addr.dev_index && + id->instance == sbdev->e_addr.instance) return id; id++; } From patchwork Mon Jan 14 13:44:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 155508 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3674957jaa; Mon, 14 Jan 2019 05:46:13 -0800 (PST) X-Google-Smtp-Source: ALg8bN5KIYrj8ACz4Tx4Qcl4IxchiI1iRPi+noFCuEqZanALlXkCfrhrm30BzHhqXvv2si6gPxxK X-Received: by 2002:a62:6b8a:: with SMTP id g132mr25662994pfc.201.1547473573708; Mon, 14 Jan 2019 05:46:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547473573; cv=none; d=google.com; s=arc-20160816; b=TqjOJjL0bVxItFyuYkrXbIQBjqTb3wao2uhje+JjwdEhlZ77+qkTtQSsI8kpuZv1FY ZEIWMsMyEbzEeYpKV6NOL8gpmSYGbajCYRFoAh/Uujhs5LUG/fgyYgdsuhHUL0ZZMrpR 9ZZFdxtEkVnCvK2VnrB6MGcgBINnHnkJK4pt25HJy9VTQJtr0iwVGnHZ0BnMnlvnsbqa BPTeGaNney99kzsNF+ChzWJL2xt7lQDTDEIEPxPBBGhM2VlPhFE5YhJufVfk5bQ7YGZB fkcA2E9yZWn4K8ZkqeFpoeNiE9EqPBpXN6M+i6Gn3lGXv+oFn9glyqNXbcdvkxeTnd68 OZRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=MW6xTzamaNbmPUlaxnuuy8yyyanO8VXt6H3zdWg6gvaMzj7x4j17eEO2vewabKPce2 Lu6+rH0mu3v7AmiW58EgbO0bjYO41c378Z6F0bCqPzE+NJvmUK2lTrjwi59FEiRSDiQn 4353VFFkZlsyqPpFjiRVe5Djn1mM0km0NTZFUknhRrp0HQDP3ps0YQv53J13o+9xj6jK 3y0SXCtQK5MPlnglrHGSjNz8/veCUPy3fFMy9EqfJmdIVuMAwBhUpDQ344kKpZgf6qnV uos3M8MvVQMVyoS3215honc2mPOKn2iqitvon9S+d3k3WCjOAfzSy2sDa1aMd5Y1EmI9 KdTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Z3/wDbhz"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si402730pli.175.2019.01.14.05.46.13; Mon, 14 Jan 2019 05:46:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Z3/wDbhz"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfANNqC (ORCPT + 31 others); Mon, 14 Jan 2019 08:46:02 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42770 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfANNqA (ORCPT ); Mon, 14 Jan 2019 08:46:00 -0500 Received: by mail-wr1-f66.google.com with SMTP id q18so22881838wrx.9 for ; Mon, 14 Jan 2019 05:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=Z3/wDbhzhopFmyHNBAS1GSnVi/sNKVPlp0oNbYpPLEEL4VqHsy+5ZLBt6oDYjcSO4T fSSE2zHTTQQ5i0sIelPEi9Kt/qThgXItG1JoSdo3gDZqGmDhbfP4J2MMFDebFOUdkHFt 0PH6bLo8xpAZlp4JFNkG55gMcPu3FtXIGRer0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=na6PqnEmuHXqvIO80XlBYKW67JTuyxm7xuyHpwhlz8trU6id3AUT/AdER5Zqqc7xOI r5JMeFCCvd0NmCBZR4c36NgTEiZfJF9HP9X33blnnaCVTkB0TtjwgstpTtwMfbfC43y1 J218F1sITm4kCXbDb2O2yC75BsTjocPjHFrhOePn9V+56vfRDQiHtsHAhqWON7vmfRzr 4pqgMkbkJlcX3thV3KumwYSPSvkglKnh29qEBIUecCpEJGNZIz07j5OTvZQGFEvsF+no UZbt/oC+H/1N/UhqUVfqVUAcVluiQ+b9kq7jYL2FwrPNd5Dhtsp042iBK1BK8R0gjUQy 3bfw== X-Gm-Message-State: AJcUukfWHeKRSQS0RhwjAGKDYVRCedFaZAvh2ES5gssVrbinHk5Gozy6 60sR69RCFcTVUZC8FZ6plvsQCg== X-Received: by 2002:adf:b201:: with SMTP id u1mr24126617wra.165.1547473558066; Mon, 14 Jan 2019 05:45:58 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:57 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 3/4] slimbus: core: use slim_device_update_status() to update status Date: Mon, 14 Jan 2019 13:44:48 +0000 Message-Id: <20190114134449.15367-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org use slim_device_update_status() instead of directly calling the device_status() callback. Move slim_device_update_status() before probe to avoid forward declaration too. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) -- 2.20.1 diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 1ba08b5f2e78..8ffdc9876223 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -42,6 +42,23 @@ static int slim_device_match(struct device *dev, struct device_driver *drv) return !!slim_match(sbdrv->id_table, sbdev); } +static void slim_device_update_status(struct slim_device *sbdev, + enum slim_device_status status) +{ + struct slim_driver *sbdrv; + + if (sbdev->status == status) + return; + + sbdev->status = status; + if (!sbdev->dev.driver) + return; + + sbdrv = to_slim_driver(sbdev->dev.driver); + if (sbdrv->device_status) + sbdrv->device_status(sbdev, sbdev->status); +} + static int slim_device_probe(struct device *dev) { struct slim_device *sbdev = to_slim_device(dev); @@ -55,8 +72,7 @@ static int slim_device_probe(struct device *dev) /* try getting the logical address after probe */ ret = slim_get_logical_addr(sbdev); if (!ret) { - if (sbdrv->device_status) - sbdrv->device_status(sbdev, sbdev->status); + slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); } else { dev_err(&sbdev->dev, "Failed to get logical address\n"); ret = -EPROBE_DEFER; @@ -297,23 +313,6 @@ int slim_unregister_controller(struct slim_controller *ctrl) } EXPORT_SYMBOL_GPL(slim_unregister_controller); -static void slim_device_update_status(struct slim_device *sbdev, - enum slim_device_status status) -{ - struct slim_driver *sbdrv; - - if (sbdev->status == status) - return; - - sbdev->status = status; - if (!sbdev->dev.driver) - return; - - sbdrv = to_slim_driver(sbdev->dev.driver); - if (sbdrv->device_status) - sbdrv->device_status(sbdev, sbdev->status); -} - /** * slim_report_absent() - Controller calls this function when a device * reports absent, OR when the device cannot be communicated with From patchwork Mon Jan 14 13:44:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 155507 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3674826jaa; Mon, 14 Jan 2019 05:46:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN6PgIM/qag8igy1//1CXObbG9H3+KrEYK8p9ve3i9vHQds6I7D9v3/DT8DbwjYMFfeQFilf X-Received: by 2002:a62:220d:: with SMTP id i13mr25289370pfi.162.1547473565857; Mon, 14 Jan 2019 05:46:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547473565; cv=none; d=google.com; s=arc-20160816; b=CwauMRmbm31tj9WeMJ4Czq0QZsCtMLIzgGzwx89Fh/f3vH3CZ/7UZOr+ZG6zAgYFMd su5yhNJ7Gsmpri8e8ahopXWanHUrQXeVYt/UrRQ++jNuFIcfQGzQC1fYJfVpiOBGpF/1 4ON51Ne1orVuHDXbKyjbp1kBGducf0RJe3wPLf9QRauLyIkHGiwxocfpIuwmXYw6k2VH sbjbzG0sfJGaNYdNHidIJK3aePR9jphwriMwjgdwfZNAQtVG2vzknCWWRw2/hAuGVC5z a177dXPDEKhknBSNnT3PPgefDIc+iK2Pu3XaM/URWbV8T2vsr9ud97sqLvS2CN5SkkzC sDVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=glNAyQwDYpde0CpVMpyTXLtt/UIGOwy46EWLTlgd0DiVSHKPWSr0PbSHk53be13Xsf bOpSoEvMtX2JCga6rnQXzzrUohjx2iGTI7hBikSJuXYjK6oJB8gGbD+wYXgkxi5Tfvp4 lXUixoAnYF/JcTc+qmOSllSTDUFgsSN1MGl/q9TurphaKbSp1W7jB12CuXX43gAcpFgJ ipQU7FzXcxAoZNsmuvKxn7shVnZT0k1PzBaQzGcB77hEsEkKehnmPjjPkjVeliF5k8k1 0kJBLMGv5TwfYY2IfD0lKXKwTlgvFE8JRw0PVvWnVVm0QyKN3xC/7kd+Hf61/wX7azkg kINQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xv+mo420; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i7si404439pgc.144.2019.01.14.05.46.05; Mon, 14 Jan 2019 05:46:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xv+mo420; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbfANNqE (ORCPT + 31 others); Mon, 14 Jan 2019 08:46:04 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43592 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726644AbfANNqB (ORCPT ); Mon, 14 Jan 2019 08:46:01 -0500 Received: by mail-wr1-f68.google.com with SMTP id r10so22903625wrs.10 for ; Mon, 14 Jan 2019 05:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=Xv+mo420RQ7SowyXQw5AOCTKRj/czTkjlgmqK2fPHy5sIyzgCxajeFCQkYBrAPj+95 +Fju2rw+nA/0cRLQlXuiFPULIZJGWcF/j3Qyi5ZPa66gsosd/FfNWpVg0zplq66CTSxK GbBvRVkhYOhLZXsP85cjaruzTkBMzLR5qQUkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=KwyvCwe50vLtSO04Thwl0shAhH97J04auy8Wu+TFm6RjrkM/GBoX77mX9DerL9q9MD 9v5g6KxACqXv7kjukTeJ4mARCxPrAn5KAVF77hd7e/dPjMS0Il5Bm2xeXfHXXfTBR3/Z HCimSPnIjEP00c7t0cGReWcHBl5NBtShptkE+SCWL15XZ26eitb8NWVkYMm916SCqcIt FzxJUnVwRtXI13GdbRKgXsKhH/MI2+nSqMuPuI12y0ff/PiDx/xWG6Q9apgIv8EooI4e lvN4FqHtaVpVko/YPyA0QRmZ16lEdQcTSjXRdTXNMZeo6WW6MIRn1S6zv6sNb9Ge+Pmc lW3A== X-Gm-Message-State: AJcUuke4uwfdbu1+bh8rIBfWNgbex+qCveZLYppdDWKu448igirR8dsg js0PuZuf+4XWEXY1SbiMiZHsLg== X-Received: by 2002:adf:b6a1:: with SMTP id j33mr24357526wre.55.1547473559036; Mon, 14 Jan 2019 05:45:59 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:58 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 4/4] slimbus: core: add missing spin_lock_init on txn_lock Date: Mon, 14 Jan 2019 13:44:49 +0000 Message-Id: <20190114134449.15367-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add missing spin lock intialization this also fixes the spinlock bad magic warning. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 8ffdc9876223..b2f07d2043eb 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -274,6 +274,7 @@ int slim_register_controller(struct slim_controller *ctrl) mutex_init(&ctrl->lock); mutex_init(&ctrl->sched.m_reconf); init_completion(&ctrl->sched.pause_comp); + spin_lock_init(&ctrl->txn_lock); dev_dbg(ctrl->dev, "Bus [%s] registered:dev:%p\n", ctrl->name, ctrl->dev);