From patchwork Thu Nov 10 16:44:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101538 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824239qge; Thu, 10 Nov 2016 08:47:26 -0800 (PST) X-Received: by 10.98.157.148 with SMTP id a20mr11818189pfk.1.1478796446319; Thu, 10 Nov 2016 08:47:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zs7si4875544pac.45.2016.11.10.08.47.26; Thu, 10 Nov 2016 08:47:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964838AbcKJQrI (ORCPT + 27 others); Thu, 10 Nov 2016 11:47:08 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:53337 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935157AbcKJQrF (ORCPT ); Thu, 10 Nov 2016 11:47:05 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0M5lI9-1d2VXk3pwP-00xrUU; Thu, 10 Nov 2016 17:45:38 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 01/11] Kbuild: enable -Wmaybe-uninitialized warning for "make W=1" Date: Thu, 10 Nov 2016 17:44:44 +0100 Message-Id: <20161110164454.293477-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:DAXk2Yxa67fKjwVk4DeXKToDkZ5sDxWPsZAvlZpQTKdNYJXUp0F mVVlzky4AH6Sq3clApz9B1jUxra6p0Gt007J8G5MPb86yl5RgPDo3BZxGoV5eVFvp9/HUpL Vjrx7B7Ox98X9RYAt4VAtf1sGqJ3cl16xDWbSw25mwWm7W6ofo81W40uYdYTyap39pTAecQ 3sMhwOWsbOM6TY4CLwcKA== X-UI-Out-Filterresults: notjunk:1; V01:K0:AKftQSy/FBI=:VHnh/LT69UYVkOIfZE/SL7 JgORH64wCohJllpLcr1KYHWSbOtbB7JdVl1v0w2bXB03wzD7+lzmVOWo9GS3SymtYebjF7hDu JHoAZ1I6/Z3ETGh9419hqaeWpovuUe8bPysQPXQ2aVu5wYR6kxJMZe5G7RhXcUeLlLFvOjELO E8rfhVMWDujd5CyVSKsXhoL1Pbc3DsVgxtlLcHsAktC+l5Tk7RdgAPm8xchpwba5aHejJTJiW FBztfn2haRUTZ4PK4tpyORyg27efR+w014esNF6tqufoCHj2rg1U6o57w3SrKM8mQXkCJKB1O Ic4+MpKvyipG0PiJPd657LJEaSVWzeB8oSjfO5cWE3SCfIRSgsP5O5BFNKaqVKZPQ+RUa1RaS PQDo4QgStIwO/jlRP4aksTor5MC/jS7OIQP9J2tdx6MKpx9FfMqMs+D8GiP1Rtdl0ePhoy/x6 +ckB63djF/sFyVu8ZigMv+QzApQxDTkiPD/PGdgP45aEx+JhwYLP2TCKYGBAIjmKhW1YDEeWe sXURoeLmTECikfD8Y+0jY3pXO8/lE3fweM/D92mmeo51pKQnFMbsjYIyiQaH0EmiNnyf7nfp6 R6rrSeASOlto0Je+JWYfHSiBkiHlhTOX0RoBQFCB7mvbGc9HDZ/LELyxpAiocddtaNUaKkPt7 bxWDXq0bCDZLdOK1sGL7ogXhBApaaFOQNeU4HdtR0Ny20rYo7Zo7V+PnQwXOT2hVZKTI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Traditionally, we have always had warnings about uninitialized variables enabled, as this is part of -Wall, and generally a good idea [1], but it also always produced false positives, mainly because this is a variation of the halting problem and provably impossible to get right in all cases [2]. Various people have identified cases that are particularly bad for false positives, and in commit e74fc973b6e5 ("Turn off -Wmaybe-uninitialized when building with -Os"), I turned off the warning for any build that was done with CC_OPTIMIZE_FOR_SIZE. This drastically reduced the number of false positive warnings in the default build but unfortunately had the side effect of turning the warning off completely in 'allmodconfig' builds, which in turn led to a lot of warnings (both actual bugs, and remaining false positives) to go in unnoticed. With commit 877417e6ffb9 ("Kbuild: change CC_OPTIMIZE_FOR_SIZE definition") enabled the warning again for allmodconfig builds in v4.7 and in v4.8-rc1, I had finally managed to address all warnings I get in an ARM allmodconfig build and most other maybe-uninitialized warnings for ARM randconfig builds. However, commit 6e8d666e9253 ("Disable "maybe-uninitialized" warning globally") was merged at the same time and disabled it completely for all configurations, because of false-positive warnings on x86 that I had not addressed until then. This caused a lot of actual bugs to get merged into mainline, and I sent several dozen patches for these during the v4.9 development cycle. Most of these are actual bugs, some are for correct code that is safe because it is only called under external constraints that make it impossible to run into the case that gcc sees, and in a few cases gcc is just stupid and finds something that can obviously never happen. I have now done a few thousand randconfig builds on x86 and collected all patches that I needed to address every single warning I got (I can provide the combined patch for the other warnings if anyone is interested), so I hope we can get the warning back and let people catch the actual bugs earlier. This reverts the change to disable the warning completely and for now brings it back at the "make W=1" level, so we can get it merged into mainline without introducing false positives. A follow-up patch enables it on all levels unless some configuration option turns it off because of false-positives. Link: https://rusty.ozlabs.org/?p=232 [1] Link: https://gcc.gnu.org/wiki/Better_Uninitialized_Warnings [2] Signed-off-by: Arnd Bergmann --- Makefile | 10 ++++++---- arch/arc/Makefile | 4 +++- scripts/Makefile.extrawarn | 3 +++ scripts/Makefile.ubsan | 4 ++++ 4 files changed, 16 insertions(+), 5 deletions(-) -- 2.9.0 diff --git a/Makefile b/Makefile index f97f786..06e2b73 100644 --- a/Makefile +++ b/Makefile @@ -370,7 +370,7 @@ LDFLAGS_MODULE = CFLAGS_KERNEL = AFLAGS_KERNEL = LDFLAGS_vmlinux = -CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop-im +CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop-im -Wno-maybe-uninitialized CFLAGS_KCOV := $(call cc-option,-fsanitize-coverage=trace-pc,) @@ -620,7 +620,6 @@ ARCH_CFLAGS := include arch/$(SRCARCH)/Makefile KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,) -KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,) ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION @@ -629,15 +628,18 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) endif ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += -Os +KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) else ifdef CONFIG_PROFILE_ALL_BRANCHES -KBUILD_CFLAGS += -O2 +KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) else KBUILD_CFLAGS += -O2 endif endif +KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0409, \ + $(call cc-disable-warning,maybe-uninitialized,)) + # Tell gcc to never replace conditional load with a non-conditional one KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index 864adad..25f81a1 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -68,7 +68,9 @@ cflags-$(CONFIG_ARC_DW2_UNWIND) += -fasynchronous-unwind-tables $(cfi) ifndef CONFIG_CC_OPTIMIZE_FOR_SIZE # Generic build system uses -O2, we want -O3 # Note: No need to add to cflags-y as that happens anyways -ARCH_CFLAGS += -O3 +# +# Disable the false maybe-uninitialized warings gcc spits out at -O3 +ARCH_CFLAGS += -O3 $(call cc-disable-warning,maybe-uninitialized,) endif # small data is default for elf32 tool-chain. If not usable, disable it diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 53449a6..7fc2c5a 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -36,6 +36,7 @@ warning-2 += -Wshadow warning-2 += $(call cc-option, -Wlogical-op) warning-2 += $(call cc-option, -Wmissing-field-initializers) warning-2 += $(call cc-option, -Wsign-compare) +warning-2 += $(call cc-option, -Wmaybe-uninitialized) warning-3 := -Wbad-function-cast warning-3 += -Wcast-qual @@ -59,6 +60,8 @@ endif KBUILD_CFLAGS += $(warning) else +KBUILD_CFLAGS += $(call cc-disable-warning, maybe-uninitialized) + ifeq ($(cc-name),clang) KBUILD_CFLAGS += $(call cc-disable-warning, initializer-overrides) KBUILD_CFLAGS += $(call cc-disable-warning, unused-value) diff --git a/scripts/Makefile.ubsan b/scripts/Makefile.ubsan index dd779c4..3b1b138 100644 --- a/scripts/Makefile.ubsan +++ b/scripts/Makefile.ubsan @@ -17,4 +17,8 @@ endif ifdef CONFIG_UBSAN_NULL CFLAGS_UBSAN += $(call cc-option, -fsanitize=null) endif + + # -fsanitize=* options makes GCC less smart than usual and + # increase number of 'maybe-uninitialized false-positives + CFLAGS_UBSAN += $(call cc-option, -Wno-maybe-uninitialized) endif From patchwork Thu Nov 10 16:44:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101530 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp825090qge; Thu, 10 Nov 2016 08:49:08 -0800 (PST) X-Received: by 10.98.66.214 with SMTP id h83mr11492824pfd.67.1478796547977; Thu, 10 Nov 2016 08:49:07 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a65si5846505pfb.18.2016.11.10.08.49.07; Thu, 10 Nov 2016 08:49:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964930AbcKJQs7 (ORCPT + 27 others); Thu, 10 Nov 2016 11:48:59 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:59577 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964877AbcKJQrq (ORCPT ); Thu, 10 Nov 2016 11:47:46 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0LibhV-1cfJpX3E1l-00d1DO; Thu, 10 Nov 2016 17:45:39 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 02/11] NFSv4.1: work around -Wmaybe-uninitialized warning Date: Thu, 10 Nov 2016 17:44:45 +0100 Message-Id: <20161110164454.293477-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:uOAwqpBcVOfYCzwvW3UMqvyO8hxpY1KbtblUfXP/jD0IfDiGVd3 rt2KwqdIvEjoFrgxfT5N59tS6DC0qxs3gzxkX7Q2W5tObeB5eLbgbh/7evhnLrvDRpCXMSZ 6crRBIZnHym5Y3GsKi2QUsLgKeZyvcM78wrpbWgR74kChDL142O7s5+Wmg0ZoEOd++ZltQH tXZCxaFGXfWokRo4wZKdg== X-UI-Out-Filterresults: notjunk:1; V01:K0:aQKvq0pBNJE=:wQh9NTDQFTt98popeH5inD V+l1jmG+lXyJgqD2sZg8yJK5qsdhr4A1fzE0KaEfoVnKA5xMS0kKrHsGTrobcydAnimn+aViz /ODYCph3wJcna/VcQO9zQ8f3xsu/PysoZUEDLgTOKGaH02XAZXIpCEL54/ChXLUUUwBFcQPKq cHW8RDug1i/qZDx5w1Jsy0gNZtSbq1cBB2RT6M9cTZfw45tCv8PrStfpE1Iv9xMQ53JBWmcOZ HxdsEnjtFtEd/vl7LW5yuZmBD5oTVaH6cFs5RIF7mP2sWM3pVRMZHuRfeouvR5wFKxGZIAk8u hKSBP0NFLcWpBfk3kG8/RQ4l3/PlCvNtz7/RasjHeTVqPOCl+6dBgw3lO6yUKh8uAEB9sM3YV 4mson6jTtBiMSGo1xIrX6c/hABeowRp8ppEaxtvqj49q45g2eYt9IjlzMN2GOJTAddoJpTvXp 4oVoY6dxf14FD6b4+3Y7utNYQO67WxkLGC4JmlD2zdgity2d0IgWCbpjowjyrG8hGESJXyats 4cdUUU7AOZVew0GuXtXH5lnbTRd4R8mGbfRF/p7LOPu22a16/S+DEsNm0dsQMJT69W8sOzg0f b9fVjYLXGjaLCfE6IPHQ53K1+qBOofP2Wm2qLcwYN2UQMifAcJHxaR4M3UCsJ3exy7iJvUV2Z OMrMAxVfBV+XxWqQJH2z4lDGn4ehiCalqpG0D2BdEfOPlqdC2J0R72rSt39AKm6aKVPY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A bugfix introduced a harmless gcc warning in nfs4_slot_seqid_in_use if we enable -Wmaybe-uninitialized again: fs/nfs/nfs4session.c:203:54: error: 'cur_seq' may be used uninitialized in this function [-Werror=maybe-uninitialized] gcc is not smart enough to conclude that the IS_ERR/PTR_ERR pair results in a nonzero return value here. Using PTR_ERR_OR_ZERO() instead makes this clear to the compiler. Fixes: e09c978aae5b ("NFSv4.1: Fix Oopsable condition in server callback races") Signed-off-by: Arnd Bergmann --- First submitted on Aug 31, but ended up not getting applied then as the warning was disabled in v4.8-rc Anna Schumaker said at the kernel summit that she had applied it and would send it for 4.9, but as of 2016-11-09 it has not made it into linux-next. fs/nfs/nfs4session.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.9.0 diff --git a/fs/nfs/nfs4session.c b/fs/nfs/nfs4session.c index b629730..150c5a1 100644 --- a/fs/nfs/nfs4session.c +++ b/fs/nfs/nfs4session.c @@ -178,12 +178,14 @@ static int nfs4_slot_get_seqid(struct nfs4_slot_table *tbl, u32 slotid, __must_hold(&tbl->slot_tbl_lock) { struct nfs4_slot *slot; + int ret; slot = nfs4_lookup_slot(tbl, slotid); - if (IS_ERR(slot)) - return PTR_ERR(slot); - *seq_nr = slot->seq_nr; - return 0; + ret = PTR_ERR_OR_ZERO(slot); + if (!ret) + *seq_nr = slot->seq_nr; + + return ret; } /* From patchwork Thu Nov 10 16:44:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101536 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824483qge; Thu, 10 Nov 2016 08:47:53 -0800 (PST) X-Received: by 10.99.244.17 with SMTP id g17mr25160513pgi.80.1478796473571; Thu, 10 Nov 2016 08:47:53 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u75si5835968pfa.86.2016.11.10.08.47.53; Thu, 10 Nov 2016 08:47:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935281AbcKJQra (ORCPT + 27 others); Thu, 10 Nov 2016 11:47:30 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:50852 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935157AbcKJQr0 (ORCPT ); Thu, 10 Nov 2016 11:47:26 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MdifM-1cS4CN2ia4-00PMDb; Thu, 10 Nov 2016 17:45:39 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 03/11] x86: apm: avoid uninitialized data Date: Thu, 10 Nov 2016 17:44:46 +0100 Message-Id: <20161110164454.293477-4-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K0:FA+4+ZuQg6TKlMDkxqXV9t+fqJGK2+oy/5d6qv5X5bZI0OeI2ms HGGT4pvARZnvsUJew22xH3sP5Wsy71gnEGH+WUgeFfpLdEHzTgxWWGmc7Jqr0cHZoKZDGhC tAb9s1wRugICk5O4srwGHNEfshXgBz5MKsKpID5whJbROvE+pAIVDJTzMd71xKXf2LX7sOo 3IQu6BEZCIg9CLD3wAgnQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:SJJy76HFdQg=:0L+I6UOk3+/UjBVEe8z+yL kzL7Dwt+Z5GsF2aZu3yb0O5f60yeiwiBd7JtuAXjhU77oc9oqRyq3henp05XQnjuNlvUwB115 XZA+Zt2/qjv706zLfJr7Jsj1Katk2Ki17KA0ZiTOFiM7gZ99J/1f3jGBru8viC5sPAYMmE2NZ OrOELCvAD9IsWNBDsxzYT7xfcAW933FyPZJnG718/EEeVyklTeE0wu67ibdQ5TWQ7KRfYvgEj 6Kxk+bbnWgyvu1yLGGh0xBKgZqYRqq6n3e3ynKdHgvHaXl7s/Py0MyU3rfR8qJvCxlA3bRV3q 1kN+bLZ85pLrCoTlONv1ZRrDiN4sFUpabej9yyYHBXGeRzYYfZo6YnPGqErvsos5V9M7fieBd 8/dBw0gGnzS8zSVecmNQlNKZ0aYIzifXuIheUudG5rGGd9/tPuOADke2ygC4mxTH1MT0D2D16 wyQOYnYqQ0Rt8dJx/UftFmiFfJOO7nTXNW7ujd0121hY7/8XYSIDqZDbXCNilDRSUXvqvZOtX 6WKHHs1SxDuJBnj87t0hCnKhiEWgvhMfhQphr/p4YWEFLiam7+KQ7BouWHThqyeydSZNkEl1t RJMHVUdzZfRqAKdjOZhrlC2WtWoUGMmMqbHfAB6cd0Jiu05/5bVCMdTZNgoGltI5ZIkDvs7Oz /JKploftbtd4A1DqvOdDxrYdCjOouFlUt2AOfNnq93VpSB+drU4StBBSNJArONgCwHDvQ6H9d g65dzzKh21abdkFu Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org apm_bios_call() can fail, and return a status in its argument structure. If that status however is zero during a call from apm_get_power_status(), we end up using data that may have never been set, as reported by "gcc -Wmaybe-uninitialized": arch/x86/kernel/apm_32.c: In function ‘apm’: arch/x86/kernel/apm_32.c:1729:17: error: ‘bx’ may be used uninitialized in this function [-Werror=maybe-uninitialized] arch/x86/kernel/apm_32.c:1835:5: error: ‘cx’ may be used uninitialized in this function [-Werror=maybe-uninitialized] arch/x86/kernel/apm_32.c:1730:17: note: ‘cx’ was declared here arch/x86/kernel/apm_32.c:1842:27: error: ‘dx’ may be used uninitialized in this function [-Werror=maybe-uninitialized] arch/x86/kernel/apm_32.c:1731:17: note: ‘dx’ was declared here This changes the function to return "APM_NO_ERROR" here, which makes the code more robust to broken BIOS versions, and avoids the warning. Signed-off-by: Arnd Bergmann Reviewed-by: Jiri Kosina Reviewed-by: Luis R. Rodriguez --- arch/x86/kernel/apm_32.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c index c7364bd..51287cd 100644 --- a/arch/x86/kernel/apm_32.c +++ b/arch/x86/kernel/apm_32.c @@ -1042,8 +1042,11 @@ static int apm_get_power_status(u_short *status, u_short *bat, u_short *life) if (apm_info.get_power_status_broken) return APM_32_UNSUPPORTED; - if (apm_bios_call(&call)) + if (apm_bios_call(&call)) { + if (!call.err) + return APM_NO_ERROR; return call.err; + } *status = call.ebx; *bat = call.ecx; if (apm_info.get_power_status_swabinminutes) { From patchwork Thu Nov 10 16:44:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101535 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824497qge; Thu, 10 Nov 2016 08:47:54 -0800 (PST) X-Received: by 10.99.126.94 with SMTP id o30mr25153762pgn.66.1478796474315; Thu, 10 Nov 2016 08:47:54 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u75si5835968pfa.86.2016.11.10.08.47.54; Thu, 10 Nov 2016 08:47:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964876AbcKJQrm (ORCPT + 27 others); Thu, 10 Nov 2016 11:47:42 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:55355 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935110AbcKJQrh (ORCPT ); Thu, 10 Nov 2016 11:47:37 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0LzTlq-1crk1u1tbe-014i3R; Thu, 10 Nov 2016 17:45:40 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 04/11] nios2: fix timer initcall return value Date: Thu, 10 Nov 2016 17:44:47 +0100 Message-Id: <20161110164454.293477-5-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:yBZul8vSPebUoQV9gsBOA5brnXGVrkdtd3lc191y03wW8ld4loT +HWZQ5UYFH5sJVy/2QURcpJyrTA/gllhHU3hCKQ2FKqkuFwPiqRJUeoo0+BPOHeE9jkppd3 GmuJZ85kJmWTSYwkooUZhMFBLVWwz2AuILZuNlaWQitt/j3vBLwjeqaFGhRHcNBIt/nK0it wTdJptLfoh8TtDft7Zirg== X-UI-Out-Filterresults: notjunk:1; V01:K0:02CAhnauOZM=:cRThe4uLJPdAW1dTO/AoFA +GlMqR+i6qnY9DmBWXbQpvAlJD9EF2gsh6whDuMOE98eOIAzoPow61XWecIYyzH7yo6qlBb/e omsaCrzWB6V5lr1kXF1DJ4GFPgvusJnwu7ZmcIKWPNGqwBxCCGvsUkQWO5iIXkJKOiYNCHfRs i0Ir91W6mg+kHrDz+jACyO5u7ch7hYhi3xlvlCKzVadm+cQuE0EpKPWaQT7VqqX1exvJQIVqe 8Ypc+0T5zPz9F6PznaCuOmlCc4qaXmhpr+B6QdbZ1CVs3yQZS1SnJlJMzv8f76APG9mCiKTTX oEBhbx1BW+s4ficD47vx7fdPqM073wpapKB9l1JeiWVZXRGwuRh/uvh4T0p0MB/CH4pmCzypk WtL016kWWxH3dUtiJirVhikw6kH6np0sS/o9CeNDDPIV+A4QwL0MrR8CX1FNkMitFSUwqaeY8 APwtNLlxNnv2zyEsljn7o3aicGVDqcYRTlGIb9BOjn4oef7l3jnyEO5abLJSRYMiOrpjnITcW +xfEZeOuAz5h56fBp/vzHxQ/SPDxQTGws5YuS42vzY1SP7bkhDP2V/JfPVDS2FVU3KeqtDVGK kbYYJ3z/KNPwg2Ly3AZJD+tzd+1G29beqZwOgKnxg3Y28ljCko/Ipu6WEj7o7dXHD2K40p/3h NZX+9JJIrTN7l230iLpsy+bs8dqeprKTEgzPuPh01+BbfZP+zqxJ49BYvEdbLwXXfnDo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When called more than twice, the nios2_time_init() function return an uninitialized value, as detected by gcc -Wmaybe-uninitialized arch/nios2/kernel/time.c: warning: 'ret' may be used uninitialized in this function This makes it return '0' here, matching the comment above the function. Acked-by: Ley Foon Tan Signed-off-by: Arnd Bergmann --- arch/nios2/kernel/time.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c index d9563dd..746bf5c 100644 --- a/arch/nios2/kernel/time.c +++ b/arch/nios2/kernel/time.c @@ -324,6 +324,7 @@ static int __init nios2_time_init(struct device_node *timer) ret = nios2_clocksource_init(timer); break; default: + ret = 0; break; } From patchwork Thu Nov 10 16:44:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101537 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824253qge; Thu, 10 Nov 2016 08:47:28 -0800 (PST) X-Received: by 10.99.67.7 with SMTP id q7mr90674pga.45.1478796447931; Thu, 10 Nov 2016 08:47:27 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zs7si4875544pac.45.2016.11.10.08.47.27; Thu, 10 Nov 2016 08:47:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964792AbcKJQqw (ORCPT + 27 others); Thu, 10 Nov 2016 11:46:52 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:65234 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934921AbcKJQqq (ORCPT ); Thu, 10 Nov 2016 11:46:46 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0LbmDM-1cU05B1Zfo-00jJoZ; Thu, 10 Nov 2016 17:45:41 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 05/11] s390: pci: don't print uninitialized data for debugging Date: Thu, 10 Nov 2016 17:44:48 +0100 Message-Id: <20161110164454.293477-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:pvDyEnuvpp9XQut/2OwDmXf7OQ7R/lKLFRs9r2Lrg0I4mKXcbK7 6GoIPKP1A1Oz4Pl0qBLR+VX6jhcoPQFEPUCGC0oo8HgWJkm9K1CuQQCvgdim4IS2BDysuaC nmCMTmlL3dzjeCD72vI8StNofcCb+9GKTptFwdUAJwLWG3PsKgNJg+qu85cqePko4lOkE+q uVVdoeyjkLWbLsVuU7MDQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:7UFD2cHaibY=:1OVUeWs+1bpYSWoMRn5Wc7 NpdiIhoTqdXD5zFI64+YIEG6pNnHkcgaHU4sKpJe5lO9wMQqqe17uhWmv6vMYm3FEVtB3PUel qE0DTYbAm3S+ZEOc5SzkfLEUtKtWulncHxQD5xiAd/n4ay/aYnryj3smINX87OcVNTC3kKvbV hMMt304QuG4mUe0Vrhak8++m+w7Yik1PvKomRrRoe+dAoXS+ZWZYSTBXMn2H4AFj/AcdbXWjm 6OzyriX6sN85/6YgzN0B2TyHyPnwdqqRAQVxXFaNF/rt7mIeyyyjjDW2xCyv6jqUNBhFbGjus iu162300sgmb6vht8CffS2jSEvTN+ROo3eLt0yKWwZPvgPVlt4EAZwy1vpukNsnks39W9SD4A kLiQmse6S+fUZHk8XbfF2qQMZhN9fAE7czaMRkJPyipohlmGzk0QINitfGrW/GIgDqzjpx9e2 RjCFdIJtiy7fU5U0wW07YHTsaMiLWL5Kibc4AZ9JZwB1WGCEUjrfq4HBBz5befWiecyhxOAoq ITFQ0WFqgIl1ACa2fZYQ4yhrmDLOhuIJ8qXRHD+9VRSfBquyNu0XoisnOY3XYYgGGvJVvotCd LTQIzIr0ZXLHUzyjReea6EFtd0stQK3dbdVopuYvlPLPloT8lcWu1alKIdNlG56MWkLPfXa/W f+G0G06s0kkMpOV6s1SQdtWyi66CkWC2DvXaIDkkxAcU3o5Ov3WGjf/SoB9dknArVwOs= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc correctly warns about an incorrect use of the 'pa' variable in case we pass an empty scatterlist to __s390_dma_map_sg: arch/s390/pci/pci_dma.c: In function '__s390_dma_map_sg': arch/s390/pci/pci_dma.c:309:13: warning: 'pa' may be used uninitialized in this function [-Wmaybe-uninitialized] This adds a bogus initialization to the function to sanitize the debug output. I would have preferred a solution without the initialization, but I only got the report from the kbuild bot after turning on the warning again, and didn't manage to reproduce it myself. Signed-off-by: Arnd Bergmann Acked-by: Sebastian Ott Acked-by: Martin Schwidefsky --- arch/s390/pci/pci_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/arch/s390/pci/pci_dma.c b/arch/s390/pci/pci_dma.c index 7350c8b..6b2f72f 100644 --- a/arch/s390/pci/pci_dma.c +++ b/arch/s390/pci/pci_dma.c @@ -423,7 +423,7 @@ static int __s390_dma_map_sg(struct device *dev, struct scatterlist *sg, dma_addr_t dma_addr_base, dma_addr; int flags = ZPCI_PTE_VALID; struct scatterlist *s; - unsigned long pa; + unsigned long pa = 0; int ret; size = PAGE_ALIGN(size); From patchwork Thu Nov 10 16:44:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101532 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824730qge; Thu, 10 Nov 2016 08:48:21 -0800 (PST) X-Received: by 10.107.53.165 with SMTP id k37mr7057555ioo.74.1478796501600; Thu, 10 Nov 2016 08:48:21 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i4si4875484pac.105.2016.11.10.08.48.21; Thu, 10 Nov 2016 08:48:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964922AbcKJQry (ORCPT + 27 others); Thu, 10 Nov 2016 11:47:54 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:59362 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964887AbcKJQru (ORCPT ); Thu, 10 Nov 2016 11:47:50 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0M48SR-1cwR0O1239-00rnk4; Thu, 10 Nov 2016 17:45:43 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 07/11] [media] rc: print correct variable for z8f0811 Date: Thu, 10 Nov 2016 17:44:50 +0100 Message-Id: <20161110164454.293477-8-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:I48EU70rNIIJauXLBOhPboRKL2oZVbv2PJs72dsP8yWyN+wBhQv MI4JMVkDjTOF9Qm6SPs3r2RHCUFCykxYDoWNWi+lK3g6VRz5N2/vISpkE8nOLAjZBD067wH 6p3ixXhzahFK1to+3rPA4AUqD2FL819COuIUal8ikpVCKO+WCv7ZhwhcEqwbic/6rrbUH2E 8/v0U86G+VLhn0E3Z/FrQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:XwQ2ynZpHdk=:tyxlLM3dM8D/BbbwuU6dfE /RUfqMQCQY09fiP+wgxOt85IPSv3NDhPXPtoPCDz4tAusOImfQvKKywJ0XfAZ06fymjlXnEib yyEZB+vTPM3W2Rs44emQQ9bmmoUVuT4r7HpsSc+SKGxz66BX8QF+2kOz+Rt7g+HKVOS9zjM8R J0hjO46c5DLHBp+MDJeUaHUKnc4Me9HiRycmL2aeWWgdOnlX+QYB1ihCCjMTjXNH3CZmxS5MW LXsFdzr/INbgTR5ScCpyhrR/qemBgdkT1EejWKhxlUZZvAgJ3pkLgfe0kJYh63ZvyuDtHLkSI nGr8bqJSQnJhtZYFxvx73gputt0OUQWHnyKfZNq5W46Mgp/+uFRYdUxsPdvFqJ33LlRfmCAsR jYc+AZqqh8LekAujjus/Qp2bFs8U4ObHRUfJUqVoqTRUIe0Js3NehkeoxxYNOUILSqqhbOEbw 97rWXUhEMxlWqjoLijuWm6XaQHXm3OP3ySONhkS+rzpFuyk6RXAKk608+NX3s7AiyyFtAlMUD 4C0B6IrJSls5YsjVdyaCVdDXCulNbeK6W2zEnks3c01IlLa6X8LCiSo8p7YKwhOlZHdWd+XSc xcDWpyFO7UF0gbNQQNq0fqPT59ueVeeb6Hq3lHPzkkaU4+XVrZTozVImEh5fJ0gkg0g7Dcgmb q8HdeQj/fgUFHL3H0TmkvfoQJvWvMVq9i6RixG8MHe+iHF+rQluc/lDFPKWpMzZ1UyX8= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent rework accidentally left a debugging printk untouched while changing the meaning of the variables, leading to an uninitialized variable being printed: drivers/media/i2c/ir-kbd-i2c.c: In function 'get_key_haup_common': drivers/media/i2c/ir-kbd-i2c.c:62:2: error: 'toggle' may be used uninitialized in this function [-Werror=maybe-uninitialized] This prints the correct one instead, as we did before the patch. Fixes: 00bb820755ed ("[media] rc: Hauppauge z8f0811 can decode RC6") Signed-off-by: Arnd Bergmann --- drivers/media/i2c/ir-kbd-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I submitted this repeatedly as it is a v4.9 regression, but I never saw a reply for it. -- 2.9.0 diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c index f95a6bc..cede397 100644 --- a/drivers/media/i2c/ir-kbd-i2c.c +++ b/drivers/media/i2c/ir-kbd-i2c.c @@ -118,7 +118,7 @@ static int get_key_haup_common(struct IR_i2c *ir, enum rc_type *protocol, *protocol = RC_TYPE_RC6_MCE; dev &= 0x7f; dprintk(1, "ir hauppauge (rc6-mce): t%d vendor=%d dev=%d code=%d\n", - toggle, vendor, dev, code); + *ptoggle, vendor, dev, code); } else { *ptoggle = 0; *protocol = RC_TYPE_RC6_6A_32; From patchwork Thu Nov 10 16:44:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101534 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824490qge; Thu, 10 Nov 2016 08:47:54 -0800 (PST) X-Received: by 10.98.200.8 with SMTP id z8mr11510003pff.176.1478796473976; Thu, 10 Nov 2016 08:47:53 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u75si5835968pfa.86.2016.11.10.08.47.53; Thu, 10 Nov 2016 08:47:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964856AbcKJQrd (ORCPT + 27 others); Thu, 10 Nov 2016 11:47:33 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:50439 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935138AbcKJQrZ (ORCPT ); Thu, 10 Nov 2016 11:47:25 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0Ll5ba-1cdO1O0g3a-00b6Kv; Thu, 10 Nov 2016 17:45:44 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 08/11] crypto: aesni: shut up -Wmaybe-uninitialized warning Date: Thu, 10 Nov 2016 17:44:51 +0100 Message-Id: <20161110164454.293477-9-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K0:pMptUU8f/fXpnZ1y/GKWImJVxyL8T6QqhZTLuSbNRSbnlgxC3EX 1X3mLU9PhMSHNeCk0T0XCzYM5fLNe/sz7lWwQpUsGlkPTQUzk9xT/fZR5/0+8AMTTFkT1Z3 JwAKAfRcTbwtOZe0nm5z7xJMvd7eDT3N7vE0i3pw/YoGsQUo0jVzDNe2DdLfc5K+R9VSflw GjBc0XYi6YktrO/ah7IyA== X-UI-Out-Filterresults: notjunk:1; V01:K0:dZWCbpHHfVQ=:Bi731d0PgQ6glBTDHVvpym lzgrKKfWaOoNQSyx+WLaHXfGww3HW6XMJ7uyIEEY+KErZbbrqgJTnugaY+I4oY2OU/Jp7pZuy c3Xo971tJhBb75to7uvYLKBZ8g0aFcVr4dpkNlvrjYO8np0BQDuYYe9ZG4jw8CurkbTWWHnJ/ +7/aZFL6gVR800qNNO9zHRjjR9q5mkCdI9IKqnKvhA7zXfbWt4YG//nmN6gsBZWvN//6p5QJh Xkqrmmh2DbB5qlq0+Bj+8BolXtgKcMklubcafz5+YgAiGjhOVSw2pr5dpPawaaLBRJXAFGUL8 5NEk8mCBvNpTyTeAvGznENCuYftZ78MdjpPLxf9ScxOPxBjogtNJy5ge59+Hi6LjLZ+VSH0F7 x80C8mZ2hHcu3Af/595pgg+xdRRHqnf65kmTZkqIVab3JZEcyEQU6xJfKcVdzMbkiwBYE0oyL 8vf4RTYrYXzd8VPbyedMWhkKb7+bKbrFgs3R0tYtDyvMDtlI2xRBAAw3oPZVNn5B35bMcwnID 2g9DjUD88yIZlDgqSeirTbsnrzphDKctLvhjncSQjIUf7LyEazSWK7E0iGWJyeR0adCbwuECh HJaW3mem9EF0CXhB0Vp9PlPybe6ShSBxYdqv0iVHI+VvlzWqK3MLZRcWHQewBgCeS70hE7Eqn 6+KLYiB1U3re/YdGHwsK9mBR2LnkSZagLQqUHEykVz0myEWVXiUNGNgqpomqXzVNtVZ9Qxq7r 473ButSojgHfXqkA Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rfc4106 encrypy/decrypt helper functions cause an annoying false-positive warning in allmodconfig if we turn on -Wmaybe-uninitialized warnings again: arch/x86/crypto/aesni-intel_glue.c: In function ‘helper_rfc4106_decrypt’: include/linux/scatterlist.h:67:31: warning: ‘dst_sg_walk.sg’ may be used uninitialized in this function [-Wmaybe-uninitialized] The problem seems to be that the compiler doesn't track the state of the 'one_entry_in_sg' variable across the kernel_fpu_begin/kernel_fpu_end section. This takes the easy way out by adding a bogus initialization, which should be harmless enough to get the patch into v4.9 so we can turn on this warning again by default without producing useless output. A follow-up patch for v4.10 rearranges the code to make the warning go away. Signed-off-by: Arnd Bergmann --- arch/x86/crypto/aesni-intel_glue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c index 0ab5ee1..aa8b067 100644 --- a/arch/x86/crypto/aesni-intel_glue.c +++ b/arch/x86/crypto/aesni-intel_glue.c @@ -888,7 +888,7 @@ static int helper_rfc4106_encrypt(struct aead_request *req) unsigned long auth_tag_len = crypto_aead_authsize(tfm); u8 iv[16] __attribute__ ((__aligned__(AESNI_ALIGN))); struct scatter_walk src_sg_walk; - struct scatter_walk dst_sg_walk; + struct scatter_walk dst_sg_walk = {}; unsigned int i; /* Assuming we are supporting rfc4106 64-bit extended */ @@ -968,7 +968,7 @@ static int helper_rfc4106_decrypt(struct aead_request *req) u8 iv[16] __attribute__ ((__aligned__(AESNI_ALIGN))); u8 authTag[16]; struct scatter_walk src_sg_walk; - struct scatter_walk dst_sg_walk; + struct scatter_walk dst_sg_walk = {}; unsigned int i; if (unlikely(req->assoclen != 16 && req->assoclen != 20)) From patchwork Thu Nov 10 16:44:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101529 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp825721qge; Thu, 10 Nov 2016 08:50:24 -0800 (PST) X-Received: by 10.99.242.5 with SMTP id v5mr36570044pgh.181.1478796624610; Thu, 10 Nov 2016 08:50:24 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m124si5819338pfb.123.2016.11.10.08.50.24; Thu, 10 Nov 2016 08:50:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964963AbcKJQuU (ORCPT + 27 others); Thu, 10 Nov 2016 11:50:20 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:49928 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935225AbcKJQqu (ORCPT ); Thu, 10 Nov 2016 11:46:50 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0LoMri-1cl7FT0QTi-00gbaX; Thu, 10 Nov 2016 17:45:45 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 09/11] [v3] infiniband: shut up a maybe-uninitialized warning Date: Thu, 10 Nov 2016 17:44:52 +0100 Message-Id: <20161110164454.293477-10-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:S7m3FaVgPzrWtSVAMhnD0cxIkMlj1cjoKJ064YuZsirZIVjYDNR 4MmtU4yu3/ZkSU1VK/nUVWr4t76jU1fgTqhsED9tqV4bZgbbnesRjN7+0D+nF9yGIF/Tyvx EZjbhiaUMJsmJNCJ4QyCeT4rWfWFqhXcGakismITuqmhhg3DLRy/i+MBWMeWZcwhex1Arx4 5oqdZFF8XcCR7RjRkgwsQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:m10LbQcS4zk=:uIRPS18UDd2aLMI3m8KP9Y KdhPir5grrutN4VP+RCetLQ7lQN5CURg3d7M4bnCRxd/um9NcbzXU/qFo33uZyBiskwANQI0j O0UqcDgztx45Xi+XOnU6A03hhNbmv4KfIFndnRFa4kk73+H8n6b/T5pZL6w46LTgKX1khmpGn qOWnliZVy/oozpXyD1zgcDx9mnGycUdjfHS83AVIn7xdGujjFYDIQBMlGHjApaYXAm9O1slDp o11ywnQtVyJSYJbIfoU7bib+OB95sQXYXusd9DG2wahtah7ZW7DM7EWOAPUiqxZJchfG3+W6k 7I+aW1jMtNk1mHX2Gb3mVgaBeEvGDf76j/CpJjdj1WPnTy5WL0W7h39CfeTUT99fPVaqDvdx/ MKdgWtb2aBqHTF1xjDzGnKfmJAAWEj852gfOTd1T76tnJdkEcuSUrnGmUR8vV8hV/0bN5GP1k x2o6sO5A/4GojlysjLEFYp9MJPVHYUTY6V9D8BZxtz6+W5SH04ttdkkEyoH0PvLP7qcBQdSjn 4PgEyaQGJX4lOyo+jyk58eOW04LRhfGN1Ej/XCoUyvo1Aw1KFSQEEkl0YDnhfvdIaSHjGkC3v 0y0J+HuH4rXpeHaZvsWDyZx3GNYOYDcs004NPx5GoAvdbENmgdm55hDfHcaSYUqqldJ/g6U2c x6te+V61JFd7oLh1eUW38idIBwRfptZoOa8uDwcWQgEPzLeRTUs9NXPFYO5q4X5sejbo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some configurations produce this harmless warning when built with gcc -Wmaybe-uninitialized: infiniband/core/cma.c: In function 'cma_get_net_dev': infiniband/core/cma.c:1242:12: warning: 'src_addr_storage.sin_addr.s_addr' may be used uninitialized in this function [-Wmaybe-uninitialized] I previously reported this for the powerpc64 defconfig, but have now reproduced the same thing for x86 as well, using gcc-5 or higher. The code looks correct to me, and this change just rearranges it by making sure we alway initialize the entire address structure to make the warning disappear. My first approach added an initialization at the time of the declaration, which Doug commented may be too costly, so I hope this version doesn't add overhead. Link: http://arm-soc.lixom.net/buildlogs/mainline/v4.7-rc6/buildall.powerpc.ppc64_defconfig.log.passed Link: https://patchwork.kernel.org/patch/9212825/ Acked-by: Haggai Eran Signed-off-by: Arnd Bergmann --- This is marked v2 as the rest of the series but is actually version three of the patch as I had to do some other changes already. v3: remove accidental leftover change of the original patch drivers/infiniband/core/cma.c | 54 ++++++++++++++++++++++--------------------- 1 file changed, 28 insertions(+), 26 deletions(-) -- 2.9.0 diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 36bf50e..89a6b05 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -1094,47 +1094,47 @@ static void cma_save_ib_info(struct sockaddr *src_addr, } } -static void cma_save_ip4_info(struct sockaddr *src_addr, - struct sockaddr *dst_addr, +static void cma_save_ip4_info(struct sockaddr_in *src_addr, + struct sockaddr_in *dst_addr, struct cma_hdr *hdr, __be16 local_port) { - struct sockaddr_in *ip4; - if (src_addr) { - ip4 = (struct sockaddr_in *)src_addr; - ip4->sin_family = AF_INET; - ip4->sin_addr.s_addr = hdr->dst_addr.ip4.addr; - ip4->sin_port = local_port; + *src_addr = (struct sockaddr_in) { + .sin_family = AF_INET, + .sin_addr.s_addr = hdr->dst_addr.ip4.addr, + .sin_port = local_port, + }; } if (dst_addr) { - ip4 = (struct sockaddr_in *)dst_addr; - ip4->sin_family = AF_INET; - ip4->sin_addr.s_addr = hdr->src_addr.ip4.addr; - ip4->sin_port = hdr->port; + *dst_addr = (struct sockaddr_in) { + .sin_family = AF_INET, + .sin_addr.s_addr = hdr->src_addr.ip4.addr, + .sin_port = hdr->port, + }; } } -static void cma_save_ip6_info(struct sockaddr *src_addr, - struct sockaddr *dst_addr, +static void cma_save_ip6_info(struct sockaddr_in6 *src_addr, + struct sockaddr_in6 *dst_addr, struct cma_hdr *hdr, __be16 local_port) { - struct sockaddr_in6 *ip6; - if (src_addr) { - ip6 = (struct sockaddr_in6 *)src_addr; - ip6->sin6_family = AF_INET6; - ip6->sin6_addr = hdr->dst_addr.ip6; - ip6->sin6_port = local_port; + *src_addr = (struct sockaddr_in6) { + .sin6_family = AF_INET6, + .sin6_addr = hdr->dst_addr.ip6, + .sin6_port = local_port, + }; } if (dst_addr) { - ip6 = (struct sockaddr_in6 *)dst_addr; - ip6->sin6_family = AF_INET6; - ip6->sin6_addr = hdr->src_addr.ip6; - ip6->sin6_port = hdr->port; + *dst_addr = (struct sockaddr_in6) { + .sin6_family = AF_INET6, + .sin6_addr = hdr->src_addr.ip6, + .sin6_port = hdr->port, + }; } } @@ -1159,10 +1159,12 @@ static int cma_save_ip_info(struct sockaddr *src_addr, switch (cma_get_ip_ver(hdr)) { case 4: - cma_save_ip4_info(src_addr, dst_addr, hdr, port); + cma_save_ip4_info((struct sockaddr_in *)src_addr, + (struct sockaddr_in *)dst_addr, hdr, port); break; case 6: - cma_save_ip6_info(src_addr, dst_addr, hdr, port); + cma_save_ip6_info((struct sockaddr_in6 *)src_addr, + (struct sockaddr_in6 *)dst_addr, hdr, port); break; default: return -EAFNOSUPPORT; From patchwork Thu Nov 10 16:44:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101540 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp823986qge; Thu, 10 Nov 2016 08:46:56 -0800 (PST) X-Received: by 10.99.125.77 with SMTP id m13mr25302913pgn.58.1478796416607; Thu, 10 Nov 2016 08:46:56 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 76si5784674pfo.238.2016.11.10.08.46.56; Thu, 10 Nov 2016 08:46:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935215AbcKJQqm (ORCPT + 27 others); Thu, 10 Nov 2016 11:46:42 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:54772 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935010AbcKJQqj (ORCPT ); Thu, 10 Nov 2016 11:46:39 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0Lst7y-1cpX6p48C2-012U3x; Thu, 10 Nov 2016 17:45:46 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 10/11] pcmcia: fix return value of soc_pcmcia_regulator_set Date: Thu, 10 Nov 2016 17:44:53 +0100 Message-Id: <20161110164454.293477-11-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:t95QodDqhnfoa2pCBD/pm7c0QOd9qacrB1eGB5hVoRZl1Ir4NeE Aq54UHjtB+Vh4N9Pxx7gJPQvXPGs5bVzciMnPkO2JgeMMcTII+n/ucigD3jURJBGW8iIbB/ AjAH1tveDxAwOtTmwdDemh5aJ8kXrpvtigp6O6pUS2Nh7kzRlivD4TEIFgZ/8JZ9bUzDSCR WeGR/fCUnQfJQOSJR+ZoA== X-UI-Out-Filterresults: notjunk:1; V01:K0:Gv6vu2smxh8=:Wj+z5+FGCKOy4KfjzYzUcC S5ljuBh3SicWU4jP5+uspQR8KH7YY+chpC6ZWI2umywYjnPjuQBIx4juFPYUGExYnWy6eaGd+ FrZjEUnFUXf9ycZWUNLu616gbWZrda+dOvxggdZivMzTtaBk3r37rWlDkAxMqV8JJoedsAMZN DY4+1L75PuF4keBiVI10kVejgMRuGc1t65WBuLIis0jjoQSijYiNNb+O35jIYu/isHOR6wB8L SfPUNhYQ+iJ7+7wsdRx9a3HrvekV1lReJu8eyvCN3DCjhfewoHv9u6Uh67GRCZK/n/Dg5ugD0 GqcxjVPcnJdAbq6k9Oe1aZGJFK+AbqdKzuC0AQMY//qNeb5if+UPqSMRBW1TtzO8Gei6A6o1F 0VPxtS28LhJO+lt2WizDCuicXH3S5PRdpDelfmLjTv+K96ZazOsLgFSNLfaP85VdBbXdDoSDz 78JMsUyWAPuX4kQVXSpI+JI4cpP1cqziB/oSbwjloWB2RlMVQD9AdApCHGg/KRYI39xTzEWI+ fJ8uvXifzray9l25MzVwyeHLa+AxBAmoyuDWHAXj/JI83unCt06UJfu8jqPd+Q2mRdobD4EWF FiU6ZZcYARj79AFqS7DnindhYuUWSaJYuNZIy+7I4z37AGmUCK1+jaXkHjxOpwPFJehGdo4V4 Ts9sMrOaNnXlwXn69zczsMYewB6/uhhoMnGQ0Ts52kxVKpPcoOUmxUBfmtrJKUvI+IG4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly introduced soc_pcmcia_regulator_set() function sometimes returns without setting its return code, as shown by this warning: drivers/pcmcia/soc_common.c: In function 'soc_pcmcia_regulator_set': drivers/pcmcia/soc_common.c:112:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] This changes it to propagate the regulator_disable() result instead. Fixes: ac61b6001a63 ("pcmcia: soc_common: add support for Vcc and Vpp regulators") Signed-off-by: Arnd Bergmann --- drivers/pcmcia/soc_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c index 153f312..b6b316d 100644 --- a/drivers/pcmcia/soc_common.c +++ b/drivers/pcmcia/soc_common.c @@ -107,7 +107,7 @@ int soc_pcmcia_regulator_set(struct soc_pcmcia_socket *skt, ret = regulator_enable(r->reg); } else { - regulator_disable(r->reg); + ret = regulator_disable(r->reg); } if (ret == 0) r->on = on; From patchwork Thu Nov 10 16:44:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101531 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp824862qge; Thu, 10 Nov 2016 08:48:37 -0800 (PST) X-Received: by 10.107.17.205 with SMTP id 74mr6871554ior.96.1478796517749; Thu, 10 Nov 2016 08:48:37 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fi1si4888822pab.9.2016.11.10.08.48.37; Thu, 10 Nov 2016 08:48:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935415AbcKJQsf (ORCPT + 27 others); Thu, 10 Nov 2016 11:48:35 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:61240 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964878AbcKJQrr (ORCPT ); Thu, 10 Nov 2016 11:47:47 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MHfXI-1c5ywY3m9s-003PTv; Thu, 10 Nov 2016 17:45:47 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 11/11] Kbuild: enable -Wmaybe-uninitialized warnings by default Date: Thu, 10 Nov 2016 17:44:54 +0100 Message-Id: <20161110164454.293477-12-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:bAjFzAv975O55N/Er9AEM4XGCSaNbeUMLaLIZdxmQg0w46I2Tay x44oSOCr7j350/i06yF1z4lAt5ETrbi2kyu+ZZ8Qy02hTQJpXX/ngJNTXi1YWIAg1WIO+nT mTnz/1HsNg1iBi3Fc/AgfNlMSu52J+E6Cy/OlS99Ccr2BfHqMZtv1w7WmzmEtz5dysTWcAN RELdH8jeX5ZhSC7g5eBuQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:IihISzsQ98E=:3+zGG4LVU1nJonLCU+47Zl qFM4yUvEWUT2l8+Z/ZpqIuRvOz7lN1lgde4UTHC+fNr+RUaz4xoCrO9A9x5SQaHEPYRjDjKUS Xvc19Tx+6PIaIs+MLSsWwqHd5aKOy/5Os4Sp1D/wyZn/dZXl1dtdpB/p23VS41NVY6w7t13Wj 8kcrlr/28HPTMY0b5YlPD2ua+I/usb/hp9H6YKPO2s0g3W5c1mSp/msTonibOC/8Yz+AGtVyE gV5VDy0axIDGG8FBPAFTxfgqWflSrKcXoxPIL4Dml/BLiPDY4qSPfB9Iun+33cN3Aa3O+go2h DEWtjDukLWXurBEe4ru39MsPzQpXK1t2vZg4+1V+EcHYlUywBCslXo/ERyIcQh2vl+CejrhKr WjHPEpCNx0BlaruUAV+UluUqC8DlD18vIhS1iLovx/PIaadjQgLM+A/P59H82dRoxj1Enll/A t2GsRmhM8v3JpnxWz7lV/7LbYePqS/+rcHn+WInB23GenCL1pGN7O0PBOvtqQhjd00aXES8ye t3j4Er09y+h073BDUlHeEUGrSNcs2MAmp8ZiPNpvWth+gfUwRNFUtNt6dv5p4+vrIHTnffvAN yckfBO08Odnk5QIHcNPyn2AhMN7ejpoAQ+j6/Jspjcy1CNgzsooH/swcinc02wuVgM1hqONAT cXP7fNN18F27b9fqT+eY0t1rzjiZkd8jZigxg2V0U6EQ4832lJEepR+p2RoLVlFZi9T4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Previously the warnings were added back at the W=1 level and above, this now turns them on again by default, assuming that we have addressed all warnings and again have a clean build for v4.10. I found a number of new warnings in linux-next already and submitted bugfixes for those. Hopefully they are caught by the 0day builder in the future as soon as this patch is merged. Signed-off-by: Arnd Bergmann --- Please check if there are any remaining warnings with this patch before applying. The one known issue right now is commit 32cb7d27e65d ("iio: maxim_thermocouple: detect invalid storage size in read()"), which is currently in linux-next but not yet in mainline. There are a couple of warnings that I get with randconfig builds, and I have submitted patches for all of them at some point and will follow up on them to make sure they get addressed eventually. --- scripts/Makefile.extrawarn | 2 -- 1 file changed, 2 deletions(-) -- 2.9.0 diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 7fc2c5a..7c321a6 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -60,8 +60,6 @@ endif KBUILD_CFLAGS += $(warning) else -KBUILD_CFLAGS += $(call cc-disable-warning, maybe-uninitialized) - ifeq ($(cc-name),clang) KBUILD_CFLAGS += $(call cc-disable-warning, initializer-overrides) KBUILD_CFLAGS += $(call cc-disable-warning, unused-value)