From patchwork Sun Jan 13 19:30:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 155380 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2903169jaa; Sun, 13 Jan 2019 11:30:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN6SS3wX8ztnV5lq0mEGd777iv+JiXlovtivdi/9/OwG9/EktByKZrF62WEg731SZw0hhGfH X-Received: by 2002:a17:906:5c45:: with SMTP id c5-v6mr17997304ejr.83.1547407851801; Sun, 13 Jan 2019 11:30:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547407851; cv=none; d=google.com; s=arc-20160816; b=NaaL8RU5qXcxZbK3Y5KJDV2IqZ0U6lbLKXJEzy6xHNIRd6IRQ/2gttEMCEeAiq/m3m m2DLvr2uH/e+D/SISsQaibrEBI7HN2og7fICyTkoK9vSnqvjyTTKlh0NO8ImJ99VOscS kketAKsPyOmAPA3hD2c+fZdnYvNUpTDcMbS5R0SvVnm2GkdiiMELiL6CsBekbbHkIOYl xwHBx3NbaakAZu/ECh9vyagz6eDOU3A16RDJJG6BF1LdTIti6ue8J6ate9qM3p85PshT l3nKV9m3OMPzqWBklYR54ndQE/9jWO3XG1Iut8i4e1UcxwUheuJ1W8ttBdupXEKqbmmo 4DhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from; bh=ChSm8AxPdYg+0tipPiIdbF5B81wE5NqFr0DG7CYVIjQ=; b=qS0fQo5ubqQRzUDNueQ+mwJHNSlF09ZDGNEq6hSumGRUTu+QpGf8b3frvdI+XEwT98 zsqCCGNolGh/NBuOiVtrB0G0/Va6XavkLG5Aztz8RdOWRgk4vk/uuuQJ7qcVy+FZDjhY sadaDQoDD3byb58edJMS2pXkkbnXnOlqFQHtrcpvCHoxgaa0B94yvWEKY8MguNldhHSc y0+TYMvf2eWZzEFMRDpS1uKG+BNpIop9JnRllSqWoILcTezOEwQksbngC9ssggFKESOD bcKNOL+b0efzVkgUykpuvbKWVu/3vdUBsauM5ZXZBRFa26P6eLhZOPjvitTFRWmnC4M6 IbuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id j9si1532508edr.185.2019.01.13.11.30.50; Sun, 13 Jan 2019 11:30:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id 627C3C21EA8; Sun, 13 Jan 2019 19:30:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 57AF5C21DB5; Sun, 13 Jan 2019 19:30:46 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 178FEC21DB5; Sun, 13 Jan 2019 19:30:45 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by lists.denx.de (Postfix) with ESMTPS id 8271DC21C2F for ; Sun, 13 Jan 2019 19:30:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 18AD7AF14; Sun, 13 Jan 2019 19:30:44 +0000 (UTC) From: Alexander Graf To: u-boot@lists.denx.de Date: Sun, 13 Jan 2019 20:30:40 +0100 Message-Id: <20190113193040.41756-1-agraf@suse.de> X-Mailer: git-send-email 2.12.3 Cc: Berkus Decker Subject: [U-Boot] [PATCH] ARM: bcm283x: Fix definition of MBOX_TAG_TEST_PIXEL_ORDER X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Berkus Decker The MBOX_TAG_TEST_PIXEL_ORDER define is incorrect. According to official documentation it has a slightly different numbering. Correct mailbox constants are defined in e.g. linux raspberry-firmware https://code.woboq.org/linux/linux/include/soc/bcm2835/raspberrypi-firmware.h.html#RPI_FIRMWARE_FRAMEBUFFER_TEST_PIXEL_ORDER These are obtained from the bcm2835 documentation e.g. https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface#test-pixel-order Fix the define to get us back in sync with the spec. Signed-off-by: Berkus Decker [agraf: clarify subject, extend commit message] Signed-off-by: Alexander Graf --- arch/arm/mach-bcm283x/include/mach/mbox.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h index 2776a396c7..e3a893e49c 100644 --- a/arch/arm/mach-bcm283x/include/mach/mbox.h +++ b/arch/arm/mach-bcm283x/include/mach/mbox.h @@ -348,7 +348,7 @@ struct bcm2835_mbox_tag_depth { }; #define BCM2835_MBOX_TAG_GET_PIXEL_ORDER 0x00040006 -#define BCM2835_MBOX_TAG_TEST_PIXEL_ORDER 0x00044005 +#define BCM2835_MBOX_TAG_TEST_PIXEL_ORDER 0x00044006 #define BCM2835_MBOX_TAG_SET_PIXEL_ORDER 0x00048006 #define BCM2835_MBOX_PIXEL_ORDER_BGR 0