From patchwork Fri May 27 06:54:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yihao Han X-Patchwork-Id: 577071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D84C433F5 for ; Fri, 27 May 2022 06:55:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D8CE316C8; Fri, 27 May 2022 08:54:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D8CE316C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653634541; bh=ClcbCf2hLI3x1cz73SJJNlFmkyjPd5XDOJrhA85Oz5M=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=PN1P1dYlS+1hY9mTYKBOOZnlkH7As5RZSYwN2W7pP9nOq89g0GF8bKq94uYyhacv6 rddrd2Hp97uIaC6i3b2tVk7Qr3LVkLIAaHwywrMFIBNkDowv3tnKizYFo2a9hRfoYo FdJCJ4cz1GiMPn560J09OPPTrhdArFoecdztB44c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 65D76F801D8; Fri, 27 May 2022 08:54:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31FA6F802DB; Fri, 27 May 2022 08:54:50 +0200 (CEST) Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on20715.outbound.protection.outlook.com [IPv6:2a01:111:f403:704b::715]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A3FEEF80100 for ; Fri, 27 May 2022 08:54:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A3FEEF80100 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=vivo0.onmicrosoft.com header.i=@vivo0.onmicrosoft.com header.b="HuNGhQ6l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XV60BnFKuANmqgkOweW7MVAhvEN6znrr+OATF+EJNKy1TynsbSFZ51nH6b4NXxB9GvHG+unftfUDTu/KAPTZz/kKdU39xCFO/c40p41Ro3jMqpCcgLOVdkBhcRY1c4VIlrSvwl2SiOMrk4JC4WASUiUEVeyaSAwCuD0odPBywef4mt3twSaX7jJSI3kItDQjLryffA5qHO2qNRZfeUsHiWuUj5pgTKfw4I2TnL479P+VACPuqoKnOwcri8EF/ZhxM/O9VPS9EgOhNzbMpUS8lWnK19o5MaZxnGUZOsBgosQbyWc9SLRNu024MjhMxlR4nKTEe6VsBs7bLDwkBZx4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sEWL3YXc1rYYEPJpdiOkM5k6qpACnJFEbxJApmZCJWs=; b=WeSWyieknjzeeYiYxPPfc1N0BGNG8QzLNlXsM8ZhnVD6oXdY5cnyKyiT2iO8SweypV+LhJ1NWBJCwpaYehoEpwZEAhVRh4T3VHsYo9mFxzAoqf5OB22Es42sVq/QVPuhCG1BKQ2pKjri62/XeibN3m58MtNkaXdINx9p5t91Ea4+UIdHKafJ4NTm7YRm0eZfP1ZSKsDUOQgVoZ/YUpbHn/4QX90pRRbVGHxUHcYKdeaPvjKHXLIjS+yh+o12oEYXs/E2HCc71UAo9l/A2/v+oy+hLoJqmz89vmwGDHaY8yafO46snwjOfy0DwsJiFlf+mq+KMP3Na+ssKUpUXbLVaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sEWL3YXc1rYYEPJpdiOkM5k6qpACnJFEbxJApmZCJWs=; b=HuNGhQ6lCrVV+KGbVaGardm9JwMhKoFjy/0qqBZH5+SPeA4g+++eS0BMj7y/gmitgQu97YPrFP7sz1c2hHKGa9GP/SzNmkuwyXkpIkYts2/fHGXNwiFS5S+8oQo2QTvXybKjjTsi+EBI87nsPpqTtKpq1rU8X01z/mDZqaNP28w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from TYZPR06MB4173.apcprd06.prod.outlook.com (2603:1096:400:26::14) by HK0PR06MB2371.apcprd06.prod.outlook.com (2603:1096:203:46::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 06:54:35 +0000 Received: from TYZPR06MB4173.apcprd06.prod.outlook.com ([fe80::a92b:6d92:5ad9:febb]) by TYZPR06MB4173.apcprd06.prod.outlook.com ([fe80::a92b:6d92:5ad9:febb%9]) with mapi id 15.20.5293.013; Fri, 27 May 2022 06:54:35 +0000 From: Yihao Han To: Krzysztof Kozlowski , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: samsung: i2s: Check before clk_unregister() not needed Date: Thu, 26 May 2022 23:54:12 -0700 Message-Id: <20220527065412.3677-1-hanyihao@vivo.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: HK0PR01CA0068.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::32) To TYZPR06MB4173.apcprd06.prod.outlook.com (2603:1096:400:26::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40245e5b-95e8-4a08-1fae-08da3fadc284 X-MS-TrafficTypeDiagnostic: HK0PR06MB2371:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1JoOhOgqWtkd5qwutXuiy198XO3nfpo8u5/MC5QMBZPZ3f9Ab/tBjxLE6+gd5sJBW07Ww+RjpDvP3tgdIQpbapD/r97BwAW7fI2sBBGriILDo79mF95+dqYhUit2d2VRTkuDRmjJZp00xMXttVvWSX/io6OAf8iSKcTN1vnBc2C+AdK3xrneyt28IYJnlI3R+uL/oskaK8EaN+nLqUhOkQMuj4/lXaXJ3dJaqOutmlF2r+HczzLlQefVQCWV+++dTI4MaCKBFgDeQGHDye6TrrRVIwwghModuWRZ/ycAfj1owxydaU5LeaIf+CNT9vvcdbwmBFaBvxUxNYEGpASHoGqyDyYyDujftvyUZssangfe9zid8ZbFETwz+H/ziFL708KiB6UcZ1D3AjCB7gMCgrrh6R1s8fLQA6HEOesmASr6dPkR0qxJh0n/tCoER1oPmQBB2qMIaf2P05WBMYGKyS2OXFxrWsTBCaG/CIYzvkmWqU7G1OW4VXdhznC58hmGntT21ZCFYneix6iWeMbayi011ZUswqTm/b0Z4PfvJuYXCWoMMZdlFV36maz9XZ3zMEbXMSXHFGhtU/5bii++8sUqzjUaaWqFuzFoxtrH+qi39I9kT3gEd8VJcaejOvJ+ccQ+uxpCZH+76dDJLTtvkXqPu0HADFtWez56ziaqT8JzGYUkFztOlMeKbQ+z5kOM5c5zNhAUpsR/X6FNsIxfrA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4173.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(38350700002)(38100700002)(508600001)(8676002)(66556008)(66476007)(4326008)(83380400001)(66946007)(6506007)(36756003)(6666004)(1076003)(6512007)(6486002)(316002)(52116002)(26005)(8936002)(2906002)(4744005)(110136005)(107886003)(186003)(86362001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LGdXtrTvcoz1LORfrgkjeLF7a/g/T+CHXhBwiEdPJVVplfq8aIuzn4L18rSCONI1/EUtmu+j/kPNBhupcoCJreUqeyadVNvuA5AyolIasI0v1/vqe17UAYNdYMmAY1Urqaz/5/HpuHTJyk8uaPPLg8VJAfn90buih+I93N+CJlFJoQo4E8vc5xvvLNCcHqqFL+TUWqaj/oo9HXOYDEJkOjNS6u1b/lHO7trZ4JAzhisuwKxwpJcr3mCLfytG9TW7q4o7Xk1qMPgLh6CcqhOrHbJRcNykXVutL7PLs6MHNSzyA8+iXoy+EvrD5LPigJ7OzXz2I+95WdBBKaOFvwpWFhoiMDU6SXoS8CvgzwW6yeAoXLoOWWOHb1rNesWko5ejG5EeQVHqFQAGH3eVrsn7B7sGNLy9Q5My9jPTpdOtEsBj2/JZnFgmC/sLxwWvk1PYJJpl13BGzD02gudLMwztLW0oKoXFuQcbBjgO7HOJQ2ZJb6EZoShR4uMkFPgH2NRN1Tey3t8A2Plpd7eqllpZCy0W3XOE+ggwYp/ExZA7czTi53iSuYAdA5NoszjoBzRsXiKOTWu0bZJvljqPbtlyMs8Y9cMfYQXXRMlbrAIO/Rx0R7DOYUANLB/OSYgelf+JaESF2nmI/ktKVZ3roEq6ndJrdJOb9oHiCvX3W2mdiUKDGxJt5Gka15q3KPq+pNdgceAdbAwwqiMb/TWQlHfGSLPqcFPI/30YpltH2xVlqxbpK0qVg2c6ghgF1QbXYT/GzvgHJY1g7MOXqWBXY7u3fDlgi2Ffk62fI4dshq/OtMd9Dn8vuW5VCh58wASbMnC6N/Vc80vbL+0Hot+NP7fK+OBlyFQcnkjNpp0T0VSyK4s104/sSt8x1nBYNyR8i0VXHTWS4rn248pRNdBCWIu+TUK+B4amD7T3uPPQ6LObnKSnX4CdDtgTc6rKOC8Ct+SpX9VQwdOGNQp3Heet5KyhYtcuQdpe6YnqyWlH2r2CFaccopqlvJNBRTirER3zkAcNiQNENH0pbfK/TVSetL4xs5K7DjMjHTE8Uc/zu8okTEm12PavxXr01DQdkFl3lbdjBF+uZQnTnolUeO7gDp43J+fUNcSlTBgjF0DZhtOrvCnVkoMBwSdm+ATFVV1h90emh3cHRZjKzBrwVeCgIozCCJNfX+XIMXjMjW5FOzX6/mR7LQlZorgOk3CLitkUxQiSTism0Ed2YfNPqyhG2xCl8G/lqZczEa3bpw8P22bbOiI/UJ9+u+UyhmGkIQTTGjmFN0mwUr4saojv/EzY39ySlNcHeuB8WISe1hZKAi/oxF5CZESbMeXOFYv3mG5sPHVnbLc4H7F/78cgVxy/KS/PlwiMR+e4YGCrjRUJSpoQHksH4bYEHaGdCg25CZSTdvc/iYV96OTrwsA4w6+zRmqTcQqWSFmyneReexAFfmjGysr/wW3Sdqf2DUqXtO+8Dxp5IFp4pMpgt0NKTdGV30HHYy/+LoexGg4L7JVCS9tqA65mZkylsMZArJv/HgJPKC3rOoJlzFWYl334mtw25iWgwfqLV8Rb4DGo77gCyBKLui/WzElI8gKZIBnh5tIwAqd1h+gw2u0fwU9CmXWe3uKtKvHBLmqVklmnZTYQbgSjdRL+fB1wx0BmIuFsND8whvaTbPoK8/Z1MoFDVBAPZBzGyIE2lVfJmEp6PhgareJiH7qs24quLV38N3rknf3pQZbTTFE7tP+jw6/NXmAK7c5GTw== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40245e5b-95e8-4a08-1fae-08da3fadc284 X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 06:54:35.4331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IwjDLklhzf/TAmC/WvNpDfnFcbJNlhxIxFYTaevyiP415DNWaz48hPnw8kQ46o4yw4HdnzNKZChOzuW9BlU+GA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2371 Cc: Yihao Han X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" clk_unregister() already checks the clk ptr using !clk || WARN_ON_ONCE(IS_ERR(clk)) so there is no need to check it again before calling it. Signed-off-by: Yihao Han --- sound/soc/samsung/i2s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 70c827162be4..84e21f7fc179 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -1247,8 +1247,7 @@ static void i2s_unregister_clocks(struct samsung_i2s_priv *priv) int i; for (i = 0; i < priv->clk_data.clk_num; i++) { - if (!IS_ERR(priv->clk_table[i])) - clk_unregister(priv->clk_table[i]); + clk_unregister(priv->clk_table[i]); } }