From patchwork Sat May 21 17:31:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 576889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377ECC433F5 for ; Sat, 21 May 2022 17:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344261AbiEURcM (ORCPT ); Sat, 21 May 2022 13:32:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245194AbiEURcK (ORCPT ); Sat, 21 May 2022 13:32:10 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB305468E for ; Sat, 21 May 2022 10:32:09 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id sSxHnqW0wFl1esSxUnDBbh; Sat, 21 May 2022 17:32:09 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=62892219 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=_g3nijcsGpEXjt1jd1AA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH v2 1/4] rtw88: Make rtw8822b_hw_spec be static Date: Sat, 21 May 2022 12:31:41 -0500 Message-Id: <20220521173144.9917-2-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220521173144.9917-1-Larry.Finger@lwfinger.net> References: <20220521173144.9917-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfCGE8qQHh3fonggzUXUenLTpSOkYaoDkLIXt7UQMdN/uO29hF6XPIFQTaHfLN+9DJ8nO2C3DmzIup0Ng/ydVTcGV/aeMYDJ6FMdUPoBMt5fN4FmhtUne fcrhk5nRwSGuysmEFUWNPavNTqZIAsuQEZN6x2axW/wj37DMoVHLcp8I3LjAt/4D8dp0KQ7fa8b8hIh+bO4nMypeVajIr0y8gRfiS7iR5bgqpA5Ko3HMuAwy QqmWxb//PbkCEYutRWBg469nUTebF5iZJ4u/wPLMkpFubzwlon8v0OzvkRxSwRfDNM2wRndWvtKtkcm2VyWPhIWxdEE//5H4aEAE6C00NA8QMIGY3DqFAE7R EW7Vp9vnDqtLR2VxylnjDe4cPSe77viuIsqoNlyblpu4GdhERX8= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse lists the following for rtw88: CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- v2 - change subject as recommended by Kalle --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c index dccd722b8e62..60c4e75df035 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c @@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = { [EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0}, }; -struct rtw_chip_info rtw8822b_hw_spec = { +static struct rtw_chip_info rtw8822b_hw_spec = { .ops = &rtw8822b_ops, .id = RTW_CHIP_TYPE_8822B, .fw_name = "rtw88/rtw8822b_fw.bin", From patchwork Sat May 21 17:31:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 576888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1106C433F5 for ; Sat, 21 May 2022 17:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346686AbiEURcZ (ORCPT ); Sat, 21 May 2022 13:32:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236589AbiEURcV (ORCPT ); Sat, 21 May 2022 13:32:21 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E43A55218 for ; Sat, 21 May 2022 10:32:20 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id sSxHnqW0wFl1esSxfnDBdF; Sat, 21 May 2022 17:32:20 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=62892224 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=x68MAS-g3-2hpnaHOukA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH v2 3/4] rtw88: Make rtw8723d_hw_spec be static Date: Sat, 21 May 2022 12:31:43 -0500 Message-Id: <20220521173144.9917-4-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220521173144.9917-1-Larry.Finger@lwfinger.net> References: <20220521173144.9917-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfHNEAVP52c06TAw0EXK+P+LdCoyAI1eOpCOBblfIT/diRMQo85HZ5ApFjgtFrfuCjWRQkyHe4oM9EQURzs7rQuux7cKzQaG7DfGoeUsDDFKWEBD1Id2r xEStU9lSJXtj/he3LjNG1motAmJXALfx37BtorldoHFZAvahjv6BMVmPfTOeRdvgHTHW/cVN9QLDeKCt8n1UNkUFn1Jq7Ggy5a283Ig0kkrPX0WdmjUs7I1p Ado04srvJ62X3czMscxuNL5cJBh1d2iXQoH8GeSotCM3O/ssA42ibNHJcQwW5gMALT3hPiOBpJ4esArZnSdNJOjy1GUyQVDRT/2Fpwt8dFn18IJlUJR6cWSL hyFVgvn+8DrEV1mKXLC4t3xIwPiJcmV+VIisuEQNKHaDNqw/eLQ= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse lists the following: CHECK drivers/net/wireless/realtek/rtw88/rtw8723d.c drivers/net/wireless/realtek/rtw88/rtw8723d.c:2704:22: warning: symbol 'rtw8723d_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- v2 - change subject as recommended by Kalle --- drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c b/drivers/net/wireless/realtek/rtw88/rtw8723d.c index 93cce44df531..05e826e6ed0d 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c @@ -2701,7 +2701,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8723d[] = { {0x953, BIT(1), RTW_REG_DOMAIN_MAC8}, }; -struct rtw_chip_info rtw8723d_hw_spec = { +static struct rtw_chip_info rtw8723d_hw_spec = { .ops = &rtw8723d_ops, .id = RTW_CHIP_TYPE_8723D, .fw_name = "rtw88/rtw8723d_fw.bin",