From patchwork Sat May 21 17:31:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 575223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C03C433F5 for ; Sat, 21 May 2022 17:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344247AbiEURcR (ORCPT ); Sat, 21 May 2022 13:32:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236589AbiEURcQ (ORCPT ); Sat, 21 May 2022 13:32:16 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9AFA5468E for ; Sat, 21 May 2022 10:32:14 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id sSxHnqW0wFl1esSxZnDBcW; Sat, 21 May 2022 17:32:14 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=6289221e a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=MrPZ0le7YmToiFjRSvwA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH v2 2/4] rtw88: Make rtw8822c_hw_spec be static Date: Sat, 21 May 2022 12:31:42 -0500 Message-Id: <20220521173144.9917-3-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220521173144.9917-1-Larry.Finger@lwfinger.net> References: <20220521173144.9917-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfNIILzX9aaSShGBS3UBbmbtukIrFhJtTV1Sz8Dj9oGpguJR1FQbqcAEnduxC9TyXwB+N+Pu5vo9Ud/YZQkPn9vm+/I9iemteLxI95gytSbdeujVQ0cMd Xom5BR3KehhpGdSvS3FwrRFHFoPL1Gdk12ald5FiRw9qzIUogqREn6KyIbYqeP0c5bamPOA16GEuO7IzsQdx1VG9Epih+KGY+UPvsOVIghAa/IUGbDlHLEZM erpkhJM4W0FBq7HV9yLDC/+yCukbpq55slxi2Z0zd/zPlaZ9V/rg6QuOKuqtedR8PYgu7f2N4M3lKUvQslEt57jKFQbcSXg9265oLfwRxEsAVPwecZl+e1+p SmHJXTNhOVh+W5R/T1pgs4NHKjNqUTDfg5cGZ6cJVPp42j0GmWE= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse reports the following: CHECK drivers/net/wireless/realtek/rtw88/rtw8822c.c drivers/net/wireless/realtek/rtw88/rtw8822c.c:5313:22: warning: symbol 'rtw8822c_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- v2 - change subject as recommended by Kalle --- drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c index c043b5c520b9..5ae72d7f5c50 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c @@ -5310,7 +5310,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8822c[] = { {0xc50, MASKBYTE0, RTW_REG_DOMAIN_MAC8}, }; -struct rtw_chip_info rtw8822c_hw_spec = { +static struct rtw_chip_info rtw8822c_hw_spec = { .ops = &rtw8822c_ops, .id = RTW_CHIP_TYPE_8822C, .fw_name = "rtw88/rtw8822c_fw.bin", From patchwork Sat May 21 17:32:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 575222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A218C433F5 for ; Sat, 21 May 2022 17:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245194AbiEURcx (ORCPT ); Sat, 21 May 2022 13:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236589AbiEURcw (ORCPT ); Sat, 21 May 2022 13:32:52 -0400 Received: from p-impout001.msg.pkvw.co.charter.net (p-impout010aa.msg.pkvw.co.charter.net [47.43.26.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 789F152E45 for ; Sat, 21 May 2022 10:32:51 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id sSy9npnEsHQLKsSy9ntM6h; Sat, 21 May 2022 17:32:50 +0000 X-Authority-Analysis: v=2.4 cv=FcIkeby6 c=1 sm=1 tr=0 ts=62892242 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=DY4fc44Ji0MHZCRQ1l4A:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH v2 4/4] rtw88: Make rtw8821c_hw_spec be static Date: Sat, 21 May 2022 12:32:45 -0500 Message-Id: <20220521173245.11463-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-CMAE-Envelope: MS4xfIx3QmqnvxU6BTolkQ33n7Q+rvJgltbMF6/WxbeJWheURCWPl+gHOpVgIb/cFHDNO8WQ/zuG4k4yXC00/rMVepcUI7Q+Ik9PP9C3Hn6QBnp1QfNAGupQ b08y6g3y6mfh0hJiCc2gD7bG/+PXy4MN6wMLidV9rrYKwcEQed98dyJAonURgAZdETchGAjpB3fIZwqityzIvFZgOvnwUtk9p8PJhfhJX/yXr4TM2a/6DqBf Z4czoZdax8n1q1GncKJdz4vxRb/hdt5EyL5J9xvQe+r6berR0HPvloHNusjCYBLHVMs+MbmQTgt2KQaTD5tNmG5Sk+yU6QEuODSjn8kKQ6P/znzNACZLMIsS zjVmzHlLqboq49zn6iancTxEBZXOANw0bTu73oiN7icvr64MGWA= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse lists the following: CHECK drivers/net/wireless/realtek/rtw88/rtw8821c.c drivers/net/wireless/realtek/rtw88/rtw8821c.c:1880:22: warning: symbol 'rtw8821c_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- v2 - change subject as recommended by Kalle --- drivers/net/wireless/realtek/rtw88/rtw8821c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c index ffee39ea5df6..c0bfda189b99 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c @@ -1877,7 +1877,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8821c[] = { {0x60A, MASKBYTE0, RTW_REG_DOMAIN_MAC8}, }; -struct rtw_chip_info rtw8821c_hw_spec = { +static struct rtw_chip_info rtw8821c_hw_spec = { .ops = &rtw8821c_ops, .id = RTW_CHIP_TYPE_8821C, .fw_name = "rtw88/rtw8821c_fw.bin",