From patchwork Wed May 11 15:49:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kushagra Verma X-Patchwork-Id: 572032 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5716DC433EF for ; Wed, 11 May 2022 15:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343956AbiEKPtv (ORCPT ); Wed, 11 May 2022 11:49:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343928AbiEKPtr (ORCPT ); Wed, 11 May 2022 11:49:47 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01olkn2095.outbound.protection.outlook.com [40.92.107.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBD876B0B2; Wed, 11 May 2022 08:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lULVfr/EeMQ0Zw6aa3OBW7TXV7g8IGvdXWX04w5Kz4uu+k9b131KwuCIvMAtDFxlvcT8hn2rIQRFefkpboJ1FaFhdm9e0Co/fn89yH4AxsOdcgKgWYh53xUZSg7scCphL6jLTiUt8bKx27V+db9cm8yTcHnO9PoX6bFBfYgztnafn+Sm2ku15Bt1EymUmWRVEKt3O3+RxqUFMYHNWJ66pxiVhTP1bIXYDFGnuPHLOpWKwnt5gRb8xmFim2HWTZSla5tug58wclJsQopZws+h9pu2xrTrYSlpK5vL2VcyO+G69zYZPYPGliiqLnlp1iVCqXgL4pPUmTS3HBNX29GquQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9r+fRVuuYJ2bIwcJqK0CdJFiJpG1MxQ0xoMFwRCXuis=; b=aZoJsUrIpE19NpsSABNgmHjt2zwGQ0e+Vr6Z871yZocmV/ze+V901KZeXPRnXWxjM0RL4LuYBaonFg7lApgNWLbALZyt8+A7DIfxafGKTiLQ3HDbesqBEuskk+edD1YnX09Zx86iRe1rAn+qoc1Uc0n/BiD9STmGZh2tT9298O8XdEPFouzByYzEoYC1jiphIuCIriNkaxpAzWA2rkJZGsSzatAB8JnIHSL9AqfMZ0bPcjYL07pFHz85BAYRs9//PQz3mHqaujPM1M5/17ecJKQXqMaXexpXGHxqThgiBRzNi/KyX0jumgNFCMIDbpfrVvQWQT+x9w8Y1gFy9Mbh1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9r+fRVuuYJ2bIwcJqK0CdJFiJpG1MxQ0xoMFwRCXuis=; b=lL658ocmzsnNXrIXAtovBdkNg/Ln/NrHSywUV73F3mjl3KHOj+KEC4mj8vWvnjYPKSkfLVkPvJGBqDO8McKWSHsuIF8UPec1+S9F07Tb1EVnP2Rk/Y7vv8JqZYhk9FWbCGtxaQwtghxiM1wkkU/V4inc9aWnV8tBRVqC/1xhA3rf1wdNGAGtrWteKL1UYEiXbf52zPFxJOYXDGkAEzECHjo5FDCUILVc12uEcDzPVj0+A24Eeu1omdRq92ZCZnAbWOAktFBqi5EMxx8hyAHANP6KQ2s70fLQXM7jwRmetjTSTpwEYav/91A2yK/s9DX+KqN85yQBGTpMsJw9+U3z6A== Received: from TYZPR01MB3935.apcprd01.prod.exchangelabs.com (2603:1096:400:8::7) by TY2PR0101MB3358.apcprd01.prod.exchangelabs.com (2603:1096:404:f0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 15:49:44 +0000 Received: from TYZPR01MB3935.apcprd01.prod.exchangelabs.com ([fe80::451c:ecce:b777:d937]) by TYZPR01MB3935.apcprd01.prod.exchangelabs.com ([fe80::451c:ecce:b777:d937%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 15:49:44 +0000 Message-ID: Subject: [PATCH] USB / dwc3: Fix a checkpatch warning in core.c From: Kushagra Verma To: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 11 May 2022 21:19:36 +0530 User-Agent: Evolution 3.42.4 X-TMN: [bO1J4nWXV10J2F/almmfDbJNSQnsHed1pIFfBrWrkf+RgGczJSyv75V3hH/qku6uQE76r/Q3I8Q=] X-ClientProxiedBy: PN0PR01CA0006.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:4f::11) To TYZPR01MB3935.apcprd01.prod.exchangelabs.com (2603:1096:400:8::7) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 110f4998-3d1e-4993-a5dc-08da3365ddfd X-MS-TrafficTypeDiagnostic: TY2PR0101MB3358:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kfV7ttAWV56exuN52f/+pxowdSB/gpuVOLhDrG/DaA9QnehNH5y/RSfj9XsNSx/QcQPDY47EGYZ101WPDzkDNx+AMS4IUDo/ZHNbEIx7wJswSWhMye9+xL86sCtqe4w5XLOux8afKRzw3GWSY2kv8r1uAtoOq+3OAGvq7zPlSPolz6lSj3GV8zCct6sWulqVs0VoFhD1f+LEqVe6/FeVBDXDuNtm1zM/VgtABtJPs+Bl10hPCqEnbehFReG/JSir1G2Wbgl1dfoZF6Y/QwyLO+a4P0c713aGxN5w98iA2clHBVUdHBualtn8U72yklV9YYkgYoiBx/soibuINF69RFLbD97UKxQWhNBL71gtA8WR+klMrccprt8yAbXu3zOj3OFG0V1PMXPm0RRh8ceulKJw6+nXsOuJLyfgoFsbjdNZlGRnWPmXCYVj2trcWNkhkSC2YfVhVd5i73fm/NDgWs0GDRkS1Oih6uxDREf6CRefnvHCPzplpcACJqWS5LIto36tvXEYSGUK8d+nGOvDK3b/UgbHAfVo+4G56eRzJeiu8Q0SHV6bXyEQiFXgzbQ0xMhnydk3yimxzm/41rMVMB9mvA/Rx6bWaQhDtzSsoJLIQiGeU7boCtEUorqmwtvs X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?sMQch8OMF9v685pHE9YUbquASwuF?= =?utf-8?q?E017r1QC+6pESKwKHyaIo3Q38/MGCuyQjcSG8OyPNoD3u0q4AOI0F2CrIuKN2uAP8?= =?utf-8?q?TXEeZCZkC1obx+x4GaoWxhuueUVYnsBiRfzxUMC1FQZaz28908LSbplbGhR7rPTjo?= =?utf-8?q?UNqWCx8MGXQQRU1a/Z3YChQ7ibfC1HNaPsBwYw5MBbmO6fxG/7j/mINLsRAcvhvFV?= =?utf-8?q?IE0suljHMoJIKj4YVvuu226XZrJM5xR+foMH7MLoicWz1f3FucraChq5/SNcJFFkj?= =?utf-8?q?xeHLv7bqaG7qQaMQNrKSMXQfsvpUF5dPAtSwZE0BcFOTI3vyEdwzxeiOwxZV94kLK?= =?utf-8?q?+9P0sGsnxWv6d/mT3k9fqqZugf5Z9KQw4+z1vmKyByeg22W/cX4jda29S5Bz8IaIQ?= =?utf-8?q?mY84AxbSDhadVqHYcUN7uQRxNCinQhBqCedaDArr9lyERDbhNWJJRdfwiYTXUa3zJ?= =?utf-8?q?ccc3plNRQE2MRSchz71llvF91yytdJUhtBoBHcoPUOR12uZN2sNFISCDqItmDaGOt?= =?utf-8?q?Lrs+6ZNhMM2vYweqiYdvNSuiZNAjdPASaWBeo5dEOJtrFd0/Mg4yy09lfETtabMHz?= =?utf-8?q?3qkSmD+VKzQ6kQG1rOGzpzcacgXbYkX9tgliqGRRrzL60E3Tnu98RG9L3gKLT85io?= =?utf-8?q?3vvRv3Eys/wXufUHRYZpmkaR4Vw8XjpGZaS5lS/JH09Jz4kbL+jCQQFHeMwcVPVgt?= =?utf-8?q?O+PwflSgFXIfNxEKmbjH/OlbnvUzZfd/2fhAmYH7m2GzTcG29cyYhnmQwx+HH06GK?= =?utf-8?q?q6CGIqWI2KaWF9P9PjS/4ucInJKBkmVV+i1r7rbJ/UxQgW6ZNqgD4cCPH+/sWnM0G?= =?utf-8?q?qVqgJstdGpIM4ppJn0EnhPt6It3zPVIlxEd/RK/9C606AEzgci9SmN48uAzBem18d?= =?utf-8?q?Q6KQaO+O2iHVBmJlK44LqhFKPOKo++a7+sTXeyr88FkA19eGXp3ZR3Jg631AvOTGp?= =?utf-8?q?onALVjZkiyJjXa3+BsEtm+wVgwVWUAB0TGQlLbyQFhSzxaoCZI/d0JFL7VnQ53zSu?= =?utf-8?q?vzRgbmLRh1JuRmA6BcGbXj0lsjP8LbnsQWMZdSVoUQbuTawu2sZIzgAJCGuYP1rbM?= =?utf-8?q?arISfBXQ38cAxCLXKC+ZUqWb5jQYtd45BLV4L5VDLboDQlKWS97uIUSo8i05ok+jV?= =?utf-8?q?a6kROgvx1u66Y1IbPjUF1aXHsjTtdmL0IkrrOeoRnsV/gxbeHnB/KsrzKDP1hSYDv?= =?utf-8?q?CELpHL3grpMQ2/kNmoi2A4rFWxyDl/5jr9OvvIs5/K4Sx2LKehtGEBJuTWk1IVnl6?= =?utf-8?q?CB/iZQipOTbMtOBhh67kTSstHK86C4p/NcotLOFtSLrp399hNnP6hGHA0JGzlRHrD?= =?utf-8?q?Z31uoMxJsrrrpt/SHYxdNhZiXExtql9sY9CoGVSiGNOfcYY7c/MZ5s6fHkEQJgWtb?= =?utf-8?q?nqDbB7qUztccfE8AykCGfPHjzuU+51+hXKmgfpuLrjsNkKb47pA7h62HEuTepzZnC?= =?utf-8?q?FR9gRlTXeY3u6?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 110f4998-3d1e-4993-a5dc-08da3365ddfd X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB3935.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 15:49:43.8727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR0101MB3358 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch fixes the following checkpatch.pl warning in core.c: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Kushagra Verma --- drivers/usb/dwc3/core.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 7d023130e145..c78205c5e19f 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1266,40 +1266,36 @@ static int dwc3_core_get_phy(struct dwc3 *dwc) if (IS_ERR(dwc->usb2_phy)) { ret = PTR_ERR(dwc->usb2_phy); - if (ret == -ENXIO || ret == -ENODEV) { + if (ret == -ENXIO || ret == -ENODEV) dwc->usb2_phy = NULL; - } else { + else return dev_err_probe(dev, ret, "no usb2 phy configured\n"); - } } if (IS_ERR(dwc->usb3_phy)) { ret = PTR_ERR(dwc->usb3_phy); - if (ret == -ENXIO || ret == -ENODEV) { + if (ret == -ENXIO || ret == -ENODEV) dwc->usb3_phy = NULL; - } else { + else return dev_err_probe(dev, ret, "no usb3 phy configured\n"); - } } dwc->usb2_generic_phy = devm_phy_get(dev, "usb2-phy"); if (IS_ERR(dwc->usb2_generic_phy)) { ret = PTR_ERR(dwc->usb2_generic_phy); - if (ret == -ENOSYS || ret == -ENODEV) { + if (ret == -ENOSYS || ret == -ENODEV) dwc->usb2_generic_phy = NULL; - } else { + else return dev_err_probe(dev, ret, "no usb2 phy configured\n"); - } } dwc->usb3_generic_phy = devm_phy_get(dev, "usb3-phy"); if (IS_ERR(dwc->usb3_generic_phy)) { ret = PTR_ERR(dwc->usb3_generic_phy); - if (ret == -ENOSYS || ret == -ENODEV) { + if (ret == -ENOSYS || ret == -ENODEV) dwc->usb3_generic_phy = NULL; - } else { + else return dev_err_probe(dev, ret, "no usb3 phy configured\n"); - } } return 0;