From patchwork Thu Jan 3 11:59:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154713 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp576078ljp; Thu, 3 Jan 2019 04:00:18 -0800 (PST) X-Google-Smtp-Source: AFSGD/XCFpDsaOfeG87FhioBrkY4Qzed1aXxxnh4rEP3JjYGii9uprLVXSDw4hcmMxBzDbf3rri8 X-Received: by 2002:a62:fc52:: with SMTP id e79mr48494946pfh.8.1546516817724; Thu, 03 Jan 2019 04:00:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546516817; cv=none; d=google.com; s=arc-20160816; b=C8GOnZwKy2zhXQ3T7MZr+c6L3A70karIzpfESbbswmStj63sMgW1bxalpJjVY3NGwd 9TcNFWn/lU9sD7hgXi3oRJkxW+YajBqCvNb/GIYsoIbnNvyqA3lPjnVV9PeoTH0k9b+X NY4nWin/+KUfFQAAxxkd64PMs2zp3KeYob7f6hCMWgEopA5aCcG/HgAOEuzDVB5ZDZDD DRDK6NCR82alJwGUMDXvg/JcF5m+flS3CrPt9XpHl6Sf3f4n38xPjwbPdzlj4uY2KTTC XoUbVXNMmM9fjkNsGDh16br4/7JZZMKsCLEKxexaazJBMnRGJfw+TbqwKoCDdP/MXzZ/ neOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=FsZZSj2nIaex/YwjMRAgUT/VlZBriqjRvIbrQkSAWYs=; b=np7QVYzPCWVekmHn0drWM403luEDI9r8NkljaPOaRtT9MaZ3MXUGJ7yVtpC3B9oKwY rhN8RpAQhjds4JgjTu6p0D3jCMIHdNcSL3q7d2HQ3hS/Ezg6rumpQ1ERt5+Lq5fGgtEY +vHCtCLpcWpPPW8TmyGup/yzI3m8wcm4IWW14QmDAeSRJwNnCAGYhR00EZQ2JrAZaIRj 8Diebl6uQsYyftcErnLWgcDGaD87zhDO129N3bEjm3sqpczaOfb7MmXEmHuzuQPtuOPK gQSJUL+Yv4kaIkhMFpaE7DyRTuZiBZJZtAR3kXHYK3VwoRzZqhy2qRwARASAK4/971Un htxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id o16si40553438pgd.117.2019.01.03.04.00.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 04:00:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EF986EACE; Thu, 3 Jan 2019 12:00:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0EA16EACE for ; Thu, 3 Jan 2019 12:00:14 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C06Uj081900; Thu, 3 Jan 2019 06:00:06 -0600 Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C05xY029145 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:05 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:03 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:03 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgg001514; Thu, 3 Jan 2019 06:00:01 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 1/7] drm/bridge: tc358767: add bus flags Date: Thu, 3 Jan 2019 13:59:48 +0200 Message-ID: <20190103115954.12785-2-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" tc358767 driver does not set DRM bus_flags, even if it does configures the polarity settings into its registers. This means that the DPI source can't configure the polarities correctly. Add sync flags accordingly. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 8e28e738cb52..29a7e33e8ae0 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1195,6 +1195,10 @@ static int tc_bridge_attach(struct drm_bridge *bridge) drm_display_info_set_bus_formats(&tc->connector.display_info, &bus_format, 1); + tc->connector.display_info.bus_flags = + DRM_BUS_FLAG_DE_HIGH | + DRM_BUS_FLAG_PIXDATA_NEGEDGE | + DRM_BUS_FLAG_SYNC_NEGEDGE; drm_connector_attach_encoder(&tc->connector, tc->bridge.encoder); return 0; From patchwork Thu Jan 3 11:59:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154717 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp583881ljp; Thu, 3 Jan 2019 04:07:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN5dfjVnwno5TJU//VAG2i9HBmOhSmshva8C4AGtjCwPVhK3QXmUdYy6Biz0+YasMAyBSSma X-Received: by 2002:a63:9501:: with SMTP id p1mr16921559pgd.149.1546517249525; Thu, 03 Jan 2019 04:07:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546517249; cv=none; d=google.com; s=arc-20160816; b=ItLwDDqLkvXtk3+h/psnq9N54bvGOx9SJvtQja5REZfz6icuWhjLWmENLI3I5rBuJD Vqdl8E7okZq5WCrrTC9Y+ILoQrOAJRSGa8HsR7L2+PgNz13tDJyKV7EDawmk4RDT5yYa xjuHtYWCRdCslvQ/inRniTsDD7d5IOxae6HRGFbx0cj8RxnynK1+I98Hf1wHNkXtEhmU DcLUNm3WU/rlyoL3vw2HSH0fm9XuicBQw3g3EscOb2dpTiOQM0hkRGDVmKNYQZR8lruH a3dD0RA/dNu8+9kXsFcQU9RA7LH0oR9ihEqrzPiciYaqTJyLeqYKNEq3iF8UUwwj/uWD QowQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=0EU0JIhmLRefRecNFkN2xgdiMQjfGp4PWKwl3C5FS7A=; b=loWol2s8MNw+jt5rNP5JQstWv1WU994omLxjFNGSnJJ6DiW/aD4nQio8B6rkPqLx5s 9TIwYpG3YfYbBNy31AIi7QE3xHHYbXYaHr+ugIGQ57yLhq1LXYd0/Y4sdE2s338N7zzh TdsqeIJBBmPjHKFDpJiUk85/IADXgfydbdrqC+QC9U1wOVYk6R4oXoKa3T95kvjoQuu9 h7gyoRkzQeSlp/9gzmmGEoc8F6pzivsYN80QT0DFM/cUrkiJ9K5ZcAWWVpIN4+LBsRyU YQMNiO3nWrEGLpsNyFPD52wESq1UAfDUFes+ruZ76GOdQ/NsGrA0sNrgsiX1LFxkKudt NBEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id d39si11449387pla.278.2019.01.03.04.07.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 04:07:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 681746EAD0; Thu, 3 Jan 2019 12:07:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A2206EACF for ; Thu, 3 Jan 2019 12:07:24 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C06ZO056052; Thu, 3 Jan 2019 06:00:06 -0600 Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C050n029144 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:05 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:05 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:05 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgh001514; Thu, 3 Jan 2019 06:00:03 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 2/7] drm/bridge: tc358767: add defines for DP1_SRCCTRL & PHY_2LANE Date: Thu, 3 Jan 2019 13:59:49 +0200 Message-ID: <20190103115954.12785-3-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" DP1_SRCCTRL register and PHY_2LANE field did not have matching defines. Add these. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 29a7e33e8ae0..5f0a666db2fd 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -142,6 +142,8 @@ #define DP0_LTLOOPCTRL 0x06d8 #define DP0_SNKLTCTRL 0x06e4 +#define DP1_SRCCTRL 0x07a0 + /* PHY */ #define DP_PHY_CTRL 0x0800 #define DP_PHY_RST BIT(28) /* DP PHY Global Soft Reset */ @@ -150,6 +152,7 @@ #define PHY_M1_RST BIT(12) /* Reset PHY1 Main Channel */ #define PHY_RDY BIT(16) /* PHY Main Channels Ready */ #define PHY_M0_RST BIT(8) /* Reset PHY0 Main Channel */ +#define PHY_2LANE BIT(2) /* PHY Enable 2 lanes */ #define PHY_A0_EN BIT(1) /* PHY Aux Channel0 Enable */ #define PHY_M0_EN BIT(0) /* PHY Main Channel0 Enable */ @@ -564,7 +567,7 @@ static int tc_aux_link_setup(struct tc_data *tc) value |= SYSCLK_SEL_LSCLK | LSCLK_DIV_2; tc_write(SYS_PLLPARAM, value); - tc_write(DP_PHY_CTRL, BGREN | PWR_SW_EN | BIT(2) | PHY_A0_EN); + tc_write(DP_PHY_CTRL, BGREN | PWR_SW_EN | PHY_2LANE | PHY_A0_EN); /* * Initially PLLs are in bypass. Force PLL parameter update, @@ -834,7 +837,7 @@ static int tc_main_link_setup(struct tc_data *tc) DP0_SRCCTRL_LANESKEW | DP0_SRCCTRL_LANES_2 | DP0_SRCCTRL_BW27 | DP0_SRCCTRL_AUTOCORRECT); /* from excel file - DP1_SrcCtrl */ - tc_write(0x07a0, 0x00003083); + tc_write(DP1_SRCCTRL, 0x00003083); rate = clk_get_rate(tc->refclk); switch (rate) { @@ -855,8 +858,9 @@ static int tc_main_link_setup(struct tc_data *tc) } value |= SYSCLK_SEL_LSCLK | LSCLK_DIV_2; tc_write(SYS_PLLPARAM, value); + /* Setup Main Link */ - dp_phy_ctrl = BGREN | PWR_SW_EN | BIT(2) | PHY_A0_EN | PHY_M0_EN; + dp_phy_ctrl = BGREN | PWR_SW_EN | PHY_2LANE | PHY_A0_EN | PHY_M0_EN; tc_write(DP_PHY_CTRL, dp_phy_ctrl); msleep(100); From patchwork Thu Jan 3 11:59:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154714 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp576088ljp; Thu, 3 Jan 2019 04:00:18 -0800 (PST) X-Google-Smtp-Source: ALg8bN7g8RaXoLirLYdAb/wk0+s6JhOk6WRAl3Ho4yW+3ULDpjfyiFizQ195ZGjTrrLoWYCQryFH X-Received: by 2002:a17:902:b090:: with SMTP id p16mr46816721plr.190.1546516818483; Thu, 03 Jan 2019 04:00:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546516818; cv=none; d=google.com; s=arc-20160816; b=uu5gSKt2QZypg4h8LN4ai7/IJUTvqywWPPahtSE0w5qu+JBzNcYn40sW9w3XKIh6vA RX3vkLxnU6AjMfWyMN2d5cKSFlSs4zN3h5VoEn92w3LfTYukPze3F1iO4gXg2BjZ5JhM bKZE13n70Vq818CE460mcgUI79bXgpkEZ0e1UFjfBVij815oqmCQJRUY6WR20onmOxRU K9YvbXVLxD4kziIADeSFplhAjm0jEE01pp4OJ/M/868CIuf83RA5UYR4dsXJ3Th5Ara9 5W4K2KrqRFxbxv3ya3kuCjTiTVkEL/Tngbb/dEywwW2hVOHxBc0zolhrXX/Gp0FFJ8TF j/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=9K2EGsRKRdfURYKpLfa906wCsGknAlRLVUoE3mZYzXM=; b=lpLiCUzHt/9rcVUub4lJjFN36hCVJdcyFtX13eoF+mP5ravAWlatoP7UqRMtimVnbc 2ObdRiGgOHahvG+eT0M4/vlRHnX5SPS3D5IgxKN8ZNe7GaTapZFi/D4in//tah/s74eY ePehYMcKZCddIlNA70uj7YJA3oMdOC+M2p7QHuY68UCrvhp8TM7IXtlvOkkRwehoqx1B y9Of4YA6lVcfd85HGZaIPkGoOQftS2J2i+T4Q+XAmbzGAK3b+XcVMmUNC65fy04j6e4i 1pwas9eNdRothZdd7nLCwn80rVatalWywiyNpre6ZWr9bA83SVUQhfd2Lv69lIxc73JQ licQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id z29si54304597pfi.9.2019.01.03.04.00.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 04:00:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 301446EAD1; Thu, 3 Jan 2019 12:00:16 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 066AC6EACE for ; Thu, 3 Jan 2019 12:00:14 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C07VA081909; Thu, 3 Jan 2019 06:00:07 -0600 Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C07Ar015487 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:07 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:06 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:06 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgi001514; Thu, 3 Jan 2019 06:00:05 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 3/7] drm/bridge: tc358767: fix single lane configuration Date: Thu, 3 Jan 2019 13:59:50 +0200 Message-ID: <20190103115954.12785-4-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" PHY_2LANE bit is always set in DP_PHY_CTRL, breaking 1 lane use. Set PHY_2LANE only when 2 lanes are used. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 5f0a666db2fd..fee53422c31f 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -543,6 +543,7 @@ static int tc_aux_link_setup(struct tc_data *tc) unsigned long rate; u32 value; int ret; + u32 dp_phy_ctrl; rate = clk_get_rate(tc->refclk); switch (rate) { @@ -567,7 +568,10 @@ static int tc_aux_link_setup(struct tc_data *tc) value |= SYSCLK_SEL_LSCLK | LSCLK_DIV_2; tc_write(SYS_PLLPARAM, value); - tc_write(DP_PHY_CTRL, BGREN | PWR_SW_EN | PHY_2LANE | PHY_A0_EN); + dp_phy_ctrl = BGREN | PWR_SW_EN | PHY_A0_EN; + if (tc->link.base.num_lanes == 2) + dp_phy_ctrl |= PHY_2LANE; + tc_write(DP_PHY_CTRL, dp_phy_ctrl); /* * Initially PLLs are in bypass. Force PLL parameter update, @@ -860,7 +864,9 @@ static int tc_main_link_setup(struct tc_data *tc) tc_write(SYS_PLLPARAM, value); /* Setup Main Link */ - dp_phy_ctrl = BGREN | PWR_SW_EN | PHY_2LANE | PHY_A0_EN | PHY_M0_EN; + dp_phy_ctrl = BGREN | PWR_SW_EN | PHY_A0_EN | PHY_M0_EN; + if (tc->link.base.num_lanes == 2) + dp_phy_ctrl |= PHY_2LANE; tc_write(DP_PHY_CTRL, dp_phy_ctrl); msleep(100); From patchwork Thu Jan 3 11:59:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154716 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp583850ljp; Thu, 3 Jan 2019 04:07:27 -0800 (PST) X-Google-Smtp-Source: ALg8bN5ocYTmSfbwgutKeY3Til96Bjcg1a13IA8dWpsCLCNMrN44qYCXg+BUloaTMG2woyjCHdRb X-Received: by 2002:a17:902:12f:: with SMTP id 44mr47250124plb.74.1546517247558; Thu, 03 Jan 2019 04:07:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546517247; cv=none; d=google.com; s=arc-20160816; b=XE3PtLgDW+me3Dp/xr/qTGl+KwpjFY5wLfd1eSzdfBDig5KNU7x9WFrxm9qKAKyQKv F4Njl8XPZ1dKKiWcczeC5sI7hq0HFukEKnOBtHEtNBNev1HSTDsMD1KOCdo/gBqTEfP0 2W65GWT+2xNBUSF/9qsrCyFdrTCm1oKF2w7IYXQiruL/HlmfIObqQHANUy5+1ppJnIk2 QNbIhGP2hMJzu+fgMUFT4eA9RYHotUOzRgEdX2zGp9EXjls30O5O2FoIzb/7yyWHX4Fb vbmwFEGaxhKCHE1x0xZ9p7zlvjzfWfX/39SfmPjdTgh+2qO8hU+x9o54+an6duZRgbmm cZzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=0hO1HkDPmWC1d83oM8PJqxBzQzfSx8kLtF6pNxy9ESw=; b=rIp8qYorr0HtUJ3ztrY0HQILYzyUKwJH94Ghpq9e9421+4tWOgJeOdQ23Cht/j8F8t 1ujCJnz9cs1pxWjNSIFMwnfH9qdU/SZ/T5EvWsf8QpgiV+6SlBZIymlBJtJwETk+RzAu VKdgXfwLZOZK0AaS/CDsc9nn7K1TaY13VqGoe51soAWhXJFfWU/HPR3YRb6fIhEzRKeA NvteoGRwcTMCmrelZBGPb14Ew5BHO3sMRXGMwxvLVoc2yMGo1uGbGbQqrUBz27urdrRA 67ZbANJ/o6Kjtx9CfnRdJrX7XnzK01YYuWyU6ekUMf6N0gYjKCNdJJxX4mNPHED6iO9z BiPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q17si56045631pfc.198.2019.01.03.04.07.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 04:07:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1657B6EACF; Thu, 3 Jan 2019 12:07:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 434 seconds by postgrey-1.36 at gabe; Thu, 03 Jan 2019 12:07:24 UTC Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A6486EACF for ; Thu, 3 Jan 2019 12:07:24 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C09ZK056070; Thu, 3 Jan 2019 06:00:09 -0600 Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C09et002537 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:09 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:08 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:08 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgj001514; Thu, 3 Jan 2019 06:00:07 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 4/7] drm/bridge: tc358767: fix initial DP0/1_SRCCTRL value Date: Thu, 3 Jan 2019 13:59:51 +0200 Message-ID: <20190103115954.12785-5-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Initially DP0_SRCCTRL is set to a static value which includes DP0_SRCCTRL_LANES_2 and DP0_SRCCTRL_BW27, even when only 1 lane of 1.62Gbps speed is used. DP1_SRCCTRL is configured to a magic number. This patch changes the configuration as follows: Configure DP0_SRCCTRL by using tc_srcctrl() which provides the correct value. DP1_SRCCTRL needs two bits to be set to the same value as DP0_SRCCTRL: SSCG and BW27. All other bits can be zero. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index fee53422c31f..ab299f4debfa 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -836,12 +836,11 @@ static int tc_main_link_setup(struct tc_data *tc) if (!tc->mode) return -EINVAL; - /* from excel file - DP0_SrcCtrl */ - tc_write(DP0_SRCCTRL, DP0_SRCCTRL_SCRMBLDIS | DP0_SRCCTRL_EN810B | - DP0_SRCCTRL_LANESKEW | DP0_SRCCTRL_LANES_2 | - DP0_SRCCTRL_BW27 | DP0_SRCCTRL_AUTOCORRECT); - /* from excel file - DP1_SrcCtrl */ - tc_write(DP1_SRCCTRL, 0x00003083); + tc_write(DP0_SRCCTRL, tc_srcctrl(tc)); + /* SSCG and BW27 on DP1 must be set to the same as on DP0 */ + tc_write(DP1_SRCCTRL, + (tc->link.spread ? DP0_SRCCTRL_SSCG : 0) | + ((tc->link.base.rate != 162000) ? DP0_SRCCTRL_BW27 : 0)); rate = clk_get_rate(tc->refclk); switch (rate) { From patchwork Thu Jan 3 11:59:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154723 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp639839ljp; Thu, 3 Jan 2019 05:09:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN5wZpoIKwDi6cRBTGAZx/uc5t0wTWd01572vfh3FWE97nkBEf6k3vkPKeF92H3uOjaQu6DE X-Received: by 2002:a63:c051:: with SMTP id z17mr16546971pgi.20.1546520965270; Thu, 03 Jan 2019 05:09:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546520965; cv=none; d=google.com; s=arc-20160816; b=Wt/WK2LlNbexoGTUTXPYtiY0EYu4pYa3Njc1lfZ0+iVxf10nlGIYZ8VBVoCnn6mK+k Kd1SKEI/i5RZDzpy3wkJ4mZ93tldVDuTRaTT6DOnDaUTDwBsbeQgpf6zk+xtQxp3evpv t/FNheTY+7N19YkeF3XW9WJD2/VnSlVvmM7ZFyZELLZDYMVO8JgzKcC3RvNTDeKgH125 qgqpihKcbY6Te21FNoyc3nYXl03VWtjsRaGUJ6uhQUs5OARk5k/56E2tDyaMvk8kgCKv 45qu7Ni8nm3F9JlE9AXe2e+trAyWVgb+unXh97feZ/db3sT1IYqHdgDfs1y9AVpSZRlq Accw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=zkLDn16DYy9qb4W7moyRcKPN7XIT41EFCJddXnmPnTk=; b=Dw1y9WZFZS2ABRDg8kzLRtyAJfvkP2GFbfMyD8LDl+BH5z4H3u7Ax6wPaHVQF+0u+o Q5hO23O4mbdb7e958F8zfG3J2hFkd5icBYaXDRb8ZhjCuEjUJo3M0oRQFVMx238E76oy qsVo9CyxkPD5CCGzLlzCQ5IlALIXWOWplN0B6C5IBCSNcXzdfyiwJEFaChUPu9MUvqzh 4AaiX2h6ALkKAV9TEfAcYnC4ABkFmDnKvyyxLkJlsTd1DR0P/P5XcUVH5AhRnmABLPm4 r+2IPT9n4Qrp4fqGyaQxPv5IROiEP0WlHj6Wnph6VBD/srihmc0xipHbtubO/is4QPyu 6Z/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id g18si52826149pgg.522.2019.01.03.05.09.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 05:09:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D84DF6E544; Thu, 3 Jan 2019 13:09:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by gabe.freedesktop.org (Postfix) with ESMTPS id E49776E544 for ; Thu, 3 Jan 2019 13:09:22 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C0CvL021837; Thu, 3 Jan 2019 06:00:12 -0600 Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C0Cf7029592 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:12 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:10 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:10 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgk001514; Thu, 3 Jan 2019 06:00:09 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 5/7] drm/bridge: tc358767: reject modes which require too much BW Date: Thu, 3 Jan 2019 13:59:52 +0200 Message-ID: <20190103115954.12785-6-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The current driver accepts any videomode with pclk < 154MHz. This is not correct, as with 1 lane and/or 1.62Mbps speed not all videomodes can be supported. Add code to reject modes that require more bandwidth that is available. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index ab299f4debfa..a1f3dd2afbb1 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1114,10 +1114,20 @@ static bool tc_bridge_mode_fixup(struct drm_bridge *bridge, static enum drm_mode_status tc_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { + struct tc_data *tc = connector_to_tc(connector); + u32 req, avail; + u32 bits_per_pixel = 24; + /* DPI interface clock limitation: upto 154 MHz */ if (mode->clock > 154000) return MODE_CLOCK_HIGH; + req = mode->clock * bits_per_pixel / 8; + avail = tc->link.base.num_lanes * tc->link.base.rate; + + if (req > avail) + return MODE_BAD; + return MODE_OK; } From patchwork Thu Jan 3 11:59:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154715 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp576130ljp; Thu, 3 Jan 2019 04:00:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/WXQzElEfWq7mzBLRKlKVUuuHdAvQfyXxn+8vhoJJbfmohvF0CpYfgJyGImG2tsakmavSD4 X-Received: by 2002:a62:e0d8:: with SMTP id d85mr47214878pfm.214.1546516820256; Thu, 03 Jan 2019 04:00:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546516820; cv=none; d=google.com; s=arc-20160816; b=DiC0gvyGcxhyZdhwdFNLNZeg2XmgsiIq9b+weLFzLfvghQjNLCOX4Gqpuyb+EyE+ZD 57Fgu0YHWPekw6Q/rKeEmWtYRyfSWYpr9SBxutsS0ZIOCSwjYNw4HQUI+ESX2hXNMnhu yUZ4Lg+dGWlF9ZCydKSnR/T4ePVqHgXRCgMRO7jCB7IQ3ig/AEZvpCpMxSDhWk4U/680 ARZNmJIriFjH/n2GY2LSwr3xQq9lg6YFUHuoIDGH4nhkPsJTMs8b7A69+2KXbIsTt+yt 0Y4FtKWe7WQpHIU3wPOZzGaI/4kDTUOULSHHxaxRfSvUim3yjVis3k1FMxOVJDD1PUzL GtMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=jb5MauPGd3lLvayTAp2yCNnrWNON3aAbFDh89BdJUFY=; b=HnYlvRQE32HW0CleP8kmblBx+7GjASoDU+UjrWsri4f5HbCPpYlH8JftSJp8JjkCYn zO2gLrTgqaG5M0yX0sSouEwlP97qxv5/XjNeYiVRxs8UFbZCgmdYRkMY85ww+JFoFiWr rximxW2sfmAXVQ59U9uddZcBahaMwuxR+UEm1IlRUwit96pqF590HcY70IF9d8HD9RmM 5vP8K4CPOGnft4Kk7YaIBOL1AZWdXIU5pHkzs8A0EnpeC+SPOwbANB0gx5lT2F+Eil+6 +pfLyeArLlpePFJniVPbXZd5Pkex6jxEpFI01uoPs/6TBu+7oUdnv4GmTgvwbLt7U84q /fxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id f13si33940631pln.368.2019.01.03.04.00.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 04:00:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBD166EAD2; Thu, 3 Jan 2019 12:00:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id C46F36EAD2 for ; Thu, 3 Jan 2019 12:00:17 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C0DiD081973; Thu, 3 Jan 2019 06:00:13 -0600 Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C0DoH029623 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:13 -0600 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:12 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:12 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgl001514; Thu, 3 Jan 2019 06:00:11 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 6/7] drm/bridge: tc358767: fix output H/V syncs Date: Thu, 3 Jan 2019 13:59:53 +0200 Message-ID: <20190103115954.12785-7-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The H and V syncs of the DP output are always set to active high. This patch fixes the syncs by configuring them according to the videomode. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index a1f3dd2afbb1..391547358756 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -98,6 +98,8 @@ #define DP0_STARTVAL 0x064c #define DP0_ACTIVEVAL 0x0650 #define DP0_SYNCVAL 0x0654 +#define SYNCVAL_HS_POL_ACTIVE_LOW (1 << 15) +#define SYNCVAL_VS_POL_ACTIVE_LOW (1 << 31) #define DP0_MISC 0x0658 #define TU_SIZE_RECOMMENDED (63) /* LSCLK cycles per TU */ #define BPC_6 (0 << 5) @@ -726,7 +728,9 @@ static int tc_set_video_mode(struct tc_data *tc, struct drm_display_mode *mode) tc_write(DP0_ACTIVEVAL, (mode->vdisplay << 16) | (mode->hdisplay)); - tc_write(DP0_SYNCVAL, (vsync_len << 16) | (hsync_len << 0)); + tc_write(DP0_SYNCVAL, (vsync_len << 16) | (hsync_len << 0) | + ((mode->flags & DRM_MODE_FLAG_NHSYNC) ? SYNCVAL_HS_POL_ACTIVE_LOW : 0) | + ((mode->flags & DRM_MODE_FLAG_NVSYNC) ? SYNCVAL_VS_POL_ACTIVE_LOW : 0)); tc_write(DPIPXLFMT, VS_POL_ACTIVE_LOW | HS_POL_ACTIVE_LOW | DE_POL_ACTIVE_HIGH | SUB_CFG_TYPE_CONFIG1 | DPI_BPP_RGB888); From patchwork Thu Jan 3 11:59:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 154724 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp639861ljp; Thu, 3 Jan 2019 05:09:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xqy6MlpdTgO00uMCO+nDPy+fG8ltPU2DiJkAqv5f5cutAR+qFKESywyqyI9BHr7epM9MBD X-Received: by 2002:a62:6e07:: with SMTP id j7mr49431796pfc.135.1546520967487; Thu, 03 Jan 2019 05:09:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546520967; cv=none; d=google.com; s=arc-20160816; b=xKs7J9Nf38xnikGyKLb7CvELwwx+16h0QZT02Du557hORZyTcur1Ym+O9ynZrv0E0T C3sTqvmeNBAV8+JXhZBE02XfhkCAywfQQL6PBQLVsLgTGGTijIXakNMwYJiyMg6rOVFv LMD4oPtqmaRP7idyHkoMYEy5Y4t9xnj7LT3GVaRfSBTuIuMWOSXxuKjwMFQGknv9xjVc e3pvfhD9mdAEO4tD/IlAdOsnHiolHR3EXK9foeCV2fce2DGPf7tZgZuf7u+krB0BBfDP FCo6mJNHwzR0xJwEtbsCXXyU0onC40Nyt9fHNHJsbQgUUSVBPWhkSxpTIpaEmOpSRZSB erIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=d+Xl6Ai6HaSwO1UBPz/crNA3OSoPmU3RlQQ1jOKQIKE=; b=iKFtgU56gaAetEZj83xRRx9yrAtv+mX2d3zjldmAIw0jeVVgIDq8JyOT/lC4WeYvB9 f7IwkMbFuBSl7QGkr5BOfu9DE9ikaJwtFsJ7eQ9q7THzQtDNMGAspxzic6E/7e/udEmb 0bdSckNorWg6YFM6wGT6tJT8n2BxfWHFwaQv7Btglp8j+4QSGmL98HpwW3OYjZcZsNKD t09FrK7SaW7jwyt1LWLB6c1YXlTRLxJ6E+NXO3YjgC2wDOQuv/Uh2Z/qMyx8HdTmuFnj P+6JsOM4vZSNSt7k2jvaCJyuNjPfKFczaYNcZCT8MwRmB+GApSdJfUx3W3aQeH1PEAQZ MYoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w67si9758203pgw.84.2019.01.03.05.09.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 05:09:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98B5A6E550; Thu, 3 Jan 2019 13:09:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB6F56E544 for ; Thu, 3 Jan 2019 13:09:22 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x03C0GbM021853; Thu, 3 Jan 2019 06:00:16 -0600 Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x03C0Gca002738 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 06:00:16 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 3 Jan 2019 06:00:14 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 3 Jan 2019 06:00:14 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x03Bxxgm001514; Thu, 3 Jan 2019 06:00:12 -0600 From: Tomi Valkeinen To: Archit Taneja , Andrzej Hajda , , Andrey Gusakov Subject: [PATCHv2 7/7] drm/bridge: tc358767: use DP connector if no panel set Date: Thu, 3 Jan 2019 13:59:54 +0200 Message-ID: <20190103115954.12785-8-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190103115954.12785-1-tomi.valkeinen@ti.com> References: <20190103115954.12785-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" tc358767 driver sets the connector type always to eDP. This patch sets the type to DP if there is no panel defined, which implies that there's a DP connector on the board. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 391547358756..e6403b9549f1 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1209,7 +1209,8 @@ static int tc_bridge_attach(struct drm_bridge *bridge) /* Create eDP connector */ drm_connector_helper_add(&tc->connector, &tc_connector_helper_funcs); ret = drm_connector_init(drm, &tc->connector, &tc_connector_funcs, - DRM_MODE_CONNECTOR_eDP); + tc->panel ? DRM_MODE_CONNECTOR_eDP : + DRM_MODE_CONNECTOR_DisplayPort); if (ret) return ret;