From patchwork Sun May 8 13:59:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 570807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD369C433FE for ; Sun, 8 May 2022 13:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233706AbiEHODe (ORCPT ); Sun, 8 May 2022 10:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233690AbiEHODc (ORCPT ); Sun, 8 May 2022 10:03:32 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72B1DFB8 for ; Sun, 8 May 2022 06:59:41 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id p18so13507587edr.7 for ; Sun, 08 May 2022 06:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cGkttDqvYsUUsrUXY9BC2Fg/b2UvTJ5Tzg5qvRI7Pfg=; b=R9RyiZXiRXv6vcGsngJu755jCUvGkw6ljd7grwWqoZNb/ssw/4hYNB5vB9lRa55bZ+ taUSkVPQIZbHizX2MevwOf9pxOeWARKNOcvLsL3wASS5hSf8+GEUa+n6Bl6AKf3y3wcc rEEKdlRNJca0M3bR3PHM1Zp0TcWxL2JpDLZMwCbxIfDrhw9eAAYfFjEUy1zzxTXJOZrX 3zaQ/dQ9jVXAeXhJl+SL9anhqZ0++VX63p5al1ryHuAblo5bRr160degilyoxjjxmGQJ 3XI3s5/6YDoHJiN57u8g+89+TYMme/PCTMy17UpzOjSNKTVbrUWMqc4doydRxVY3pGns qjeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cGkttDqvYsUUsrUXY9BC2Fg/b2UvTJ5Tzg5qvRI7Pfg=; b=VdM30uQO/D49MHAvOGGp0ytGNXJMGQNB/qikMI11fnCzQteb4ha4a3JpOJEiMYLELL yg6w5eqJZlI32EK5zZ0PV0oUVvEVVrtE1erWPKsolkJeMeyzMELE1rtPDi/CfB1MhJW/ 2k7UtV7VMdBiJ/J543yPIJiBxgGttuZXNqXyeOdctDPpwi9NqTTP9BqcejvNBbbKTpvv wb/DGAjCRcfpPP/3Dxy+YoSFfjbK+UWi/JXQONeZGKAYkjLm/Os9z3cDwdDAV4Iieizh BSJxh0OcK59qxx60szjVnAFXM0yAOsYuCclsHf0M0MWMHj5vNR01XQv2YW1VNeg+rA7J nXlQ== X-Gm-Message-State: AOAM533duI9AtGW2C9F8Ymgo4bdrz6Ff5m3VAydhVLXIQuOhUJWG++Kn /O2XSV/h3o2vDtSAFz3u0MbyEg== X-Google-Smtp-Source: ABdhPJyyEyxl9FMGJJ4ozYTfSy5BfZGk1porbFMbi0rxnxZtLnTydeSDWYl5p3+oGop5WsR4vS68JA== X-Received: by 2002:a50:ce19:0:b0:425:d85c:90e3 with SMTP id y25-20020a50ce19000000b00425d85c90e3mr12866432edi.350.1652018380092; Sun, 08 May 2022 06:59:40 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id qz24-20020a170907681800b006f3ef214dc6sm4075524ejc.44.2022.05.08.06.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 06:59:39 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Luca Weiss , David Heidelberg , Konrad Dybcio , Krzysztof Kozlowski Subject: [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges' Date: Sun, 8 May 2022 15:59:29 +0200 Message-Id: <20220508135932.132378-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220508135932.132378-1-krzysztof.kozlowski@linaro.org> References: <20220508135932.132378-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 'gpio-reserved-ranges' property is already used and supported by common pinctrl bindings, so add it also here to fix warnings like: qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- .../bindings/pinctrl/qcom,pmic-gpio.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml index 7e74a87ccc39..69195660ee2a 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml @@ -78,6 +78,12 @@ properties: minItems: 2 maxItems: 44 + gpio-reserved-ranges: + minItems: 1 + # maxItems as half of total number of GPIOs, as there has to be at + # least one usable GPIO between each reserved range. + maxItems: 22 + '#gpio-cells': const: 2 description: @@ -107,6 +113,8 @@ allOf: gpio-line-names: minItems: 2 maxItems: 2 + gpio-reserved-ranges: + maxItems: 1 - if: properties: @@ -124,6 +132,9 @@ allOf: gpio-line-names: minItems: 4 maxItems: 4 + gpio-reserved-ranges: + minItems: 1 + maxItems: 2 - if: properties: @@ -137,6 +148,9 @@ allOf: gpio-line-names: minItems: 6 maxItems: 6 + gpio-reserved-ranges: + minItems: 1 + maxItems: 3 - if: properties: @@ -150,6 +164,9 @@ allOf: gpio-line-names: minItems: 8 maxItems: 8 + gpio-reserved-ranges: + minItems: 1 + maxItems: 4 - if: properties: @@ -163,6 +180,9 @@ allOf: gpio-line-names: minItems: 9 maxItems: 9 + gpio-reserved-ranges: + minItems: 1 + maxItems: 5 - if: properties: @@ -182,6 +202,9 @@ allOf: gpio-line-names: minItems: 10 maxItems: 10 + gpio-reserved-ranges: + minItems: 1 + maxItems: 5 - if: properties: @@ -194,6 +217,9 @@ allOf: gpio-line-names: minItems: 11 maxItems: 11 + gpio-reserved-ranges: + minItems: 1 + maxItems: 6 - if: properties: @@ -212,6 +238,9 @@ allOf: gpio-line-names: minItems: 12 maxItems: 12 + gpio-reserved-ranges: + minItems: 1 + maxItems: 6 - if: properties: @@ -224,6 +253,9 @@ allOf: gpio-line-names: minItems: 13 maxItems: 13 + gpio-reserved-ranges: + minItems: 1 + maxItems: 7 - if: properties: @@ -236,6 +268,9 @@ allOf: gpio-line-names: minItems: 14 maxItems: 14 + gpio-reserved-ranges: + minItems: 1 + maxItems: 7 - if: properties: @@ -248,6 +283,9 @@ allOf: gpio-line-names: minItems: 16 maxItems: 16 + gpio-reserved-ranges: + minItems: 1 + maxItems: 8 - if: properties: @@ -261,6 +299,9 @@ allOf: gpio-line-names: minItems: 22 maxItems: 22 + gpio-reserved-ranges: + minItems: 1 + maxItems: 11 - if: properties: @@ -273,6 +314,9 @@ allOf: gpio-line-names: minItems: 26 maxItems: 26 + gpio-reserved-ranges: + minItems: 1 + maxItems: 13 - if: properties: @@ -285,6 +329,9 @@ allOf: gpio-line-names: minItems: 36 maxItems: 36 + gpio-reserved-ranges: + minItems: 1 + maxItems: 18 - if: properties: @@ -297,6 +344,9 @@ allOf: gpio-line-names: minItems: 38 maxItems: 38 + gpio-reserved-ranges: + minItems: 1 + maxItems: 19 - if: properties: @@ -310,6 +360,9 @@ allOf: gpio-line-names: minItems: 44 maxItems: 44 + gpio-reserved-ranges: + minItems: 1 + maxItems: 22 patternProperties: '-state$': From patchwork Sun May 8 13:59:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 570806 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D714C433EF for ; Sun, 8 May 2022 13:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233753AbiEHODi (ORCPT ); Sun, 8 May 2022 10:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233709AbiEHODf (ORCPT ); Sun, 8 May 2022 10:03:35 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D9C1DFB1 for ; Sun, 8 May 2022 06:59:44 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id z2so20739506ejj.3 for ; Sun, 08 May 2022 06:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k50mJPbpmQp4ZqpTJGpM+QQCXPw1yE6XvXVaK9la8K8=; b=Lr65hVJJkETPw516VWaQvE8zkYACS4A1NHzJ0ZDkc8+J7e4lUMyXusayN7ywW2D3lF 12dlRSup0iGCOhLuNLNwjOrP3ZbvyhXfjFR6wxOsa2jE3hdDWKz529oExedwTLryU8PL 8mze926P2VhVK1VipDHDcQeVShexST67/JKyufOcwiTcK16J0fZOb6sCigODoZZFQgxe Cz/bBChj3PiMTGk404KzzTeYhywBPMtAQ/2Ds5tEttkJKfiA8gR8JnjAFqBSjEH29+G6 Qd894sPf6X0/BqIkTqcLPxsB3gLkUpYo9eSMHqzYjzpjUy1B8kXyuug1eYAjRcwk3mVA QwSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k50mJPbpmQp4ZqpTJGpM+QQCXPw1yE6XvXVaK9la8K8=; b=G4cPZPBC9/7LiQ4BlISblxC/QDhQ9aSi9CQ0EbHk8BmMUiO5hyOQ95MIb1N5JcgVT2 jYi00CDCHfWMFrJDVYweZZ/M3SUJ5EegIxmiZWpUhj3PAxqoBz0FhVuvilYSPnONERdn Vnvc8Mt02+r+sfQUopRk+h4EPvfP/JetNx5naDmgK4pg4pbNCuqmrg5jqnTL46bL2qeI zQUHtODspEWfnvE7p8ZmXwqcs3ei0a+aqH7NteFYKYYQGm4DOT+VII0gyyN41IkQHyY7 9a9v/zxuHoGQIs2D0USlPYovOAQuh4aZhg3qXK7ptHcaETtX2yPlLmhkx16CErSNm/PV wGlg== X-Gm-Message-State: AOAM532R2oKpxRT1N+iP4vwvAfaGWURxl7X1EWhDR4rUdNgY2wzupFG3 BSK4sD2kxpmc+pxZfJPAf4ECUA== X-Google-Smtp-Source: ABdhPJw3eg/IFzBYwVdGMUwtyRIdaWs2jgo/4w2kfJyKecL4+n2lggRm/3VGBSpCEJ3zgUVoIUWhGw== X-Received: by 2002:a17:907:7242:b0:6f5:2904:5354 with SMTP id ds2-20020a170907724200b006f529045354mr10026196ejc.452.1652018383113; Sun, 08 May 2022 06:59:43 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id qz24-20020a170907681800b006f3ef214dc6sm4075524ejc.44.2022.05.08.06.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 06:59:42 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Luca Weiss , David Heidelberg , Konrad Dybcio , Krzysztof Kozlowski Subject: [RFT 3/4] arm64: dts: qcom: correct interrupt controller on PM8916 and PMS405 Date: Sun, 8 May 2022 15:59:31 +0200 Message-Id: <20220508135932.132378-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220508135932.132378-1-krzysztof.kozlowski@linaro.org> References: <20220508135932.132378-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The PM8916 and PMS405 PMIC GPIOs are interrupt controllers, as described in the bindings and used by the driver. Drop the interrupts (apparently copied from downstream tree), just like in commit 61d2ca503d0b ("arm64: dts: qcom: fix pm8150 gpio interrupts"): qcs404-evb-4000.dtb: gpio@c000: 'interrupts' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' qcs404-evb-4000.dtb: gpio@c000: 'interrupt-controller' is a required property Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/pm8916.dtsi | 6 ++---- arch/arm64/boot/dts/qcom/pms405.dtsi | 14 ++------------ 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi index d52919a8c0b0..0b6e8ad7fa50 100644 --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi @@ -113,10 +113,8 @@ pm8916_gpios: gpios@c000 { gpio-controller; gpio-ranges = <&pm8916_gpios 0 0 4>; #gpio-cells = <2>; - interrupts = <0 0xc0 0 IRQ_TYPE_NONE>, - <0 0xc1 0 IRQ_TYPE_NONE>, - <0 0xc2 0 IRQ_TYPE_NONE>, - <0 0xc3 0 IRQ_TYPE_NONE>; + interrupt-controller; + #interrupt-cells = <2>; }; }; diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi index 26f1e8cc9c6c..634b0681d04c 100644 --- a/arch/arm64/boot/dts/qcom/pms405.dtsi +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi @@ -43,18 +43,8 @@ pms405_gpios: gpio@c000 { gpio-controller; gpio-ranges = <&pms405_gpios 0 0 12>; #gpio-cells = <2>; - interrupts = <0 0xc0 0 IRQ_TYPE_NONE>, - <0 0xc1 0 IRQ_TYPE_NONE>, - <0 0xc2 0 IRQ_TYPE_NONE>, - <0 0xc3 0 IRQ_TYPE_NONE>, - <0 0xc4 0 IRQ_TYPE_NONE>, - <0 0xc5 0 IRQ_TYPE_NONE>, - <0 0xc6 0 IRQ_TYPE_NONE>, - <0 0xc7 0 IRQ_TYPE_NONE>, - <0 0xc8 0 IRQ_TYPE_NONE>, - <0 0xc9 0 IRQ_TYPE_NONE>, - <0 0xca 0 IRQ_TYPE_NONE>, - <0 0xcb 0 IRQ_TYPE_NONE>; + interrupt-controller; + #interrupt-cells = <2>; }; pon@800 {