From patchwork Thu May 5 02:29:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 570893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD02C433FE for ; Thu, 5 May 2022 02:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239337AbiEECdb (ORCPT ); Wed, 4 May 2022 22:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239264AbiEECd3 (ORCPT ); Wed, 4 May 2022 22:33:29 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30FB549F35; Wed, 4 May 2022 19:29:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TOfVymYPRY9Knwba5zkz2qQWqzhsgV5nQMVwverzKRCi74J86iU+ICNnyqhiBmgAMdWLjJW57Bt6Z11uBLaAC4/rPLvIMV65NHngzcBZmY6AqWruizVcBgGUDQ0TH1U7C/d6lwdi3nFZv9LS4tLawPrFH5GiCXLYl+DZZeZdehvLQ5VTPmsyHtohin5Dd/njnSUsFuJoici/4DbOV8MMT4GVYMNehVWNa8xkf0ZHUopVhixB6+HORAMQjubRqTX2PaHNdNNd0cE2TO1awCQQqxILVgCesLsVzyeuT0H3Fjv/Oqeg9zlC5omMmdAcJKgNHsisuW2WQAKg83GbB128Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fPnNI2bIDkdlt38aPtGjA+tsnC2UfqcIM1ohrVtJmu8=; b=mx2s9R+KOZt7SLUkEwL4gc22utkn6UEvfaGxs8elZ0Dl8Ysuy14p27Wf5dy+InqHQbW6HHX5cAcJZmpTC0MFGwNvZ3x31uqgZzgyAJLLNhpYvJKC+fBn1xoYkVSJj+3xcyL5hVfqhhY/Tn188rHwuQqOy9HiAgBFydKT/HQWL1fO5j8fj2qohvkhnctMxYPV2TpzR9inwvgww/MK4pVibqg8Rm//MWAhDELXytvPELS8PYZT2EFqLbWZ/VMsBf4UZqwSW7I7/IhSV5C0YcesOSYtuXDd/hNBbIXD6InYXbbEX8N+j/OlxkXNGQpBN/jZNBvajw1uZIo/BX9iAKzMSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fPnNI2bIDkdlt38aPtGjA+tsnC2UfqcIM1ohrVtJmu8=; b=dd10giTut9Fp6KwonPu2FsvlO4sKZDTqOYXfsxKu36QP/1LYuaU9l5y4OqEckssxcOeQ43Cl4Ibq0+Qw75ejrHtqr0U1fsbwznBzunp4QK7Te3oStPiSiPgXxS7eGYuEfChLAq+/BiHdicKyXhuaLJx3EXJKbpbLJFSAqxqngDo= Received: from BN1PR14CA0003.namprd14.prod.outlook.com (2603:10b6:408:e3::8) by MN2PR12MB3821.namprd12.prod.outlook.com (2603:10b6:208:16f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 02:29:49 +0000 Received: from BN8NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e3:cafe::f5) by BN1PR14CA0003.outlook.office365.com (2603:10b6:408:e3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Thu, 5 May 2022 02:29:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT045.mail.protection.outlook.com (10.13.177.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 02:29:48 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 4 May 2022 21:29:44 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V5 1/3] cpufreq: amd-pstate: Expose struct amd_cpudata Date: Thu, 5 May 2022 10:29:11 +0800 Message-ID: <20220505022913.329259-2-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505022913.329259-1-li.meng@amd.com> References: <20220505022913.329259-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f49c203-6faf-4c86-59be-08da2e3f207e X-MS-TrafficTypeDiagnostic: MN2PR12MB3821:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NsTOEPztFYwQx3wbS+Roa0Fb1icvssEYe8xE4UVuz1qNF/qHWWu1EfXJNoZRXGA9hetvc9fuOCVXdY8uE/IPA/KupM7Y2vyBXpQnk+MvF1fP03lJp5kUB9JuJARBE9uTgDE3i5YSREM7gGUQAHoApygJhdA+5KCc2tYwi8LZJw9u3BtiopVtN4UW45resi61Hri6LKVpHkfvX0AaXVJpTQpO3wlRmhecz115zAo26XInfwJMziM3U1iZktRIP9Moejonw0LfxVLTJEm8SchPx6GwSiwsalwAyndYQ4yj6JnLK8oODjMw0jrL0oUJ+ntbBcXql7+ygotLMc/x9OeZQK6BxsWEibOx0IRXasT8gzkaKmsZxRf62XJwvIIDQW6S2IaOJsR/0xdS17Dy04KGjgri9Wg84g6LR5P6bEpfVk7rGBsHTEQxSm5Tw8H5Ohx5BXzxPcMI8iAA0B9TMPbdFkrrPdpskfFA0AZyxcys3CxFZjkCron6lqp4Rqu34v0NdY0FmQ1nwp/rT/BlLGh6rUJQQXQAqgFgHL8ekg6xhhL0WA0Zhdvt5x+LOeZrlh7QZB1TaSDuw2VJW11BvAHb6pJkMA0CbJ9bcK930noQhTm0ENDH+rsztniLZGC6BpBWiQIhZXfNXdcAfN9mVuk+c6kO9PZcyZH1ZqKTZLLx2xUCClCi6lE1pFymlWsNVYM5WS0OUG1TZWKwtzllbDSXHQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(4326008)(336012)(426003)(47076005)(40460700003)(81166007)(70586007)(83380400001)(70206006)(2616005)(110136005)(36860700001)(16526019)(316002)(186003)(1076003)(54906003)(82310400005)(8676002)(26005)(86362001)(2906002)(36756003)(6666004)(356005)(5660300002)(7696005)(508600001)(8936002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 02:29:48.8690 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f49c203-6faf-4c86-59be-08da2e3f207e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3821 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Expose struct amd_cpudata to AMD P-State unit test module. This data struct will be used on the following AMD P-State unit test (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD infomations by this data struct. For example: highest perf, nominal perf, boost supported etc. Signed-off-by: Meng Li Acked-by: Huang Rui --- MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--------------------------- include/linux/amd-pstate.h | 77 ++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h diff --git a/MAINTAINERS b/MAINTAINERS index 40fa1955ca3f..db85d9e52547 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1021,6 +1021,7 @@ L: linux-pm@vger.kernel.org S: Supported F: Documentation/admin-guide/pm/amd-pstate.rst F: drivers/cpufreq/amd-pstate* +F: include/linux/amd-pstate.h F: tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py AMD PTDMA DRIVER diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 7be38bc6a673..5f7a00a64f76 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -36,6 +36,7 @@ #include #include #include +#include #include #include @@ -65,65 +66,6 @@ MODULE_PARM_DESC(shared_mem, static struct cpufreq_driver amd_pstate_driver; -/** - * struct amd_aperf_mperf - * @aperf: actual performance frequency clock count - * @mperf: maximum performance frequency clock count - * @tsc: time stamp counter - */ -struct amd_aperf_mperf { - u64 aperf; - u64 mperf; - u64 tsc; -}; - -/** - * struct amd_cpudata - private CPU data for AMD P-State - * @cpu: CPU number - * @req: constraint request to apply - * @cppc_req_cached: cached performance request hints - * @highest_perf: the maximum performance an individual processor may reach, - * assuming ideal conditions - * @nominal_perf: the maximum sustained performance level of the processor, - * assuming ideal operating conditions - * @lowest_nonlinear_perf: the lowest performance level at which nonlinear power - * savings are achieved - * @lowest_perf: the absolute lowest performance level of the processor - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf - * @cur: Difference of Aperf/Mperf/tsc count between last and current sample - * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value - * @boost_supported: check whether the Processor or SBIOS supports boost mode - * - * The amd_cpudata is key private data for each CPU thread in AMD P-State, and - * represents all the attributes and goals that AMD P-State requests at runtime. - */ -struct amd_cpudata { - int cpu; - - struct freq_qos_request req[2]; - u64 cppc_req_cached; - - u32 highest_perf; - u32 nominal_perf; - u32 lowest_nonlinear_perf; - u32 lowest_perf; - - u32 max_freq; - u32 min_freq; - u32 nominal_freq; - u32 lowest_nonlinear_freq; - - struct amd_aperf_mperf cur; - struct amd_aperf_mperf prev; - - u64 freq; - bool boost_supported; -}; - static inline int pstate_enable(bool enable) { return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable); diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h new file mode 100644 index 000000000000..1c4b8659f171 --- /dev/null +++ b/include/linux/amd-pstate.h @@ -0,0 +1,77 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * linux/include/linux/amd-pstate.h + * + * Copyright (C) 2022 Advanced Micro Devices, Inc. + * + * Author: Meng Li + */ + +#ifndef _LINUX_AMD_PSTATE_H +#define _LINUX_AMD_PSTATE_H + +#include + +/********************************************************************* + * AMD P-state INTERFACE * + *********************************************************************/ +/** + * struct amd_aperf_mperf + * @aperf: actual performance frequency clock count + * @mperf: maximum performance frequency clock count + * @tsc: time stamp counter + */ +struct amd_aperf_mperf { + u64 aperf; + u64 mperf; + u64 tsc; +}; + +/** + * struct amd_cpudata - private CPU data for AMD P-State + * @cpu: CPU number + * @req: constraint request to apply + * @cppc_req_cached: cached performance request hints + * @highest_perf: the maximum performance an individual processor may reach, + * assuming ideal conditions + * @nominal_perf: the maximum sustained performance level of the processor, + * assuming ideal operating conditions + * @lowest_nonlinear_perf: the lowest performance level at which nonlinear power + * savings are achieved + * @lowest_perf: the absolute lowest performance level of the processor + * @max_freq: the frequency that mapped to highest_perf + * @min_freq: the frequency that mapped to lowest_perf + * @nominal_freq: the frequency that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf + * @cur: Difference of Aperf/Mperf/tsc count between last and current sample + * @prev: Last Aperf/Mperf/tsc count value read from register + * @freq: current cpu frequency value + * @boost_supported: check whether the Processor or SBIOS supports boost mode + * + * The amd_cpudata is key private data for each CPU thread in AMD P-State, and + * represents all the attributes and goals that AMD P-State requests at runtime. + */ +struct amd_cpudata { + int cpu; + + struct freq_qos_request req[2]; + u64 cppc_req_cached; + + u32 highest_perf; + u32 nominal_perf; + u32 lowest_nonlinear_perf; + u32 lowest_perf; + + u32 max_freq; + u32 min_freq; + u32 nominal_freq; + u32 lowest_nonlinear_freq; + + struct amd_aperf_mperf cur; + struct amd_aperf_mperf prev; + + u64 freq; + bool boost_supported; +}; + +#endif /* _LINUX_AMD_PSTATE_H */ From patchwork Thu May 5 02:29:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 570102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146FAC433F5 for ; Thu, 5 May 2022 02:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239417AbiEECdk (ORCPT ); Wed, 4 May 2022 22:33:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239264AbiEECdg (ORCPT ); Wed, 4 May 2022 22:33:36 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2071.outbound.protection.outlook.com [40.107.243.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B744ECD2; Wed, 4 May 2022 19:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJP53wNljUTRdI0OAtgqsL7u6Q1XS0r69YCKaNLSRMYuvlmy9Np9xhZM97K3EkAJT/d4LEWbgI8JExD5EQrq3D+plSdTRJoZg6mPwwEa3RYTmnn3xD7OhWwuvXkWgNVlhPKupICWTIwvOXCpk5guUeiOJSUrUUokKkzrfRQR3MZiXF10eQyasSCHZuzUCPenJxgAmqBUCPG/ztV8Bmvcud8D2l5pZNw4T+UpKHWKXLOostWv0NLsdbC1X/lxhOgWNSkAJL8wME9lt30RJGJDJlexWP7r3CmTkO11wJW/Dc1CnQ1+xf3QekWmkjo/YhW19zYQ0D9CWI8ima54bNFC9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MrTSCngPL++xv1S6xHJvI4/g0pOtMYaQ7W0kEoVUQ/U=; b=aq2u7nXJLkglZUq+nvBWdpqBbVcyp+g2xLWYcEb7ASL34rRSxj75sBcJhe011YR4OlMD0ic8cdYAoAv7vqcXLmgVALkp3rtHUQ+u99LYJN2tyK1meYm/VwrEY2ZwV72jsR0hMdubIpxAxN+ATFVSQqMOr9uam+1cpQDDnv3lXCPAGTrnp+VjV/FqUzhcUXR9jvsn/Y/p+NQtrIu1pY9guqLfJGCBkS2lnfY56xD4jOms6h5rBvF0a3YJPtP8PC6No5+c5ZPtUY+3ZvR1VJaWRshwbdW6MUwk+jWgYXw4D3bQbGxkojM+QZnjXMw2BXS89J1AOl6qwu1EoD72b1wqjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MrTSCngPL++xv1S6xHJvI4/g0pOtMYaQ7W0kEoVUQ/U=; b=04cVepZTteWtsfyPordiNzFSdg8mpfV8I5eWvhRP7yZ0szJQQhL9VOg7IVniZo+EQnesFhngjLb/TisDUQTVi97sRKvN76+P22kuFQhgyTDyGISwNjo2XsdgQZgL25vGlFg1nb2MkAs00fLYdhOCYvWAqA7yvJcjzkjJqh463h4= Received: from BN0PR03CA0040.namprd03.prod.outlook.com (2603:10b6:408:e7::15) by BN6PR12MB1921.namprd12.prod.outlook.com (2603:10b6:404:fe::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 02:29:55 +0000 Received: from BN8NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::4c) by BN0PR03CA0040.outlook.office365.com (2603:10b6:408:e7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 02:29:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT064.mail.protection.outlook.com (10.13.176.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 02:29:55 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 4 May 2022 21:29:48 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V5 2/3] selftests: amd-pstate: Add test module for amd-pstate driver Date: Thu, 5 May 2022 10:29:12 +0800 Message-ID: <20220505022913.329259-3-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505022913.329259-1-li.meng@amd.com> References: <20220505022913.329259-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de24c7e9-133f-4d2d-03b5-08da2e3f2436 X-MS-TrafficTypeDiagnostic: BN6PR12MB1921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g+7ADQ9/EBqUj0yvc540oNUQvqODRkH+jQjhjM1yuXsV6SIIi+7Yx9F8vtsFBQ05MSoA1+rVwvkTMJqt2ly4WC/U9DZgFX6mOgKHROodItk0OldxpC9wHrgIKaWjJC6dOwNUFhXXpeMYqnqpS5Tv5SgdhahHqZZNNgqPmN0IGQ9HuqS6IB/vbsSG2JWHg7ZrQna6tLVJ4S1p27R0XrkufHUJ8igHNB9ASfoUpXE0O/mqn7ts3n6rC4A3OD3owjjPyawCgc3smJrKmOYRDuRefLs49aLXgAWfboIPbm/WFk8jsic9pjqyTxXE3swu+LcrHNECD1T+oa71AM3ZGxki1tkp3QFeUvs8bI+1HxbvOgmdLPXN89pDkWSLd4ssK8kdZd5XkuPEK5EONIostREncWuUGACFY89hL8pY5fIN7shoBHQ0P82QeiJAqQzZXIyK169B4NmY92HDPV5NF++WGeGUd+nge4v1dqCiFKHMmVnRviLKWSU1hgfSGvG4G+ROvgYBddFsu50BZtJBAAsAjN7hh7pRuDjDsyrSIueXVujm4SlTnSD93Rpb/hw58KDcY61gOQZXh8Vbh6GqG8j4THNGsios3DU1v1YVD0n+oNw/shLGXsKy/lgZ4yDTDnc1B8hzK5P/P8S2/PJxYRim3V1qpGmlfL6c7j2hZsUayNhF+o7a5G2whTmjUlQdsSfiWGyDVaaEw9ApYTb1zuDORw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(7696005)(6666004)(36860700001)(86362001)(26005)(81166007)(356005)(16526019)(186003)(426003)(47076005)(336012)(40460700003)(1076003)(2616005)(316002)(83380400001)(5660300002)(8676002)(70206006)(4326008)(70586007)(82310400005)(36756003)(30864003)(2906002)(8936002)(54906003)(110136005)(508600001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 02:29:55.1058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de24c7e9-133f-4d2d-03b5-08da2e3f2436 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1921 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add amd-pstate-ut module, which is conceptually out-of-tree module and provides ways for selftests/amd-pstate driver to test various kernel module-related functionality. This module will be expected by some of selftests to be present and loaded. Signed-off-by: Meng Li --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 15 + .../selftests/amd-pstate/amd-pstate-ut.sh | 45 +++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 278 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 6 files changed, 360 insertions(+) create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/config diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 2319ec87f53d..975c13368286 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 TARGETS += alsa +TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile new file mode 100644 index 000000000000..0cac1971a2fb --- /dev/null +++ b/tools/testing/selftests/amd-pstate/Makefile @@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Makefile for amd-pstate/ function selftests + +uname_M := $(shell uname -m 2>/dev/null || echo not) +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) + +ifeq (x86,$(ARCH)) +TEST_GEN_FILES := amd-pstate-ut/amd-pstate-ut.ko +endif + +TEST_PROGS := amd-pstate-ut.sh + +include ../lib.mk + +$(TEST_GEN_FILES): $(HEADERS) diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file mode 100755 index 000000000000..785a5bde0e1f --- /dev/null +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh @@ -0,0 +1,45 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +# amd-pstate-ut is a test module for testing the amd-pstate driver. +# (1) It can help all users to verify their processor support +# (SBIOS/Firmware or Hardware). +# (2) Kernel can have a basic function test to avoid the kernel +# regression during the update. +# (3) We can introduce more functional or performance tests to align +# the result together, it will benefit power and performance scale optimization. + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then + echo "$0 # Skipped: Test can only run on x86 architectures." + exit $ksft_skip +fi + +msg="Skip all tests:" +if [ ! -w /dev ]; then + echo $msg please run this as root >&2 + exit $ksft_skip +fi + +scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver) + +if [ "$scaling_driver" != "amd-pstate" ]; then + echo "$0 # Skipped: Test can only run on amd-pstate driver." + echo "$0 # Current cpufreq scaling drvier is $scaling_driver." + exit $ksft_skip +fi + +kernel_release=`uname -r` +sudo cp amd-pstate-ut.ko /lib/modules/$kernel_release/ +if [ $? -eq 1 ];then + echo $msg please check test module >&2 + exit $ksft_skip +fi +sudo depmod + +$(dirname $0)/../kselftest/module.sh "amd-pstate-ut" amd-pstate-ut + +sudo rm /lib/modules/$kernel_release/amd-pstate-ut.ko +sudo depmod diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile b/tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile new file mode 100644 index 000000000000..16e09c64369a --- /dev/null +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile @@ -0,0 +1,20 @@ +AMD_PSTATE_UT_DIR := $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST))))) +KDIR ?= $(abspath $(AMD_PSATE_UT_DIR)/../../../../..) + +ifeq ($(V),1) +Q = +else +Q = @ +endif + +MODULES = amd-pstate-ut.ko + +obj-m += amd-pstate-ut.o +CFLAGS_amd-pstate-ut.o = -I$(src) + +all: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) modules + +clean: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) clean + diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c b/tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c new file mode 100644 index 000000000000..83aeb1d9dbba --- /dev/null +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c @@ -0,0 +1,278 @@ +// SPDX-License-Identifier: GPL-1.0-or-later +/* + * AMD Processor P-state Frequency Driver Unit Test + * + * Copyright (C) 2022 Advanced Micro Devices, Inc. All Rights Reserved. + * + * Author: Meng Li + * + * The AMD P-State Unit Test is a test module for testing the amd-pstate + * driver. 1) It can help all users to verify their processor support + * (SBIOS/Firmware or Hardware). 2) Kernel can have a basic function + * test to avoid the kernel regression during the update. 3) We can + * introduce more functional or performance tests to align the result + * together, it will benefit power and performance scale optimization. + * + * At present, it only implements the basic framework and some simple + * test cases. Next, 1) we will add a rst document. 2) we will add more + * test cases to improve the depth and coverage of the test. + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include "../../kselftest_module.h" + +#include +#include +#include +#include +#include + +#include + +/* + * Abbreviations: + * aput: used as a shortform for AMD P-State unit test. + * It helps to keep variable names smaller, simpler + */ + +KSTM_MODULE_GLOBALS(); + +/* + * Kernel module for testing the AMD P-State unit test + */ +enum aput_result { + APUT_RESULT_PASS, + APUT_RESULT_FAIL, + MAX_APUT_RESULT, +}; + +struct aput_struct { + const char *name; + void (*func)(u32 index); + enum aput_result result; +}; + +static void aput_acpi_cpc(u32 index); +static void aput_check_enabled(u32 index); +static void aput_check_perf(u32 index); +static void aput_check_freq(u32 index); + +static struct aput_struct aput_cases[] = { + {"acpi_cpc_valid", aput_acpi_cpc }, + {"check_enabled", aput_check_enabled }, + {"check_perf", aput_check_perf }, + {"check_freq", aput_check_freq } +}; + +static bool get_shared_mem(void) +{ + bool result = false; + char buf[5] = {0}; + struct file *filp = NULL; + loff_t pos = 0; + ssize_t ret; + + if (!boot_cpu_has(X86_FEATURE_CPPC)) { + filp = filp_open("/sys/module/amd_pstate/parameters/shared_mem", FMODE_PREAD, 0); + if (IS_ERR(filp)) + pr_err("%s Open param file fail!\n", __func__); + else { + ret = kernel_read(filp, &buf, sizeof(buf), &pos); + if (ret < 0) + pr_err("%s ret=%ld unable to read from param file!\n", + __func__, ret); + filp_close(filp, NULL); + } + + if ('Y' == *buf) + result = true; + } + + return result; +} + +static void aput_acpi_cpc(u32 index) +{ + if (acpi_cpc_valid()) + aput_cases[index].result = APUT_RESULT_PASS; + else + aput_cases[index].result = APUT_RESULT_FAIL; +} + +static void aput_pstate_enable(u32 index) +{ + int ret = 0; + u64 cppc_enable = 0; + + ret = rdmsrl_safe(MSR_AMD_CPPC_ENABLE, &cppc_enable); + if (ret) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s rdmsrl_safe MSR_AMD_CPPC_ENABLE ret=%d is error!\n", __func__, ret); + return; + } + if (cppc_enable) + aput_cases[index].result = APUT_RESULT_PASS; + else + aput_cases[index].result = APUT_RESULT_FAIL; +} + +/* + *Check if enabled amd pstate + */ +static void aput_check_enabled(u32 index) +{ + if (get_shared_mem()) + aput_cases[index].result = APUT_RESULT_PASS; + else + aput_pstate_enable(index); +} + +/* + * Check if the each performance values are reasonable. + * highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0 + */ +static void aput_check_perf(u32 index) +{ + int cpu = 0, ret = 0; + u32 highest_perf = 0, nominal_perf = 0, lowest_nonlinear_perf = 0, lowest_perf = 0; + u64 cap1 = 0; + struct cppc_perf_caps cppc_perf; + struct cpufreq_policy *policy = NULL; + struct amd_cpudata *cpudata = NULL; + + highest_perf = amd_get_highest_perf(); + + for_each_possible_cpu(cpu) { + policy = cpufreq_cpu_get(cpu); + if (!policy) + break; + cpudata = policy->driver_data; + + if (get_shared_mem()) { + ret = cppc_get_perf_caps(cpu, &cppc_perf); + if (ret) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cppc_get_perf_caps ret=%d is error!\n", __func__, ret); + return; + } + + nominal_perf = cppc_perf.nominal_perf; + lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; + lowest_perf = cppc_perf.lowest_perf; + } else { + ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1); + if (ret) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s read CPPC_CAP1 ret=%d is error!\n", __func__, ret); + return; + } + + nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1); + lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1); + lowest_perf = AMD_CPPC_LOWEST_PERF(cap1); + } + + if ((highest_perf != READ_ONCE(cpudata->highest_perf)) || + (nominal_perf != READ_ONCE(cpudata->nominal_perf)) || + (lowest_nonlinear_perf != READ_ONCE(cpudata->lowest_nonlinear_perf)) || + (lowest_perf != READ_ONCE(cpudata->lowest_perf))) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d highest=%d %d nominal=%d %d lowest_nonlinear=%d %d lowest=%d %d are not equal!\n", + __func__, cpu, highest_perf, cpudata->highest_perf, + nominal_perf, cpudata->nominal_perf, + lowest_nonlinear_perf, cpudata->lowest_nonlinear_perf, + lowest_perf, cpudata->lowest_perf); + return; + } + + if (!((highest_perf >= nominal_perf) && + (nominal_perf > lowest_nonlinear_perf) && + (lowest_nonlinear_perf > lowest_perf) && + (lowest_perf > 0))) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d highest=%d nominal=%d lowest_nonlinear=%d lowest=%d have error!\n", + __func__, cpu, highest_perf, nominal_perf, + lowest_nonlinear_perf, lowest_perf); + return; + } + } + + aput_cases[index].result = APUT_RESULT_PASS; +} + +/* + * Check if the each frequency values are reasonable. + * max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 + * check max freq when set support boost mode. + */ +static void aput_check_freq(u32 index) +{ + int cpu = 0; + struct cpufreq_policy *policy = NULL; + struct amd_cpudata *cpudata = NULL; + + for_each_possible_cpu(cpu) { + policy = cpufreq_cpu_get(cpu); + if (!policy) + break; + cpudata = policy->driver_data; + + if (!((cpudata->max_freq >= cpudata->nominal_freq) && + (cpudata->nominal_freq > cpudata->lowest_nonlinear_freq) && + (cpudata->lowest_nonlinear_freq > cpudata->min_freq) && + (cpudata->min_freq > 0))) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d max=%d nominal=%d lowest_nonlinear=%d min=%d have error!\n", + __func__, cpu, cpudata->max_freq, cpudata->nominal_freq, + cpudata->lowest_nonlinear_freq, cpudata->min_freq); + return; + } + + if (cpudata->min_freq != policy->min) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d have error!\n", + __func__, cpu, cpudata->min_freq, policy->min); + return; + } + + if (cpudata->boost_supported) { + if ((policy->max == cpudata->max_freq) || + (policy->max == cpudata->nominal_freq)) + aput_cases[index].result = APUT_RESULT_PASS; + else { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d policy_max=%d cpu_max=%d cpu_nominal=%d have error!\n", + __func__, cpu, policy->max, cpudata->max_freq, + cpudata->nominal_freq); + return; + } + } else { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d not support boost!\n", __func__, cpu); + return; + } + } +} + +static void aput_do_test_case(void) +{ + u32 i = 0, arr_size = ARRAY_SIZE(aput_cases); + + for (i = 0; i < arr_size; i++) { + pr_info("****** Begin %-5d\t %-20s\t ******\n", i+1, aput_cases[i].name); + aput_cases[i].func(i); + KSTM_CHECK_ZERO(aput_cases[i].result); + pr_info("****** End %-5d\t %-20s\t ******\n", i+1, aput_cases[i].name); + } +} + +static void __init selftest(void) +{ + aput_do_test_case(); +} + +KSTM_MODULE_LOADERS(amd_pstate_ut); +MODULE_AUTHOR("Meng Li "); +MODULE_DESCRIPTION("Unit test for AMD P-state driver"); +MODULE_LICENSE("GPL"); diff --git a/tools/testing/selftests/amd-pstate/config b/tools/testing/selftests/amd-pstate/config new file mode 100644 index 000000000000..f43103c9adc4 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/config @@ -0,0 +1 @@ +CONFIG_X86_AMD_PSTATE_UT=m From patchwork Thu May 5 02:29:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 570892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE91C433EF for ; Thu, 5 May 2022 02:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239264AbiEECdn (ORCPT ); Wed, 4 May 2022 22:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbiEECdn (ORCPT ); Wed, 4 May 2022 22:33:43 -0400 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2055.outbound.protection.outlook.com [40.107.95.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 442FB506C2; Wed, 4 May 2022 19:30:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWH72k/RJGHcguldnfsC8XpjiM1mguayCHYfKNJ0Cvt11A17ejTna2xCHAsjJRGbSP95GrVuBbD7MJFTjptmKR/mQ3dE0QZ6jB/5TV6Z1D6O3aUrZLMA6A+R5AhNYqcvO3s0XpP/hktizvY0jhSk2zl1Zj4TpqRBxEB2CPavqZxf1bJwLYEmwMEgRrMeOHxbTH1yHbp/UBeb6T+fIapG+uQjegtcstNSv7b89osTZN+3NQlmYm+xdx3ACkYCgp8LaKcRQplA1HXWWtMkD1qEB8EWTsJd90TSa3TDWiluOkUv7C/GnklKrU/1mrl1ysNyLAL/5LEBKFqywdaiFU4JLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mT+4mfkRr7MVGEB89tWrj/q81OM4L9M/85uwrwTbqEM=; b=l29m3fs2N7m+43UdfeJKWmH4Sdd9s+unJnROdqb8frBQSoeEggDggegaH2LtnCZpdaEEIBUDzp+/c9qX/eU8n/JhCSnsHZQcPcfjOV677xXS8CkDSovgx6qb+b+kR18flUgUGLgSTUmUIRcJCjqmIMnynUY7J0nHPZNlPJhywunqulwTYPTNvroST7HhRiEBMONinjirN2Yr0krZUrflthvkdBre7k+ktJ3amrcodonSmrQAkGHtGh/KQTdlCywXe8Og+wpr6pZow6M6dAMjhLwCF3yfYcuhNiqnjK6aWaQHqRdQLlMRJLB5uJeEwyzM4U1jES/N/xyE6SMbpFw7ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mT+4mfkRr7MVGEB89tWrj/q81OM4L9M/85uwrwTbqEM=; b=q32XFE3eC1KKaHcVshARmzZZ2fE6ecI4Kzhu0dUtOQMG5rWLwDS3DTcDBdWujQ0A+5hDVUWWUl0dWhtp1W4RxkKo1hT9amm75MjZXHdFUlQIid2VkddZgsa2Hgbr4Z3oc3cg6bEHYapbXhz5HeYOxQzJwVc6aHRTUJH8b2Y8Nek= Received: from BN9PR03CA0061.namprd03.prod.outlook.com (2603:10b6:408:fc::6) by BYAPR12MB3541.namprd12.prod.outlook.com (2603:10b6:a03:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 5 May 2022 02:29:59 +0000 Received: from BN8NAM11FT019.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::82) by BN9PR03CA0061.outlook.office365.com (2603:10b6:408:fc::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25 via Frontend Transport; Thu, 5 May 2022 02:29:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT019.mail.protection.outlook.com (10.13.176.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 02:29:59 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 4 May 2022 21:29:54 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V5 3/3] Documentation: amd-pstate: Add unit test introduction Date: Thu, 5 May 2022 10:29:13 +0800 Message-ID: <20220505022913.329259-4-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505022913.329259-1-li.meng@amd.com> References: <20220505022913.329259-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9cd9703a-fc82-48b8-3828-08da2e3f2697 X-MS-TrafficTypeDiagnostic: BYAPR12MB3541:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YURXEh/AQzZHI05x5rhtzr49IQkhgt/HXeyp12GCJ+MFLaUycaaLQZSVuuqRzrGZAK9F6qeXeyGjQNzKsfS3spQzaZtgTBTFb9gflWY0jZ4MVOUQ0thUw3TIp4z+eQTuYNlX48jvTzIeS0KoOYY/ztL+6sLex9h2MIXE+SdRzgZiFFJ3llKv9H9QqIfaldsAq/wWYfey8cFQY97wFtWNvjcZAU15nioeimPdfFHpsafYEA7PpI9QpRmxLSX/taiRO7EemL/T2svWkF3KF0zP/65+dapfupBrOMHOJkHfUJxHH5kBI79O3Me5Y/RkE+Yrfmw6HYYeEEKWJnNOAm22GyJ9Pw4YBYt1iRV7cNV+JO8tNX1dApce3Q789e7+AZzAzUkjv7QXO6CcGShq8ooRXLVhxXTsuqFoU0iw4DJ9yDGkSdGKCprhSfSDM1M45shrlMaHGUoza1BGNL4JxGx7uP2WrvnpjN1arE+inoBcr/b9ItlkURIqqZQaEV/dHIRXAupO9IoEZMWG2ZvZG4CD951hRwFXEBdIxR6h+SeOwFRN7qSDdZOr7dxh+bpmHJCiagorKjBwqzPml/MutVlx4tY28FSIJqYFdEs41mu4pRzFXiEAvhHZ1ETi2oTRrzipVpQWAwvGhAzZOkYqII28oKgeZm/6tP5O+huC1XvqCEuYXrJeOyK9sT3No5XKAYYNyiVuMabR1M/kkdXjlusd3JDVF3mWobqirLbVQVz0qx2uYA6foaGqEwDPXR9KqaRAUcs2O0A/3rv44snXKVwiUNUc1AunC8wyD4c6bF+SnUhBbrcIzz5rFG6hl4bKYDZJUaRVAGCPTjMrCMoseVnkGg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(70206006)(82310400005)(8676002)(81166007)(70586007)(4326008)(356005)(40460700003)(8936002)(54906003)(110136005)(5660300002)(508600001)(86362001)(36860700001)(316002)(966005)(2906002)(2616005)(336012)(47076005)(83380400001)(426003)(36756003)(6666004)(7696005)(16526019)(186003)(1076003)(26005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 02:29:59.0358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd9703a-fc82-48b8-3828-08da2e3f2697 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT019.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3541 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Introduce the AMD P-State unit test module design and implementation. Signed-off-by: Meng Li --- Documentation/admin-guide/pm/amd-pstate.rst | 85 +++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 83b58eb4ab4d..dbcc50e973f9 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -182,6 +182,7 @@ to the ``struct sugov_cpu`` that the utilization update belongs to. Then, ``amd-pstate`` updates the desired performance according to the CPU scheduler assigned. +.. _processor_support: Processor Support ======================= @@ -282,6 +283,8 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= +.. _shared_mem: + ``shared_mem`` Use a module param (shared_mem) to enable related processors manually with **amd_pstate.shared_mem=1**. @@ -393,6 +396,85 @@ about part of the output. :: CPU_005 712 116384 39 49 166 0.7565 9645075 2214891 38431470 25.1 11.646 469 2.496 kworker/5:0-40 CPU_006 712 116408 39 49 166 0.6769 8950227 1839034 37192089 24.06 11.272 470 2.496 kworker/6:0-1264 +Unit Tests for amd-pstate +------------------------- + +``amd-pstate-ut`` is a test module for testing the ``amd-pstate`` driver. + + * It can help all users to verify their processor support (SBIOS/Firmware or Hardware). + + * Kernel can have a basic function test to avoid the kernel regression during the update. + + * We can introduce more functional or performance tests to align the result together, it will benefit power and performance scale optimization. + +1. Test case decriptions + + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | Index | Functions | Description | + +=========+================================+====================================================================================+ + | 0 | aput_acpi_cpc || Check whether the _CPC object is present in SBIOS. | + | | || | + | | || The detail refer to `Processor Support `_. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 1 | aput_check_enabled || Check whether AMD P-State is enabled. | + | | || | + | | || AMD P-States and ACPI hardware P-States always can be supported in one processor. | + | | | But AMD P-States has the higher priority and if it is enabled with | + | | | :c:macro:`MSR_AMD_CPPC_ENABLE` or ``cppc_set_enable``, it will respond to the | + | | | request from AMD P-States. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 2 | aput_check_perf || Check if the each performance values are reasonable. | + | | || highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 3 | aput_check_freq || Check if the each frequency values and max freq when set support boost mode | + | | | are reasonable. | + | | || max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 | + | | || If boost is not active but supported, this maximum frequency will be larger than | + | | | the one in ``cpuinfo``. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + +#. How to execute the tests + + We use test module in the kselftest frameworks to implement it. + We create amd-pstate-ut module and tie it into kselftest.(for + details refer to Linux Kernel Selftests [4]_). + + 1. Build :: + + jasminemeng@jasmine-meng:~/amd-brahma$ cd linux + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make modules M=tools/testing/selftests/amd-pstate/amd-pstate-ut + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.o + MODPOST tools/testing/selftests/amd-pstate/amd-pstate-ut/Module.symvers + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.mod.o + LD [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + BTF [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests + + #. Installation & Steps :: + + jasmine@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests install INSTALL_PATH=~/kselftest + jasmine@jasmine-meng:~$ sudo ./kselftest/run_kselftest.sh -c amd-pstate + TAP version 13 + 1..1 + # selftests: amd-pstate: amd-pstate-ut.sh + # amd-pstate-ut: ok + ok 1 selftests: amd-pstate: amd-pstate-ut.sh + + #. Results :: + + jasmine@jasmine-meng:~$ dmesg | grep "amd-pstate-ut" | tee log.txt + [76697.480217] amd-pstate-ut: loaded. + [76697.480222] amd-pstate-ut: ****** Begin 1 acpi_cpc_valid ****** + [76697.480227] amd-pstate-ut: ****** End 1 acpi_cpc_valid ****** + [76697.480228] amd-pstate-ut: ****** Begin 2 check_enabled ****** + [76697.480253] amd-pstate-ut: ****** End 2 check_enabled ****** + [76697.480255] amd-pstate-ut: ****** Begin 3 check_perf ****** + [76697.480554] amd-pstate-ut: ****** End 3 check_perf ****** + [76697.480556] amd-pstate-ut: ****** Begin 4 check_freq ****** + [76697.480558] amd-pstate-ut: ****** End 4 check_freq ****** + [76697.480559] amd-pstate-ut: all 4 tests passed + [76697.482507] amd-pstate-ut: unloaded. + Reference =========== @@ -405,3 +487,6 @@ Reference .. [3] Processor Programming Reference (PPR) for AMD Family 19h Model 51h, Revision A1 Processors https://www.amd.com/system/files/TechDocs/56569-A1-PUB.zip + +.. [4] Linux Kernel Selftests, + https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html