From patchwork Wed May 4 15:04:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 569443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C53C433F5 for ; Wed, 4 May 2022 15:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351857AbiEDPKb (ORCPT ); Wed, 4 May 2022 11:10:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351856AbiEDPK3 (ORCPT ); Wed, 4 May 2022 11:10:29 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9A621822; Wed, 4 May 2022 08:06:52 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id i5so2413937wrc.13; Wed, 04 May 2022 08:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j014OwZQ/1Vr0LeTFnisQQ4MbndJvNCQ2vkGTTx6Wm0=; b=MUbOq6kq6abBYIo/GOfrvhDWPCv5+2w5l4XNuc+KzOKM4dupLugIG5cg01w/KOejsl bJOMuFd7dzNtaNfq8Idm8hJA4yG1HuWA/BxGVt2JWc7ObSrwcvDph3LsRDgNoc/zHSCU +UaNqQlLdHjR3/Aiye4osJ6+Y4wbtFjSpUEkFIeaVKadmVp/Ft5KRIePEg0JPfpoE8GO Fm/JDjDaWtebq+oYzlx9eyPlT7xgNwj6U3JgO13icWwvXlFPnmhPPTyrm61KYX3Lqa7y YuvuG9yDr5ix7s+axc/OsOobgmgKmxH+vWO7mkk5G4c2nZbSsbK7YI971vTKhgjDkVXj XCeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j014OwZQ/1Vr0LeTFnisQQ4MbndJvNCQ2vkGTTx6Wm0=; b=P6RTKCY3IUZai4DyjW/1thNZCIlnFaWs0BwcvhxBI2TsRi4JuvxQk2loVlT8d6qHgl ipzH0ds0zqs+3ICv9mjsCHOTKDJWqGx1/XQ0qadLm8dP5+2GwOmCcWeSGoPs26xaOtgM qxzADV87LBqejMCmTzsVPgC6syk+37VX7jCKVRnJucFul0MFnYiAouO14FIF9Gtk6boV L7S/8SJPeThxADIarMobh1PFVLbVUIz3ORaEua77dvJFuOsrDPvIg8zPpYxSYdb1M3Fh +QT7IjLvPHRAlbAtU4SP5TVb76DrqmVZeOee/3di7LnDPdY1k33GUHljOSzYBSFv0l+f f1mQ== X-Gm-Message-State: AOAM530VrjyvOGqToc+wfTg5Xcn546rKMSmqnAyOb/HMwwC5FwbmyLmc DNYz7lnyHNZtFbTAlm+blgU= X-Google-Smtp-Source: ABdhPJxIUgfQt1O/25Wc1e25VugPL6xYArndoYjz4VAGytLufnQCymwjH8L9z/PYbw3BjlgMG/MxNg== X-Received: by 2002:adf:e310:0:b0:20c:7894:99ad with SMTP id b16-20020adfe310000000b0020c789499admr5864717wrj.73.1651676811090; Wed, 04 May 2022 08:06:51 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id q14-20020adfaa4e000000b0020c5253d91fsm12143596wrd.107.2022.05.04.08.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:06:50 -0700 (PDT) From: Markuss Broks To: pavel@ucw.cz Cc: Markuss Broks , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Christophe JAILLET , Lad Prabhakar , Linus Walleij , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v6 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Wed, 4 May 2022 18:04:10 +0300 Message-Id: <20220504150457.5626-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504150457.5626-1-markuss.broks@gmail.com> References: <20220504150457.5626-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Reviewed-by: Andy Shevchenko Signed-off-by: Markuss Broks --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Wed May 4 15:04:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 570636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7D7C433FE for ; Wed, 4 May 2022 15:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351870AbiEDPKe (ORCPT ); Wed, 4 May 2022 11:10:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351865AbiEDPKd (ORCPT ); Wed, 4 May 2022 11:10:33 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3F8121822; Wed, 4 May 2022 08:06:56 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 1-20020a05600c248100b00393fbf11a05so3391039wms.3; Wed, 04 May 2022 08:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yb/evyWqaNixsLW2kxwJWCdv52JEaXEGCeVAcoqx36g=; b=UoJRUOku+Y5L4dmp7tDz9wPK5709yjvuajXhr+DZmwvqcJieFzkkO1qUpNnwlAJN8W CXVuT1gyUNPyGr1foBcskQwExbC3ZhWTSMRZkL2nzQRKdtKDoscDeofCxtnz3ZiSYzaV T31f6NnQ7iBiaUcZg6+St17jbrSuxrkjdQ/EPdI8ejQQF2gaPExkw1FwGuoMdY2CEHuq HkVtcdc3RbnQQZDz1GZMvwrAqSzm1KZ1KWlRk8nox1MgsePF0e2Tp034hdMGu+mMXgcL ift+Jaokypbs9waLHaYQDKOEDmV3J/Fhwm1yldyuA80+l3ripsWJbqQ/Ae24aKTGHTpW j53A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yb/evyWqaNixsLW2kxwJWCdv52JEaXEGCeVAcoqx36g=; b=wQ1Xl/QvApMijcK1xb3gm+2Xh+hmSV7Y4sPmJnS9IcO8NdKY9RkBeUPBqxI5plqfEx W5boXDuipy9X8w1QCn51z25wosHR9eZ4jIsABOGUzmfQqsMvkkWZN4vKF+4le+YTuzaj bJXf/ILL/eWLGC7hlGa461PP9BG0/xkzElSEMQ/azuG2ajHwtbGzK7vF9zp3ohHTfpD5 BAMYciuu9h9uNqmz+HMS6SHnb+GY/1b1g6EPmo2+Jsuy+zUSY2XEVpXFXJAdn1AbWsA2 TmPsVWm0puxxHUP77HBzz/tJLtf6kx59AtcbFivOo3vOQx50DRxmeRWNgx+ngNNLuQ3T 30OQ== X-Gm-Message-State: AOAM532Z41NrvmlYILK3t+9RRbBC9GnXK2pQ66yzx/0CHid1WgH9LIb4 8QMgm7A9trE9fnWUmWLRZIc= X-Google-Smtp-Source: ABdhPJyXHyoVksCuq8+mhIBxrsoR9GlQ7k+6D18WjCHanh4pORoyL0mATlWtjWk6Q5v30M+bi4swAA== X-Received: by 2002:a1c:2c6:0:b0:38f:f280:caa2 with SMTP id 189-20020a1c02c6000000b0038ff280caa2mr8031383wmc.87.1651676815484; Wed, 04 May 2022 08:06:55 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id q14-20020adfaa4e000000b0020c5253d91fsm12143596wrd.107.2022.05.04.08.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:06:55 -0700 (PDT) From: Markuss Broks To: pavel@ucw.cz Cc: Markuss Broks , Rob Herring , Rob Herring , Krzysztof Kozlowski , Linus Walleij , Lad Prabhakar , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v6 2/2] leds: ktd2692: Make aux-gpios optional Date: Wed, 4 May 2022 18:04:11 +0300 Message-Id: <20220504150457.5626-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504150457.5626-1-markuss.broks@gmail.com> References: <20220504150457.5626-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Also pick up maintenance for the LED driver and the yaml bindings. Reviewed-by: Rob Herring Signed-off-by: Markuss Broks --- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2db49ea7ae55..8ef5667a1d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt M: John Hawley diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index f341da1503a4..01ceea83af67 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -284,9 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return ret; } - led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - ret = PTR_ERR_OR_ZERO(led->aux_gpio); - if (ret) { + led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS); + if (IS_ERR(led->aux_gpio)) { + ret = PTR_ERR(led->aux_gpio); dev_err(dev, "cannot get aux-gpios %d\n", ret); return ret; }