From patchwork Wed May 4 15:38:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 569440 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531D4C35275 for ; Wed, 4 May 2022 15:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352592AbiEDPnn (ORCPT ); Wed, 4 May 2022 11:43:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352629AbiEDPmG (ORCPT ); Wed, 4 May 2022 11:42:06 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47AE4167CB; Wed, 4 May 2022 08:38:30 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id q23so2583630wra.1; Wed, 04 May 2022 08:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZT7VKniHc2GWnckoL6MlPZLbnEyYu3dBdYD4+s+IxsM=; b=dpUs+ULOSWyg1nkmdz2a1ekAEjlgRxz1EaV5vhyqvt29kS99LjZp/ZDdWezFs/sSvy TD8Hp6WhR5vsZsUj5OGNfsKpBmzUbNryuAww6dlwu3YvCFT2dYKg5RedoDy5CNx8k+jP ZM5VwqO233lv+FJ0xywuH3jRU1DejtovShCPMXSJgy1lbql/5ASpgtVFwOT7Rn+0+TJ3 dtKdhjSN5M/5JHh0BfrWigFESWo49Nao2LiDqj10u5YqdTJ2PLav4PCK+20pdRB45WHO PMsWb4I9yYkiew1mdYtOU9osqLrKhy58UbMtzDkLPyYRT6KCGiiyoMrAdKFJ8894fmDD dRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZT7VKniHc2GWnckoL6MlPZLbnEyYu3dBdYD4+s+IxsM=; b=Kp3vzEYw0W+2V10eMFm0jsIihU/zX3ORqSgvtRxtDXv6P6ddao7VpWB0JiV2yYXjJ9 w6HHR1rTJ0BJHfuflwkCfEYYi5Vuq5eK4XKOg2c5qos2tG6CNCVZfe0/mYeiJz3uxUCn Z90VFK8B9B8wyVyVbX4jx1H3X+uc6yAoKU6jsVayNCpSxD6NdgeB/oIU2pwWCzdjnxRa cKYJ8CqpamMbi65Z4Xa2pmWXIp2H9qgCII4dU1OcFf+9OS3bbZ1Jq5/17o0kARRaltKX quQlSSn76lCpa+P0jCiluMM03aWFPV/JgT1spDO6oCBSSLJbJZ/UpROLW5SD7poTLfjg JC6w== X-Gm-Message-State: AOAM533bOc2CfLsYqyvVZUphK8p1Gec6pu2FT0RkODtz3tr5ns+unmTr mv7a5Zg5XF2Sx5Bt8Ug+E3Y= X-Google-Smtp-Source: ABdhPJwWCHDnF8fQV4UIGI9GatqjbFQVZx+ARmoJBoUk5HfKaG7eXRSa1s12nkehFaqewlwjlewNkA== X-Received: by 2002:a5d:4ac6:0:b0:20c:561d:5aed with SMTP id y6-20020a5d4ac6000000b0020c561d5aedmr15875913wrs.318.1651678708760; Wed, 04 May 2022 08:38:28 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id e18-20020adf9bd2000000b0020c5253d8besm11792725wrc.10.2022.05.04.08.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:38:28 -0700 (PDT) From: Markuss Broks To: pavel@ucw.cz Cc: Markuss Broks , Rob Herring , Rob Herring , Krzysztof Kozlowski , Christophe JAILLET , Lad Prabhakar , Linus Walleij , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v6 (corrected v2) 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Wed, 4 May 2022 18:38:10 +0300 Message-Id: <20220504153814.11108-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504153814.11108-1-markuss.broks@gmail.com> References: <20220504153814.11108-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Reviewed-by: Rob Herring Signed-off-by: Markuss Broks --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Wed May 4 15:38:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 569441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A28DC4321E for ; Wed, 4 May 2022 15:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352573AbiEDPmM (ORCPT ); Wed, 4 May 2022 11:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352431AbiEDPmK (ORCPT ); Wed, 4 May 2022 11:42:10 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77760165BB; Wed, 4 May 2022 08:38:34 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id q20so1097116wmq.1; Wed, 04 May 2022 08:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CGfHsjidANyyHV7qeZ5govjIF6ESMs4sMWxP9NbcJlA=; b=HKTlhRQHU8wuB7Yd31wODGwwRr40WNkmFOUi8rsW6a8U0AAakmd/S8xFQCyz9ygkUq KkbnO3jCpSaaRv9Cu18gBVEYgWedbtQIQ7v1QZzQGuem2lXTH4pVkFSZ8ahpG4gb8Yfe Owfjb/312vx0W+x6paggOO9TZSNp+AsCeZAPybwqxItFZ26jUv0nBmX5jgh1lR3B8Dx4 9ZhrgldNc1u5aC2kqKViBqEhO0M1dij+sKZGyYAviJF3LCi6h1y/5MMHTnJIcJWE9QWE Ouvdhmn2ZGLH46qpy5POC5U0eZrN8FnHYvns7eKamBnzL/u+7NlTEPqxhMFs0LQw1Bn9 GFrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CGfHsjidANyyHV7qeZ5govjIF6ESMs4sMWxP9NbcJlA=; b=WPgaZNgsdEG5l3PZVQS/3V/XwMy09Vz3/f7tcmY2dquTfghzV0+kivFpDyZW7bo10h O9Yg2MwuzM1v/Jf0twwVOW3QwkQJiHLM/6R0+QU9IKdaLxB9baXSjSe7HVGJXvbX7LXx LZBErjZ/Ag8sH87DHkGiq3oz5INvzZ7Ja6q2D05P5EyhPBvUd0LU3brROlNwwUB9/8F+ u7r6OTRMDi0G2pigyX6fguuXqSCy2lRU7cPDjxcGATA/L97iWe67mfan5urTnu41HWMp 40tD/3Nkxq3XTgOIkOfYHwOKhrZ5IDar6Srddl3JkBzs+N6Z+ZfQnAY6JBsOf9Oz+ocM z24w== X-Gm-Message-State: AOAM533BjOB2IGAkuez0/R3xd/RXDI6tNvAaEKg3LS2YGL/u0Rc31WkA 19AHX+UUC9kQ5atihfFazN4= X-Google-Smtp-Source: ABdhPJzh6RAR1drthFT0i0kt4pF+YyMWOWIHuCbuIALa+gZThkRIq2l8IX27Il5BYGhR0GytSkfC7w== X-Received: by 2002:a1c:2706:0:b0:391:822c:83da with SMTP id n6-20020a1c2706000000b00391822c83damr46858wmn.100.1651678713085; Wed, 04 May 2022 08:38:33 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id e18-20020adf9bd2000000b0020c5253d8besm11792725wrc.10.2022.05.04.08.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:38:32 -0700 (PDT) From: Markuss Broks To: pavel@ucw.cz Cc: Markuss Broks , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Linus Walleij , Christophe JAILLET , Lad Prabhakar , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v6 (corrected v2) 2/2] leds: ktd2692: Make aux-gpios optional Date: Wed, 4 May 2022 18:38:11 +0300 Message-Id: <20220504153814.11108-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504153814.11108-1-markuss.broks@gmail.com> References: <20220504153814.11108-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Also pick up maintenance for the LED driver and the yaml bindings. Reviewed-by: Andy Shevchenko Signed-off-by: Markuss Broks --- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2db49ea7ae55..8ef5667a1d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt M: John Hawley diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index f341da1503a4..01ceea83af67 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -284,9 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return ret; } - led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - ret = PTR_ERR_OR_ZERO(led->aux_gpio); - if (ret) { + led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS); + if (IS_ERR(led->aux_gpio)) { + ret = PTR_ERR(led->aux_gpio); dev_err(dev, "cannot get aux-gpios %d\n", ret); return ret; }