From patchwork Tue Apr 19 01:14:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Solomon Tan X-Patchwork-Id: 564305 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD92DC433EF for ; Tue, 19 Apr 2022 01:15:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245288AbiDSBRx (ORCPT ); Mon, 18 Apr 2022 21:17:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245298AbiDSBRv (ORCPT ); Mon, 18 Apr 2022 21:17:51 -0400 Received: from mail-0301.mail-europe.com (mail-0301.mail-europe.com [188.165.51.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE8563ED for ; Mon, 18 Apr 2022 18:15:06 -0700 (PDT) Date: Tue, 19 Apr 2022 01:14:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=protonmail2; t=1650330895; bh=wzjLv5GUoM7KeGIIy7AzLAwk4fQSO5fQfUO1CoZX6mE=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=LiOp4kU0sz/rECP1P5L+HAWzzUAn0yRxycXak9G9oVdeVD69ewZ8Cx8c6Ks0d57NM tHPEI1YJN++9FapXLDzPo0O498sTWj3MR9oPslAEwEDIEhh7nacD8J7MuAaA2Xt+6r r6exslw4i+WL1Yh74CxU5Pu7a7NC64PgaeuFW8a/54zeMZVva6wjEiDudqTqOGvyTL ++cIs6teTsdqDLWvQOpr6ADKBJSgrBqWvHY82xW1GTq/Lg1B03EBd/lt2ZJoJAsD1n uZcZDMzmD/TpwqBs5qJ4k4WIFbvIGOfZVrp+lWqxwjUD35Tus75DjbxiBdbuObKbGK XVtufnavEu+Iw== To: linux-wireless@vger.kernel.org From: Solomon Tan Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, rdunlap@infradead.org, gregkh@linuxfoundation.org, miriam.rachel.korenblit@intel.com, johannes.berg@intel.com, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, kvalo@kernel.org, luciano.coelho@intel.com, Solomon Tan Reply-To: Solomon Tan Subject: [PATCH 1/3] iwlwifi: Remove prohibited spaces Message-ID: <20220419011340.14954-2-solomonbstoner@protonmail.ch> In-Reply-To: <20220419011340.14954-1-solomonbstoner@protonmail.ch> References: <20220419011340.14954-1-solomonbstoner@protonmail.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This patch addresses the error from checkpatch.pl regarding the presence of prohibited spaces. Signed-off-by: Solomon Tan --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.35.3 diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c index 9040da3dcce3..c11088fecc16 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c @@ -81,7 +81,7 @@ static const u16 iwl_nvm_channels[] = { /* 2.4 GHz */ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, /* 5 GHz */ - 36, 40, 44 , 48, 52, 56, 60, 64, + 36, 40, 44, 48, 52, 56, 60, 64, 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 144, 149, 153, 157, 161, 165 }; diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c index 49898fd99594..5e7f2c64937e 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c @@ -214,9 +214,9 @@ static ssize_t iwl_dbgfs_set_nic_temperature_read(struct file *file, int pos; if (!mvm->temperature_test) - pos = scnprintf(buf , sizeof(buf), "disabled\n"); + pos = scnprintf(buf, sizeof(buf), "disabled\n"); else - pos = scnprintf(buf , sizeof(buf), "%d\n", mvm->temperature); + pos = scnprintf(buf, sizeof(buf), "%d\n", mvm->temperature); return simple_read_from_buffer(user_buf, count, ppos, buf, pos); } @@ -261,7 +261,7 @@ static ssize_t iwl_dbgfs_set_nic_temperature_write(struct iwl_mvm *mvm, mvm->temperature = temperature; } IWL_DEBUG_TEMP(mvm, "%sabling debug set temperature (temp = %d)\n", - mvm->temperature_test ? "En" : "Dis" , + mvm->temperature_test ? "En" : "Dis", mvm->temperature); /* handle the temperature change */ iwl_mvm_tt_handler(mvm); @@ -291,7 +291,7 @@ static ssize_t iwl_dbgfs_nic_temp_read(struct file *file, if (ret) return -EIO; - pos = scnprintf(buf , sizeof(buf), "%d\n", temp); + pos = scnprintf(buf, sizeof(buf), "%d\n", temp); return simple_read_from_buffer(user_buf, count, ppos, buf, pos); } From patchwork Tue Apr 19 01:15:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Solomon Tan X-Patchwork-Id: 563949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41527C433EF for ; Tue, 19 Apr 2022 01:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245170AbiDSBSI (ORCPT ); Mon, 18 Apr 2022 21:18:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239603AbiDSBSG (ORCPT ); Mon, 18 Apr 2022 21:18:06 -0400 Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A31B2E68E for ; Mon, 18 Apr 2022 18:15:26 -0700 (PDT) Date: Tue, 19 Apr 2022 01:15:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=protonmail2; t=1650330923; bh=1GFGYWgcMmJP4l5OtKG/5cs+LyA9/eYC0MJ8P1m8xlg=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=V+DXe/SnQB47XqyyhSfe7jCE5WBce8ni5iPME4kgFFAvo0+dZP3KIJVm8QSJ+H7tT AGb3A+ldMIZIfgOr2ldlu+SxgV6JR2M9KJEeLRfCwKUmM7M+L0aubzfKuhYLX7cali 9X3ElMImvt1BmUTq8ye/MvYH0iuM1v/GhbyWARKXPRptFqTFywqqom4En/YguWe8SD av4eVE4topVUaspWjpg7z2ox8eWlphHAhYxIBQbjCan+1GpWjS0EA129FwKWBMivDz plVbUdBUJYhJTHE88+z5mZnCrSYWB1EBFIcfAKJDEU5YhNkXXS57IZ+msk3MjY88es pU2llwlRsWYdg== To: linux-wireless@vger.kernel.org From: Solomon Tan Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, rdunlap@infradead.org, gregkh@linuxfoundation.org, miriam.rachel.korenblit@intel.com, johannes.berg@intel.com, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, kvalo@kernel.org, luciano.coelho@intel.com, Solomon Tan Reply-To: Solomon Tan Subject: [PATCH 2/3] iwlwifi: Add required space before open '(' Message-ID: <20220419011340.14954-3-solomonbstoner@protonmail.ch> In-Reply-To: <20220419011340.14954-1-solomonbstoner@protonmail.ch> References: <20220419011340.14954-1-solomonbstoner@protonmail.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This patch addresses the error from checkpatch.pl that a space is required before an open parenthesis. Signed-off-by: Solomon Tan --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.35.3 diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index e842816134f1..bae270893eac 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -1016,7 +1016,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm) ret = iwl_read_ppag_table(&mvm->fwrt, &cmd, &cmd_size); /* Not supporting PPAG table is a valid scenario */ - if(ret < 0) + if (ret < 0) return 0; IWL_DEBUG_RADIO(mvm, "Sending PER_PLATFORM_ANT_GAIN_CMD\n"); From patchwork Tue Apr 19 01:15:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Solomon Tan X-Patchwork-Id: 564304 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFA3C433F5 for ; Tue, 19 Apr 2022 01:15:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245241AbiDSBSa (ORCPT ); Mon, 18 Apr 2022 21:18:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245168AbiDSBS2 (ORCPT ); Mon, 18 Apr 2022 21:18:28 -0400 X-Greylist: delayed 77 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 18 Apr 2022 18:15:47 PDT Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747F42E699 for ; Mon, 18 Apr 2022 18:15:47 -0700 (PDT) Date: Tue, 19 Apr 2022 01:15:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=protonmail2; t=1650330945; bh=vGPe9oyRu6z4m0OTxHe6LWHmTuENY6PMjtLMb1ZCtVw=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID; b=iy2tFF5ff1tGp9AWAravB8fvnSbPUavEzLcdhPxmkQO/9XqmbbGbQsm3JxgP1DSsl WVnfbamtD07T8ZiMB/nBGA/qkv1GejKTg4KJyj2fSsRoGpgQyn7uJDli4z+l75IaST 4LMW+BDl3xq2eufBO9NSeAMi4BoIURyVjVO0bBxkbpZVY3eMwCZkrAMJPruClqeZv0 ZN2tBoBFVXx5iCY61lzrHJsMQroMaUeCLQQLehbgAnaS9RYL9/k6u+cC2sTigYQ5cJ 8/azlLvpIWOZqO0/KumJDor3T9Y2V5xQZZvKK3nUxPCT+Enx1CcCi9Pkui3sWWilbi p52mVJi0yCLAg== To: linux-wireless@vger.kernel.org From: Solomon Tan Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, rdunlap@infradead.org, gregkh@linuxfoundation.org, miriam.rachel.korenblit@intel.com, johannes.berg@intel.com, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, kvalo@kernel.org, luciano.coelho@intel.com, Solomon Tan Reply-To: Solomon Tan Subject: [PATCH 3/3] iwlwifi: Replace space with tabs as code indent Message-ID: <20220419011340.14954-4-solomonbstoner@protonmail.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This patch addresses the checkpatch.pl warning that code indent should use tabs. Signed-off-by: Solomon Tan --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.35.3 diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h index c6bc85d4600a..0e5ba208e606 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h @@ -1305,7 +1305,7 @@ static inline bool iwl_mvm_is_csum_supported(struct iwl_mvm *mvm) { return fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_CSUM_SUPPORT) && - !IWL_MVM_HW_CSUM_DISABLE; + !IWL_MVM_HW_CSUM_DISABLE; } static inline bool iwl_mvm_is_mplut_supported(struct iwl_mvm *mvm) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c b/drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c index 080a1587caa5..0f7fa6032c66 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c @@ -104,9 +104,9 @@ static const struct wiphy_vendor_command iwl_mvm_vendor_commands[] = { }; enum iwl_mvm_vendor_events_idx { - /* 0x0 - 0x3 are deprecated */ - IWL_MVM_VENDOR_EVENT_IDX_ROAMING_FORBIDDEN = 4, - NUM_IWL_MVM_VENDOR_EVENT_IDX + /* 0x0 - 0x3 are deprecated */ + IWL_MVM_VENDOR_EVENT_IDX_ROAMING_FORBIDDEN = 4, + NUM_IWL_MVM_VENDOR_EVENT_IDX }; static const struct nl80211_vendor_cmd_info