From patchwork Sun Apr 17 16:51:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562964 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E279C433EF for ; Sun, 17 Apr 2022 16:52:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234422AbiDQQzI (ORCPT ); Sun, 17 Apr 2022 12:55:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234416AbiDQQzH (ORCPT ); Sun, 17 Apr 2022 12:55:07 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AE6C13F64; Sun, 17 Apr 2022 09:52:30 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id y85so2785767iof.3; Sun, 17 Apr 2022 09:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HDfxEj2AIXBVPrxK8VdAYTkqepHnxXEHBD5DZE+il6M=; b=I3bQ32MfT4w2EcoC7Q8CaI9h+g8YTFICZeDfpIOfc1kDdKQoiCdXujVGNjoCQ5axx6 EihRbv5ZFrEIZnmP7RjX8GlyrL78ylp2HtZCfQrBXkSHDWPJmXQaV25wWMG0eT2QGT0S ICMloa5LCOAFdRyq2I4uZu3yTDJzM/ogUUjrxXJumC9C3YUH1zHJ2Al6VzqHf24WpCxD OjguheJVO9jLMQZiyqcjPw+zip2EiYZTLS/boHQFANK8p7r9m5T1ydeRfFvxZ7/IgXI8 6em6UBqhxGsZVZsgF0iS/TyTqbzARLgZVa5SAQaQrefTwynyZvvdGYamVaqfv3yGUDPy n0IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HDfxEj2AIXBVPrxK8VdAYTkqepHnxXEHBD5DZE+il6M=; b=WelmYscncSjVXA957bVxnE4MXUG3Fwb4oH22woA0blBiaH60Df0ebz7FAO0eUmCa7k 331HFJxFfexb8GxdB2s53YnYjLC5tiRh5gOgCF35ppSn4Us+pq02dNsSNAOREKeqnxTm Gf274nW/v4UkcwSuwnyI6pG45KlOMOISh4h7IoIJo4O21Jb1z6Xhjw+4oCrybbsSqzFy p3Zgu9frozDslbwymy6aJ1cCSW0PEIvkZarFxjybu5L7KknUATP+MiMu73xhEnIvLcQ8 2/s4UGNItQIIJuaxuGh23wHpYPLjHwCm+u5iGRMN6vPJzjUA+VpnMPRt0Qn1hBmjnORf ixNw== X-Gm-Message-State: AOAM532nzyfu9hqL1E4GaGxx47EIuTpP8IJlUH2ZvyYz/vNHx6WiaSrX lqpfY1gz11+4Rm3BZeFd6Bw= X-Google-Smtp-Source: ABdhPJwdMCn7xa04OnLDn/ZbAT53D07vO5lfJ8aVlrta4VUcy8lYjEgoHESNn1gzyvz3q9nksfVEqQ== X-Received: by 2002:a05:6638:134e:b0:323:65d0:99fe with SMTP id u14-20020a056638134e00b0032365d099femr3427182jad.131.1650214349865; Sun, 17 Apr 2022 09:52:29 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id y8-20020a920908000000b002cc18763721sm1869720ilg.74.2022.04.17.09.52.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:52:29 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 01/15] gpio: use raw spinlock for gpio chip shadowed data Date: Mon, 18 Apr 2022 00:51:54 +0800 Message-Id: <20220417165208.39754-1-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org In case of PREEMPT_RT, there is a raw_spinlock -> spinlock dependency as the lockdep report shows. __irq_set_handler irq_get_desc_buslock __irq_get_desc_lock raw_spin_lock_irqsave(&desc->lock, *flags); // raw spinlock get here __irq_do_set_handler mask_ack_irq dwapb_irq_ack spin_lock_irqsave(&gc->bgpio_lock, flags); // sleep able spinlock irq_put_desc_busunlock Replace with a raw lock to avoid BUGs. This lock is only used to access registers, and It's safe to replace with the raw lock without bad influence. [ 15.090359][ T1] ============================= [ 15.090365][ T1] [ BUG: Invalid wait context ] [ 15.090373][ T1] 5.10.59-rt52-00983-g186a6841c682-dirty #3 Not tainted [ 15.090386][ T1] ----------------------------- [ 15.090392][ T1] swapper/0/1 is trying to lock: [ 15.090402][ T1] 70ff00018507c188 (&gc->bgpio_lock){....}-{3:3}, at: _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090470][ T1] other info that might help us debug this: [ 15.090477][ T1] context-{5:5} [ 15.090485][ T1] 3 locks held by swapper/0/1: [ 15.090497][ T1] #0: c2ff0001816de1a0 (&dev->mutex){....}-{4:4}, at: __device_driver_lock+0x98/0x104 [ 15.090553][ T1] #1: ffff90001485b4b8 (irq_domain_mutex){+.+.}-{4:4}, at: irq_domain_associate+0xbc/0x6d4 [ 15.090606][ T1] #2: 4bff000185d7a8e0 (lock_class){....}-{2:2}, at: _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090654][ T1] stack backtrace: [ 15.090661][ T1] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.10.59-rt52-00983-g186a6841c682-dirty #3 [ 15.090682][ T1] Hardware name: Horizon Robotics Journey 5 DVB (DT) [ 15.090692][ T1] Call trace: ...... [ 15.090811][ T1] _raw_spin_lock_irqsave+0x1c/0x28 [ 15.090828][ T1] dwapb_irq_ack+0xb4/0x300 [ 15.090846][ T1] __irq_do_set_handler+0x494/0xb2c [ 15.090864][ T1] __irq_set_handler+0x74/0x114 [ 15.090881][ T1] irq_set_chip_and_handler_name+0x44/0x58 [ 15.090900][ T1] gpiochip_irq_map+0x210/0x644 ...... Changelog: v1 -> v2: - Reduce the useless stacktrace. - Split to series of patches Link: https://lore.kernel.org/all/20220415165505.30383-1-schspa@gmail.com/ Signed-off-by: Schspa Shi --- drivers/gpio/gpio-mmio.c | 22 +++++++++++----------- include/linux/gpio/driver.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c index c335a0309ba3..d9dff3dc92ae 100644 --- a/drivers/gpio/gpio-mmio.c +++ b/drivers/gpio/gpio-mmio.c @@ -220,7 +220,7 @@ static void bgpio_set(struct gpio_chip *gc, unsigned int gpio, int val) unsigned long mask = bgpio_line2mask(gc, gpio); unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); if (val) gc->bgpio_data |= mask; @@ -229,7 +229,7 @@ static void bgpio_set(struct gpio_chip *gc, unsigned int gpio, int val) gc->write_reg(gc->reg_dat, gc->bgpio_data); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void bgpio_set_with_clear(struct gpio_chip *gc, unsigned int gpio, @@ -248,7 +248,7 @@ static void bgpio_set_set(struct gpio_chip *gc, unsigned int gpio, int val) unsigned long mask = bgpio_line2mask(gc, gpio); unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); if (val) gc->bgpio_data |= mask; @@ -257,7 +257,7 @@ static void bgpio_set_set(struct gpio_chip *gc, unsigned int gpio, int val) gc->write_reg(gc->reg_set, gc->bgpio_data); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void bgpio_multiple_get_masks(struct gpio_chip *gc, @@ -286,7 +286,7 @@ static void bgpio_set_multiple_single_reg(struct gpio_chip *gc, unsigned long flags; unsigned long set_mask, clear_mask; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); bgpio_multiple_get_masks(gc, mask, bits, &set_mask, &clear_mask); @@ -295,7 +295,7 @@ static void bgpio_set_multiple_single_reg(struct gpio_chip *gc, gc->write_reg(reg, gc->bgpio_data); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void bgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, @@ -347,7 +347,7 @@ static int bgpio_dir_in(struct gpio_chip *gc, unsigned int gpio) { unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); gc->bgpio_dir &= ~bgpio_line2mask(gc, gpio); @@ -356,7 +356,7 @@ static int bgpio_dir_in(struct gpio_chip *gc, unsigned int gpio) if (gc->reg_dir_out) gc->write_reg(gc->reg_dir_out, gc->bgpio_dir); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } @@ -387,7 +387,7 @@ static void bgpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) { unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); gc->bgpio_dir |= bgpio_line2mask(gc, gpio); @@ -396,7 +396,7 @@ static void bgpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) if (gc->reg_dir_out) gc->write_reg(gc->reg_dir_out, gc->bgpio_dir); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static int bgpio_dir_out_dir_first(struct gpio_chip *gc, unsigned int gpio, @@ -610,7 +610,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev, if (gc->bgpio_bits > BITS_PER_LONG) return -EINVAL; - spin_lock_init(&gc->bgpio_lock); + raw_spin_lock_init(&gc->bgpio_lock); gc->parent = dev; gc->label = dev_name(dev); gc->base = -1; diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 874aabd270c9..ff8247a19f57 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -445,7 +445,7 @@ struct gpio_chip { void __iomem *reg_dir_in; bool bgpio_dir_unreadable; int bgpio_bits; - spinlock_t bgpio_lock; + raw_spinlock_t bgpio_lock; unsigned long bgpio_data; unsigned long bgpio_dir; #endif /* CONFIG_GPIO_GENERIC */ From patchwork Sun Apr 17 16:51:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5860FC433F5 for ; Sun, 17 Apr 2022 16:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234431AbiDQQzZ (ORCPT ); Sun, 17 Apr 2022 12:55:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234429AbiDQQzX (ORCPT ); Sun, 17 Apr 2022 12:55:23 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18FD827173; Sun, 17 Apr 2022 09:52:48 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id y85so2786107iof.3; Sun, 17 Apr 2022 09:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3PxZRjr3wyeAKqstrnBd3HbjtR/5c3lDXuJSEUWG8pE=; b=oVzQU+ufinXD7bmpNBMXsPvaMURLdNBbCBjdFKox5iR8bKAeTZFeUJldZHySxCJTDq q3g56k5sp/hvW/OE7lPVpfQTn11LcgJ9TULWcLn8dId6542lkTGT/sHoCAJi/wdeqT6s lZ2cK6BQLMtCSaTSpBnqB3Yp+8al5q96vVFqy7EI9evsl519pmbNTV2bBTKwbTJ02YV/ 5td5b5sEc0BY/f0IyO4D1DZBEIEwIQwZWhFSf88UVqnoyu1Zgok01zw0OZ/0ycYkx402 cOlNktQVGey9EHsjCMkhkfEHYUxNvk0KOK9/1+1p9TLm1Pnf/EXjIvsm1EwFUceNls+Y KbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3PxZRjr3wyeAKqstrnBd3HbjtR/5c3lDXuJSEUWG8pE=; b=TyNQs4nou5+xMeBxscCcmLRJ/xzAM37K0Suz5Dkb2RUbBMAkdEm+b9L7YoQQPtHKC/ DYQAJ12Mdn1AFhng0FiHOW/JouD4rm1xOCHB0W6WUOSy/KHT917zIZQyQHYn8FB9USfV ZNluCdSc1yhN1mm33DTFX2THVTwQlB8PKY0uLPxV+gDB5/UUvtyQYOk9Q1mJ+HuMbfQi W+4SOsoSuHuWQZAycyuiRTz+vlOU6PX4W8Tlx8sTI9hRdQ5EJpZFtjFumBNnXN6JQ1k4 5qC3bpUSa4/ZmkCIYycED6GTdwt/0IQTG06stHzAXnKHQxzggEZWmr49vDdQDXnQxAD5 YgRg== X-Gm-Message-State: AOAM532N4AspgIasfDg8X0ahndWgNMWGnTRhkaTUOHHkF0m8sS61WI9g Pf27xfcYDoRrZ78/Lddxi50nE3z3wE3pLGyX X-Google-Smtp-Source: ABdhPJwMz2GALH4hX73Pnz+fsCqDst9DHZ/MyfAYdr/ZRJ3LlkO38bgaRzTIe1RckOqb+1MXSWf42A== X-Received: by 2002:a5d:8855:0:b0:651:fe8:47a8 with SMTP id t21-20020a5d8855000000b006510fe847a8mr3042681ios.84.1650214367514; Sun, 17 Apr 2022 09:52:47 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id c4-20020a6b4e04000000b00653e74540f0sm3130099iob.7.2022.04.17.09.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:52:47 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 02/15] pinctrl: nuvoton: npcm7xx: use raw_spin_lock_irqsave for bgpio_lock Date: Mon, 18 Apr 2022 00:51:55 +0800 Message-Id: <20220417165208.39754-2-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This lock is converted to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c index 9557fac5d11c..b2a0f11a658b 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c @@ -104,12 +104,12 @@ static void npcm_gpio_set(struct gpio_chip *gc, void __iomem *reg, unsigned long flags; unsigned long val; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val = ioread32(reg) | pinmask; iowrite32(val, reg); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void npcm_gpio_clr(struct gpio_chip *gc, void __iomem *reg, @@ -118,12 +118,12 @@ static void npcm_gpio_clr(struct gpio_chip *gc, void __iomem *reg, unsigned long flags; unsigned long val; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val = ioread32(reg) & ~pinmask; iowrite32(val, reg); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void npcmgpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) From patchwork Sun Apr 17 16:51:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562963 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63E6C433F5 for ; Sun, 17 Apr 2022 16:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234438AbiDQQzf (ORCPT ); Sun, 17 Apr 2022 12:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234429AbiDQQze (ORCPT ); Sun, 17 Apr 2022 12:55:34 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62C3B27146; Sun, 17 Apr 2022 09:52:58 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id c125so5142171iof.9; Sun, 17 Apr 2022 09:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+OwOsVwj0AcxMEF/6BJstkFWn8hxakPI1KDKnUQ4Lzg=; b=UunGbPJEiLCLNU919rHI7QhLrHG38Xr/bpbs4lj+86720GzjEZ/FTVpKjuiaulXL9O E2U9cXnDy817oQ5k6PYSEe0+uf/7Y8zQnfoH18lZ4EWB/0V7eszyJqHP9zL9dRS0a291 r1mzJfDJvHlK6WL0SHCzcBcWCYpod9PIolFJ5eCTFH8EUcWOkNVVOrKqc5TR+BRzxw2r l//TVmwvqeOtK84BUaf9oZGnv2/HtNasgBU4Nu/Cp7tGT4APo8SlMgFmEV3FMfFyiJDd vxGVdldaYz+FjlowKPrXgJgOZR/YXQUVscJ1DOSi1//WXJojKmdaXwfS93nXizQjkhLn JpAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+OwOsVwj0AcxMEF/6BJstkFWn8hxakPI1KDKnUQ4Lzg=; b=mc6XMGvvLRsp6woMS2OodWcKqWw7ew6bjk3kVzhFPZHnZDU09Hl4TT8cxwIrFB69PA 8Q/g7UoOSsc4YS8vjAB5icgmGUJ/sqEuH0At/GMstoDsoY78d5vZg1SIxwMD+qB8vgz6 5ufoqlmluWHY7NNg7A45cI3HsaCIuweD0i2UuaWol7FIV9BovpSbRXcS7OGISffRfJlL YPMlDDRZoVLJpXRzqoiTk/q9s0ag2fqKoxUWvpqwUMnbP81PH3te9ssMK0utTMYyyOt8 7s1RhGvonP5I7gSnSoI7iUUSYUrMyt41Nrt+3jsdDEEZWxg+IJ5lCjTkxueHc7P3nfNX YZYg== X-Gm-Message-State: AOAM532VTWNVBeQlQ/SLw8mPl6OvjX4vuEdijDk/CF6NdZ6Qyg0awsa0 HDmgvSiRtdJZ6L5ibYaiqLye8xI7JojOI1pb X-Google-Smtp-Source: ABdhPJxA4BLCU17xbWVxEJOu67pQzjppsMUw4X3TWe1gpZ6YQNY50y4bIGv9DZFUmEI4lCBaHGZ3/w== X-Received: by 2002:a02:970c:0:b0:326:f9ba:e6b1 with SMTP id x12-20020a02970c000000b00326f9bae6b1mr3187984jai.25.1650214377881; Sun, 17 Apr 2022 09:52:57 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id l13-20020a92700d000000b002caa6f61ed4sm5978555ilc.5.2022.04.17.09.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:52:57 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 03/15] gpio: tb10x: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:51:56 +0800 Message-Id: <20220417165208.39754-3-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-tb10x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c index 718a508d3b2f..de6afa3f9716 100644 --- a/drivers/gpio/gpio-tb10x.c +++ b/drivers/gpio/gpio-tb10x.c @@ -62,14 +62,14 @@ static inline void tb10x_set_bits(struct tb10x_gpio *gpio, unsigned int offs, u32 r; unsigned long flags; - spin_lock_irqsave(&gpio->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&gpio->gc.bgpio_lock, flags); r = tb10x_reg_read(gpio, offs); r = (r & ~mask) | (val & mask); tb10x_reg_write(gpio, offs, r); - spin_unlock_irqrestore(&gpio->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gpio->gc.bgpio_lock, flags); } static int tb10x_gpio_to_irq(struct gpio_chip *chip, unsigned offset) From patchwork Sun Apr 17 16:51:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50432C433F5 for ; Sun, 17 Apr 2022 16:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234451AbiDQQzu (ORCPT ); Sun, 17 Apr 2022 12:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234429AbiDQQzt (ORCPT ); Sun, 17 Apr 2022 12:55:49 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CA613669D; Sun, 17 Apr 2022 09:53:05 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id r12so6599960iod.6; Sun, 17 Apr 2022 09:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qt+lIiaoXj1DlgMlhg3MjeYK/cjNRe8GsFy1n6MmALQ=; b=FGEfP0j+HjHjlmD5uStx+e3iLnengOE0cWLF3SOWJ4NqIK0hZ7w+0y8vz/asw6VW9J bnGMr+qSXHHGxlI+BmCfJaqMp6B6i9dCZlpwsRVye/2OX+N+vRnN5eufd1ieJCfJqYjz j6n7wn40NcYPxXHIAYKON7YnckDJCwnt3X8Ah/CLPSRWe7+MBQi9Wu5NQHvXrJmPHBu0 QiJFMGWNEczJQKrBAhkxrjQHN9J/xo1gSnO3wMmI91DB+gEeDStyVPXBDIjbNNiHiwuB tAPoXqsPrQuKLi0R3PU7TzReR327Yjmqj7kMTk0lcHXFXRX8wdY/ope1hmqatcDMmkTq kkKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qt+lIiaoXj1DlgMlhg3MjeYK/cjNRe8GsFy1n6MmALQ=; b=G9SQ5nPOZcpz5yRehxj0E0KUj/dXIek6/aRDQ5TZd4ykVUKTo5GTCZl5u2Yql+7buT sKoNM+vc/E2phdufcruqFIHRNzWJwh/Xgw2vm3XaE5CodfBGb/41T8T/mEw5Ha3fm2Ee 6UCbFjXHGTJO1U9kiSBT0Qdmt6V/oZN28meezaslAKhqKoKeTGse1SZv5wskK+NrldMQ X1soj0M4wbMHGCZcoWlCho2dMq6+RVi7p62jGX7nkGG7OyLiJ1oK6WOZ6ygJSb7w3jg4 suF/H4JVG2S8VUoBYVk8ODw+vcgn++R5unYOz/zlt6WflOSIo8xPBs+24BSTuUbIUfGO VSYA== X-Gm-Message-State: AOAM532jIBZROgHtbmVU8HYj+1XEWJZUZienXQRMGtHL9YebNJ2tH0Fr I+I6RJrHYp+GNs24gJB4F9E= X-Google-Smtp-Source: ABdhPJwMBNqO1HFmGHhprp9/rHf6X4VsprTSDjCpeb7oPWF4mrHQKZKV9/OjXk+upw3nNlFjA+6E1w== X-Received: by 2002:a02:a98f:0:b0:315:19db:27a3 with SMTP id q15-20020a02a98f000000b0031519db27a3mr3202308jam.184.1650214384621; Sun, 17 Apr 2022 09:53:04 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id c4-20020a6b4e04000000b00653e74540f0sm3130481iob.7.2022.04.17.09.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:04 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 04/15] gpio: sifive: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:51:57 +0800 Message-Id: <20220417165208.39754-4-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-sifive.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c index 7d82388b4ab7..03b8c4de2e91 100644 --- a/drivers/gpio/gpio-sifive.c +++ b/drivers/gpio/gpio-sifive.c @@ -44,7 +44,7 @@ static void sifive_gpio_set_ie(struct sifive_gpio *chip, unsigned int offset) unsigned long flags; unsigned int trigger; - spin_lock_irqsave(&chip->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&chip->gc.bgpio_lock, flags); trigger = (chip->irq_state & BIT(offset)) ? chip->trigger[offset] : 0; regmap_update_bits(chip->regs, SIFIVE_GPIO_RISE_IE, BIT(offset), (trigger & IRQ_TYPE_EDGE_RISING) ? BIT(offset) : 0); @@ -54,7 +54,7 @@ static void sifive_gpio_set_ie(struct sifive_gpio *chip, unsigned int offset) (trigger & IRQ_TYPE_LEVEL_HIGH) ? BIT(offset) : 0); regmap_update_bits(chip->regs, SIFIVE_GPIO_LOW_IE, BIT(offset), (trigger & IRQ_TYPE_LEVEL_LOW) ? BIT(offset) : 0); - spin_unlock_irqrestore(&chip->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&chip->gc.bgpio_lock, flags); } static int sifive_gpio_irq_set_type(struct irq_data *d, unsigned int trigger) @@ -84,13 +84,13 @@ static void sifive_gpio_irq_enable(struct irq_data *d) /* Switch to input */ gc->direction_input(gc, offset); - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); /* Clear any sticky pending interrupts */ regmap_write(chip->regs, SIFIVE_GPIO_RISE_IP, bit); regmap_write(chip->regs, SIFIVE_GPIO_FALL_IP, bit); regmap_write(chip->regs, SIFIVE_GPIO_HIGH_IP, bit); regmap_write(chip->regs, SIFIVE_GPIO_LOW_IP, bit); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); /* Enable interrupts */ assign_bit(offset, &chip->irq_state, 1); @@ -116,13 +116,13 @@ static void sifive_gpio_irq_eoi(struct irq_data *d) u32 bit = BIT(offset); unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); /* Clear all pending interrupts */ regmap_write(chip->regs, SIFIVE_GPIO_RISE_IP, bit); regmap_write(chip->regs, SIFIVE_GPIO_FALL_IP, bit); regmap_write(chip->regs, SIFIVE_GPIO_HIGH_IP, bit); regmap_write(chip->regs, SIFIVE_GPIO_LOW_IP, bit); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); irq_chip_eoi_parent(d); } From patchwork Sun Apr 17 16:51:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562962 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D478C433EF for ; Sun, 17 Apr 2022 16:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234429AbiDQQzw (ORCPT ); Sun, 17 Apr 2022 12:55:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234477AbiDQQzu (ORCPT ); Sun, 17 Apr 2022 12:55:50 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12AC0369C0; Sun, 17 Apr 2022 09:53:12 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id g21so12383544iom.13; Sun, 17 Apr 2022 09:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=geJH8cZ/3Pw+l+10NnZZq8zy0Rzo4tHJudLUHjx7QEw=; b=STgM9dLwNtoU1Fpjq/AFOWz4iRwFK3VvFy31HU/sSBH/dnlLobRdc/H5/9AQWAosqC rBlFbIg2BIgGLUazoOY4bKMZcNYlQokFGJIg7rC1vx1INtK0pF22BzMehgW5orVoTypy zUwRUlWSOEvyvnfwagPgktb67RUwtmPNLJ9VRTJqsEiwSM8/62NyEOye/Ftcdqbob/b5 rtLY9Qw1/hpCrCldiUOLboCo1CV632Hk/wbPLL9oiziL4rWNmTulVCjLYgKarV5JdzBp 1RzVGYg4ORf2Ou1/QTQgpvKwzMvcIU3hUwWvubTTJ9hJQmX7a8ALsMaqrx3vhAcJi//1 pypQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=geJH8cZ/3Pw+l+10NnZZq8zy0Rzo4tHJudLUHjx7QEw=; b=ksOe0gfhM9oQUJJN6fDjB5jZq+bvRxrB7oX8gfY1mswMNDveyVQZe6VGpazFbKXzRv obw0PeGZtXdFlrFZunpobf1hyM//2ImXngRVSx8PR8c63CLf74FjenvsCG8pJzFRop5e 2TzsKtro+IIdbzQiFOmjXBM2UgD8XcmQt4RxPdWc/xPepynKg76NEGOTd9QbztjH41ld o4yqOlK0dBT8cTi/Yw5q9WmaAKyxW0oHYzH4j8FvS0TsX2NuQM5QlDAJ+ov1Z0bxkRqZ j78tvA/ez3JacbEtT0SUJ7dyajKJXLX7DGNLtBOxIEOHam1KON+VO3liwAPsYlVzwBtJ eeRA== X-Gm-Message-State: AOAM531x8L3R02MFjfTFL0Vs7hmORwBDIoM+5gzOCvPsVUtFt+3/OoSh gvF2sUFuCmg2HG+bRvQdPDo= X-Google-Smtp-Source: ABdhPJwSBEPt6MXNZRA6Lh1xuMsCOxOXUtYFvKCMy/VTNY0PkrkCrLyMSyhz+r4vJOuXNu22vbCj0w== X-Received: by 2002:a05:6602:194:b0:64f:caa4:f9e0 with SMTP id m20-20020a056602019400b0064fcaa4f9e0mr3128959ioo.1.1650214391377; Sun, 17 Apr 2022 09:53:11 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id h24-20020a6bfb18000000b006497692016bsm6656061iog.15.2022.04.17.09.53.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:11 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 05/15] gpio: mlxbf2: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:51:58 +0800 Message-Id: <20220417165208.39754-5-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-mlxbf2.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 3d89912a05b8..64cb060d9d75 100644 --- a/drivers/gpio/gpio-mlxbf2.c +++ b/drivers/gpio/gpio-mlxbf2.c @@ -131,7 +131,7 @@ static int mlxbf2_gpio_lock_acquire(struct mlxbf2_gpio_context *gs) u32 arm_gpio_lock_val; mutex_lock(yu_arm_gpio_lock_param.lock); - spin_lock(&gs->gc.bgpio_lock); + raw_spin_lock(&gs->gc.bgpio_lock); arm_gpio_lock_val = readl(yu_arm_gpio_lock_param.io); @@ -139,7 +139,7 @@ static int mlxbf2_gpio_lock_acquire(struct mlxbf2_gpio_context *gs) * When lock active bit[31] is set, ModeX is write enabled */ if (YU_LOCK_ACTIVE_BIT(arm_gpio_lock_val)) { - spin_unlock(&gs->gc.bgpio_lock); + raw_spin_unlock(&gs->gc.bgpio_lock); mutex_unlock(yu_arm_gpio_lock_param.lock); return -EINVAL; } @@ -157,7 +157,7 @@ static void mlxbf2_gpio_lock_release(struct mlxbf2_gpio_context *gs) __releases(yu_arm_gpio_lock_param.lock) { writel(YU_ARM_GPIO_LOCK_RELEASE, yu_arm_gpio_lock_param.io); - spin_unlock(&gs->gc.bgpio_lock); + raw_spin_unlock(&gs->gc.bgpio_lock); mutex_unlock(yu_arm_gpio_lock_param.lock); } @@ -237,7 +237,7 @@ static void mlxbf2_gpio_irq_enable(struct irq_data *irqd) unsigned long flags; u32 val; - spin_lock_irqsave(&gs->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&gs->gc.bgpio_lock, flags); val = readl(gs->gpio_io + YU_GPIO_CAUSE_OR_CLRCAUSE); val |= BIT(offset); writel(val, gs->gpio_io + YU_GPIO_CAUSE_OR_CLRCAUSE); @@ -245,7 +245,7 @@ static void mlxbf2_gpio_irq_enable(struct irq_data *irqd) val = readl(gs->gpio_io + YU_GPIO_CAUSE_OR_EVTEN0); val |= BIT(offset); writel(val, gs->gpio_io + YU_GPIO_CAUSE_OR_EVTEN0); - spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags); } static void mlxbf2_gpio_irq_disable(struct irq_data *irqd) @@ -256,11 +256,11 @@ static void mlxbf2_gpio_irq_disable(struct irq_data *irqd) unsigned long flags; u32 val; - spin_lock_irqsave(&gs->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&gs->gc.bgpio_lock, flags); val = readl(gs->gpio_io + YU_GPIO_CAUSE_OR_EVTEN0); val &= ~BIT(offset); writel(val, gs->gpio_io + YU_GPIO_CAUSE_OR_EVTEN0); - spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags); } static irqreturn_t mlxbf2_gpio_irq_handler(int irq, void *ptr) @@ -307,7 +307,7 @@ mlxbf2_gpio_irq_set_type(struct irq_data *irqd, unsigned int type) return -EINVAL; } - spin_lock_irqsave(&gs->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&gs->gc.bgpio_lock, flags); if (fall) { val = readl(gs->gpio_io + YU_GPIO_CAUSE_FALL_EN); val |= BIT(offset); @@ -319,7 +319,7 @@ mlxbf2_gpio_irq_set_type(struct irq_data *irqd, unsigned int type) val |= BIT(offset); writel(val, gs->gpio_io + YU_GPIO_CAUSE_RISE_EN); } - spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags); return 0; } From patchwork Sun Apr 17 16:51:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FCAFC433FE for ; Sun, 17 Apr 2022 16:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233866AbiDQQzz (ORCPT ); Sun, 17 Apr 2022 12:55:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234463AbiDQQzy (ORCPT ); Sun, 17 Apr 2022 12:55:54 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6481636692; Sun, 17 Apr 2022 09:53:18 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id r11so7401446ila.1; Sun, 17 Apr 2022 09:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4iJFzazvB5OE5uDCqrIdiik65/U6jCZuduJdScIPpgU=; b=knw2LHR/3xqjb24LGF7oUL4/bcXk2a3GmM5qY86t/Wm+/e0m1+c85fGtgXVC87uRqN TCJCGHmQCR0mrcPUuxfe1PqQ5IrQLjmtJndO91+QiBHVZ+WrCdJgV+xc/FL9qaycmigX RA7qsOkNyYoWKbj0Hfnt8lkZw093ww3RivTVeB88C5leXH1YysCsMCIFJ0GS8RQrTGUc 0oRICUN9Qqm3sgecCn4QFUZsUHGQLZBF2axHqAX4pnW4z4M2tbPSxd4To8Vn0Q/CxaCZ 6dkjxklJsDqIxBl1TjE3F5S8EHcIjdX4X2g8STyZ/gIs+HRGIom7qecndkPgJNqR8NMY vQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4iJFzazvB5OE5uDCqrIdiik65/U6jCZuduJdScIPpgU=; b=uEvmEiOJpeUnfJHqi/Yd0F8h9XTIoMoOz/kqTkuscaReRBd+Rkilx2WLEJtyvu0F4K nuKkX0JyEani+S5vNd/D0sSHDbaqFfSaRUcXTLzDQu4G/EjjbNkujbcB3FQK4v606Txr S2wwEfuKd9/T2RCpGZnyCJLNz4J0KnwXXtLFGVRy1UO+lsZs/1LshrsSyUburK0lEjI9 NRHH0xFzMSmvt5MHR9SAaJlJPc/TFA6hqIjlkgLbPTSjG1+5xpxOHBmyV39x1E2d+qrP 1ed/or8UNEvoFjs5MgCfDJcl9RrUJe+ptyyokN/sQSIEyY4bFDk7ARH7RmznCvdVfOk3 ey5A== X-Gm-Message-State: AOAM533p7sxwx9LuLzBwM9N5KseDjGQn/TqAOqWeuV3apkxVmYatBT9d KbqGCdR9p2ug3okOu5tV0bM= X-Google-Smtp-Source: ABdhPJwkk7/8kIzA/aiHehD3c6S+1kopGTbTKdVCbcCrUENES3UFHAgCH+elhrljtnwYtEzJwvvaCQ== X-Received: by 2002:a05:6e02:1b81:b0:2ca:c4b1:9687 with SMTP id h1-20020a056e021b8100b002cac4b19687mr3101436ili.293.1650214397860; Sun, 17 Apr 2022 09:53:17 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id a22-20020a5d9816000000b006496d8651cfsm6459048iol.1.2022.04.17.09.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:17 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 06/15] gpio: menz127: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:51:59 +0800 Message-Id: <20220417165208.39754-6-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-menz127.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c index 1e21c661d79d..a035a9bcb57c 100644 --- a/drivers/gpio/gpio-menz127.c +++ b/drivers/gpio/gpio-menz127.c @@ -64,7 +64,7 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio, debounce /= 50; } - spin_lock(&gc->bgpio_lock); + raw_spin_lock(&gc->bgpio_lock); db_en = readl(priv->reg_base + MEN_Z127_DBER); @@ -79,7 +79,7 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio, writel(db_en, priv->reg_base + MEN_Z127_DBER); writel(db_cnt, priv->reg_base + GPIO_TO_DBCNT_REG(gpio)); - spin_unlock(&gc->bgpio_lock); + raw_spin_unlock(&gc->bgpio_lock); return 0; } @@ -91,7 +91,7 @@ static int men_z127_set_single_ended(struct gpio_chip *gc, struct men_z127_gpio *priv = gpiochip_get_data(gc); u32 od_en; - spin_lock(&gc->bgpio_lock); + raw_spin_lock(&gc->bgpio_lock); od_en = readl(priv->reg_base + MEN_Z127_ODER); if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN) @@ -101,7 +101,7 @@ static int men_z127_set_single_ended(struct gpio_chip *gc, od_en &= ~BIT(offset); writel(od_en, priv->reg_base + MEN_Z127_ODER); - spin_unlock(&gc->bgpio_lock); + raw_spin_unlock(&gc->bgpio_lock); return 0; } From patchwork Sun Apr 17 16:52:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562961 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65714C433F5 for ; Sun, 17 Apr 2022 16:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234454AbiDQQ4H (ORCPT ); Sun, 17 Apr 2022 12:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234496AbiDQQ4F (ORCPT ); Sun, 17 Apr 2022 12:56:05 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D56B9366A6; Sun, 17 Apr 2022 09:53:28 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id 79so4225824iou.7; Sun, 17 Apr 2022 09:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SE/JUxfuW/QxTb++fk+mriOUA6JHM85iCZJkZkrQ1C4=; b=Sjse0foV8Q9We+8VbVwP9DRhkXZGEGAqTpumlGSau1lKbjW/wXHUkSEXl7Jd6GQFav O4NWHRtkzSXeM7uWlxT+yk3AbDu8/C4uzFgkr6XswILcRad1VV9lwFFyLkPfOuZajabk xmPNgfQMDO1iiLQdUkw45yN0JcaQe/lNUJuj1r+IbY+pcYnrV/v0GVCXsOUPJShGOwgR cWl/Mwsfg5GZNqs/Ie0J8y6dNcW+OAOx7A9dLWuE2oSBmzF+B8fBQsT5dh7YokZsu1CM KXKgm7P7rqLNO+TYDqCmifsS/Wq6otl5Ii7KEDGFw6ApGzgLqrmMZ0EiEFjAQZi/xBNF resw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SE/JUxfuW/QxTb++fk+mriOUA6JHM85iCZJkZkrQ1C4=; b=y4jKkucsv1ZnFatRngzvz7gEh5wFRsCzIGqVIzEWRi6IcUuGiBGx4MD0QH/ad4Ggqs MBU02932XxuBAV9VuQbrGEFm8bVCCLFetRwyDrfj10e6DcnF14a+XIg3Fo8mukZ7D0Et D8b43Y24r+whslMUZJxjADLZEXD+s1Y7Y+46zoPy0jJ8iipV5FAZxyjW45hoVgDVHZsn kseVyWoJKi90sT8bK2j5Q4Rx1CvXHaC8pSKtAKDVPeVsV7g7oPPiQ+gBD0ezD8LLu+wz L8MUx0RKmK711jd8F8XVk3mVf1xdxO2eiV3kOP0eWdDbbCDE4V/jSeOUFeUOprz+fykE ZPEg== X-Gm-Message-State: AOAM531Kq5PXMMqqLCitPL17/HV4x1iQHKeYkKFdpsGWkM7ztcqp0IMe 1A91m2Mp31w1o13JcbBlIC8= X-Google-Smtp-Source: ABdhPJwNah/4aGnaAOv4hzit2lCkg4f0rwUk+60fuPdK0ACgwM89Me72jpv3MHOBwLLrtJHC6d4s4w== X-Received: by 2002:a05:6638:4191:b0:326:3d26:6953 with SMTP id az17-20020a056638419100b003263d266953mr3427253jab.101.1650214408097; Sun, 17 Apr 2022 09:53:28 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id d16-20020a056e020bf000b002ca51236f60sm6047879ilu.9.2022.04.17.09.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:27 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 07/15] gpio: loongson1: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:00 +0800 Message-Id: <20220417165208.39754-7-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-loongson1.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c index 1b1ee94eeab4..5d90b3bc5a25 100644 --- a/drivers/gpio/gpio-loongson1.c +++ b/drivers/gpio/gpio-loongson1.c @@ -25,10 +25,10 @@ static int ls1x_gpio_request(struct gpio_chip *gc, unsigned int offset) { unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); __raw_writel(__raw_readl(gpio_reg_base + GPIO_CFG) | BIT(offset), gpio_reg_base + GPIO_CFG); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } @@ -37,10 +37,10 @@ static void ls1x_gpio_free(struct gpio_chip *gc, unsigned int offset) { unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); __raw_writel(__raw_readl(gpio_reg_base + GPIO_CFG) & ~BIT(offset), gpio_reg_base + GPIO_CFG); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static int ls1x_gpio_probe(struct platform_device *pdev) From patchwork Sun Apr 17 16:52:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10522C433F5 for ; Sun, 17 Apr 2022 16:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234493AbiDQQ4P (ORCPT ); Sun, 17 Apr 2022 12:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234464AbiDQQ4M (ORCPT ); Sun, 17 Apr 2022 12:56:12 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23BD82717C; Sun, 17 Apr 2022 09:53:37 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id 125so12402699iov.10; Sun, 17 Apr 2022 09:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BEsXWsVAFxE0Qk9j9TD45ImCnz9zFCsmdmXDW5FiVWg=; b=e5qDIPzNb5i/XDJETnbYTVvf7n/Tz1w05RSl1zubtU+VL7MOtOpH5HwOutaI69+iZB rYx8U06TVLuwCczmAQ7VGcoSfQZ0VJRMpfdXLc0BltbM74CIqcBLSdYEICIvlV0pE38B LzSzw3RMgR4qOp9gMOSH6rdBVJ7hWQPifTqCObYy9JEftJz1fC5K+mZH2YX9SwcLgK2K GQW9/xgn0dwjFxTveoQrl1AXvmT18FQUdurqzuI3/vgftrUX0XyCZjLSrXLiJSKRfNP+ vL/c8Qk5C1iVmXXWgTWWKu1aoEyMKGEipgmcHYswfs3XGNKadPEpJwmrQCmiTl1dWvuE kiGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BEsXWsVAFxE0Qk9j9TD45ImCnz9zFCsmdmXDW5FiVWg=; b=WHLxQVocLVSJ01wACLj2FEPM86MqYsVheC1jD1wGYpiPcQrCdXqD5oGFjV7+iRZnXb UvCwcjyy5sYrgWlsBhdIhZQR+5g29bZ5lNy1Rs3s2p2lhGA0+9IhmmWU/RaeHSqpGtcv vePtdqx4YGZcCt9lGkep774N4u7pbvVu6dGIxAvGc37uly6tG2v/aqxsyYkZK8v0Vj8k 5UkgsGM+j+phamaHBUmBHnsBJyiP2jKtchnUgkeGg//C4MrH2a8mcJwngHYgIvF8+Nsc mLfv1T6tVqpn6GskGKJn3Oqzj5BGYoSQ/MkvV2urv9RZm1NsjanwIymb4A78oAYGohv6 XsaA== X-Gm-Message-State: AOAM5331gNRvbwdpTrjW8+lGRhJOuJqPACqMPU8h7IkzUAmwFxnb/AYg cbo0qXwKzScHzXeqFStiwXQ= X-Google-Smtp-Source: ABdhPJyh1gSqRyo717tsWNV4tEqAE7Hi4VCbdcxUrunF8BUVtyqzqiU0k2TgU5xd+dDGmmFmZvwZUQ== X-Received: by 2002:a05:6602:2c0b:b0:63d:dfb2:9a95 with SMTP id w11-20020a0566022c0b00b0063ddfb29a95mr3120108iov.93.1650214416558; Sun, 17 Apr 2022 09:53:36 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id l15-20020a056e0205cf00b002cbea6a61b9sm5338147ils.25.2022.04.17.09.53.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:36 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 08/15] gpio: ixp4xx: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:01 +0800 Message-Id: <20220417165208.39754-8-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-ixp4xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c index b3b050604e0b..6b184502fa3f 100644 --- a/drivers/gpio/gpio-ixp4xx.c +++ b/drivers/gpio/gpio-ixp4xx.c @@ -128,7 +128,7 @@ static int ixp4xx_gpio_irq_set_type(struct irq_data *d, unsigned int type) int_reg = IXP4XX_REG_GPIT1; } - spin_lock_irqsave(&g->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&g->gc.bgpio_lock, flags); /* Clear the style for the appropriate pin */ val = __raw_readl(g->base + int_reg); @@ -147,7 +147,7 @@ static int ixp4xx_gpio_irq_set_type(struct irq_data *d, unsigned int type) val |= BIT(d->hwirq); __raw_writel(val, g->base + IXP4XX_REG_GPOE); - spin_unlock_irqrestore(&g->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&g->gc.bgpio_lock, flags); /* This parent only accept level high (asserted) */ return irq_chip_set_type_parent(d, IRQ_TYPE_LEVEL_HIGH); From patchwork Sun Apr 17 16:52:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562960 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA039C433FE for ; Sun, 17 Apr 2022 16:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232523AbiDQQ42 (ORCPT ); Sun, 17 Apr 2022 12:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234496AbiDQQ4U (ORCPT ); Sun, 17 Apr 2022 12:56:20 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F886366B0; Sun, 17 Apr 2022 09:53:44 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id y16so7382852ilc.7; Sun, 17 Apr 2022 09:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5D6NILl4YmkLrfTcck1sdO4j+0L2jByfOgqbLzhtKKs=; b=MRfPX3YWO6/EVPIIjuT9QNczt4JNJRn1DCUSP9gkJxeSjJjDOnfy1WI1TyGpEocNOV kTOiCfWxWxOVgalneexJWV3BmEoZQ5ErLoY2Idlq+RYsEARdWqsyBvNagrqpF2vzHCEx eByDKIDe8Kdq25hPkgeW2DZW+tPA5EG8rJpwvEi45Cd11hVbSdChz+8mC7WLdEHS+Fah QF4ebpxZ7yKzdbZXRbueIrPFetBOwcYYeBNvJDTaEcAtDrSVazpzhFMqC2N70owf9PeH Wwlo/3iwkLcY0tbfnf40cgOJgIZZlur1xzf1NnG6BwKPR1+OHdmnb6QV0+uk2My237/b 7j9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5D6NILl4YmkLrfTcck1sdO4j+0L2jByfOgqbLzhtKKs=; b=6cyglQtCNomBl4DTFdeShUGOdomMGM5DQkbBfnB6QXFmb5NvvKr53gHgdnojrv5c1k kYA36tQtxMizvSzdSzR6lnn1AEAL0wXHoLUFp7nOaOQdv3N9E1U3wVs8EX7vSLbR0x5q do9+Gaq4ojF3MpkJGMgDHce+vESIMLDdE0iNT71LTtmQJyAYh7ByGZRsITH0bKVWrCYx 7LyOjysQA89Sy6KFIEo34fX4/pMKzd+UwwxCews9o7ezE1pDyFJyLfMIreVzbm3lrKSm t00g7xaagjNIjzTfP7b4TOGClsYViX4Wbg5zpCDzgY5h7nS9SN1Ha+v77zTVbLyxSfeE uHcg== X-Gm-Message-State: AOAM5331jpuxUA+hq1CRuAXWgIEAGZMoSjgWToEAw8pDpPbWGwHN8d+d H0Ze8PySYxyn2SVzprYY4iA= X-Google-Smtp-Source: ABdhPJz0ED/K/UtRpNtOaJ5RJE0VJ7lvo1q9Y5Dcon6uJJYxW1/n6PpYER/B2hz8hfu1QUSYNwFVUA== X-Received: by 2002:a92:cd83:0:b0:2cc:1a66:6435 with SMTP id r3-20020a92cd83000000b002cc1a666435mr1595008ilb.252.1650214423774; Sun, 17 Apr 2022 09:53:43 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id f10-20020a05660215ca00b0064d25228248sm6999500iow.11.2022.04.17.09.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:43 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 09/15] gpio: idt3243x: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:02 +0800 Message-Id: <20220417165208.39754-9-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-idt3243x.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c index 52b8b72ded77..1cafdf46f875 100644 --- a/drivers/gpio/gpio-idt3243x.c +++ b/drivers/gpio/gpio-idt3243x.c @@ -57,7 +57,7 @@ static int idt_gpio_irq_set_type(struct irq_data *d, unsigned int flow_type) if (sense == IRQ_TYPE_NONE || (sense & IRQ_TYPE_EDGE_BOTH)) return -EINVAL; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); ilevel = readl(ctrl->gpio + IDT_GPIO_ILEVEL); if (sense & IRQ_TYPE_LEVEL_HIGH) @@ -68,7 +68,7 @@ static int idt_gpio_irq_set_type(struct irq_data *d, unsigned int flow_type) writel(ilevel, ctrl->gpio + IDT_GPIO_ILEVEL); irq_set_handler_locked(d, handle_level_irq); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } @@ -86,12 +86,12 @@ static void idt_gpio_mask(struct irq_data *d) struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc); unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); ctrl->mask_cache |= BIT(d->hwirq); writel(ctrl->mask_cache, ctrl->pic + IDT_PIC_IRQ_MASK); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void idt_gpio_unmask(struct irq_data *d) @@ -100,12 +100,12 @@ static void idt_gpio_unmask(struct irq_data *d) struct idt_gpio_ctrl *ctrl = gpiochip_get_data(gc); unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); ctrl->mask_cache &= ~BIT(d->hwirq); writel(ctrl->mask_cache, ctrl->pic + IDT_PIC_IRQ_MASK); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static int idt_gpio_irq_init_hw(struct gpio_chip *gc) From patchwork Sun Apr 17 16:52:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563218 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3272C433F5 for ; Sun, 17 Apr 2022 16:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234464AbiDQQ4f (ORCPT ); Sun, 17 Apr 2022 12:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234486AbiDQQ42 (ORCPT ); Sun, 17 Apr 2022 12:56:28 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16845366BC; Sun, 17 Apr 2022 09:53:52 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id o127so7122981iof.12; Sun, 17 Apr 2022 09:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BNgNnKpVM/3g6n+FIhL3S2OP5y+05NtGKKDcg+5q1u4=; b=FR2Tengc6fUBl1WwUs+gRAE88YNYT+YTpNcVHeEQU8006VgNrH2pLKvHpkBYhdZjeq oP8DsID5H5XgZxdAkD947yESy2zIrREixuYE0PpUwcXytL6XMLSzJuB2Cg63pPZQTxy5 CBbEKIZFWFBu6sgevDrMqFcNL1FJZLwqKt6opZTzriZOopR8pT9oQsfinW35tUvWDCC4 mLujb9pCErVva2ZgyhNOx5Cz63sbdSGuJLqw04sD0v42iCAlgJxZNITBoHKVY1ptTS35 A66LAHvym0Z7GDUl06LkXQqjbuo24421nOqDyUvjcQrxxhcmsO6U4LCJgeH1QlCXX0pb bCuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BNgNnKpVM/3g6n+FIhL3S2OP5y+05NtGKKDcg+5q1u4=; b=ZeQzWM4HwR3ITQvGJZgYDo63uxTK5wB2GQhC6j0yQ9zcuPsiiLdwJxLB7uiUVLMOAZ UDpt0KK1XbYSDTGpG8SNcLDLr3BB2Xu7fVmiZMExUa/kCq5lsBebK8lUh9WQPY+eIs7E kZpmhDHTB43ojOaHLy2KVi5N+VQDp8b73QKYVAyU8yyPBOZrtwjLEu+7xSeZOjarzsoN 73hnYqBdjJ+xFGTSoKQ8ofUy2lsufm0FVmkJK2DlzmC1GpM3q6aSvPKruFfIIRYl8EEE AwSz7IE/nWbAgd7Sr5y35e3O5YTmNQ7UwQl9AK141wLH5P9py7wdPfKB6xaMCifZucgv yR5Q== X-Gm-Message-State: AOAM531nnVxWtNI3Esmoe/LrWRLx4JoTl05i5+SDmNQ4se4JEQGK2BrZ SV8WlwM+YDj74O3spzvQXxg= X-Google-Smtp-Source: ABdhPJz/F1XQREAAKtmdV7Mj2isUbnW72M6pJnGg1VOd+eboG43/AlseoNS2StjbuaMXQb3XlOfQmQ== X-Received: by 2002:a05:6638:2182:b0:323:a610:3eaf with SMTP id s2-20020a056638218200b00323a6103eafmr3480486jaj.204.1650214431527; Sun, 17 Apr 2022 09:53:51 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id r14-20020a92ac0e000000b002ca8eb05174sm6034445ilh.57.2022.04.17.09.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:51 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 10/15] gpio: hlwd: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:03 +0800 Message-Id: <20220417165208.39754-10-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-hlwd.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-hlwd.c b/drivers/gpio/gpio-hlwd.c index 641719a96a1a..4e13e937f832 100644 --- a/drivers/gpio/gpio-hlwd.c +++ b/drivers/gpio/gpio-hlwd.c @@ -65,7 +65,7 @@ static void hlwd_gpio_irqhandler(struct irq_desc *desc) int hwirq; u32 emulated_pending; - spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); pending = ioread32be(hlwd->regs + HW_GPIOB_INTFLAG); pending &= ioread32be(hlwd->regs + HW_GPIOB_INTMASK); @@ -93,7 +93,7 @@ static void hlwd_gpio_irqhandler(struct irq_desc *desc) /* Mark emulated interrupts as pending */ pending |= rising | falling; } - spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); chained_irq_enter(chip, desc); @@ -118,11 +118,11 @@ static void hlwd_gpio_irq_mask(struct irq_data *data) unsigned long flags; u32 mask; - spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); mask = ioread32be(hlwd->regs + HW_GPIOB_INTMASK); mask &= ~BIT(data->hwirq); iowrite32be(mask, hlwd->regs + HW_GPIOB_INTMASK); - spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); } static void hlwd_gpio_irq_unmask(struct irq_data *data) @@ -132,11 +132,11 @@ static void hlwd_gpio_irq_unmask(struct irq_data *data) unsigned long flags; u32 mask; - spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); mask = ioread32be(hlwd->regs + HW_GPIOB_INTMASK); mask |= BIT(data->hwirq); iowrite32be(mask, hlwd->regs + HW_GPIOB_INTMASK); - spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); } static void hlwd_gpio_irq_enable(struct irq_data *data) @@ -173,7 +173,7 @@ static int hlwd_gpio_irq_set_type(struct irq_data *data, unsigned int flow_type) unsigned long flags; u32 level; - spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); hlwd->edge_emulation &= ~BIT(data->hwirq); @@ -194,11 +194,11 @@ static int hlwd_gpio_irq_set_type(struct irq_data *data, unsigned int flow_type) hlwd_gpio_irq_setup_emulation(hlwd, data->hwirq, flow_type); break; default: - spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); return -EINVAL; } - spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&hlwd->gpioc.bgpio_lock, flags); return 0; } From patchwork Sun Apr 17 16:52:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562959 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6DAC433EF for ; Sun, 17 Apr 2022 16:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234487AbiDQQ4h (ORCPT ); Sun, 17 Apr 2022 12:56:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234496AbiDQQ4f (ORCPT ); Sun, 17 Apr 2022 12:56:35 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A87133EA0; Sun, 17 Apr 2022 09:53:59 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id b5so7420209ile.0; Sun, 17 Apr 2022 09:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vWYbhtE+mjLPNJexKnCqZt1IMsrit1m6da/niohR7jg=; b=jwzY2MNX+HYAV5LH+1v2heLZePU+fg4zLW2K5LhCgQRhWujNtxz2P8ltPJGtLyQ81U bwasm6BxbMRSEPQ6RhAVl59IWLz7p5uMyO6BR67WeVpQpmsfmjri3Gb8T2GZy4IT/MGf sksJ5kZ/YL8rMynIvGn4AZBxv4cl5leM+Evcb8f9tfxZk5YgQa90Gopp9osFiNhqy1en W7pT9wRkjapBE/kOqzS3qRhSNt2meycT0w4uwrer4jFcrIm3xEKFJehTYuDDZegZBJEv aT8i1Xdx+dzSiISWW9hvWp7sp/7VzNHMKnR/TPmKj0UiFbvh8yJ5hQTTuDI2nmOrjEZQ x5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vWYbhtE+mjLPNJexKnCqZt1IMsrit1m6da/niohR7jg=; b=lGjhCI4DB9OnwKhhQ9dD51Rfs+z48ZgkXhLG9r0739TTccgrPfrvQLOOpDONXj1+gi 8q/lHhtnm9XzFmSuz1+rbZYpPyN/bVEeD4Gigc9rA34OPDfdj71t44wzZhWYNXMzLv6u Xjdk7HcR4mH3N+WCc16Maqb+LuuICLeQss6Sz6IqAC7pbUx8SZHFZdQW/JiTcXNC8H9Y YFaEDo1fJBFn8dQCHhUm1YV3+nvGaipgsLHxrvcLURqk8hRoflPQEBr6MGOKb98F5qg8 WOhjwsab276q6JJMSclb4ATQMHIWo/MVibwoDexdCDmDCYQ2YKOs1FasdRomodkEe5wG HraQ== X-Gm-Message-State: AOAM530q1AbK0J/Kj4cnp3NonFj4iJjFy6Xz2JoKFB6wlXr/vLz0jDLc uVp+JGCboRbkyPx2rcnYI5g= X-Google-Smtp-Source: ABdhPJyiij1CYANAcBUqdhdYy+CwFQJSrpat7DgvBsoR7BU10ao1kzewsYKMDbpRIvp9+pR3Q+XC0Q== X-Received: by 2002:a92:ca0b:0:b0:2ca:53a1:69b0 with SMTP id j11-20020a92ca0b000000b002ca53a169b0mr3085280ils.110.1650214439018; Sun, 17 Apr 2022 09:53:59 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id e14-20020a92de4e000000b002cabd3731ddsm6076398ilr.7.2022.04.17.09.53.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:53:58 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 11/15] gpio: grgpio: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:04 +0800 Message-Id: <20220417165208.39754-11-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-grgpio.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c index 23d447e17a67..df563616f943 100644 --- a/drivers/gpio/gpio-grgpio.c +++ b/drivers/gpio/gpio-grgpio.c @@ -145,7 +145,7 @@ static int grgpio_irq_set_type(struct irq_data *d, unsigned int type) return -EINVAL; } - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); ipol = priv->gc.read_reg(priv->regs + GRGPIO_IPOL) & ~mask; iedge = priv->gc.read_reg(priv->regs + GRGPIO_IEDGE) & ~mask; @@ -153,7 +153,7 @@ static int grgpio_irq_set_type(struct irq_data *d, unsigned int type) priv->gc.write_reg(priv->regs + GRGPIO_IPOL, ipol | pol); priv->gc.write_reg(priv->regs + GRGPIO_IEDGE, iedge | edge); - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); return 0; } @@ -164,11 +164,11 @@ static void grgpio_irq_mask(struct irq_data *d) int offset = d->hwirq; unsigned long flags; - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); grgpio_set_imask(priv, offset, 0); - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); } static void grgpio_irq_unmask(struct irq_data *d) @@ -177,11 +177,11 @@ static void grgpio_irq_unmask(struct irq_data *d) int offset = d->hwirq; unsigned long flags; - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); grgpio_set_imask(priv, offset, 1); - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); } static struct irq_chip grgpio_irq_chip = { @@ -199,7 +199,7 @@ static irqreturn_t grgpio_irq_handler(int irq, void *dev) int i; int match = 0; - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); /* * For each gpio line, call its interrupt handler if it its underlying @@ -215,7 +215,7 @@ static irqreturn_t grgpio_irq_handler(int irq, void *dev) } } - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); if (!match) dev_warn(priv->dev, "No gpio line matched irq %d\n", irq); @@ -247,13 +247,13 @@ static int grgpio_irq_map(struct irq_domain *d, unsigned int irq, dev_dbg(priv->dev, "Mapping irq %d for gpio line %d\n", irq, offset); - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); /* Request underlying irq if not already requested */ lirq->irq = irq; uirq = &priv->uirqs[lirq->index]; if (uirq->refcnt == 0) { - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); ret = request_irq(uirq->uirq, grgpio_irq_handler, 0, dev_name(priv->dev), priv); if (ret) { @@ -262,11 +262,11 @@ static int grgpio_irq_map(struct irq_domain *d, unsigned int irq, uirq->uirq); return ret; } - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); } uirq->refcnt++; - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); /* Setup irq */ irq_set_chip_data(irq, priv); @@ -290,7 +290,7 @@ static void grgpio_irq_unmap(struct irq_domain *d, unsigned int irq) irq_set_chip_and_handler(irq, NULL, NULL); irq_set_chip_data(irq, NULL); - spin_lock_irqsave(&priv->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&priv->gc.bgpio_lock, flags); /* Free underlying irq if last user unmapped */ index = -1; @@ -309,13 +309,13 @@ static void grgpio_irq_unmap(struct irq_domain *d, unsigned int irq) uirq = &priv->uirqs[lirq->index]; uirq->refcnt--; if (uirq->refcnt == 0) { - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); free_irq(uirq->uirq, priv); return; } } - spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags); } static const struct irq_domain_ops grgpio_irq_domain_ops = { From patchwork Sun Apr 17 16:52:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563217 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631BCC433EF for ; Sun, 17 Apr 2022 16:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbiDQQ4t (ORCPT ); Sun, 17 Apr 2022 12:56:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234529AbiDQQ4m (ORCPT ); Sun, 17 Apr 2022 12:56:42 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39358366A3; Sun, 17 Apr 2022 09:54:06 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id g21so12384482iom.13; Sun, 17 Apr 2022 09:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZeoPF/5s/8FefeZEMvEU3kXPz31OKiUJe25SyiRvD6Q=; b=T6skccgysjxKrWbkjDXiulPTulgnjRiPioFAu8/vJ7QZ2Z5IaaKQB/RZ4O+k7Wln8f /wSMzF1ekNINHn1weakHHyA6+TONEJlwnwPRvRq+o8HfCruG/6PELBHD6lEvLasbzxS2 pAxqvBZ5rdOcjgGbi4lWfjIJ5BYNVH2Bj3KdNGsYZi1mrZckI95uOPtxzTMwLff2CjjV aEtT6UTPNOcfppcfUVqioEe36Y1PR47WANj0udnVE5UHuVRmiqmzatQzhlWpzzb27yKd myXZxhtzKAsicPbhKenTYKG8yNBGmZdoMo+06vuYK9deyd9jXrmwbIWX0BcUQWMKLkwM iIMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZeoPF/5s/8FefeZEMvEU3kXPz31OKiUJe25SyiRvD6Q=; b=4DV1e0uh8F8/YOFDCxCrN+mDHSMzaohAK9uRMcbIUaGNmnpzYmqPrMnSNG1AEP6hmg ISiZzbNd2VP6uU/D+pLTKZp6q4VQLkXYeMIa9ge+iZDUzz7PVOLAx4Fdma2w0kb0qpT6 HtZZS8CIr0jOGWg4TVW9Y6tcSbRBSU2tQ/WKc7OYaNtfwtbcSK+32FPneEocV3cPn9T3 ljGVUanjYwjtT7jiUUOKeBzrgbHdllWAu3R1yb4aqcPicCMRWWEfCvwDkpHbK9G+xTpj CsdJelZiDvHdGObG5AvsKJmksJ9t73fJfMhyNlfNyaME+TXXX6P8Y7ZqUvUSWqZZLZM+ AONw== X-Gm-Message-State: AOAM531uEvHgB7/M0Z6nl6qvS/STB4JKB8UdgjAqQpfPyP3c4d3Kq5GD +Af2in1cilNmZGAiA2hFsDw= X-Google-Smtp-Source: ABdhPJyR8KhzPCxF4rkMPJPQnV2k6aCKS9RbpGHxF/VNtsR5BydtgXayWDVRtFWaRIp/DveMws7m/A== X-Received: by 2002:a02:9429:0:b0:326:6774:5ba0 with SMTP id a38-20020a029429000000b0032667745ba0mr3272012jai.213.1650214445540; Sun, 17 Apr 2022 09:54:05 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id p15-20020a92da4f000000b002caa4481d07sm5965239ilq.23.2022.04.17.09.54.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:54:05 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 12/15] gpio: dwapb: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:05 +0800 Message-Id: <20220417165208.39754-12-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-dwapb.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index b0f3aca61974..7130195da48d 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -243,9 +243,9 @@ static void dwapb_irq_ack(struct irq_data *d) u32 val = BIT(irqd_to_hwirq(d)); unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); dwapb_write(gpio, GPIO_PORTA_EOI, val); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void dwapb_irq_mask(struct irq_data *d) @@ -255,10 +255,10 @@ static void dwapb_irq_mask(struct irq_data *d) unsigned long flags; u32 val; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val = dwapb_read(gpio, GPIO_INTMASK) | BIT(irqd_to_hwirq(d)); dwapb_write(gpio, GPIO_INTMASK, val); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void dwapb_irq_unmask(struct irq_data *d) @@ -268,10 +268,10 @@ static void dwapb_irq_unmask(struct irq_data *d) unsigned long flags; u32 val; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val = dwapb_read(gpio, GPIO_INTMASK) & ~BIT(irqd_to_hwirq(d)); dwapb_write(gpio, GPIO_INTMASK, val); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void dwapb_irq_enable(struct irq_data *d) @@ -281,11 +281,11 @@ static void dwapb_irq_enable(struct irq_data *d) unsigned long flags; u32 val; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val = dwapb_read(gpio, GPIO_INTEN); val |= BIT(irqd_to_hwirq(d)); dwapb_write(gpio, GPIO_INTEN, val); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static void dwapb_irq_disable(struct irq_data *d) @@ -295,11 +295,11 @@ static void dwapb_irq_disable(struct irq_data *d) unsigned long flags; u32 val; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val = dwapb_read(gpio, GPIO_INTEN); val &= ~BIT(irqd_to_hwirq(d)); dwapb_write(gpio, GPIO_INTEN, val); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static int dwapb_irq_set_type(struct irq_data *d, u32 type) @@ -309,7 +309,7 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type) irq_hw_number_t bit = irqd_to_hwirq(d); unsigned long level, polarity, flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL); polarity = dwapb_read(gpio, GPIO_INT_POLARITY); @@ -344,7 +344,7 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type) dwapb_write(gpio, GPIO_INTTYPE_LEVEL, level); if (type != IRQ_TYPE_EDGE_BOTH) dwapb_write(gpio, GPIO_INT_POLARITY, polarity); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } @@ -374,7 +374,7 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc, unsigned long flags, val_deb; unsigned long mask = BIT(offset); - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); val_deb = dwapb_read(gpio, GPIO_PORTA_DEBOUNCE); if (debounce) @@ -383,7 +383,7 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc, val_deb &= ~mask; dwapb_write(gpio, GPIO_PORTA_DEBOUNCE, val_deb); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } @@ -738,7 +738,7 @@ static int dwapb_gpio_suspend(struct device *dev) unsigned long flags; int i; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); for (i = 0; i < gpio->nr_ports; i++) { unsigned int offset; unsigned int idx = gpio->ports[i].idx; @@ -765,7 +765,7 @@ static int dwapb_gpio_suspend(struct device *dev) dwapb_write(gpio, GPIO_INTMASK, ~ctx->wake_en); } } - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); clk_bulk_disable_unprepare(DWAPB_NR_CLOCKS, gpio->clks); @@ -785,7 +785,7 @@ static int dwapb_gpio_resume(struct device *dev) return err; } - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); for (i = 0; i < gpio->nr_ports; i++) { unsigned int offset; unsigned int idx = gpio->ports[i].idx; @@ -812,7 +812,7 @@ static int dwapb_gpio_resume(struct device *dev) dwapb_write(gpio, GPIO_PORTA_EOI, 0xffffffff); } } - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } From patchwork Sun Apr 17 16:52:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B79DC433F5 for ; Sun, 17 Apr 2022 16:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234546AbiDQQ47 (ORCPT ); Sun, 17 Apr 2022 12:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234547AbiDQQ4t (ORCPT ); Sun, 17 Apr 2022 12:56:49 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3584636B50; Sun, 17 Apr 2022 09:54:13 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id r17so1386444iln.9; Sun, 17 Apr 2022 09:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WpafZOKGy8uw4nGe6/GVYe+oBX78YZzxyaLoPSujzfU=; b=egMfLQdOLO8GIGFwSxiNlknQU9OQprDKwJuzaZCkUJsN+I2Z32yd4zQHbWDu/PmvMn vz4uh3chuZUOVGEjIxrK+GGMQYsw4Y9zv6jvFUIRxHBpSfkBKJrfWWzKmw9raaqJ+JWM K1NrAtoj2Ersr815tCIh7bpVPB14aUw23T3IV5slSA1Gu8/+tOsdxElP+Wb1XKawNLCI khTPBzemsqLcDy3uvML++snSlTkxpCnuZ8YyPMusgd79yd5pxrsG+zbV7rM+fhrLNUJU 0X59h8BYJOi6gicT0MWDLLK2lY93/Ylf30nvWVKgvmfYA7AutbEQEPZB5HMe8r1dKfj9 /6bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WpafZOKGy8uw4nGe6/GVYe+oBX78YZzxyaLoPSujzfU=; b=ykQLXZlHsjk/b11OtUDzTWSdJjEUZ9k+eA1wGWNWQ8BAXf2P/6d//aJCN8klt+v0so o7BnKnp2WCZqoa3UTRWc5S8XQiSx3QfYT3Dt2+YKykdQT40FENepxfcCjT0GlKhfR+0V mRdLg3lHn8qj5Wn6hHz/cvarTs91cNKUHUNorNtvp8XofD7nDH94TbhybhRM04ux888w RSaKf1J+5kBw6wzDEW8kaEOFTx67WakmFYnqRWNb5NFtHwWOax45VHjPs5lXZdxJSFd4 HDnDx06FsYvShEMlkZ3Ujr7ojQyHEzlvvHhh/uEK2wRtpJ6uFLkYG3W/4PvQlFv75B7b lOcQ== X-Gm-Message-State: AOAM531P71uBK6uXOJN/hctD6sNKEiWBxGdLTtc/DJtOP/syPN7Qp5q7 enYcAjVwceL6vCJ7jofWnT4= X-Google-Smtp-Source: ABdhPJxIMxTNkVpwSRXdJeqHX05+ohsoFzcH3flCB34EEJXR1f2wEuLKcSSiKfzo26XiccOezvEglQ== X-Received: by 2002:a92:9405:0:b0:2bf:6a01:6ad1 with SMTP id c5-20020a929405000000b002bf6a016ad1mr3246596ili.197.1650214452620; Sun, 17 Apr 2022 09:54:12 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id t18-20020a056e02011200b002cbe6ce18e5sm5697326ilm.40.2022.04.17.09.54.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:54:12 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 13/15] gpio: cadence: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:06 +0800 Message-Id: <20220417165208.39754-13-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-cadence.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c index 562f8f7e7d1f..137aea49ba02 100644 --- a/drivers/gpio/gpio-cadence.c +++ b/drivers/gpio/gpio-cadence.c @@ -41,12 +41,12 @@ static int cdns_gpio_request(struct gpio_chip *chip, unsigned int offset) struct cdns_gpio_chip *cgpio = gpiochip_get_data(chip); unsigned long flags; - spin_lock_irqsave(&chip->bgpio_lock, flags); + raw_spin_lock_irqsave(&chip->bgpio_lock, flags); iowrite32(ioread32(cgpio->regs + CDNS_GPIO_BYPASS_MODE) & ~BIT(offset), cgpio->regs + CDNS_GPIO_BYPASS_MODE); - spin_unlock_irqrestore(&chip->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&chip->bgpio_lock, flags); return 0; } @@ -55,13 +55,13 @@ static void cdns_gpio_free(struct gpio_chip *chip, unsigned int offset) struct cdns_gpio_chip *cgpio = gpiochip_get_data(chip); unsigned long flags; - spin_lock_irqsave(&chip->bgpio_lock, flags); + raw_spin_lock_irqsave(&chip->bgpio_lock, flags); iowrite32(ioread32(cgpio->regs + CDNS_GPIO_BYPASS_MODE) | (BIT(offset) & cgpio->bypass_orig), cgpio->regs + CDNS_GPIO_BYPASS_MODE); - spin_unlock_irqrestore(&chip->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&chip->bgpio_lock, flags); } static void cdns_gpio_irq_mask(struct irq_data *d) @@ -90,7 +90,7 @@ static int cdns_gpio_irq_set_type(struct irq_data *d, unsigned int type) u32 mask = BIT(d->hwirq); int ret = 0; - spin_lock_irqsave(&chip->bgpio_lock, flags); + raw_spin_lock_irqsave(&chip->bgpio_lock, flags); int_value = ioread32(cgpio->regs + CDNS_GPIO_IRQ_VALUE) & ~mask; int_type = ioread32(cgpio->regs + CDNS_GPIO_IRQ_TYPE) & ~mask; @@ -115,7 +115,7 @@ static int cdns_gpio_irq_set_type(struct irq_data *d, unsigned int type) iowrite32(int_type, cgpio->regs + CDNS_GPIO_IRQ_TYPE); err_irq_type: - spin_unlock_irqrestore(&chip->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&chip->bgpio_lock, flags); return ret; } From patchwork Sun Apr 17 16:52:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 563216 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDDDC433EF for ; Sun, 17 Apr 2022 16:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234478AbiDQQ5D (ORCPT ); Sun, 17 Apr 2022 12:57:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234498AbiDQQ44 (ORCPT ); Sun, 17 Apr 2022 12:56:56 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09ED2369D6; Sun, 17 Apr 2022 09:54:21 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id k12so455020ilv.3; Sun, 17 Apr 2022 09:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=52T4ey2PAbrZ4woSDAdfzc4UGJubZTXGCe7mp+PSSTY=; b=dsVqKrGYg7rYsBJvl0PxSGFLitm+Wgs65VY0cWMxGp1+oCiyljTNjOqHFmnKovHZZu 8SqUB0JoIMn6539HglLoQWw1KDUY/oIWL5AF+4XT9ptiYbJ9LaPohHwNfBQJoDEwYEff RfgPlBEf7he92/yDn+CBKkQcTHTBpY3YbjRnCYKRKMI9BOnrzZOCRqYbgdp2QdSqrEJz czorHrphAxArbQDpfMCW9C9+YDoAffCmX4GUgxanpzYh6CVK2sNtVUNPb5fz6y9HQx6o ScZIr9LX6y+WvG3dCDV0RPgYamutLiRM9wigPhgxNLWWHe/ZESxb90JD2pbjUhu2og1z 7WIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=52T4ey2PAbrZ4woSDAdfzc4UGJubZTXGCe7mp+PSSTY=; b=LK5FZKmn4hKfkqAON9UuCR2Prrdi11fq8f0r4vt33OZBwIp9N3RgfRp04KtlKnLIah JnRuIfRiHtK6rQsxHzJ6mVhstsYoMGzUekXtNJOcvNkdvhFF18hdZKJmaVq58FbzSxLy zqHmw/rkp8DDCYyRy4FIU7mrit15k//hk303xBpZM4zDAJfb/Hz8fwQe0mLOrNyHtcR0 gV5XMa3Pb/ySfTmGffVmnvXqAjWW1kT5dzPGmaH5GApJoGd433Cksdn0CWa8Z48a9U61 heHnrxbR1htQoEtEbjHVM26wIJc8CCgpwPlrAPD8zF060raTTZQguFM9soMWH/6ihPVB ciJg== X-Gm-Message-State: AOAM5317Pr3PWSdxU0N/isiNQqtyekUvf/7VQzcZ8zm3oT6MCv96sbpZ 76Jn/aEU3QDp8/2IkF3yM2E= X-Google-Smtp-Source: ABdhPJyHETgZLwVB/532u/+Od1IHuL7PgKnaZ4fBFtKdxboN2h7V5+dmOoChDkiJ8dVzyCAgu0ZzRQ== X-Received: by 2002:a92:c54e:0:b0:2c9:aa07:71b2 with SMTP id a14-20020a92c54e000000b002c9aa0771b2mr3079086ilj.257.1650214460469; Sun, 17 Apr 2022 09:54:20 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id r9-20020a6b6009000000b006412abddbbbsm6554619iog.24.2022.04.17.09.54.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:54:20 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 14/15] gpio: brcmstb: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:07 +0800 Message-Id: <20220417165208.39754-14-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-brcmstb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index 74ef89248867..6b7439b44690 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -92,9 +92,9 @@ brcmstb_gpio_get_active_irqs(struct brcmstb_gpio_bank *bank) unsigned long status; unsigned long flags; - spin_lock_irqsave(&bank->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&bank->gc.bgpio_lock, flags); status = __brcmstb_gpio_get_active_irqs(bank); - spin_unlock_irqrestore(&bank->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&bank->gc.bgpio_lock, flags); return status; } @@ -114,14 +114,14 @@ static void brcmstb_gpio_set_imask(struct brcmstb_gpio_bank *bank, u32 imask; unsigned long flags; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); imask = gc->read_reg(priv->reg_base + GIO_MASK(bank->id)); if (enable) imask |= mask; else imask &= ~mask; gc->write_reg(priv->reg_base + GIO_MASK(bank->id), imask); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); } static int brcmstb_gpio_to_irq(struct gpio_chip *gc, unsigned offset) @@ -204,7 +204,7 @@ static int brcmstb_gpio_irq_set_type(struct irq_data *d, unsigned int type) return -EINVAL; } - spin_lock_irqsave(&bank->gc.bgpio_lock, flags); + raw_spin_lock_irqsave(&bank->gc.bgpio_lock, flags); iedge_config = bank->gc.read_reg(priv->reg_base + GIO_EC(bank->id)) & ~mask; @@ -220,7 +220,7 @@ static int brcmstb_gpio_irq_set_type(struct irq_data *d, unsigned int type) bank->gc.write_reg(priv->reg_base + GIO_LEVEL(bank->id), ilevel | level); - spin_unlock_irqrestore(&bank->gc.bgpio_lock, flags); + raw_spin_unlock_irqrestore(&bank->gc.bgpio_lock, flags); return 0; } From patchwork Sun Apr 17 16:52:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Schspa Shi X-Patchwork-Id: 562957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376A3C433EF for ; Sun, 17 Apr 2022 16:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234491AbiDQQ5T (ORCPT ); Sun, 17 Apr 2022 12:57:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbiDQQ5J (ORCPT ); Sun, 17 Apr 2022 12:57:09 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 143CF27146; Sun, 17 Apr 2022 09:54:33 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id y85so2788086iof.3; Sun, 17 Apr 2022 09:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F0+uIW7FbNHXgejqXfaEwe+NSEamiwjwIvCj5cOI+QI=; b=DRI/2Qyei+WVTwSLZ3vEvl6cnKMWwO54YzAbUubaClLBH6VbbDShMmkjKOlYmcXCC6 ORxG1wU/Fi9MXw0aJXyQarrMFpRaYM+ZOrMN6asGvU2A7XCH5MRutYUKJIbzlW+mTxR7 bHA/0xULU3dRsfOw/52etSNkTS0aTRv3r939wbjPOBdaB42Bl/Do4WkimX7LvVXRtx0S qK/P0e8f7tpdj9o/WrlNXa5i/JPDrhSLterxF7VoNoWnVKTDawVUNA+Pm5mXgSpq5WE9 KDOzpOubhQXeMZ4ywkh57qPb+xt807RbCDHafY6GIh92lq2j/9pzTruM34xYagkfgi0h Y0sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F0+uIW7FbNHXgejqXfaEwe+NSEamiwjwIvCj5cOI+QI=; b=huHt+87U95Wnvv2T+K0tfeC25jDNzYRTrYgJX24rQqkYszalEa0q4LX8LpCtAeT5ox tnuRDiZEbHAn9PxGJSbUDpb/bDzNdNFDP/dQMdh8fo8BtRYRuoohKZ4btibER9/AE6RN qyqQb0egJO3CkpopcgY29nFFIbxWIQuqr+NxIGRLHCz1kBv9bh22fbilsjg1BjIaBqeG zQBPZUAQi31fQz5YrwJq21W1HiVAHbbz/FjPxOKU5juTvNzAVS/mj8em7m9TC/EC/HJG 7g3ztakfsqXWKmN2c+uUUyY0AiR5T6/i1K3uGMNvRbDox4rgCJCq8XTSJOLKUnpdpQr6 jn7A== X-Gm-Message-State: AOAM532KWSRG8SMkR7wRskpKzqe47Qud+ScXQI+aiRDBWbOdtFjMp6kS hGe4Y0Q+Cx9H9Lpq7GSSMWF/ivR7c7cE5g== X-Google-Smtp-Source: ABdhPJwZe1EqihYk67eZkXbIsb65BX3uCy7lLc1xnydlVvcfBAAsmB5eox1UKzdcdch9GHrc3w9rqw== X-Received: by 2002:a05:6602:150f:b0:64c:6878:1ec8 with SMTP id g15-20020a056602150f00b0064c68781ec8mr2985277iow.143.1650214472543; Sun, 17 Apr 2022 09:54:32 -0700 (PDT) Received: from localhost (ec2-13-59-0-164.us-east-2.compute.amazonaws.com. [13.59.0.164]) by smtp.gmail.com with UTF8SMTPSA id i81-20020a6bb854000000b00649c1b67a6csm6732443iof.28.2022.04.17.09.54.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 09:54:32 -0700 (PDT) From: Schspa Shi To: andy.shevchenko@gmail.com Cc: brgl@bgdev.pl, f.fainelli@gmail.com, fancer.lancer@gmail.com, hoan@os.amperecomputing.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, opendmb@gmail.com, schspa@gmail.com Subject: [PATCH v2 15/15] gpio: amdpt: use raw lock for bgpio_lock Date: Mon, 18 Apr 2022 00:52:08 +0800 Message-Id: <20220417165208.39754-15-schspa@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220417165208.39754-1-schspa@gmail.com> References: <20220417165208.39754-1-schspa@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bgpio_lock is changed to raw lock, fellow the header change Signed-off-by: Schspa Shi --- drivers/gpio/gpio-amdpt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-amdpt.c b/drivers/gpio/gpio-amdpt.c index 8cfb353c3abb..07c6d090058d 100644 --- a/drivers/gpio/gpio-amdpt.c +++ b/drivers/gpio/gpio-amdpt.c @@ -36,19 +36,19 @@ static int pt_gpio_request(struct gpio_chip *gc, unsigned offset) dev_dbg(gc->parent, "pt_gpio_request offset=%x\n", offset); - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); using_pins = readl(pt_gpio->reg_base + PT_SYNC_REG); if (using_pins & BIT(offset)) { dev_warn(gc->parent, "PT GPIO pin %x reconfigured\n", offset); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return -EINVAL; } writel(using_pins | BIT(offset), pt_gpio->reg_base + PT_SYNC_REG); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); return 0; } @@ -59,13 +59,13 @@ static void pt_gpio_free(struct gpio_chip *gc, unsigned offset) unsigned long flags; u32 using_pins; - spin_lock_irqsave(&gc->bgpio_lock, flags); + raw_spin_lock_irqsave(&gc->bgpio_lock, flags); using_pins = readl(pt_gpio->reg_base + PT_SYNC_REG); using_pins &= ~BIT(offset); writel(using_pins, pt_gpio->reg_base + PT_SYNC_REG); - spin_unlock_irqrestore(&gc->bgpio_lock, flags); + raw_spin_unlock_irqrestore(&gc->bgpio_lock, flags); dev_dbg(gc->parent, "pt_gpio_free offset=%x\n", offset); }