From patchwork Tue Apr 12 11:00:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 559983 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp3284494map; Tue, 12 Apr 2022 04:02:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnhlQw5JzYiD3mDDtObAIT92E1fQPFWxiL2bNvc5IdAxF8tfqP/uTW1+2XOTuBJHtW2xCl X-Received: by 2002:ae9:e316:0:b0:69c:1434:c3d1 with SMTP id v22-20020ae9e316000000b0069c1434c3d1mr2603566qkf.264.1649761372231; Tue, 12 Apr 2022 04:02:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649761372; cv=none; d=google.com; s=arc-20160816; b=NoOO8KMHrOrSe7CNZBNicz5rLMfydLQnbKKGCr44ntbHhEk1bauDWc+PKbS1DHqOPO QAxfyQ0TyzRxBLql024kJi6IP4lPCOeJ4zQvBQtyFHQbYe3sDq5/fzx6/CuasIr1Kibr I49KmtUZRnuXZzEnQae3VYha9EOKx7zByn7JsNdxEMJvAIAcOZwNNn3YUNj8MTJArRgJ VdSpos7RflvXcBUmSt3WC5EoB1UCfygZOZ70lKaey5Vfa6LFvmpZug4TFFKaLP7Cas2o Ov1fAwoTxSxFPHk58TOfgIIt+D9BwYmrWGF4RlhBtb/KMQDK3sGRuxxONrh2K9RtKBqO LzPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=ZMVXcyBhQ3fOCB18YZV7ZqOwoRtv4k/rTjqMPh4caqA=; b=f6UN8pyDc+giZNyLya6zJ8uBxwIZKOR0ontBAATA1ZoR0IBy/o+X8hViF/HCseD1fE 74W4XtQYF7Q57pgHrGsSGLxH4NpBAvYqvaMSCzn60p7I8wtCV7LWF9Ge75oVK1XVF3Jv uhM1hnw0kBrZJIqvtAZvpSbA2OcGJVx1GVOyvxg1BX+MgdgplJMXsopuTkMYgoLcSZkE foY5EyR9obgJth/JWHeWyeJin8F+RDC+QIZuhuWQEKOt8NFk5u8U6aYRUg3VYQitAKG9 4rUZovsw9N4PZhm/2RkwLtec14iGSiuf1zhr/G+ZK6gyo2nGfCzYmbRadKGKQy1RI88A An3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YHRDp+kU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t9-20020ad45bc9000000b00443d72c248esi5371505qvt.473.2022.04.12.04.02.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Apr 2022 04:02:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YHRDp+kU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neEIN-0007js-Rd for patch@linaro.org; Tue, 12 Apr 2022 07:02:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neEGt-0007iw-1G for qemu-devel@nongnu.org; Tue, 12 Apr 2022 07:01:19 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:36768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1neEGj-00042S-Ek for qemu-devel@nongnu.org; Tue, 12 Apr 2022 07:01:18 -0400 Received: by mail-wr1-x434.google.com with SMTP id u3so27176580wrg.3 for ; Tue, 12 Apr 2022 04:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZMVXcyBhQ3fOCB18YZV7ZqOwoRtv4k/rTjqMPh4caqA=; b=YHRDp+kUhp1H20xKbu9mMWCScacLOhv8t2v8KRio1m6LetmW4hz6mNjkiFg8ulYMdG Py0VC/V7a51g+YsIZKvuGL/kYKSF3QfW47de/LgxWZuG0uTLXa1DcXTBFYmX29RxhbGc VvSMVI8EneNfcCCedIZ9BmPj9Pp70/1f+PKkBaVrrykxGJVmDey8A9sgQlM+C7Xvfe28 YpLLzEKG0i9t1VoJ1i+D8xI8StyZjJ5uFf/zMv9SQ7mtJcogwm1p0B+0WjWB4VDzuwsX 2nJ5ykORFJdels5Z9AYh8Z2Z7GpAQTEDZlvUWRzXfWNDq5Tx7joT49rLAV0pwMd8cIgH 6mpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZMVXcyBhQ3fOCB18YZV7ZqOwoRtv4k/rTjqMPh4caqA=; b=xpK15QgYYDV9lFthaA3z1ln3QSAKqvYVw+GzEOFlhESGmuhHJ3a0izpsir8eikdwn2 c0McI8SuRcKlwhlYgT7u2ABTNonxeoSn++n92jDMg7AGtks3ST6fLnR2VcGp4Aeb6GhJ r4Lc4f7pM4FuVyUkqWC/dZXoG5GuKV2NgMbd2UJcVu6YpY2ikcJr/22FyT7nkshXjKqg T1hIBNe+cuej1Aw6IpkD+dvOLdrJuWft92t4d0mspd/nr+MKHG20//fXMeoVSbeaE06+ LOJ4w32o/NEvgL+4lOmIRsBk8VhFjWBXm0sshhQvZSN4XdldFKgofwkf5tO6AASJtlPD e+gQ== X-Gm-Message-State: AOAM530Zx+1WzU9nnQsjoTAD1CbSu1jt8tKEnoFPBcuYkVPdW9Sr+zff 4/WlYfJBybIAuUHdKc6dravwquiLJ75r8Q== X-Received: by 2002:a05:6000:178f:b0:207:a6d7:81b5 with SMTP id e15-20020a056000178f00b00207a6d781b5mr7448800wrg.322.1649761250377; Tue, 12 Apr 2022 04:00:50 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id e13-20020a05600c4e4d00b0038e44e316c1sm2057058wmq.6.2022.04.12.04.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 04:00:49 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH for-7.1] target/i386: Remove unused XMMReg, YMMReg types and CPUState fields Date: Tue, 12 Apr 2022 12:00:47 +0100 Message-Id: <20220412110047.1497190-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In commit b7711471f5 in 2014 we refactored the handling of the x86 vector registers so that instead of separate structs XMMReg, YMMReg and ZMMReg for representing the 16-byte, 32-byte and 64-byte width vector registers and multiple fields in the CPU state, we have a single type (XMMReg, later renamed to ZMMReg) and a single struct field (xmm_regs). However, in 2017 in commit c97d6d2cdf97ed some of the old struct types and CPU state fields got added back, when we merged in the hvf support (which had developed in a separate fork that had presumably not had the refactoring of b7711471f5), as part of code handling xsave. Commit f585195ec07 then almost immediately dropped that xsave code again in favour of sharing the xsave handling with KVM, but forgot to remove the now unused CPU state fields and struct types. Delete the unused types and CPUState fields. Signed-off-by: Peter Maydell --- target/i386/cpu.h | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 982c5323537..77b4f5696cf 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1217,20 +1217,6 @@ typedef struct SegmentCache { float64 _d_##n[(bits)/64]; \ } -typedef union { - uint8_t _b[16]; - uint16_t _w[8]; - uint32_t _l[4]; - uint64_t _q[2]; -} XMMReg; - -typedef union { - uint8_t _b[32]; - uint16_t _w[16]; - uint32_t _l[8]; - uint64_t _q[4]; -} YMMReg; - typedef MMREG_UNION(ZMMReg, 512) ZMMReg; typedef MMREG_UNION(MMXReg, 64) MMXReg; @@ -1529,11 +1515,7 @@ typedef struct CPUArchState { ZMMReg xmm_t0; MMXReg mmx_t0; - XMMReg ymmh_regs[CPU_NB_REGS]; - uint64_t opmask_regs[NB_OPMASK_REGS]; - YMMReg zmmh_regs[CPU_NB_REGS]; - ZMMReg hi16_zmm_regs[CPU_NB_REGS]; #ifdef TARGET_X86_64 uint8_t xtilecfg[64]; uint8_t xtiledata[8192];