From patchwork Fri Apr 8 16:33:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 559814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF855C433EF for ; Fri, 8 Apr 2022 16:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232165AbiDHQgP (ORCPT ); Fri, 8 Apr 2022 12:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231303AbiDHQgM (ORCPT ); Fri, 8 Apr 2022 12:36:12 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6277412635; Fri, 8 Apr 2022 09:34:08 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id s17so4242680ljp.8; Fri, 08 Apr 2022 09:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=WeJA+BxGDcYcYhLmRbFuDEBVn3+Auwoho6PRs4s0Z0/HFrQvOaauJ5hccixiPBgFeK zsJET1tUmwQ00KPMR3TrDwyCaKFCHBKVrYO/9GfRDlkTgCaIAzK0b7OoPm9GvoJqHi9N zNt9d68kstgZ4DfwnAcBWHxY0s7PHG54WIIMKP6QOz03mNlC0uWeDiABqlg7XEWsn1u9 gWe5CFN8afkdwaAv5+6cYpaPtDnVc2L6CIDZM3YOT3VOcTyGotyJA09jWCZtunoIZMcj UPGRYw4qFuGa5FK1jiI0QYyOjrAd0CsoPc83m1VeT3z2wWMYZcB6PT/5RzyEZ7SsuKrd rJeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=0lxWkz3jEcVu+RPjkS5rbh5RGQ0mLSVv31F1G/18mIQcVM5ADRTkW1kR5nCDeUjRJi jIsuRcyUILOcO2VPo4wCTP9ikTydKKflO+EUg+fLolsyDOPBNl/UlL5GtDlC2Otb62sf 7YS+Ljo1qO8GDCvDumN8R7ZjcfPdsovi0y9xiaARFqRPUjfo3Yc99DBHYEja41v0i/4C udP3y6QpuqAgwnXUxCpOzFIK22MziYsuB083bYyjpDH7lRmkqHuY6jzpCfQwTh/EOir2 gXCMjJU7KtkcFl++IsGkDGtSmaPzx1lD4v/KbKX/G9U5dBuVAugDaFegE3J7YK9d24pw EzFg== X-Gm-Message-State: AOAM533ENLcyTzyvczFm+j85FflIwOwCUvDKtcOD6WkjUXjU/Q79nyqs 3uPmMgyZrHjx5W9VjJagZzYkF9msJ7Y= X-Google-Smtp-Source: ABdhPJxaJZnhq9RjyDB4u2ZXlLfI3Mgag/FEd7yCZrO8ehvDGFn0ohYdEamIjs1eSmWIXkA7s0T5QQ== X-Received: by 2002:a2e:b0d9:0:b0:24b:4c65:5ef6 with SMTP id g25-20020a2eb0d9000000b0024b4c655ef6mr3359223ljl.275.1649435646300; Fri, 08 Apr 2022 09:34:06 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id q4-20020a0565123a8400b0044a27a8c63asm2495403lfu.80.2022.04.08.09.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 09:34:05 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Christophe JAILLET , Linus Walleij , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v4 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Fri, 8 Apr 2022 19:33:27 +0300 Message-Id: <20220408163330.200898-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220408163330.200898-1-markuss.broks@gmail.com> References: <20220408163330.200898-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Signed-off-by: Markuss Broks --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Fri Apr 8 16:33:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 559062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB11C43219 for ; Fri, 8 Apr 2022 16:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232342AbiDHQgQ (ORCPT ); Fri, 8 Apr 2022 12:36:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232317AbiDHQgP (ORCPT ); Fri, 8 Apr 2022 12:36:15 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30F0D10A971; Fri, 8 Apr 2022 09:34:11 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id j9so7908763lfe.9; Fri, 08 Apr 2022 09:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cChhgUxqUquSxt9/MV0hz1DMxqkQELGYSGZGOjKnMXY=; b=XPHg1ZZyWroe2zHgMWYnq2OaPDwRV0W/+Mg6I/WEteIPObhlP7AWhC1Y6tH+wqzwCJ AkbU77JCJfgH5J/b614F3Yk+rYiJ0kkorHjEaW+3ASqerwfjxEJiAGtKznLDdxiCij+/ BaUVr8tOs98EREPi7eVoW22wLPimRHKZhWrAiLmgNfnCzirNxbxNj409lA8POvYv5LoU SaLJ5KE3006n8MIq4j5Mvdp/5mO+V83kQMymm/57NU/8j2xC3rf+cGDQpK2GV3e2Kbak jJA/kHEA4Y8hOWKk0vZSchrP8GfNjraBdgPGxZ7iFeKT/HoI7yt7rZNmGzcyUumJajUS o1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cChhgUxqUquSxt9/MV0hz1DMxqkQELGYSGZGOjKnMXY=; b=ID04/VsYg7iRmldIu8VtFhL5xGFhDBlgmIEh50MBMEsoB/KOUnUkPI1otkjY85knkT p2mmJ/Mm9B5ByN8xymV1DUNVxjGUTUd9HfS247vERHQrZOvyu1Pgxhcw5+INV9chfOxQ zHPok3sCE4QRLKvkn9EKFPncOgG45fg3q4cjsABqbET5QwdlaJCK9ScmLOKcvXJ0B4qe E8GEFo16mM9BHLinfx/N+aooJT8QJ4d4AFzVpinCQom7qg0Ij1dhiYPl1QtsEdOfarIO phEaY6fSceyS6LkSLRnZdoQmTP1TQ4FntkEgEly2mKy5ReIvsKzL535kRvV+veXqQf+r T3gw== X-Gm-Message-State: AOAM533xyKXh/fusTnRRgymuIwUlr2SI8LcpnTvI1fmdqSezPJMF5KrE 2WqDKOnUrOoV3jqVV5PYp1Zh6c4S6N4= X-Google-Smtp-Source: ABdhPJzJm9fP7FHt9SJzUQD5SShZf1ryBdWk3MHN43jMhhAgxzXqSMavPhRjqZB0DrekOSSraMeDCA== X-Received: by 2002:a05:6512:308a:b0:44a:96cf:7ceb with SMTP id z10-20020a056512308a00b0044a96cf7cebmr13008771lfd.1.1649435649340; Fri, 08 Apr 2022 09:34:09 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id q4-20020a0565123a8400b0044a27a8c63asm2495403lfu.80.2022.04.08.09.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 09:34:08 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Linus Walleij , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v4 2/2] leds: ktd2692: Make aux-gpios optional Date: Fri, 8 Apr 2022 19:33:28 +0300 Message-Id: <20220408163330.200898-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220408163330.200898-1-markuss.broks@gmail.com> References: <20220408163330.200898-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Also pick up maintenance for the LED driver and the yaml bindings. Signed-off-by: Markuss Broks --- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 7 +++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2db49ea7ae55..8ef5667a1d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt M: John Hawley diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index f341da1503a4..26edf41dfa7d 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -284,10 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return ret; } - led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - ret = PTR_ERR_OR_ZERO(led->aux_gpio); - if (ret) { - dev_err(dev, "cannot get aux-gpios %d\n", ret); + led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS); + if (IS_ERR(led->aux_gpio)) { + dev_err(dev, "cannot get aux-gpios: %d\n", ret); return ret; }