From patchwork Fri Apr 8 17:59:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 559061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30CCC433EF for ; Fri, 8 Apr 2022 17:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238443AbiDHSBs (ORCPT ); Fri, 8 Apr 2022 14:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238438AbiDHSBr (ORCPT ); Fri, 8 Apr 2022 14:01:47 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EF4818A78E; Fri, 8 Apr 2022 10:59:42 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 17so12490885lji.1; Fri, 08 Apr 2022 10:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=ixT6s9f+Ka7pjUz6sHZM6mtC1Ve8Pz8pO73vOfWQ9DF4xBnrkPRGQZl2A/1QTb4opp 7daeuYEg9MzH2Yaj3DSgoVBqf2zuxTD0qM+dRumG2DJTynWBQ6TArq1calu2vjJ7Fq2e dMOnpLHdMr/qQcjcB5C0LdCMzeZtu+yr2DVp2WKf2s6az7JopO0ktw7m4hJq3x4gIUvM xRerSQKPOK8uR74WQ65/cliO3ujItScxuzx+msI1yyn0dlI00I8a4+znbSVrbQK8EdX0 lO8bwU/O45U1erfssdxJWndh8/K5hIK+flI40V/j63ciz7iall57m6grz4KFEJ+qXfrk 1V6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=v/s99nhJNfj9JHsm3mqZ1uSZCpUybsJAOkdPpVvLoLX0CyrRqo6xxDX2jpvzBgmuMk OSLtfVAqsi2G/71L1f++qPH/ASMGblC/OMMO6voQm45qeba+wuIEwtm8qx49GVkhp5xq MNp4BdU2KTTQYwPm11NUDRx1ttOG4cGvPG1egV9YDeBNdK7SXZmv2yNwvvJCKTLCPxUo iJpDY+QGqk3XUALCnTd+8WBHirCUqi31vXS4+uT93MV+1rXLaD9WycEbWk18RsKTv9pc Vs87gc5Cdai4cTppCxff9Zx6AUcBSBEwpoeaiI0GkYfCJLt7k6L00OJCguPyoM9Qqm+X cqKw== X-Gm-Message-State: AOAM532p7DCH5+UCY6nUl9utBiy0FOMbGcm8uH9XnuOizuXK5yiPk4ij Ks0vRriDc1u16FrfNMbuKP0KbhH/xu0= X-Google-Smtp-Source: ABdhPJyMPbZo8yYLdKduvR8Ct/tC2biBUUPqUUVK4c1Xb5eq+/i5CPJlcCPwWt+Lnd7RqDdS/T+swA== X-Received: by 2002:a2e:9545:0:b0:249:8221:86d9 with SMTP id t5-20020a2e9545000000b00249822186d9mr12508567ljh.137.1649440780426; Fri, 08 Apr 2022 10:59:40 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id p3-20020a056512312300b0046b83c2f92fsm272456lfd.58.2022.04.08.10.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 10:59:39 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Linus Walleij , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v5 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Fri, 8 Apr 2022 20:59:26 +0300 Message-Id: <20220408175929.281453-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220408175929.281453-1-markuss.broks@gmail.com> References: <20220408175929.281453-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Signed-off-by: Markuss Broks --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Fri Apr 8 17:59:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 559812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E1FC433F5 for ; Fri, 8 Apr 2022 17:59:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238483AbiDHSB6 (ORCPT ); Fri, 8 Apr 2022 14:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238445AbiDHSBw (ORCPT ); Fri, 8 Apr 2022 14:01:52 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 167D418D2B4; Fri, 8 Apr 2022 10:59:47 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id x33so9903441lfu.1; Fri, 08 Apr 2022 10:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cHwD9GpfMIl1xZZPIJHVwBE+F4ubsEa4nK0RYjRnyoU=; b=pkII27vEMBXPOVRFSuqGRql7ECxDp+6zybJkSzjSmZEB4rtpeAH6EZdLnEb6+Bf96+ +qKhP5qGpVcxxsHXCmeuF0LpyYXU4kuP3YPH1rxpvZp/TDlEp4q5Ch15ZBXWaLjFQpGf ldd7P1xXUU21YFiIm+2cWURXwjG/qotqJQEoLwMYSGFEziLoRXAD3NJ4t+hEZDWn9IoH LCO3N/g8KginyTxzgn6behS9lUZZEeyMLOBtpY6AvLeQFcl/0KZemwsd+UPI1E33gNp0 AifsI1QxH4MX4NT562J1A/f9SOPLBz1ljShdd7lQCqF4izBH1S43csxSNqgmzd/YcSP+ J4qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cHwD9GpfMIl1xZZPIJHVwBE+F4ubsEa4nK0RYjRnyoU=; b=XYF7jfqWYEEYur7zuLbMwgR6rqHdR4TAc9qC11jZgw3kSsscLVNMBv4AbYdiGS9YNP RtVLkOviODAE9u/Mu3VbELH3ytcctIzgEkbgGpPujDmq5Ey+wg4QhDBYrw3awwVr8iWn uZNP0Spwp2YKe+dfwaGZvwJQUzZFcgTAUFM4+wNIoBySI8MZyNegjROasCr5WZZWLsoA A9+HNERD79iq5gRd8c9kPx9ICvh2Z3yrcB7v9HLOK2OPxn8wGVUx7K85e0jYXIr8dcYd fVeMi2s6plTEbQqFbVy0bUQA5GSRumFO43lBK2oZruyNQ1xC/p+DDnR/gziE5Q1iZhrg D0kA== X-Gm-Message-State: AOAM53010pr0DGtsSLMH5JT20GDsTZ0eObBs4T9sMTk8QLVZ65ZCCcmr yNDYIvr1Gqv+0XQUOsFNJYWh5RMtis0= X-Google-Smtp-Source: ABdhPJx/RRusuJLg0P0+7asKI3Org4PDwmMiP5YKiDrhBMgWuH/+/AfJt98EN5DMXeDpze9HPauvVg== X-Received: by 2002:ac2:4e14:0:b0:44a:24d4:fa29 with SMTP id e20-20020ac24e14000000b0044a24d4fa29mr12746828lfr.586.1649440784643; Fri, 08 Apr 2022 10:59:44 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id p3-20020a056512312300b0046b83c2f92fsm272456lfd.58.2022.04.08.10.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 10:59:44 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Christophe JAILLET , Linus Walleij , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v5 2/2] leds: ktd2692: Make aux-gpios optional Date: Fri, 8 Apr 2022 20:59:27 +0300 Message-Id: <20220408175929.281453-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220408175929.281453-1-markuss.broks@gmail.com> References: <20220408175929.281453-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Also pick up maintenance for the LED driver and the yaml bindings. Signed-off-by: Markuss Broks --- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2db49ea7ae55..8ef5667a1d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt M: John Hawley diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index f341da1503a4..fc9c2e441caa 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -284,8 +284,8 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return ret; } - led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - ret = PTR_ERR_OR_ZERO(led->aux_gpio); + led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS); + ret = PTR_ERR(led->aux_gpio); if (ret) { dev_err(dev, "cannot get aux-gpios %d\n", ret); return ret;