From patchwork Fri Apr 8 18:40:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 558954 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B65C4332F for ; Fri, 8 Apr 2022 18:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237887AbiDHSnb (ORCPT ); Fri, 8 Apr 2022 14:43:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239157AbiDHSnY (ORCPT ); Fri, 8 Apr 2022 14:43:24 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11C551B29CF; Fri, 8 Apr 2022 11:41:20 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id q14so12552881ljc.12; Fri, 08 Apr 2022 11:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=QNUeOm09XzZP73Lq3wcRHFuJcQN6mkEoyEY1lAEpMl7sTg19gwYaWWl2KFxBd24V8X daK4vbxD0+vCTzFtp0OaD9lt/B4fNLu5dQ1DPoQn/awGT9GI60eUA9FxkBAThWZtRYr3 tZ0P1ommhO/kqYt+kuXzDJSd+3y8a83tH1NMbEfhO7kPbTwSVnWKstZ+R+hUl5Ql4CEf qoG9bD4JFFUbHsfStBp3bKLjHReqIRmdzFOfgVyMXz416dUWkoLH/9U61/6vi+qCoEr7 hWCvtnszjTaVCl3jqzs3ur2DhbPebcA9jNI3VPA67jE1KR62ECqBjt4ZemUyHNcsimtN aU+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=8K8epTvp0TscCtZ/leGNRzQTK4KE/P82StKmC1cD+hOBd+dSikm1PfM1FMwp9o3Bb5 tG5PraQ5fwPJt8pBoqN079uYb7tWoyVc9FOcOE1q10VxL7/ZOA1uhGxrfBwyGGDd/NsC onQWmH+wOY9llpoIru37eqyaMoX8mwE73ZRzvA6sUouh+AIH8q5EHNwt2FiVOAt5zKdU p1L9Qs95/M9U5LaZ9zqtmt43zOhaeHEOpM7GT0Gc4E3chNVnRKhBcZEiU8MXpQgn/IYg sLQERHTvYP8ac2zkrOUsZl9EMUkwD0Gax1mUc3IP6cuz3Yl2jbIfuELr/Obei5n7HD5p G4Bg== X-Gm-Message-State: AOAM532tHdjtT25kSSWbC9czhkOkcV9vMaHPxVh6+Pw//6t6JpH9cwsi nHFkvE4rlrZmZbxDpa4rsYif4Y7eaGo= X-Google-Smtp-Source: ABdhPJwgKQgFeF+ZHFeP+QE3KUFVa3/HJZaecCaDs6Ywxd7WknOQuItsuKhjel/tqA2/J6ZzKtUp1w== X-Received: by 2002:a2e:90d6:0:b0:246:e44:bcf6 with SMTP id o22-20020a2e90d6000000b002460e44bcf6mr12082739ljg.501.1649443278156; Fri, 08 Apr 2022 11:41:18 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id v17-20020a2e9f51000000b0024b006037eesm2301201ljk.139.2022.04.08.11.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 11:41:17 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Linus Walleij , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v6 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Fri, 8 Apr 2022 21:40:54 +0300 Message-Id: <20220408184104.13665-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220408184104.13665-1-markuss.broks@gmail.com> References: <20220408184104.13665-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Signed-off-by: Markuss Broks Reviewed-by: Rob Herring --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Fri Apr 8 18:40:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 559302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 348D0C43217 for ; Fri, 8 Apr 2022 18:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239163AbiDHSnc (ORCPT ); Fri, 8 Apr 2022 14:43:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239160AbiDHSn2 (ORCPT ); Fri, 8 Apr 2022 14:43:28 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A1ED190B77; Fri, 8 Apr 2022 11:41:24 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id p15so16517524lfk.8; Fri, 08 Apr 2022 11:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hss05uUSr3Uc3Gs0kDe2glyZ50kr35XM4twyAZx/Q7g=; b=BiLeBiNJ4IU0JKxxJwQ/+tsSbDO8w926u868ywMqvgqSx1ECrq4SQRpVmiNHU8xInz I08n30WH55Fgmj3kKdizeFitibHvWRfJ+NsJTlIyX3sdgo/gRX0ApYXQGo25hnxeJH0o IchXYwrlNxr6YCxsOjzty/dlQUst72RcEKFB94cZQmdku2lU5NqQ0A/pCZ174EZIuQ/G NDJjCwqsKNMQ+C1AgoYTSwvcopDsdbP1FuCdqKlEJCIwmJSmCRO9iZsF0b0rdGJ9aEN6 0EQEV3Si86ME/BVSZL7hEeg+9PTpDY5FO2NxDfT6C98SSDTFdo8hVrj9SYMbeD4Q8oZU GSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hss05uUSr3Uc3Gs0kDe2glyZ50kr35XM4twyAZx/Q7g=; b=3GN4UqsGcXE1so6MDu2e+4FtEXttIJ+xKHl3EY0R0TRSFXLNh8+1RR9KKZjQzi/OrO iumRqZBEPUL8Tz2lSzJkvgUMzQhEsOnAE/YeMyoRiN4sL4dFv5W6nxeRsUjs3W3E5Lq2 fk6R0OHgLZ/bEd/KmoD4XjlsJephSB5cMo1qwTCOPsSnFmCLtl5mS+hWp+6ciHN6cTuA PZqkUfBEQYLC9ONsuQ6qPRU/JjGUoueWSTg3jf8eFgRewA7/NC8UprFDY1ijRDoVB8AH n4KR9TTOqSdEWGCFU97UP1J6yX0q7Ijsa1vWxiCAHZMZy+9lChhuBrwkf1KhTeYPyC3u E2KQ== X-Gm-Message-State: AOAM533zNLFCqD/ix8ua+Fi2eTiocbWirwyyhm8l6J7zUro0geiynjKk ob4WdwLV/xEt5/+iMBiVel14pQ+0XS8= X-Google-Smtp-Source: ABdhPJy/Vqtt6+tWHlLIytsK6143rCKFf7AKlW6x1FLCTH0jDJY7ZEmgYaHrNxzFJSHIFIY2fBqhtQ== X-Received: by 2002:ac2:5619:0:b0:464:f76b:cace with SMTP id v25-20020ac25619000000b00464f76bcacemr5412057lfd.437.1649443282346; Fri, 08 Apr 2022 11:41:22 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id v17-20020a2e9f51000000b0024b006037eesm2301201ljk.139.2022.04.08.11.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 11:41:21 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Christophe JAILLET , Linus Walleij , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional Date: Fri, 8 Apr 2022 21:40:55 +0300 Message-Id: <20220408184104.13665-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220408184104.13665-1-markuss.broks@gmail.com> References: <20220408184104.13665-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Also pick up maintenance for the LED driver and the yaml bindings. Signed-off-by: Markuss Broks Reviewed-by: Andy Shevchenko --- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2db49ea7ae55..8ef5667a1d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt M: John Hawley diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index f341da1503a4..01ceea83af67 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -284,9 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return ret; } - led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - ret = PTR_ERR_OR_ZERO(led->aux_gpio); - if (ret) { + led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS); + if (IS_ERR(led->aux_gpio)) { + ret = PTR_ERR(led->aux_gpio); dev_err(dev, "cannot get aux-gpios %d\n", ret); return ret; }