From patchwork Wed Dec 5 19:50:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 152946 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp9695287ljp; Wed, 5 Dec 2018 11:51:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/WP9ROAYMGAX5j/6IcrIM2si8uGXjJd0tfuHv8ngmx/Efql2zp9FHGUf8eFVQj/X+3Q7cBp X-Received: by 2002:a63:6150:: with SMTP id v77mr21205506pgb.266.1544039476909; Wed, 05 Dec 2018 11:51:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544039476; cv=none; d=google.com; s=arc-20160816; b=xDeZMS7hP4z4D+L+uRzOKD3G8SFjYAsC1tSjpdVTyMkhYwK2rJi7+jB+msq1yIDOjj 6ycrLKGt8jcNWTWiv0BG+NGKXkMqjgsU8nUfJ6RzCyMH2FUvGkNlmjDlsaGMUUw7QRmp qISNPi01h4tuSsS9bnmJghGoA+yKfn4FE+MLSlwKz17pVxuu4jtgWK2qgwJOtUkzT+OG 0zTlC+bp/XNRrP/3FN31FWz2BPQ5ldjW+SO+ybCNOJ1eFOnjy1yZwbJfxfO5nT9fIdqS lLx9EGZPIBevdINuwgVW0Bicr1jsME6f+JrcWIfMIt2axf5c/NiE7i96cb61qlHtU4nR qbQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kV+bfkiFbMBXJunTBXrEXEZOatnnsr69uBsZeOB6vV8=; b=XsoMHNSbqqnacHu+70K7xtBjK++CQPBcpiAvLfXIc5yhQPKUpE8hm+7ZaizwfAc4vi +bmiR5coxsP+PySMY6Kzyyef/D+/qPybI1Xl2OFmRoWQ/c4zN3OQQ/ov7aQq40Ee9oj5 OlU03jFIwbCJ2WDEBB0Y3c9fwAONfhUBEBxFjCBg/S2/7+RV7+KXoEjxmw5lWf1XEBgQ O+0G2Z8WbqHeXqP8NXlYcqrXe6rdZLmORBJR8fFPVYvvCns/dCQOJZgySd6PQ0CGDYq7 lpDJ5juX+oD/yS4WlgrjaduRvuriLgdmcsK36bxEXKWex0EU4uuaz0NwqmRo800p+HD8 7xlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si19875173pgl.122.2018.12.05.11.51.16; Wed, 05 Dec 2018 11:51:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728794AbeLETvP (ORCPT + 31 others); Wed, 5 Dec 2018 14:51:15 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:46298 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728769AbeLETvN (ORCPT ); Wed, 5 Dec 2018 14:51:13 -0500 Received: by mail-oi1-f194.google.com with SMTP id x202so18596046oif.13; Wed, 05 Dec 2018 11:51:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kV+bfkiFbMBXJunTBXrEXEZOatnnsr69uBsZeOB6vV8=; b=Qf35j1AnfIusUGol2qoPYMrNlSmw53zQnAFvZSwAwqw+zVpBot2hlxER3i8BxuTdoU ZPQCVtrxPX1mRO8Skkp24Zd1wgF21enFCaUsxzpZDHpQP8GfOO+PK0GSWM50wEsKK99m j/KmQ/FBReTqnX5REbokB7N84wZoZA98jpF6wD6TkG1n6WGb1399NgXlLNSiQ0sdnJYP 4ftqGPbJrFtihBxPNs6EUPtyd3GVZB+AxKYsqtGgyAPdSjdvMk1/syyzyBxXIAWhO+ga Qpl0OKZ8qw2MuB7egxJ9ioWYs7uNEj32p0KuJU2q3W6U2L+0EOg9ML2iwxTTL0oyyUn3 +Z3A== X-Gm-Message-State: AA+aEWatSVDIf3ispLXB5K6/cYtuOZTFl6Zp8gXT61xDPoPrc8GDuS30 D1fZjs5PfjZ16FqDmtTVKkPQFms= X-Received: by 2002:a54:468b:: with SMTP id k11mr14909094oic.27.1544039472473; Wed, 05 Dec 2018 11:51:12 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id k13sm25759879otj.19.2018.12.05.11.51.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 11:51:11 -0800 (PST) From: Rob Herring To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kishon Vijay Abraham I , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH] phy: Use of_node_name_eq for node name comparisons Date: Wed, 5 Dec 2018 13:50:35 -0600 Message-Id: <20181205195050.4759-19-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For instances using of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which all of these are. Cc: Kishon Vijay Abraham I Cc: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Rob Herring --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 6 +++--- drivers/phy/rockchip/phy-rockchip-typec.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.19.1 diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 24bd2717abdb..91fba60267a0 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -1168,8 +1168,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) struct phy *phy; /* This driver aims to support both otg-port and host-port */ - if (of_node_cmp(child_np->name, "host-port") && - of_node_cmp(child_np->name, "otg-port")) + if (!of_node_name_eq(child_np, "host-port") && + !of_node_name_eq(child_np, "otg-port")) goto next_child; phy = devm_phy_create(dev, child_np, &rockchip_usb2phy_ops); @@ -1183,7 +1183,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) phy_set_drvdata(rport->phy, rport); /* initialize otg/host port separately */ - if (!of_node_cmp(child_np->name, "host-port")) { + if (of_node_name_eq(child_np, "host-port")) { ret = rockchip_usb2phy_host_port_init(rphy, rport, child_np); if (ret) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index c57e496f0b0c..e32edeebcd63 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -1176,10 +1176,10 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev) for_each_available_child_of_node(np, child_np) { struct phy *phy; - if (!of_node_cmp(child_np->name, "dp-port")) + if (of_node_name_eq(child_np, "dp-port")) phy = devm_phy_create(dev, child_np, &rockchip_dp_phy_ops); - else if (!of_node_cmp(child_np->name, "usb3-port")) + else if (of_node_name_eq(child_np, "usb3-port")) phy = devm_phy_create(dev, child_np, &rockchip_usb3_phy_ops); else