From patchwork Fri Mar 4 00:14:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 548100 Delivered-To: patch@linaro.org Received: by 2002:ac0:f585:0:0:0:0:0 with SMTP id s5csp1097235imq; Thu, 3 Mar 2022 16:16:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJz10SwYhyzyb99uKaXmuaKSJSOEHK6jgz/NNBhlPSRgOjSY8dXGerOSdH2RboWugg1Wp+IM X-Received: by 2002:a25:8c90:0:b0:627:eab0:be91 with SMTP id m16-20020a258c90000000b00627eab0be91mr29381020ybl.260.1646352980741; Thu, 03 Mar 2022 16:16:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646352980; cv=none; d=google.com; s=arc-20160816; b=OOsWJ7eBBO62U1MQKkjyhALhhGijS45zjT+xCLmDqjGAFKajBvEJgGVcGjdQvg8Cna VRgEHTOJ2QmoVST+BHVSAK6Nj6SLLJTzX2O+d3Vu18YdrDLYIUdOBFNteJsxRfPfizwH IIBgK+gwp2P+coSnoEH7H/hK98aGBEyAY1QvTy/nS6/4xy/BzZQdYRm7Kg8PPbgbe8ZY 3kB3qL/2L8G8dMk/eJx/BQ08Cdsoc1IkHCc9CRsQd62RDe24yaeJ9yZNxMbW00PYReWW +ux240ntV+sN5I6g9IHk2+Lc9o5qJoKU+OBb7SAvP+sUVi9j5bpxSYDVZfwYicoBQa7p T/qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=vaDQznwcypm1q0+tvTR4An0zuVWVPb5LLtISrx/tsEE=; b=Vn7uGj9j8bBMworMnfva37lOkZRQ/yFEeS8pp9wRqrQpDHlL0KrequVyadHAVnKMKd dlR3k825/AWiBhx+opRRTbIkp0loigxKkWUWe2A17+qLewgfIciCGzOUWE0d1g2DSKas k05DZq/jFBGPahgE66gVB3/kxzXUza8fX2bgp5lbmT/rcrWZga3PzYWorcpnq82QMp5L WBbPxXltvoTWY3/aS3cZ+sD+einxxSWXVrtA8VUU2oj+3cjH9KZBnefJ0zLyMtqp4ja+ hszBhYKseHFV5XrjkEQeS5On7jqw6+4uRN20wv14ZWM7mYZwqHQ6ErYzzUbR9wzC1ad0 kBBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=saB9QSqM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c84-20020a254e57000000b0062424c0006bsi2890299ybb.532.2022.03.03.16.16.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Mar 2022 16:16:20 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=saB9QSqM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPvcK-0003Bs-7B for patch@linaro.org; Thu, 03 Mar 2022 19:16:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPvao-0002ag-JB for qemu-devel@nongnu.org; Thu, 03 Mar 2022 19:14:46 -0500 Received: from [2607:f8b0:4864:20::102e] (port=39904 helo=mail-pj1-x102e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPvam-0006ru-QB for qemu-devel@nongnu.org; Thu, 03 Mar 2022 19:14:46 -0500 Received: by mail-pj1-x102e.google.com with SMTP id mr24-20020a17090b239800b001bf0a375440so3869308pjb.4 for ; Thu, 03 Mar 2022 16:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=vaDQznwcypm1q0+tvTR4An0zuVWVPb5LLtISrx/tsEE=; b=saB9QSqMmlMqgMstjpTMVyhqOC0cXWdukenXvCnmK1mhF4m/i5FajD9bs98ooE4iic 9EHyakBEN9EcGrOJfRW5xe5wcqCzSfXW1foU9zheLQa/4NxW7r6IqjU+Vjqc7zs5FbDv VQKw8URregnAhXYadTnzRuG+dePVphNX2jxt2nkkxRaoVwdMxsiHS02JJ38+TmBhhoWv Vnr6pPDaendRsR5HnOxHd66ynTlKPxQt35C68xmZ5qAhnpe4fO1NvErzAGTlieNng3Gg 6hr6sBKWMeH4AGpKQYQjH+pagHRZf+guEYKyh9kQ8lH7Jw04sEiJoPEwIB1cRDmwZzht C9DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=vaDQznwcypm1q0+tvTR4An0zuVWVPb5LLtISrx/tsEE=; b=F95p5KOBJRAvBt9FBE8Yc8qmAJLVDeSEeUXnEglW3irWw1T1I9vmRFjg1AkKa3cVRd dkOG8NeJ+DNO5vOroJ0ddlfC+EHtnairONBdTWTQ7uIypH+GqyS6rbVHdzRfM8mmm9Ln dGpRDG3crHCnT85asGopdawZvbVavdBl+8CCbc3veB0tf4EwKUoPj6kzXnkb3d1EjG6b P8p4tQZY0i0OPkjV+19znFwQpeLUiak6X44n+XpGJGE7p7iabABZyFOq3ID3UshwhNsV 6LiM/rDpKIycgYO4+PxkYdUSud57ig6JQ/O1Or8l30EOy4ia+nInTKFbCndQuD1H9cFg QpVA== X-Gm-Message-State: AOAM533QW10r2rE2N57hV0wHd6VBiMVPaSFPZtua8r+Z/8wGW6m76T51 22TKpadwY4BP1BiqkfCQHAXjV1Ybq3thCQ== X-Received: by 2002:a17:902:8b85:b0:150:27f1:e86 with SMTP id ay5-20020a1709028b8500b0015027f10e86mr34258951plb.88.1646352883205; Thu, 03 Mar 2022 16:14:43 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-119c-490c-a4ee-08e8.res6.spectrum.com. [2603:800c:1201:c600:119c:490c:a4ee:8e8]) by smtp.gmail.com with ESMTPSA id ip3-20020a17090b314300b001b9cb7ab96fsm3474318pjb.8.2022.03.03.16.14.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 16:14:42 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH] target/arm: Fix sve2 ldnt1 (64-bit unscaled offset) Date: Thu, 3 Mar 2022 14:14:40 -1000 Message-Id: <20220304001440.472085-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102e (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We were mapping this to ld1 (32-bit unpacked unscaled offset), which discarded the upper 32 bits of the address coming from the vector argument. Fixed by setting XS=2, which is the existing translator internal value for no extension. Update the comments, which matched the incorrect code. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/826 Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/sve.decode | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index c60b9f0fec..fd96baeb68 100644 --- a/target/arm/sve.decode +++ b/target/arm/sve.decode @@ -1576,9 +1576,9 @@ USDOT_zzzz 01000100 .. 0 ..... 011 110 ..... ..... @rda_rn_rm ### SVE2 Memory Gather Load Group # SVE2 64-bit gather non-temporal load -# (scalar plus unpacked 32-bit unscaled offsets) +# (scalar plus 64-bit unscaled offsets) LDNT1_zprz 1100010 msz:2 00 rm:5 1 u:1 0 pg:3 rn:5 rd:5 \ - &rprr_gather_load xs=0 esz=3 scale=0 ff=0 + &rprr_gather_load xs=2 esz=3 scale=0 ff=0 # SVE2 32-bit gather non-temporal load (scalar plus 32-bit unscaled offsets) LDNT1_zprz 1000010 msz:2 00 rm:5 10 u:1 pg:3 rn:5 rd:5 \