From patchwork Sun Feb 20 13:13:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahamed Husni X-Patchwork-Id: 544641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B09C433F5 for ; Sun, 20 Feb 2022 13:13:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243457AbiBTNOK (ORCPT ); Sun, 20 Feb 2022 08:14:10 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232564AbiBTNOJ (ORCPT ); Sun, 20 Feb 2022 08:14:09 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1A53BA55; Sun, 20 Feb 2022 05:13:48 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id 12so8418250pgd.0; Sun, 20 Feb 2022 05:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v3lcWy39/feSBR2awpXTCsURsclOCUkZfJp12n1k3gw=; b=Kzc1kuFvgvQ0dEq1XdjLtihLfBmtL17gacl5yN4yZAHsJqQMoutC+Dl6yLcqlyfcY+ c+vwOJFlyoGF9+3y5A6M5LpwpjDlzQaU32+/x0n7UQqzOCJFeWYIlJzUobQexR4C7T8I xAhyIQM8BF7xsxr1uKOrtK2/qOWjTlcAAECoVeVOZ4jDLbCuVavnnmVUwS1gh+zyl80f 65i5msB9/Rp6wPtXBrsDb5HB2427hb/jHKYfRNC9Vo94CKjYnO5n0yzbrszFxQ44IvLM XWqY93owYh/uB6f/sAWtVKHTGusZA37CagU8GemJm07HljbCWJGdnAP+v799LeVHtexe mOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v3lcWy39/feSBR2awpXTCsURsclOCUkZfJp12n1k3gw=; b=FKt+QAiHznyYZaL//YxnbHP2R0gIITzFJGriUPLvgrPGG9up4ZFV0VfOXl8cXE0UVc MFYjLsxhDkDta1bgwML7X71Jwyg9j0Rib3jLnGYQp548HLx5rwDx54lK01T15cwpaaVQ c+vkhOCNxXt6cxRUho9+mLG6RLbREWfS1SdIYA0GJ0iA1vX7n1GdmIBbb1923uGfWBgv aFh9TuKDIUGdULHe3rz4W2PmMxohOte4dvHIb8jaUPY1gGDIZ4X1c8m7p91V83gizHj0 sYJFhwYpj8sZ7Uu3VPpwO0ruKTYdPd44yRuQktf+BYASVlGefr+kOxFakoo3Urln19vF jQ2g== X-Gm-Message-State: AOAM533IDGhIBmg5lKtgiww4YsHeQlVeugFIRNimyuv9eY/ibbuDgSa0 Al9q8SIrr9GdKHaMIeHPwMwjffuGD9b+Bw== X-Google-Smtp-Source: ABdhPJyRrh/7e91UMMmzE/lH0U70jf28jxjhWEXCvaFRNAabc6rRwMfLWxX+edDGzGrjyeqsNz+Fbw== X-Received: by 2002:a63:1844:0:b0:36c:6a88:ad72 with SMTP id 4-20020a631844000000b0036c6a88ad72mr12416622pgy.329.1645362828150; Sun, 20 Feb 2022 05:13:48 -0800 (PST) Received: from localhost.localdomain ([116.206.246.215]) by smtp.gmail.com with ESMTPSA id s3-20020a17090a5d0300b001bc2b469051sm1419246pji.29.2022.02.20.05.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 05:13:47 -0800 (PST) From: Husni Faiz To: johan@kernel.org, gregkh@linuxfoundation.org Cc: Husni Faiz , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] usb: serial: Fix Space Prohibited Coding Style Errors Date: Sun, 20 Feb 2022 18:43:39 +0530 Message-Id: <20220220131339.179648-1-ahamedhusni73@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220212175510.521072-1-ahamedhusni73@gmail.com> References: <20220212175510.521072-1-ahamedhusni73@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch fixes "space prohibited before that ','" checkpatch error. Removed the space after the function argument value "8". Signed-off-by: Husni Faiz --- V1->V2 : Separated the style changes into multiple patches. drivers/usb/serial/iuu_phoenix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c index 0be3b5e1eaf3..2f7784572c4d 100644 --- a/drivers/usb/serial/iuu_phoenix.c +++ b/drivers/usb/serial/iuu_phoenix.c @@ -360,7 +360,7 @@ static void iuu_led_activity_on(struct urb *urb) usb_fill_bulk_urb(port->write_urb, port->serial->dev, usb_sndbulkpipe(port->serial->dev, port->bulk_out_endpointAddress), - port->write_urb->transfer_buffer, 8 , + port->write_urb->transfer_buffer, 8, iuu_rxcmd, port); usb_submit_urb(port->write_urb, GFP_ATOMIC); } @@ -380,7 +380,7 @@ static void iuu_led_activity_off(struct urb *urb) usb_fill_bulk_urb(port->write_urb, port->serial->dev, usb_sndbulkpipe(port->serial->dev, port->bulk_out_endpointAddress), - port->write_urb->transfer_buffer, 8 , + port->write_urb->transfer_buffer, 8, iuu_rxcmd, port); usb_submit_urb(port->write_urb, GFP_ATOMIC); } From patchwork Sun Feb 20 13:14:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahamed Husni X-Patchwork-Id: 544389 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262BDC433F5 for ; Sun, 20 Feb 2022 13:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238120AbiBTNPD (ORCPT ); Sun, 20 Feb 2022 08:15:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:32918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232564AbiBTNPC (ORCPT ); Sun, 20 Feb 2022 08:15:02 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 644A13C72C; Sun, 20 Feb 2022 05:14:42 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id i10so10839164plr.2; Sun, 20 Feb 2022 05:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dQJzI4pAiqIrAiK8xf/I2uFAOefNuHWrds+r7Y0sKAI=; b=K8WLbjNA5ycR3w9LmvOwdvvjkeiXak+aPyHiG6SkSdlSviSF1zMJWLYgVTrkSLuEOa t34YKn527pBGIF6TkShiLK/Fk8snv3HKRhkKpcKj7VVeYAR5oRLYiLwGHI0Jq9eE0FSj aTUtZ4AYWt1ZxgSUSETEIiZUBJwdJVck3A2PRc8OarO9UWL0b6xOFj8xeRSB8KbL12WB OHEpfo82pqCm30BLJb8MhYVQzGaBzQo1cd7J6DqES3qGzYjKNgdBwqhf/J+RQSASA6py HqQ/B4I1HsrDn5SYi+S8reyLVdZKTlnUzPeUt2tfPEheSFbzHFkUL5fwYF3AvyMjqJcp 51dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dQJzI4pAiqIrAiK8xf/I2uFAOefNuHWrds+r7Y0sKAI=; b=giQYVyP6PRP/S8HkM813DxtAJ29oaO8Uixk7s1AZ+DDIWnDlsDm+zmQT5psh/td6Np 6BB6ssf3YMTOkW9B/3x/JR1ODZFbPt0pZ7MCHGaqa0tGzgwHYos+liJEw0e7y+eCwdaX TqgSCReqm8rTUSfHZymmMswdRXliujTQJi1UIkVBi/JF7m8K8EQRyItfptRxrNB8RrGC KvJ3ajsqi/xSXGPjW8ppabwlA8vDs6ZDGHSEW5TVHbwhpigaAtGimFV7gZ8bx2GB3BTY 67HhyoGFo5V5SPX0WscLA45DK+ga3B7ty8XunrBuTAMkBLAzxl3OYrh6UCdHxvXd6rbm G1lg== X-Gm-Message-State: AOAM532o8zM+L5oV0nrJE/nQiUlJvTLJf7Yj3+W9ApOep44TAD1p6LDS wLQc4Gr5qXj4891wenYK4jiYdpIIqeKIDg== X-Google-Smtp-Source: ABdhPJz3w1igsvJNn/MOHJOWYKDvjPkoHXbYuBdOrDyg2khlwjE+3CpTWD76C8LJWbJWRh4KeL3mig== X-Received: by 2002:a17:90a:e008:b0:1b9:2e0f:1e57 with SMTP id u8-20020a17090ae00800b001b92e0f1e57mr21291546pjy.174.1645362881969; Sun, 20 Feb 2022 05:14:41 -0800 (PST) Received: from localhost.localdomain ([116.206.246.215]) by smtp.gmail.com with ESMTPSA id c68sm15593739pga.1.2022.02.20.05.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 05:14:41 -0800 (PST) From: Husni Faiz To: johan@kernel.org, gregkh@linuxfoundation.org Cc: Husni Faiz , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] usb: serial: Fix Coding Style Error Around Ternary Operator Date: Sun, 20 Feb 2022 18:44:05 +0530 Message-Id: <20220220131405.179732-1-ahamedhusni73@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220212175510.521072-1-ahamedhusni73@gmail.com> References: <20220212175510.521072-1-ahamedhusni73@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch fixes "spaces required around that '?'" checkpatch error Added a space before the "?" ternary operator. Signed-off-by: Husni Faiz --- V1->V2 : Separated the style changes into multiple patches. drivers/usb/serial/cp210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 8a60c0d56863..1fcdfb7d118c 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -1403,7 +1403,7 @@ static int cp210x_tiocmget(struct tty_struct *tty) |((control & CONTROL_RTS) ? TIOCM_RTS : 0) |((control & CONTROL_CTS) ? TIOCM_CTS : 0) |((control & CONTROL_DSR) ? TIOCM_DSR : 0) - |((control & CONTROL_RING)? TIOCM_RI : 0) + |((control & CONTROL_RING) ? TIOCM_RI : 0) |((control & CONTROL_DCD) ? TIOCM_CD : 0); dev_dbg(&port->dev, "%s - control = 0x%02x\n", __func__, control);