From patchwork Mon Nov 26 09:24:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 151997 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp5414832ljp; Mon, 26 Nov 2018 01:25:16 -0800 (PST) X-Google-Smtp-Source: AFSGD/U+SSLUXvNDgZQvV8LLBN1rtEQwLoVXklz5mZOYAFx0Qwmx/63XiFc/Qde4DWAFVrZhs1pY X-Received: by 2002:a63:e84c:: with SMTP id a12mr23757192pgk.241.1543224316762; Mon, 26 Nov 2018 01:25:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543224316; cv=none; d=google.com; s=arc-20160816; b=Y9pJ8RZpFX2c9bUVcVTks/nsFSGYVK5l2iOAfSxHbuE4++aiBo+Datf7QhXlRVerxu uP+DrN22EluAOodEUc/l1laQYmc8+tvf5O+GCCyZCiboYrEl4EkSxfSgymFnfVIN5xf/ 6G/ySuxnJHCq18KdM9J6nO8Bk/SX6GgNYiY3bi9Gb4YYUXhhkvqInWZR9MnPqnCQ0X3L 3U2ddEfhAapgx7ukyAOFHXsCrygbYcSz/KKURusguR9+QNpT/Bcgjelf+DTOaSxrK2RD nC4XmyYa0iOK7+ynZqiFlvjVYUaZzlaP79dHFUfMUZZdrF2pX0aj/mttGe58lM4a83ea 8Khg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to; bh=u6iExPE0L+wWMKPBQ8VzRGSQzpRcGpE1rN1kfxwJKQA=; b=UBvVp8yQHFnhfc11la77bRb7NG1ogjhwwOdrdQojQUEEEFN57VEHevhQW+6NlBwcWO QUCDZRmxKb9VyA1EeNBSCy6bw8ltErf2vGsCnsdGTdA3oBdbQmvcAGBarIK0wpWZyiy2 +c7OYtD7Or3y2Wr1wMuyU+/HNaekS4oTt9umtZmXf92ximYFEpoBFu54S5J7TvHhNMtg IKyIGmukYVZc88hN3U+CIB0llxK4ojBXYnubGJl2LjWpqLsppZuQ9qegsgV+0OriSbPp 3ETbSImBPk+r9DBbGnTrt3h/emrx906Di+jqBfp/roVuq6VhEW6CeRgpAHKUh/M7Dx3u x3CA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id g3-v6si50042432plt.208.2018.11.26.01.25.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 01:25:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14B1E89307; Mon, 26 Nov 2018 09:25:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0416789307 for ; Mon, 26 Nov 2018 09:25:13 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id wAQ9OwM8128613; Mon, 26 Nov 2018 03:24:58 -0600 Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wAQ9Ow5Z050012 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 26 Nov 2018 03:24:58 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 26 Nov 2018 03:24:57 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 26 Nov 2018 03:24:57 -0600 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wAQ9OtrW009699; Mon, 26 Nov 2018 03:24:56 -0600 From: Tomi Valkeinen To: , Laurent Pinchart Subject: [PATCH] drm/omap: fix bus_flags for panel-dpi Date: Mon, 26 Nov 2018 11:24:47 +0200 Message-ID: <20181126092447.11864-1-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "H . Nikolaus Schaller" , Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" panel-dpi used to convey the bus-flags via the videomode, but recent changes changed the use of videomode to DRM's drm_display_mode which does not contain bus-flags. This broke panel-dpi, which didn't explicitly store the bus-flags into dssdev->bus_flags. Fix this by setting dssdev->bus_flags. Also change the bus_flags type to u32, as that is the type used in the DRM framework, and we would get a warning with drm_bus_flags_from_videomode() otherwise. Fixes: 3fbda31e814868d8477ddf52d74b7b8f596578e8 ("drm/omap: Split mode fixup and mode set from encoder enable") Signed-off-by: Tomi Valkeinen Reported-by: H. Nikolaus Schaller Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 1 + drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index 1f8161b041be..465120809eb3 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c @@ -177,6 +177,7 @@ static int panel_dpi_probe(struct platform_device *pdev) dssdev->type = OMAP_DISPLAY_TYPE_DPI; dssdev->owner = THIS_MODULE; dssdev->of_ports = BIT(0); + drm_bus_flags_from_videomode(&ddata->vm, &dssdev->bus_flags); omapdss_display_init(dssdev); omapdss_device_register(dssdev); diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 1f698a95a94a..33e15cb77efa 100644 --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h @@ -432,7 +432,7 @@ struct omap_dss_device { const struct omap_dss_driver *driver; const struct omap_dss_device_ops *ops; unsigned long ops_flags; - unsigned long bus_flags; + u32 bus_flags; /* helper variable for driver suspend/resume */ bool activate_after_resume;