From patchwork Mon Jan 31 15:42:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 538618 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19767C433F5 for ; Mon, 31 Jan 2022 15:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242983AbiAaPmH (ORCPT ); Mon, 31 Jan 2022 10:42:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:22269 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236278AbiAaPmH (ORCPT ); Mon, 31 Jan 2022 10:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1sW7rzPQhozZJd5bIGL105H+ak+PyChDVEsMpXF5SsA=; b=cG8Dn2Z2l5t041xxWBFu0uYyJmYiz+myZAIv80YS30B6xrHrwx7tcX4wpMY7uEm9YzYWci VPbc6GHkq6ckPJ5klvNUMCoaWkbg1nMgW9KxRMTW7osuhudnIsOPzwB9XuDpfwWUNVBuwo hAk+Na2aF0Bjb2JpkU6hN2L/ixYuBTM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-249-e3YW6kMOO66Ewrn53KQLWg-1; Mon, 31 Jan 2022 10:42:05 -0500 X-MC-Unique: e3YW6kMOO66Ewrn53KQLWg-1 Received: by mail-wm1-f70.google.com with SMTP id q125-20020a1c4383000000b003503e10c027so3092366wma.2 for ; Mon, 31 Jan 2022 07:42:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1sW7rzPQhozZJd5bIGL105H+ak+PyChDVEsMpXF5SsA=; b=X0QgF1DxpIurqHeGs/66E+dCFEHtNcDzHUFuk+QGuMSI/mDNkxE66M7TEM2760TOeV h956blxuXA2vCcdQ1FAUBHp6JVLKkmJIeHeTjk3CZsoFouWAx1IhhVqD2qSbkViHqTfN aQm0bnPQJYOkubH/SoZK1JggXeMBHKURzOfkUJlU3KB6myfPTwmo8TSjdBZ9jwqRKofW CZRL/KIoKPI9PzaihdzUV57O3F7JfTkfim3VYfxJEigZrRcf03ANqkwBbL9Pgr0YJb9/ BH1FwNgdxwMT/yoXNUW6ZIrm97ha/eFNYExQtqqzudqgkO0ufQQf2mNNX4gn6ksEfthm fFPQ== X-Gm-Message-State: AOAM531+BUMprClkcrlc2ejLoXn+cnBThnH1gD4f6m3751oH58hwBf+W uLcJeuuydmKriEkHrT6ZWCC8eNIjr1ne0JjCc3jAg5sIZFYCXqOC5vkjNkViLVwRuwbf7YfSCy9 oF4ll0jU/8WLB8T3yduEjUTXUI9VU X-Received: by 2002:a05:600c:4606:: with SMTP id m6mr18884793wmo.158.1643643724082; Mon, 31 Jan 2022 07:42:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxby5+LXKmhGyrUYjq8E3JvF/Tb4DHqOiKvlAvELRnZXgXmO2oDHs3fV9s7zGDIfs9YNcWdTw== X-Received: by 2002:a05:600c:4606:: with SMTP id m6mr18884782wmo.158.1643643723938; Mon, 31 Jan 2022 07:42:03 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id p17sm12454713wrf.112.2022.01.31.07.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:03 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:01 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 1/4] selftests: fib rule: Make 'getmatch' and 'match' local variables Message-ID: <6c58c82747ac8351105a0d25eefc594206d414d6.1643643083.git.gnault@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Let's restrict the scope of these variables to avoid possible interferences. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 43ea8407a82e..f04f337dd7c6 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -115,6 +115,9 @@ fib_rule6_test_match_n_redirect() fib_rule6_test() { + local getmatch + local match + # setup the fib rule redirect route $IP -6 route add table $RTABLE default via $GW_IP6 dev $DEV onlink @@ -184,6 +187,9 @@ fib_rule4_test_match_n_redirect() fib_rule4_test() { + local getmatch + local match + # setup the fib rule redirect route $IP route add table $RTABLE default via $GW_IP4 dev $DEV onlink From patchwork Mon Jan 31 15:42:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 539980 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F139BC433FE for ; Mon, 31 Jan 2022 15:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379783AbiAaPmK (ORCPT ); Mon, 31 Jan 2022 10:42:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:23542 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350284AbiAaPmK (ORCPT ); Mon, 31 Jan 2022 10:42:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hkxchTylyBIw36KxB2bjQj4NjTJ8gEN7NWBvja/ptEI=; b=OtgrpUGvsyy2TZRhrjCjDfrMqRL3pJE9NqjoBlqkwIosAY+5OPsm3AOUqkcZ/2cCD+FCm6 0g9EsnFuSn7jds4Sj4r5Zf1w0qmIZ7Dk86CukO6jaWzuewCsZ/jSyVtVr06ZEukX25IMf3 hngVqQaopH5dvbaVKT0lfHzD+lKCnM0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-541-y1rtsdR2MDuhadJgqkeJZw-1; Mon, 31 Jan 2022 10:42:07 -0500 X-MC-Unique: y1rtsdR2MDuhadJgqkeJZw-1 Received: by mail-wr1-f70.google.com with SMTP id x4-20020adfbb44000000b001d83e815683so4955474wrg.8 for ; Mon, 31 Jan 2022 07:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hkxchTylyBIw36KxB2bjQj4NjTJ8gEN7NWBvja/ptEI=; b=EgP1kIrWRau95J5tkARuDNwoqn+FnhtieYKQr4qz6g4MYsGPWiQKB1iCP0rnpPyBfB C5vejaAPfuNPc3meDqgLHdrHn+WT9NHsvLLmoiKqHbuyX1YkiCw2uoQPMhzH8OfOb7On 9eaJNfkLS+tlJNbxlA0D65CTAqRw7IpEnvdxdAr5Trv2pZr3Q+tZyDuvsaN/JXn286iZ JqEbP7FBGq5flfuu5oaeFQVzYIP0aZi6h8EjaeFCmGDetRV+3vAYeC67v5LH3UeZHi+z WWpg3Nabpj/dOKWjB59X8nUDFp0FV1P6WMNf/L2OcizMG3qzj1tdMaK9HruFHgRU4L4z hZeg== X-Gm-Message-State: AOAM5304EToDRkM25TUx/Lm+X/DetwA8mCl/4q+eczkiy+2oyaVddTSH PGvJ/UzQYuFcWAZQA3bA6T677/wKOkbafdJz2DyMEPgV6PkniANv9ZP/efjgG4ouT2R69QVlR+8 y6Lrk9NcPOgCdyOHnNJJyhIgO+oaT X-Received: by 2002:adf:9dc6:: with SMTP id q6mr17692038wre.679.1643643726601; Mon, 31 Jan 2022 07:42:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1DwCI3Fw2wTecxht4WC3IQ8a5vpBieNVHkhHesxDAYIX779C8wLRFnFWyOh+KqnTZ7JI11A== X-Received: by 2002:adf:9dc6:: with SMTP id q6mr17692030wre.679.1643643726417; Mon, 31 Jan 2022 07:42:06 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id i9sm14449262wry.32.2022.01.31.07.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:06 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:04 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 2/4] selftests: fib rule: Drop erroneous TABLE variable Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org The fib_rule6_del_by_pref() and fib_rule4_del_by_pref() functions use an uninitialised $TABLE variable. They should use $RTABLE instead. This doesn't alter the result of the test, as it just makes the grep command less specific (but since the script always uses the same table number, that doesn't really matter). Let's fix it anyway and, while there, specify the filtering parameters directly in 'ip -X rule show' to avoid the extra grep command entirely. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index f04f337dd7c6..012f9385d68c 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -96,7 +96,7 @@ fib_rule6_del() fib_rule6_del_by_pref() { - pref=$($IP -6 rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1) + pref=$($IP -6 rule show $1 table $RTABLE | cut -d ":" -f 1) $IP -6 rule del pref $pref } @@ -168,7 +168,7 @@ fib_rule4_del() fib_rule4_del_by_pref() { - pref=$($IP rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1) + pref=$($IP rule show $1 table $RTABLE | cut -d ":" -f 1) $IP rule del pref $pref } From patchwork Mon Jan 31 15:42:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 538617 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E61C4332F for ; Mon, 31 Jan 2022 15:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379258AbiAaPmN (ORCPT ); Mon, 31 Jan 2022 10:42:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29964 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379784AbiAaPmM (ORCPT ); Mon, 31 Jan 2022 10:42:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slqi+eFgPyIV91fplcPLPuJfZVr8h1BVcJVDtOG3dfs=; b=WmGC0IhVsqq2Fjvuq0HxWAuxybYAeYyTO95UpsAmDGJYNTW6ZcnEaUwhgZxd2cqeyIgKWc zxjoHdIdiauyWzLtOXLDFnE3SmIPQoQACPxRYV02OBYN/o9sxRTpzuDIN6ZMYz92iKy/iU TOwD6Y7e9jYWTGMTpePNmwNWlvvIdJE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-96-R04qHEVNNs-ZvnGfiqSLjQ-1; Mon, 31 Jan 2022 10:42:10 -0500 X-MC-Unique: R04qHEVNNs-ZvnGfiqSLjQ-1 Received: by mail-wr1-f72.google.com with SMTP id x4-20020adfbb44000000b001d83e815683so4955538wrg.8 for ; Mon, 31 Jan 2022 07:42:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=slqi+eFgPyIV91fplcPLPuJfZVr8h1BVcJVDtOG3dfs=; b=vh8NjKQkHiWbBWYLJ8izM7Npc1y1lUYygu4HrtXM+9gz6y0bdkY0w2vuZelhXUKr/s NDR2wR+22rjdaYCjhk8HQRTOeRXPFdfc8KtdYSPsDmWqtqVGq8f0wVLdMR3lBzSKX9vL wzXJNPE7uw8/vMh1KEmH9K2j6deIHxpjYJn/rFwUMewiJTCHttmCFsMfn+KoYPWqAmgV QGSaqttFfCKgs2rkoCk7lPlJEYj1QV7s4OJQ5Go7vi//6W4bRFETYOs1JGWkxqiqzfP8 xsr1NU24/LKP+8Uv6VjsTRezeDsiWD7r02rUnToaLUmtYG+5j2pCpTesSoY1k4CdNYsK UbiQ== X-Gm-Message-State: AOAM5311bJGTsbW6LJVuYXVR+DNHyezhSLjApkUkdtwxEkGm0tDxQv0K y6QOr6kViKJBROpAHRN94r2zNKDHGpyyDZ/+fKXwzAEKjE1Dq98gKmgJHO2pD1c85/22fOU3oyB oI9/15Z5urW07QgcG9Sh5VaXNhFPl X-Received: by 2002:a05:600c:3217:: with SMTP id r23mr18796169wmp.159.1643643728867; Mon, 31 Jan 2022 07:42:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMLn8ts+Ww3+PnE/eJvxpKnuFYaYejpPPPVrdfW9EaLvIgjdFDBxVx65LUYPgD/7F0PC720g== X-Received: by 2002:a05:600c:3217:: with SMTP id r23mr18796158wmp.159.1643643728737; Mon, 31 Jan 2022 07:42:08 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id p8sm13210073wrr.16.2022.01.31.07.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:08 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:06 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 3/4] selftests: fib rule: Log test description Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org All callers of fib_rule6_test_match_n_redirect() and fib_rule4_test_match_n_redirect() pass a third argument containing a description of the test being run. Instead of ignoring this argument, let's use it for logging instead of printing a truncated version of the command. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 012f9385d68c..6a05e81fc81d 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -104,13 +104,14 @@ fib_rule6_test_match_n_redirect() { local match="$1" local getmatch="$2" + local description="$3" $IP -6 rule add $match table $RTABLE $IP -6 route get $GW_IP6 $getmatch | grep -q "table $RTABLE" - log_test $? 0 "rule6 check: $1" + log_test $? 0 "rule6 check: $description" fib_rule6_del_by_pref "$match" - log_test $? 0 "rule6 del by pref: $match" + log_test $? 0 "rule6 del by pref: $description" } fib_rule6_test() @@ -176,13 +177,14 @@ fib_rule4_test_match_n_redirect() { local match="$1" local getmatch="$2" + local description="$3" $IP rule add $match table $RTABLE $IP route get $GW_IP4 $getmatch | grep -q "table $RTABLE" - log_test $? 0 "rule4 check: $1" + log_test $? 0 "rule4 check: $description" fib_rule4_del_by_pref "$match" - log_test $? 0 "rule4 del by pref: $match" + log_test $? 0 "rule4 del by pref: $description" } fib_rule4_test() From patchwork Mon Jan 31 15:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 539979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999EEC433F5 for ; Mon, 31 Jan 2022 15:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379792AbiAaPmR (ORCPT ); Mon, 31 Jan 2022 10:42:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30594 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379784AbiAaPmP (ORCPT ); Mon, 31 Jan 2022 10:42:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1JlgLZscDoIFop5dBhXgA1KNuotqIeX45MP+1J3nAYY=; b=YeFsNng0zShieqie30KAPYmGtfDhnkTyhyjyaoxkaXQDD6rUrPOC4gPkKFjm/x6O+QoZnw Y6lLduTuQsnWqJLcTWbcw8QaBT5tS/9hMGpBTCMR5owlN/CF3Gq40ppbzNV4BN9es2qNEQ lcf8VhOXfLzbJ40+C7ex1hSZJsZlsf0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-7LTfXTbKPWq2gqfrPVYOfg-1; Mon, 31 Jan 2022 10:42:13 -0500 X-MC-Unique: 7LTfXTbKPWq2gqfrPVYOfg-1 Received: by mail-wr1-f72.google.com with SMTP id r2-20020adfa142000000b001e176ac1ec3so803031wrr.3 for ; Mon, 31 Jan 2022 07:42:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1JlgLZscDoIFop5dBhXgA1KNuotqIeX45MP+1J3nAYY=; b=DQcHFFCZ4OEMZHaXh2p8M9TGolC7WEm/0jDc4RObnKSIOYL/08+ePjEBuehfKd//Bk mJpQGJZbDflq5rLzidgKpv77dr3bEHR8Ook0ivaIw1hqbybMKFEF/mGG45ZSN3J2eHzD 7LOejUggFW2JU0f7clP3s56hWg6bbvvft8wTVswfClvHyqbCuqgJf2FtKVtKy5KAxSqS zXDWYr+2uDfpWdLcSpAD2h+ke5eo5t7j6RYD8PDPSDwJqSotXU9+RhIZEBi1tYHH5Cdx 1Nw8YxScE3+LKFK5/W52CbTIceu/Im9DvLaP2UOrU/fN/N7laJtbAS1DWDSrhXMurQe6 oEqA== X-Gm-Message-State: AOAM533eibZARLsge7X9LakpaOZJL9ZFI+Iz6NVVI94B1wus6y2jNbza tNvU7vbTz8tGEzzzTuL09n/A1VX0ecCpXbIw0td+OJTO5KsTeLGzoAKG89jB9bvReE4Qm7cUYPo qXGi4ND/t9zKod+uhEMv5sUAB8g80 X-Received: by 2002:a05:6000:15c5:: with SMTP id y5mr19027261wry.656.1643643731549; Mon, 31 Jan 2022 07:42:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJygQlVQ+YgRpR5xEHj4gvtNZSfcyjb7bmNGvYeSOgWRfcZ4vdWME0LKdI1icjsxp88B6wNo3A== X-Received: by 2002:a05:6000:15c5:: with SMTP id y5mr19027244wry.656.1643643731344; Mon, 31 Jan 2022 07:42:11 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id f13sm10379789wmq.29.2022.01.31.07.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:10 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:09 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu , Hangbin Liu Subject: [PATCH net-next 4/4] selftests: fib rule: Don't echo modified sysctls Message-ID: <6baa96248e33682166fa295ec98a472d02f4767a.1643643083.git.gnault@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Run sysctl in quiet mode. Echoing the modified sysctl doesn't bring any useful information. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 6a05e81fc81d..3b0489910422 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -200,11 +200,11 @@ fib_rule4_test() # need enable forwarding and disable rp_filter temporarily as all the # addresses are in the same subnet and egress device == ingress device. - ip netns exec testns sysctl -w net.ipv4.ip_forward=1 - ip netns exec testns sysctl -w net.ipv4.conf.$DEV.rp_filter=0 + ip netns exec testns sysctl -qw net.ipv4.ip_forward=1 + ip netns exec testns sysctl -qw net.ipv4.conf.$DEV.rp_filter=0 match="from $SRC_IP iif $DEV" fib_rule4_test_match_n_redirect "$match" "$match" "iif redirect to table" - ip netns exec testns sysctl -w net.ipv4.ip_forward=0 + ip netns exec testns sysctl -qw net.ipv4.ip_forward=0 match="tos 0x10" fib_rule4_test_match_n_redirect "$match" "$match" "tos redirect to table"