From patchwork Tue Nov 20 12:35:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 151584 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp613912ljp; Tue, 20 Nov 2018 05:38:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/UViOSOgh4PXB6ui4iH6oLXhKTNAnVfqFJrzjdnZbgWTA9Xs3pB2H3ZSl7zdLT7ULkP0w7u X-Received: by 2002:a25:9b83:: with SMTP id v3-v6mr1818271ybo.13.1542721100128; Tue, 20 Nov 2018 05:38:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542721100; cv=none; d=google.com; s=arc-20160816; b=ecF8tF5UoLV5dZrh6UggO8m3QG3HB18l/WgoU3Uc6wOLumsBaC9xZqfoDDh4hmexWX xGytSPCYOkrse8Y2iFJrGOm+CEF1huhl7uUmM/D6irzrBILpRnjCGemDXMCR6WowzV7s D5jNbFBM7qgO1jcOQnxTg+oSSDE9hmt3u9UkpARX7BlPAwaOP25AjQuXULZ+W1ivFc3/ bCFxY2BIbpAPxbGyh+zwgJ9RsX/T8XSKst0gEsdAvTb0n16gQIB2Ru3458CaAFgSf15/ RoSS86T/sBws7adwJNfHHt/7KkdKzjd/JnGr50v77m+Ql30/hfMym09ZjJa92CK6lgR2 v+rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=JrnuX0gzsdDZ8qimkpHEhhaGpZq5WczIjjxaFtfaDXY=; b=ABks1FEpIw+sgdrOjWqGRZZgt/m5u1mszlmuuzk0xgqZtCmZHwlhBO4bPb54Wb6leq 7KNcQYZn2RJ9M/zwJ/qqeW6v4t2FQU5WOglAcmHKKFB1NatsRcxJ8n8G4vf4NDbOWgZQ eh8NxVLTC+RwziobDKI3xG0pcHIYUpFB7UFTHPx0teIlElMJHb/TM0EXnntOTkoZvjcs XJNdZgu2hn7BmI0/iPtp20R77MmYwzFy0BgsSlw4dcndNqBROYqUydc6uS2+mRezgskL 66SxI3OfGRBnegv+gE14p+A99TUpLMvtIks4wcGO0z9VxpJlrna0OL6aAxe12JZcez4n 1w0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Cw2kc0Us; spf=pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="grub-devel-bounces+patch=linaro.org@gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id p14-v6si281227ybk.212.2018.11.20.05.38.19 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Nov 2018 05:38:20 -0800 (PST) Received-SPF: pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Cw2kc0Us; spf=pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="grub-devel-bounces+patch=linaro.org@gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP6EN-00079x-E4 for patch@linaro.org; Tue, 20 Nov 2018 08:38:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP5Fs-0001jM-46 for grub-devel@gnu.org; Tue, 20 Nov 2018 07:35:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP5Fn-00075b-4Y for grub-devel@gnu.org; Tue, 20 Nov 2018 07:35:48 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:43249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP5Fm-000759-Me for grub-devel@gnu.org; Tue, 20 Nov 2018 07:35:43 -0500 Received: by mail-wr1-x433.google.com with SMTP id r10so1783862wrs.10 for ; Tue, 20 Nov 2018 04:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TtG1M+ay7fWB56OaVMBJOz6BZLrx7oyznwlpL+lNhgM=; b=Cw2kc0UshrkIgIdtrWc04xfPYWiaGH/f/F+FcsOe9xMoahmyPAzBVIYQxcXz5gBKI8 E7yx2XJ5PhqDmmuQUChTtBzMY3pIb2PsMLywtATYqziq6n8cM3nhpKbaJr0ABo3+dTHl GY6JioBdLiNXk0wjAF7qbn6VqsyVmu/pN4jPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TtG1M+ay7fWB56OaVMBJOz6BZLrx7oyznwlpL+lNhgM=; b=TyPwEslI/3ykGiNDpMJPoGLkF87fuXdD9dfullMmi+hLsZAFZpifyPFHQdfvWsF9br xOzQUKsmxityFW6MFXzwLg4X57p6GbhUMC9zLCmrzIS65Yt9/Lh/Fx9Y6xl8ZN/7NHcE uoUzsHEIlWwxXUBzRuNK8Uqu1lcThL1vlZNP+iVNP2V3746yL/jq2yJzO5zYgr6iZtSM LTzn65RbusU+Xy01/YqJrblnQA+MTH9BZCi1fVnoGIWSeb+ALpNQwpIU71Ulh7vL35zS E9gvNwZnGAJQYKBySSI9qLpynPvUn8lgpK5pCzQvVTEqPTbk/oo49DWjt9pvNxm996ax JtJw== X-Gm-Message-State: AA+aEWY45A56fZ//k3YUPIn11utBYeb4YJGicD7q5jZ12pf3kuGfXWN+ GYDbCzaYllrow2OjWo6csEL/OA== X-Received: by 2002:adf:9786:: with SMTP id s6mr1810445wrb.283.1542717341287; Tue, 20 Nov 2018 04:35:41 -0800 (PST) Received: from dell ([2.31.167.205]) by smtp.gmail.com with ESMTPSA id y81-v6sm28384771wmd.11.2018.11.20.04.35.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 04:35:40 -0800 (PST) Date: Tue, 20 Nov 2018 12:35:39 +0000 From: Lee Jones To: Daniel Kiper Subject: [PATCH v3 (part 1)] arm64/xen: =?utf-8?q?Fix_implicit_declaration?= =?utf-8?q?_of_function_=E2=80=98grub=5Ffile=5Ffilter=5Fdisable=5Fc?= =?utf-8?q?ompression=27?= Message-ID: <20181120123538.GV3513@dell> References: <20181114192919.24655-1-leif.lindholm@linaro.org> <20181116140737.wuox7v63y6lt2ymt@tomti.i.net-space.pl> <20181120104656.GN3513@dell> <20181120113819.GS3513@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181120113819.GS3513@dell> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::433 X-Mailman-Approved-At: Tue, 20 Nov 2018 08:36:40 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Cc: The development of GNU GRUB , Julien Grall , Leif Lindholm , Fu Wei Fu Errors-To: grub-devel-bounces+patch=linaro.org@gnu.org Sender: "Grub-devel" From: Lee Jones arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression' Without this fix, building xen_boot.c emits: loader/arm64/xen_boot.c:433:5: error: implicit declaration of function ‘grub_file_filter_disable_compression’; did you mean ‘grub_file_filter_unregister’? [-Werror=implicit-function-declaration] grub_file_filter_disable_compression (); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ grub_file_filter_unregister loader/arm64/xen_boot.c:433:5: error: nested extern declaration of ‘grub_file_filter_disable_compression’ [-Werror=nested-externs] Signed-off-by: Lee Jones diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c index 7d1adce1b..a01792a72 100644 --- a/grub-core/loader/arm64/xen_boot.c +++ b/grub-core/loader/arm64/xen_boot.c @@ -429,9 +429,9 @@ grub_cmd_xen_module (grub_command_t cmd __attribute__((unused)), grub_dprintf ("xen_loader", "Init module and node info\n"); - if (nounzip) - grub_file_filter_disable_compression (); - file = grub_file_open (argv[0], GRUB_FILE_TYPE_LINUX_KERNEL); + file = grub_file_open (argv[0], GRUB_FILE_TYPE_LINUX_KERNEL + | (nounzip ? GRUB_FILE_TYPE_NO_DECOMPRESS + : GRUB_FILE_TYPE_NONE)); if (!file) goto fail;